[INFO] cloning repository https://github.com/rejoinrobloxd/check-online [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rejoinrobloxd/check-online" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frejoinrobloxd%2Fcheck-online", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frejoinrobloxd%2Fcheck-online'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ce777015491bd6955926c2e0027cf541fe130fb6 [INFO] linting rejoinrobloxd/check-online/ce777015491bd6955926c2e0027cf541fe130fb6 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frejoinrobloxd%2Fcheck-online" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/rejoinrobloxd/check-online [INFO] finished tweaking git repo https://github.com/rejoinrobloxd/check-online [INFO] tweaked toml for git repo https://github.com/rejoinrobloxd/check-online written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rejoinrobloxd/check-online on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rejoinrobloxd/check-online already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded async-net v2.0.0 [INFO] [stderr] Downloaded endi v1.1.0 [INFO] [stderr] Downloaded tabled_derive v0.7.0 [INFO] [stderr] Downloaded ping-rs v0.1.2 [INFO] [stderr] Downloaded figlet-rs v0.1.5 [INFO] [stderr] Downloaded rfd v0.14.1 [INFO] [stderr] Downloaded ashpd v0.8.1 [INFO] [stderr] Downloaded windows v0.43.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e932e4a2f8fcd12bfc0133e56e39b8fcdb8662e41a456e02b59778f4ed7c3ca4 [INFO] running `Command { std: "docker" "start" "-a" "e932e4a2f8fcd12bfc0133e56e39b8fcdb8662e41a456e02b59778f4ed7c3ca4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e932e4a2f8fcd12bfc0133e56e39b8fcdb8662e41a456e02b59778f4ed7c3ca4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e932e4a2f8fcd12bfc0133e56e39b8fcdb8662e41a456e02b59778f4ed7c3ca4", kill_on_drop: false }` [INFO] [stdout] e932e4a2f8fcd12bfc0133e56e39b8fcdb8662e41a456e02b59778f4ed7c3ca4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] da08f4e02d39fe4d84dd88ae063f6f07d0cd2ae685d003f2e1cf8d22060fac75 [INFO] running `Command { std: "docker" "start" "-a" "da08f4e02d39fe4d84dd88ae063f6f07d0cd2ae685d003f2e1cf8d22060fac75", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.110 [INFO] [stderr] Compiling icu_properties_data v2.1.1 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling winnow v0.7.13 [INFO] [stderr] Compiling toml_datetime v0.7.3 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Compiling indexmap v2.12.0 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking mio v1.1.0 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Compiling cc v1.2.46 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Checking endi v1.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking bytecount v0.6.9 [INFO] [stderr] Compiling rfd v0.14.1 [INFO] [stderr] Checking papergrid v0.11.0 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking async-fs v2.2.0 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking pollster v0.3.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking sysinfo v0.30.13 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking figlet-rs v0.1.5 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Compiling tabled_derive v0.7.0 [INFO] [stderr] Compiling toml_parser v1.0.4 [INFO] [stderr] Checking tabled v0.15.0 [INFO] [stderr] Compiling toml_edit v0.23.7 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling stability v0.2.1 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking ratatui v0.26.3 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking ping-rs v0.1.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking zvariant v4.2.0 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking ashpd v0.8.1 [INFO] [stderr] Checking check_online v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use crossterm; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use crossterm; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/check/phase/phase3.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | / ... if let Some(count) = json["count"].as_i64() { [INFO] [stdout] 30 | | ... Some((id, count)) [INFO] [stdout] 31 | | ... } else { [INFO] [stdout] 32 | | ... None [INFO] [stdout] 33 | | ... } [INFO] [stdout] | |_______________________^ help: try: `json["count"].as_i64().map(|count| (id, count))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/check/phase/phase3.rs:46:47 [INFO] [stdout] | [INFO] [stdout] 46 | for (_, handle) in handles.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 46 - for (_, handle) in handles.into_iter().enumerate() { [INFO] [stdout] 46 + for handle in handles.into_iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/check/filter.rs:31:53 [INFO] [stdout] | [INFO] [stdout] 31 | data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c <= max)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 31 - data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c <= max)); [INFO] [stdout] 31 + data.final_ids.retain(|&id| data.friends_count.get(&id).is_some_and(|&c| c <= max)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/check/filter.rs:39:54 [INFO] [stdout] | [INFO] [stdout] 39 | let parts: Vec<&str> = val_input.trim().split_whitespace().collect(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/check/filter.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | / if parts.len() == 2 { [INFO] [stdout] 41 | | if let (Ok(min), Ok(max)) = (parts[0].parse::(), parts[1].parse::()) { [INFO] [stdout] 42 | | data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c >= min && c <= max)); [INFO] [stdout] 43 | | } [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 40 ~ if parts.len() == 2 [INFO] [stdout] 41 ~ && let (Ok(min), Ok(max)) = (parts[0].parse::(), parts[1].parse::()) { [INFO] [stdout] 42 | data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c >= min && c <= max)); [INFO] [stdout] 43 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/check/filter.rs:42:57 [INFO] [stdout] | [INFO] [stdout] 42 | ... data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c >= min && c <= max)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 42 - data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c >= min && c <= max)); [INFO] [stdout] 42 + data.final_ids.retain(|&id| data.friends_count.get(&id).is_some_and(|&c| c >= min && c <= max)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/check/filter.rs:52:53 [INFO] [stdout] | [INFO] [stdout] 52 | data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c >= min)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 52 - data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c >= min)); [INFO] [stdout] 52 + data.final_ids.retain(|&id| data.friends_count.get(&id).is_some_and(|&c| c >= min)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/check/filter.rs:65:94 [INFO] [stdout] | [INFO] [stdout] 65 | println!("{}", tabled::Table::new(&rows).with(tabled::settings::Style::rounded()).to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/check/main.rs:74:78 [INFO] [stdout] | [INFO] [stdout] 74 | println!("{}", Table::new(&rows).with(tabled::settings::Style::rounded()).to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/check_realtime/utils.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / if let Some(space_pos) = after_epyc.find(' ') { [INFO] [stdout] 29 | | if let Some(num_start) = after_epyc[space_pos..].find(|c: char| c.is_ascii_digit()) { [INFO] [stdout] 30 | | let num_part = &after_epyc[space_pos + num_start..]; [INFO] [stdout] 31 | | let end = num_part.find(|c: char| !c.is_ascii_digit() && c != '-' && c != ' ').unwrap_or(num_part.len()); [INFO] [stdout] ... | [INFO] [stdout] 34 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 28 ~ if let Some(space_pos) = after_epyc.find(' ') [INFO] [stdout] 29 ~ && let Some(num_start) = after_epyc[space_pos..].find(|c: char| c.is_ascii_digit()) { [INFO] [stdout] 30 | let num_part = &after_epyc[space_pos + num_start..]; [INFO] [stdout] 31 | let end = num_part.find(|c: char| !c.is_ascii_digit() && c != '-' && c != ' ').unwrap_or(num_part.len()); [INFO] [stdout] 32 | return format!("EPYC {}", num_part[..end].trim()); [INFO] [stdout] 33 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/check_realtime/utils.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / if ch == 'I' { [INFO] [stdout] 55 | | if let Some(next_ch) = after_core_upper.chars().nth(i + 1) { [INFO] [stdout] 56 | | if next_ch.is_ascii_digit() { [INFO] [stdout] 57 | | let i_part = &after_core[i..]; [INFO] [stdout] ... | [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 54 ~ if ch == 'I' [INFO] [stdout] 55 ~ && let Some(next_ch) = after_core_upper.chars().nth(i + 1) { [INFO] [stdout] 56 | if next_ch.is_ascii_digit() { [INFO] [stdout] ... [INFO] [stdout] 65 | } [INFO] [stdout] 66 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/check_realtime/utils.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | / if let Some(next_ch) = after_core_upper.chars().nth(i + 1) { [INFO] [stdout] 56 | | if next_ch.is_ascii_digit() { [INFO] [stdout] 57 | | let i_part = &after_core[i..]; [INFO] [stdout] 58 | | if let Some(dash_pos) = i_part.find('-') { [INFO] [stdout] ... | [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 55 ~ if let Some(next_ch) = after_core_upper.chars().nth(i + 1) [INFO] [stdout] 56 ~ && next_ch.is_ascii_digit() { [INFO] [stdout] 57 | let i_part = &after_core[i..]; [INFO] [stdout] ... [INFO] [stdout] 64 | break; [INFO] [stdout] 65 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/check/phase/phase3.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | / ... if let Some(count) = json["count"].as_i64() { [INFO] [stdout] 30 | | ... Some((id, count)) [INFO] [stdout] 31 | | ... } else { [INFO] [stdout] 32 | | ... None [INFO] [stdout] 33 | | ... } [INFO] [stdout] | |_______________________^ help: try: `json["count"].as_i64().map(|count| (id, count))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/check/phase/phase3.rs:46:47 [INFO] [stdout] | [INFO] [stdout] 46 | for (_, handle) in handles.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 46 - for (_, handle) in handles.into_iter().enumerate() { [INFO] [stdout] 46 + for handle in handles.into_iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/check_realtime/utils.rs:185:36 [INFO] [stdout] | [INFO] [stdout] 185 | Ok(result) => Some(result.rtt as u32), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `result.rtt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/check/filter.rs:31:53 [INFO] [stdout] | [INFO] [stdout] 31 | data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c <= max)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 31 - data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c <= max)); [INFO] [stdout] 31 + data.final_ids.retain(|&id| data.friends_count.get(&id).is_some_and(|&c| c <= max)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/check/filter.rs:39:54 [INFO] [stdout] | [INFO] [stdout] 39 | let parts: Vec<&str> = val_input.trim().split_whitespace().collect(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/check/filter.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | / if parts.len() == 2 { [INFO] [stdout] 41 | | if let (Ok(min), Ok(max)) = (parts[0].parse::(), parts[1].parse::()) { [INFO] [stdout] 42 | | data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c >= min && c <= max)); [INFO] [stdout] 43 | | } [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 40 ~ if parts.len() == 2 [INFO] [stdout] 41 ~ && let (Ok(min), Ok(max)) = (parts[0].parse::(), parts[1].parse::()) { [INFO] [stdout] 42 | data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c >= min && c <= max)); [INFO] [stdout] 43 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/check/filter.rs:42:57 [INFO] [stdout] | [INFO] [stdout] 42 | ... data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c >= min && c <= max)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 42 - data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c >= min && c <= max)); [INFO] [stdout] 42 + data.final_ids.retain(|&id| data.friends_count.get(&id).is_some_and(|&c| c >= min && c <= max)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/check/filter.rs:52:53 [INFO] [stdout] | [INFO] [stdout] 52 | data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c >= min)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 52 - data.final_ids.retain(|&id| data.friends_count.get(&id).map_or(false, |&c| c >= min)); [INFO] [stdout] 52 + data.final_ids.retain(|&id| data.friends_count.get(&id).is_some_and(|&c| c >= min)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/check/filter.rs:65:94 [INFO] [stdout] | [INFO] [stdout] 65 | println!("{}", tabled::Table::new(&rows).with(tabled::settings::Style::rounded()).to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/check_realtime/checker.rs:68:18 [INFO] [stdout] | [INFO] [stdout] 68 | .get(&format!("https://users.roblox.com/v1/users/{}", auth.id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("https://users.roblox.com/v1/users/{}", auth.id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/check/main.rs:74:78 [INFO] [stdout] | [INFO] [stdout] 74 | println!("{}", Table::new(&rows).with(tabled::settings::Style::rounded()).to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/check_realtime/checker.rs:182:21 [INFO] [stdout] | [INFO] [stdout] 182 | / if let Ok(json) = resp.json::().await { [INFO] [stdout] 183 | | if let Some(user_presences) = json["userPresences"].as_array() { [INFO] [stdout] 184 | | let mut presence = self.presence.lock().unwrap(); [INFO] [stdout] 185 | | for presence_data in user_presences { [INFO] [stdout] ... | [INFO] [stdout] 197 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 182 ~ if let Ok(json) = resp.json::().await [INFO] [stdout] 183 ~ && let Some(user_presences) = json["userPresences"].as_array() { [INFO] [stdout] 184 | let mut presence = self.presence.lock().unwrap(); [INFO] [stdout] ... [INFO] [stdout] 195 | } [INFO] [stdout] 196 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/check_realtime/utils.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / if let Some(space_pos) = after_epyc.find(' ') { [INFO] [stdout] 29 | | if let Some(num_start) = after_epyc[space_pos..].find(|c: char| c.is_ascii_digit()) { [INFO] [stdout] 30 | | let num_part = &after_epyc[space_pos + num_start..]; [INFO] [stdout] 31 | | let end = num_part.find(|c: char| !c.is_ascii_digit() && c != '-' && c != ' ').unwrap_or(num_part.len()); [INFO] [stdout] ... | [INFO] [stdout] 34 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 28 ~ if let Some(space_pos) = after_epyc.find(' ') [INFO] [stdout] 29 ~ && let Some(num_start) = after_epyc[space_pos..].find(|c: char| c.is_ascii_digit()) { [INFO] [stdout] 30 | let num_part = &after_epyc[space_pos + num_start..]; [INFO] [stdout] 31 | let end = num_part.find(|c: char| !c.is_ascii_digit() && c != '-' && c != ' ').unwrap_or(num_part.len()); [INFO] [stdout] 32 | return format!("EPYC {}", num_part[..end].trim()); [INFO] [stdout] 33 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/check_realtime/utils.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / if ch == 'I' { [INFO] [stdout] 55 | | if let Some(next_ch) = after_core_upper.chars().nth(i + 1) { [INFO] [stdout] 56 | | if next_ch.is_ascii_digit() { [INFO] [stdout] 57 | | let i_part = &after_core[i..]; [INFO] [stdout] ... | [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 54 ~ if ch == 'I' [INFO] [stdout] 55 ~ && let Some(next_ch) = after_core_upper.chars().nth(i + 1) { [INFO] [stdout] 56 | if next_ch.is_ascii_digit() { [INFO] [stdout] ... [INFO] [stdout] 65 | } [INFO] [stdout] 66 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/check_realtime/utils.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | / if let Some(next_ch) = after_core_upper.chars().nth(i + 1) { [INFO] [stdout] 56 | | if next_ch.is_ascii_digit() { [INFO] [stdout] 57 | | let i_part = &after_core[i..]; [INFO] [stdout] 58 | | if let Some(dash_pos) = i_part.find('-') { [INFO] [stdout] ... | [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 55 ~ if let Some(next_ch) = after_core_upper.chars().nth(i + 1) [INFO] [stdout] 56 ~ && next_ch.is_ascii_digit() { [INFO] [stdout] 57 | let i_part = &after_core[i..]; [INFO] [stdout] ... [INFO] [stdout] 64 | break; [INFO] [stdout] 65 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/check_realtime/utils.rs:185:36 [INFO] [stdout] | [INFO] [stdout] 185 | Ok(result) => Some(result.rtt as u32), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `result.rtt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/check_realtime/main.rs:51:24 [INFO] [stdout] | [INFO] [stdout] 51 | Ok(val) if val >= 60 && val <= 360 => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(60..=360).contains(&val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/check_realtime/checker.rs:68:18 [INFO] [stdout] | [INFO] [stdout] 68 | .get(&format!("https://users.roblox.com/v1/users/{}", auth.id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("https://users.roblox.com/v1/users/{}", auth.id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/check_realtime/main.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 96 | / if crossterm::event::poll(Duration::from_millis(100))? { [INFO] [stdout] 97 | | if let Event::Key(key) = event::read()? { [INFO] [stdout] 98 | | if key.kind == KeyEventKind::Press { [INFO] [stdout] 99 | | match key.code { [INFO] [stdout] ... | [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 96 ~ if crossterm::event::poll(Duration::from_millis(100))? [INFO] [stdout] 97 ~ && let Event::Key(key) = event::read()? { [INFO] [stdout] 98 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 105 | } [INFO] [stdout] 106 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/check_realtime/main.rs:97:25 [INFO] [stdout] | [INFO] [stdout] 97 | / if let Event::Key(key) = event::read()? { [INFO] [stdout] 98 | | if key.kind == KeyEventKind::Press { [INFO] [stdout] 99 | | match key.code { [INFO] [stdout] 100 | | KeyCode::Char('q') | KeyCode::Esc => { [INFO] [stdout] ... | [INFO] [stdout] 106 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 97 ~ if let Event::Key(key) = event::read()? [INFO] [stdout] 98 ~ && key.kind == KeyEventKind::Press { [INFO] [stdout] 99 | match key.code { [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/check_realtime/checker.rs:182:21 [INFO] [stdout] | [INFO] [stdout] 182 | / if let Ok(json) = resp.json::().await { [INFO] [stdout] 183 | | if let Some(user_presences) = json["userPresences"].as_array() { [INFO] [stdout] 184 | | let mut presence = self.presence.lock().unwrap(); [INFO] [stdout] 185 | | for presence_data in user_presences { [INFO] [stdout] ... | [INFO] [stdout] 197 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 182 ~ if let Ok(json) = resp.json::().await [INFO] [stdout] 183 ~ && let Some(user_presences) = json["userPresences"].as_array() { [INFO] [stdout] 184 | let mut presence = self.presence.lock().unwrap(); [INFO] [stdout] ... [INFO] [stdout] 195 | } [INFO] [stdout] 196 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/check_realtime/main.rs:51:24 [INFO] [stdout] | [INFO] [stdout] 51 | Ok(val) if val >= 60 && val <= 360 => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(60..=360).contains(&val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/check_realtime/main.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 96 | / if crossterm::event::poll(Duration::from_millis(100))? { [INFO] [stdout] 97 | | if let Event::Key(key) = event::read()? { [INFO] [stdout] 98 | | if key.kind == KeyEventKind::Press { [INFO] [stdout] 99 | | match key.code { [INFO] [stdout] ... | [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 96 ~ if crossterm::event::poll(Duration::from_millis(100))? [INFO] [stdout] 97 ~ && let Event::Key(key) = event::read()? { [INFO] [stdout] 98 | if key.kind == KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 105 | } [INFO] [stdout] 106 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/check_realtime/main.rs:97:25 [INFO] [stdout] | [INFO] [stdout] 97 | / if let Event::Key(key) = event::read()? { [INFO] [stdout] 98 | | if key.kind == KeyEventKind::Press { [INFO] [stdout] 99 | | match key.code { [INFO] [stdout] 100 | | KeyCode::Char('q') | KeyCode::Esc => { [INFO] [stdout] ... | [INFO] [stdout] 106 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 97 ~ if let Event::Key(key) = event::read()? [INFO] [stdout] 98 ~ && key.kind == KeyEventKind::Press { [INFO] [stdout] 99 | match key.code { [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 54.96s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: ashpd v0.8.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "da08f4e02d39fe4d84dd88ae063f6f07d0cd2ae685d003f2e1cf8d22060fac75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "da08f4e02d39fe4d84dd88ae063f6f07d0cd2ae685d003f2e1cf8d22060fac75", kill_on_drop: false }` [INFO] [stdout] da08f4e02d39fe4d84dd88ae063f6f07d0cd2ae685d003f2e1cf8d22060fac75