[INFO] cloning repository https://github.com/reb/tag-agents [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/reb/tag-agents" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freb%2Ftag-agents", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freb%2Ftag-agents'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f6a5c59f1c43605bf59ce036079abe9c6ddd32f6 [INFO] linting reb/tag-agents against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freb%2Ftag-agents" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/reb/tag-agents [INFO] finished tweaking git repo https://github.com/reb/tag-agents [INFO] tweaked toml for git repo https://github.com/reb/tag-agents written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/reb/tag-agents on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/reb/tag-agents already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pyo3-macros v0.16.5 [INFO] [stderr] Downloaded target-lexicon v0.12.4 [INFO] [stderr] Downloaded pyo3-ffi v0.16.5 [INFO] [stderr] Downloaded indoc v1.0.6 [INFO] [stderr] Downloaded unicode-ident v1.0.0 [INFO] [stderr] Downloaded unindent v0.1.9 [INFO] [stderr] Downloaded pyo3-build-config v0.16.5 [INFO] [stderr] Downloaded os_str_bytes v6.1.0 [INFO] [stderr] Downloaded pyo3-macros-backend v0.16.5 [INFO] [stderr] Downloaded pyo3 v0.16.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 76b299a647c4df8df5cb1a4889c9438d3a500f0e4663a357ecf18b4355105cac [INFO] running `Command { std: "docker" "start" "-a" "76b299a647c4df8df5cb1a4889c9438d3a500f0e4663a357ecf18b4355105cac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "76b299a647c4df8df5cb1a4889c9438d3a500f0e4663a357ecf18b4355105cac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76b299a647c4df8df5cb1a4889c9438d3a500f0e4663a357ecf18b4355105cac", kill_on_drop: false }` [INFO] [stdout] 76b299a647c4df8df5cb1a4889c9438d3a500f0e4663a357ecf18b4355105cac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 03d774c37dcdc8baac230d98fbe22cb821f0212ab5ad58708c85adf9b2ba8b19 [INFO] running `Command { std: "docker" "start" "-a" "03d774c37dcdc8baac230d98fbe22cb821f0212ab5ad58708c85adf9b2ba8b19", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.12.4 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.96 [INFO] [stderr] Compiling once_cell v1.12.0 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking os_str_bytes v6.1.0 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking clap_lex v0.2.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking unindent v0.1.9 [INFO] [stderr] Compiling indoc v1.0.6 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling pyo3-build-config v0.16.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking console v0.15.0 [INFO] [stderr] Compiling pyo3-ffi v0.16.5 [INFO] [stderr] Compiling pyo3 v0.16.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling pyo3-macros-backend v0.16.5 [INFO] [stderr] Compiling clap_derive v3.1.18 [INFO] [stderr] Checking clap v3.1.18 [INFO] [stderr] Compiling pyo3-macros v0.16.5 [INFO] [stderr] Checking tag-agents v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/simulator.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | let mut tagging_agent = agents.get_mut(tagging_agent_id).unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `decide_action` is never used [INFO] [stdout] --> src/simulator.rs:109:8 [INFO] [stdout] | [INFO] [stdout] 108 | impl Agent { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] 109 | fn decide_action(&self, agents: &Vec) -> Action { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `str::repeat` using iterators [INFO] [stdout] --> src/display.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | / iter::repeat('\n') [INFO] [stdout] 11 | | .take(settings.height as usize + 2) // there are two horizontal boundaries extra [INFO] [stdout] 12 | | .collect::() [INFO] [stdout] | |________________________________^ help: try: `"\n".repeat(settings.height as usize + 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_str_repeat [INFO] [stdout] = note: `#[warn(clippy::manual_str_repeat)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/display.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | / iter::repeat('\n') [INFO] [stdout] 11 | | .take(settings.height as usize + 2) // there are two horizontal boundaries extra [INFO] [stdout] | |_______________________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n('\n', settings.height as usize + 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/display.rs:18:22 [INFO] [stdout] | [INFO] [stdout] 18 | let mut screen = iter::repeat( [INFO] [stdout] | ______________________^ [INFO] [stdout] 19 | | iter::repeat(' ') [INFO] [stdout] 20 | | .take(settings.width as usize) [INFO] [stdout] 21 | | .collect::>(), [INFO] [stdout] 22 | | ) [INFO] [stdout] 23 | | .take(settings.height as usize) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] help: consider using `repeat_n()` instead [INFO] [stdout] | [INFO] [stdout] 18 ~ let mut screen = std::iter::repeat_n(iter::repeat(' ') [INFO] [stdout] 19 + .take(settings.width as usize) [INFO] [stdout] 20 + .collect::>(), settings.height as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/display.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / iter::repeat(' ') [INFO] [stdout] 20 | | .take(settings.width as usize) [INFO] [stdout] | |__________________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(' ', settings.width as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/display.rs:43:31 [INFO] [stdout] | [INFO] [stdout] 43 | let horizontal_boundary = iter::repeat(wall) [INFO] [stdout] | _______________________________^ [INFO] [stdout] 44 | | .take(settings.width as usize + 2) // there are two vertical walls as well [INFO] [stdout] | |__________________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(wall, settings.width as usize + 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/simulator.rs:68:18 [INFO] [stdout] | [INFO] [stdout] 68 | .zip(actions.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 68 - .zip(actions.into_iter()) [INFO] [stdout] 68 + .zip(actions) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/simulator.rs:109:37 [INFO] [stdout] | [INFO] [stdout] 109 | fn decide_action(&self, agents: &Vec) -> Action { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 109 - fn decide_action(&self, agents: &Vec) -> Action { [INFO] [stdout] 109 + fn decide_action(&self, agents: &[Agent]) -> Action { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/simulator.rs:115:60 [INFO] [stdout] | [INFO] [stdout] 115 | .filter(|agent| !agent.has_immunity && !(agent.id == self.id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(agent.id != self.id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual saturating arithmetic [INFO] [stdout] --> src/simulator.rs:168:31 [INFO] [stdout] | [INFO] [stdout] 168 | Action::Up => y = y.checked_sub(1).unwrap_or_default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `saturating_sub`: `y.saturating_sub(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic [INFO] [stdout] = note: `#[warn(clippy::manual_saturating_arithmetic)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual saturating arithmetic [INFO] [stdout] --> src/simulator.rs:171:33 [INFO] [stdout] | [INFO] [stdout] 171 | Action::Left => x = x.checked_sub(1).unwrap_or_default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `saturating_sub`: `x.saturating_sub(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression can be written more simply using `.retain()` [INFO] [stdout] --> src/simulator.rs:345:9 [INFO] [stdout] | [INFO] [stdout] 345 | agents = agents.into_iter().filter(|agent| agent.is_it).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling `.retain()` instead: `agents.retain(|agent| agent.is_it)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain [INFO] [stdout] = note: `#[warn(clippy::manual_retain)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/simulator.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | let mut tagging_agent = agents.get_mut(tagging_agent_id).unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `decide_action` is never used [INFO] [stdout] --> src/simulator.rs:109:8 [INFO] [stdout] | [INFO] [stdout] 108 | impl Agent { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] 109 | fn decide_action(&self, agents: &Vec) -> Action { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `str::repeat` using iterators [INFO] [stdout] --> src/display.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | / iter::repeat('\n') [INFO] [stdout] 11 | | .take(settings.height as usize + 2) // there are two horizontal boundaries extra [INFO] [stdout] 12 | | .collect::() [INFO] [stdout] | |________________________________^ help: try: `"\n".repeat(settings.height as usize + 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_str_repeat [INFO] [stdout] = note: `#[warn(clippy::manual_str_repeat)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/display.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | / iter::repeat('\n') [INFO] [stdout] 11 | | .take(settings.height as usize + 2) // there are two horizontal boundaries extra [INFO] [stdout] | |_______________________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n('\n', settings.height as usize + 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/display.rs:18:22 [INFO] [stdout] | [INFO] [stdout] 18 | let mut screen = iter::repeat( [INFO] [stdout] | ______________________^ [INFO] [stdout] 19 | | iter::repeat(' ') [INFO] [stdout] 20 | | .take(settings.width as usize) [INFO] [stdout] 21 | | .collect::>(), [INFO] [stdout] 22 | | ) [INFO] [stdout] 23 | | .take(settings.height as usize) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] help: consider using `repeat_n()` instead [INFO] [stdout] | [INFO] [stdout] 18 ~ let mut screen = std::iter::repeat_n(iter::repeat(' ') [INFO] [stdout] 19 + .take(settings.width as usize) [INFO] [stdout] 20 + .collect::>(), settings.height as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/display.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / iter::repeat(' ') [INFO] [stdout] 20 | | .take(settings.width as usize) [INFO] [stdout] | |__________________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(' ', settings.width as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/display.rs:43:31 [INFO] [stdout] | [INFO] [stdout] 43 | let horizontal_boundary = iter::repeat(wall) [INFO] [stdout] | _______________________________^ [INFO] [stdout] 44 | | .take(settings.width as usize + 2) // there are two vertical walls as well [INFO] [stdout] | |__________________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(wall, settings.width as usize + 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/simulator.rs:68:18 [INFO] [stdout] | [INFO] [stdout] 68 | .zip(actions.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 68 - .zip(actions.into_iter()) [INFO] [stdout] 68 + .zip(actions) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/simulator.rs:109:37 [INFO] [stdout] | [INFO] [stdout] 109 | fn decide_action(&self, agents: &Vec) -> Action { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 109 - fn decide_action(&self, agents: &Vec) -> Action { [INFO] [stdout] 109 + fn decide_action(&self, agents: &[Agent]) -> Action { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/simulator.rs:115:60 [INFO] [stdout] | [INFO] [stdout] 115 | .filter(|agent| !agent.has_immunity && !(agent.id == self.id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(agent.id != self.id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual saturating arithmetic [INFO] [stdout] --> src/simulator.rs:168:31 [INFO] [stdout] | [INFO] [stdout] 168 | Action::Up => y = y.checked_sub(1).unwrap_or_default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `saturating_sub`: `y.saturating_sub(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic [INFO] [stdout] = note: `#[warn(clippy::manual_saturating_arithmetic)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual saturating arithmetic [INFO] [stdout] --> src/simulator.rs:171:33 [INFO] [stdout] | [INFO] [stdout] 171 | Action::Left => x = x.checked_sub(1).unwrap_or_default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `saturating_sub`: `x.saturating_sub(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.20s [INFO] running `Command { std: "docker" "inspect" "03d774c37dcdc8baac230d98fbe22cb821f0212ab5ad58708c85adf9b2ba8b19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03d774c37dcdc8baac230d98fbe22cb821f0212ab5ad58708c85adf9b2ba8b19", kill_on_drop: false }` [INFO] [stdout] 03d774c37dcdc8baac230d98fbe22cb821f0212ab5ad58708c85adf9b2ba8b19