[INFO] cloning repository https://github.com/reasv/mitsuba [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/reasv/mitsuba" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freasv%2Fmitsuba", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freasv%2Fmitsuba'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 35905467205d41a7addcce90add730039aaef4d7 [INFO] linting reasv/mitsuba against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freasv%2Fmitsuba" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/reasv/mitsuba [INFO] finished tweaking git repo https://github.com/reasv/mitsuba [INFO] tweaked toml for git repo https://github.com/reasv/mitsuba written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/reasv/mitsuba on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/reasv/mitsuba already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded whoami v1.5.1 [INFO] [stderr] Downloaded weighted-rs v0.1.3 [INFO] [stderr] Downloaded redox_syscall v0.5.2 [INFO] [stderr] Downloaded unicode-truncate v1.0.0 [INFO] [stderr] Downloaded sqlformat v0.2.4 [INFO] [stderr] Downloaded serde_spanned v0.6.6 [INFO] [stderr] Downloaded tinyvec v1.6.1 [INFO] [stderr] Downloaded impl-more v0.1.6 [INFO] [stderr] Downloaded v_htmlescape v0.15.8 [INFO] [stderr] Downloaded base32 v0.5.0 [INFO] [stderr] Downloaded unsafe-any-ors v1.0.0 [INFO] [stderr] Downloaded env_logger v0.11.3 [INFO] [stderr] Downloaded actix-server v2.4.0 [INFO] [stderr] Downloaded actix-files v0.6.6 [INFO] [stderr] Downloaded toml v0.8.14 [INFO] [stderr] Downloaded log4rs v1.3.0 [INFO] [stderr] Downloaded handlebars v5.1.2 [INFO] [stderr] Downloaded raw-cpuid v11.0.2 [INFO] [stderr] Downloaded toml_edit v0.22.14 [INFO] [stderr] Downloaded actix-http v3.8.0 [INFO] [stderr] Downloaded winnow v0.6.13 [INFO] [stderr] Downloaded hyper v0.14.29 [INFO] [stderr] Downloaded clap_builder v4.5.8 [INFO] [stderr] Downloaded webpki-roots v0.26.3 [INFO] [stderr] Downloaded deunicode v1.6.0 [INFO] [stderr] Downloaded actix-web v4.8.0 [INFO] [stderr] Downloaded object v0.36.1 [INFO] [stderr] Downloaded rustls v0.20.9 [INFO] [stderr] Downloaded quick-xml v0.26.0 [INFO] [stderr] Downloaded hyper-util v0.1.5 [INFO] [stderr] Downloaded serde_json v1.0.119 [INFO] [stderr] Downloaded attohttpc v0.22.0 [INFO] [stderr] Downloaded webpki v0.22.4 [INFO] [stderr] Downloaded rust-s3 v0.33.0 [INFO] [stderr] Downloaded unicode-properties v0.1.1 [INFO] [stderr] Downloaded cc v1.0.103 [INFO] [stderr] Downloaded actix-session v0.9.0 [INFO] [stderr] Downloaded actix-tls v3.4.0 [INFO] [stderr] Downloaded clap v4.5.8 [INFO] [stderr] Downloaded jmespath v0.3.0 [INFO] [stderr] Downloaded metrics v0.18.1 [INFO] [stderr] Downloaded metrics-util v0.12.1 [INFO] [stderr] Downloaded new_mime_guess v4.0.1 [INFO] [stderr] Downloaded wasm-streams v0.4.0 [INFO] [stderr] Downloaded dashmap v6.0.1 [INFO] [stderr] Downloaded quanta v0.12.3 [INFO] [stderr] Downloaded quanta v0.9.3 [INFO] [stderr] Downloaded cruet v0.14.0 [INFO] [stderr] Downloaded handlebars_misc_helpers v0.16.3 [INFO] [stderr] Downloaded zstd-sys v2.0.11+zstd.1.5.6 [INFO] [stderr] Downloaded thread-id v4.2.1 [INFO] [stderr] Downloaded metrics-exporter-prometheus v0.9.0 [INFO] [stderr] Downloaded rust-embed-utils v8.4.0 [INFO] [stderr] Downloaded atomic-shim v0.2.0 [INFO] [stderr] Downloaded aws-region v0.25.4 [INFO] [stderr] Downloaded enquote v1.1.0 [INFO] [stderr] Downloaded typemap-ors v1.0.0 [INFO] [stderr] Downloaded sketches-ddsketch v0.1.3 [INFO] [stderr] Downloaded aws-creds v0.34.1 [INFO] [stderr] Downloaded slug v0.1.5 [INFO] [stderr] Downloaded destructure_traitobject v0.2.0 [INFO] [stderr] Downloaded rust-embed v8.4.0 [INFO] [stderr] Downloaded metrics-macros v0.5.1 [INFO] [stderr] Downloaded rust-embed-impl v8.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2790889b9ff72a7682ec86230ff8b7ce5f25abbe665da0541898912678e4c116 [INFO] running `Command { std: "docker" "start" "-a" "2790889b9ff72a7682ec86230ff8b7ce5f25abbe665da0541898912678e4c116", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2790889b9ff72a7682ec86230ff8b7ce5f25abbe665da0541898912678e4c116", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2790889b9ff72a7682ec86230ff8b7ce5f25abbe665da0541898912678e4c116", kill_on_drop: false }` [INFO] [stdout] 2790889b9ff72a7682ec86230ff8b7ce5f25abbe665da0541898912678e4c116 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f393ea9fb3527f221bea63d69a1acb1ee0c90aeb7e3c790c633106403f75b905 [INFO] running `Command { std: "docker" "start" "-a" "f393ea9fb3527f221bea63d69a1acb1ee0c90aeb7e3c790c633106403f75b905", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.119 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking tinyvec v1.6.1 [INFO] [stderr] Compiling pin-project-lite v0.2.14 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling tracing-core v0.1.32 [INFO] [stderr] Compiling rustls v0.20.9 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling futures-core v0.3.30 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling socket2 v0.5.7 [INFO] [stderr] Compiling cc v1.0.103 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Compiling futures-sink v0.3.30 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Compiling zstd-safe v7.1.0 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Compiling tokio v1.38.0 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling unicode_categories v0.1.1 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling futures-io v0.3.30 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Compiling crc v3.2.1 [INFO] [stderr] Compiling futures-util v0.3.30 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling hashlink v0.8.4 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling zstd-sys v2.0.11+zstd.1.5.6 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.11 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Compiling futures-channel v0.3.30 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking bytestring v1.3.1 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Compiling rustls v0.23.10 [INFO] [stderr] Compiling deunicode v1.6.0 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling event-listener v2.5.3 [INFO] [stderr] Compiling unicode-properties v0.1.1 [INFO] [stderr] Checking impl-more v0.1.6 [INFO] [stderr] Compiling regex-lite v0.1.6 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Compiling slug v0.1.5 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Compiling sqlformat v0.2.4 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling base64 v0.21.7 [INFO] [stderr] Compiling fastrand v2.1.0 [INFO] [stderr] Checking dlv-list v0.3.0 [INFO] [stderr] Compiling whoami v1.5.1 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Compiling metrics v0.18.1 [INFO] [stderr] Checking base64 v0.20.0 [INFO] [stderr] Checking ordered-multimap v0.4.3 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Compiling v_htmlescape v0.15.8 [INFO] [stderr] Compiling metrics-macros v0.5.1 [INFO] [stderr] Compiling tempfile v3.10.1 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rust-ini v0.18.0 [INFO] [stderr] Checking quanta v0.9.3 [INFO] [stderr] Compiling rust-embed-utils v8.4.0 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling tokio-stream v0.1.15 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling new_mime_guess v4.0.1 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking raw-cpuid v11.0.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking atomic-shim v0.2.0 [INFO] [stderr] Checking dotenvy v0.15.7 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking sketches-ddsketch v0.1.3 [INFO] [stderr] Checking clap_builder v4.5.8 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking webpki v0.22.4 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking rustls-webpki v0.102.4 [INFO] [stderr] Checking webpki-roots v0.22.6 [INFO] [stderr] Checking quanta v0.12.3 [INFO] [stderr] Checking metrics-util v0.12.1 [INFO] [stderr] Compiling maybe-async v0.2.10 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling rust-embed-impl v8.4.0 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Compiling tracing v0.1.40 [INFO] [stderr] Checking pest v2.7.10 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking aws-region v0.25.4 [INFO] [stderr] Checking enquote v1.1.0 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking cruet v0.14.0 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking thread-id v4.2.1 [INFO] [stderr] Checking spinning_top v0.3.0 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking no-std-compat v0.4.1 [INFO] [stderr] Checking nonzero_ext v0.3.0 [INFO] [stderr] Checking http-range v0.1.5 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking rust-embed v8.4.0 [INFO] [stderr] Checking weighted-rs v0.1.3 [INFO] [stderr] Checking dashmap v6.0.1 [INFO] [stderr] Checking base32 v0.5.0 [INFO] [stderr] Checking clap v4.5.8 [INFO] [stderr] Compiling pest_meta v2.7.10 [INFO] [stderr] Checking zstd v0.13.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling pest_generator v2.7.10 [INFO] [stderr] Checking governor v0.6.3 [INFO] [stderr] Compiling pest_derive v2.7.10 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking quick-xml v0.26.0 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking toml_edit v0.22.14 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking handlebars v5.1.2 [INFO] [stderr] Checking log4rs v1.3.0 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Checking unicode-truncate v1.0.0 [INFO] [stderr] Compiling sqlx-core v0.7.4 [INFO] [stderr] Compiling jmespath v0.3.0 [INFO] [stderr] Checking attohttpc v0.22.0 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking aws-creds v0.34.1 [INFO] [stderr] Checking handlebars_misc_helpers v0.16.3 [INFO] [stderr] Compiling sqlx-postgres v0.7.4 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking actix-rt v2.10.0 [INFO] [stderr] Checking tokio-rustls v0.23.4 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking backoff v0.4.0 [INFO] [stderr] Checking actix-server v2.4.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking actix-tls v3.4.0 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Compiling sqlx-macros-core v0.7.4 [INFO] [stderr] Checking hyper v0.14.29 [INFO] [stderr] Checking actix-http v3.8.0 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Compiling sqlx-macros v0.7.4 [INFO] [stderr] Checking sqlx v0.7.4 [INFO] [stderr] Checking hyper-util v0.1.5 [INFO] [stderr] Checking actix-web v4.8.0 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking metrics-exporter-prometheus v0.9.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking rust-s3 v0.33.0 [INFO] [stderr] Checking actix-files v0.6.6 [INFO] [stderr] Checking actix-session v0.9.0 [INFO] [stderr] Checking mitsuba v1.12.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `UserReports` is never constructed [INFO] [stdout] --> src/models.rs:521:12 [INFO] [stdout] | [INFO] [stdout] 521 | pub struct UserReports { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SubmittedUserReport` is never constructed [INFO] [stdout] --> src/web/api.rs:305:8 [INFO] [stdout] | [INFO] [stdout] 305 | struct SubmittedUserReport { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PageQuery` is never constructed [INFO] [stdout] --> src/web/api.rs:334:8 [INFO] [stdout] | [INFO] [stdout] 334 | struct PageQuery { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TextRCError` is never constructed [INFO] [stdout] --> src/web/auth.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | pub struct TextRCError; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RedirectRCError` is never constructed [INFO] [stdout] --> src/web/auth.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 89 | pub struct RedirectRCError; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RedirectError` is never constructed [INFO] [stdout] --> src/web/auth.rs:109:8 [INFO] [stdout] | [INFO] [stdout] 109 | struct RedirectError { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `BadRequest` is never used [INFO] [stdout] --> src/web/auth.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 151 | impl JSONError { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 184 | pub fn BadRequest(message: T) -> JSONError { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AnonymousOnly` is never constructed [INFO] [stdout] --> src/web/auth.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 232 | pub struct AnonymousOnly; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RequireModerator` is never constructed [INFO] [stdout] --> src/web/auth.rs:250:12 [INFO] [stdout] | [INFO] [stdout] 250 | pub struct RequireModerator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/db.rs:169:10 [INFO] [stdout] | [INFO] [stdout] 169 | .filter_map(|img| img).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] = note: `#[warn(clippy::filter_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db.rs:410:51 [INFO] [stdout] | [INFO] [stdout] 410 | let tinfo_hash = self.get_threadinfo_hash(&tinfo); [INFO] [stdout] | ^^^^^^ help: change this to: `tinfo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/db.rs:568:13 [INFO] [stdout] | [INFO] [stdout] 568 | return Ok(Some(post)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 568 - return Ok(Some(post)); [INFO] [stdout] 568 + Ok(Some(post)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/db.rs:570:13 [INFO] [stdout] | [INFO] [stdout] 570 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 570 - return Ok(None); [INFO] [stdout] 570 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UserReports` is never constructed [INFO] [stdout] --> src/models.rs:521:12 [INFO] [stdout] | [INFO] [stdout] 521 | pub struct UserReports { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SubmittedUserReport` is never constructed [INFO] [stdout] --> src/web/api.rs:305:8 [INFO] [stdout] | [INFO] [stdout] 305 | struct SubmittedUserReport { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PageQuery` is never constructed [INFO] [stdout] --> src/web/api.rs:334:8 [INFO] [stdout] | [INFO] [stdout] 334 | struct PageQuery { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TextRCError` is never constructed [INFO] [stdout] --> src/web/auth.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | pub struct TextRCError; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RedirectRCError` is never constructed [INFO] [stdout] --> src/web/auth.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 89 | pub struct RedirectRCError; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RedirectError` is never constructed [INFO] [stdout] --> src/web/auth.rs:109:8 [INFO] [stdout] | [INFO] [stdout] 109 | struct RedirectError { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `BadRequest` is never used [INFO] [stdout] --> src/web/auth.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 151 | impl JSONError { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 184 | pub fn BadRequest(message: T) -> JSONError { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AnonymousOnly` is never constructed [INFO] [stdout] --> src/web/auth.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 232 | pub struct AnonymousOnly; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RequireModerator` is never constructed [INFO] [stdout] --> src/web/auth.rs:250:12 [INFO] [stdout] | [INFO] [stdout] 250 | pub struct RequireModerator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/db.rs:169:10 [INFO] [stdout] | [INFO] [stdout] 169 | .filter_map(|img| img).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] = note: `#[warn(clippy::filter_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db.rs:410:51 [INFO] [stdout] | [INFO] [stdout] 410 | let tinfo_hash = self.get_threadinfo_hash(&tinfo); [INFO] [stdout] | ^^^^^^ help: change this to: `tinfo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/db.rs:568:13 [INFO] [stdout] | [INFO] [stdout] 568 | return Ok(Some(post)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 568 - return Ok(Some(post)); [INFO] [stdout] 568 + Ok(Some(post)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/db.rs:570:13 [INFO] [stdout] | [INFO] [stdout] 570 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 570 - return Ok(None); [INFO] [stdout] 570 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/models.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | fn is_empty_string(s: &String) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 104 - fn is_empty_string(s: &String) -> bool { [INFO] [stdout] 104 + fn is_empty_string(s: &str) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/db.rs:1566:9 [INFO] [stdout] | [INFO] [stdout] 1566 | post1.board = "test".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `models::Post { board: "test".to_string(), no: 10, time: 1337, images: 77, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/db.rs:1565:9 [INFO] [stdout] | [INFO] [stdout] 1565 | let mut post1 = Post::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/db.rs:1571:9 [INFO] [stdout] | [INFO] [stdout] 1571 | post2.board = "test".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `models::Post { board: "test".to_string(), no: 11, time: 1559, images: 55, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/db.rs:1570:9 [INFO] [stdout] | [INFO] [stdout] 1570 | let mut post2 = Post::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/db.rs:1576:9 [INFO] [stdout] | [INFO] [stdout] 1576 | post3.board = "test".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `models::Post { board: "test".to_string(), no: 12, time: 4444, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/db.rs:1575:9 [INFO] [stdout] | [INFO] [stdout] 1575 | let mut post3 = Post::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/db.rs:1600:9 [INFO] [stdout] | [INFO] [stdout] 1600 | post1.board = "test".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `models::Post { board: "test".to_string(), no: 10, time: 1337, images: 77, com: "test \u{00} test \u{00}".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/db.rs:1599:9 [INFO] [stdout] | [INFO] [stdout] 1599 | let mut post1 = Post::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/db.rs:1617:9 [INFO] [stdout] | [INFO] [stdout] 1617 | post1.board = "test".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `models::Post { board: "test".to_string(), no: 10, com: "Comment2".to_string(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/db.rs:1616:9 [INFO] [stdout] | [INFO] [stdout] 1616 | let mut post1 = Post::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/db.rs:1640:9 [INFO] [stdout] | [INFO] [stdout] 1640 | post1.board = "test".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `models::Post { board: "test".to_string(), no: 10, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/db.rs:1639:9 [INFO] [stdout] | [INFO] [stdout] 1639 | let mut post1 = Post::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/db.rs:1665:9 [INFO] [stdout] | [INFO] [stdout] 1665 | post1.board = "test".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `models::Post { board: "test".to_string(), resto: 1, no: 1, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/db.rs:1664:9 [INFO] [stdout] | [INFO] [stdout] 1664 | let mut post1 = Post::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/db.rs:1670:9 [INFO] [stdout] | [INFO] [stdout] 1670 | post2.board = "test".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `models::Post { board: "test".to_string(), resto: 1, no: 2, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/db.rs:1669:9 [INFO] [stdout] | [INFO] [stdout] 1669 | let mut post2 = Post::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/db.rs:1675:9 [INFO] [stdout] | [INFO] [stdout] 1675 | post3.board = "test".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `models::Post { board: "test".to_string(), resto: 1, no: 3, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/db.rs:1674:9 [INFO] [stdout] | [INFO] [stdout] 1674 | let mut post3 = Post::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/db.rs:1680:9 [INFO] [stdout] | [INFO] [stdout] 1680 | post4.board = "test".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `models::Post { board: "test".to_string(), resto: 1, no: 4, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/db.rs:1679:9 [INFO] [stdout] | [INFO] [stdout] 1679 | let mut post4 = Post::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/db.rs:1716:9 [INFO] [stdout] | [INFO] [stdout] 1716 | img.board = "test_a".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `models::ImageInfo { board: "test_a".to_string(), no: 777, url: "url1".to_string(), page: 5, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/db.rs:1715:9 [INFO] [stdout] | [INFO] [stdout] 1715 | let mut img = ImageInfo::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/db.rs:1726:9 [INFO] [stdout] | [INFO] [stdout] 1726 | img_b.board = "test_b".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `models::ImageInfo { board: "test_b".to_string(), no: 777, url: "urlB".to_string(), page: 77, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/db.rs:1725:9 [INFO] [stdout] | [INFO] [stdout] 1725 | let mut img_b = ImageInfo::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/db.rs:1732:9 [INFO] [stdout] | [INFO] [stdout] 1732 | assert_eq!(false, img_job.id == img_b_job.id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1732 - assert_eq!(false, img_job.id == img_b_job.id); [INFO] [stdout] 1732 + assert!(!(img_job.id == img_b_job.id)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/models.rs:317:12 [INFO] [stdout] | [INFO] [stdout] 317 | if thread.posts.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `thread.posts.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/models.rs:457:19 [INFO] [stdout] | [INFO] [stdout] 457 | int_value.try_into().map_err(|_| "failed to parse enum".into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `i32` to `UserRole` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 457 - int_value.try_into().map_err(|_| "failed to parse enum".into()) [INFO] [stdout] 457 + int_value.into().map_err(|_| "failed to parse enum".into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/models.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | fn is_empty_string(s: &String) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 104 - fn is_empty_string(s: &String) -> bool { [INFO] [stdout] 104 + fn is_empty_string(s: &str) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/models.rs:575:1 [INFO] [stdout] | [INFO] [stdout] 575 | / impl std::string::ToString for ModActionType { [INFO] [stdout] 576 | | fn to_string(&self) -> String { [INFO] [stdout] 577 | | match self { [INFO] [stdout] 578 | | ModActionType::BlacklistImage => "blacklist_image".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 588 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/http.rs:129:57 [INFO] [stdout] | [INFO] [stdout] 129 | async fn save_file(&self, bytes: bytes::Bytes, ext: &String, is_thumb: bool) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 129 - async fn save_file(&self, bytes: bytes::Bytes, ext: &String, is_thumb: bool) -> Option { [INFO] [stdout] 129 + async fn save_file(&self, bytes: bytes::Bytes, ext: &str, is_thumb: bool) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http.rs:144:44 [INFO] [stdout] | [INFO] [stdout] 144 | let filename = get_file_url(&hash, &ext, is_thumb); [INFO] [stdout] | ^^^^ help: change this to: `ext` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/http.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | / if let Some(response_data) = self.oclient.bucket.put_object(filename.clone(), &bytes).await [INFO] [stdout] 147 | | .map_err(|e| {error!("Error uploading file ({}) to object storage: {}", filename, e);}) [INFO] [stdout] 148 | | .ok() { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] = note: `#[warn(clippy::match_result_ok)]` on by default [INFO] [stdout] help: consider matching on `Ok(response_data)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 146 ~ if let Ok(response_data) = self.oclient.bucket.put_object(filename.clone(), &bytes).await [INFO] [stdout] 147 ~ .map_err(|e| {error!("Error uploading file ({}) to object storage: {}", filename, e);}) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `String` [INFO] [stdout] --> src/util.rs:24:37 [INFO] [stdout] | [INFO] [stdout] 24 | msg = ((msg << 5) - msg) + (s.bytes().nth(i).unwrap_or(0) as i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(i).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] = note: `#[warn(clippy::bytes_nth)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/util.rs:43:26 [INFO] [stdout] | [INFO] [stdout] 43 | ss.to_string() + &"(...)".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `"(...)"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/util.rs:84:32 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn get_file_folder(sha256: &String, is_thumb: bool) -> PathBuf { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 84 - pub fn get_file_folder(sha256: &String, is_thumb: bool) -> PathBuf { [INFO] [stdout] 84 + pub fn get_file_folder(sha256: &str, is_thumb: bool) -> PathBuf { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/util.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | while let Some(url) = env::var(format!("PROXY_URL_{}", i)).ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(url)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 128 - while let Some(url) = env::var(format!("PROXY_URL_{}", i)).ok() { [INFO] [stdout] 128 + while let Ok(url) = env::var(format!("PROXY_URL_{}", i)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/util.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | if let Some(proxy) = reqwest::Url::parse(&url).ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(proxy)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 129 - if let Some(proxy) = reqwest::Url::parse(&url).ok() { [INFO] [stdout] 129 + if let Ok(proxy) = reqwest::Url::parse(&url) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/util.rs:145:27 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn strip_nullchars(s: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 145 - pub fn strip_nullchars(s: &String) -> String { [INFO] [stdout] 145 + pub fn strip_nullchars(s: &str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/object_storage.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | region: std::env::var("S3_REGION").unwrap().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `std::env::var("S3_REGION").unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/object_storage.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | endpoint: std::env::var("S3_ENDPOINT").unwrap().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `std::env::var("S3_ENDPOINT").unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/object_storage.rs:53:33 [INFO] [stdout] | [INFO] [stdout] 53 | bucket: Bucket::new(&"bucket".to_string(), "us-east-1".parse().unwrap(), Credentials::anonymous().unwrap()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `"bucket"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/archiver/board_archiver.rs:38:44 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn get_archived_hash(&self, board: &String, tid: i64) -> u64 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 38 ~ pub fn get_archived_hash(&self, board: &str, tid: i64) -> u64 { [INFO] [stdout] 39 | let mut hasher = DefaultHasher::new(); [INFO] [stdout] 40 ~ (board.to_owned(), tid).hash(& mut hasher); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/archiver/image_archiver.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | if jobs.len() == 0 { // No more jobs available [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `jobs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/archiver/thread_archiver.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 35 | if jobs.len() == 0 { // No more jobs available [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `jobs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/archiver/thread_archiver.rs:61:26 [INFO] [stdout] | [INFO] [stdout] 61 | let job_id = job.id.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `job.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/models.rs:317:12 [INFO] [stdout] | [INFO] [stdout] 317 | if thread.posts.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `thread.posts.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inequality checks against true can be replaced by a negation [INFO] [stdout] --> src/archiver/mod.rs:127:16 [INFO] [stdout] | [INFO] [stdout] 127 | if self.db_client.is_file_orphaned(file.file_id).await? != true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.db_client.is_file_orphaned(file.file_id).await?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/archiver/mod.rs:194:17 [INFO] [stdout] | [INFO] [stdout] 194 | &board_name, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `board_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/archiver/mod.rs:256:33 [INFO] [stdout] | [INFO] [stdout] 256 | .blacklist_file(&sha256, action_id).await?; [INFO] [stdout] | ^^^^^^^ help: change this to: `sha256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/archiver/mod.rs:301:50 [INFO] [stdout] | [INFO] [stdout] 301 | let password_hash = argon2.hash_password(&password.as_bytes(), &salt) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `password.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserRole` which implements the `Copy` trait [INFO] [stdout] --> src/archiver/mod.rs:307:19 [INFO] [stdout] | [INFO] [stdout] 307 | role: role.clone() [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `role` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/archiver/mod.rs:340:50 [INFO] [stdout] | [INFO] [stdout] 340 | let password_hash = argon2.hash_password(&password.as_bytes(), &salt) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `password.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/models.rs:457:19 [INFO] [stdout] | [INFO] [stdout] 457 | int_value.try_into().map_err(|_| "failed to parse enum".into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `i32` to `UserRole` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 457 - int_value.try_into().map_err(|_| "failed to parse enum".into()) [INFO] [stdout] 457 + int_value.into().map_err(|_| "failed to parse enum".into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/web/api.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | / let user = archiver.add_user( [INFO] [stdout] 108 | | &new_user.username, [INFO] [stdout] 109 | | &new_user.password_hash, [INFO] [stdout] 110 | | new_user.role [INFO] [stdout] ... | [INFO] [stdout] 114 | | JSONError::InternalServerError("Error creating user in DB") [INFO] [stdout] 115 | | })?; [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 107 ~ archiver.add_user( [INFO] [stdout] 108 | &new_user.username, [INFO] [stdout] ... [INFO] [stdout] 116 | Ok(HttpResponse::Ok().json( [INFO] [stdout] 117 ~ ActionSuccess::new_with_data("User created", ()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/models.rs:575:1 [INFO] [stdout] | [INFO] [stdout] 575 | / impl std::string::ToString for ModActionType { [INFO] [stdout] 576 | | fn to_string(&self) -> String { [INFO] [stdout] 577 | | match self { [INFO] [stdout] 578 | | ModActionType::BlacklistImage => "blacklist_image".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 588 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/web/api.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | return Ok(HttpResponse::Ok().json(ActionSuccess::new(format!("Filed Report #{}", report_id)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 327 - return Ok(HttpResponse::Ok().json(ActionSuccess::new(format!("Filed Report #{}", report_id)))) [INFO] [stdout] 327 + Ok(HttpResponse::Ok().json(ActionSuccess::new(format!("Filed Report #{}", report_id)))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/web/api.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | return Err(JSONError::BadRequest("Post does not exist").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 329 - return Err(JSONError::BadRequest("Post does not exist").into()) [INFO] [stdout] 329 + Err(JSONError::BadRequest("Post does not exist").into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/http.rs:129:57 [INFO] [stdout] | [INFO] [stdout] 129 | async fn save_file(&self, bytes: bytes::Bytes, ext: &String, is_thumb: bool) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 129 - async fn save_file(&self, bytes: bytes::Bytes, ext: &String, is_thumb: bool) -> Option { [INFO] [stdout] 129 + async fn save_file(&self, bytes: bytes::Bytes, ext: &str, is_thumb: bool) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http.rs:144:44 [INFO] [stdout] | [INFO] [stdout] 144 | let filename = get_file_url(&hash, &ext, is_thumb); [INFO] [stdout] | ^^^^ help: change this to: `ext` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/http.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | / if let Some(response_data) = self.oclient.bucket.put_object(filename.clone(), &bytes).await [INFO] [stdout] 147 | | .map_err(|e| {error!("Error uploading file ({}) to object storage: {}", filename, e);}) [INFO] [stdout] 148 | | .ok() { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] = note: `#[warn(clippy::match_result_ok)]` on by default [INFO] [stdout] help: consider matching on `Ok(response_data)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 146 ~ if let Ok(response_data) = self.oclient.bucket.put_object(filename.clone(), &bytes).await [INFO] [stdout] 147 ~ .map_err(|e| {error!("Error uploading file ({}) to object storage: {}", filename, e);}) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.bytes().nth()` on a `String` [INFO] [stdout] --> src/util.rs:24:37 [INFO] [stdout] | [INFO] [stdout] 24 | msg = ((msg << 5) - msg) + (s.bytes().nth(i).unwrap_or(0) as i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `s.as_bytes().get(i).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bytes_nth [INFO] [stdout] = note: `#[warn(clippy::bytes_nth)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/util.rs:43:26 [INFO] [stdout] | [INFO] [stdout] 43 | ss.to_string() + &"(...)".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `"(...)"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/util.rs:84:32 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn get_file_folder(sha256: &String, is_thumb: bool) -> PathBuf { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 84 - pub fn get_file_folder(sha256: &String, is_thumb: bool) -> PathBuf { [INFO] [stdout] 84 + pub fn get_file_folder(sha256: &str, is_thumb: bool) -> PathBuf { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/util.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | while let Some(url) = env::var(format!("PROXY_URL_{}", i)).ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(url)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 128 - while let Some(url) = env::var(format!("PROXY_URL_{}", i)).ok() { [INFO] [stdout] 128 + while let Ok(url) = env::var(format!("PROXY_URL_{}", i)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/util.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | if let Some(proxy) = reqwest::Url::parse(&url).ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] help: consider matching on `Ok(proxy)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 129 - if let Some(proxy) = reqwest::Url::parse(&url).ok() { [INFO] [stdout] 129 + if let Ok(proxy) = reqwest::Url::parse(&url) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/util.rs:145:27 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn strip_nullchars(s: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 145 - pub fn strip_nullchars(s: &String) -> String { [INFO] [stdout] 145 + pub fn strip_nullchars(s: &str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/object_storage.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | region: std::env::var("S3_REGION").unwrap().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `std::env::var("S3_REGION").unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/object_storage.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | endpoint: std::env::var("S3_ENDPOINT").unwrap().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `std::env::var("S3_ENDPOINT").unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/object_storage.rs:53:33 [INFO] [stdout] | [INFO] [stdout] 53 | bucket: Bucket::new(&"bucket".to_string(), "us-east-1".parse().unwrap(), Credentials::anonymous().unwrap()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `"bucket"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/web/api.rs:511:17 [INFO] [stdout] | [INFO] [stdout] 511 | &search_query, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `search_query` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/archiver/board_archiver.rs:38:44 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn get_archived_hash(&self, board: &String, tid: i64) -> u64 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 38 ~ pub fn get_archived_hash(&self, board: &str, tid: i64) -> u64 { [INFO] [stdout] 39 | let mut hasher = DefaultHasher::new(); [INFO] [stdout] 40 ~ (board.to_owned(), tid).hash(& mut hasher); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/web/api.rs:622:56 [INFO] [stdout] | [INFO] [stdout] 622 | get_file_object_storage(obc, &("/img/".to_string()+&path)).await [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `actix_web::Error` [INFO] [stdout] --> src/web/api.rs:640:13 [INFO] [stdout] | [INFO] [stdout] 640 | Err(actix_web::error::ErrorInternalServerError("").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `actix_web::error::ErrorInternalServerError("")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/archiver/image_archiver.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | if jobs.len() == 0 { // No more jobs available [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `jobs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/archiver/thread_archiver.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 35 | if jobs.len() == 0 { // No more jobs available [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `jobs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/archiver/thread_archiver.rs:61:26 [INFO] [stdout] | [INFO] [stdout] 61 | let job_id = job.id.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `job.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/web/frontend.rs:57:28 [INFO] [stdout] | [INFO] [stdout] 57 | fn get_home_boards(boards: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 57 - fn get_home_boards(boards: &Vec) -> Vec { [INFO] [stdout] 57 + fn get_home_boards(boards: &[Board]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/web/frontend.rs:187:34 [INFO] [stdout] | [INFO] [stdout] 187 | let op: Option = match threads.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!threads.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/web/frontend.rs:255:34 [INFO] [stdout] | [INFO] [stdout] 255 | let op: Option = match posts.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!posts.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/web/frontend.rs:315:49 [INFO] [stdout] | [INFO] [stdout] 315 | handlebars.register_template_string(&name, &template_str).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inequality checks against true can be replaced by a negation [INFO] [stdout] --> src/archiver/mod.rs:127:16 [INFO] [stdout] | [INFO] [stdout] 127 | if self.db_client.is_file_orphaned(file.file_id).await? != true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.db_client.is_file_orphaned(file.file_id).await?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/archiver/mod.rs:194:17 [INFO] [stdout] | [INFO] [stdout] 194 | &board_name, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `board_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/archiver/mod.rs:256:33 [INFO] [stdout] | [INFO] [stdout] 256 | .blacklist_file(&sha256, action_id).await?; [INFO] [stdout] | ^^^^^^^ help: change this to: `sha256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/archiver/mod.rs:301:50 [INFO] [stdout] | [INFO] [stdout] 301 | let password_hash = argon2.hash_password(&password.as_bytes(), &salt) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `password.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserRole` which implements the `Copy` trait [INFO] [stdout] --> src/archiver/mod.rs:307:19 [INFO] [stdout] | [INFO] [stdout] 307 | role: role.clone() [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `role` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/archiver/mod.rs:340:50 [INFO] [stdout] | [INFO] [stdout] 340 | let password_hash = argon2.hash_password(&password.as_bytes(), &salt) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `password.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/web/auth.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | / match role { [INFO] [stdout] 224 | | UserRole::Anonymous => false, [INFO] [stdout] 225 | | _ => true, [INFO] [stdout] 226 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 223 - match role { [INFO] [stdout] 224 - UserRole::Anonymous => false, [INFO] [stdout] 225 - _ => true, [INFO] [stdout] 226 - } [INFO] [stdout] 223 + !matches!(role, UserRole::Anonymous) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/web/auth.rs:272:29 [INFO] [stdout] | [INFO] [stdout] 272 | let archiver_data = req.app_data::>() [INFO] [stdout] | _____________________________^ [INFO] [stdout] 273 | | .map(|data| data.clone()); [INFO] [stdout] | |_____________________________________^ help: consider calling the dedicated `cloned` method: `req.app_data::>().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/web/mod.rs:37:39 [INFO] [stdout] | [INFO] [stdout] 37 | let secret_key = Key::derive_from(&secret_seed.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `secret_seed.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/web/api.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | / let user = archiver.add_user( [INFO] [stdout] 108 | | &new_user.username, [INFO] [stdout] 109 | | &new_user.password_hash, [INFO] [stdout] 110 | | new_user.role [INFO] [stdout] ... | [INFO] [stdout] 114 | | JSONError::InternalServerError("Error creating user in DB") [INFO] [stdout] 115 | | })?; [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 107 ~ archiver.add_user( [INFO] [stdout] 108 | &new_user.username, [INFO] [stdout] ... [INFO] [stdout] 116 | Ok(HttpResponse::Ok().json( [INFO] [stdout] 117 ~ ActionSuccess::new_with_data("User created", ()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/web/api.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | return Ok(HttpResponse::Ok().json(ActionSuccess::new(format!("Filed Report #{}", report_id)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 327 - return Ok(HttpResponse::Ok().json(ActionSuccess::new(format!("Filed Report #{}", report_id)))) [INFO] [stdout] 327 + Ok(HttpResponse::Ok().json(ActionSuccess::new(format!("Filed Report #{}", report_id)))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/web/api.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | return Err(JSONError::BadRequest("Post does not exist").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 329 - return Err(JSONError::BadRequest("Post does not exist").into()) [INFO] [stdout] 329 + Err(JSONError::BadRequest("Post does not exist").into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/web/api.rs:511:17 [INFO] [stdout] | [INFO] [stdout] 511 | &search_query, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `search_query` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/web/api.rs:622:56 [INFO] [stdout] | [INFO] [stdout] 622 | get_file_object_storage(obc, &("/img/".to_string()+&path)).await [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `actix_web::Error` [INFO] [stdout] --> src/web/api.rs:640:13 [INFO] [stdout] | [INFO] [stdout] 640 | Err(actix_web::error::ErrorInternalServerError("").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `actix_web::error::ErrorInternalServerError("")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/web/frontend.rs:57:28 [INFO] [stdout] | [INFO] [stdout] 57 | fn get_home_boards(boards: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 57 - fn get_home_boards(boards: &Vec) -> Vec { [INFO] [stdout] 57 + fn get_home_boards(boards: &[Board]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/web/frontend.rs:187:34 [INFO] [stdout] | [INFO] [stdout] 187 | let op: Option = match threads.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!threads.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/web/frontend.rs:255:34 [INFO] [stdout] | [INFO] [stdout] 255 | let op: Option = match posts.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!posts.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/web/frontend.rs:315:49 [INFO] [stdout] | [INFO] [stdout] 315 | handlebars.register_template_string(&name, &template_str).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/web/auth.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | / match role { [INFO] [stdout] 224 | | UserRole::Anonymous => false, [INFO] [stdout] 225 | | _ => true, [INFO] [stdout] 226 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 223 - match role { [INFO] [stdout] 224 - UserRole::Anonymous => false, [INFO] [stdout] 225 - _ => true, [INFO] [stdout] 226 - } [INFO] [stdout] 223 + !matches!(role, UserRole::Anonymous) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/web/auth.rs:272:29 [INFO] [stdout] | [INFO] [stdout] 272 | let archiver_data = req.app_data::>() [INFO] [stdout] | _____________________________^ [INFO] [stdout] 273 | | .map(|data| data.clone()); [INFO] [stdout] | |_____________________________________^ help: consider calling the dedicated `cloned` method: `req.app_data::>().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/web/mod.rs:37:39 [INFO] [stdout] | [INFO] [stdout] 37 | let secret_key = Key::derive_from(&secret_seed.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `secret_seed.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 47s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: sqlx-postgres v0.7.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "f393ea9fb3527f221bea63d69a1acb1ee0c90aeb7e3c790c633106403f75b905", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f393ea9fb3527f221bea63d69a1acb1ee0c90aeb7e3c790c633106403f75b905", kill_on_drop: false }` [INFO] [stdout] f393ea9fb3527f221bea63d69a1acb1ee0c90aeb7e3c790c633106403f75b905