[INFO] cloning repository https://github.com/realoksi/foobar2000-catbox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/realoksi/foobar2000-catbox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frealoksi%2Ffoobar2000-catbox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frealoksi%2Ffoobar2000-catbox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f47db1aa322e3484cc97593c4156b103da289065 [INFO] linting realoksi/foobar2000-catbox against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frealoksi%2Ffoobar2000-catbox" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/realoksi/foobar2000-catbox [INFO] finished tweaking git repo https://github.com/realoksi/foobar2000-catbox [INFO] tweaked toml for git repo https://github.com/realoksi/foobar2000-catbox written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/realoksi/foobar2000-catbox on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/realoksi/foobar2000-catbox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zune-jpeg v0.4.14 [INFO] [stderr] Downloaded curl v0.4.47 [INFO] [stderr] Downloaded openssl-sys v0.9.108 [INFO] [stderr] Downloaded curl-sys v0.4.80+curl-8.12.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e5a00d24515e18bcd14bf8cac10232bf2b0512e973889277d95b6b0477fca500 [INFO] running `Command { std: "docker" "start" "-a" "e5a00d24515e18bcd14bf8cac10232bf2b0512e973889277d95b6b0477fca500", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e5a00d24515e18bcd14bf8cac10232bf2b0512e973889277d95b6b0477fca500", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5a00d24515e18bcd14bf8cac10232bf2b0512e973889277d95b6b0477fca500", kill_on_drop: false }` [INFO] [stdout] e5a00d24515e18bcd14bf8cac10232bf2b0512e973889277d95b6b0477fca500 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 28e9825a72da32fe5e65e3ea6da1adfeb7fc625ab51aba977f0117616ab3fef7 [INFO] running `Command { std: "docker" "start" "-a" "28e9825a72da32fe5e65e3ea6da1adfeb7fc625ab51aba977f0117616ab3fef7", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.2.24 [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling anyhow v1.0.98 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde_yml v0.0.12 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Checking hashbrown v0.15.3 [INFO] [stderr] Compiling curl v0.4.47 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking libyml v0.0.5 [INFO] [stderr] Checking image-webp v0.2.1 [INFO] [stderr] Checking zune-jpeg v0.4.14 [INFO] [stderr] Checking flate2 v1.1.1 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking socket2 v0.5.9 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking bytemuck v1.23.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling openssl-sys v0.9.108 [INFO] [stderr] Compiling libz-sys v1.1.22 [INFO] [stderr] Compiling curl-sys v0.4.80+curl-8.12.1 [INFO] [stderr] Checking image v0.25.6 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling strum_macros v0.27.1 [INFO] [stderr] Checking strum v0.27.1 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking foobar2000-catbox v1.0.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/consumer.rs:112:23 [INFO] [stdout] | [INFO] [stdout] 112 | .contents(&self.expire_time.as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.expire_time.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/settings.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | EncodeFormatQualityError(u8), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/settings.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | ResizeMaxResolutionZeroError([u32; 2]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/settings.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | ResizeMaxResolutionPowerError([u32; 2]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/settings.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | UserHashError(u8), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/settings.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / pub enum Error { [INFO] [stdout] 8 | | EncodeFormatQualityError(u8), [INFO] [stdout] 9 | | ResizeMaxResolutionZeroError([u32; 2]), [INFO] [stdout] 10 | | ResizeMaxResolutionPowerError([u32; 2]), [INFO] [stdout] 11 | | UserHashError(u8), [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/settings.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 117 | if !(self.resize_max_resolution[0] > 0) || !(self.resize_max_resolution[1] > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.resize_max_resolution[0] <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/settings.rs:117:52 [INFO] [stdout] | [INFO] [stdout] 117 | if !(self.resize_max_resolution[0] > 0) || !(self.resize_max_resolution[1] > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.resize_max_resolution[1] <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JPG` contains a capitalized acronym [INFO] [stdout] --> src/settings.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | JPG, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jpg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PNG` contains a capitalized acronym [INFO] [stdout] --> src/settings.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 145 | PNG, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Png` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WEBP` contains a capitalized acronym [INFO] [stdout] --> src/settings.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | WEBP, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Webp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/settings.rs:150:1 [INFO] [stdout] | [INFO] [stdout] 150 | / impl Default for EncodeFormat { [INFO] [stdout] 151 | | fn default() -> Self { [INFO] [stdout] 152 | | Self::JPG [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 141 + #[derive(Default)] [INFO] [stdout] 142 | pub enum EncodeFormat { [INFO] [stdout] 143 | #[strum(serialize = "JPEG", serialize = "JPG", ascii_case_insensitive)] [INFO] [stdout] 144 ~ #[default] [INFO] [stdout] 145 ~ JPG, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ONE` contains a capitalized acronym [INFO] [stdout] --> src/settings.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | ONE, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `One` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TWELVE` contains a capitalized acronym [INFO] [stdout] --> src/settings.rs:163:5 [INFO] [stdout] | [INFO] [stdout] 163 | TWELVE, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Twelve` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TWENTYFOUR` contains a capitalized acronym [INFO] [stdout] --> src/settings.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 166 | TWENTYFOUR, [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Twentyfour` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEVENTYTWO` contains a capitalized acronym [INFO] [stdout] --> src/settings.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 169 | SEVENTYTWO, [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Seventytwo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/settings.rs:172:1 [INFO] [stdout] | [INFO] [stdout] 172 | / impl Default for ExpireTime { [INFO] [stdout] 173 | | fn default() -> Self { [INFO] [stdout] 174 | | Self::TWENTYFOUR [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 157 + #[derive(Default)] [INFO] [stdout] 158 | pub enum ExpireTime { [INFO] [stdout] 159 | #[serde(rename = "1h")] [INFO] [stdout] ... [INFO] [stdout] 166 | #[strum(serialize = "24h", ascii_case_insensitive)] [INFO] [stdout] 167 ~ #[default] [INFO] [stdout] 168 ~ TWENTYFOUR, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/settings.rs:234:43 [INFO] [stdout] | [INFO] [stdout] 234 | let settings = Settings::from_str(&ok_case1).unwrap(); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `ok_case1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/settings.rs:245:43 [INFO] [stdout] | [INFO] [stdout] 245 | let settings = Settings::from_str(&ok_case1).unwrap(); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `ok_case1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/settings.rs:252:43 [INFO] [stdout] | [INFO] [stdout] 252 | let settings = Settings::from_str(&err_case1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `err_case1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/settings.rs:260:43 [INFO] [stdout] | [INFO] [stdout] 260 | let settings = Settings::from_str(&err_case2).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `err_case2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/settings.rs:272:43 [INFO] [stdout] | [INFO] [stdout] 272 | let settings = Settings::from_str(&ok_case1).unwrap(); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `ok_case1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/settings.rs:281:43 [INFO] [stdout] | [INFO] [stdout] 281 | let settings = Settings::from_str(&err_case1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `err_case1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/settings.rs:291:43 [INFO] [stdout] | [INFO] [stdout] 291 | let settings = Settings::from_str(&err_case2).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `err_case2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/settings.rs:301:43 [INFO] [stdout] | [INFO] [stdout] 301 | let settings = Settings::from_str(&err_case3).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `err_case3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/settings.rs:311:43 [INFO] [stdout] | [INFO] [stdout] 311 | let settings = Settings::from_str(&err_case4).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `err_case4` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/settings.rs:321:43 [INFO] [stdout] | [INFO] [stdout] 321 | let settings = Settings::from_str(&err_case5).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `err_case5` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/main.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | .unwrap_or(Settings::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:62:46 [INFO] [stdout] | [INFO] [stdout] 62 | let file_buffer: Vec = std::fs::read(&file_path).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/consumer.rs:112:23 [INFO] [stdout] | [INFO] [stdout] 112 | .contents(&self.expire_time.as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.expire_time.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/settings.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | EncodeFormatQualityError(u8), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/settings.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | ResizeMaxResolutionZeroError([u32; 2]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/settings.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | ResizeMaxResolutionPowerError([u32; 2]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/settings.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | UserHashError(u8), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/settings.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / pub enum Error { [INFO] [stdout] 8 | | EncodeFormatQualityError(u8), [INFO] [stdout] 9 | | ResizeMaxResolutionZeroError([u32; 2]), [INFO] [stdout] 10 | | ResizeMaxResolutionPowerError([u32; 2]), [INFO] [stdout] 11 | | UserHashError(u8), [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/settings.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 117 | if !(self.resize_max_resolution[0] > 0) || !(self.resize_max_resolution[1] > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.resize_max_resolution[0] <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/settings.rs:117:52 [INFO] [stdout] | [INFO] [stdout] 117 | if !(self.resize_max_resolution[0] > 0) || !(self.resize_max_resolution[1] > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.resize_max_resolution[1] <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JPG` contains a capitalized acronym [INFO] [stdout] --> src/settings.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | JPG, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jpg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PNG` contains a capitalized acronym [INFO] [stdout] --> src/settings.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 145 | PNG, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Png` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WEBP` contains a capitalized acronym [INFO] [stdout] --> src/settings.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | WEBP, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Webp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/settings.rs:150:1 [INFO] [stdout] | [INFO] [stdout] 150 | / impl Default for EncodeFormat { [INFO] [stdout] 151 | | fn default() -> Self { [INFO] [stdout] 152 | | Self::JPG [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 141 + #[derive(Default)] [INFO] [stdout] 142 | pub enum EncodeFormat { [INFO] [stdout] 143 | #[strum(serialize = "JPEG", serialize = "JPG", ascii_case_insensitive)] [INFO] [stdout] 144 ~ #[default] [INFO] [stdout] 145 ~ JPG, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ONE` contains a capitalized acronym [INFO] [stdout] --> src/settings.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | ONE, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `One` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TWELVE` contains a capitalized acronym [INFO] [stdout] --> src/settings.rs:163:5 [INFO] [stdout] | [INFO] [stdout] 163 | TWELVE, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Twelve` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TWENTYFOUR` contains a capitalized acronym [INFO] [stdout] --> src/settings.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 166 | TWENTYFOUR, [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Twentyfour` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEVENTYTWO` contains a capitalized acronym [INFO] [stdout] --> src/settings.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 169 | SEVENTYTWO, [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Seventytwo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/settings.rs:172:1 [INFO] [stdout] | [INFO] [stdout] 172 | / impl Default for ExpireTime { [INFO] [stdout] 173 | | fn default() -> Self { [INFO] [stdout] 174 | | Self::TWENTYFOUR [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 157 + #[derive(Default)] [INFO] [stdout] 158 | pub enum ExpireTime { [INFO] [stdout] 159 | #[serde(rename = "1h")] [INFO] [stdout] ... [INFO] [stdout] 166 | #[strum(serialize = "24h", ascii_case_insensitive)] [INFO] [stdout] 167 ~ #[default] [INFO] [stdout] 168 ~ TWENTYFOUR, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/main.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | .unwrap_or(Settings::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:62:46 [INFO] [stdout] | [INFO] [stdout] 62 | let file_buffer: Vec = std::fs::read(&file_path).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 24.40s [INFO] running `Command { std: "docker" "inspect" "28e9825a72da32fe5e65e3ea6da1adfeb7fc625ab51aba977f0117616ab3fef7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28e9825a72da32fe5e65e3ea6da1adfeb7fc625ab51aba977f0117616ab3fef7", kill_on_drop: false }` [INFO] [stdout] 28e9825a72da32fe5e65e3ea6da1adfeb7fc625ab51aba977f0117616ab3fef7