[INFO] cloning repository https://github.com/rdni/interpreter [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rdni/interpreter" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frdni%2Finterpreter", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frdni%2Finterpreter'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d3db731d6c384f74617bc692a607f77b73aedcec [INFO] linting rdni/interpreter against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frdni%2Finterpreter" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/rdni/interpreter [INFO] finished tweaking git repo https://github.com/rdni/interpreter [INFO] tweaked toml for git repo https://github.com/rdni/interpreter written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rdni/interpreter on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rdni/interpreter already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6dd4fca90981c10ae8fdb09a04d648128733599fb9b3c297821f84c829ff2a80 [INFO] running `Command { std: "docker" "start" "-a" "6dd4fca90981c10ae8fdb09a04d648128733599fb9b3c297821f84c829ff2a80", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6dd4fca90981c10ae8fdb09a04d648128733599fb9b3c297821f84c829ff2a80", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6dd4fca90981c10ae8fdb09a04d648128733599fb9b3c297821f84c829ff2a80", kill_on_drop: false }` [INFO] [stdout] 6dd4fca90981c10ae8fdb09a04d648128733599fb9b3c297821f84c829ff2a80 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4cb04c9ef22c2cc6a3c807210e989628500079dff5a6a45e1d684cb44e63085e [INFO] running `Command { std: "docker" "start" "-a" "4cb04c9ef22c2cc6a3c807210e989628500079dff5a6a45e1d684cb44e63085e", kill_on_drop: false }` [INFO] [stderr] Checking interpreter v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/frontend/parser.rs:291:17 [INFO] [stdout] | [INFO] [stdout] 291 | value: value [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/frontend/parser.rs:291:17 [INFO] [stdout] | [INFO] [stdout] 291 | value: value [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/frontend/ast.rs:162:27 [INFO] [stdout] | [INFO] [stdout] 162 | let new_env = Arc::new(Mutex::new(Environment::new(Some(Arc::clone(&env))))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc>` is not `Send` and `Sync` as `Mutex` is neither `Send` nor `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `Mutex` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/frontend/lexer.rs:83:15 [INFO] [stdout] | [INFO] [stdout] 83 | while src.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!src.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/frontend/lexer.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | / if src[0] == '/' { [INFO] [stdout] 85 | | if src.len() > 1 { [INFO] [stdout] 86 | | if src[1] == '/' { [INFO] [stdout] 87 | | while src[0] != '\n' || src[0] != '\r' { [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 84 ~ if src[0] == '/' [INFO] [stdout] 85 ~ && src.len() > 1 { [INFO] [stdout] 86 | if src[1] == '/' { [INFO] [stdout] ... [INFO] [stdout] 90 | } [INFO] [stdout] 91 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/frontend/lexer.rs:85:17 [INFO] [stdout] | [INFO] [stdout] 85 | / if src.len() > 1 { [INFO] [stdout] 86 | | if src[1] == '/' { [INFO] [stdout] 87 | | while src[0] != '\n' || src[0] != '\r' { [INFO] [stdout] 88 | | src.remove(0); [INFO] [stdout] ... | [INFO] [stdout] 91 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 85 ~ if src.len() > 1 [INFO] [stdout] 86 ~ && src[1] == '/' { [INFO] [stdout] 87 | while src[0] != '\n' || src[0] != '\r' { [INFO] [stdout] 88 | src.remove(0); [INFO] [stdout] 89 | } [INFO] [stdout] 90 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/frontend/lexer.rs:130:23 [INFO] [stdout] | [INFO] [stdout] 130 | while src.len() > 0 && (src[0] != '"' || escaped) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!src.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/frontend/lexer.rs:166:27 [INFO] [stdout] | [INFO] [stdout] 166 | while src.len() > 0 && (src[0].is_numeric() || src[0] == '.') { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!src.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/frontend/lexer.rs:174:27 [INFO] [stdout] | [INFO] [stdout] 174 | while src.len() > 0 && (is_valid_ident_char(src[0])) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!src.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/frontend/parser.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | / return StmtWrapper::new(Box::new(ReturnStmt { [INFO] [stdout] 209 | | kind: NodeType::Return, [INFO] [stdout] 210 | | value [INFO] [stdout] 211 | | })); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 ~ StmtWrapper::new(Box::new(ReturnStmt { [INFO] [stdout] 209 + kind: NodeType::Return, [INFO] [stdout] 210 + value [INFO] [stdout] 211 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/frontend/parser.rs:232:9 [INFO] [stdout] | [INFO] [stdout] 232 | / return StmtWrapper::new(Box::new(FunctionDeclaration { [INFO] [stdout] 233 | | kind: NodeType::FunctionDeclaration, [INFO] [stdout] 234 | | parameters: params, [INFO] [stdout] 235 | | name, [INFO] [stdout] 236 | | body, [INFO] [stdout] 237 | | })); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 232 ~ StmtWrapper::new(Box::new(FunctionDeclaration { [INFO] [stdout] 233 + kind: NodeType::FunctionDeclaration, [INFO] [stdout] 234 + parameters: params, [INFO] [stdout] 235 + name, [INFO] [stdout] 236 + body, [INFO] [stdout] 237 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/parser.rs:403:31 [INFO] [stdout] | [INFO] [stdout] 403 | if !self.not_eof() && !self.at_comparative_expr().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.at_comparative_expr().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/frontend/parser.rs:498:8 [INFO] [stdout] | [INFO] [stdout] 498 | return args; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 498 - return args; [INFO] [stdout] 498 + args [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/frontend/parser.rs:509:9 [INFO] [stdout] | [INFO] [stdout] 509 | return args; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 509 - return args; [INFO] [stdout] 509 + args [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting float literal to `f64` is unnecessary [INFO] [stdout] --> src/runtime/interpreter.rs:17:107 [INFO] [stdout] | [INFO] [stdout] 17 | Box::new(MK_NUMBER!(if let StmtValue::F64(val) = ast_node.get_value().unwrap() { val } else { 0.0 as f64}))}, [INFO] [stdout] | ^^^^^^^^^^ help: try: `0.0_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/runtime/interpreter.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 30 | let value = eval_identifier(identifier.clone(), Arc::clone(&env)); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 31 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 30 ~ [INFO] [stdout] 31 ~ (eval_identifier(identifier.clone(), Arc::clone(&env))) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/runtime/interpreter.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 35 | let value = eval_object_expr(object.clone(), Arc::clone(&env)); [INFO] [stdout] | --------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 36 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 35 ~ [INFO] [stdout] 36 ~ (eval_object_expr(object.clone(), Arc::clone(&env))) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/runtime/interpreter.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 44 | let value = eval_member_expr(member_expr.clone(), Arc::clone(&env)); [INFO] [stdout] | -------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 45 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 44 ~ [INFO] [stdout] 45 ~ (eval_member_expr(member_expr.clone(), Arc::clone(&env))) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/runtime/interpreter.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 49 | let value = eval_assignment(assignment_expr.clone(), Arc::clone(&env)); [INFO] [stdout] | ----------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 50 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 49 ~ [INFO] [stdout] 50 ~ (eval_assignment(assignment_expr.clone(), Arc::clone(&env))) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/runtime/interpreter.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 54 | let value = eval_call(call_expr.clone(), Arc::clone(&env)); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 55 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 54 ~ [INFO] [stdout] 55 ~ (eval_call(call_expr.clone(), Arc::clone(&env))) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/runtime/interpreter.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 60 | let value = eval_var_declaration(var_declaration.clone(), Arc::clone(&env)); [INFO] [stdout] | ---------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 61 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 60 ~ [INFO] [stdout] 61 ~ (eval_var_declaration(var_declaration.clone(), Arc::clone(&env))) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/runtime/interpreter.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 65 | let value = eval_function_declaration(function_declaration.clone(), Arc::clone(&env)); [INFO] [stdout] | -------------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 66 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 65 ~ [INFO] [stdout] 66 ~ (eval_function_declaration(function_declaration.clone(), Arc::clone(&env))) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BooleanValue` which implements the `Copy` trait [INFO] [stdout] --> src/runtime/values.rs:70:18 [INFO] [stdout] | [INFO] [stdout] 70 | Box::new(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NumberValue` which implements the `Copy` trait [INFO] [stdout] --> src/runtime/values.rs:124:18 [INFO] [stdout] | [INFO] [stdout] 124 | Box::new(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/runtime/values.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | String::from(self.value.to_string().replace(".0", "")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.value.to_string().replace(".0", "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/runtime/values.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 130 | String::from(self.value.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.value.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/runtime/values.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | self.properties.len() != 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.properties.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/runtime/values.rs:219:23 [INFO] [stdout] | [INFO] [stdout] 219 | value += &format!("{}", property.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `property.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/runtime/values.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 228 | self.elements.len() != 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.elements.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/runtime/values.rs:241:15 [INFO] [stdout] | [INFO] [stdout] 241 | pub func: Rc>, &Mutex) -> Box + 'static>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/runtime/values.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 303 | self.value.len() != 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/runtime/values.rs:320:23 [INFO] [stdout] | [INFO] [stdout] 320 | let new_env = Arc::new(Mutex::new(Environment::new(Some(Arc::clone(&env))))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc>` is not `Send` and `Sync` as `Mutex` is neither `Send` nor `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `Mutex` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/runtime/environment.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 47 | if let None = parent { [INFO] [stdout] | -------^^^^--------- help: try: `if parent.is_none()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/runtime/environment.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / if let None = self.parent { [INFO] [stdout] 70 | | true [INFO] [stdout] 71 | | } else { [INFO] [stdout] 72 | | false [INFO] [stdout] 73 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 69 - if let None = self.parent { [INFO] [stdout] 70 - true [INFO] [stdout] 71 - } else { [INFO] [stdout] 72 - false [INFO] [stdout] 73 - } [INFO] [stdout] 69 + matches!(self.parent, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/runtime/environment.rs:69:16 [INFO] [stdout] | [INFO] [stdout] 69 | if let None = self.parent { [INFO] [stdout] | -------^^^^-------------- help: try: `if self.parent.is_none()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime/environment.rs:101:24 [INFO] [stdout] | [INFO] [stdout] 101 | Arc::clone(&inner) [INFO] [stdout] | ^^^^^^ help: change this to: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime/environment.rs:104:39 [INFO] [stdout] | [INFO] [stdout] 104 | Some(v) => Arc::clone(&v), [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/runtime/environment.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | let env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `env` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 120 ~ [INFO] [stdout] 121 ~ let env = if bypass { [INFO] [stdout] 122 ~ Arc::clone(&self.0) [INFO] [stdout] 123 | } else { [INFO] [stdout] 124 ~ self.resolve(&varname) [INFO] [stdout] 125 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime/native_funcs.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / return Box::new(NumberValue { [INFO] [stdout] 22 | | value: SystemTime::now().duration_since(SystemTime::UNIX_EPOCH).unwrap().as_secs_f64() [INFO] [stdout] 23 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Box::new(NumberValue { [INFO] [stdout] 22 + value: SystemTime::now().duration_since(SystemTime::UNIX_EPOCH).unwrap().as_secs_f64() [INFO] [stdout] 23 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NumberValue` which implements the `Copy` trait [INFO] [stdout] --> src/runtime/native_funcs.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 35 | let number = args[0].as_any().downcast_ref::().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*args[0].as_any().downcast_ref::().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/runtime/native_funcs.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | / if args.len() == 1 { [INFO] [stdout] 48 | | if args[0].get_type() == ValueType::String { [INFO] [stdout] 49 | | print!("{}", args[0].as_any().downcast_ref::().expect("Failed to downcast to StringValue.").to_string()); [INFO] [stdout] 50 | | io::stdout().flush().unwrap(); [INFO] [stdout] 51 | | } [INFO] [stdout] 52 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 47 ~ if args.len() == 1 [INFO] [stdout] 48 ~ && args[0].get_type() == ValueType::String { [INFO] [stdout] 49 | print!("{}", args[0].as_any().downcast_ref::().expect("Failed to downcast to StringValue.").to_string()); [INFO] [stdout] 50 | io::stdout().flush().unwrap(); [INFO] [stdout] 51 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/eval/eval_statements.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return Box::new(NullValue {}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Box::new(NullValue {}); [INFO] [stdout] 29 + Box::new(NullValue {}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/eval/eval_statements.rs:58:11 [INFO] [stdout] | [INFO] [stdout] 58 | while eval(while_stmt.condition.to_stmt_from_expr(), last_env).as_bool() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `eval(while_stmt.condition.to_stmt_from_expr(), last_env).as_bool()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/eval/eval_statements.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 71 | if iterable.elements.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `iterable.elements.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NumberValue` which implements the `Copy` trait [INFO] [stdout] --> src/eval/eval_expressions.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | number = rhs.as_any().downcast_ref::().expect("Failed to downcast to NumberValue").clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*rhs.as_any().downcast_ref::().expect("Failed to downcast to NumberValue")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NumberValue` which implements the `Copy` trait [INFO] [stdout] --> src/eval/eval_expressions.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 30 | number = lhs.as_any().downcast_ref::().expect("Failed to downcast to NumberValue").clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*lhs.as_any().downcast_ref::().expect("Failed to downcast to NumberValue")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NumberValue` which implements the `Copy` trait [INFO] [stdout] --> src/eval/eval_expressions.rs:184:32 [INFO] [stdout] | [INFO] [stdout] 184 | ... = eval(member_expr.property.to_stmt_from_expr(), Arc::clone(&env)).as_any().downcast_ref::().expect("Expected number when indexing list").clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*eval(member_expr.property.to_stmt_from_expr(), Arc::clone(&env)).as_any().downcast_ref::().expect("Expected number when indexing list")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/eval/eval_expressions.rs:223:5 [INFO] [stdout] | [INFO] [stdout] 223 | return Box::new(object); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - return Box::new(object); [INFO] [stdout] 223 + Box::new(object) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `obj.elements.get(obj.elements.len() - 1)` [INFO] [stdout] --> src/eval/eval_expressions.rs:280:20 [INFO] [stdout] | [INFO] [stdout] 280 | return obj.elements.get(obj.elements.len() - 1).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `obj.elements.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/frontend/ast.rs:162:27 [INFO] [stdout] | [INFO] [stdout] 162 | let new_env = Arc::new(Mutex::new(Environment::new(Some(Arc::clone(&env))))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc>` is not `Send` and `Sync` as `Mutex` is neither `Send` nor `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `Mutex` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/frontend/lexer.rs:83:15 [INFO] [stdout] | [INFO] [stdout] 83 | while src.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!src.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/frontend/lexer.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | / if src[0] == '/' { [INFO] [stdout] 85 | | if src.len() > 1 { [INFO] [stdout] 86 | | if src[1] == '/' { [INFO] [stdout] 87 | | while src[0] != '\n' || src[0] != '\r' { [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 84 ~ if src[0] == '/' [INFO] [stdout] 85 ~ && src.len() > 1 { [INFO] [stdout] 86 | if src[1] == '/' { [INFO] [stdout] ... [INFO] [stdout] 90 | } [INFO] [stdout] 91 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/frontend/lexer.rs:85:17 [INFO] [stdout] | [INFO] [stdout] 85 | / if src.len() > 1 { [INFO] [stdout] 86 | | if src[1] == '/' { [INFO] [stdout] 87 | | while src[0] != '\n' || src[0] != '\r' { [INFO] [stdout] 88 | | src.remove(0); [INFO] [stdout] ... | [INFO] [stdout] 91 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 85 ~ if src.len() > 1 [INFO] [stdout] 86 ~ && src[1] == '/' { [INFO] [stdout] 87 | while src[0] != '\n' || src[0] != '\r' { [INFO] [stdout] 88 | src.remove(0); [INFO] [stdout] 89 | } [INFO] [stdout] 90 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/frontend/lexer.rs:130:23 [INFO] [stdout] | [INFO] [stdout] 130 | while src.len() > 0 && (src[0] != '"' || escaped) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!src.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/frontend/lexer.rs:166:27 [INFO] [stdout] | [INFO] [stdout] 166 | while src.len() > 0 && (src[0].is_numeric() || src[0] == '.') { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!src.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/frontend/lexer.rs:174:27 [INFO] [stdout] | [INFO] [stdout] 174 | while src.len() > 0 && (is_valid_ident_char(src[0])) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!src.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/main.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 23 | let env = Arc::new(Mutex::new(Environment::new(None))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc>` is not `Send` and `Sync` as `Mutex` is neither `Send` nor `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `Mutex` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/frontend/parser.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | / return StmtWrapper::new(Box::new(ReturnStmt { [INFO] [stdout] 209 | | kind: NodeType::Return, [INFO] [stdout] 210 | | value [INFO] [stdout] 211 | | })); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 ~ StmtWrapper::new(Box::new(ReturnStmt { [INFO] [stdout] 209 + kind: NodeType::Return, [INFO] [stdout] 210 + value [INFO] [stdout] 211 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/frontend/parser.rs:232:9 [INFO] [stdout] | [INFO] [stdout] 232 | / return StmtWrapper::new(Box::new(FunctionDeclaration { [INFO] [stdout] 233 | | kind: NodeType::FunctionDeclaration, [INFO] [stdout] 234 | | parameters: params, [INFO] [stdout] 235 | | name, [INFO] [stdout] 236 | | body, [INFO] [stdout] 237 | | })); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 232 ~ StmtWrapper::new(Box::new(FunctionDeclaration { [INFO] [stdout] 233 + kind: NodeType::FunctionDeclaration, [INFO] [stdout] 234 + parameters: params, [INFO] [stdout] 235 + name, [INFO] [stdout] 236 + body, [INFO] [stdout] 237 ~ })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/parser.rs:403:31 [INFO] [stdout] | [INFO] [stdout] 403 | if !self.not_eof() && !self.at_comparative_expr().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.at_comparative_expr().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/frontend/parser.rs:498:8 [INFO] [stdout] | [INFO] [stdout] 498 | return args; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 498 - return args; [INFO] [stdout] 498 + args [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/frontend/parser.rs:509:9 [INFO] [stdout] | [INFO] [stdout] 509 | return args; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 509 - return args; [INFO] [stdout] 509 + args [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting float literal to `f64` is unnecessary [INFO] [stdout] --> src/runtime/interpreter.rs:17:107 [INFO] [stdout] | [INFO] [stdout] 17 | Box::new(MK_NUMBER!(if let StmtValue::F64(val) = ast_node.get_value().unwrap() { val } else { 0.0 as f64}))}, [INFO] [stdout] | ^^^^^^^^^^ help: try: `0.0_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/runtime/interpreter.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 30 | let value = eval_identifier(identifier.clone(), Arc::clone(&env)); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 31 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 30 ~ [INFO] [stdout] 31 ~ (eval_identifier(identifier.clone(), Arc::clone(&env))) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/runtime/interpreter.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 35 | let value = eval_object_expr(object.clone(), Arc::clone(&env)); [INFO] [stdout] | --------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 36 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 35 ~ [INFO] [stdout] 36 ~ (eval_object_expr(object.clone(), Arc::clone(&env))) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/runtime/interpreter.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 44 | let value = eval_member_expr(member_expr.clone(), Arc::clone(&env)); [INFO] [stdout] | -------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 45 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 44 ~ [INFO] [stdout] 45 ~ (eval_member_expr(member_expr.clone(), Arc::clone(&env))) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/runtime/interpreter.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 49 | let value = eval_assignment(assignment_expr.clone(), Arc::clone(&env)); [INFO] [stdout] | ----------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 50 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 49 ~ [INFO] [stdout] 50 ~ (eval_assignment(assignment_expr.clone(), Arc::clone(&env))) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/runtime/interpreter.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 54 | let value = eval_call(call_expr.clone(), Arc::clone(&env)); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 55 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 54 ~ [INFO] [stdout] 55 ~ (eval_call(call_expr.clone(), Arc::clone(&env))) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/runtime/interpreter.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 60 | let value = eval_var_declaration(var_declaration.clone(), Arc::clone(&env)); [INFO] [stdout] | ---------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 61 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 60 ~ [INFO] [stdout] 61 ~ (eval_var_declaration(var_declaration.clone(), Arc::clone(&env))) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/runtime/interpreter.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 65 | let value = eval_function_declaration(function_declaration.clone(), Arc::clone(&env)); [INFO] [stdout] | -------------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 66 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 65 ~ [INFO] [stdout] 66 ~ (eval_function_declaration(function_declaration.clone(), Arc::clone(&env))) as _ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BooleanValue` which implements the `Copy` trait [INFO] [stdout] --> src/runtime/values.rs:70:18 [INFO] [stdout] | [INFO] [stdout] 70 | Box::new(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NumberValue` which implements the `Copy` trait [INFO] [stdout] --> src/runtime/values.rs:124:18 [INFO] [stdout] | [INFO] [stdout] 124 | Box::new(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/runtime/values.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | String::from(self.value.to_string().replace(".0", "")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.value.to_string().replace(".0", "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/runtime/values.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 130 | String::from(self.value.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.value.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/runtime/values.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | self.properties.len() != 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.properties.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/runtime/values.rs:219:23 [INFO] [stdout] | [INFO] [stdout] 219 | value += &format!("{}", property.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `property.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/runtime/values.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 228 | self.elements.len() != 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.elements.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/runtime/values.rs:241:15 [INFO] [stdout] | [INFO] [stdout] 241 | pub func: Rc>, &Mutex) -> Box + 'static>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/runtime/values.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 303 | self.value.len() != 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/runtime/values.rs:320:23 [INFO] [stdout] | [INFO] [stdout] 320 | let new_env = Arc::new(Mutex::new(Environment::new(Some(Arc::clone(&env))))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc>` is not `Send` and `Sync` as `Mutex` is neither `Send` nor `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `Mutex` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/runtime/environment.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 47 | if let None = parent { [INFO] [stdout] | -------^^^^--------- help: try: `if parent.is_none()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/runtime/environment.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / if let None = self.parent { [INFO] [stdout] 70 | | true [INFO] [stdout] 71 | | } else { [INFO] [stdout] 72 | | false [INFO] [stdout] 73 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 69 - if let None = self.parent { [INFO] [stdout] 70 - true [INFO] [stdout] 71 - } else { [INFO] [stdout] 72 - false [INFO] [stdout] 73 - } [INFO] [stdout] 69 + matches!(self.parent, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/runtime/environment.rs:69:16 [INFO] [stdout] | [INFO] [stdout] 69 | if let None = self.parent { [INFO] [stdout] | -------^^^^-------------- help: try: `if self.parent.is_none()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime/environment.rs:101:24 [INFO] [stdout] | [INFO] [stdout] 101 | Arc::clone(&inner) [INFO] [stdout] | ^^^^^^ help: change this to: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime/environment.rs:104:39 [INFO] [stdout] | [INFO] [stdout] 104 | Some(v) => Arc::clone(&v), [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/runtime/environment.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | let env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `env` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 120 ~ [INFO] [stdout] 121 ~ let env = if bypass { [INFO] [stdout] 122 ~ Arc::clone(&self.0) [INFO] [stdout] 123 | } else { [INFO] [stdout] 124 ~ self.resolve(&varname) [INFO] [stdout] 125 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/runtime/native_funcs.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / return Box::new(NumberValue { [INFO] [stdout] 22 | | value: SystemTime::now().duration_since(SystemTime::UNIX_EPOCH).unwrap().as_secs_f64() [INFO] [stdout] 23 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Box::new(NumberValue { [INFO] [stdout] 22 + value: SystemTime::now().duration_since(SystemTime::UNIX_EPOCH).unwrap().as_secs_f64() [INFO] [stdout] 23 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of an `Arc` that is not `Send` and `Sync` [INFO] [stdout] --> src/main.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 23 | let env = Arc::new(Mutex::new(Environment::new(None))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Arc>` is not `Send` and `Sync` as `Mutex` is neither `Send` nor `Sync` [INFO] [stdout] = help: if the `Arc` will not be used across threads replace it with an `Rc` [INFO] [stdout] = help: otherwise make `Mutex` `Send` and `Sync` or consider a wrapper type such as `Mutex` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync [INFO] [stdout] = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NumberValue` which implements the `Copy` trait [INFO] [stdout] --> src/runtime/native_funcs.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 35 | let number = args[0].as_any().downcast_ref::().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*args[0].as_any().downcast_ref::().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/runtime/native_funcs.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | / if args.len() == 1 { [INFO] [stdout] 48 | | if args[0].get_type() == ValueType::String { [INFO] [stdout] 49 | | print!("{}", args[0].as_any().downcast_ref::().expect("Failed to downcast to StringValue.").to_string()); [INFO] [stdout] 50 | | io::stdout().flush().unwrap(); [INFO] [stdout] 51 | | } [INFO] [stdout] 52 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 47 ~ if args.len() == 1 [INFO] [stdout] 48 ~ && args[0].get_type() == ValueType::String { [INFO] [stdout] 49 | print!("{}", args[0].as_any().downcast_ref::().expect("Failed to downcast to StringValue.").to_string()); [INFO] [stdout] 50 | io::stdout().flush().unwrap(); [INFO] [stdout] 51 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/eval/eval_statements.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return Box::new(NullValue {}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Box::new(NullValue {}); [INFO] [stdout] 29 + Box::new(NullValue {}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/eval/eval_statements.rs:58:11 [INFO] [stdout] | [INFO] [stdout] 58 | while eval(while_stmt.condition.to_stmt_from_expr(), last_env).as_bool() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `eval(while_stmt.condition.to_stmt_from_expr(), last_env).as_bool()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/eval/eval_statements.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 71 | if iterable.elements.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `iterable.elements.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NumberValue` which implements the `Copy` trait [INFO] [stdout] --> src/eval/eval_expressions.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | number = rhs.as_any().downcast_ref::().expect("Failed to downcast to NumberValue").clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*rhs.as_any().downcast_ref::().expect("Failed to downcast to NumberValue")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NumberValue` which implements the `Copy` trait [INFO] [stdout] --> src/eval/eval_expressions.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 30 | number = lhs.as_any().downcast_ref::().expect("Failed to downcast to NumberValue").clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*lhs.as_any().downcast_ref::().expect("Failed to downcast to NumberValue")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NumberValue` which implements the `Copy` trait [INFO] [stdout] --> src/eval/eval_expressions.rs:184:32 [INFO] [stdout] | [INFO] [stdout] 184 | ... = eval(member_expr.property.to_stmt_from_expr(), Arc::clone(&env)).as_any().downcast_ref::().expect("Expected number when indexing list").clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*eval(member_expr.property.to_stmt_from_expr(), Arc::clone(&env)).as_any().downcast_ref::().expect("Expected number when indexing list")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/eval/eval_expressions.rs:223:5 [INFO] [stdout] | [INFO] [stdout] 223 | return Box::new(object); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - return Box::new(object); [INFO] [stdout] 223 + Box::new(object) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `obj.elements.get(obj.elements.len() - 1)` [INFO] [stdout] --> src/eval/eval_expressions.rs:280:20 [INFO] [stdout] | [INFO] [stdout] 280 | return obj.elements.get(obj.elements.len() - 1).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `obj.elements.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.98s [INFO] running `Command { std: "docker" "inspect" "4cb04c9ef22c2cc6a3c807210e989628500079dff5a6a45e1d684cb44e63085e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4cb04c9ef22c2cc6a3c807210e989628500079dff5a6a45e1d684cb44e63085e", kill_on_drop: false }` [INFO] [stdout] 4cb04c9ef22c2cc6a3c807210e989628500079dff5a6a45e1d684cb44e63085e