[INFO] cloning repository https://github.com/rctcwyvrn/toy_rust_db [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rctcwyvrn/toy_rust_db" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frctcwyvrn%2Ftoy_rust_db", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frctcwyvrn%2Ftoy_rust_db'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 49dc61457db0f86fc8f5c52252454b34d0e1dfdc [INFO] linting rctcwyvrn/toy_rust_db against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frctcwyvrn%2Ftoy_rust_db" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-5-tc1/source/rust-toolchain [INFO] started tweaking git repo https://github.com/rctcwyvrn/toy_rust_db [INFO] finished tweaking git repo https://github.com/rctcwyvrn/toy_rust_db [INFO] tweaked toml for git repo https://github.com/rctcwyvrn/toy_rust_db written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rctcwyvrn/toy_rust_db on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rctcwyvrn/toy_rust_db already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded csv-core v0.1.10 [INFO] [stderr] Downloaded regex-automata v0.1.9 [INFO] [stderr] Downloaded bstr v0.2.14 [INFO] [stderr] Downloaded csv v1.1.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1c94f02e5b244ec522cc6f13e233b052500ab635d23bb88cdd76bc4ac96a5ad8 [INFO] running `Command { std: "docker" "start" "-a" "1c94f02e5b244ec522cc6f13e233b052500ab635d23bb88cdd76bc4ac96a5ad8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1c94f02e5b244ec522cc6f13e233b052500ab635d23bb88cdd76bc4ac96a5ad8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c94f02e5b244ec522cc6f13e233b052500ab635d23bb88cdd76bc4ac96a5ad8", kill_on_drop: false }` [INFO] [stdout] 1c94f02e5b244ec522cc6f13e233b052500ab635d23bb88cdd76bc4ac96a5ad8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e15b1e7f54cb86f47751d7e6e5acf7c60ca759a0632de1c63ecfec780ca327c [INFO] running `Command { std: "docker" "start" "-a" "5e15b1e7f54cb86f47751d7e6e5acf7c60ca759a0632de1c63ecfec780ca327c", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling serde v1.0.117 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking bstr v0.2.14 [INFO] [stderr] Checking csv v1.1.4 [INFO] [stderr] Checking toy_rust_db v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `cols` is never read [INFO] [stdout] --> src/parser/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct ParsedQuery { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 10 | pub cols: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParsedQuery` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/data/mod.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | Ok(&self.loaded.get(&dataset).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.loaded.get(&dataset).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/data/mod.rs:48:36 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|r| r.map_err(|e| QueryError::from(e))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `QueryError::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LEQ` contains a capitalized acronym [INFO] [stdout] --> src/filter/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | LEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Leq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GEQ` contains a capitalized acronym [INFO] [stdout] --> src/filter/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | GEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Geq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `cols` is never read [INFO] [stdout] --> src/parser/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct ParsedQuery { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 10 | pub cols: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParsedQuery` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser/lexer.rs:38:22 [INFO] [stdout] | [INFO] [stdout] 38 | c if !(c == &'\"') => { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(c != &'\"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/data/mod.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | Ok(&self.loaded.get(&dataset).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.loaded.get(&dataset).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/data/mod.rs:48:36 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|r| r.map_err(|e| QueryError::from(e))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `QueryError::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/parser/lexer.rs:165:1 [INFO] [stdout] | [INFO] [stdout] 165 | impl Into> for Token { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 165 ~ impl From for Result { [INFO] [stdout] 166 ~ fn from(val: Token) -> Self { [INFO] [stdout] 167 ~ Ok(val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/parser/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod parser; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LEQ` contains a capitalized acronym [INFO] [stdout] --> src/filter/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | LEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Leq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GEQ` contains a capitalized acronym [INFO] [stdout] --> src/filter/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | GEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Geq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser/lexer.rs:38:22 [INFO] [stdout] | [INFO] [stdout] 38 | c if !(c == &'\"') => { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(c != &'\"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LEQ` contains a capitalized acronym [INFO] [stdout] --> src/parser/mod.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | LEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Leq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GEQ` contains a capitalized acronym [INFO] [stdout] --> src/parser/mod.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | GEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Geq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/lib.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | write!(f, "'{}':\n", self.query)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 16 - write!(f, "'{}':\n", self.query)?; [INFO] [stdout] 16 + writeln!(f, "'{}':", self.query)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/parser/lexer.rs:165:1 [INFO] [stdout] | [INFO] [stdout] 165 | impl Into> for Token { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 165 ~ impl From for Result { [INFO] [stdout] 166 ~ fn from(val: Token) -> Self { [INFO] [stdout] 167 ~ Ok(val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/lib.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | write!(f, "]\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 23 - write!(f, "]\n")?; [INFO] [stdout] 23 + writeln!(f, "]")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/parser/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod parser; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LEQ` contains a capitalized acronym [INFO] [stdout] --> src/parser/mod.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | LEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Leq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GEQ` contains a capitalized acronym [INFO] [stdout] --> src/parser/mod.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | GEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Geq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/lib.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | write!(f, "'{}':\n", self.query)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 16 - write!(f, "'{}':\n", self.query)?; [INFO] [stdout] 16 + writeln!(f, "'{}':", self.query)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/lib.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | write!(f, "]\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 23 - write!(f, "]\n")?; [INFO] [stdout] 23 + writeln!(f, "]")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.39s [INFO] running `Command { std: "docker" "inspect" "5e15b1e7f54cb86f47751d7e6e5acf7c60ca759a0632de1c63ecfec780ca327c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e15b1e7f54cb86f47751d7e6e5acf7c60ca759a0632de1c63ecfec780ca327c", kill_on_drop: false }` [INFO] [stdout] 5e15b1e7f54cb86f47751d7e6e5acf7c60ca759a0632de1c63ecfec780ca327c