[INFO] cloning repository https://github.com/rcardenes/tftpd [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rcardenes/tftpd" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frcardenes%2Ftftpd", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frcardenes%2Ftftpd'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1910f357b5477755d1eb44544f1c07834238afa4 [INFO] linting rcardenes/tftpd against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frcardenes%2Ftftpd" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/rcardenes/tftpd [INFO] finished tweaking git repo https://github.com/rcardenes/tftpd [INFO] tweaked toml for git repo https://github.com/rcardenes/tftpd written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rcardenes/tftpd on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rcardenes/tftpd already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.3 [INFO] [stderr] Downloaded syn v2.0.53 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d313e12e65a736ea6a77ddb28ef8f3e306b93831cdec880c283a9ca2d3a55574 [INFO] running `Command { std: "docker" "start" "-a" "d313e12e65a736ea6a77ddb28ef8f3e306b93831cdec880c283a9ca2d3a55574", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d313e12e65a736ea6a77ddb28ef8f3e306b93831cdec880c283a9ca2d3a55574", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d313e12e65a736ea6a77ddb28ef8f3e306b93831cdec880c283a9ca2d3a55574", kill_on_drop: false }` [INFO] [stdout] d313e12e65a736ea6a77ddb28ef8f3e306b93831cdec880c283a9ca2d3a55574 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0ede1d54bcb03df058272cae507d2537d9bba28aabf7509b08c7427881f3243c [INFO] running `Command { std: "docker" "start" "-a" "0ede1d54bcb03df058272cae507d2537d9bba28aabf7509b08c7427881f3243c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking clap v4.5.3 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking tftpd v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/lib.rs:203:32 [INFO] [stdout] | [INFO] [stdout] 203 | .filter(|&val| (val > 7 && val < 65465)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 203 - .filter(|&val| (val > 7 && val < 65465)) [INFO] [stdout] 203 + .filter(|&val| val > 7 && val < 65465) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `PacketType` is never used [INFO] [stdout] --> src/lib.rs:2:6 [INFO] [stdout] | [INFO] [stdout] 2 | enum PacketType { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lib.rs:192:20 [INFO] [stdout] | [INFO] [stdout] 192 | .chain(self.encoded_value().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 192 - .chain(self.encoded_value().into_iter()) [INFO] [stdout] 192 + .chain(self.encoded_value()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/lib.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | / value.parse::() [INFO] [stdout] 202 | | .ok() [INFO] [stdout] 203 | | .filter(|&val| (val > 7 && val < 65465)) [INFO] [stdout] 204 | | .and_then(|val| Some(TftpOption::BlockSize(val))) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 201 ~ value.parse::() [INFO] [stdout] 202 + .ok() [INFO] [stdout] 203 + .filter(|&val| (val > 7 && val < 65465)).map(|val| TftpOption::BlockSize(val)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/lib.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 207 | / value.parse::() [INFO] [stdout] 208 | | .ok() [INFO] [stdout] 209 | | .filter(|&val| val > 0) [INFO] [stdout] 210 | | .and_then(|val| Some(TftpOption::Timeout(val))) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 207 ~ value.parse::() [INFO] [stdout] 208 + .ok() [INFO] [stdout] 209 + .filter(|&val| val > 0).map(|val| TftpOption::Timeout(val)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/lib.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | / value.parse::() [INFO] [stdout] 214 | | .ok() [INFO] [stdout] 215 | | .and_then(|val| Some(TftpOption::TransferSize(val))) [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 213 ~ value.parse::() [INFO] [stdout] 214 + .ok().map(|val| TftpOption::TransferSize(val)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/lib.rs:246:14 [INFO] [stdout] | [INFO] [stdout] 246 | .map(|chunk| parse_option(&chunk[0], &chunk[1])) [INFO] [stdout] | ______________^ [INFO] [stdout] 247 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `filter_map` and remove the `.flatten()`: `filter_map(|chunk| parse_option(&chunk[0], &chunk[1]))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/lib.rs:203:32 [INFO] [stdout] | [INFO] [stdout] 203 | .filter(|&val| (val > 7 && val < 65465)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 203 - .filter(|&val| (val > 7 && val < 65465)) [INFO] [stdout] 203 + .filter(|&val| val > 7 && val < 65465) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `PacketType` is never used [INFO] [stdout] --> src/lib.rs:2:6 [INFO] [stdout] | [INFO] [stdout] 2 | enum PacketType { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lib.rs:192:20 [INFO] [stdout] | [INFO] [stdout] 192 | .chain(self.encoded_value().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 192 - .chain(self.encoded_value().into_iter()) [INFO] [stdout] 192 + .chain(self.encoded_value()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/lib.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | / value.parse::() [INFO] [stdout] 202 | | .ok() [INFO] [stdout] 203 | | .filter(|&val| (val > 7 && val < 65465)) [INFO] [stdout] 204 | | .and_then(|val| Some(TftpOption::BlockSize(val))) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 201 ~ value.parse::() [INFO] [stdout] 202 + .ok() [INFO] [stdout] 203 + .filter(|&val| (val > 7 && val < 65465)).map(|val| TftpOption::BlockSize(val)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/lib.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 207 | / value.parse::() [INFO] [stdout] 208 | | .ok() [INFO] [stdout] 209 | | .filter(|&val| val > 0) [INFO] [stdout] 210 | | .and_then(|val| Some(TftpOption::Timeout(val))) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 207 ~ value.parse::() [INFO] [stdout] 208 + .ok() [INFO] [stdout] 209 + .filter(|&val| val > 0).map(|val| TftpOption::Timeout(val)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/lib.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | / value.parse::() [INFO] [stdout] 214 | | .ok() [INFO] [stdout] 215 | | .and_then(|val| Some(TftpOption::TransferSize(val))) [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 213 ~ value.parse::() [INFO] [stdout] 214 + .ok().map(|val| TftpOption::TransferSize(val)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/lib.rs:246:14 [INFO] [stdout] | [INFO] [stdout] 246 | .map(|chunk| parse_option(&chunk[0], &chunk[1])) [INFO] [stdout] | ______________^ [INFO] [stdout] 247 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `filter_map` and remove the `.flatten()`: `filter_map(|chunk| parse_option(&chunk[0], &chunk[1]))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | / match res { [INFO] [stdout] 91 | | Err(error) => eprintln!("While trying to send an error message: {error:?}"), [INFO] [stdout] 92 | | _ => {} [INFO] [stdout] 93 | | } [INFO] [stdout] | |_____^ help: try: `if let Err(error) = res { eprintln!("While trying to send an error message: {error:?}") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | / match opt { [INFO] [stdout] 99 | | TftpOption::BlockSize(bls) => { return *bls as usize }, [INFO] [stdout] 100 | | _ => {} [INFO] [stdout] 101 | | } [INFO] [stdout] | |_________^ help: try: `if let TftpOption::BlockSize(bls) = opt { return *bls as usize }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | / match opt { [INFO] [stdout] 110 | | TftpOption::Timeout(tout) => { return *tout as u64 }, [INFO] [stdout] 111 | | _ => {} [INFO] [stdout] 112 | | } [INFO] [stdout] | |_________^ help: try: `if let TftpOption::Timeout(tout) = opt { return *tout as u64 }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | / match opt { [INFO] [stdout] 121 | | TftpOption::TransferSize(tsize) => { return Some(*tsize) }, [INFO] [stdout] 122 | | _ => {} [INFO] [stdout] 123 | | } [INFO] [stdout] | |_________^ help: try: `if let TftpOption::TransferSize(tsize) = opt { return Some(*tsize) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:135:16 [INFO] [stdout] | [INFO] [stdout] 135 | if !sock.send(&packet).await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sock.send(&packet).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:135:27 [INFO] [stdout] | [INFO] [stdout] 135 | if !sock.send(&packet).await.is_ok() { [INFO] [stdout] | ^^^^^^^ help: change this to: `packet` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:150:29 [INFO] [stdout] | [INFO] [stdout] 150 | ... &sock, [INFO] [stdout] | ^^^^^ help: change this to: `sock` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:175:8 [INFO] [stdout] | [INFO] [stdout] 175 | if options.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!options.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | / match packet_and_ack(&sock, 0, &msg, block_size, tout).await { [INFO] [stdout] 191 | | Err(error) => eprintln!("{error}"), [INFO] [stdout] 192 | | _ => {} [INFO] [stdout] 193 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(error) = packet_and_ack(&sock, 0, &msg, block_size, tout).await { eprintln!("{error}") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | / match packet_and_ack(&sock, current_block, &message, block_size, tout).await { [INFO] [stdout] 211 | | Err(error) => eprintln!("{error}"), [INFO] [stdout] 212 | | _ => {} [INFO] [stdout] 213 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(error) = packet_and_ack(&sock, current_block, &message, block_size, tout).await { eprintln!("{error}") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:265:28 [INFO] [stdout] | [INFO] [stdout] 265 | if !sock.send_to( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 266 | | &ErrorCode::IllegalOperation [INFO] [stdout] 267 | | .into_message() [INFO] [stdout] 268 | | .into_packet(), [INFO] [stdout] 269 | | addr).await.is_ok() [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 265 ~ if sock.send_to( [INFO] [stdout] 266 + &ErrorCode::IllegalOperation [INFO] [stdout] 267 + .into_message() [INFO] [stdout] 268 + .into_packet(), [INFO] [stdout] 269 + addr).await.is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | / match res { [INFO] [stdout] 91 | | Err(error) => eprintln!("While trying to send an error message: {error:?}"), [INFO] [stdout] 92 | | _ => {} [INFO] [stdout] 93 | | } [INFO] [stdout] | |_____^ help: try: `if let Err(error) = res { eprintln!("While trying to send an error message: {error:?}") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | / match opt { [INFO] [stdout] 99 | | TftpOption::BlockSize(bls) => { return *bls as usize }, [INFO] [stdout] 100 | | _ => {} [INFO] [stdout] 101 | | } [INFO] [stdout] | |_________^ help: try: `if let TftpOption::BlockSize(bls) = opt { return *bls as usize }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | / match opt { [INFO] [stdout] 110 | | TftpOption::Timeout(tout) => { return *tout as u64 }, [INFO] [stdout] 111 | | _ => {} [INFO] [stdout] 112 | | } [INFO] [stdout] | |_________^ help: try: `if let TftpOption::Timeout(tout) = opt { return *tout as u64 }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | / match opt { [INFO] [stdout] 121 | | TftpOption::TransferSize(tsize) => { return Some(*tsize) }, [INFO] [stdout] 122 | | _ => {} [INFO] [stdout] 123 | | } [INFO] [stdout] | |_________^ help: try: `if let TftpOption::TransferSize(tsize) = opt { return Some(*tsize) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:135:16 [INFO] [stdout] | [INFO] [stdout] 135 | if !sock.send(&packet).await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sock.send(&packet).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:135:27 [INFO] [stdout] | [INFO] [stdout] 135 | if !sock.send(&packet).await.is_ok() { [INFO] [stdout] | ^^^^^^^ help: change this to: `packet` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:150:29 [INFO] [stdout] | [INFO] [stdout] 150 | ... &sock, [INFO] [stdout] | ^^^^^ help: change this to: `sock` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:175:8 [INFO] [stdout] | [INFO] [stdout] 175 | if options.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!options.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | / match packet_and_ack(&sock, 0, &msg, block_size, tout).await { [INFO] [stdout] 191 | | Err(error) => eprintln!("{error}"), [INFO] [stdout] 192 | | _ => {} [INFO] [stdout] 193 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(error) = packet_and_ack(&sock, 0, &msg, block_size, tout).await { eprintln!("{error}") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | / match packet_and_ack(&sock, current_block, &message, block_size, tout).await { [INFO] [stdout] 211 | | Err(error) => eprintln!("{error}"), [INFO] [stdout] 212 | | _ => {} [INFO] [stdout] 213 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(error) = packet_and_ack(&sock, current_block, &message, block_size, tout).await { eprintln!("{error}") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:265:28 [INFO] [stdout] | [INFO] [stdout] 265 | if !sock.send_to( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 266 | | &ErrorCode::IllegalOperation [INFO] [stdout] 267 | | .into_message() [INFO] [stdout] 268 | | .into_packet(), [INFO] [stdout] 269 | | addr).await.is_ok() [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 265 ~ if sock.send_to( [INFO] [stdout] 266 + &ErrorCode::IllegalOperation [INFO] [stdout] 267 + .into_message() [INFO] [stdout] 268 + .into_packet(), [INFO] [stdout] 269 + addr).await.is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.00s [INFO] running `Command { std: "docker" "inspect" "0ede1d54bcb03df058272cae507d2537d9bba28aabf7509b08c7427881f3243c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ede1d54bcb03df058272cae507d2537d9bba28aabf7509b08c7427881f3243c", kill_on_drop: false }` [INFO] [stdout] 0ede1d54bcb03df058272cae507d2537d9bba28aabf7509b08c7427881f3243c