[INFO] cloning repository https://github.com/raudel25/rcf [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/raudel25/rcf" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fraudel25%2Frcf", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fraudel25%2Frcf'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 17a2f7dd88d635f261e7f9088da31e80d3a3dfef [INFO] linting raudel25/rcf against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fraudel25%2Frcf" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/raudel25/rcf [INFO] finished tweaking git repo https://github.com/raudel25/rcf [INFO] tweaked toml for git repo https://github.com/raudel25/rcf written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/raudel25/rcf on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/raudel25/rcf already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quote v1.0.28 [INFO] [stderr] Downloaded thin-slice v0.1.1 [INFO] [stderr] Downloaded siphasher v0.3.10 [INFO] [stderr] Downloaded errno v0.3.1 [INFO] [stderr] Downloaded proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Downloaded servo_arc v0.1.1 [INFO] [stderr] Downloaded new_debug_unreachable v1.0.4 [INFO] [stderr] Downloaded matches v0.1.10 [INFO] [stderr] Downloaded dtoa-short v0.3.4 [INFO] [stderr] Downloaded unicode-ident v1.0.9 [INFO] [stderr] Downloaded ego-tree v0.6.2 [INFO] [stderr] Downloaded ipnet v2.7.2 [INFO] [stderr] Downloaded colored v2.0.0 [INFO] [stderr] Downloaded openssl-sys v0.9.90 [INFO] [stderr] Downloaded html5ever v0.25.2 [INFO] [stderr] Downloaded security-framework v2.9.1 [INFO] [stderr] Downloaded bumpalo v3.13.0 [INFO] [stderr] Downloaded serde v1.0.164 [INFO] [stderr] Downloaded h2 v0.3.19 [INFO] [stderr] Downloaded hyper v0.14.26 [INFO] [stderr] Downloaded serde_json v1.0.97 [INFO] [stderr] Downloaded syn v2.0.18 [INFO] [stderr] Downloaded cssparser v0.27.2 [INFO] [stderr] Downloaded serde_derive v1.0.164 [INFO] [stderr] Downloaded schannel v0.1.21 [INFO] [stderr] Downloaded tempfile v3.6.0 [INFO] [stderr] Downloaded openssl v0.10.55 [INFO] [stderr] Downloaded selectors v0.22.0 [INFO] [stderr] Downloaded rustix v0.37.20 [INFO] [stderr] Downloaded ryu v1.0.13 [INFO] [stderr] Downloaded proc-macro2 v1.0.60 [INFO] [stderr] Downloaded security-framework-sys v2.9.0 [INFO] [stderr] Downloaded markup5ever v0.10.1 [INFO] [stderr] Downloaded dtoa v1.0.6 [INFO] [stderr] Downloaded semver v1.0.17 [INFO] [stderr] Downloaded scraper v0.12.0 [INFO] [stderr] Downloaded itoa v1.0.6 [INFO] [stderr] Downloaded phf_macros v0.8.0 [INFO] [stderr] Downloaded tokio v1.28.2 [INFO] [stderr] Downloaded libc v0.2.146 [INFO] [stderr] Downloaded encoding_rs v0.8.32 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9ddfc671d45f56eb9c42f44cbd1ed1662239c46c858a3847a223e71015ec5d26 [INFO] running `Command { std: "docker" "start" "-a" "9ddfc671d45f56eb9c42f44cbd1ed1662239c46c858a3847a223e71015ec5d26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9ddfc671d45f56eb9c42f44cbd1ed1662239c46c858a3847a223e71015ec5d26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ddfc671d45f56eb9c42f44cbd1ed1662239c46c858a3847a223e71015ec5d26", kill_on_drop: false }` [INFO] [stdout] 9ddfc671d45f56eb9c42f44cbd1ed1662239c46c858a3847a223e71015ec5d26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 75b3f06a9d1c79b04093d167caeb4bb42b0cd6be02d81129114210fb643cfaaa [INFO] running `Command { std: "docker" "start" "-a" "75b3f06a9d1c79b04093d167caeb4bb42b0cd6be02d81129114210fb643cfaaa", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling siphasher v0.3.10 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling phf_shared v0.8.0 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling serde v1.0.164 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Compiling tokio v1.28.2 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling getrandom v0.2.10 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling openssl-sys v0.9.90 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling openssl v0.10.55 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stderr] Compiling phf_codegen v0.8.0 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Compiling markup5ever v0.10.1 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking dtoa v1.0.6 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking dtoa-short v0.3.4 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Compiling selectors v0.22.0 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking servo_arc v0.1.1 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking thin-slice v0.1.1 [INFO] [stderr] Compiling serde_json v1.0.97 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking encoding_rs v0.8.32 [INFO] [stderr] Checking ego-tree v0.6.2 [INFO] [stderr] Checking ipnet v2.7.2 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.164 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Compiling phf_macros v0.8.0 [INFO] [stderr] Compiling cssparser v0.27.2 [INFO] [stderr] Compiling html5ever v0.25.2 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking phf v0.8.0 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.19 [INFO] [stderr] Checking string_cache v0.8.7 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking scraper v0.12.0 [INFO] [stderr] Checking hyper v0.14.26 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.18 [INFO] [stderr] Checking rcf v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/contest.rs:4:27 [INFO] [stdout] | [INFO] [stdout] 4 | pub async fn get_problems<'a>(contest_id: i32) -> Result, Error> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/languages.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/languages.rs:56:26 [INFO] [stdout] | [INFO] [stdout] 56 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/languages.rs:57:32 [INFO] [stdout] | [INFO] [stdout] 57 | fs::create_dir_all(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/languages.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/languages.rs:73:26 [INFO] [stdout] | [INFO] [stdout] 73 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/languages.rs:74:32 [INFO] [stdout] | [INFO] [stdout] 74 | fs::create_dir_all(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/languages.rs:98:27 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn get_language(path: &PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 98 - pub fn get_language(path: &PathBuf) -> Result { [INFO] [stdout] 98 + pub fn get_language(path: &Path) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::SplitWhitespace<'_>` [INFO] [stdout] --> src/system.rs:5:28 [INFO] [stdout] | [INFO] [stdout] 5 | let commands: Vec<_> = command.split_whitespace().into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `command.split_whitespace()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::SplitWhitespace<'_>` [INFO] [stdout] --> src/system.rs:37:28 [INFO] [stdout] | [INFO] [stdout] 37 | let commands: Vec<_> = command.split_whitespace().into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `command.split_whitespace()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/test_cases.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/test_cases.rs:27:26 [INFO] [stdout] | [INFO] [stdout] 27 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/test_cases.rs:28:32 [INFO] [stdout] | [INFO] [stdout] 28 | fs::create_dir_all(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/test_cases.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | if lines.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/test_cases.rs:87:60 [INFO] [stdout] | [INFO] [stdout] 87 | for (i, (input, output)) in inputs.into_iter().zip(outputs.into_iter()).enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 87 - for (i, (input, output)) in inputs.into_iter().zip(outputs.into_iter()).enumerate() { [INFO] [stdout] 87 + for (i, (input, output)) in inputs.into_iter().zip(outputs).enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tester.rs:17:51 [INFO] [stdout] | [INFO] [stdout] 17 | for (input, output) in inputs.into_iter().zip(outputs.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 17 - for (input, output) in inputs.into_iter().zip(outputs.into_iter()) { [INFO] [stdout] 17 + for (input, output) in inputs.into_iter().zip(outputs) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tester.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return true; [INFO] [stdout] 72 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/tester.rs:66:28 [INFO] [stdout] | [INFO] [stdout] 66 | for (s1, s2) in output.into_iter().zip(out.into_iter()) { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/tester.rs:66:48 [INFO] [stdout] | [INFO] [stdout] 66 | for (s1, s2) in output.into_iter().zip(out.into_iter()) { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tester.rs:66:44 [INFO] [stdout] | [INFO] [stdout] 66 | for (s1, s2) in output.into_iter().zip(out.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 66 - for (s1, s2) in output.into_iter().zip(out.into_iter()) { [INFO] [stdout] 66 + for (s1, s2) in output.into_iter().zip(&*out) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/tester.rs:102:27 [INFO] [stdout] | [INFO] [stdout] 102 | fn analyze_failed(output: &Vec<&str>, out: &Vec<&str>) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 102 ~ fn analyze_failed(output: &[&str], out: &Vec<&str>) { [INFO] [stdout] 103 ~ let mut output: Vec<_> = output.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/tester.rs:102:44 [INFO] [stdout] | [INFO] [stdout] 102 | fn analyze_failed(output: &Vec<&str>, out: &Vec<&str>) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 102 ~ fn analyze_failed(output: &Vec<&str>, out: &[&str]) { [INFO] [stdout] 103 | let mut output: Vec<_> = output.clone(); [INFO] [stdout] 104 ~ let mut out: Vec<_> = out.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tester.rs:110:44 [INFO] [stdout] | [INFO] [stdout] 110 | for (s1, s2) in output.into_iter().zip(out.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 110 - for (s1, s2) in output.into_iter().zip(out.into_iter()) { [INFO] [stdout] 110 + for (s1, s2) in output.into_iter().zip(out) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:40:66 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn clone_contest(contest_id: i32, language: &Language, path: &PathBuf) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 40 - pub fn clone_contest(contest_id: i32, language: &Language, path: &PathBuf) { [INFO] [stdout] 40 + pub fn clone_contest(contest_id: i32, language: &Language, path: &Path) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/contest.rs:4:27 [INFO] [stdout] | [INFO] [stdout] 4 | pub async fn get_problems<'a>(contest_id: i32) -> Result, Error> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/languages.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/languages.rs:56:26 [INFO] [stdout] | [INFO] [stdout] 56 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/languages.rs:57:32 [INFO] [stdout] | [INFO] [stdout] 57 | fs::create_dir_all(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/languages.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/languages.rs:73:26 [INFO] [stdout] | [INFO] [stdout] 73 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/languages.rs:74:32 [INFO] [stdout] | [INFO] [stdout] 74 | fs::create_dir_all(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/languages.rs:98:27 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn get_language(path: &PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 98 - pub fn get_language(path: &PathBuf) -> Result { [INFO] [stdout] 98 + pub fn get_language(path: &Path) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::SplitWhitespace<'_>` [INFO] [stdout] --> src/system.rs:5:28 [INFO] [stdout] | [INFO] [stdout] 5 | let commands: Vec<_> = command.split_whitespace().into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `command.split_whitespace()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::SplitWhitespace<'_>` [INFO] [stdout] --> src/system.rs:37:28 [INFO] [stdout] | [INFO] [stdout] 37 | let commands: Vec<_> = command.split_whitespace().into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `command.split_whitespace()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/test_cases.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/test_cases.rs:27:26 [INFO] [stdout] | [INFO] [stdout] 27 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/test_cases.rs:28:32 [INFO] [stdout] | [INFO] [stdout] 28 | fs::create_dir_all(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/test_cases.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | if lines.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/test_cases.rs:87:60 [INFO] [stdout] | [INFO] [stdout] 87 | for (i, (input, output)) in inputs.into_iter().zip(outputs.into_iter()).enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 87 - for (i, (input, output)) in inputs.into_iter().zip(outputs.into_iter()).enumerate() { [INFO] [stdout] 87 + for (i, (input, output)) in inputs.into_iter().zip(outputs).enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tester.rs:17:51 [INFO] [stdout] | [INFO] [stdout] 17 | for (input, output) in inputs.into_iter().zip(outputs.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 17 - for (input, output) in inputs.into_iter().zip(outputs.into_iter()) { [INFO] [stdout] 17 + for (input, output) in inputs.into_iter().zip(outputs) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tester.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return true; [INFO] [stdout] 72 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/tester.rs:66:28 [INFO] [stdout] | [INFO] [stdout] 66 | for (s1, s2) in output.into_iter().zip(out.into_iter()) { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/tester.rs:66:48 [INFO] [stdout] | [INFO] [stdout] 66 | for (s1, s2) in output.into_iter().zip(out.into_iter()) { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tester.rs:66:44 [INFO] [stdout] | [INFO] [stdout] 66 | for (s1, s2) in output.into_iter().zip(out.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 66 - for (s1, s2) in output.into_iter().zip(out.into_iter()) { [INFO] [stdout] 66 + for (s1, s2) in output.into_iter().zip(&*out) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/tester.rs:102:27 [INFO] [stdout] | [INFO] [stdout] 102 | fn analyze_failed(output: &Vec<&str>, out: &Vec<&str>) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 102 ~ fn analyze_failed(output: &[&str], out: &Vec<&str>) { [INFO] [stdout] 103 ~ let mut output: Vec<_> = output.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/tester.rs:102:44 [INFO] [stdout] | [INFO] [stdout] 102 | fn analyze_failed(output: &Vec<&str>, out: &Vec<&str>) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 102 ~ fn analyze_failed(output: &Vec<&str>, out: &[&str]) { [INFO] [stdout] 103 | let mut output: Vec<_> = output.clone(); [INFO] [stdout] 104 ~ let mut out: Vec<_> = out.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tester.rs:110:44 [INFO] [stdout] | [INFO] [stdout] 110 | for (s1, s2) in output.into_iter().zip(out.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 110 - for (s1, s2) in output.into_iter().zip(out.into_iter()) { [INFO] [stdout] 110 + for (s1, s2) in output.into_iter().zip(out) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:40:66 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn clone_contest(contest_id: i32, language: &Language, path: &PathBuf) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 40 - pub fn clone_contest(contest_id: i32, language: &Language, path: &PathBuf) { [INFO] [stdout] 40 + pub fn clone_contest(contest_id: i32, language: &Language, path: &Path) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | if arg == "" { [INFO] [stdout] | ^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `arg.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:41:18 [INFO] [stdout] | [INFO] [stdout] 41 | fn contest(args: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 - fn contest(args: &Vec) { [INFO] [stdout] 41 + fn contest(args: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 78 | fn problem(args: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - fn problem(args: &Vec) { [INFO] [stdout] 78 + fn problem(args: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | fn test_e(args: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 115 - fn test_e(args: &Vec) { [INFO] [stdout] 115 + fn test_e(args: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | if arg == "" { [INFO] [stdout] | ^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `arg.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:41:18 [INFO] [stdout] | [INFO] [stdout] 41 | fn contest(args: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 - fn contest(args: &Vec) { [INFO] [stdout] 41 + fn contest(args: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 78 | fn problem(args: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - fn problem(args: &Vec) { [INFO] [stdout] 78 + fn problem(args: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | fn test_e(args: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 115 - fn test_e(args: &Vec) { [INFO] [stdout] 115 + fn test_e(args: &[String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 04s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: openssl v0.10.55 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "75b3f06a9d1c79b04093d167caeb4bb42b0cd6be02d81129114210fb643cfaaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75b3f06a9d1c79b04093d167caeb4bb42b0cd6be02d81129114210fb643cfaaa", kill_on_drop: false }` [INFO] [stdout] 75b3f06a9d1c79b04093d167caeb4bb42b0cd6be02d81129114210fb643cfaaa