[INFO] cloning repository https://github.com/ratnadeep007/override-vm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ratnadeep007/override-vm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fratnadeep007%2Foverride-vm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fratnadeep007%2Foverride-vm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fca1e5898a02cf4b46c600dd8001eda30b157f76 [INFO] linting ratnadeep007/override-vm against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fratnadeep007%2Foverride-vm" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ratnadeep007/override-vm [INFO] finished tweaking git repo https://github.com/ratnadeep007/override-vm [INFO] tweaked toml for git repo https://github.com/ratnadeep007/override-vm written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ratnadeep007/override-vm on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ratnadeep007/override-vm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b84719bb3d0fff1233926f48256b2d020a8c5ab9aab24da69497edc628588d1b [INFO] running `Command { std: "docker" "start" "-a" "b84719bb3d0fff1233926f48256b2d020a8c5ab9aab24da69497edc628588d1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b84719bb3d0fff1233926f48256b2d020a8c5ab9aab24da69497edc628588d1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b84719bb3d0fff1233926f48256b2d020a8c5ab9aab24da69497edc628588d1b", kill_on_drop: false }` [INFO] [stdout] b84719bb3d0fff1233926f48256b2d020a8c5ab9aab24da69497edc628588d1b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d8bf3eb2e0cd0fdda61c600c1c72e67a820f9136d2651c4e87fa27c738d1b7a2 [INFO] running `Command { std: "docker" "start" "-a" "d8bf3eb2e0cd0fdda61c600c1c72e67a820f9136d2651c4e87fa27c738d1b7a2", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Checking override-vm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::vm::VM` [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::vm::VM; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/opcode_parsers.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/register_parsers.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/operand_parsers.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::instruction::Opcode` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::instruction::Opcode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/program_parsers.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | instructions: instructions [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/program_parsers.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `parse_hex` is never used [INFO] [stdout] --> src/repl/mod.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 14 | impl REPL { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 73 | fn parse_hex(&mut self, i: &str) -> Result, ParseIntError> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `VM` [INFO] [stdout] --> src/vm.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> VM { [INFO] [stdout] 15 | | VM { [INFO] [stdout] 16 | | registers: [0; 32], [INFO] [stdout] 17 | | program: vec![], [INFO] [stdout] ... | [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for VM { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:89:17 [INFO] [stdout] | [INFO] [stdout] 89 | / if register1 == register2 { [INFO] [stdout] 90 | | self.equal_flag = true; [INFO] [stdout] 91 | | } else { [INFO] [stdout] 92 | | self.equal_flag = false; [INFO] [stdout] 93 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 == register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 99 | / if register1 != register2 { [INFO] [stdout] 100 | | self.equal_flag = true; [INFO] [stdout] 101 | | } else { [INFO] [stdout] 102 | | self.equal_flag = false; [INFO] [stdout] 103 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 != register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 109 | / if register1 > register2 { [INFO] [stdout] 110 | | self.equal_flag = true; [INFO] [stdout] 111 | | } else { [INFO] [stdout] 112 | | self.equal_flag = false; [INFO] [stdout] 113 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 > register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | / if register1 >= register2 { [INFO] [stdout] 120 | | self.equal_flag = true; [INFO] [stdout] 121 | | } else { [INFO] [stdout] 122 | | self.equal_flag = false; [INFO] [stdout] 123 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 >= register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | / if register1 < register2 { [INFO] [stdout] 130 | | self.equal_flag = true; [INFO] [stdout] 131 | | } else { [INFO] [stdout] 132 | | self.equal_flag = false; [INFO] [stdout] 133 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 < register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:139:17 [INFO] [stdout] | [INFO] [stdout] 139 | / if register1 <= register2 { [INFO] [stdout] 140 | | self.equal_flag = true; [INFO] [stdout] 141 | | } else { [INFO] [stdout] 142 | | self.equal_flag = false; [INFO] [stdout] 143 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 <= register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | return opcode; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return opcode; [INFO] [stdout] 165 + opcode [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return result; [INFO] [stdout] 171 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - return result; [INFO] [stdout] 177 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / return match v { [INFO] [stdout] 29 | | 0 => Opcode::LOAD, [INFO] [stdout] 30 | | 1 => Opcode::ADD, [INFO] [stdout] 31 | | 2 => Opcode::SUB, [INFO] [stdout] ... | [INFO] [stdout] 46 | | _ => Opcode::IGL [INFO] [stdout] 47 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ match v { [INFO] [stdout] 29 + 0 => Opcode::LOAD, [INFO] [stdout] 30 + 1 => Opcode::ADD, [INFO] [stdout] 31 + 2 => Opcode::SUB, [INFO] [stdout] 32 + 3 => Opcode::MUL, [INFO] [stdout] 33 + 4 => Opcode::DIV, [INFO] [stdout] 34 + 5 => Opcode::HLT, [INFO] [stdout] 35 + 6 => Opcode::JMP, [INFO] [stdout] 36 + 7 => Opcode::JMPF, [INFO] [stdout] 37 + 8 => Opcode::JMPB, [INFO] [stdout] 38 + 9 => Opcode::EQ, [INFO] [stdout] 39 + 10 => Opcode::NEQ, [INFO] [stdout] 40 + 11 => Opcode::GTE, [INFO] [stdout] 41 + 12 => Opcode::GT, [INFO] [stdout] 42 + 13 => Opcode::LTE, [INFO] [stdout] 43 + 14 => Opcode::LT, [INFO] [stdout] 44 + 15 => Opcode::JMPE, [INFO] [stdout] 45 + 16 => Opcode::NOP, [INFO] [stdout] 46 + _ => Opcode::IGL [INFO] [stdout] 47 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `REPL` [INFO] [stdout] --> src/repl/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> REPL { [INFO] [stdout] 16 | | REPL { [INFO] [stdout] 17 | | vm: VM::new(), [INFO] [stdout] 18 | | command_buffer: vec![] [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for REPL { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/repl/mod.rs:58:24 [INFO] [stdout] | [INFO] [stdout] 58 | if !parsed_program.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parsed_program.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/repl/mod.rs:77:43 [INFO] [stdout] | [INFO] [stdout] 77 | let byte = u8::from_str_radix(&hex_string, 16); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `hex_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/assembler/instruction_parsers.rs:23:35 [INFO] [stdout] | [INFO] [stdout] 23 | Token::Op { code } => match code { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 24 | | _ => { [INFO] [stdout] 25 | | results.push(code as u8); [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 23 ~ Token::Op { code } => { [INFO] [stdout] 24 + results.push(code as u8); [INFO] [stdout] 25 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | / match operand { [INFO] [stdout] 35 | | Some(t) => AssemblerInstruction::extract_operand(t, &mut results), [INFO] [stdout] 36 | | None => {} [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(t) = operand { AssemblerInstruction::extract_operand(t, &mut results) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:33:24 [INFO] [stdout] | [INFO] [stdout] 33 | for operand in vec![&self.operand1, &self.operand2, &self.operand3] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[&self.operand1, &self.operand2, &self.operand3]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vm::VM` [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::vm::VM; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::instruction::Opcode` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::instruction::Opcode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/program_parsers.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | instructions: instructions [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `parse_hex` is never used [INFO] [stdout] --> src/repl/mod.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 14 | impl REPL { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 73 | fn parse_hex(&mut self, i: &str) -> Result, ParseIntError> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `VM` [INFO] [stdout] --> src/vm.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> VM { [INFO] [stdout] 15 | | VM { [INFO] [stdout] 16 | | registers: [0; 32], [INFO] [stdout] 17 | | program: vec![], [INFO] [stdout] ... | [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for VM { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:89:17 [INFO] [stdout] | [INFO] [stdout] 89 | / if register1 == register2 { [INFO] [stdout] 90 | | self.equal_flag = true; [INFO] [stdout] 91 | | } else { [INFO] [stdout] 92 | | self.equal_flag = false; [INFO] [stdout] 93 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 == register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 99 | / if register1 != register2 { [INFO] [stdout] 100 | | self.equal_flag = true; [INFO] [stdout] 101 | | } else { [INFO] [stdout] 102 | | self.equal_flag = false; [INFO] [stdout] 103 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 != register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 109 | / if register1 > register2 { [INFO] [stdout] 110 | | self.equal_flag = true; [INFO] [stdout] 111 | | } else { [INFO] [stdout] 112 | | self.equal_flag = false; [INFO] [stdout] 113 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 > register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | / if register1 >= register2 { [INFO] [stdout] 120 | | self.equal_flag = true; [INFO] [stdout] 121 | | } else { [INFO] [stdout] 122 | | self.equal_flag = false; [INFO] [stdout] 123 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 >= register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | / if register1 < register2 { [INFO] [stdout] 130 | | self.equal_flag = true; [INFO] [stdout] 131 | | } else { [INFO] [stdout] 132 | | self.equal_flag = false; [INFO] [stdout] 133 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 < register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:139:17 [INFO] [stdout] | [INFO] [stdout] 139 | / if register1 <= register2 { [INFO] [stdout] 140 | | self.equal_flag = true; [INFO] [stdout] 141 | | } else { [INFO] [stdout] 142 | | self.equal_flag = false; [INFO] [stdout] 143 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 <= register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | return opcode; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return opcode; [INFO] [stdout] 165 + opcode [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return result; [INFO] [stdout] 171 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - return result; [INFO] [stdout] 177 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:291:9 [INFO] [stdout] | [INFO] [stdout] 291 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 291 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 291 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:294:9 [INFO] [stdout] | [INFO] [stdout] 294 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 294 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 294 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:304:9 [INFO] [stdout] | [INFO] [stdout] 304 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 304 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 304 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 307 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 307 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:317:9 [INFO] [stdout] | [INFO] [stdout] 317 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 317 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 317 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 320 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 320 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 320 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:323:9 [INFO] [stdout] | [INFO] [stdout] 323 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 323 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 323 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 333 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 333 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 333 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:336:9 [INFO] [stdout] | [INFO] [stdout] 336 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 336 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 336 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:339:9 [INFO] [stdout] | [INFO] [stdout] 339 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 339 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 339 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:349:9 [INFO] [stdout] | [INFO] [stdout] 349 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 349 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 349 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:352:9 [INFO] [stdout] | [INFO] [stdout] 352 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 352 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 352 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:355:9 [INFO] [stdout] | [INFO] [stdout] 355 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 355 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 355 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:365:9 [INFO] [stdout] | [INFO] [stdout] 365 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 365 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 365 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:368:9 [INFO] [stdout] | [INFO] [stdout] 368 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 368 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 368 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 371 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 371 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 371 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/instruction.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / return match v { [INFO] [stdout] 29 | | 0 => Opcode::LOAD, [INFO] [stdout] 30 | | 1 => Opcode::ADD, [INFO] [stdout] 31 | | 2 => Opcode::SUB, [INFO] [stdout] ... | [INFO] [stdout] 46 | | _ => Opcode::IGL [INFO] [stdout] 47 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ match v { [INFO] [stdout] 29 + 0 => Opcode::LOAD, [INFO] [stdout] 30 + 1 => Opcode::ADD, [INFO] [stdout] 31 + 2 => Opcode::SUB, [INFO] [stdout] 32 + 3 => Opcode::MUL, [INFO] [stdout] 33 + 4 => Opcode::DIV, [INFO] [stdout] 34 + 5 => Opcode::HLT, [INFO] [stdout] 35 + 6 => Opcode::JMP, [INFO] [stdout] 36 + 7 => Opcode::JMPF, [INFO] [stdout] 37 + 8 => Opcode::JMPB, [INFO] [stdout] 38 + 9 => Opcode::EQ, [INFO] [stdout] 39 + 10 => Opcode::NEQ, [INFO] [stdout] 40 + 11 => Opcode::GTE, [INFO] [stdout] 41 + 12 => Opcode::GT, [INFO] [stdout] 42 + 13 => Opcode::LTE, [INFO] [stdout] 43 + 14 => Opcode::LT, [INFO] [stdout] 44 + 15 => Opcode::JMPE, [INFO] [stdout] 45 + 16 => Opcode::NOP, [INFO] [stdout] 46 + _ => Opcode::IGL [INFO] [stdout] 47 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `REPL` [INFO] [stdout] --> src/repl/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> REPL { [INFO] [stdout] 16 | | REPL { [INFO] [stdout] 17 | | vm: VM::new(), [INFO] [stdout] 18 | | command_buffer: vec![] [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for REPL { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/repl/mod.rs:58:24 [INFO] [stdout] | [INFO] [stdout] 58 | if !parsed_program.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parsed_program.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/repl/mod.rs:77:43 [INFO] [stdout] | [INFO] [stdout] 77 | let byte = u8::from_str_radix(&hex_string, 16); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `hex_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/opcode_parsers.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 22 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 22 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/register_parsers.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 26 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 26 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/register_parsers.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 28 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 28 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/register_parsers.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 30 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 30 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/operand_parsers.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 24 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 24 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/operand_parsers.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 30 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 30 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/assembler/instruction_parsers.rs:23:35 [INFO] [stdout] | [INFO] [stdout] 23 | Token::Op { code } => match code { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 24 | | _ => { [INFO] [stdout] 25 | | results.push(code as u8); [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 23 ~ Token::Op { code } => { [INFO] [stdout] 24 + results.push(code as u8); [INFO] [stdout] 25 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | / match operand { [INFO] [stdout] 35 | | Some(t) => AssemblerInstruction::extract_operand(t, &mut results), [INFO] [stdout] 36 | | None => {} [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(t) = operand { AssemblerInstruction::extract_operand(t, &mut results) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/program_parsers.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 37 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 37 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/program_parsers.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 49 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 49 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:33:24 [INFO] [stdout] | [INFO] [stdout] 33 | for operand in vec![&self.operand1, &self.operand2, &self.operand3] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[&self.operand1, &self.operand2, &self.operand3]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.87s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v4.2.3 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "d8bf3eb2e0cd0fdda61c600c1c72e67a820f9136d2651c4e87fa27c738d1b7a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d8bf3eb2e0cd0fdda61c600c1c72e67a820f9136d2651c4e87fa27c738d1b7a2", kill_on_drop: false }` [INFO] [stdout] d8bf3eb2e0cd0fdda61c600c1c72e67a820f9136d2651c4e87fa27c738d1b7a2