[INFO] cloning repository https://github.com/rapgenic/zed-vhdl [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rapgenic/zed-vhdl" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frapgenic%2Fzed-vhdl", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frapgenic%2Fzed-vhdl'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a7ddb689e54ef49ee0bd5af5a1f2f00805b0717e [INFO] linting rapgenic/zed-vhdl against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frapgenic%2Fzed-vhdl" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/rapgenic/zed-vhdl [INFO] finished tweaking git repo https://github.com/rapgenic/zed-vhdl [INFO] tweaked toml for git repo https://github.com/rapgenic/zed-vhdl written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rapgenic/zed-vhdl on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rapgenic/zed-vhdl already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-encoder v0.201.0 [INFO] [stderr] Downloaded wasm-metadata v0.201.0 [INFO] [stderr] Downloaded zed_extension_api v0.1.0 [INFO] [stderr] Downloaded wit-bindgen-rust-macro v0.22.0 [INFO] [stderr] Downloaded wit-bindgen v0.22.0 [INFO] [stderr] Downloaded wit-bindgen-rt v0.22.0 [INFO] [stderr] Downloaded wit-bindgen-core v0.22.0 [INFO] [stderr] Downloaded wit-bindgen-rust v0.22.0 [INFO] [stderr] Downloaded wit-parser v0.201.0 [INFO] [stderr] Downloaded wit-component v0.201.0 [INFO] [stderr] Downloaded wasmparser v0.201.0 [INFO] [stderr] Downloaded spdx v0.10.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6c8a74ed1555a72b7a4623ebd08881bd3581f6fcc779ceaf3991a18ee730ab8e [INFO] running `Command { std: "docker" "start" "-a" "6c8a74ed1555a72b7a4623ebd08881bd3581f6fcc779ceaf3991a18ee730ab8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c8a74ed1555a72b7a4623ebd08881bd3581f6fcc779ceaf3991a18ee730ab8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c8a74ed1555a72b7a4623ebd08881bd3581f6fcc779ceaf3991a18ee730ab8e", kill_on_drop: false }` [INFO] [stdout] 6c8a74ed1555a72b7a4623ebd08881bd3581f6fcc779ceaf3991a18ee730ab8e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f3239434241937f148a79976a2f8df891826ba0fede50996b76198399357d9ea [INFO] running `Command { std: "docker" "start" "-a" "f3239434241937f148a79976a2f8df891826ba0fede50996b76198399357d9ea", kill_on_drop: false }` [INFO] [stderr] Compiling hashbrown v0.16.0 [INFO] [stderr] Compiling bitflags v2.9.4 [INFO] [stderr] Compiling id-arena v2.2.1 [INFO] [stderr] Compiling leb128 v0.2.5 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Compiling log v0.4.28 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Compiling wit-bindgen-rust v0.22.0 [INFO] [stderr] Compiling spdx v0.10.9 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling wit-bindgen-rt v0.22.0 [INFO] [stderr] Compiling wit-bindgen-rust-macro v0.22.0 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Compiling zed_extension_api v0.1.0 [INFO] [stderr] Compiling wasm-encoder v0.201.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking regex-automata v0.4.11 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling indexmap v2.11.4 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling wasmparser v0.201.0 [INFO] [stderr] Checking regex v1.11.3 [INFO] [stderr] Compiling wit-parser v0.201.0 [INFO] [stderr] Compiling wasm-metadata v0.201.0 [INFO] [stderr] Compiling wit-bindgen-core v0.22.0 [INFO] [stderr] Compiling wit-component v0.201.0 [INFO] [stderr] Checking wit-bindgen v0.22.0 [INFO] [stderr] Checking zed-vhdl v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | if fs::metadata(path).map_or(false, |stat| stat.is_file()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_ok_and` instead [INFO] [stdout] | [INFO] [stdout] 24 - if fs::metadata(path).map_or(false, |stat| stat.is_file()) { [INFO] [stdout] 24 + if fs::metadata(path).is_ok_and(|stat| stat.is_file()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | &language_server_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `language_server_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | if !fs::metadata(&binary_path).map_or(false, |stat| stat.is_file()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_ok_and` instead [INFO] [stdout] | [INFO] [stdout] 66 - if !fs::metadata(&binary_path).map_or(false, |stat| stat.is_file()) { [INFO] [stdout] 66 + if !fs::metadata(&binary_path).is_ok_and(|stat| stat.is_file()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | &language_server_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `language_server_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:84:40 [INFO] [stdout] | [INFO] [stdout] 84 | fs::remove_dir_all(&entry.path()).ok(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `entry.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:131:72 [INFO] [stdout] | [INFO] [stdout] 131 | let captures = SIGNAL_CONSTANT_VARIABLE_REGEX.captures(&detail)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `detail` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:186:72 [INFO] [stdout] | [INFO] [stdout] 186 | let captures = SIGNAL_CONSTANT_VARIABLE_REGEX.captures(&detail)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `detail` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:290:58 [INFO] [stdout] | [INFO] [stdout] 290 | let captures = FUNCTION_SIGNATURE_REGEX.captures(&detail).expect(detail); [INFO] [stdout] | ^^^^^^^ help: change this to: `detail` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:369:24 [INFO] [stdout] | [INFO] [stdout] 369 | if !it.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `it.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:440:40 [INFO] [stdout] | [INFO] [stdout] 440 | let captures = ENUM_REGEX.captures(&detail).expect(detail); [INFO] [stdout] | ^^^^^^^ help: change this to: `detail` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | if fs::metadata(path).map_or(false, |stat| stat.is_file()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_ok_and` instead [INFO] [stdout] | [INFO] [stdout] 24 - if fs::metadata(path).map_or(false, |stat| stat.is_file()) { [INFO] [stdout] 24 + if fs::metadata(path).is_ok_and(|stat| stat.is_file()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | &language_server_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `language_server_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | if !fs::metadata(&binary_path).map_or(false, |stat| stat.is_file()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_ok_and` instead [INFO] [stdout] | [INFO] [stdout] 66 - if !fs::metadata(&binary_path).map_or(false, |stat| stat.is_file()) { [INFO] [stdout] 66 + if !fs::metadata(&binary_path).is_ok_and(|stat| stat.is_file()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | &language_server_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `language_server_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:84:40 [INFO] [stdout] | [INFO] [stdout] 84 | fs::remove_dir_all(&entry.path()).ok(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `entry.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:131:72 [INFO] [stdout] | [INFO] [stdout] 131 | let captures = SIGNAL_CONSTANT_VARIABLE_REGEX.captures(&detail)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `detail` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:186:72 [INFO] [stdout] | [INFO] [stdout] 186 | let captures = SIGNAL_CONSTANT_VARIABLE_REGEX.captures(&detail)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `detail` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:290:58 [INFO] [stdout] | [INFO] [stdout] 290 | let captures = FUNCTION_SIGNATURE_REGEX.captures(&detail).expect(detail); [INFO] [stdout] | ^^^^^^^ help: change this to: `detail` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:369:24 [INFO] [stdout] | [INFO] [stdout] 369 | if !it.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `it.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:440:40 [INFO] [stdout] | [INFO] [stdout] 440 | let captures = ENUM_REGEX.captures(&detail).expect(detail); [INFO] [stdout] | ^^^^^^^ help: change this to: `detail` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 35.55s [INFO] running `Command { std: "docker" "inspect" "f3239434241937f148a79976a2f8df891826ba0fede50996b76198399357d9ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3239434241937f148a79976a2f8df891826ba0fede50996b76198399357d9ea", kill_on_drop: false }` [INFO] [stdout] f3239434241937f148a79976a2f8df891826ba0fede50996b76198399357d9ea