[INFO] cloning repository https://github.com/ranjeethmahankali/cheers [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ranjeethmahankali/cheers" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Franjeethmahankali%2Fcheers", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Franjeethmahankali%2Fcheers'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 75c1ec81cba1a43154bcf1be14b5b49d5d079e43 [INFO] linting ranjeethmahankali/cheers against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Franjeethmahankali%2Fcheers" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ranjeethmahankali/cheers [INFO] finished tweaking git repo https://github.com/ranjeethmahankali/cheers [INFO] tweaked toml for git repo https://github.com/ranjeethmahankali/cheers written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ranjeethmahankali/cheers on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ranjeethmahankali/cheers already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 064f92e45fe256a77fff565ecb4cd158892e8f8fcef26a0679b5854e99c29068 [INFO] running `Command { std: "docker" "start" "-a" "064f92e45fe256a77fff565ecb4cd158892e8f8fcef26a0679b5854e99c29068", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "064f92e45fe256a77fff565ecb4cd158892e8f8fcef26a0679b5854e99c29068", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "064f92e45fe256a77fff565ecb4cd158892e8f8fcef26a0679b5854e99c29068", kill_on_drop: false }` [INFO] [stdout] 064f92e45fe256a77fff565ecb4cd158892e8f8fcef26a0679b5854e99c29068 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5dd3dfa65b7cbf7c11aedc87c0a308431e60ac9216cd21f6e24b28e5b1c73f23 [INFO] running `Command { std: "docker" "start" "-a" "5dd3dfa65b7cbf7c11aedc87c0a308431e60ac9216cd21f6e24b28e5b1c73f23", kill_on_drop: false }` [INFO] [stderr] Checking fixedbitset v0.5.7 [INFO] [stderr] Checking cheers v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/greedy.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | slots.sort_by(|(_, _, anbs), (_, _, bnbs)| count_nbs(anbs).cmp(&count_nbs(bnbs))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 - slots.sort_by(|(_, _, anbs), (_, _, bnbs)| count_nbs(anbs).cmp(&count_nbs(bnbs))); [INFO] [stdout] 27 + slots.sort_by_key(|(_, _, anbs)| count_nbs(anbs)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/lattice.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / impl Default for Neighbor { [INFO] [stdout] 14 | | fn default() -> Self { [INFO] [stdout] 15 | | Self(None) [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 11 + #[derive(Default)] [INFO] [stdout] 12 | pub struct Neighbor(Option); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lattice.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | return OFFSETS[self.0 as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return OFFSETS[self.0 as usize]; [INFO] [stdout] 88 + OFFSETS[self.0 as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/greedy.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | slots.sort_by(|(_, _, anbs), (_, _, bnbs)| count_nbs(anbs).cmp(&count_nbs(bnbs))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 - slots.sort_by(|(_, _, anbs), (_, _, bnbs)| count_nbs(anbs).cmp(&count_nbs(bnbs))); [INFO] [stdout] 27 + slots.sort_by_key(|(_, _, anbs)| count_nbs(anbs)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/lattice.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / impl Default for Neighbor { [INFO] [stdout] 14 | | fn default() -> Self { [INFO] [stdout] 15 | | Self(None) [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 11 + #[derive(Default)] [INFO] [stdout] 12 | pub struct Neighbor(Option); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lattice.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | return OFFSETS[self.0 as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return OFFSETS[self.0 as usize]; [INFO] [stdout] 88 + OFFSETS[self.0 as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `Iterator::fold` on a type that implements `Try` [INFO] [stdout] --> src/lattice.rs:472:49 [INFO] [stdout] | [INFO] [stdout] 472 | if let Some((last, _)) = (0..3).fold(Some((node, dir)), |current, _| { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 473 | | if let Some((id, dir)) = current [INFO] [stdout] 474 | | && let Some((next, ndir, nrot)) = lattice.step_loop_cw(id, dir) [INFO] [stdout] 475 | | && nrot == 1 [INFO] [stdout] ... | [INFO] [stdout] 481 | | }) { [INFO] [stdout] | |__________________^ help: use `try_fold` instead: `try_fold((node, dir), |current, _| ...)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold [INFO] [stdout] = note: `#[warn(clippy::manual_try_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `Iterator::fold` on a type that implements `Try` [INFO] [stdout] --> src/lattice.rs:484:49 [INFO] [stdout] | [INFO] [stdout] 484 | if let Some((last, _)) = (0..3).fold(Some((node, dir)), |current, _| { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 485 | | if let Some((id, dir)) = current [INFO] [stdout] 486 | | && let Some((next, ndir, nrot)) = lattice.step_loop_ccw(id, dir) [INFO] [stdout] 487 | | && nrot == 1 [INFO] [stdout] ... | [INFO] [stdout] 493 | | }) { [INFO] [stdout] | |__________________^ help: use `try_fold` instead: `try_fold((node, dir), |current, _| ...)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lattice.rs:510:21 [INFO] [stdout] | [INFO] [stdout] 510 | assert!(!neighbor.get().is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `neighbor.get().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.68s [INFO] running `Command { std: "docker" "inspect" "5dd3dfa65b7cbf7c11aedc87c0a308431e60ac9216cd21f6e24b28e5b1c73f23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5dd3dfa65b7cbf7c11aedc87c0a308431e60ac9216cd21f6e24b28e5b1c73f23", kill_on_drop: false }` [INFO] [stdout] 5dd3dfa65b7cbf7c11aedc87c0a308431e60ac9216cd21f6e24b28e5b1c73f23