[INFO] cloning repository https://github.com/randal923/truco
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/randal923/truco" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frandal923%2Ftruco", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frandal923%2Ftruco'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] f8281f4c8f13b5bc8f09a9c57307cc6bf310eeb9
[INFO] linting randal923/truco against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frandal923%2Ftruco" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/randal923/truco
[INFO] finished tweaking git repo https://github.com/randal923/truco
[INFO] tweaked toml for git repo https://github.com/randal923/truco written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/randal923/truco on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/randal923/truco already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded assert_cmd v2.0.14
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 30cf1cb306ea43f302b5ee319ed4a7bab58e325904ba9db043ce1a7ce64f942d
[INFO] running `Command { std: "docker" "start" "-a" "30cf1cb306ea43f302b5ee319ed4a7bab58e325904ba9db043ce1a7ce64f942d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "30cf1cb306ea43f302b5ee319ed4a7bab58e325904ba9db043ce1a7ce64f942d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "30cf1cb306ea43f302b5ee319ed4a7bab58e325904ba9db043ce1a7ce64f942d", kill_on_drop: false }`
[INFO] [stdout] 30cf1cb306ea43f302b5ee319ed4a7bab58e325904ba9db043ce1a7ce64f942d
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 15fd83a569d3e3dd6cb9b7ef82c6918c2c317e535fbeeaebfbffbd0f447f0e97
[INFO] running `Command { std: "docker" "start" "-a" "15fd83a569d3e3dd6cb9b7ef82c6918c2c317e535fbeeaebfbffbd0f447f0e97", kill_on_drop: false }`
[INFO] [stderr]     Checking anstyle v1.0.7
[INFO] [stderr]    Compiling assert_cmd v2.0.14
[INFO] [stderr]     Checking regex-automata v0.4.6
[INFO] [stderr]     Checking memchr v2.7.2
[INFO] [stderr]     Checking colored v2.1.0
[INFO] [stderr]     Checking predicates v3.1.0
[INFO] [stderr]     Checking truco v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Deck`
[INFO] [stdout]   --> src/deck.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 14 | /     pub fn new() -> Deck {
[INFO] [stdout] 15 | |         Deck {
[INFO] [stdout] 16 | |             cards: Deck::create_cards(),
[INFO] [stdout] 17 | |             flip_card: None,
[INFO] [stdout] 18 | |         }
[INFO] [stdout] 19 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 13 + impl Default for Deck {
[INFO] [stdout] 14 +     fn default() -> Self {
[INFO] [stdout] 15 +         Self::new()
[INFO] [stdout] 16 +     }
[INFO] [stdout] 17 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/deck.rs:37:9
[INFO] [stdout]    |
[INFO] [stdout] 35 |         let manilha_rank = flip_card.rank.next();
[INFO] [stdout]    |         ----------------------------------------- unnecessary `let` binding
[INFO] [stdout] 36 |
[INFO] [stdout] 37 |         manilha_rank
[INFO] [stdout]    |         ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 35 ~         
[INFO] [stdout] 36 |
[INFO] [stdout] 37 ~         flip_card.rank.next()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/deck.rs:70:43
[INFO] [stdout]    |
[INFO] [stdout] 70 |     pub fn deal_cards(&mut self, players: &mut Vec<Player>) {
[INFO] [stdout]    |                                           ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 70 -     pub fn deal_cards(&mut self, players: &mut Vec<Player>) {
[INFO] [stdout] 70 +     pub fn deal_cards(&mut self, players: &mut [Player]) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/game.rs:101:16
[INFO] [stdout]     |
[INFO] [stdout] 101 |             if !is_draw || (is_draw && round == 1 && i < 2) {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!is_draw || round == 1 && i < 2`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Round`
[INFO] [stdout]   --> src/round.rs:7:5
[INFO] [stdout]    |
[INFO] [stdout]  7 | /     pub fn new() -> Round {
[INFO] [stdout]  8 | |         Round {
[INFO] [stdout]  9 | |             round: 0,
[INFO] [stdout] 10 | |             current_player_turn: 0,
[INFO] [stdout] 11 | |         }
[INFO] [stdout] 12 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout]  6 + impl Default for Round {
[INFO] [stdout]  7 +     fn default() -> Self {
[INFO] [stdout]  8 +         Self::new()
[INFO] [stdout]  9 +     }
[INFO] [stdout] 10 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `RoundPoints`
[INFO] [stdout]   --> src/round_points.rs:7:5
[INFO] [stdout]    |
[INFO] [stdout]  7 | /     pub fn new() -> RoundPoints {
[INFO] [stdout]  8 | |         RoundPoints {
[INFO] [stdout]  9 | |             team_1_score: 0,
[INFO] [stdout] 10 | |             team_2_score: 0,
[INFO] [stdout] 11 | |         }
[INFO] [stdout] 12 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout]  6 + impl Default for RoundPoints {
[INFO] [stdout]  7 +     fn default() -> Self {
[INFO] [stdout]  8 +         Self::new()
[INFO] [stdout]  9 +     }
[INFO] [stdout] 10 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/team.rs:39:9
[INFO] [stdout]    |
[INFO] [stdout] 39 |         return None;
[INFO] [stdout]    |         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 39 -         return None;
[INFO] [stdout] 39 +         None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Checking bstr v1.9.1
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> tests/team_tests.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 11 |     let team = Team::new(players);
[INFO] [stdout]    |     ------------------------------ unnecessary `let` binding
[INFO] [stdout] 12 |
[INFO] [stdout] 13 |     team
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 11 ~     
[INFO] [stdout] 12 |
[INFO] [stdout] 13 ~     Team::new(players)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Deck`
[INFO] [stdout]   --> src/deck.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 14 | /     pub fn new() -> Deck {
[INFO] [stdout] 15 | |         Deck {
[INFO] [stdout] 16 | |             cards: Deck::create_cards(),
[INFO] [stdout] 17 | |             flip_card: None,
[INFO] [stdout] 18 | |         }
[INFO] [stdout] 19 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 13 + impl Default for Deck {
[INFO] [stdout] 14 +     fn default() -> Self {
[INFO] [stdout] 15 +         Self::new()
[INFO] [stdout] 16 +     }
[INFO] [stdout] 17 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/deck.rs:37:9
[INFO] [stdout]    |
[INFO] [stdout] 35 |         let manilha_rank = flip_card.rank.next();
[INFO] [stdout]    |         ----------------------------------------- unnecessary `let` binding
[INFO] [stdout] 36 |
[INFO] [stdout] 37 |         manilha_rank
[INFO] [stdout]    |         ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 35 ~         
[INFO] [stdout] 36 |
[INFO] [stdout] 37 ~         flip_card.rank.next()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/deck.rs:70:43
[INFO] [stdout]    |
[INFO] [stdout] 70 |     pub fn deal_cards(&mut self, players: &mut Vec<Player>) {
[INFO] [stdout]    |                                           ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 70 -     pub fn deal_cards(&mut self, players: &mut Vec<Player>) {
[INFO] [stdout] 70 +     pub fn deal_cards(&mut self, players: &mut [Player]) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/game.rs:101:16
[INFO] [stdout]     |
[INFO] [stdout] 101 |             if !is_draw || (is_draw && round == 1 && i < 2) {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!is_draw || round == 1 && i < 2`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Round`
[INFO] [stdout]   --> src/round.rs:7:5
[INFO] [stdout]    |
[INFO] [stdout]  7 | /     pub fn new() -> Round {
[INFO] [stdout]  8 | |         Round {
[INFO] [stdout]  9 | |             round: 0,
[INFO] [stdout] 10 | |             current_player_turn: 0,
[INFO] [stdout] 11 | |         }
[INFO] [stdout] 12 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout]  6 + impl Default for Round {
[INFO] [stdout]  7 +     fn default() -> Self {
[INFO] [stdout]  8 +         Self::new()
[INFO] [stdout]  9 +     }
[INFO] [stdout] 10 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `RoundPoints`
[INFO] [stdout]   --> src/round_points.rs:7:5
[INFO] [stdout]    |
[INFO] [stdout]  7 | /     pub fn new() -> RoundPoints {
[INFO] [stdout]  8 | |         RoundPoints {
[INFO] [stdout]  9 | |             team_1_score: 0,
[INFO] [stdout] 10 | |             team_2_score: 0,
[INFO] [stdout] 11 | |         }
[INFO] [stdout] 12 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout]  6 + impl Default for RoundPoints {
[INFO] [stdout]  7 +     fn default() -> Self {
[INFO] [stdout]  8 +         Self::new()
[INFO] [stdout]  9 +     }
[INFO] [stdout] 10 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/team.rs:39:9
[INFO] [stdout]    |
[INFO] [stdout] 39 |         return None;
[INFO] [stdout]    |         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 39 -         return None;
[INFO] [stdout] 39 +         None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.85s
[INFO] running `Command { std: "docker" "inspect" "15fd83a569d3e3dd6cb9b7ef82c6918c2c317e535fbeeaebfbffbd0f447f0e97", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "15fd83a569d3e3dd6cb9b7ef82c6918c2c317e535fbeeaebfbffbd0f447f0e97", kill_on_drop: false }`
[INFO] [stdout] 15fd83a569d3e3dd6cb9b7ef82c6918c2c317e535fbeeaebfbffbd0f447f0e97