[INFO] cloning repository https://github.com/railwayhistory/railmap [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/railwayhistory/railmap" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frailwayhistory%2Frailmap", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frailwayhistory%2Frailmap'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7bb52d75cd7b62325f0a5a9f6a2c5ff51ce1f8e8 [INFO] linting railwayhistory/railmap against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frailwayhistory%2Frailmap" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/railwayhistory/railmap [INFO] finished tweaking git repo https://github.com/railwayhistory/railmap [INFO] tweaked toml for git repo https://github.com/railwayhistory/railmap written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/railwayhistory/railmap on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/railwayhistory/railmap already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/partim/femtomap.git` [INFO] [stderr] Updating git repository `https://github.com/partim/osmxml.git` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pango-sys v0.21.5 [INFO] [stderr] Downloaded cairo-sys-rs v0.21.5 [INFO] [stderr] Downloaded pango v0.21.5 [INFO] [stderr] Downloaded pangocairo-sys v0.21.5 [INFO] [stderr] Downloaded cfg-expr v0.20.4 [INFO] [stderr] Downloaded pangocairo v0.21.5 [INFO] [stderr] Downloaded cairo-rs v0.21.5 [INFO] [stderr] Downloaded toml_edit v0.23.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cf805b66906d4dcf9ed9abec747a3edff62de9eb35ab7d219fb7b3a5ac11850f [INFO] running `Command { std: "docker" "start" "-a" "cf805b66906d4dcf9ed9abec747a3edff62de9eb35ab7d219fb7b3a5ac11850f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cf805b66906d4dcf9ed9abec747a3edff62de9eb35ab7d219fb7b3a5ac11850f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf805b66906d4dcf9ed9abec747a3edff62de9eb35ab7d219fb7b3a5ac11850f", kill_on_drop: false }` [INFO] [stdout] cf805b66906d4dcf9ed9abec747a3edff62de9eb35ab7d219fb7b3a5ac11850f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2cd854c58d1e2f51e7d539845c67351a47b9f0d8a69194a4ed0a7712deeaafd6 [INFO] running `Command { std: "docker" "start" "-a" "2cd854c58d1e2f51e7d539845c67351a47b9f0d8a69194a4ed0a7712deeaafd6", kill_on_drop: false }` [INFO] [stderr] Compiling toml_parser v1.0.4 [INFO] [stderr] Compiling toml_datetime v0.7.3 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling serde_spanned v1.0.3 [INFO] [stderr] Compiling version-compare v0.2.1 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Compiling target-lexicon v0.13.3 [INFO] [stderr] Compiling indexmap v2.12.1 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling cfg-expr v0.20.4 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking xml-rs v0.8.28 [INFO] [stderr] Checking bytecount v0.6.9 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking foldhash v0.2.0 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking inotify v0.10.2 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking kurbo v0.11.3 [INFO] [stderr] Compiling toml v0.9.8 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling toml_edit v0.23.9 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking osmxml v0.1.0 (https://github.com/partim/osmxml.git#0930d832) [INFO] [stderr] Checking filetime v0.2.26 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking toml_writer v1.0.4 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking notify v7.0.0 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling system-deps v7.0.7 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking rstar v0.12.2 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking lru v0.16.2 [INFO] [stderr] Compiling glib-sys v0.21.5 [INFO] [stderr] Compiling gobject-sys v0.21.5 [INFO] [stderr] Compiling gio-sys v0.21.5 [INFO] [stderr] Compiling pango-sys v0.21.5 [INFO] [stderr] Compiling cairo-sys-rs v0.21.5 [INFO] [stderr] Compiling pangocairo-sys v0.21.5 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling glib-macros v0.21.5 [INFO] [stderr] Checking nom_locate v4.2.0 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking globset v0.4.18 [INFO] [stderr] Checking ignore v0.4.25 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking glib v0.21.5 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking gio v0.21.5 [INFO] [stderr] Checking cairo-rs v0.21.5 [INFO] [stderr] Checking pango v0.21.5 [INFO] [stderr] Checking pangocairo v0.21.5 [INFO] [stderr] Checking femtomap v0.1.0 (https://github.com/partim/femtomap.git#e49f94dc) [INFO] [stderr] Checking railmap v0.1.21 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/railway/feature/oldmarker.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / /// closed or removed. [INFO] [stdout] 13 | | [INFO] [stdout] | |_^ [INFO] [stdout] 14 | use std::collections::HashMap; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Rendering of markers. [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! How a marker is rendered is selected via the symbol set passed to the [INFO] [stdout] 4 ~ //! marker. Each known base marker has its own designated symbol. This base [INFO] [stdout] 5 ~ //! can be modified via the following additional symbols: [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! * `:right`, `:top`, `:left`, `:bottom`: Apply the marker to the right, [INFO] [stdout] 8 ~ //! top, left, bottom of the position, respectively. The default of none [INFO] [stdout] 9 ~ //! of these is provided is `:right`. [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! * `:closed`, `:removed`: The entity described by the marker has been [INFO] [stdout] 12 ~ //! closed or removed. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/railway/feature/oldmarker.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / /// closed or removed. [INFO] [stdout] 13 | | [INFO] [stdout] | |_^ [INFO] [stdout] 14 | use std::collections::HashMap; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Rendering of markers. [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! How a marker is rendered is selected via the symbol set passed to the [INFO] [stdout] 4 ~ //! marker. Each known base marker has its own designated symbol. This base [INFO] [stdout] 5 ~ //! can be modified via the following additional symbols: [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! * `:right`, `:top`, `:left`, `:bottom`: Apply the marker to the right, [INFO] [stdout] 8 ~ //! top, left, bottom of the position, respectively. The default of none [INFO] [stdout] 9 ~ //! of these is provided is `:right`. [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! * `:closed`, `:removed`: The entity described by the marker has been [INFO] [stdout] 12 ~ //! closed or removed. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/railway/class.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 300 | / match self { [INFO] [stdout] 301 | | Category::First | Category::Second => true, [INFO] [stdout] 302 | | _ => false [INFO] [stdout] 303 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 300 - match self { [INFO] [stdout] 301 - Category::First | Category::Second => true, [INFO] [stdout] 302 - _ => false [INFO] [stdout] 303 - } [INFO] [stdout] 300 + matches!(self, Category::First | Category::Second) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/railway/class.rs:319:1 [INFO] [stdout] | [INFO] [stdout] 319 | / impl Default for Category { [INFO] [stdout] 320 | | fn default() -> Self { [INFO] [stdout] 321 | | Category::Siding [INFO] [stdout] 322 | | } [INFO] [stdout] 323 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 253 + #[derive(Default)] [INFO] [stdout] 254 | pub enum Category { [INFO] [stdout] 255 | /// First-class public railway. [INFO] [stdout] ... [INFO] [stdout] 270 | /// Sidings tracks. [INFO] [stdout] 271 ~ #[default] [INFO] [stdout] 272 ~ Siding, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/railway/class.rs:418:1 [INFO] [stdout] | [INFO] [stdout] 418 | / impl Default for Status { [INFO] [stdout] 419 | | fn default() -> Self { [INFO] [stdout] 420 | | Status::Open [INFO] [stdout] 421 | | } [INFO] [stdout] 422 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 333 + #[derive(Default)] [INFO] [stdout] 334 | pub enum Status { [INFO] [stdout] 335 | /// The feature has been removed a long time ago. [INFO] [stdout] ... [INFO] [stdout] 355 | /// This is the default if the status is not explicitly given. [INFO] [stdout] 356 ~ #[default] [INFO] [stdout] 357 ~ Open, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/railway/class.rs:442:1 [INFO] [stdout] | [INFO] [stdout] 442 | / impl Default for Surface { [INFO] [stdout] 443 | | fn default() -> Self { [INFO] [stdout] 444 | | Surface::Ground [INFO] [stdout] 445 | | } [INFO] [stdout] 446 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 429 + #[derive(Default)] [INFO] [stdout] 430 | pub enum Surface { [INFO] [stdout] 431 | /// The track sits on regular ground. [INFO] [stdout] 432 | /// [INFO] [stdout] 433 | /// This is the default. [INFO] [stdout] 434 ~ #[default] [INFO] [stdout] 435 ~ Ground, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/railway/class.rs:714:1 [INFO] [stdout] | [INFO] [stdout] 714 | / impl Default for Speed { [INFO] [stdout] 715 | | fn default() -> Self { [INFO] [stdout] 716 | | Speed::V160 [INFO] [stdout] 717 | | } [INFO] [stdout] 718 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 683 + #[derive(Default)] [INFO] [stdout] 684 | pub enum Speed { [INFO] [stdout] 685 ~ #[default] [INFO] [stdout] 686 ~ V160, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/railway/class.rs:766:1 [INFO] [stdout] | [INFO] [stdout] 766 | / impl Default for Pax { [INFO] [stdout] 767 | | fn default() -> Self { [INFO] [stdout] 768 | | Pax::None [INFO] [stdout] 769 | | } [INFO] [stdout] 770 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 724 + #[derive(Default)] [INFO] [stdout] 725 | pub enum Pax { [INFO] [stdout] 726 | /// There is no passenger service. [INFO] [stdout] 727 ~ #[default] [INFO] [stdout] 728 ~ None = 0, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/class.rs:926:13 [INFO] [stdout] | [INFO] [stdout] 926 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 925 - if symbols.take("narrower") { [INFO] [stdout] 926 - return [INFO] [stdout] 925 + if symbols.take("narrower") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/class.rs:929:13 [INFO] [stdout] | [INFO] [stdout] 929 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 928 - else if symbols.take("narrow") { [INFO] [stdout] 929 - return [INFO] [stdout] 928 + else if symbols.take("narrow") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/class.rs:932:13 [INFO] [stdout] | [INFO] [stdout] 932 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 931 - else if symbols.take("standard") { [INFO] [stdout] 932 - return [INFO] [stdout] 931 + else if symbols.take("standard") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/class.rs:935:13 [INFO] [stdout] | [INFO] [stdout] 935 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 934 - else if symbols.take("broad") { [INFO] [stdout] 935 - return [INFO] [stdout] 934 + else if symbols.take("broad") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/class.rs:938:13 [INFO] [stdout] | [INFO] [stdout] 938 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 937 - else if symbols.take("broader") { [INFO] [stdout] 938 - return [INFO] [stdout] 937 + else if symbols.take("broader") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/railway/class.rs:925:37 [INFO] [stdout] | [INFO] [stdout] 925 | if symbols.take("narrower") { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 926 | | return [INFO] [stdout] 927 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/railway/class.rs:928:40 [INFO] [stdout] | [INFO] [stdout] 928 | else if symbols.take("narrow") { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 929 | | return [INFO] [stdout] 930 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/railway/class.rs:928:40 [INFO] [stdout] | [INFO] [stdout] 928 | else if symbols.take("narrow") { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 929 | | return [INFO] [stdout] 930 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/railway/class.rs:931:42 [INFO] [stdout] | [INFO] [stdout] 931 | else if symbols.take("standard") { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 932 | | return [INFO] [stdout] 933 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/railway/class.rs:931:42 [INFO] [stdout] | [INFO] [stdout] 931 | else if symbols.take("standard") { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 932 | | return [INFO] [stdout] 933 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/railway/class.rs:934:39 [INFO] [stdout] | [INFO] [stdout] 934 | else if symbols.take("broad") { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 935 | | return [INFO] [stdout] 936 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/railway/class.rs:934:39 [INFO] [stdout] | [INFO] [stdout] 934 | else if symbols.take("broad") { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 935 | | return [INFO] [stdout] 936 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/railway/class.rs:937:41 [INFO] [stdout] | [INFO] [stdout] 937 | else if symbols.take("broader") { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 938 | | return [INFO] [stdout] 939 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/railway/colors/mod.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | / pub enum Colors { [INFO] [stdout] 16 | | El(el::Colors), [INFO] [stdout] | | -------------- the largest variant contains at least 480 bytes [INFO] [stdout] 17 | | Pax(pax::Colors), [INFO] [stdout] | | ---------------- the second-largest variant contains at least 96 bytes [INFO] [stdout] 18 | | } [INFO] [stdout] | |_^ the entire enum is at least 488 bytes [INFO] [stdout] | [INFO] [stdout] note: boxing a variant would require the type no longer be `Copy` [INFO] [stdout] --> src/railway/colors/mod.rs:15:10 [INFO] [stdout] | [INFO] [stdout] 15 | pub enum Colors { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] --> src/railway/colors/mod.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | El(el::Colors), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `LoadFeatures` [INFO] [stdout] --> src/railway/import/load.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / pub fn new() -> Self { [INFO] [stdout] 21 | | LoadFeatures { [INFO] [stdout] 22 | | features: Default::default(), [INFO] [stdout] 23 | | err: Default::default(), [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 19 + impl Default for LoadFeatures { [INFO] [stdout] 20 + fn default() -> Self { [INFO] [stdout] 21 + Self::new() [INFO] [stdout] 22 + } [INFO] [stdout] 23 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: current MSRV (Minimum Supported Rust Version) is `1.65.0` but this item is stable since `1.70.0` [INFO] [stdout] --> src/railway/import/load.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | Arc::into_inner( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv [INFO] [stdout] = note: `#[warn(clippy::incompatible_msrv)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/railway/import/functions.rs:37:18 [INFO] [stdout] | [INFO] [stdout] 37 | const FUNCTIONS: &[( [INFO] [stdout] | __________________^ [INFO] [stdout] 38 | | &str, [INFO] [stdout] 39 | | &dyn for<'a> Fn( [INFO] [stdout] 40 | | ArgumentList<'a>, [INFO] [stdout] ... | [INFO] [stdout] 44 | | ) -> Result, Failed> [INFO] [stdout] 45 | | )] = &[ [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/railway/import/procedures.rs:44:19 [INFO] [stdout] | [INFO] [stdout] 44 | const PROCEDURES: &[( [INFO] [stdout] | ___________________^ [INFO] [stdout] 45 | | &str, [INFO] [stdout] 46 | | &dyn for<'a> Fn( [INFO] [stdout] 47 | | Pos, [INFO] [stdout] ... | [INFO] [stdout] 51 | | ) -> Result<(), Failed> [INFO] [stdout] 52 | | )] = &[ [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/railway/class.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 300 | / match self { [INFO] [stdout] 301 | | Category::First | Category::Second => true, [INFO] [stdout] 302 | | _ => false [INFO] [stdout] 303 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 300 - match self { [INFO] [stdout] 301 - Category::First | Category::Second => true, [INFO] [stdout] 302 - _ => false [INFO] [stdout] 303 - } [INFO] [stdout] 300 + matches!(self, Category::First | Category::Second) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/railway/class.rs:319:1 [INFO] [stdout] | [INFO] [stdout] 319 | / impl Default for Category { [INFO] [stdout] 320 | | fn default() -> Self { [INFO] [stdout] 321 | | Category::Siding [INFO] [stdout] 322 | | } [INFO] [stdout] 323 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 253 + #[derive(Default)] [INFO] [stdout] 254 | pub enum Category { [INFO] [stdout] 255 | /// First-class public railway. [INFO] [stdout] ... [INFO] [stdout] 270 | /// Sidings tracks. [INFO] [stdout] 271 ~ #[default] [INFO] [stdout] 272 ~ Siding, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/railway/class.rs:418:1 [INFO] [stdout] | [INFO] [stdout] 418 | / impl Default for Status { [INFO] [stdout] 419 | | fn default() -> Self { [INFO] [stdout] 420 | | Status::Open [INFO] [stdout] 421 | | } [INFO] [stdout] 422 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 333 + #[derive(Default)] [INFO] [stdout] 334 | pub enum Status { [INFO] [stdout] 335 | /// The feature has been removed a long time ago. [INFO] [stdout] ... [INFO] [stdout] 355 | /// This is the default if the status is not explicitly given. [INFO] [stdout] 356 ~ #[default] [INFO] [stdout] 357 ~ Open, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/railway/class.rs:442:1 [INFO] [stdout] | [INFO] [stdout] 442 | / impl Default for Surface { [INFO] [stdout] 443 | | fn default() -> Self { [INFO] [stdout] 444 | | Surface::Ground [INFO] [stdout] 445 | | } [INFO] [stdout] 446 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 429 + #[derive(Default)] [INFO] [stdout] 430 | pub enum Surface { [INFO] [stdout] 431 | /// The track sits on regular ground. [INFO] [stdout] 432 | /// [INFO] [stdout] 433 | /// This is the default. [INFO] [stdout] 434 ~ #[default] [INFO] [stdout] 435 ~ Ground, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/railway/class.rs:714:1 [INFO] [stdout] | [INFO] [stdout] 714 | / impl Default for Speed { [INFO] [stdout] 715 | | fn default() -> Self { [INFO] [stdout] 716 | | Speed::V160 [INFO] [stdout] 717 | | } [INFO] [stdout] 718 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 683 + #[derive(Default)] [INFO] [stdout] 684 | pub enum Speed { [INFO] [stdout] 685 ~ #[default] [INFO] [stdout] 686 ~ V160, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/railway/class.rs:766:1 [INFO] [stdout] | [INFO] [stdout] 766 | / impl Default for Pax { [INFO] [stdout] 767 | | fn default() -> Self { [INFO] [stdout] 768 | | Pax::None [INFO] [stdout] 769 | | } [INFO] [stdout] 770 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 724 + #[derive(Default)] [INFO] [stdout] 725 | pub enum Pax { [INFO] [stdout] 726 | /// There is no passenger service. [INFO] [stdout] 727 ~ #[default] [INFO] [stdout] 728 ~ None = 0, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/class.rs:926:13 [INFO] [stdout] | [INFO] [stdout] 926 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 925 - if symbols.take("narrower") { [INFO] [stdout] 926 - return [INFO] [stdout] 925 + if symbols.take("narrower") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/class.rs:929:13 [INFO] [stdout] | [INFO] [stdout] 929 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 928 - else if symbols.take("narrow") { [INFO] [stdout] 929 - return [INFO] [stdout] 928 + else if symbols.take("narrow") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/class.rs:932:13 [INFO] [stdout] | [INFO] [stdout] 932 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 931 - else if symbols.take("standard") { [INFO] [stdout] 932 - return [INFO] [stdout] 931 + else if symbols.take("standard") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/class.rs:935:13 [INFO] [stdout] | [INFO] [stdout] 935 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 934 - else if symbols.take("broad") { [INFO] [stdout] 935 - return [INFO] [stdout] 934 + else if symbols.take("broad") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/class.rs:938:13 [INFO] [stdout] | [INFO] [stdout] 938 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 937 - else if symbols.take("broader") { [INFO] [stdout] 938 - return [INFO] [stdout] 937 + else if symbols.take("broader") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/railway/class.rs:925:37 [INFO] [stdout] | [INFO] [stdout] 925 | if symbols.take("narrower") { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 926 | | return [INFO] [stdout] 927 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/railway/class.rs:928:40 [INFO] [stdout] | [INFO] [stdout] 928 | else if symbols.take("narrow") { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 929 | | return [INFO] [stdout] 930 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/railway/class.rs:928:40 [INFO] [stdout] | [INFO] [stdout] 928 | else if symbols.take("narrow") { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 929 | | return [INFO] [stdout] 930 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/railway/class.rs:931:42 [INFO] [stdout] | [INFO] [stdout] 931 | else if symbols.take("standard") { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 932 | | return [INFO] [stdout] 933 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/railway/class.rs:931:42 [INFO] [stdout] | [INFO] [stdout] 931 | else if symbols.take("standard") { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 932 | | return [INFO] [stdout] 933 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/railway/class.rs:934:39 [INFO] [stdout] | [INFO] [stdout] 934 | else if symbols.take("broad") { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 935 | | return [INFO] [stdout] 936 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/railway/class.rs:934:39 [INFO] [stdout] | [INFO] [stdout] 934 | else if symbols.take("broad") { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 935 | | return [INFO] [stdout] 936 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/railway/class.rs:937:41 [INFO] [stdout] | [INFO] [stdout] 937 | else if symbols.take("broader") { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 938 | | return [INFO] [stdout] 939 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/railway/colors/mod.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | / pub enum Colors { [INFO] [stdout] 16 | | El(el::Colors), [INFO] [stdout] | | -------------- the largest variant contains at least 480 bytes [INFO] [stdout] 17 | | Pax(pax::Colors), [INFO] [stdout] | | ---------------- the second-largest variant contains at least 96 bytes [INFO] [stdout] 18 | | } [INFO] [stdout] | |_^ the entire enum is at least 488 bytes [INFO] [stdout] | [INFO] [stdout] note: boxing a variant would require the type no longer be `Copy` [INFO] [stdout] --> src/railway/colors/mod.rs:15:10 [INFO] [stdout] | [INFO] [stdout] 15 | pub enum Colors { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] --> src/railway/colors/mod.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | El(el::Colors), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/railway/feature/dot.rs:127:14 [INFO] [stdout] | [INFO] [stdout] 127 | else if symbols.take("over") { [INFO] [stdout] | ______________^ [INFO] [stdout] 128 | | false [INFO] [stdout] 129 | | } [INFO] [stdout] 130 | | else { [INFO] [stdout] 131 | | true [INFO] [stdout] 132 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `{ !symbols.take("over") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/dot.rs:171:17 [INFO] [stdout] | [INFO] [stdout] 171 | / if self.feature.casing { [INFO] [stdout] 172 | | let mut sketch = canvas.sketch(); [INFO] [stdout] 173 | | sketch.apply( [INFO] [stdout] 174 | | Circle::new( [INFO] [stdout] ... | [INFO] [stdout] 184 | | sketch.fill(); [INFO] [stdout] 185 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 170 ~ Stage::MarkerCasing [INFO] [stdout] 171 ~ if self.feature.casing => { [INFO] [stdout] 172 | let mut sketch = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 184 | sketch.fill(); [INFO] [stdout] 185 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/railway/feature/dot.rs:262:40 [INFO] [stdout] | [INFO] [stdout] 262 | else if symbols.take("medium") { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 263 | | Size::Medium [INFO] [stdout] 264 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/railway/feature/dot.rs:265:14 [INFO] [stdout] | [INFO] [stdout] 265 | else { [INFO] [stdout] | ______________^ [INFO] [stdout] 266 | | Size::Medium [INFO] [stdout] 267 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/guide.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | / if self.contour.casing { [INFO] [stdout] 79 | | let mut sketch = canvas.sketch(); [INFO] [stdout] 80 | | sketch.apply(&self.trace); [INFO] [stdout] 81 | | sketch.apply(LineWidth( [INFO] [stdout] ... | [INFO] [stdout] 85 | | sketch.stroke(); [INFO] [stdout] 86 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 77 ~ Stage::Casing [INFO] [stdout] 78 ~ if self.contour.casing => { [INFO] [stdout] 79 | let mut sketch = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 85 | sketch.stroke(); [INFO] [stdout] 86 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/feature/label.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | return Err(Failed) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return Err(Failed) [INFO] [stdout] 122 + Err(Failed) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/feature/label.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 144 | return Err(Failed) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return Err(Failed) [INFO] [stdout] 144 + Err(Failed) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `LoadFeatures` [INFO] [stdout] --> src/railway/import/load.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / pub fn new() -> Self { [INFO] [stdout] 21 | | LoadFeatures { [INFO] [stdout] 22 | | features: Default::default(), [INFO] [stdout] 23 | | err: Default::default(), [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 19 + impl Default for LoadFeatures { [INFO] [stdout] 20 + fn default() -> Self { [INFO] [stdout] 21 + Self::new() [INFO] [stdout] 22 + } [INFO] [stdout] 23 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: current MSRV (Minimum Supported Rust Version) is `1.65.0` but this item is stable since `1.70.0` [INFO] [stdout] --> src/railway/import/load.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | Arc::into_inner( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv [INFO] [stdout] = note: `#[warn(clippy::incompatible_msrv)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/railway/import/functions.rs:37:18 [INFO] [stdout] | [INFO] [stdout] 37 | const FUNCTIONS: &[( [INFO] [stdout] | __________________^ [INFO] [stdout] 38 | | &str, [INFO] [stdout] 39 | | &dyn for<'a> Fn( [INFO] [stdout] 40 | | ArgumentList<'a>, [INFO] [stdout] ... | [INFO] [stdout] 44 | | ) -> Result, Failed> [INFO] [stdout] 45 | | )] = &[ [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/railway/import/procedures.rs:44:19 [INFO] [stdout] | [INFO] [stdout] 44 | const PROCEDURES: &[( [INFO] [stdout] | ___________________^ [INFO] [stdout] 45 | | &str, [INFO] [stdout] 46 | | &dyn for<'a> Fn( [INFO] [stdout] 47 | | Pos, [INFO] [stdout] ... | [INFO] [stdout] 51 | | ) -> Result<(), Failed> [INFO] [stdout] 52 | | )] = &[ [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/railway/feature/marker.rs:151:39 [INFO] [stdout] | [INFO] [stdout] 151 | else if symbols.take("right") { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 152 | | Ok(Self::Right) [INFO] [stdout] 153 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/railway/feature/marker.rs:154:14 [INFO] [stdout] | [INFO] [stdout] 154 | else { [INFO] [stdout] | ______________^ [INFO] [stdout] 155 | | Ok(Self::Right) [INFO] [stdout] 156 | | /* [INFO] [stdout] 157 | | err.add(pos, "missing orientation"); [INFO] [stdout] 158 | | Err(Failed) [INFO] [stdout] 159 | | */ [INFO] [stdout] 160 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Matrix` which implements the `Copy` trait [INFO] [stdout] --> src/railway/feature/marker.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 192 | matrix.clone().invert().transform_point(extent) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `matrix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/feature/track.rs:274:13 [INFO] [stdout] | [INFO] [stdout] 274 | return AnyShape::from(ContourShape2::new(self, style)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 274 - return AnyShape::from(ContourShape2::new(self, style)); [INFO] [stdout] 274 + AnyShape::from(ContourShape2::new(self, style)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/feature/track.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | return AnyShape::from(ContourShape3::new(self, style)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - return AnyShape::from(ContourShape3::new(self, style)); [INFO] [stdout] 277 + AnyShape::from(ContourShape3::new(self, style)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/feature/track.rs:280:13 [INFO] [stdout] | [INFO] [stdout] 280 | return ContourShape4::new(self, style) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 280 - return ContourShape4::new(self, style) [INFO] [stdout] 280 + ContourShape4::new(self, style) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:446:17 [INFO] [stdout] | [INFO] [stdout] 446 | / if !self.open { [INFO] [stdout] 447 | | canvas.sketch() [INFO] [stdout] 448 | | .apply( [INFO] [stdout] 449 | | if self.dash.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 458 | | .stroke() [INFO] [stdout] 459 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 445 ~ Stage::AbandonedBase [INFO] [stdout] 446 ~ if !self.open => { [INFO] [stdout] 447 | canvas.sketch() [INFO] [stdout] ... [INFO] [stdout] 458 | .stroke() [INFO] [stdout] 459 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:462:17 [INFO] [stdout] | [INFO] [stdout] 462 | / if !self.open { [INFO] [stdout] 463 | | if let Some(dash) = self.dash { [INFO] [stdout] 464 | | canvas.sketch() [INFO] [stdout] 465 | | .apply(self.color) [INFO] [stdout] ... | [INFO] [stdout] 471 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 461 ~ Stage::AbandonedMarking [INFO] [stdout] 462 ~ if !self.open => { [INFO] [stdout] 463 | if let Some(dash) = self.dash { [INFO] [stdout] ... [INFO] [stdout] 470 | } [INFO] [stdout] 471 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:474:17 [INFO] [stdout] | [INFO] [stdout] 474 | / if self.open && self.dash.is_some() { [INFO] [stdout] 475 | | canvas.sketch() [INFO] [stdout] 476 | | .apply(Color::rgba(1., 1., 1., 0.8)) [INFO] [stdout] 477 | | .apply(LineWidth(self.width)) [INFO] [stdout] 478 | | .apply(&self.outline) [INFO] [stdout] 479 | | .stroke() [INFO] [stdout] 480 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 473 ~ Stage::LimitedBase [INFO] [stdout] 474 ~ if self.open && self.dash.is_some() => { [INFO] [stdout] 475 | canvas.sketch() [INFO] [stdout] ... [INFO] [stdout] 479 | .stroke() [INFO] [stdout] 480 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:483:17 [INFO] [stdout] | [INFO] [stdout] 483 | / if self.open { [INFO] [stdout] 484 | | if let Some(dash) = self.dash { [INFO] [stdout] 485 | | canvas.sketch() [INFO] [stdout] 486 | | .apply(self.color) [INFO] [stdout] ... | [INFO] [stdout] 492 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 482 ~ Stage::LimitedMarking [INFO] [stdout] 483 ~ if self.open => { [INFO] [stdout] 484 | if let Some(dash) = self.dash { [INFO] [stdout] ... [INFO] [stdout] 491 | } [INFO] [stdout] 492 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:495:17 [INFO] [stdout] | [INFO] [stdout] 495 | / if self.open && self.dash.is_none() { [INFO] [stdout] 496 | | canvas.sketch() [INFO] [stdout] 497 | | .apply(self.color) [INFO] [stdout] 498 | | .apply(LineWidth(self.width)) [INFO] [stdout] 499 | | .apply(&self.outline) [INFO] [stdout] 500 | | .stroke() [INFO] [stdout] 501 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 494 ~ Stage::Base [INFO] [stdout] 495 ~ if self.open && self.dash.is_none() => { [INFO] [stdout] 496 | canvas.sketch() [INFO] [stdout] ... [INFO] [stdout] 500 | .stroke() [INFO] [stdout] 501 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:634:17 [INFO] [stdout] | [INFO] [stdout] 634 | / if !self.open { [INFO] [stdout] 635 | | canvas.sketch() [INFO] [stdout] 636 | | .apply( [INFO] [stdout] 637 | | if self.dash.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 646 | | .stroke() [INFO] [stdout] 647 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 633 ~ Stage::AbandonedBase [INFO] [stdout] 634 ~ if !self.open => { [INFO] [stdout] 635 | canvas.sketch() [INFO] [stdout] ... [INFO] [stdout] 646 | .stroke() [INFO] [stdout] 647 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:650:17 [INFO] [stdout] | [INFO] [stdout] 650 | / if !self.open { [INFO] [stdout] 651 | | let mut canvas = canvas.sketch(); [INFO] [stdout] 652 | | if let Some(dash) = self.dash { [INFO] [stdout] 653 | | canvas [INFO] [stdout] ... | [INFO] [stdout] 663 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 649 ~ Stage::AbandonedMarking [INFO] [stdout] 650 ~ if !self.open => { [INFO] [stdout] 651 | let mut canvas = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 662 | } [INFO] [stdout] 663 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:666:17 [INFO] [stdout] | [INFO] [stdout] 666 | / if self.open && self.dash.is_some() { [INFO] [stdout] 667 | | canvas.sketch() [INFO] [stdout] 668 | | .apply(Color::rgba(1., 1., 1., 0.8)) [INFO] [stdout] 669 | | .apply(LineWidth(self.width)) [INFO] [stdout] 670 | | .apply(&self.outline) [INFO] [stdout] 671 | | .stroke(); [INFO] [stdout] 672 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 665 ~ Stage::LimitedBase [INFO] [stdout] 666 ~ if self.open && self.dash.is_some() => { [INFO] [stdout] 667 | canvas.sketch() [INFO] [stdout] ... [INFO] [stdout] 671 | .stroke(); [INFO] [stdout] 672 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:675:17 [INFO] [stdout] | [INFO] [stdout] 675 | / if self.open { [INFO] [stdout] 676 | | let mut canvas = canvas.sketch(); [INFO] [stdout] 677 | | if let Some(dash) = self.dash { [INFO] [stdout] 678 | | canvas [INFO] [stdout] ... | [INFO] [stdout] 688 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 674 ~ Stage::LimitedMarking [INFO] [stdout] 675 ~ if self.open => { [INFO] [stdout] 676 | let mut canvas = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 687 | } [INFO] [stdout] 688 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:691:17 [INFO] [stdout] | [INFO] [stdout] 691 | / if self.open && self.dash.is_none() { [INFO] [stdout] 692 | | let mut canvas = canvas.sketch(); [INFO] [stdout] 693 | | canvas [INFO] [stdout] 694 | | .apply(self.color) [INFO] [stdout] ... | [INFO] [stdout] 701 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 690 ~ Stage::Base [INFO] [stdout] 691 ~ if self.open && self.dash.is_none() => { [INFO] [stdout] 692 | let mut canvas = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 700 | } [INFO] [stdout] 701 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/railway/feature/track.rs:747:5 [INFO] [stdout] | [INFO] [stdout] 747 | / fn new<'a>(contour: &'a TrackContour, style: &Style) -> AnyShape<'a> { [INFO] [stdout] 748 | | let open = contour.class.class.status().is_open(); [INFO] [stdout] 749 | | let color = style.track_color(&contour.class.class); [INFO] [stdout] 750 | | let width = style.measures().class_track(&contour.class.class); [INFO] [stdout] ... | [INFO] [stdout] 795 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/railway/feature/track.rs:881:33 [INFO] [stdout] | [INFO] [stdout] 881 | if self.open && !self.dash.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.dash.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:849:17 [INFO] [stdout] | [INFO] [stdout] 849 | / if !self.open { [INFO] [stdout] 850 | | self.render_base(&mut canvas.sketch()); [INFO] [stdout] 851 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 848 ~ Stage::AbandonedBase [INFO] [stdout] 849 ~ if !self.open => { [INFO] [stdout] 850 | self.render_base(&mut canvas.sketch()); [INFO] [stdout] 851 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:854:17 [INFO] [stdout] | [INFO] [stdout] 854 | / if !self.open { [INFO] [stdout] 855 | | let mut canvas = canvas.sketch(); [INFO] [stdout] 856 | | if let Some(dash) = self.dash { [INFO] [stdout] 857 | | self.render_dashed_track(dash, &mut canvas) [INFO] [stdout] ... | [INFO] [stdout] 862 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 853 ~ Stage::AbandonedMarking [INFO] [stdout] 854 ~ if !self.open => { [INFO] [stdout] 855 | let mut canvas = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 861 | } [INFO] [stdout] 862 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:865:17 [INFO] [stdout] | [INFO] [stdout] 865 | / if self.open && self.dash.is_some() { [INFO] [stdout] 866 | | self.render_base(&mut canvas.sketch()); [INFO] [stdout] 867 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 864 ~ Stage::LimitedBase [INFO] [stdout] 865 ~ if self.open && self.dash.is_some() => { [INFO] [stdout] 866 | self.render_base(&mut canvas.sketch()); [INFO] [stdout] 867 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:870:17 [INFO] [stdout] | [INFO] [stdout] 870 | / if self.open { [INFO] [stdout] 871 | | let mut canvas = canvas.sketch(); [INFO] [stdout] 872 | | if let Some(dash) = self.dash { [INFO] [stdout] 873 | | self.render_dashed_track(dash, &mut canvas) [INFO] [stdout] ... | [INFO] [stdout] 878 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 869 ~ Stage::LimitedMarking [INFO] [stdout] 870 ~ if self.open => { [INFO] [stdout] 871 | let mut canvas = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 877 | } [INFO] [stdout] 878 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:881:17 [INFO] [stdout] | [INFO] [stdout] 881 | / if self.open && !self.dash.is_some() { [INFO] [stdout] 882 | | let mut canvas = canvas.sketch(); [INFO] [stdout] 883 | | self.render_base(&mut canvas); [INFO] [stdout] 884 | | if let Some(electric) = self.electric { [INFO] [stdout] ... | [INFO] [stdout] 887 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 880 ~ Stage::Base [INFO] [stdout] 881 ~ if self.open && !self.dash.is_some() => { [INFO] [stdout] 882 | let mut canvas = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 886 | } [INFO] [stdout] 887 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/railway/feature/dot.rs:127:14 [INFO] [stdout] | [INFO] [stdout] 127 | else if symbols.take("over") { [INFO] [stdout] | ______________^ [INFO] [stdout] 128 | | false [INFO] [stdout] 129 | | } [INFO] [stdout] 130 | | else { [INFO] [stdout] 131 | | true [INFO] [stdout] 132 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `{ !symbols.take("over") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/dot.rs:171:17 [INFO] [stdout] | [INFO] [stdout] 171 | / if self.feature.casing { [INFO] [stdout] 172 | | let mut sketch = canvas.sketch(); [INFO] [stdout] 173 | | sketch.apply( [INFO] [stdout] 174 | | Circle::new( [INFO] [stdout] ... | [INFO] [stdout] 184 | | sketch.fill(); [INFO] [stdout] 185 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 170 ~ Stage::MarkerCasing [INFO] [stdout] 171 ~ if self.feature.casing => { [INFO] [stdout] 172 | let mut sketch = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 184 | sketch.fill(); [INFO] [stdout] 185 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/railway/feature/dot.rs:262:40 [INFO] [stdout] | [INFO] [stdout] 262 | else if symbols.take("medium") { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 263 | | Size::Medium [INFO] [stdout] 264 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/railway/feature/dot.rs:265:14 [INFO] [stdout] | [INFO] [stdout] 265 | else { [INFO] [stdout] | ______________^ [INFO] [stdout] 266 | | Size::Medium [INFO] [stdout] 267 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/railway/feature/oldmarker.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | / pub fn new( [INFO] [stdout] 70 | | position: Position, [INFO] [stdout] 71 | | orientation: f64, [INFO] [stdout] 72 | | class: Railway, [INFO] [stdout] ... | [INFO] [stdout] 84 | | Ok(StandardMarker { position, orientation, class, marker }.into()) [INFO] [stdout] 85 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/guide.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | / if self.contour.casing { [INFO] [stdout] 79 | | let mut sketch = canvas.sketch(); [INFO] [stdout] 80 | | sketch.apply(&self.trace); [INFO] [stdout] 81 | | sketch.apply(LineWidth( [INFO] [stdout] ... | [INFO] [stdout] 85 | | sketch.stroke(); [INFO] [stdout] 86 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 77 ~ Stage::Casing [INFO] [stdout] 78 ~ if self.contour.casing => { [INFO] [stdout] 79 | let mut sketch = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 85 | sketch.stroke(); [INFO] [stdout] 86 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/railway/feature/oldmarker.rs:127:39 [INFO] [stdout] | [INFO] [stdout] 127 | else if symbols.take("right") { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 128 | | Ok(0.) [INFO] [stdout] 129 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/railway/feature/oldmarker.rs:130:14 [INFO] [stdout] | [INFO] [stdout] 130 | else { [INFO] [stdout] | ______________^ [INFO] [stdout] 131 | | Ok(0.) [INFO] [stdout] 132 | | /* [INFO] [stdout] 133 | | err.add(pos, "missing orientation"); [INFO] [stdout] 134 | | Err(Failed) [INFO] [stdout] 135 | | */ [INFO] [stdout] 136 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/feature/label.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | return Err(Failed) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return Err(Failed) [INFO] [stdout] 122 + Err(Failed) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/feature/label.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 144 | return Err(Failed) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return Err(Failed) [INFO] [stdout] 144 + Err(Failed) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/railway/feature/marker.rs:151:39 [INFO] [stdout] | [INFO] [stdout] 151 | else if symbols.take("right") { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 152 | | Ok(Self::Right) [INFO] [stdout] 153 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/railway/feature/marker.rs:154:14 [INFO] [stdout] | [INFO] [stdout] 154 | else { [INFO] [stdout] | ______________^ [INFO] [stdout] 155 | | Ok(Self::Right) [INFO] [stdout] 156 | | /* [INFO] [stdout] 157 | | err.add(pos, "missing orientation"); [INFO] [stdout] 158 | | Err(Failed) [INFO] [stdout] 159 | | */ [INFO] [stdout] 160 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Matrix` which implements the `Copy` trait [INFO] [stdout] --> src/railway/feature/marker.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 192 | matrix.clone().invert().transform_point(extent) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `matrix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/feature/track.rs:274:13 [INFO] [stdout] | [INFO] [stdout] 274 | return AnyShape::from(ContourShape2::new(self, style)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 274 - return AnyShape::from(ContourShape2::new(self, style)); [INFO] [stdout] 274 + AnyShape::from(ContourShape2::new(self, style)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/feature/track.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | return AnyShape::from(ContourShape3::new(self, style)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - return AnyShape::from(ContourShape3::new(self, style)); [INFO] [stdout] 277 + AnyShape::from(ContourShape3::new(self, style)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/railway/feature/track.rs:280:13 [INFO] [stdout] | [INFO] [stdout] 280 | return ContourShape4::new(self, style) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 280 - return ContourShape4::new(self, style) [INFO] [stdout] 280 + ContourShape4::new(self, style) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/railway/feature/oldmarker.rs:996:28 [INFO] [stdout] | [INFO] [stdout] 996 | canvas.line_to(-1.0 * u.dt(), 0.0); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using: `-u.dt()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:446:17 [INFO] [stdout] | [INFO] [stdout] 446 | / if !self.open { [INFO] [stdout] 447 | | canvas.sketch() [INFO] [stdout] 448 | | .apply( [INFO] [stdout] 449 | | if self.dash.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 458 | | .stroke() [INFO] [stdout] 459 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 445 ~ Stage::AbandonedBase [INFO] [stdout] 446 ~ if !self.open => { [INFO] [stdout] 447 | canvas.sketch() [INFO] [stdout] ... [INFO] [stdout] 458 | .stroke() [INFO] [stdout] 459 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:462:17 [INFO] [stdout] | [INFO] [stdout] 462 | / if !self.open { [INFO] [stdout] 463 | | if let Some(dash) = self.dash { [INFO] [stdout] 464 | | canvas.sketch() [INFO] [stdout] 465 | | .apply(self.color) [INFO] [stdout] ... | [INFO] [stdout] 471 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 461 ~ Stage::AbandonedMarking [INFO] [stdout] 462 ~ if !self.open => { [INFO] [stdout] 463 | if let Some(dash) = self.dash { [INFO] [stdout] ... [INFO] [stdout] 470 | } [INFO] [stdout] 471 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:474:17 [INFO] [stdout] | [INFO] [stdout] 474 | / if self.open && self.dash.is_some() { [INFO] [stdout] 475 | | canvas.sketch() [INFO] [stdout] 476 | | .apply(Color::rgba(1., 1., 1., 0.8)) [INFO] [stdout] 477 | | .apply(LineWidth(self.width)) [INFO] [stdout] 478 | | .apply(&self.outline) [INFO] [stdout] 479 | | .stroke() [INFO] [stdout] 480 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 473 ~ Stage::LimitedBase [INFO] [stdout] 474 ~ if self.open && self.dash.is_some() => { [INFO] [stdout] 475 | canvas.sketch() [INFO] [stdout] ... [INFO] [stdout] 479 | .stroke() [INFO] [stdout] 480 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:483:17 [INFO] [stdout] | [INFO] [stdout] 483 | / if self.open { [INFO] [stdout] 484 | | if let Some(dash) = self.dash { [INFO] [stdout] 485 | | canvas.sketch() [INFO] [stdout] 486 | | .apply(self.color) [INFO] [stdout] ... | [INFO] [stdout] 492 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 482 ~ Stage::LimitedMarking [INFO] [stdout] 483 ~ if self.open => { [INFO] [stdout] 484 | if let Some(dash) = self.dash { [INFO] [stdout] ... [INFO] [stdout] 491 | } [INFO] [stdout] 492 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:495:17 [INFO] [stdout] | [INFO] [stdout] 495 | / if self.open && self.dash.is_none() { [INFO] [stdout] 496 | | canvas.sketch() [INFO] [stdout] 497 | | .apply(self.color) [INFO] [stdout] 498 | | .apply(LineWidth(self.width)) [INFO] [stdout] 499 | | .apply(&self.outline) [INFO] [stdout] 500 | | .stroke() [INFO] [stdout] 501 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 494 ~ Stage::Base [INFO] [stdout] 495 ~ if self.open && self.dash.is_none() => { [INFO] [stdout] 496 | canvas.sketch() [INFO] [stdout] ... [INFO] [stdout] 500 | .stroke() [INFO] [stdout] 501 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:634:17 [INFO] [stdout] | [INFO] [stdout] 634 | / if !self.open { [INFO] [stdout] 635 | | canvas.sketch() [INFO] [stdout] 636 | | .apply( [INFO] [stdout] 637 | | if self.dash.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 646 | | .stroke() [INFO] [stdout] 647 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 633 ~ Stage::AbandonedBase [INFO] [stdout] 634 ~ if !self.open => { [INFO] [stdout] 635 | canvas.sketch() [INFO] [stdout] ... [INFO] [stdout] 646 | .stroke() [INFO] [stdout] 647 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:650:17 [INFO] [stdout] | [INFO] [stdout] 650 | / if !self.open { [INFO] [stdout] 651 | | let mut canvas = canvas.sketch(); [INFO] [stdout] 652 | | if let Some(dash) = self.dash { [INFO] [stdout] 653 | | canvas [INFO] [stdout] ... | [INFO] [stdout] 663 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 649 ~ Stage::AbandonedMarking [INFO] [stdout] 650 ~ if !self.open => { [INFO] [stdout] 651 | let mut canvas = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 662 | } [INFO] [stdout] 663 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:666:17 [INFO] [stdout] | [INFO] [stdout] 666 | / if self.open && self.dash.is_some() { [INFO] [stdout] 667 | | canvas.sketch() [INFO] [stdout] 668 | | .apply(Color::rgba(1., 1., 1., 0.8)) [INFO] [stdout] 669 | | .apply(LineWidth(self.width)) [INFO] [stdout] 670 | | .apply(&self.outline) [INFO] [stdout] 671 | | .stroke(); [INFO] [stdout] 672 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 665 ~ Stage::LimitedBase [INFO] [stdout] 666 ~ if self.open && self.dash.is_some() => { [INFO] [stdout] 667 | canvas.sketch() [INFO] [stdout] ... [INFO] [stdout] 671 | .stroke(); [INFO] [stdout] 672 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:675:17 [INFO] [stdout] | [INFO] [stdout] 675 | / if self.open { [INFO] [stdout] 676 | | let mut canvas = canvas.sketch(); [INFO] [stdout] 677 | | if let Some(dash) = self.dash { [INFO] [stdout] 678 | | canvas [INFO] [stdout] ... | [INFO] [stdout] 688 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 674 ~ Stage::LimitedMarking [INFO] [stdout] 675 ~ if self.open => { [INFO] [stdout] 676 | let mut canvas = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 687 | } [INFO] [stdout] 688 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:691:17 [INFO] [stdout] | [INFO] [stdout] 691 | / if self.open && self.dash.is_none() { [INFO] [stdout] 692 | | let mut canvas = canvas.sketch(); [INFO] [stdout] 693 | | canvas [INFO] [stdout] 694 | | .apply(self.color) [INFO] [stdout] ... | [INFO] [stdout] 701 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 690 ~ Stage::Base [INFO] [stdout] 691 ~ if self.open && self.dash.is_none() => { [INFO] [stdout] 692 | let mut canvas = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 700 | } [INFO] [stdout] 701 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/railway/feature/track.rs:747:5 [INFO] [stdout] | [INFO] [stdout] 747 | / fn new<'a>(contour: &'a TrackContour, style: &Style) -> AnyShape<'a> { [INFO] [stdout] 748 | | let open = contour.class.class.status().is_open(); [INFO] [stdout] 749 | | let color = style.track_color(&contour.class.class); [INFO] [stdout] 750 | | let width = style.measures().class_track(&contour.class.class); [INFO] [stdout] ... | [INFO] [stdout] 795 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/railway/feature/track.rs:881:33 [INFO] [stdout] | [INFO] [stdout] 881 | if self.open && !self.dash.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.dash.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:849:17 [INFO] [stdout] | [INFO] [stdout] 849 | / if !self.open { [INFO] [stdout] 850 | | self.render_base(&mut canvas.sketch()); [INFO] [stdout] 851 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 848 ~ Stage::AbandonedBase [INFO] [stdout] 849 ~ if !self.open => { [INFO] [stdout] 850 | self.render_base(&mut canvas.sketch()); [INFO] [stdout] 851 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:854:17 [INFO] [stdout] | [INFO] [stdout] 854 | / if !self.open { [INFO] [stdout] 855 | | let mut canvas = canvas.sketch(); [INFO] [stdout] 856 | | if let Some(dash) = self.dash { [INFO] [stdout] 857 | | self.render_dashed_track(dash, &mut canvas) [INFO] [stdout] ... | [INFO] [stdout] 862 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 853 ~ Stage::AbandonedMarking [INFO] [stdout] 854 ~ if !self.open => { [INFO] [stdout] 855 | let mut canvas = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 861 | } [INFO] [stdout] 862 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:865:17 [INFO] [stdout] | [INFO] [stdout] 865 | / if self.open && self.dash.is_some() { [INFO] [stdout] 866 | | self.render_base(&mut canvas.sketch()); [INFO] [stdout] 867 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 864 ~ Stage::LimitedBase [INFO] [stdout] 865 ~ if self.open && self.dash.is_some() => { [INFO] [stdout] 866 | self.render_base(&mut canvas.sketch()); [INFO] [stdout] 867 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:870:17 [INFO] [stdout] | [INFO] [stdout] 870 | / if self.open { [INFO] [stdout] 871 | | let mut canvas = canvas.sketch(); [INFO] [stdout] 872 | | if let Some(dash) = self.dash { [INFO] [stdout] 873 | | self.render_dashed_track(dash, &mut canvas) [INFO] [stdout] ... | [INFO] [stdout] 878 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 869 ~ Stage::LimitedMarking [INFO] [stdout] 870 ~ if self.open => { [INFO] [stdout] 871 | let mut canvas = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 877 | } [INFO] [stdout] 878 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/railway/feature/track.rs:881:17 [INFO] [stdout] | [INFO] [stdout] 881 | / if self.open && !self.dash.is_some() { [INFO] [stdout] 882 | | let mut canvas = canvas.sketch(); [INFO] [stdout] 883 | | self.render_base(&mut canvas); [INFO] [stdout] 884 | | if let Some(electric) = self.electric { [INFO] [stdout] ... | [INFO] [stdout] 887 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 880 ~ Stage::Base [INFO] [stdout] 881 ~ if self.open && !self.dash.is_some() => { [INFO] [stdout] 882 | let mut canvas = canvas.sketch(); [INFO] [stdout] ... [INFO] [stdout] 886 | } [INFO] [stdout] 887 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `array` [INFO] [stdout] --> src/railway/measures.rs:268:23 [INFO] [stdout] | [INFO] [stdout] 268 | (&mut self.0).into_iter().for_each(|value| *value *= rhs); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/railway/feature/oldmarker.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | / pub fn new( [INFO] [stdout] 70 | | position: Position, [INFO] [stdout] 71 | | orientation: f64, [INFO] [stdout] 72 | | class: Railway, [INFO] [stdout] ... | [INFO] [stdout] 84 | | Ok(StandardMarker { position, orientation, class, marker }.into()) [INFO] [stdout] 85 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/railway/feature/oldmarker.rs:127:39 [INFO] [stdout] | [INFO] [stdout] 127 | else if symbols.take("right") { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 128 | | Ok(0.) [INFO] [stdout] 129 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/railway/feature/oldmarker.rs:130:14 [INFO] [stdout] | [INFO] [stdout] 130 | else { [INFO] [stdout] | ______________^ [INFO] [stdout] 131 | | Ok(0.) [INFO] [stdout] 132 | | /* [INFO] [stdout] 133 | | err.add(pos, "missing orientation"); [INFO] [stdout] 134 | | Err(Failed) [INFO] [stdout] 135 | | */ [INFO] [stdout] 136 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are explicitly cloning with `.map()` [INFO] [stdout] --> src/server.rs:181:22 [INFO] [stdout] | [INFO] [stdout] 181 | let cached = self.cache.lock().unwrap().get(&tile).map(Clone::clone); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.cache.lock().unwrap().get(&tile).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TileId` which implements the `Copy` trait [INFO] [stdout] --> src/server.rs:186:48 [INFO] [stdout] | [INFO] [stdout] 186 | self.cache.lock().unwrap().put(tile.clone(), bytes.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `tile` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/tile.rs:272:17 [INFO] [stdout] | [INFO] [stdout] 271 | let stream = *(stream.downcast::>().unwrap()); [INFO] [stdout] | ------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 272 | stream [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 271 ~ [INFO] [stdout] 272 ~ *(stream.downcast::>().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/railway/feature/oldmarker.rs:996:28 [INFO] [stdout] | [INFO] [stdout] 996 | canvas.line_to(-1.0 * u.dt(), 0.0); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using: `-u.dt()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `array` [INFO] [stdout] --> src/railway/measures.rs:268:23 [INFO] [stdout] | [INFO] [stdout] 268 | (&mut self.0).into_iter().for_each(|value| *value *= rhs); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are explicitly cloning with `.map()` [INFO] [stdout] --> src/server.rs:181:22 [INFO] [stdout] | [INFO] [stdout] 181 | let cached = self.cache.lock().unwrap().get(&tile).map(Clone::clone); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.cache.lock().unwrap().get(&tile).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TileId` which implements the `Copy` trait [INFO] [stdout] --> src/server.rs:186:48 [INFO] [stdout] | [INFO] [stdout] 186 | self.cache.lock().unwrap().put(tile.clone(), bytes.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `tile` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/tile.rs:272:17 [INFO] [stdout] | [INFO] [stdout] 271 | let stream = *(stream.downcast::>().unwrap()); [INFO] [stdout] | ------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 272 | stream [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 271 ~ [INFO] [stdout] 272 ~ *(stream.downcast::>().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:199:21 [INFO] [stdout] | [INFO] [stdout] 199 | / match res { [INFO] [stdout] 200 | | Ok(ev) => { [INFO] [stdout] 201 | | let mut skip = true; [INFO] [stdout] 202 | | for path in &ev.paths { [INFO] [stdout] ... | [INFO] [stdout] 217 | | _ => { } // XXX Ignore errors for now. [INFO] [stdout] 218 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 199 ~ if let Ok(ev) = res { [INFO] [stdout] 200 + let mut skip = true; [INFO] [stdout] 201 + for path in &ev.paths { [INFO] [stdout] 202 + if let Some(name) = path.file_name() { [INFO] [stdout] 203 + if name.as_encoded_bytes().first() [INFO] [stdout] 204 + != Some(&b'.') [INFO] [stdout] 205 + { [INFO] [stdout] 206 + skip = false; [INFO] [stdout] 207 + break; [INFO] [stdout] 208 + } [INFO] [stdout] 209 + } [INFO] [stdout] 210 + } [INFO] [stdout] 211 + if skip { [INFO] [stdout] 212 + return [INFO] [stdout] 213 + } [INFO] [stdout] 214 + let _ = ev_tx.blocking_send(()); [INFO] [stdout] 215 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: current MSRV (Minimum Supported Rust Version) is `1.65.0` but this item is stable since `1.74.0` [INFO] [stdout] --> src/main.rs:204:45 [INFO] [stdout] | [INFO] [stdout] 204 | ... if name.as_encoded_bytes().first() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv [INFO] [stdout] = note: `#[warn(clippy::incompatible_msrv)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:199:21 [INFO] [stdout] | [INFO] [stdout] 199 | / match res { [INFO] [stdout] 200 | | Ok(ev) => { [INFO] [stdout] 201 | | let mut skip = true; [INFO] [stdout] 202 | | for path in &ev.paths { [INFO] [stdout] ... | [INFO] [stdout] 217 | | _ => { } // XXX Ignore errors for now. [INFO] [stdout] 218 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 199 ~ if let Ok(ev) = res { [INFO] [stdout] 200 + let mut skip = true; [INFO] [stdout] 201 + for path in &ev.paths { [INFO] [stdout] 202 + if let Some(name) = path.file_name() { [INFO] [stdout] 203 + if name.as_encoded_bytes().first() [INFO] [stdout] 204 + != Some(&b'.') [INFO] [stdout] 205 + { [INFO] [stdout] 206 + skip = false; [INFO] [stdout] 207 + break; [INFO] [stdout] 208 + } [INFO] [stdout] 209 + } [INFO] [stdout] 210 + } [INFO] [stdout] 211 + if skip { [INFO] [stdout] 212 + return [INFO] [stdout] 213 + } [INFO] [stdout] 214 + let _ = ev_tx.blocking_send(()); [INFO] [stdout] 215 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: current MSRV (Minimum Supported Rust Version) is `1.65.0` but this item is stable since `1.74.0` [INFO] [stdout] --> src/main.rs:204:45 [INFO] [stdout] | [INFO] [stdout] 204 | ... if name.as_encoded_bytes().first() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv [INFO] [stdout] = note: `#[warn(clippy::incompatible_msrv)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 45.16s [INFO] running `Command { std: "docker" "inspect" "2cd854c58d1e2f51e7d539845c67351a47b9f0d8a69194a4ed0a7712deeaafd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cd854c58d1e2f51e7d539845c67351a47b9f0d8a69194a4ed0a7712deeaafd6", kill_on_drop: false }` [INFO] [stdout] 2cd854c58d1e2f51e7d539845c67351a47b9f0d8a69194a4ed0a7712deeaafd6