[INFO] cloning repository https://github.com/r4f4/game-fifteen-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/r4f4/game-fifteen-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fr4f4%2Fgame-fifteen-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fr4f4%2Fgame-fifteen-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 28bd9185d765337fb7c6aee0d9d33ab21f7d4d22 [INFO] linting r4f4/game-fifteen-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fr4f4%2Fgame-fifteen-rs" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/r4f4/game-fifteen-rs [INFO] finished tweaking git repo https://github.com/r4f4/game-fifteen-rs [INFO] tweaked toml for git repo https://github.com/r4f4/game-fifteen-rs written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/r4f4/game-fifteen-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/r4f4/game-fifteen-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1419a98e466c7ffe559eb03657c5fffc4ae61b4e0710016e4d9b57303d80fc98 [INFO] running `Command { std: "docker" "start" "-a" "1419a98e466c7ffe559eb03657c5fffc4ae61b4e0710016e4d9b57303d80fc98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1419a98e466c7ffe559eb03657c5fffc4ae61b4e0710016e4d9b57303d80fc98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1419a98e466c7ffe559eb03657c5fffc4ae61b4e0710016e4d9b57303d80fc98", kill_on_drop: false }` [INFO] [stdout] 1419a98e466c7ffe559eb03657c5fffc4ae61b4e0710016e4d9b57303d80fc98 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe7fa67c40168c253cc18069618d5cf481394e76dfd86bcb90fc1927ef699e07 [INFO] running `Command { std: "docker" "start" "-a" "fe7fa67c40168c253cc18069618d5cf481394e76dfd86bcb90fc1927ef699e07", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking getrandom v0.1.14 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking game15 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/solver.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | ((diff / 4) + (diff % 4)) // # of rows + cols to move [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 47 - ((diff / 4) + (diff % 4)) // # of rows + cols to move [INFO] [stdout] 47 + (diff / 4) + (diff % 4) // # of rows + cols to move [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/board.rs:187:28 [INFO] [stdout] | [INFO] [stdout] 187 | const DEFAULT_CONFIG: &'static [u8; SIZE * SIZE] = [INFO] [stdout] | -^^^^^^^------------------ help: consider removing `'static`: `&[u8; SIZE * SIZE]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/board.rs:189:27 [INFO] [stdout] | [INFO] [stdout] 189 | const SOLVED_CONFIG: &'static [u8; SIZE * SIZE] = [INFO] [stdout] | -^^^^^^^------------------ help: consider removing `'static`: `&[u8; SIZE * SIZE]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/board.rs:191:29 [INFO] [stdout] | [INFO] [stdout] 191 | const SOLVABLE_CONFIG: &'static [u8; SIZE * SIZE] = [INFO] [stdout] | -^^^^^^^------------------ help: consider removing `'static`: `&[u8; SIZE * SIZE]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/solver.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | ((diff / 4) + (diff % 4)) // # of rows + cols to move [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 47 - ((diff / 4) + (diff % 4)) // # of rows + cols to move [INFO] [stdout] 47 + (diff / 4) + (diff % 4) // # of rows + cols to move [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/solver.rs:110:29 [INFO] [stdout] | [INFO] [stdout] 110 | const SOLVABLE_CONFIG: &'static [u8; 16] = [INFO] [stdout] | -^^^^^^^--------- help: consider removing `'static`: `&[u8; 16]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/solver.rs:112:27 [INFO] [stdout] | [INFO] [stdout] 112 | const ALMOST_CONFIG: &'static [u8; 16] = [INFO] [stdout] | -^^^^^^^--------- help: consider removing `'static`: `&[u8; 16]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/board.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | / match ((self.empty / SIZE) % 2 == 0, invs % 2 == 0) { [INFO] [stdout] 157 | | (true, false) | (false, true) => true, [INFO] [stdout] 158 | | _ => false, [INFO] [stdout] 159 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 156 - match ((self.empty / SIZE) % 2 == 0, invs % 2 == 0) { [INFO] [stdout] 157 - (true, false) | (false, true) => true, [INFO] [stdout] 158 - _ => false, [INFO] [stdout] 159 - } [INFO] [stdout] 156 + matches!(((self.empty / SIZE) % 2 == 0, invs % 2 == 0), (true, false) | (false, true)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/board.rs:156:16 [INFO] [stdout] | [INFO] [stdout] 156 | match ((self.empty / SIZE) % 2 == 0, invs % 2 == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(self.empty / SIZE).is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/board.rs:156:46 [INFO] [stdout] | [INFO] [stdout] 156 | match ((self.empty / SIZE) % 2 == 0, invs % 2 == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `invs.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/board.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | / match ((self.empty / SIZE) % 2 == 0, invs % 2 == 0) { [INFO] [stdout] 157 | | (true, false) | (false, true) => true, [INFO] [stdout] 158 | | _ => false, [INFO] [stdout] 159 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 156 - match ((self.empty / SIZE) % 2 == 0, invs % 2 == 0) { [INFO] [stdout] 157 - (true, false) | (false, true) => true, [INFO] [stdout] 158 - _ => false, [INFO] [stdout] 159 - } [INFO] [stdout] 156 + matches!(((self.empty / SIZE) % 2 == 0, invs % 2 == 0), (true, false) | (false, true)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/board.rs:156:16 [INFO] [stdout] | [INFO] [stdout] 156 | match ((self.empty / SIZE) % 2 == 0, invs % 2 == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(self.empty / SIZE).is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/board.rs:156:46 [INFO] [stdout] | [INFO] [stdout] 156 | match ((self.empty / SIZE) % 2 == 0, invs % 2 == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `invs.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | assert!(!board.slide_safe(dir).is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `board.slide_safe(dir).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solver.rs:124:29 [INFO] [stdout] | [INFO] [stdout] 124 | assert!(!board.slide_safe(dir).is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `board.slide_safe(dir).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:58:35 [INFO] [stdout] | [INFO] [stdout] 58 | v.retain(|&x| x != ""); [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | assert!(!board.slide_safe(dir).is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `board.slide_safe(dir).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solver.rs:141:29 [INFO] [stdout] | [INFO] [stdout] 141 | assert!(!board.slide_safe(dir).is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `board.slide_safe(dir).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:58:35 [INFO] [stdout] | [INFO] [stdout] 58 | v.retain(|&x| x != ""); [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solver.rs:157:29 [INFO] [stdout] | [INFO] [stdout] 157 | assert!(!board.slide_safe(dir).is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `board.slide_safe(dir).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.18s [INFO] running `Command { std: "docker" "inspect" "fe7fa67c40168c253cc18069618d5cf481394e76dfd86bcb90fc1927ef699e07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe7fa67c40168c253cc18069618d5cf481394e76dfd86bcb90fc1927ef699e07", kill_on_drop: false }` [INFO] [stdout] fe7fa67c40168c253cc18069618d5cf481394e76dfd86bcb90fc1927ef699e07