[INFO] cloning repository https://github.com/quackmagic/duckdb-extension-clickhouse-native [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/quackmagic/duckdb-extension-clickhouse-native" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fquackmagic%2Fduckdb-extension-clickhouse-native", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fquackmagic%2Fduckdb-extension-clickhouse-native'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3f6207bdf590060d20b22fd3430b70a30640e052 [INFO] linting quackmagic/duckdb-extension-clickhouse-native/3f6207bdf590060d20b22fd3430b70a30640e052 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fquackmagic%2Fduckdb-extension-clickhouse-native" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-6-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/quackmagic/duckdb-extension-clickhouse-native [INFO] removed 0 missing examples [INFO] finished tweaking git repo https://github.com/quackmagic/duckdb-extension-clickhouse-native [INFO] tweaked toml for git repo https://github.com/quackmagic/duckdb-extension-clickhouse-native written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/quackmagic/duckdb-extension-clickhouse-native on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/quackmagic/duckdb-extension-clickhouse-native already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded duckdb-loadable-macros v0.1.14 [INFO] [stderr] Downloaded lz4 v1.28.0 [INFO] [stderr] Downloaded clickhouse-rs-cityhash-sys v0.1.2 [INFO] [stderr] Downloaded lexical-core v1.0.2 [INFO] [stderr] Downloaded arrow-arith v56.2.0 [INFO] [stderr] Downloaded comfy-table v7.1.2 [INFO] [stderr] Downloaded clickhouse-rs v1.1.0-alpha.1 [INFO] [stderr] Downloaded lexical-write-float v1.0.2 [INFO] [stderr] Downloaded arrow-cast v56.2.0 [INFO] [stderr] Downloaded lexical-util v1.0.3 [INFO] [stderr] Downloaded arrow-buffer v56.2.0 [INFO] [stderr] Downloaded arrow v56.2.0 [INFO] [stderr] Downloaded lexical-parse-float v1.0.2 [INFO] [stderr] Downloaded zlib-rs v0.6.1 [INFO] [stderr] Downloaded zip v6.0.0 [INFO] [stderr] Downloaded arrow-ord v56.2.0 [INFO] [stderr] Downloaded arrow-data v56.2.0 [INFO] [stderr] Downloaded arrow-array v56.2.0 [INFO] [stderr] Downloaded arrow-schema v56.2.0 [INFO] [stderr] Downloaded lexical-parse-integer v1.0.2 [INFO] [stderr] Downloaded lexical-write-integer v1.0.2 [INFO] [stderr] Downloaded arrow-select v56.2.0 [INFO] [stderr] Downloaded arrow-string v56.2.0 [INFO] [stderr] Downloaded arrow-row v56.2.0 [INFO] [stderr] Downloaded duckdb v1.4.4 [INFO] [stderr] Downloaded libduckdb-sys v1.4.4 [INFO] [stderr] Downloaded openssl-src v300.4.1+3.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 20ed546a41f20264b19592af908c86d1666fa6902692b81c739ca8b15b8b1218 [INFO] running `Command { std: "docker" "start" "-a" "20ed546a41f20264b19592af908c86d1666fa6902692b81c739ca8b15b8b1218", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "20ed546a41f20264b19592af908c86d1666fa6902692b81c739ca8b15b8b1218", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20ed546a41f20264b19592af908c86d1666fa6902692b81c739ca8b15b8b1218", kill_on_drop: false }` [INFO] [stdout] 20ed546a41f20264b19592af908c86d1666fa6902692b81c739ca8b15b8b1218 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d779cb3b03598b9fa5077549f45cc198fbc0d623d9ad1a3385869ec712c3aedd [INFO] running `Command { std: "docker" "start" "-a" "d779cb3b03598b9fa5077549f45cc198fbc0d623d9ad1a3385869ec712c3aedd", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling stable_deref_trait v1.2.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Compiling pin-project-lite v0.2.15 [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling litemap v0.7.4 [INFO] [stderr] Compiling writeable v0.5.5 [INFO] [stderr] Compiling zeroize v1.8.2 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling icu_locid_transform_data v1.5.0 [INFO] [stderr] Compiling untrusted v0.9.0 [INFO] [stderr] Compiling icu_properties_data v1.5.0 [INFO] [stderr] Compiling rustls-pki-types v1.14.0 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Checking arrow-schema v56.2.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling openssl-src v300.4.1+3.4.0 [INFO] [stderr] Compiling http v1.4.0 [INFO] [stderr] Compiling futures-io v0.3.32 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Compiling try-lock v0.2.5 [INFO] [stderr] Compiling write16 v1.0.0 [INFO] [stderr] Compiling utf16_iter v1.0.5 [INFO] [stderr] Compiling icu_normalizer_data v1.5.0 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Compiling want v0.3.1 [INFO] [stderr] Checking lexical-util v1.0.3 [INFO] [stderr] Compiling tracing-core v0.1.36 [INFO] [stderr] Compiling openssl-sys v0.9.104 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling syn v2.0.93 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling atomic-waker v1.1.2 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling simd-adler32 v0.3.8 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling tower-service v0.3.3 [INFO] [stderr] Compiling regex-syntax v0.8.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling socket2 v0.5.8 [INFO] [stderr] Compiling mio v1.0.3 [INFO] [stderr] Compiling tracing v0.1.44 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling tokio v1.42.0 [INFO] [stderr] Compiling http-body v1.0.1 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling webpki-roots v1.0.6 [INFO] [stderr] Compiling crc32fast v1.4.2 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling adler2 v2.0.0 [INFO] [stderr] Compiling miniz_oxide v0.8.9 [INFO] [stderr] Compiling sync_wrapper v1.0.2 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling zlib-rs v0.6.1 [INFO] [stderr] Compiling tower-layer v0.3.3 [INFO] [stderr] Compiling bumpalo v3.19.1 [INFO] [stderr] Compiling indexmap v2.6.0 [INFO] [stderr] Compiling webpki-roots v0.26.11 [INFO] [stderr] Compiling http-body-util v0.1.3 [INFO] [stderr] Compiling filetime v0.2.25 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking lexical-parse-integer v1.0.2 [INFO] [stderr] Compiling regex-automata v0.4.8 [INFO] [stderr] Compiling zopfli v0.8.2 [INFO] [stderr] Checking lexical-write-integer v1.0.2 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Compiling rustls-pemfile v2.2.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling openssl v0.10.68 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling mime v0.3.17 [INFO] [stderr] Compiling ipnet v2.11.0 [INFO] [stderr] Checking lexical-write-float v1.0.2 [INFO] [stderr] Checking lexical-parse-float v1.0.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling lz4-sys v1.11.1+lz4-1.10.0 [INFO] [stderr] Checking arrow-buffer v56.2.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking arrow-data v56.2.0 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking lexical-core v1.0.2 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking arrow-array v56.2.0 [INFO] [stderr] Compiling rustls-webpki v0.103.9 [INFO] [stderr] Compiling xattr v1.3.1 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling tar v0.4.42 [INFO] [stderr] Compiling clickhouse-rs-cityhash-sys v0.1.2 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking crossbeam-channel v0.5.14 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling regex v1.11.0 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Compiling chrono-tz-build v0.2.1 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Compiling flate2 v1.1.9 [INFO] [stderr] Checking serde_json v1.0.134 [INFO] [stderr] Checking arrow-select v56.2.0 [INFO] [stderr] Checking arrow-arith v56.2.0 [INFO] [stderr] Checking arrow-row v56.2.0 [INFO] [stderr] Compiling chrono-tz v0.8.6 [INFO] [stderr] Compiling zip v6.0.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling hyper v1.8.1 [INFO] [stderr] Compiling tower v0.5.3 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking arrow-ord v56.2.0 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking arrow-string v56.2.0 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling thiserror-impl v1.0.65 [INFO] [stderr] Compiling pin-project-internal v1.1.7 [INFO] [stderr] Compiling zerofrom v0.1.5 [INFO] [stderr] Compiling hyper-util v0.1.10 [INFO] [stderr] Compiling yoke v0.7.5 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling duckdb-loadable-macros v0.1.14 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Compiling tinystr v0.7.6 [INFO] [stderr] Compiling icu_collections v1.5.0 [INFO] [stderr] Compiling icu_locid v1.5.0 [INFO] [stderr] Checking pin-project v1.1.7 [INFO] [stderr] Checking thiserror v1.0.65 [INFO] [stderr] Compiling tokio-rustls v0.26.4 [INFO] [stderr] Compiling hyper-rustls v0.27.7 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking comfy-table v7.1.2 [INFO] [stderr] Checking arrow-cast v56.2.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Compiling serde_urlencoded v0.7.1 [INFO] [stderr] Checking arrow v56.2.0 [INFO] [stderr] Compiling icu_properties v1.5.1 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Compiling reqwest v0.12.12 [INFO] [stderr] Compiling libduckdb-sys v1.4.4 [INFO] [stderr] Checking duckdb v1.4.4 [INFO] [stderr] Checking lz4 v1.28.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking clickhouse-rs v1.1.0-alpha.1 [INFO] [stderr] Checking chsql_native v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error[E0583]: file not found for module `clickhouse_scan` [INFO] [stdout] --> src/lib.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | mod clickhouse_scan; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: to create the module `clickhouse_scan`, create file "src/lib/clickhouse_scan.rs" or "src/lib/clickhouse_scan/mod.rs" [INFO] [stdout] = note: if there is a `mod clickhouse_scan` elsewhere in the crate already, import it with `use crate::...` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0583`. [INFO] [stdout] [INFO] [stderr] error: could not compile `chsql_native` (example "chsql_native") due to 1 previous error [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/clickhouse_scan.rs:177:50 [INFO] [stdout] | [INFO] [stdout] 177 | let column_names = bind_data.column_names.iter().cloned().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `col_idx` is used to index `block_data` [INFO] [stdout] --> src/clickhouse_scan.rs:207:28 [INFO] [stdout] | [INFO] [stdout] 207 | for col_idx in 0..(*init_data).column_types.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 207 - for col_idx in 0..(*init_data).column_types.len() { [INFO] [stdout] 207 + for (col_idx, ) in block_data.iter().enumerate().take((*init_data).column_types.len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row_offset` is used to index `slice` [INFO] [stdout] --> src/clickhouse_scan.rs:214:43 [INFO] [stdout] | [INFO] [stdout] 214 | for row_offset in 0..batch_size { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 214 - for row_offset in 0..batch_size { [INFO] [stdout] 214 + for (row_offset, ) in slice.iter_mut().enumerate().take(batch_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/clickhouse_scan.rs:222:36 [INFO] [stdout] | [INFO] [stdout] 222 | ... } else if let Ok(v) = i32::from_str_radix(val_str.trim(), 10) { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 223 | | ... v [INFO] [stdout] 224 | | ... } else { [INFO] [stdout] 225 | | ... 0 [INFO] [stdout] 226 | | ... }; [INFO] [stdout] | |_______________________^ help: ascribe the type i32 and replace your expression with: `i32::from_str_radix(val_str.trim(), 10).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/clickhouse_scan.rs:222:51 [INFO] [stdout] | [INFO] [stdout] 222 | ... } else if let Ok(v) = i32::from_str_radix(val_str.trim(), 10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `val_str.trim().parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row_offset` is used to index `slice` [INFO] [stdout] --> src/clickhouse_scan.rs:232:43 [INFO] [stdout] | [INFO] [stdout] 232 | for row_offset in 0..batch_size { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 232 - for row_offset in 0..batch_size { [INFO] [stdout] 232 + for (row_offset, ) in slice.iter_mut().enumerate().take(batch_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/lib.rs:72:10 [INFO] [stdout] | [INFO] [stdout] 72 | .replace('\0', "") [INFO] [stdout] | __________^ [INFO] [stdout] 73 | | .replace('\u{FFFD}', "") [INFO] [stdout] | |________________________________^ help: replace with: `replace(['\0', '\u{FFFD}'], "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/lib.rs:310:49 [INFO] [stdout] | [INFO] [stdout] 310 | ... let cleaned = s.replace('\0', "").replace('\u{FFFD}', ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['\0', '\u{FFFD}'], "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `slice` [INFO] [stdout] --> src/lib.rs:319:32 [INFO] [stdout] | [INFO] [stdout] 319 | for row in 0..batch_size { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 319 - for row in 0..batch_size { [INFO] [stdout] 319 + for (row, ) in slice.iter_mut().enumerate().take(batch_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `slice` [INFO] [stdout] --> src/lib.rs:337:32 [INFO] [stdout] | [INFO] [stdout] 337 | for row in 0..batch_size { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 337 - for row in 0..batch_size { [INFO] [stdout] 337 + for (row, ) in slice.iter_mut().enumerate().take(batch_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `slice` [INFO] [stdout] --> src/lib.rs:346:32 [INFO] [stdout] | [INFO] [stdout] 346 | for row in 0..batch_size { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 346 - for row in 0..batch_size { [INFO] [stdout] 346 + for (row, ) in slice.iter_mut().enumerate().take(batch_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/lib.rs:368:1 [INFO] [stdout] | [INFO] [stdout] 368 | pub unsafe fn extension_entrypoint(con: Connection) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/clickhouse_scan.rs:177:50 [INFO] [stdout] | [INFO] [stdout] 177 | let column_names = bind_data.column_names.iter().cloned().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `col_idx` is used to index `block_data` [INFO] [stdout] --> src/clickhouse_scan.rs:207:28 [INFO] [stdout] | [INFO] [stdout] 207 | for col_idx in 0..(*init_data).column_types.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 207 - for col_idx in 0..(*init_data).column_types.len() { [INFO] [stdout] 207 + for (col_idx, ) in block_data.iter().enumerate().take((*init_data).column_types.len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row_offset` is used to index `slice` [INFO] [stdout] --> src/clickhouse_scan.rs:214:43 [INFO] [stdout] | [INFO] [stdout] 214 | for row_offset in 0..batch_size { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 214 - for row_offset in 0..batch_size { [INFO] [stdout] 214 + for (row_offset, ) in slice.iter_mut().enumerate().take(batch_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/clickhouse_scan.rs:222:36 [INFO] [stdout] | [INFO] [stdout] 222 | ... } else if let Ok(v) = i32::from_str_radix(val_str.trim(), 10) { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 223 | | ... v [INFO] [stdout] 224 | | ... } else { [INFO] [stdout] 225 | | ... 0 [INFO] [stdout] 226 | | ... }; [INFO] [stdout] | |_______________________^ help: ascribe the type i32 and replace your expression with: `i32::from_str_radix(val_str.trim(), 10).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/clickhouse_scan.rs:222:51 [INFO] [stdout] | [INFO] [stdout] 222 | ... } else if let Ok(v) = i32::from_str_radix(val_str.trim(), 10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `val_str.trim().parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row_offset` is used to index `slice` [INFO] [stdout] --> src/clickhouse_scan.rs:232:43 [INFO] [stdout] | [INFO] [stdout] 232 | for row_offset in 0..batch_size { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 232 - for row_offset in 0..batch_size { [INFO] [stdout] 232 + for (row_offset, ) in slice.iter_mut().enumerate().take(batch_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/lib.rs:72:10 [INFO] [stdout] | [INFO] [stdout] 72 | .replace('\0', "") [INFO] [stdout] | __________^ [INFO] [stdout] 73 | | .replace('\u{FFFD}', "") [INFO] [stdout] | |________________________________^ help: replace with: `replace(['\0', '\u{FFFD}'], "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/lib.rs:310:49 [INFO] [stdout] | [INFO] [stdout] 310 | ... let cleaned = s.replace('\0', "").replace('\u{FFFD}', ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['\0', '\u{FFFD}'], "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `slice` [INFO] [stdout] --> src/lib.rs:319:32 [INFO] [stdout] | [INFO] [stdout] 319 | for row in 0..batch_size { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 319 - for row in 0..batch_size { [INFO] [stdout] 319 + for (row, ) in slice.iter_mut().enumerate().take(batch_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `slice` [INFO] [stdout] --> src/lib.rs:337:32 [INFO] [stdout] | [INFO] [stdout] 337 | for row in 0..batch_size { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 337 - for row in 0..batch_size { [INFO] [stdout] 337 + for (row, ) in slice.iter_mut().enumerate().take(batch_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `slice` [INFO] [stdout] --> src/lib.rs:346:32 [INFO] [stdout] | [INFO] [stdout] 346 | for row in 0..batch_size { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 346 - for row in 0..batch_size { [INFO] [stdout] 346 + for (row, ) in slice.iter_mut().enumerate().take(batch_size) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/lib.rs:368:1 [INFO] [stdout] | [INFO] [stdout] 368 | pub unsafe fn extension_entrypoint(con: Connection) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "d779cb3b03598b9fa5077549f45cc198fbc0d623d9ad1a3385869ec712c3aedd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d779cb3b03598b9fa5077549f45cc198fbc0d623d9ad1a3385869ec712c3aedd", kill_on_drop: false }` [INFO] [stdout] d779cb3b03598b9fa5077549f45cc198fbc0d623d9ad1a3385869ec712c3aedd