[INFO] cloning repository https://github.com/puetzp/pullconf [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/puetzp/pullconf" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpuetzp%2Fpullconf", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpuetzp%2Fpullconf'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 176bd6dcca361b94a44299a0dc9ee532149b3151 [INFO] linting puetzp/pullconf against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpuetzp%2Fpullconf" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/puetzp/pullconf [INFO] finished tweaking git repo https://github.com/puetzp/pullconf [INFO] tweaked toml for git repo https://github.com/puetzp/pullconf written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/puetzp/pullconf on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/puetzp/pullconf already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anyhow v1.0.96 [INFO] [stderr] Downloaded gzip-header v1.0.0 [INFO] [stderr] Downloaded deflate v1.0.0 [INFO] [stderr] Downloaded rouille v3.6.2 [INFO] [stderr] Downloaded ureq-proto v0.3.3 [INFO] [stderr] Downloaded rustls-platform-verifier v0.3.4 [INFO] [stderr] Downloaded strict-yaml-rust v0.1.2 [INFO] [stderr] Downloaded zerocopy-derive v0.8.21 [INFO] [stderr] Downloaded ureq v3.0.8 [INFO] [stderr] Downloaded aws-lc-rs v1.12.5 [INFO] [stderr] Downloaded zerocopy v0.8.21 [INFO] [stderr] Downloaded aws-lc-sys v0.26.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2cb8ab182109531c3c3ea8b4044fe413364d538c4180e49fdb1e86a733d00394 [INFO] running `Command { std: "docker" "start" "-a" "2cb8ab182109531c3c3ea8b4044fe413364d538c4180e49fdb1e86a733d00394", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2cb8ab182109531c3c3ea8b4044fe413364d538c4180e49fdb1e86a733d00394", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cb8ab182109531c3c3ea8b4044fe413364d538c4180e49fdb1e86a733d00394", kill_on_drop: false }` [INFO] [stdout] 2cb8ab182109531c3c3ea8b4044fe413364d538c4180e49fdb1e86a733d00394 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 783c0fd34050f9b042567f98f3377c9d39f32bf426327aa95d336205df69e148 [INFO] running `Command { std: "docker" "start" "-a" "783c0fd34050f9b042567f98f3377c9d39f32bf426327aa95d336205df69e148", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.17 [INFO] [stderr] Compiling libc v0.2.170 [INFO] [stderr] Compiling getrandom v0.3.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking log v0.4.26 [INFO] [stderr] Compiling serde v1.0.218 [INFO] [stderr] Checking once_cell v1.20.3 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling httparse v1.10.0 [INFO] [stderr] Compiling aws-lc-rs v1.12.5 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking rustls-pki-types v1.11.0 [INFO] [stderr] Compiling time-macros v0.2.19 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Compiling serde_json v1.0.139 [INFO] [stderr] Compiling anyhow v1.0.96 [INFO] [stderr] Checking ryu v1.0.19 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling unicase v2.8.1 [INFO] [stderr] Compiling rustls v0.23.23 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling rustls v0.20.9 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking bytes v1.10.0 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Compiling zerocopy v0.8.21 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking buf_redux v0.8.4 [INFO] [stderr] Checking rustls-native-certs v0.7.3 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking miniz_oxide v0.8.5 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Checking rustls-pemfile v0.2.1 [INFO] [stderr] Checking gzip-header v1.0.0 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking chunked_transfer v1.5.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking flate2 v1.1.0 [INFO] [stderr] Checking deflate v1.0.0 [INFO] [stderr] Checking chrono v0.4.40 [INFO] [stderr] Checking webpki-roots v0.26.8 [INFO] [stderr] Checking brotli-decompressor v4.0.2 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking http v1.2.0 [INFO] [stderr] Checking strict-yaml-rust v0.1.2 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling cc v1.2.16 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ureq-proto v0.3.3 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Checking tempfile v3.17.1 [INFO] [stderr] Compiling ring v0.17.11 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling aws-lc-sys v0.26.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.218 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking env_logger v0.11.6 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand v0.9.0 [INFO] [stderr] Checking webpki v0.22.4 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking multipart v0.18.0 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking tiny_http v0.12.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking uuid v1.15.1 [INFO] [stderr] Checking time v0.3.37 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking common v0.1.0 (/opt/rustwide/workdir/common) [INFO] [stderr] Checking rouille v3.6.2 [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> common/src/resources/group.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | &self.0 == other.deref() [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `self.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> common/src/resources/group.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | &self.0 == other.deref() [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `self.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> common/src/resources/user.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 39 | match Date::parse(&s, EXPIRY_DATE_FORMAT) { [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> common/src/resources/user.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 39 | match Date::parse(&s, EXPIRY_DATE_FORMAT) { [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking pullconfd v0.5.0 (/opt/rustwide/workdir/server) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> server/src/configuration.rs:165:51 [INFO] [stdout] | [INFO] [stdout] 165 | let contents = fs::read_to_string(&path) [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> server/src/configuration.rs:165:51 [INFO] [stdout] | [INFO] [stdout] 165 | let contents = fs::read_to_string(&path) [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> server/src/types/client.rs:207:69 [INFO] [stdout] | [INFO] [stdout] 207 | .any(|id| self.relationship_introduces_loop(&id, target)) [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> server/src/types/client.rs:467:17 [INFO] [stdout] | [INFO] [stdout] 467 | / if resource.kind() == ResourceType::Execute { [INFO] [stdout] 468 | | if self [INFO] [stdout] 469 | | .temporary [INFO] [stdout] 470 | | .triggers [INFO] [stdout] ... | [INFO] [stdout] 490 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 467 ~ if resource.kind() == ResourceType::Execute [INFO] [stdout] 468 ~ && self [INFO] [stdout] 469 | .temporary [INFO] [stdout] ... [INFO] [stdout] 488 | } [INFO] [stdout] 489 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> server/src/types/client.rs:207:69 [INFO] [stdout] | [INFO] [stdout] 207 | .any(|id| self.relationship_introduces_loop(&id, target)) [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> server/src/types/client.rs:467:17 [INFO] [stdout] | [INFO] [stdout] 467 | / if resource.kind() == ResourceType::Execute { [INFO] [stdout] 468 | | if self [INFO] [stdout] 469 | | .temporary [INFO] [stdout] 470 | | .triggers [INFO] [stdout] ... | [INFO] [stdout] 490 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 467 ~ if resource.kind() == ResourceType::Execute [INFO] [stdout] 468 ~ && self [INFO] [stdout] 469 | .temporary [INFO] [stdout] ... [INFO] [stdout] 488 | } [INFO] [stdout] 489 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> server/src/types/resources/mod.rs:543:1 [INFO] [stdout] | [INFO] [stdout] 543 | / pub enum UnresolvedResource { [INFO] [stdout] 544 | | AptPackage { [INFO] [stdout] 545 | | parameters: apt::package::UnresolvedParameters, [INFO] [stdout] 546 | | requires: Vec, [INFO] [stdout] ... | [INFO] [stdout] 559 | | / File { [INFO] [stdout] 560 | | | parameters: file::UnresolvedParameters, [INFO] [stdout] 561 | | | requires: Vec, [INFO] [stdout] 562 | | | triggers: Vec, [INFO] [stdout] 563 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 888 bytes [INFO] [stdout] ... | [INFO] [stdout] 579 | | / User { [INFO] [stdout] 580 | | | parameters: user::UnresolvedParameters, [INFO] [stdout] 581 | | | requires: Vec, [INFO] [stdout] 582 | | | triggers: Vec, [INFO] [stdout] 583 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 1248 bytes [INFO] [stdout] 584 | | } [INFO] [stdout] | |___^ the entire enum is at least 1248 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 580 - parameters: user::UnresolvedParameters, [INFO] [stdout] 580 + parameters: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> server/src/types/resources/mod.rs:543:1 [INFO] [stdout] | [INFO] [stdout] 543 | / pub enum UnresolvedResource { [INFO] [stdout] 544 | | AptPackage { [INFO] [stdout] 545 | | parameters: apt::package::UnresolvedParameters, [INFO] [stdout] 546 | | requires: Vec, [INFO] [stdout] ... | [INFO] [stdout] 559 | | / File { [INFO] [stdout] 560 | | | parameters: file::UnresolvedParameters, [INFO] [stdout] 561 | | | requires: Vec, [INFO] [stdout] 562 | | | triggers: Vec, [INFO] [stdout] 563 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 888 bytes [INFO] [stdout] ... | [INFO] [stdout] 579 | | / User { [INFO] [stdout] 580 | | | parameters: user::UnresolvedParameters, [INFO] [stdout] 581 | | | requires: Vec, [INFO] [stdout] 582 | | | triggers: Vec, [INFO] [stdout] 583 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 1248 bytes [INFO] [stdout] 584 | | } [INFO] [stdout] | |___^ the entire enum is at least 1248 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 580 - parameters: user::UnresolvedParameters, [INFO] [stdout] 580 + parameters: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking rustls-platform-verifier v0.3.4 [INFO] [stderr] Checking ureq v3.0.8 [INFO] [stderr] Checking pullconf v0.5.0 (/opt/rustwide/workdir/client) [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> client/src/configuration.rs:294:13 [INFO] [stdout] | [INFO] [stdout] 294 | order = order + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `order += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> client/src/configuration.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | resources.sort_by(|a, b| a.order().cmp(&b.order())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 301 - resources.sort_by(|a, b| a.order().cmp(&b.order())); [INFO] [stdout] 301 + resources.sort_by_key(|a| a.order()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> client/src/configuration.rs:333:13 [INFO] [stdout] | [INFO] [stdout] 333 | / return Err(format!( [INFO] [stdout] 334 | | "failed to read etag file `{}`: {}", [INFO] [stdout] 335 | | ETAG_FILE, error [INFO] [stdout] 336 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 333 ~ Err(format!( [INFO] [stdout] 334 + "failed to read etag file `{}`: {}", [INFO] [stdout] 335 + ETAG_FILE, error [INFO] [stdout] 336 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> client/src/resources/apt/package.rs:174:25 [INFO] [stdout] | [INFO] [stdout] 174 | command.arg(&format!("{}={}", self.parameters.name.as_str(), version)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}={}", self.parameters.name.as_str(), version)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `to_owned` call clones the `Cow<'_, str>` itself and does not cause its contents to become owned [INFO] [stdout] --> client/src/resources/apt/package.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | let s = String::from_utf8_lossy(&output.stderr).to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_to_owned [INFO] [stdout] = note: `#[warn(clippy::suspicious_to_owned)]` on by default [INFO] [stdout] help: depending on intent, either make the `Cow` an `Owned` variant [INFO] [stdout] | [INFO] [stdout] 186 | let s = String::from_utf8_lossy(&output.stderr).into_owned(); [INFO] [stdout] | ++ [INFO] [stdout] help: or clone the `Cow` itself [INFO] [stdout] | [INFO] [stdout] 186 - let s = String::from_utf8_lossy(&output.stderr).to_owned(); [INFO] [stdout] 186 + let s = String::from_utf8_lossy(&output.stderr).clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `to_owned` call clones the `Cow<'_, str>` itself and does not cause its contents to become owned [INFO] [stdout] --> client/src/resources/apt/package.rs:218:21 [INFO] [stdout] | [INFO] [stdout] 218 | let s = String::from_utf8_lossy(&output.stderr).to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_to_owned [INFO] [stdout] help: depending on intent, either make the `Cow` an `Owned` variant [INFO] [stdout] | [INFO] [stdout] 218 | let s = String::from_utf8_lossy(&output.stderr).into_owned(); [INFO] [stdout] | ++ [INFO] [stdout] help: or clone the `Cow` itself [INFO] [stdout] | [INFO] [stdout] 218 - let s = String::from_utf8_lossy(&output.stderr).to_owned(); [INFO] [stdout] 218 + let s = String::from_utf8_lossy(&output.stderr).clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `to_owned` call clones the `Cow<'_, str>` itself and does not cause its contents to become owned [INFO] [stdout] --> client/src/resources/apt/package.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 240 | let s = String::from_utf8_lossy(&output.stdout).to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_to_owned [INFO] [stdout] help: depending on intent, either make the `Cow` an `Owned` variant [INFO] [stdout] | [INFO] [stdout] 240 | let s = String::from_utf8_lossy(&output.stdout).into_owned(); [INFO] [stdout] | ++ [INFO] [stdout] help: or clone the `Cow` itself [INFO] [stdout] | [INFO] [stdout] 240 - let s = String::from_utf8_lossy(&output.stdout).to_owned(); [INFO] [stdout] 240 + let s = String::from_utf8_lossy(&output.stdout).clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> client/src/configuration.rs:294:13 [INFO] [stdout] | [INFO] [stdout] 294 | order = order + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `order += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> client/src/resources/directory.rs:202:24 [INFO] [stdout] | [INFO] [stdout] 202 | } else if kind.is_symlink() { [INFO] [stdout] | ________________________^ [INFO] [stdout] 203 | | if !self [INFO] [stdout] 204 | | .relationships [INFO] [stdout] 205 | | .children [INFO] [stdout] ... | [INFO] [stdout] 212 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 202 ~ } else if kind.is_symlink() [INFO] [stdout] 203 ~ && !self [INFO] [stdout] 204 | .relationships [INFO] [stdout] ... [INFO] [stdout] 210 | action = Action::Changed; [INFO] [stdout] 211 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> client/src/configuration.rs:301:9 [INFO] [stdout] | [INFO] [stdout] 301 | resources.sort_by(|a, b| a.order().cmp(&b.order())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 301 - resources.sort_by(|a, b| a.order().cmp(&b.order())); [INFO] [stdout] 301 + resources.sort_by_key(|a| a.order()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> client/src/configuration.rs:333:13 [INFO] [stdout] | [INFO] [stdout] 333 | / return Err(format!( [INFO] [stdout] 334 | | "failed to read etag file `{}`: {}", [INFO] [stdout] 335 | | ETAG_FILE, error [INFO] [stdout] 336 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 333 ~ Err(format!( [INFO] [stdout] 334 + "failed to read etag file `{}`: {}", [INFO] [stdout] 335 + ETAG_FILE, error [INFO] [stdout] 336 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|v| v.as_str())` on an `Option` value [INFO] [stdout] --> client/src/resources/execute.rs:144:21 [INFO] [stdout] | [INFO] [stdout] 144 | env.value.as_ref().map(|v| v.as_str()).unwrap_or_default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `env.value.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method chain can be written more clearly with `if .. else ..` [INFO] [stdout] --> client/src/resources/execute.rs:165:17 [INFO] [stdout] | [INFO] [stdout] 165 | stdout.is_empty().then_some(stderr).unwrap_or(stdout) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if stdout.is_empty() { stderr } else { stdout }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else [INFO] [stdout] = note: `#[warn(clippy::obfuscated_if_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|v| v.as_str())` on an `Option` value [INFO] [stdout] --> client/src/resources/execute.rs:205:25 [INFO] [stdout] | [INFO] [stdout] 205 | env.value.as_ref().map(|v| v.as_str()).unwrap_or_default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `env.value.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method chain can be written more clearly with `if .. else ..` [INFO] [stdout] --> client/src/resources/execute.rs:230:25 [INFO] [stdout] | [INFO] [stdout] 230 | stdout.is_empty().then_some(stderr).unwrap_or(stdout) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if stdout.is_empty() { stderr } else { stdout }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method chain can be written more clearly with `if .. else ..` [INFO] [stdout] --> client/src/resources/execute.rs:239:25 [INFO] [stdout] | [INFO] [stdout] 239 | stdout.is_empty().then_some(stderr).unwrap_or(stdout) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if stdout.is_empty() { stderr } else { stdout }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> client/src/resources/apt/package.rs:174:25 [INFO] [stdout] | [INFO] [stdout] 174 | command.arg(&format!("{}={}", self.parameters.name.as_str(), version)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}={}", self.parameters.name.as_str(), version)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `to_owned` call clones the `Cow<'_, str>` itself and does not cause its contents to become owned [INFO] [stdout] --> client/src/resources/apt/package.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | let s = String::from_utf8_lossy(&output.stderr).to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_to_owned [INFO] [stdout] = note: `#[warn(clippy::suspicious_to_owned)]` on by default [INFO] [stdout] help: depending on intent, either make the `Cow` an `Owned` variant [INFO] [stdout] | [INFO] [stdout] 186 | let s = String::from_utf8_lossy(&output.stderr).into_owned(); [INFO] [stdout] | ++ [INFO] [stdout] help: or clone the `Cow` itself [INFO] [stdout] | [INFO] [stdout] 186 - let s = String::from_utf8_lossy(&output.stderr).to_owned(); [INFO] [stdout] 186 + let s = String::from_utf8_lossy(&output.stderr).clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `to_owned` call clones the `Cow<'_, str>` itself and does not cause its contents to become owned [INFO] [stdout] --> client/src/resources/apt/package.rs:218:21 [INFO] [stdout] | [INFO] [stdout] 218 | let s = String::from_utf8_lossy(&output.stderr).to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_to_owned [INFO] [stdout] help: depending on intent, either make the `Cow` an `Owned` variant [INFO] [stdout] | [INFO] [stdout] 218 | let s = String::from_utf8_lossy(&output.stderr).into_owned(); [INFO] [stdout] | ++ [INFO] [stdout] help: or clone the `Cow` itself [INFO] [stdout] | [INFO] [stdout] 218 - let s = String::from_utf8_lossy(&output.stderr).to_owned(); [INFO] [stdout] 218 + let s = String::from_utf8_lossy(&output.stderr).clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `to_owned` call clones the `Cow<'_, str>` itself and does not cause its contents to become owned [INFO] [stdout] --> client/src/resources/apt/package.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 240 | let s = String::from_utf8_lossy(&output.stdout).to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_to_owned [INFO] [stdout] help: depending on intent, either make the `Cow` an `Owned` variant [INFO] [stdout] | [INFO] [stdout] 240 | let s = String::from_utf8_lossy(&output.stdout).into_owned(); [INFO] [stdout] | ++ [INFO] [stdout] help: or clone the `Cow` itself [INFO] [stdout] | [INFO] [stdout] 240 - let s = String::from_utf8_lossy(&output.stdout).to_owned(); [INFO] [stdout] 240 + let s = String::from_utf8_lossy(&output.stdout).clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|v| v.as_str())` on an `Option` value [INFO] [stdout] --> client/src/resources/file.rs:523:21 [INFO] [stdout] | [INFO] [stdout] 523 | env.value.as_ref().map(|v| v.as_str()).unwrap_or_default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `env.value.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> client/src/resources/directory.rs:202:24 [INFO] [stdout] | [INFO] [stdout] 202 | } else if kind.is_symlink() { [INFO] [stdout] | ________________________^ [INFO] [stdout] 203 | | if !self [INFO] [stdout] 204 | | .relationships [INFO] [stdout] 205 | | .children [INFO] [stdout] ... | [INFO] [stdout] 212 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 202 ~ } else if kind.is_symlink() [INFO] [stdout] 203 ~ && !self [INFO] [stdout] 204 | .relationships [INFO] [stdout] ... [INFO] [stdout] 210 | action = Action::Changed; [INFO] [stdout] 211 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|v| v.as_str())` on an `Option` value [INFO] [stdout] --> client/src/resources/execute.rs:144:21 [INFO] [stdout] | [INFO] [stdout] 144 | env.value.as_ref().map(|v| v.as_str()).unwrap_or_default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `env.value.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method chain can be written more clearly with `if .. else ..` [INFO] [stdout] --> client/src/resources/execute.rs:165:17 [INFO] [stdout] | [INFO] [stdout] 165 | stdout.is_empty().then_some(stderr).unwrap_or(stdout) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if stdout.is_empty() { stderr } else { stdout }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else [INFO] [stdout] = note: `#[warn(clippy::obfuscated_if_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|v| v.as_str())` on an `Option` value [INFO] [stdout] --> client/src/resources/execute.rs:205:25 [INFO] [stdout] | [INFO] [stdout] 205 | env.value.as_ref().map(|v| v.as_str()).unwrap_or_default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `env.value.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method chain can be written more clearly with `if .. else ..` [INFO] [stdout] --> client/src/resources/execute.rs:230:25 [INFO] [stdout] | [INFO] [stdout] 230 | stdout.is_empty().then_some(stderr).unwrap_or(stdout) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if stdout.is_empty() { stderr } else { stdout }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method chain can be written more clearly with `if .. else ..` [INFO] [stdout] --> client/src/resources/execute.rs:239:25 [INFO] [stdout] | [INFO] [stdout] 239 | stdout.is_empty().then_some(stderr).unwrap_or(stdout) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if stdout.is_empty() { stderr } else { stdout }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> client/src/resources/host.rs:289:12 [INFO] [stdout] | [INFO] [stdout] 289 | if !content.as_bytes().last().is_some_and(|byte| *byte == 0xA) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `content.as_bytes().last().is_none_or(|byte| *byte != 0xA)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|v| v.as_str())` on an `Option` value [INFO] [stdout] --> client/src/resources/file.rs:523:21 [INFO] [stdout] | [INFO] [stdout] 523 | env.value.as_ref().map(|v| v.as_str()).unwrap_or_default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `env.value.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> client/src/resources/user.rs:310:17 [INFO] [stdout] | [INFO] [stdout] 310 | / if current_password != *password { [INFO] [stdout] 311 | | passwd.arg("--password"); [INFO] [stdout] 312 | | passwd.arg(password.as_str()); [INFO] [stdout] 313 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 309 ~ (Password::Unlocked(current_password), Password::Unlocked(password)) [INFO] [stdout] 310 ~ if current_password != *password => { [INFO] [stdout] 311 | passwd.arg("--password"); [INFO] [stdout] 312 | passwd.arg(password.as_str()); [INFO] [stdout] 313 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method chain can be written more clearly with `if .. else ..` [INFO] [stdout] --> client/src/main.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 47 | let exit = report [INFO] [stdout] | ________________________^ [INFO] [stdout] 48 | | .resources [INFO] [stdout] 49 | | .iter() [INFO] [stdout] 50 | | .any(|resource| resource.is_failed()) [INFO] [stdout] 51 | | .then_some(ExitCode::FAILURE) [INFO] [stdout] 52 | | .unwrap_or_default(); [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 ~ let exit = if report [INFO] [stdout] 48 + .resources [INFO] [stdout] 49 + .iter() [INFO] [stdout] 50 ~ .any(|resource| resource.is_failed()) { ExitCode::FAILURE } else { Default::default() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> client/src/resources/host.rs:289:12 [INFO] [stdout] | [INFO] [stdout] 289 | if !content.as_bytes().last().is_some_and(|byte| *byte == 0xA) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `content.as_bytes().last().is_none_or(|byte| *byte != 0xA)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> client/src/resources/user.rs:310:17 [INFO] [stdout] | [INFO] [stdout] 310 | / if current_password != *password { [INFO] [stdout] 311 | | passwd.arg("--password"); [INFO] [stdout] 312 | | passwd.arg(password.as_str()); [INFO] [stdout] 313 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 309 ~ (Password::Unlocked(current_password), Password::Unlocked(password)) [INFO] [stdout] 310 ~ if current_password != *password => { [INFO] [stdout] 311 | passwd.arg("--password"); [INFO] [stdout] 312 | passwd.arg(password.as_str()); [INFO] [stdout] 313 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method chain can be written more clearly with `if .. else ..` [INFO] [stdout] --> client/src/main.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 47 | let exit = report [INFO] [stdout] | ________________________^ [INFO] [stdout] 48 | | .resources [INFO] [stdout] 49 | | .iter() [INFO] [stdout] 50 | | .any(|resource| resource.is_failed()) [INFO] [stdout] 51 | | .then_some(ExitCode::FAILURE) [INFO] [stdout] 52 | | .unwrap_or_default(); [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 ~ let exit = if report [INFO] [stdout] 48 + .resources [INFO] [stdout] 49 + .iter() [INFO] [stdout] 50 ~ .any(|resource| resource.is_failed()) { ExitCode::FAILURE } else { Default::default() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 44.99s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: buf_redux v0.8.4, multipart v0.18.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "783c0fd34050f9b042567f98f3377c9d39f32bf426327aa95d336205df69e148", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "783c0fd34050f9b042567f98f3377c9d39f32bf426327aa95d336205df69e148", kill_on_drop: false }` [INFO] [stdout] 783c0fd34050f9b042567f98f3377c9d39f32bf426327aa95d336205df69e148