[INFO] cloning repository https://github.com/przemo1232/rust-shell [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/przemo1232/rust-shell" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fprzemo1232%2Frust-shell", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fprzemo1232%2Frust-shell'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ec9d87e1524eb5a5d989ee843e285123d103877a [INFO] linting przemo1232/rust-shell against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fprzemo1232%2Frust-shell" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/przemo1232/rust-shell [INFO] finished tweaking git repo https://github.com/przemo1232/rust-shell [INFO] tweaked toml for git repo https://github.com/przemo1232/rust-shell written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/przemo1232/rust-shell on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/przemo1232/rust-shell already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded syn v2.0.75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bbe83fd29dba35fb481a449a3b2d35e50b4dc0bfbd3878aa617743361461df6a [INFO] running `Command { std: "docker" "start" "-a" "bbe83fd29dba35fb481a449a3b2d35e50b4dc0bfbd3878aa617743361461df6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bbe83fd29dba35fb481a449a3b2d35e50b4dc0bfbd3878aa617743361461df6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bbe83fd29dba35fb481a449a3b2d35e50b4dc0bfbd3878aa617743361461df6a", kill_on_drop: false }` [INFO] [stdout] bbe83fd29dba35fb481a449a3b2d35e50b4dc0bfbd3878aa617743361461df6a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93830404dedf246178a38d1b84738b60e8b8f2eac4bea8664b250eed73fd9307 [INFO] running `Command { std: "docker" "start" "-a" "93830404dedf246178a38d1b84738b60e8b8f2eac4bea8664b250eed73fd9307", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.171 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling siphasher v1.0.1 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking smallvec v1.14.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking phf_shared v0.11.3 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling phf_macros v0.11.3 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking codecrafters-shell v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/main.rs:321:19 [INFO] [stdout] | [INFO] [stdout] 321 | while matches[0].len() >= input.len() + 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `matches[0].len() > input.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/main.rs:321:19 [INFO] [stdout] | [INFO] [stdout] 321 | while matches[0].len() >= input.len() + 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `matches[0].len() > input.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:95:31 [INFO] [stdout] | [INFO] [stdout] 95 | } else if (!single_quote [INFO] [stdout] | _______________________________^ [INFO] [stdout] 96 | | && double_quote [INFO] [stdout] 97 | | && input.len() > i [INFO] [stdout] 98 | | && ['\\', '$', '"'].contains(&input.chars().collect::>()[i + 1])) [INFO] [stdout] 99 | | || (!single_quote && !double_quote) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 95 - } else if (!single_quote [INFO] [stdout] 96 - && double_quote [INFO] [stdout] 97 - && input.len() > i [INFO] [stdout] 98 - && ['\\', '$', '"'].contains(&input.chars().collect::>()[i + 1])) [INFO] [stdout] 99 - || (!single_quote && !double_quote) [INFO] [stdout] 95 + } else if !(single_quote || double_quote && input.len() <= i || double_quote && !['\\', '$', '"'].contains(&input.chars().collect::>()[i + 1])) [INFO] [stdout] | [INFO] [stdout] 95 - } else if (!single_quote [INFO] [stdout] 96 - && double_quote [INFO] [stdout] 97 - && input.len() > i [INFO] [stdout] 98 - && ['\\', '$', '"'].contains(&input.chars().collect::>()[i + 1])) [INFO] [stdout] 99 - || (!single_quote && !double_quote) [INFO] [stdout] 95 + } else if !single_quote && !double_quote || !single_quote && input.len() > i && ['\\', '$', '"'].contains(&input.chars().collect::>()[i + 1]) [INFO] [stdout] | [INFO] [stdout] 95 - } else if (!single_quote [INFO] [stdout] 96 - && double_quote [INFO] [stdout] 97 - && input.len() > i [INFO] [stdout] 98 - && ['\\', '$', '"'].contains(&input.chars().collect::>()[i + 1])) [INFO] [stdout] 99 - || (!single_quote && !double_quote) [INFO] [stdout] 95 + } else if (['\\', '$', '"'].contains(&input.chars().collect::>()[i + 1]) || !double_quote) && (input.len() > i || !double_quote) && !single_quote [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:75:21 [INFO] [stdout] | [INFO] [stdout] 75 | / if !backslash && !double_quote { [INFO] [stdout] 76 | | single_quote = !single_quote; [INFO] [stdout] 77 | | } else { [INFO] [stdout] 78 | | this_word.push(this_char); [INFO] [stdout] 79 | | backslash = false; [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ '\'' [INFO] [stdout] 75 ~ if !backslash && !double_quote => { [INFO] [stdout] 76 | single_quote = !single_quote; [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:83:21 [INFO] [stdout] | [INFO] [stdout] 83 | / if !backslash && !single_quote { [INFO] [stdout] 84 | | double_quote = !double_quote; [INFO] [stdout] 85 | | } else { [INFO] [stdout] 86 | | this_word.push(this_char); [INFO] [stdout] 87 | | backslash = false; [INFO] [stdout] 88 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 82 ~ '"' [INFO] [stdout] 83 ~ if !backslash && !single_quote => { [INFO] [stdout] 84 | double_quote = !double_quote; [INFO] [stdout] 85 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 129 | / if !single_quote && !double_quote { [INFO] [stdout] 130 | | if this_word == "1" { [INFO] [stdout] 131 | | this_word.pop(); [INFO] [stdout] 132 | | redirect = true; [INFO] [stdout] ... | [INFO] [stdout] 151 | | backslash = false; [INFO] [stdout] 152 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 128 ~ '>' [INFO] [stdout] 129 ~ if !single_quote && !double_quote => { [INFO] [stdout] 130 | if this_word == "1" { [INFO] [stdout] ... [INFO] [stdout] 148 | } [INFO] [stdout] 149 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:95:31 [INFO] [stdout] | [INFO] [stdout] 95 | } else if (!single_quote [INFO] [stdout] | _______________________________^ [INFO] [stdout] 96 | | && double_quote [INFO] [stdout] 97 | | && input.len() > i [INFO] [stdout] 98 | | && ['\\', '$', '"'].contains(&input.chars().collect::>()[i + 1])) [INFO] [stdout] 99 | | || (!single_quote && !double_quote) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 95 - } else if (!single_quote [INFO] [stdout] 96 - && double_quote [INFO] [stdout] 97 - && input.len() > i [INFO] [stdout] 98 - && ['\\', '$', '"'].contains(&input.chars().collect::>()[i + 1])) [INFO] [stdout] 99 - || (!single_quote && !double_quote) [INFO] [stdout] 95 + } else if !(single_quote || double_quote && input.len() <= i || double_quote && !['\\', '$', '"'].contains(&input.chars().collect::>()[i + 1])) [INFO] [stdout] | [INFO] [stdout] 95 - } else if (!single_quote [INFO] [stdout] 96 - && double_quote [INFO] [stdout] 97 - && input.len() > i [INFO] [stdout] 98 - && ['\\', '$', '"'].contains(&input.chars().collect::>()[i + 1])) [INFO] [stdout] 99 - || (!single_quote && !double_quote) [INFO] [stdout] 95 + } else if !single_quote && !double_quote || !single_quote && input.len() > i && ['\\', '$', '"'].contains(&input.chars().collect::>()[i + 1]) [INFO] [stdout] | [INFO] [stdout] 95 - } else if (!single_quote [INFO] [stdout] 96 - && double_quote [INFO] [stdout] 97 - && input.len() > i [INFO] [stdout] 98 - && ['\\', '$', '"'].contains(&input.chars().collect::>()[i + 1])) [INFO] [stdout] 99 - || (!single_quote && !double_quote) [INFO] [stdout] 95 + } else if (['\\', '$', '"'].contains(&input.chars().collect::>()[i + 1]) || !double_quote) && (input.len() > i || !double_quote) && !single_quote [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/main.rs:187:41 [INFO] [stdout] | [INFO] [stdout] 187 | match OpenOptions::new().write(true).append(true).open(x.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `ends_with` method [INFO] [stdout] --> src/main.rs:193:16 [INFO] [stdout] | [INFO] [stdout] 193 | if byte_list.chars().last() != Some('\n') && !byte_list.is_empty() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!byte_list.ends_with('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_last_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:75:21 [INFO] [stdout] | [INFO] [stdout] 75 | / if !backslash && !double_quote { [INFO] [stdout] 76 | | single_quote = !single_quote; [INFO] [stdout] 77 | | } else { [INFO] [stdout] 78 | | this_word.push(this_char); [INFO] [stdout] 79 | | backslash = false; [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ '\'' [INFO] [stdout] 75 ~ if !backslash && !double_quote => { [INFO] [stdout] 76 | single_quote = !single_quote; [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:83:21 [INFO] [stdout] | [INFO] [stdout] 83 | / if !backslash && !single_quote { [INFO] [stdout] 84 | | double_quote = !double_quote; [INFO] [stdout] 85 | | } else { [INFO] [stdout] 86 | | this_word.push(this_char); [INFO] [stdout] 87 | | backslash = false; [INFO] [stdout] 88 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 82 ~ '"' [INFO] [stdout] 83 ~ if !backslash && !single_quote => { [INFO] [stdout] 84 | double_quote = !double_quote; [INFO] [stdout] 85 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 129 | / if !single_quote && !double_quote { [INFO] [stdout] 130 | | if this_word == "1" { [INFO] [stdout] 131 | | this_word.pop(); [INFO] [stdout] 132 | | redirect = true; [INFO] [stdout] ... | [INFO] [stdout] 151 | | backslash = false; [INFO] [stdout] 152 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 128 ~ '>' [INFO] [stdout] 129 ~ if !single_quote && !double_quote => { [INFO] [stdout] 130 | if this_word == "1" { [INFO] [stdout] ... [INFO] [stdout] 148 | } [INFO] [stdout] 149 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/main.rs:206:41 [INFO] [stdout] | [INFO] [stdout] 206 | match OpenOptions::new().write(true).append(true).open(x.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `ends_with` method [INFO] [stdout] --> src/main.rs:212:16 [INFO] [stdout] | [INFO] [stdout] 212 | if byte_list.chars().last() != Some('\n') && !byte_list.is_empty() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!byte_list.ends_with('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:269:53 [INFO] [stdout] | [INFO] [stdout] 269 | (input, pressed_tab) = autocomplete(&env_vars, input, pressed_tab); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `env_vars` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/main.rs:187:41 [INFO] [stdout] | [INFO] [stdout] 187 | match OpenOptions::new().write(true).append(true).open(x.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `ends_with` method [INFO] [stdout] --> src/main.rs:193:16 [INFO] [stdout] | [INFO] [stdout] 193 | if byte_list.chars().last() != Some('\n') && !byte_list.is_empty() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!byte_list.ends_with('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_last_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/main.rs:206:41 [INFO] [stdout] | [INFO] [stdout] 206 | match OpenOptions::new().write(true).append(true).open(x.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `ends_with` method [INFO] [stdout] --> src/main.rs:212:16 [INFO] [stdout] | [INFO] [stdout] 212 | if byte_list.chars().last() != Some('\n') && !byte_list.is_empty() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!byte_list.ends_with('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:317:12 [INFO] [stdout] | [INFO] [stdout] 317 | if pressed_tab == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `!pressed_tab` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/main.rs:323:20 [INFO] [stdout] | [INFO] [stdout] 323 | if matches [INFO] [stdout] | ____________________^ [INFO] [stdout] 324 | | .iter() [INFO] [stdout] 325 | | .filter(|x| x.starts_with(just_one_more_letter_bro)) [INFO] [stdout] 326 | | .map(|x| x.clone()) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 323 ~ if matches [INFO] [stdout] 324 + .iter() [INFO] [stdout] 325 + .filter(|x| x.starts_with(just_one_more_letter_bro)).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:269:53 [INFO] [stdout] | [INFO] [stdout] 269 | (input, pressed_tab) = autocomplete(&env_vars, input, pressed_tab); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `env_vars` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:317:12 [INFO] [stdout] | [INFO] [stdout] 317 | if pressed_tab == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `!pressed_tab` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/main.rs:323:20 [INFO] [stdout] | [INFO] [stdout] 323 | if matches [INFO] [stdout] | ____________________^ [INFO] [stdout] 324 | | .iter() [INFO] [stdout] 325 | | .filter(|x| x.starts_with(just_one_more_letter_bro)) [INFO] [stdout] 326 | | .map(|x| x.clone()) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 323 ~ if matches [INFO] [stdout] 324 + .iter() [INFO] [stdout] 325 + .filter(|x| x.starts_with(just_one_more_letter_bro)).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:457:5 [INFO] [stdout] | [INFO] [stdout] 457 | return (None, out, String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 457 - return (None, out, String::new()); [INFO] [stdout] 457 + (None, out, String::new()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:457:5 [INFO] [stdout] | [INFO] [stdout] 457 | return (None, out, String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 457 - return (None, out, String::new()); [INFO] [stdout] 457 + (None, out, String::new()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.92s [INFO] running `Command { std: "docker" "inspect" "93830404dedf246178a38d1b84738b60e8b8f2eac4bea8664b250eed73fd9307", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93830404dedf246178a38d1b84738b60e8b8f2eac4bea8664b250eed73fd9307", kill_on_drop: false }` [INFO] [stdout] 93830404dedf246178a38d1b84738b60e8b8f2eac4bea8664b250eed73fd9307