[INFO] cloning repository https://github.com/protoshark/chip8 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/protoshark/chip8" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fprotoshark%2Fchip8", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fprotoshark%2Fchip8'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b26c0f12fd04d3ee5a02af844db64ee1d8453220 [INFO] linting protoshark/chip8 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fprotoshark%2Fchip8" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/protoshark/chip8 [INFO] finished tweaking git repo https://github.com/protoshark/chip8 [INFO] tweaked toml for git repo https://github.com/protoshark/chip8 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/protoshark/chip8 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/protoshark/chip8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sdl2 v0.34.3 [INFO] [stderr] Downloaded sdl2-sys v0.34.3 [INFO] [stderr] Downloaded libc v0.2.82 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 45fa9487760cdc345a56704f4e6fb33b08807f1fa0718c2556c70e11699d06bb [INFO] running `Command { std: "docker" "start" "-a" "45fa9487760cdc345a56704f4e6fb33b08807f1fa0718c2556c70e11699d06bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "45fa9487760cdc345a56704f4e6fb33b08807f1fa0718c2556c70e11699d06bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45fa9487760cdc345a56704f4e6fb33b08807f1fa0718c2556c70e11699d06bb", kill_on_drop: false }` [INFO] [stdout] 45fa9487760cdc345a56704f4e6fb33b08807f1fa0718c2556c70e11699d06bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fbac55f3425b40009b2c9e59c543e329ba49a51a6beea83f8c699baf1450050e [INFO] running `Command { std: "docker" "start" "-a" "fbac55f3425b40009b2c9e59c543e329ba49a51a6beea83f8c699baf1450050e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Checking getrandom v0.2.2 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking chip8 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: name `CLS` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | CLS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cls` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RET` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | RET, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ret` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SYS` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | SYS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Sys` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CALL` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | CALL, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Call` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADD` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | ADD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Add` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XOR` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | XOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUB` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | SUB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SHR` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | SHR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Shr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUBN` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | SUBN, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Subn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SHL` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | SHL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Shl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SNE` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | SNE, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sne` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RND` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | RND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rnd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DRW` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | DRW, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Drw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SKP` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | SKP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Skp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SKNP` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | SKNP, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Sknp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cpu/instruction.rs:215:21 [INFO] [stdout] | [INFO] [stdout] 215 | / if (sprite_data & (0x80 >> bit)) > 0 { [INFO] [stdout] 216 | | if self [INFO] [stdout] 217 | | .bus [INFO] [stdout] 218 | | .borrow_mut() [INFO] [stdout] ... | [INFO] [stdout] 223 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 215 ~ if (sprite_data & (0x80 >> bit)) > 0 [INFO] [stdout] 216 ~ && self [INFO] [stdout] 217 | .bus [INFO] [stdout] ... [INFO] [stdout] 221 | self.v[0xF] = 1; [INFO] [stdout] 222 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu/instruction.rs:261:13 [INFO] [stdout] | [INFO] [stdout] 261 | self.v[x] = self.v[x] | self.v[y]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[x] |= self.v[y]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu/instruction.rs:269:13 [INFO] [stdout] | [INFO] [stdout] 269 | self.v[x] = self.v[x] & self.v[y]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[x] &= self.v[y]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu/instruction.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | self.v[x] = self.v[x] ^ self.v[y]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[x] ^= self.v[y]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu/instruction.rs:356:16 [INFO] [stdout] | [INFO] [stdout] 356 | if !((self.keypad & 1 << u16::from(self.v[x])) == 1 << u16::from(self.v[x])) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((self.keypad & 1 << u16::from(self.v[x])) != 1 << u16::from(self.v[x]))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLS` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | CLS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cls` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RET` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | RET, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ret` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SYS` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | SYS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Sys` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CALL` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | CALL, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Call` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADD` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | ADD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Add` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XOR` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | XOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUB` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | SUB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SHR` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | SHR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Shr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUBN` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | SUBN, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Subn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SHL` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | SHL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Shl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SNE` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | SNE, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sne` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RND` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | RND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rnd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DRW` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | DRW, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Drw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SKP` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | SKP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Skp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SKNP` contains a capitalized acronym [INFO] [stdout] --> src/cpu/instruction.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | SKNP, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Sknp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cpu/instruction.rs:215:21 [INFO] [stdout] | [INFO] [stdout] 215 | / if (sprite_data & (0x80 >> bit)) > 0 { [INFO] [stdout] 216 | | if self [INFO] [stdout] 217 | | .bus [INFO] [stdout] 218 | | .borrow_mut() [INFO] [stdout] ... | [INFO] [stdout] 223 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 215 ~ if (sprite_data & (0x80 >> bit)) > 0 [INFO] [stdout] 216 ~ && self [INFO] [stdout] 217 | .bus [INFO] [stdout] ... [INFO] [stdout] 221 | self.v[0xF] = 1; [INFO] [stdout] 222 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu/instruction.rs:261:13 [INFO] [stdout] | [INFO] [stdout] 261 | self.v[x] = self.v[x] | self.v[y]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[x] |= self.v[y]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu/instruction.rs:269:13 [INFO] [stdout] | [INFO] [stdout] 269 | self.v[x] = self.v[x] & self.v[y]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[x] &= self.v[y]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu/instruction.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | self.v[x] = self.v[x] ^ self.v[y]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.v[x] ^= self.v[y]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu/instruction.rs:356:16 [INFO] [stdout] | [INFO] [stdout] 356 | if !((self.keypad & 1 << u16::from(self.v[x])) == 1 << u16::from(self.v[x])) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((self.keypad & 1 << u16::from(self.v[x])) != 1 << u16::from(self.v[x]))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.56s [INFO] running `Command { std: "docker" "inspect" "fbac55f3425b40009b2c9e59c543e329ba49a51a6beea83f8c699baf1450050e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fbac55f3425b40009b2c9e59c543e329ba49a51a6beea83f8c699baf1450050e", kill_on_drop: false }` [INFO] [stdout] fbac55f3425b40009b2c9e59c543e329ba49a51a6beea83f8c699baf1450050e