[INFO] cloning repository https://github.com/programmingAthlete/alegebraic_immunity_utils [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/programmingAthlete/alegebraic_immunity_utils" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FprogrammingAthlete%2Falegebraic_immunity_utils", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FprogrammingAthlete%2Falegebraic_immunity_utils'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6754fb299e3de92e5bf7569f11232340ad09d7db [INFO] linting programmingAthlete/alegebraic_immunity_utils against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FprogrammingAthlete%2Falegebraic_immunity_utils" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/programmingAthlete/alegebraic_immunity_utils [INFO] finished tweaking git repo https://github.com/programmingAthlete/alegebraic_immunity_utils [INFO] tweaked toml for git repo https://github.com/programmingAthlete/alegebraic_immunity_utils written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/programmingAthlete/alegebraic_immunity_utils on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.10.5 (available: v0.14.0) [INFO] [stderr] Adding ndarray v0.15.6 (available: v0.17.2) [INFO] [stderr] Adding pyo3 v0.23.5 (available: v0.28.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pyo3-build-config v0.23.5 [INFO] [stderr] Downloaded pyo3-macros v0.23.5 [INFO] [stderr] Downloaded pyo3-ffi v0.23.5 [INFO] [stderr] Downloaded pyo3-macros-backend v0.23.5 [INFO] [stderr] Downloaded pyo3 v0.23.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 331310ae2c2a2489d358ea0c27ae197bfb9757f86625f70afdf28b11b31c33d3 [INFO] running `Command { std: "docker" "start" "-a" "331310ae2c2a2489d358ea0c27ae197bfb9757f86625f70afdf28b11b31c33d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "331310ae2c2a2489d358ea0c27ae197bfb9757f86625f70afdf28b11b31c33d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "331310ae2c2a2489d358ea0c27ae197bfb9757f86625f70afdf28b11b31c33d3", kill_on_drop: false }` [INFO] [stdout] 331310ae2c2a2489d358ea0c27ae197bfb9757f86625f70afdf28b11b31c33d3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 55520c5e8c11526936990ba071dbd391b4c1b3807cd50a167b5b1e4e30703c48 [INFO] running `Command { std: "docker" "start" "-a" "55520c5e8c11526936990ba071dbd391b4c1b3807cd50a167b5b1e4e30703c48", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Checking unindent v0.2.4 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Compiling pyo3-build-config v0.23.5 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling pyo3-ffi v0.23.5 [INFO] [stderr] Compiling pyo3-macros-backend v0.23.5 [INFO] [stderr] Compiling pyo3 v0.23.5 [INFO] [stderr] Compiling pyo3-macros v0.23.5 [INFO] [stderr] Checking algebraic_immunity_utils v1.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::cmp::Ordering` [INFO] [stdout] --> src/restricted_ai.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::cmp::Ordering; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::Ordering` [INFO] [stdout] --> src/restricted_ai.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::cmp::Ordering; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/matrix.rs:106:21 [INFO] [stdout] | [INFO] [stdout] 106 | let mut distance_base = m_copy.nrows(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `k` [INFO] [stdout] --> src/matrix.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | for k in 0..m_copy.ncols() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_k` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `distance_base` [INFO] [stdout] --> src/matrix.rs:106:21 [INFO] [stdout] | [INFO] [stdout] 106 | let mut distance_base = m_copy.nrows(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_distance_base` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/matrix.rs:106:21 [INFO] [stdout] | [INFO] [stdout] 106 | let mut distance_base = m_copy.nrows(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `k` [INFO] [stdout] --> src/matrix.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | for k in 0..m_copy.ncols() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_k` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `distance_base` [INFO] [stdout] --> src/matrix.rs:106:21 [INFO] [stdout] | [INFO] [stdout] 106 | let mut distance_base = m_copy.nrows(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_distance_base` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `add_to_vectors` is never used [INFO] [stdout] --> src/matrix.rs:386:4 [INFO] [stdout] | [INFO] [stdout] 386 | fn add_to_vectors(mut v1: Vec, v2: Vec, size: usize) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `add_to_vectors` is never used [INFO] [stdout] --> src/matrix.rs:386:4 [INFO] [stdout] | [INFO] [stdout] 386 | fn add_to_vectors(mut v1: Vec, v2: Vec, size: usize) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/matrix.rs:86:29 [INFO] [stdout] | [INFO] [stdout] 86 | || (!prev_pivot.is_none() && curr_pivot < prev_pivot.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `prev_pivot.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/matrix.rs:92:31 [INFO] [stdout] | [INFO] [stdout] 92 | } else if !prev_pivot.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `prev_pivot.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/matrix.rs:134:24 [INFO] [stdout] | [INFO] [stdout] 134 | if !closest.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `closest.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/matrix.rs:156:24 [INFO] [stdout] | [INFO] [stdout] 156 | if !new_pivot.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `new_pivot.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `prev_pivot` after checking its variant with `is_none` [INFO] [stdout] --> src/matrix.rs:93:29 [INFO] [stdout] | [INFO] [stdout] 85 | if prev_pivot.is_none() [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 93 | && (prev_pivot.unwrap() == curr_pivot) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `p_index` after checking its variant with `is_none` [INFO] [stdout] --> src/matrix.rs:102:31 [INFO] [stdout] | [INFO] [stdout] 78 | if p_index.is_none() { [INFO] [stdout] | -------------------- help: try: `if let Some() = p_index` [INFO] [stdout] ... [INFO] [stdout] 102 | let p_index = p_index.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `piv` after checking its variant with `is_none` [INFO] [stdout] --> src/matrix.rs:117:37 [INFO] [stdout] | [INFO] [stdout] 110 | if piv.is_none() { [INFO] [stdout] | ---------------- help: try: `if let Some() = piv` [INFO] [stdout] ... [INFO] [stdout] 117 | let piv_u = piv.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `closest` after checking its variant with `is_none` [INFO] [stdout] --> src/matrix.rs:135:41 [INFO] [stdout] | [INFO] [stdout] 134 | if !closest.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 135 | let closest_u = closest.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `p_row` after checking its variant with `is_none` [INFO] [stdout] --> src/matrix.rs:151:27 [INFO] [stdout] | [INFO] [stdout] 133 | if p_row.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = p_row` [INFO] [stdout] ... [INFO] [stdout] 151 | } else if p_row.unwrap()[p_index] == 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `new_pivot` after checking its variant with `is_none` [INFO] [stdout] --> src/matrix.rs:157:43 [INFO] [stdout] | [INFO] [stdout] 156 | if !new_pivot.is_none() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] 157 | let new_pivot_u = new_pivot.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/matrix.rs:86:29 [INFO] [stdout] | [INFO] [stdout] 86 | || (!prev_pivot.is_none() && curr_pivot < prev_pivot.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `prev_pivot.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/matrix.rs:92:31 [INFO] [stdout] | [INFO] [stdout] 92 | } else if !prev_pivot.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `prev_pivot.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `v` [INFO] [stdout] --> src/matrix.rs:261:18 [INFO] [stdout] | [INFO] [stdout] 261 | for i in 0..self.nrows() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 261 - for i in 0..self.nrows() { [INFO] [stdout] 261 + for (i, ) in v.iter().enumerate().take(self.nrows()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/matrix.rs:134:24 [INFO] [stdout] | [INFO] [stdout] 134 | if !closest.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `closest.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/matrix.rs:156:24 [INFO] [stdout] | [INFO] [stdout] 156 | if !new_pivot.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `new_pivot.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `prev_pivot` after checking its variant with `is_none` [INFO] [stdout] --> src/matrix.rs:93:29 [INFO] [stdout] | [INFO] [stdout] 85 | if prev_pivot.is_none() [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 93 | && (prev_pivot.unwrap() == curr_pivot) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `p_index` after checking its variant with `is_none` [INFO] [stdout] --> src/matrix.rs:102:31 [INFO] [stdout] | [INFO] [stdout] 78 | if p_index.is_none() { [INFO] [stdout] | -------------------- help: try: `if let Some() = p_index` [INFO] [stdout] ... [INFO] [stdout] 102 | let p_index = p_index.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `piv` after checking its variant with `is_none` [INFO] [stdout] --> src/matrix.rs:117:37 [INFO] [stdout] | [INFO] [stdout] 110 | if piv.is_none() { [INFO] [stdout] | ---------------- help: try: `if let Some() = piv` [INFO] [stdout] ... [INFO] [stdout] 117 | let piv_u = piv.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `closest` after checking its variant with `is_none` [INFO] [stdout] --> src/matrix.rs:135:41 [INFO] [stdout] | [INFO] [stdout] 134 | if !closest.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 135 | let closest_u = closest.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `p_row` after checking its variant with `is_none` [INFO] [stdout] --> src/matrix.rs:151:27 [INFO] [stdout] | [INFO] [stdout] 133 | if p_row.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = p_row` [INFO] [stdout] ... [INFO] [stdout] 151 | } else if p_row.unwrap()[p_index] == 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `new_pivot` after checking its variant with `is_none` [INFO] [stdout] --> src/matrix.rs:157:43 [INFO] [stdout] | [INFO] [stdout] 156 | if !new_pivot.is_none() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] 157 | let new_pivot_u = new_pivot.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/matrix.rs:308:25 [INFO] [stdout] | [INFO] [stdout] 308 | sum = sum ^ (self.elements[p_row][col] * kernel_vector[col]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum ^= (self.elements[p_row][col] * kernel_vector[col])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/matrix.rs:325:39 [INFO] [stdout] | [INFO] [stdout] 325 | .map(|ej| str_ops(&zi, &ej)) [INFO] [stdout] | ^^^ help: change this to: `zi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/matrix.rs:325:44 [INFO] [stdout] | [INFO] [stdout] 325 | .map(|ej| str_ops(&zi, &ej)) [INFO] [stdout] | ^^^ help: change this to: `ej` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/matrix.rs:341:22 [INFO] [stdout] | [INFO] [stdout] 341 | .map(|i| str_ops(&support_slice[support_slice.len() - 1], &monom_slice[i]) as u8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `str_ops(&support_slice[support_slice.len() - 1], &monom_slice[i])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/matrix.rs:344:22 [INFO] [stdout] | [INFO] [stdout] 344 | .map(|i| str_ops(&support_slice[i], &monom_slice[monom_slice.len() - 1]) as u8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `str_ops(&support_slice[i], &monom_slice[monom_slice.len() - 1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/matrix.rs:357:22 [INFO] [stdout] | [INFO] [stdout] 357 | .map(|i| str_ops(&support[i], &monom) as u8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `str_ops(&support[i], &monom)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `support_slice` [INFO] [stdout] --> src/matrix.rs:367:18 [INFO] [stdout] | [INFO] [stdout] 367 | for j in 0..support_slice.len(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 367 - for j in 0..support_slice.len(){ [INFO] [stdout] 367 + for in &support_slice{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/matrix.rs:369:26 [INFO] [stdout] | [INFO] [stdout] 369 | .map(|i| str_ops(&support_slice[j], &monom_slice[i]) as u8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `str_ops(&support_slice[j], &monom_slice[i])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `v` [INFO] [stdout] --> src/matrix.rs:261:18 [INFO] [stdout] | [INFO] [stdout] 261 | for i in 0..self.nrows() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 261 - for i in 0..self.nrows() { [INFO] [stdout] 261 + for (i, ) in v.iter().enumerate().take(self.nrows()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/matrix.rs:308:25 [INFO] [stdout] | [INFO] [stdout] 308 | sum = sum ^ (self.elements[p_row][col] * kernel_vector[col]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum ^= (self.elements[p_row][col] * kernel_vector[col])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/matrix.rs:325:39 [INFO] [stdout] | [INFO] [stdout] 325 | .map(|ej| str_ops(&zi, &ej)) [INFO] [stdout] | ^^^ help: change this to: `zi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/matrix.rs:325:44 [INFO] [stdout] | [INFO] [stdout] 325 | .map(|ej| str_ops(&zi, &ej)) [INFO] [stdout] | ^^^ help: change this to: `ej` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/matrix.rs:341:22 [INFO] [stdout] | [INFO] [stdout] 341 | .map(|i| str_ops(&support_slice[support_slice.len() - 1], &monom_slice[i]) as u8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `str_ops(&support_slice[support_slice.len() - 1], &monom_slice[i])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/matrix.rs:344:22 [INFO] [stdout] | [INFO] [stdout] 344 | .map(|i| str_ops(&support_slice[i], &monom_slice[monom_slice.len() - 1]) as u8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `str_ops(&support_slice[i], &monom_slice[monom_slice.len() - 1])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/matrix.rs:357:22 [INFO] [stdout] | [INFO] [stdout] 357 | .map(|i| str_ops(&support[i], &monom) as u8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `str_ops(&support[i], &monom)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `support_slice` [INFO] [stdout] --> src/matrix.rs:367:18 [INFO] [stdout] | [INFO] [stdout] 367 | for j in 0..support_slice.len(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 367 - for j in 0..support_slice.len(){ [INFO] [stdout] 367 + for in &support_slice{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/matrix.rs:369:26 [INFO] [stdout] | [INFO] [stdout] 369 | .map(|i| str_ops(&support_slice[j], &monom_slice[i]) as u8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `str_ops(&support_slice[j], &monom_slice[i])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/matrix.rs:380:23 [INFO] [stdout] | [INFO] [stdout] 380 | fn get_pivot(row: &Vec) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 380 - fn get_pivot(row: &Vec) -> Option { [INFO] [stdout] 380 + fn get_pivot(row: &[u8]) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/matrix.rs:404:33 [INFO] [stdout] | [INFO] [stdout] 404 | fn apply_operations(operations: &Vec<(usize, usize)>, v: Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 404 - fn apply_operations(operations: &Vec<(usize, usize)>, v: Vec) -> Vec { [INFO] [stdout] 404 + fn apply_operations(operations: &[(usize, usize)], v: Vec) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/matrix.rs:380:23 [INFO] [stdout] | [INFO] [stdout] 380 | fn get_pivot(row: &Vec) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 380 - fn get_pivot(row: &Vec) -> Option { [INFO] [stdout] 380 + fn get_pivot(row: &[u8]) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/matrix.rs:404:33 [INFO] [stdout] | [INFO] [stdout] 404 | fn apply_operations(operations: &Vec<(usize, usize)>, v: Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 404 - fn apply_operations(operations: &Vec<(usize, usize)>, v: Vec) -> Vec { [INFO] [stdout] 404 + fn apply_operations(operations: &[(usize, usize)], v: Vec) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/restricted_ai.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / match results.into_iter().flatten().min() { [INFO] [stdout] 70 | | Some(min_val) => min_val, [INFO] [stdout] 71 | | None => 0, [INFO] [stdout] 72 | | } [INFO] [stdout] | |_________^ help: replace it with: `results.into_iter().flatten().min().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/restricted_ai.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / match results.into_iter().flatten().min() { [INFO] [stdout] 70 | | Some(min_val) => min_val, [INFO] [stdout] 71 | | None => 0, [INFO] [stdout] 72 | | } [INFO] [stdout] | |_________^ help: replace it with: `results.into_iter().flatten().min().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/restricted_ai.rs:163:22 [INFO] [stdout] | [INFO] [stdout] 163 | while r_s <= (s_len + 1) / 2 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `s_len.div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/restricted_ai.rs:163:22 [INFO] [stdout] | [INFO] [stdout] 163 | while r_s <= (s_len + 1) / 2 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `s_len.div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 26.50s [INFO] running `Command { std: "docker" "inspect" "55520c5e8c11526936990ba071dbd391b4c1b3807cd50a167b5b1e4e30703c48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55520c5e8c11526936990ba071dbd391b4c1b3807cd50a167b5b1e4e30703c48", kill_on_drop: false }` [INFO] [stdout] 55520c5e8c11526936990ba071dbd391b4c1b3807cd50a167b5b1e4e30703c48