[INFO] cloning repository https://github.com/pramadha-nindi-atmaja/Endo-SaaS-Project [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pramadha-nindi-atmaja/Endo-SaaS-Project" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpramadha-nindi-atmaja%2FEndo-SaaS-Project", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpramadha-nindi-atmaja%2FEndo-SaaS-Project'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fd7f7bbf28190e065db11a4a39a75e8390941b48 [INFO] linting pramadha-nindi-atmaja/Endo-SaaS-Project against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpramadha-nindi-atmaja%2FEndo-SaaS-Project" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] [stderr] Updating files: 25% (10244/40250) Updating files: 26% (10465/40250) Updating files: 27% (10868/40250) Updating files: 28% (11270/40250) Updating files: 29% (11673/40250) Updating files: 30% (12075/40250) Updating files: 31% (12478/40250) Updating files: 32% (12880/40250) Updating files: 33% (13283/40250) Updating files: 34% (13685/40250) Updating files: 35% (14088/40250) Updating files: 36% (14490/40250) Updating files: 37% (14893/40250) Updating files: 38% (15295/40250) Updating files: 39% (15698/40250) Updating files: 40% (16100/40250) Updating files: 41% (16503/40250) Updating files: 42% (16905/40250) Updating files: 43% (17308/40250) Updating files: 44% (17710/40250) Updating files: 45% (18113/40250) Updating files: 46% (18515/40250) Updating files: 47% (18918/40250) Updating files: 48% (19320/40250) Updating files: 49% (19723/40250) Updating files: 50% (20125/40250) Updating files: 51% (20528/40250) Updating files: 52% (20930/40250) Updating files: 53% (21333/40250) Updating files: 54% (21735/40250) Updating files: 55% (22138/40250) Updating files: 56% (22540/40250) Updating files: 57% (22943/40250) Updating files: 57% (23154/40250) Updating files: 58% (23345/40250) Updating files: 59% (23748/40250) Updating files: 60% (24150/40250) Updating files: 61% (24553/40250) Updating files: 62% (24955/40250) Updating files: 63% (25358/40250) Updating files: 64% (25760/40250) Updating files: 65% (26163/40250) Updating files: 66% (26565/40250) Updating files: 67% (26968/40250) Updating files: 68% (27370/40250) Updating files: 69% (27773/40250) Updating files: 70% (28175/40250) Updating files: 71% (28578/40250) Updating files: 72% (28980/40250) Updating files: 73% (29383/40250) Updating files: 74% (29785/40250) Updating files: 75% (30188/40250) Updating files: 76% (30590/40250) Updating files: 77% (30993/40250) Updating files: 78% (31395/40250) Updating files: 79% (31798/40250) Updating files: 80% (32200/40250) Updating files: 81% (32603/40250) Updating files: 82% (33005/40250) Updating files: 83% (33408/40250) Updating files: 84% (33810/40250) Updating files: 85% (34213/40250) Updating files: 86% (34615/40250) Updating files: 87% (35018/40250) Updating files: 88% (35420/40250) Updating files: 89% (35823/40250) Updating files: 90% (36225/40250) Updating files: 91% (36628/40250) Updating files: 92% (37030/40250) Updating files: 92% (37414/40250) Updating files: 93% (37433/40250) Updating files: 94% (37835/40250) Updating files: 95% (38238/40250) Updating files: 96% (38640/40250) Updating files: 97% (39043/40250) Updating files: 98% (39445/40250) Updating files: 99% (39848/40250) Updating files: 100% (40250/40250) Updating files: 100% (40250/40250), done. [INFO] started tweaking git repo https://github.com/pramadha-nindi-atmaja/Endo-SaaS-Project [INFO] finished tweaking git repo https://github.com/pramadha-nindi-atmaja/Endo-SaaS-Project [INFO] tweaked toml for git repo https://github.com/pramadha-nindi-atmaja/Endo-SaaS-Project written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/pramadha-nindi-atmaja/Endo-SaaS-Project on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/pramadha-nindi-atmaja/Endo-SaaS-Project already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded noise-protocol v0.2.0 [INFO] [stderr] Downloaded noise-rust-crypto v0.6.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1311865d8e4d7b4b016548933d9047621b362c3bbf60fc8aee38e790e5f70f62 [INFO] running `Command { std: "docker" "start" "-a" "1311865d8e4d7b4b016548933d9047621b362c3bbf60fc8aee38e790e5f70f62", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1311865d8e4d7b4b016548933d9047621b362c3bbf60fc8aee38e790e5f70f62", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1311865d8e4d7b4b016548933d9047621b362c3bbf60fc8aee38e790e5f70f62", kill_on_drop: false }` [INFO] [stdout] 1311865d8e4d7b4b016548933d9047621b362c3bbf60fc8aee38e790e5f70f62 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0839fd19f9a4090c0b17efeadc52ffbf0af6dd1cc669e463d3ce9096d576008 [INFO] running `Command { std: "docker" "start" "-a" "b0839fd19f9a4090c0b17efeadc52ffbf0af6dd1cc669e463d3ce9096d576008", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.19 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking noise-protocol v0.2.0 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking noise-rust-crypto v0.6.2 [INFO] [stderr] Checking ocapn_noise_protocol_facilities v0.1.0 (/opt/rustwide/workdir/rust/ocapn_noise) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:104:30 [INFO] [stdout] | [INFO] [stdout] 104 | .copy_from_slice(&signing_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signing_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:106:30 [INFO] [stdout] | [INFO] [stdout] 106 | .copy_from_slice(&verifying_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `verifying_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:121:30 [INFO] [stdout] | [INFO] [stdout] 121 | .copy_from_slice(&signing_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signing_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:123:30 [INFO] [stdout] | [INFO] [stdout] 123 | .copy_from_slice(&verifying_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `verifying_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return 0; [INFO] [stdout] 171 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | / match hs.write_message( [INFO] [stdout] 161 | | &BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 162 | | &mut BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 163 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 167 | | Ok(()) => (), [INFO] [stdout] 168 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 160 ~ if let Err(_) = hs.write_message( [INFO] [stdout] 161 + &BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 162 + &mut BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 163 + ) { [INFO] [stdout] 164 + return 1; [INFO] [stdout] 165 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - return 0; [INFO] [stdout] 220 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | / match hs.read_message( [INFO] [stdout] 210 | | &BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 211 | | &mut BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 212 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 216 | | Ok(_) => (), [INFO] [stdout] 217 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 209 ~ if let Err(_) = hs.read_message( [INFO] [stdout] 210 + &BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 211 + &mut BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 212 + ) { [INFO] [stdout] 213 + return 2; [INFO] [stdout] 214 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 244 - return 0; [INFO] [stdout] 244 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | / match hs.write_message( [INFO] [stdout] 234 | | &BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 235 | | &mut BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 236 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 240 | | Ok(_) => (), [INFO] [stdout] 241 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 233 ~ if let Err(_) = hs.write_message( [INFO] [stdout] 234 + &BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 235 + &mut BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 236 + ) { [INFO] [stdout] 237 + return 2; [INFO] [stdout] 238 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:290:12 [INFO] [stdout] | [INFO] [stdout] 290 | if !responder_verifying_key [INFO] [stdout] | ____________^ [INFO] [stdout] 291 | | .verify(&responder_public_crypt_key.as_slice(), &responder_signature) [INFO] [stdout] 292 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 290 ~ if responder_verifying_key [INFO] [stdout] 291 + .verify(&responder_public_crypt_key.as_slice(), &responder_signature).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:298:9 [INFO] [stdout] | [INFO] [stdout] 298 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return 0; [INFO] [stdout] 298 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 257 | / match hs.read_message( [INFO] [stdout] 258 | | &BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 259 | | &mut BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 260 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 264 | | Ok(_) => (), [INFO] [stdout] 265 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 257 ~ if let Err(_) = hs.read_message( [INFO] [stdout] 258 + &BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 259 + &mut BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 260 + ) { [INFO] [stdout] 261 + return 2; [INFO] [stdout] 262 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:291:21 [INFO] [stdout] | [INFO] [stdout] 291 | .verify(&responder_public_crypt_key.as_slice(), &responder_signature) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `responder_public_crypt_key.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 324 - return 0; [INFO] [stdout] 324 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:312:9 [INFO] [stdout] | [INFO] [stdout] 312 | / match hs.write_message(&[], &mut BUFFER[ACK_OFFSET..][..ACK_LENGTH]) { [INFO] [stdout] 313 | | Err(_) => { [INFO] [stdout] 314 | | return 1; [INFO] [stdout] ... | [INFO] [stdout] 317 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 312 ~ if let Err(_) = hs.write_message(&[], &mut BUFFER[ACK_OFFSET..][..ACK_LENGTH]) { [INFO] [stdout] 313 + return 1; [INFO] [stdout] 314 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:367:12 [INFO] [stdout] | [INFO] [stdout] 367 | if !initiator_verifying_key [INFO] [stdout] | ____________^ [INFO] [stdout] 368 | | .verify(&initiator_public_crypt_key.as_slice(), &initiator_signature) [INFO] [stdout] 369 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 367 ~ if initiator_verifying_key [INFO] [stdout] 368 + .verify(&initiator_public_crypt_key.as_slice(), &initiator_signature).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:379:9 [INFO] [stdout] | [INFO] [stdout] 379 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 379 - return 0; [INFO] [stdout] 379 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:336:9 [INFO] [stdout] | [INFO] [stdout] 336 | / match hs.read_message(&BUFFER[ACK_OFFSET..][..ACK_LENGTH], &mut []) { [INFO] [stdout] 337 | | Err(_) => { [INFO] [stdout] 338 | | return 2; [INFO] [stdout] ... | [INFO] [stdout] 341 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 336 ~ if let Err(_) = hs.read_message(&BUFFER[ACK_OFFSET..][..ACK_LENGTH], &mut []) { [INFO] [stdout] 337 + return 2; [INFO] [stdout] 338 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:368:21 [INFO] [stdout] | [INFO] [stdout] 368 | .verify(&initiator_public_crypt_key.as_slice(), &initiator_signature) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `initiator_public_crypt_key.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:398:9 [INFO] [stdout] | [INFO] [stdout] 398 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 398 - return 0; [INFO] [stdout] 398 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:422:9 [INFO] [stdout] | [INFO] [stdout] 422 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 422 - return 0; [INFO] [stdout] 422 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:415:9 [INFO] [stdout] | [INFO] [stdout] 415 | / match decrypter.decrypt_in_place(&mut BUFFER, length) { [INFO] [stdout] 416 | | Err(_) => { [INFO] [stdout] 417 | | return 2; [INFO] [stdout] ... | [INFO] [stdout] 420 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 415 ~ if let Err(_) = decrypter.decrypt_in_place(&mut BUFFER, length) { [INFO] [stdout] 416 + return 2; [INFO] [stdout] 417 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:104:30 [INFO] [stdout] | [INFO] [stdout] 104 | .copy_from_slice(&signing_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signing_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:106:30 [INFO] [stdout] | [INFO] [stdout] 106 | .copy_from_slice(&verifying_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `verifying_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:121:30 [INFO] [stdout] | [INFO] [stdout] 121 | .copy_from_slice(&signing_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signing_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:123:30 [INFO] [stdout] | [INFO] [stdout] 123 | .copy_from_slice(&verifying_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `verifying_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return 0; [INFO] [stdout] 171 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | / match hs.write_message( [INFO] [stdout] 161 | | &BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 162 | | &mut BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 163 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 167 | | Ok(()) => (), [INFO] [stdout] 168 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 160 ~ if let Err(_) = hs.write_message( [INFO] [stdout] 161 + &BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 162 + &mut BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 163 + ) { [INFO] [stdout] 164 + return 1; [INFO] [stdout] 165 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - return 0; [INFO] [stdout] 220 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | / match hs.read_message( [INFO] [stdout] 210 | | &BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 211 | | &mut BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 212 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 216 | | Ok(_) => (), [INFO] [stdout] 217 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 209 ~ if let Err(_) = hs.read_message( [INFO] [stdout] 210 + &BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 211 + &mut BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 212 + ) { [INFO] [stdout] 213 + return 2; [INFO] [stdout] 214 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 244 - return 0; [INFO] [stdout] 244 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | / match hs.write_message( [INFO] [stdout] 234 | | &BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 235 | | &mut BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 236 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 240 | | Ok(_) => (), [INFO] [stdout] 241 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 233 ~ if let Err(_) = hs.write_message( [INFO] [stdout] 234 + &BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 235 + &mut BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 236 + ) { [INFO] [stdout] 237 + return 2; [INFO] [stdout] 238 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:290:12 [INFO] [stdout] | [INFO] [stdout] 290 | if !responder_verifying_key [INFO] [stdout] | ____________^ [INFO] [stdout] 291 | | .verify(&responder_public_crypt_key.as_slice(), &responder_signature) [INFO] [stdout] 292 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 290 ~ if responder_verifying_key [INFO] [stdout] 291 + .verify(&responder_public_crypt_key.as_slice(), &responder_signature).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:298:9 [INFO] [stdout] | [INFO] [stdout] 298 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return 0; [INFO] [stdout] 298 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 257 | / match hs.read_message( [INFO] [stdout] 258 | | &BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 259 | | &mut BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 260 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 264 | | Ok(_) => (), [INFO] [stdout] 265 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 257 ~ if let Err(_) = hs.read_message( [INFO] [stdout] 258 + &BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 259 + &mut BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 260 + ) { [INFO] [stdout] 261 + return 2; [INFO] [stdout] 262 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:291:21 [INFO] [stdout] | [INFO] [stdout] 291 | .verify(&responder_public_crypt_key.as_slice(), &responder_signature) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `responder_public_crypt_key.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 324 - return 0; [INFO] [stdout] 324 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:312:9 [INFO] [stdout] | [INFO] [stdout] 312 | / match hs.write_message(&[], &mut BUFFER[ACK_OFFSET..][..ACK_LENGTH]) { [INFO] [stdout] 313 | | Err(_) => { [INFO] [stdout] 314 | | return 1; [INFO] [stdout] ... | [INFO] [stdout] 317 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 312 ~ if let Err(_) = hs.write_message(&[], &mut BUFFER[ACK_OFFSET..][..ACK_LENGTH]) { [INFO] [stdout] 313 + return 1; [INFO] [stdout] 314 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:367:12 [INFO] [stdout] | [INFO] [stdout] 367 | if !initiator_verifying_key [INFO] [stdout] | ____________^ [INFO] [stdout] 368 | | .verify(&initiator_public_crypt_key.as_slice(), &initiator_signature) [INFO] [stdout] 369 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 367 ~ if initiator_verifying_key [INFO] [stdout] 368 + .verify(&initiator_public_crypt_key.as_slice(), &initiator_signature).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:379:9 [INFO] [stdout] | [INFO] [stdout] 379 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 379 - return 0; [INFO] [stdout] 379 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:336:9 [INFO] [stdout] | [INFO] [stdout] 336 | / match hs.read_message(&BUFFER[ACK_OFFSET..][..ACK_LENGTH], &mut []) { [INFO] [stdout] 337 | | Err(_) => { [INFO] [stdout] 338 | | return 2; [INFO] [stdout] ... | [INFO] [stdout] 341 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 336 ~ if let Err(_) = hs.read_message(&BUFFER[ACK_OFFSET..][..ACK_LENGTH], &mut []) { [INFO] [stdout] 337 + return 2; [INFO] [stdout] 338 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:368:21 [INFO] [stdout] | [INFO] [stdout] 368 | .verify(&initiator_public_crypt_key.as_slice(), &initiator_signature) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `initiator_public_crypt_key.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:398:9 [INFO] [stdout] | [INFO] [stdout] 398 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 398 - return 0; [INFO] [stdout] 398 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:422:9 [INFO] [stdout] | [INFO] [stdout] 422 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 422 - return 0; [INFO] [stdout] 422 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:415:9 [INFO] [stdout] | [INFO] [stdout] 415 | / match decrypter.decrypt_in_place(&mut BUFFER, length) { [INFO] [stdout] 416 | | Err(_) => { [INFO] [stdout] 417 | | return 2; [INFO] [stdout] ... | [INFO] [stdout] 420 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 415 ~ if let Err(_) = decrypter.decrypt_in_place(&mut BUFFER, length) { [INFO] [stdout] 416 + return 2; [INFO] [stdout] 417 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.62s [INFO] running `Command { std: "docker" "inspect" "b0839fd19f9a4090c0b17efeadc52ffbf0af6dd1cc669e463d3ce9096d576008", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0839fd19f9a4090c0b17efeadc52ffbf0af6dd1cc669e463d3ce9096d576008", kill_on_drop: false }` [INFO] [stdout] b0839fd19f9a4090c0b17efeadc52ffbf0af6dd1cc669e463d3ce9096d576008