[INFO] cloning repository https://github.com/pocky34/rust-riversi
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pocky34/rust-riversi" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpocky34%2Frust-riversi", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpocky34%2Frust-riversi'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 8c380cbe444316a731cd523b84594f41e71ccadc
[INFO] linting pocky34/rust-riversi against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpocky34%2Frust-riversi" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/pocky34/rust-riversi
[INFO] finished tweaking git repo https://github.com/pocky34/rust-riversi
[INFO] tweaked toml for git repo https://github.com/pocky34/rust-riversi written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/pocky34/rust-riversi on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/pocky34/rust-riversi already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 1e96327d7cf2071474c72b49d35c052dacf86757350417c09e7e2ab0161dd175
[INFO] running `Command { std: "docker" "start" "-a" "1e96327d7cf2071474c72b49d35c052dacf86757350417c09e7e2ab0161dd175", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "1e96327d7cf2071474c72b49d35c052dacf86757350417c09e7e2ab0161dd175", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "1e96327d7cf2071474c72b49d35c052dacf86757350417c09e7e2ab0161dd175", kill_on_drop: false }`
[INFO] [stdout] 1e96327d7cf2071474c72b49d35c052dacf86757350417c09e7e2ab0161dd175
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] bbbf0ef1bc19a4d018893f4f73ec8b5588d3609491b58a42fdc9e758513780ce
[INFO] running `Command { std: "docker" "start" "-a" "bbbf0ef1bc19a4d018893f4f73ec8b5588d3609491b58a42fdc9e758513780ce", kill_on_drop: false }`
[INFO] [stderr]     Checking rust-riversi v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/stage.rs:66:7
[INFO] [stdout]    |
[INFO] [stdout] 66 |       turn: turn,
[INFO] [stdout]    |       ^^^^^^^^^^ help: replace it with: `turn`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/stage.rs:129:40
[INFO] [stdout]     |
[INFO] [stdout] 129 |         if self.can_put_disc(&Position{x: x, y: y}) {
[INFO] [stdout]     |                                        ^^^^ help: replace it with: `x`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/stage.rs:129:46
[INFO] [stdout]     |
[INFO] [stdout] 129 |         if self.can_put_disc(&Position{x: x, y: y}) {
[INFO] [stdout]     |                                              ^^^^ help: replace it with: `y`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/stage.rs:66:7
[INFO] [stdout]    |
[INFO] [stdout] 66 |       turn: turn,
[INFO] [stdout]    |       ^^^^^^^^^^ help: replace it with: `turn`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/stage.rs:129:40
[INFO] [stdout]     |
[INFO] [stdout] 129 |         if self.can_put_disc(&Position{x: x, y: y}) {
[INFO] [stdout]     |                                        ^^^^ help: replace it with: `x`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/stage.rs:129:46
[INFO] [stdout]     |
[INFO] [stdout] 129 |         if self.can_put_disc(&Position{x: x, y: y}) {
[INFO] [stdout]     |                                              ^^^^ help: replace it with: `y`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression returns a bool literal
[INFO] [stdout]   --> src/stage.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 14 | /     if x < 0 || x >= 8 || y < 0 || y >= 8 {
[INFO] [stdout] 15 | |       false
[INFO] [stdout] 16 | |     } else {
[INFO] [stdout] 17 | |       true
[INFO] [stdout] 18 | |     }
[INFO] [stdout]    | |_____^ help: you can reduce it to: `!(x < 0 || x >= 8 || y < 0 || y >= 8)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stdout]    = note: `#[warn(clippy::needless_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!Range::contains` implementation
[INFO] [stdout]   --> src/stage.rs:14:27
[INFO] [stdout]    |
[INFO] [stdout] 14 |     if x < 0 || x >= 8 || y < 0 || y >= 8 {
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^ help: use: `!(0..8).contains(&y)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout]    = note: `#[warn(clippy::manual_range_contains)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!Range::contains` implementation
[INFO] [stdout]   --> src/stage.rs:14:8
[INFO] [stdout]    |
[INFO] [stdout] 14 |     if x < 0 || x >= 8 || y < 0 || y >= 8 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^ help: use: `!(0..8).contains(&x)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `stage::Position`
[INFO] [stdout]   --> src/stage.rs:25:3
[INFO] [stdout]    |
[INFO] [stdout] 25 | /   pub fn to_string(&self) -> String {
[INFO] [stdout] 26 | |     format!("x: {}, y: {}", self.x, self.y)
[INFO] [stdout] 27 | |   }
[INFO] [stdout]    | |___^
[INFO] [stdout]    |
[INFO] [stdout]    = help: implement trait `Display` for type `stage::Position` instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string
[INFO] [stdout]    = note: `#[warn(clippy::inherent_to_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Stage`
[INFO] [stdout]   --> src/stage.rs:46:3
[INFO] [stdout]    |
[INFO] [stdout] 46 | /   pub fn new() -> Stage {
[INFO] [stdout] 47 | |     let default_array = [
[INFO] [stdout] 48 | |       [0, 0, 0, 0, 0, 0, 0, 0],
[INFO] [stdout] 49 | |       [0, 0, 0, 0, 0, 0, 0, 0],
[INFO] [stdout] ...  |
[INFO] [stdout] 61 | |   }
[INFO] [stdout]    | |___^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 45 + impl Default for Stage {
[INFO] [stdout] 46 +     fn default() -> Self {
[INFO] [stdout] 47 +         Self::new()
[INFO] [stdout] 48 +     }
[INFO] [stdout] 49 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/stage.rs:83:40
[INFO] [stdout]    |
[INFO] [stdout] 83 |         let _ = self.reverse(&new_pos, &dir, &mut num_reversed_discs);
[INFO] [stdout]    |                                        ^^^^ help: change this to: `dir`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/stage.rs:92:11
[INFO] [stdout]    |
[INFO] [stdout] 92 |       Err(format!("No discs to revers"))
[INFO] [stdout]    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No discs to revers".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]    = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/stage.rs:123:5
[INFO] [stdout]     |
[INFO] [stdout] 123 |     !cloned_stage.put_disc(pos).is_err()
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cloned_stage.put_disc(pos).is_ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression returns a bool literal
[INFO] [stdout]   --> src/stage.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 14 | /     if x < 0 || x >= 8 || y < 0 || y >= 8 {
[INFO] [stdout] 15 | |       false
[INFO] [stdout] 16 | |     } else {
[INFO] [stdout] 17 | |       true
[INFO] [stdout] 18 | |     }
[INFO] [stdout]    | |_____^ help: you can reduce it to: `!(x < 0 || x >= 8 || y < 0 || y >= 8)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stdout]    = note: `#[warn(clippy::needless_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!Range::contains` implementation
[INFO] [stdout]   --> src/stage.rs:14:27
[INFO] [stdout]    |
[INFO] [stdout] 14 |     if x < 0 || x >= 8 || y < 0 || y >= 8 {
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^ help: use: `!(0..8).contains(&y)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout]    = note: `#[warn(clippy::manual_range_contains)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `!Range::contains` implementation
[INFO] [stdout]   --> src/stage.rs:14:8
[INFO] [stdout]    |
[INFO] [stdout] 14 |     if x < 0 || x >= 8 || y < 0 || y >= 8 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^ help: use: `!(0..8).contains(&x)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `stage::Position`
[INFO] [stdout]   --> src/stage.rs:25:3
[INFO] [stdout]    |
[INFO] [stdout] 25 | /   pub fn to_string(&self) -> String {
[INFO] [stdout] 26 | |     format!("x: {}, y: {}", self.x, self.y)
[INFO] [stdout] 27 | |   }
[INFO] [stdout]    | |___^
[INFO] [stdout]    |
[INFO] [stdout]    = help: implement trait `Display` for type `stage::Position` instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string
[INFO] [stdout]    = note: `#[warn(clippy::inherent_to_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Stage`
[INFO] [stdout]   --> src/stage.rs:46:3
[INFO] [stdout]    |
[INFO] [stdout] 46 | /   pub fn new() -> Stage {
[INFO] [stdout] 47 | |     let default_array = [
[INFO] [stdout] 48 | |       [0, 0, 0, 0, 0, 0, 0, 0],
[INFO] [stdout] 49 | |       [0, 0, 0, 0, 0, 0, 0, 0],
[INFO] [stdout] ...  |
[INFO] [stdout] 61 | |   }
[INFO] [stdout]    | |___^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 45 + impl Default for Stage {
[INFO] [stdout] 46 +     fn default() -> Self {
[INFO] [stdout] 47 +         Self::new()
[INFO] [stdout] 48 +     }
[INFO] [stdout] 49 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/stage.rs:83:40
[INFO] [stdout]    |
[INFO] [stdout] 83 |         let _ = self.reverse(&new_pos, &dir, &mut num_reversed_discs);
[INFO] [stdout]    |                                        ^^^^ help: change this to: `dir`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/stage.rs:92:11
[INFO] [stdout]    |
[INFO] [stdout] 92 |       Err(format!("No discs to revers"))
[INFO] [stdout]    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No discs to revers".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]    = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/stage.rs:123:5
[INFO] [stdout]     |
[INFO] [stdout] 123 |     !cloned_stage.put_disc(pos).is_err()
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cloned_stage.put_disc(pos).is_ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.26s
[INFO] running `Command { std: "docker" "inspect" "bbbf0ef1bc19a4d018893f4f73ec8b5588d3609491b58a42fdc9e758513780ce", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "bbbf0ef1bc19a4d018893f4f73ec8b5588d3609491b58a42fdc9e758513780ce", kill_on_drop: false }`
[INFO] [stdout] bbbf0ef1bc19a4d018893f4f73ec8b5588d3609491b58a42fdc9e758513780ce