[INFO] cloning repository https://github.com/poblish/BabyNamesRust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/poblish/BabyNamesRust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpoblish%2FBabyNamesRust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpoblish%2FBabyNamesRust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 82f6869a46271ee0c756938793ef9ccd8c4707e1 [INFO] linting poblish/BabyNamesRust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpoblish%2FBabyNamesRust" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/poblish/BabyNamesRust [INFO] finished tweaking git repo https://github.com/poblish/BabyNamesRust [INFO] tweaked toml for git repo https://github.com/poblish/BabyNamesRust written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/poblish/BabyNamesRust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/poblish/BabyNamesRust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0e2108dd880915f1a7dbd618b70b3a544db7ad10457ff1c4ae5c403e51ec7d29 [INFO] running `Command { std: "docker" "start" "-a" "0e2108dd880915f1a7dbd618b70b3a544db7ad10457ff1c4ae5c403e51ec7d29", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0e2108dd880915f1a7dbd618b70b3a544db7ad10457ff1c4ae5c403e51ec7d29", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e2108dd880915f1a7dbd618b70b3a544db7ad10457ff1c4ae5c403e51ec7d29", kill_on_drop: false }` [INFO] [stdout] 0e2108dd880915f1a7dbd618b70b3a544db7ad10457ff1c4ae5c403e51ec7d29 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad2c34e9e4b4818fb72bef7db563f7c95aa33d3c6a00d687040643548c41431d [INFO] running `Command { std: "docker" "start" "-a" "ad2c34e9e4b4818fb72bef7db563f7c95aa33d3c6a00d687040643548c41431d", kill_on_drop: false }` [INFO] [stderr] Checking names v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/main.rs:15:41 [INFO] [stdout] | [INFO] [stdout] 15 | for (_i, name1) in fore_names.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 15 - for (_i, name1) in fore_names.iter().enumerate() { [INFO] [stdout] 15 + for name1 in fore_names.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | if was_vowel && ((last_char == 'u' && c == 'a') || (last_char == 'i' && c == 'a')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 - if was_vowel && ((last_char == 'u' && c == 'a') || (last_char == 'i' && c == 'a')) { [INFO] [stdout] 56 + if !(!was_vowel || c != 'a' || last_char != 'u' && last_char != 'i') { [INFO] [stdout] | [INFO] [stdout] 56 - if was_vowel && ((last_char == 'u' && c == 'a') || (last_char == 'i' && c == 'a')) { [INFO] [stdout] 56 + if (last_char == 'i' || last_char == 'u') && c == 'a' && was_vowel { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:56:25 [INFO] [stdout] | [INFO] [stdout] 56 | if was_vowel && ((last_char == 'u' && c == 'a') || (last_char == 'i' && c == 'a')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 - if was_vowel && ((last_char == 'u' && c == 'a') || (last_char == 'i' && c == 'a')) { [INFO] [stdout] 56 + if was_vowel && !(c != 'a' || last_char != 'u' && last_char != 'i') { [INFO] [stdout] | [INFO] [stdout] 56 - if was_vowel && ((last_char == 'u' && c == 'a') || (last_char == 'i' && c == 'a')) { [INFO] [stdout] 56 + if was_vowel && (last_char == 'i' || last_char == 'u') && c == 'a' { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 59 | if !was_vowel && (!(c == 'e') || !runes_1.is_empty()) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != 'e')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | / match ch { [INFO] [stdout] 79 | | 'a' | 'e' | 'i' | 'o' | 'u' => true, [INFO] [stdout] 80 | | _ => false, [INFO] [stdout] 81 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 78 - match ch { [INFO] [stdout] 79 - 'a' | 'e' | 'i' | 'o' | 'u' => true, [INFO] [stdout] 80 - _ => false, [INFO] [stdout] 81 - } [INFO] [stdout] 78 + matches!(ch, 'a' | 'e' | 'i' | 'o' | 'u') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/main.rs:15:41 [INFO] [stdout] | [INFO] [stdout] 15 | for (_i, name1) in fore_names.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 15 - for (_i, name1) in fore_names.iter().enumerate() { [INFO] [stdout] 15 + for name1 in fore_names.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | if was_vowel && ((last_char == 'u' && c == 'a') || (last_char == 'i' && c == 'a')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 - if was_vowel && ((last_char == 'u' && c == 'a') || (last_char == 'i' && c == 'a')) { [INFO] [stdout] 56 + if !(!was_vowel || c != 'a' || last_char != 'u' && last_char != 'i') { [INFO] [stdout] | [INFO] [stdout] 56 - if was_vowel && ((last_char == 'u' && c == 'a') || (last_char == 'i' && c == 'a')) { [INFO] [stdout] 56 + if (last_char == 'i' || last_char == 'u') && c == 'a' && was_vowel { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:56:25 [INFO] [stdout] | [INFO] [stdout] 56 | if was_vowel && ((last_char == 'u' && c == 'a') || (last_char == 'i' && c == 'a')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 56 - if was_vowel && ((last_char == 'u' && c == 'a') || (last_char == 'i' && c == 'a')) { [INFO] [stdout] 56 + if was_vowel && !(c != 'a' || last_char != 'u' && last_char != 'i') { [INFO] [stdout] | [INFO] [stdout] 56 - if was_vowel && ((last_char == 'u' && c == 'a') || (last_char == 'i' && c == 'a')) { [INFO] [stdout] 56 + if was_vowel && (last_char == 'i' || last_char == 'u') && c == 'a' { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 59 | if !was_vowel && (!(c == 'e') || !runes_1.is_empty()) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != 'e')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | / match ch { [INFO] [stdout] 79 | | 'a' | 'e' | 'i' | 'o' | 'u' => true, [INFO] [stdout] 80 | | _ => false, [INFO] [stdout] 81 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 78 - match ch { [INFO] [stdout] 79 - 'a' | 'e' | 'i' | 'o' | 'u' => true, [INFO] [stdout] 80 - _ => false, [INFO] [stdout] 81 - } [INFO] [stdout] 78 + matches!(ch, 'a' | 'e' | 'i' | 'o' | 'u') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.18s [INFO] running `Command { std: "docker" "inspect" "ad2c34e9e4b4818fb72bef7db563f7c95aa33d3c6a00d687040643548c41431d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad2c34e9e4b4818fb72bef7db563f7c95aa33d3c6a00d687040643548c41431d", kill_on_drop: false }` [INFO] [stdout] ad2c34e9e4b4818fb72bef7db563f7c95aa33d3c6a00d687040643548c41431d