[INFO] cloning repository https://github.com/pmalmgren/pongbrickbreaker
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pmalmgren/pongbrickbreaker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpmalmgren%2Fpongbrickbreaker", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpmalmgren%2Fpongbrickbreaker'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 708bee1059243ea43af39418dac04eeca8034275
[INFO] linting pmalmgren/pongbrickbreaker against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpmalmgren%2Fpongbrickbreaker" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/pmalmgren/pongbrickbreaker
[INFO] finished tweaking git repo https://github.com/pmalmgren/pongbrickbreaker
[INFO] tweaked toml for git repo https://github.com/pmalmgren/pongbrickbreaker written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/pmalmgren/pongbrickbreaker on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/pmalmgren/pongbrickbreaker already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded cc v1.0.66
[INFO] [stderr]   Downloaded pkg-config v0.3.19
[INFO] [stderr]   Downloaded ncurses v5.99.0
[INFO] [stderr]   Downloaded libc v0.2.81
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] fedfca8fbb1f124aa0dea7bdad91b9ea0378b9ed6a2965519d16a3d49f50bb26
[INFO] running `Command { std: "docker" "start" "-a" "fedfca8fbb1f124aa0dea7bdad91b9ea0378b9ed6a2965519d16a3d49f50bb26", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "fedfca8fbb1f124aa0dea7bdad91b9ea0378b9ed6a2965519d16a3d49f50bb26", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "fedfca8fbb1f124aa0dea7bdad91b9ea0378b9ed6a2965519d16a3d49f50bb26", kill_on_drop: false }`
[INFO] [stdout] fedfca8fbb1f124aa0dea7bdad91b9ea0378b9ed6a2965519d16a3d49f50bb26
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 0082528c2a0393532812ac0c9f8a94596681959b0050dd8b51f56f3236665657
[INFO] running `Command { std: "docker" "start" "-a" "0082528c2a0393532812ac0c9f8a94596681959b0050dd8b51f56f3236665657", kill_on_drop: false }`
[INFO] [stderr]    Compiling cc v1.0.66
[INFO] [stderr]    Compiling pkg-config v0.3.19
[INFO] [stderr]    Compiling libc v0.2.81
[INFO] [stderr]    Compiling ncurses v5.99.0
[INFO] [stderr]     Checking pong v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary parentheses around match arm expression
[INFO] [stdout]    --> src/main.rs:415:18
[INFO] [stdout]     |
[INFO] [stdout] 415 |             0 => (brick_width / 2),
[INFO] [stdout]     |                  ^               ^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 415 -             0 => (brick_width / 2),
[INFO] [stdout] 415 +             0 => brick_width / 2 ,
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/main.rs:431:9
[INFO] [stdout]     |
[INFO] [stdout] 431 |         window: window,
[INFO] [stdout]     |         ^^^^^^^^^^^^^^ help: replace it with: `window`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/main.rs:446:9
[INFO] [stdout]     |
[INFO] [stdout] 446 |         bricks: bricks,
[INFO] [stdout]     |         ^^^^^^^^^^^^^^ help: replace it with: `bricks`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/main.rs:432:26
[INFO] [stdout]     |
[INFO] [stdout] 432 |         bounds: Bounds { max_x: max_x, max_y: max_y, min_x: 0, min_y: 0 },
[INFO] [stdout]     |                          ^^^^^^^^^^^^ help: replace it with: `max_x`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/main.rs:432:40
[INFO] [stdout]     |
[INFO] [stdout] 432 |         bounds: Bounds { max_x: max_x, max_y: max_y, min_x: 0, min_y: 0 },
[INFO] [stdout]     |                                        ^^^^^^^^^^^^ help: replace it with: `max_y`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around match arm expression
[INFO] [stdout]    --> src/main.rs:415:18
[INFO] [stdout]     |
[INFO] [stdout] 415 |             0 => (brick_width / 2),
[INFO] [stdout]     |                  ^               ^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 415 -             0 => (brick_width / 2),
[INFO] [stdout] 415 +             0 => brick_width / 2 ,
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/main.rs:431:9
[INFO] [stdout]     |
[INFO] [stdout] 431 |         window: window,
[INFO] [stdout]     |         ^^^^^^^^^^^^^^ help: replace it with: `window`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/main.rs:446:9
[INFO] [stdout]     |
[INFO] [stdout] 446 |         bricks: bricks,
[INFO] [stdout]     |         ^^^^^^^^^^^^^^ help: replace it with: `bricks`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/main.rs:432:26
[INFO] [stdout]     |
[INFO] [stdout] 432 |         bounds: Bounds { max_x: max_x, max_y: max_y, min_x: 0, min_y: 0 },
[INFO] [stdout]     |                          ^^^^^^^^^^^^ help: replace it with: `max_x`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/main.rs:432:40
[INFO] [stdout]     |
[INFO] [stdout] 432 |         bounds: Bounds { max_x: max_x, max_y: max_y, min_x: 0, min_y: 0 },
[INFO] [stdout]     |                                        ^^^^^^^^^^^^ help: replace it with: `max_y`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:47:45
[INFO] [stdout]    |
[INFO] [stdout] 47 |     fn will_collide_with_any(&self, bounds: &Vec<Bounds>, direction: &Direction) -> Option<usize> {
[INFO] [stdout]    |                                             ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 47 -     fn will_collide_with_any(&self, bounds: &Vec<Bounds>, direction: &Direction) -> Option<usize> {
[INFO] [stdout] 47 +     fn will_collide_with_any(&self, bounds: &[Bounds], direction: &Direction) -> Option<usize> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: all variants have the same prefix: `Hit`
[INFO] [stdout]   --> src/main.rs:71:1
[INFO] [stdout]    |
[INFO] [stdout] 71 | / enum MoveResult {
[INFO] [stdout] 72 | |     HitPaddleCenter,
[INFO] [stdout] 73 | |     HitPaddleLeft,
[INFO] [stdout] 74 | |     HitPaddleRight,
[INFO] [stdout] ...  |
[INFO] [stdout] 78 | |     HitBrick(Direction, usize),
[INFO] [stdout] 79 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout]    = note: `#[warn(clippy::enum_variant_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:111:9
[INFO] [stdout]     |
[INFO] [stdout] 111 | /         return match direction {
[INFO] [stdout] 112 | |             Direction::Left => {
[INFO] [stdout] 113 | |                 if left_edge <= 1 {
[INFO] [stdout] 114 | |                     return Some(MoveResult::HitWallLeftRight);
[INFO] [stdout] ...   |
[INFO] [stdout] 151 | |             Direction::Still => None,
[INFO] [stdout] 152 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 111 ~         match direction {
[INFO] [stdout] 112 +             Direction::Left => {
[INFO] [stdout] 113 +                 if left_edge <= 1 {
[INFO] [stdout] 114 +                     return Some(MoveResult::HitWallLeftRight);
[INFO] [stdout] 115 +                 }
[INFO] [stdout] 116 + 
[INFO] [stdout] 117 +                 self.do_move1(bricks, direction)
[INFO] [stdout] 118 +             },
[INFO] [stdout] 119 +             Direction::Right => {
[INFO] [stdout] 120 +                 if right_edge >= (bounds.max_x - 2) {
[INFO] [stdout] 121 +                     return Some(MoveResult::HitWallLeftRight)
[INFO] [stdout] 122 +                 }
[INFO] [stdout] 123 + 
[INFO] [stdout] 124 +                 self.do_move1(bricks, direction)
[INFO] [stdout] 125 +             },
[INFO] [stdout] 126 +             Direction::Up => {
[INFO] [stdout] 127 +                 if self.pos.y <= 1 {
[INFO] [stdout] 128 +                     return Some(MoveResult::HitWallTop);
[INFO] [stdout] 129 +                 }
[INFO] [stdout] 130 + 
[INFO] [stdout] 131 +                 self.do_move1(bricks, direction)
[INFO] [stdout] 132 +             },
[INFO] [stdout] 133 +             Direction::Down => {
[INFO] [stdout] 134 +                 if self.pos.y >= (bounds.max_y - 2) {
[INFO] [stdout] 135 +                     return Some(MoveResult::HitWallBottom)
[INFO] [stdout] 136 +                 }
[INFO] [stdout] 137 + 
[INFO] [stdout] 138 +                 if self.pos.will_collide(paddle_bounds, &Direction::Down) {
[INFO] [stdout] 139 +                     let third = PADDLE_WIDTH / 3;
[INFO] [stdout] 140 +                     if self.pos.x < (paddle_bounds.min_x + third) {
[INFO] [stdout] 141 +                         return Some(MoveResult::HitPaddleLeft);
[INFO] [stdout] 142 +                     }
[INFO] [stdout] 143 +                     if self.pos.x < (paddle_bounds.min_x + (2 * third)) {
[INFO] [stdout] 144 +                         return Some(MoveResult::HitPaddleCenter);
[INFO] [stdout] 145 +                     }
[INFO] [stdout] 146 +                     return Some(MoveResult::HitPaddleRight);
[INFO] [stdout] 147 +                 }
[INFO] [stdout] 148 + 
[INFO] [stdout] 149 +                 self.do_move1(bricks, direction)
[INFO] [stdout] 150 +             },
[INFO] [stdout] 151 +             Direction::Still => None,
[INFO] [stdout] 152 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:202:20
[INFO] [stdout]     |
[INFO] [stdout] 202 |                 if !hit_brick.is_some() {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^ help: try: `hit_brick.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:208:20
[INFO] [stdout]     |
[INFO] [stdout] 208 |                 if !hit_brick.is_some() {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^ help: try: `hit_brick.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/main.rs:202:17
[INFO] [stdout]     |
[INFO] [stdout] 202 | /                 if !hit_brick.is_some() {
[INFO] [stdout] 203 | |                     self.vel.x = -self.vel.x;
[INFO] [stdout] 204 | |                     hit_brick = Some(brick_idx);
[INFO] [stdout] 205 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 201 ~             Some(MoveResult::HitBrick(Direction::Left, brick_idx))
[INFO] [stdout] 202 ~                 if !hit_brick.is_some() => {
[INFO] [stdout] 203 |                     self.vel.x = -self.vel.x;
[INFO] [stdout] 204 |                     hit_brick = Some(brick_idx);
[INFO] [stdout] 205 ~                 },
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/main.rs:208:17
[INFO] [stdout]     |
[INFO] [stdout] 208 | /                 if !hit_brick.is_some() {
[INFO] [stdout] 209 | |                     self.vel.x = -self.vel.x;
[INFO] [stdout] 210 | |                     hit_brick = Some(brick_idx);
[INFO] [stdout] 211 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 207 ~             Some(MoveResult::HitBrick(Direction::Right, brick_idx))
[INFO] [stdout] 208 ~                 if !hit_brick.is_some() => {
[INFO] [stdout] 209 |                     self.vel.x = -self.vel.x;
[INFO] [stdout] 210 |                     hit_brick = Some(brick_idx);
[INFO] [stdout] 211 ~                 },
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:310:20
[INFO] [stdout]     |
[INFO] [stdout] 310 |             'a' => return Command::Move(Direction::Left),
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 310 ~             'a' => Command::Move(Direction::Left),
[INFO] [stdout] 311 |             'd' => return Command::Move(Direction::Right),
[INFO] [stdout] 312 |             'q' => return Command::Quit,
[INFO] [stdout] 313 |             _ => return Command::Move(Direction::Still),
[INFO] [stdout] 314 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:311:20
[INFO] [stdout]     |
[INFO] [stdout] 311 |             'd' => return Command::Move(Direction::Right),
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 311 ~             'd' => Command::Move(Direction::Right),
[INFO] [stdout] 312 |             'q' => return Command::Quit,
[INFO] [stdout] 313 |             _ => return Command::Move(Direction::Still),
[INFO] [stdout] 314 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:312:20
[INFO] [stdout]     |
[INFO] [stdout] 312 |             'q' => return Command::Quit,
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 312 ~             'q' => Command::Quit,
[INFO] [stdout] 313 |             _ => return Command::Move(Direction::Still),
[INFO] [stdout] 314 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:313:18
[INFO] [stdout]     |
[INFO] [stdout] 313 |             _ => return Command::Move(Direction::Still),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 313 ~             _ => Command::Move(Direction::Still),
[INFO] [stdout] 314 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:319:25
[INFO] [stdout]     |
[INFO] [stdout] 319 |             Some(ch) => return Command::from_char(ch),
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 319 ~             Some(ch) => Command::from_char(ch),
[INFO] [stdout] 320 |             None => return Command::Move(Direction::Still), 
[INFO] [stdout] 321 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:320:21
[INFO] [stdout]     |
[INFO] [stdout] 320 |             None => return Command::Move(Direction::Still), 
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 320 ~             None => Command::Move(Direction::Still), 
[INFO] [stdout] 321 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:351:5
[INFO] [stdout]     |
[INFO] [stdout] 351 |     return Ok(window);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 351 -     return Ok(window);
[INFO] [stdout] 351 +     Ok(window)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/main.rs:373:17
[INFO] [stdout]     |
[INFO] [stdout] 373 | /                 match hit_brick {
[INFO] [stdout] 374 | |                     Some(brick_idx) => game.rm_brick(brick_idx),
[INFO] [stdout] 375 | |                     None => (),
[INFO] [stdout] 376 | |                 }
[INFO] [stdout]     | |_________________^ help: try: `if let Some(brick_idx) = hit_brick { game.rm_brick(brick_idx) }`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:47:45
[INFO] [stdout]    |
[INFO] [stdout] 47 |     fn will_collide_with_any(&self, bounds: &Vec<Bounds>, direction: &Direction) -> Option<usize> {
[INFO] [stdout]    |                                             ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 47 -     fn will_collide_with_any(&self, bounds: &Vec<Bounds>, direction: &Direction) -> Option<usize> {
[INFO] [stdout] 47 +     fn will_collide_with_any(&self, bounds: &[Bounds], direction: &Direction) -> Option<usize> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/main.rs:383:12
[INFO] [stdout]     |
[INFO] [stdout] 383 |         if game.bricks.len() == 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `game.bricks.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: all variants have the same prefix: `Hit`
[INFO] [stdout]   --> src/main.rs:71:1
[INFO] [stdout]    |
[INFO] [stdout] 71 | / enum MoveResult {
[INFO] [stdout] 72 | |     HitPaddleCenter,
[INFO] [stdout] 73 | |     HitPaddleLeft,
[INFO] [stdout] 74 | |     HitPaddleRight,
[INFO] [stdout] ...  |
[INFO] [stdout] 78 | |     HitBrick(Direction, usize),
[INFO] [stdout] 79 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout]    = note: `#[warn(clippy::enum_variant_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:111:9
[INFO] [stdout]     |
[INFO] [stdout] 111 | /         return match direction {
[INFO] [stdout] 112 | |             Direction::Left => {
[INFO] [stdout] 113 | |                 if left_edge <= 1 {
[INFO] [stdout] 114 | |                     return Some(MoveResult::HitWallLeftRight);
[INFO] [stdout] ...   |
[INFO] [stdout] 151 | |             Direction::Still => None,
[INFO] [stdout] 152 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 111 ~         match direction {
[INFO] [stdout] 112 +             Direction::Left => {
[INFO] [stdout] 113 +                 if left_edge <= 1 {
[INFO] [stdout] 114 +                     return Some(MoveResult::HitWallLeftRight);
[INFO] [stdout] 115 +                 }
[INFO] [stdout] 116 + 
[INFO] [stdout] 117 +                 self.do_move1(bricks, direction)
[INFO] [stdout] 118 +             },
[INFO] [stdout] 119 +             Direction::Right => {
[INFO] [stdout] 120 +                 if right_edge >= (bounds.max_x - 2) {
[INFO] [stdout] 121 +                     return Some(MoveResult::HitWallLeftRight)
[INFO] [stdout] 122 +                 }
[INFO] [stdout] 123 + 
[INFO] [stdout] 124 +                 self.do_move1(bricks, direction)
[INFO] [stdout] 125 +             },
[INFO] [stdout] 126 +             Direction::Up => {
[INFO] [stdout] 127 +                 if self.pos.y <= 1 {
[INFO] [stdout] 128 +                     return Some(MoveResult::HitWallTop);
[INFO] [stdout] 129 +                 }
[INFO] [stdout] 130 + 
[INFO] [stdout] 131 +                 self.do_move1(bricks, direction)
[INFO] [stdout] 132 +             },
[INFO] [stdout] 133 +             Direction::Down => {
[INFO] [stdout] 134 +                 if self.pos.y >= (bounds.max_y - 2) {
[INFO] [stdout] 135 +                     return Some(MoveResult::HitWallBottom)
[INFO] [stdout] 136 +                 }
[INFO] [stdout] 137 + 
[INFO] [stdout] 138 +                 if self.pos.will_collide(paddle_bounds, &Direction::Down) {
[INFO] [stdout] 139 +                     let third = PADDLE_WIDTH / 3;
[INFO] [stdout] 140 +                     if self.pos.x < (paddle_bounds.min_x + third) {
[INFO] [stdout] 141 +                         return Some(MoveResult::HitPaddleLeft);
[INFO] [stdout] 142 +                     }
[INFO] [stdout] 143 +                     if self.pos.x < (paddle_bounds.min_x + (2 * third)) {
[INFO] [stdout] 144 +                         return Some(MoveResult::HitPaddleCenter);
[INFO] [stdout] 145 +                     }
[INFO] [stdout] 146 +                     return Some(MoveResult::HitPaddleRight);
[INFO] [stdout] 147 +                 }
[INFO] [stdout] 148 + 
[INFO] [stdout] 149 +                 self.do_move1(bricks, direction)
[INFO] [stdout] 150 +             },
[INFO] [stdout] 151 +             Direction::Still => None,
[INFO] [stdout] 152 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:202:20
[INFO] [stdout]     |
[INFO] [stdout] 202 |                 if !hit_brick.is_some() {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^ help: try: `hit_brick.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:208:20
[INFO] [stdout]     |
[INFO] [stdout] 208 |                 if !hit_brick.is_some() {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^ help: try: `hit_brick.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/main.rs:202:17
[INFO] [stdout]     |
[INFO] [stdout] 202 | /                 if !hit_brick.is_some() {
[INFO] [stdout] 203 | |                     self.vel.x = -self.vel.x;
[INFO] [stdout] 204 | |                     hit_brick = Some(brick_idx);
[INFO] [stdout] 205 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 201 ~             Some(MoveResult::HitBrick(Direction::Left, brick_idx))
[INFO] [stdout] 202 ~                 if !hit_brick.is_some() => {
[INFO] [stdout] 203 |                     self.vel.x = -self.vel.x;
[INFO] [stdout] 204 |                     hit_brick = Some(brick_idx);
[INFO] [stdout] 205 ~                 },
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/main.rs:208:17
[INFO] [stdout]     |
[INFO] [stdout] 208 | /                 if !hit_brick.is_some() {
[INFO] [stdout] 209 | |                     self.vel.x = -self.vel.x;
[INFO] [stdout] 210 | |                     hit_brick = Some(brick_idx);
[INFO] [stdout] 211 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 207 ~             Some(MoveResult::HitBrick(Direction::Right, brick_idx))
[INFO] [stdout] 208 ~                 if !hit_brick.is_some() => {
[INFO] [stdout] 209 |                     self.vel.x = -self.vel.x;
[INFO] [stdout] 210 |                     hit_brick = Some(brick_idx);
[INFO] [stdout] 211 ~                 },
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:310:20
[INFO] [stdout]     |
[INFO] [stdout] 310 |             'a' => return Command::Move(Direction::Left),
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 310 ~             'a' => Command::Move(Direction::Left),
[INFO] [stdout] 311 |             'd' => return Command::Move(Direction::Right),
[INFO] [stdout] 312 |             'q' => return Command::Quit,
[INFO] [stdout] 313 |             _ => return Command::Move(Direction::Still),
[INFO] [stdout] 314 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:311:20
[INFO] [stdout]     |
[INFO] [stdout] 311 |             'd' => return Command::Move(Direction::Right),
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 311 ~             'd' => Command::Move(Direction::Right),
[INFO] [stdout] 312 |             'q' => return Command::Quit,
[INFO] [stdout] 313 |             _ => return Command::Move(Direction::Still),
[INFO] [stdout] 314 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:312:20
[INFO] [stdout]     |
[INFO] [stdout] 312 |             'q' => return Command::Quit,
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 312 ~             'q' => Command::Quit,
[INFO] [stdout] 313 |             _ => return Command::Move(Direction::Still),
[INFO] [stdout] 314 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:313:18
[INFO] [stdout]     |
[INFO] [stdout] 313 |             _ => return Command::Move(Direction::Still),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 313 ~             _ => Command::Move(Direction::Still),
[INFO] [stdout] 314 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:319:25
[INFO] [stdout]     |
[INFO] [stdout] 319 |             Some(ch) => return Command::from_char(ch),
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 319 ~             Some(ch) => Command::from_char(ch),
[INFO] [stdout] 320 |             None => return Command::Move(Direction::Still), 
[INFO] [stdout] 321 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:320:21
[INFO] [stdout]     |
[INFO] [stdout] 320 |             None => return Command::Move(Direction::Still), 
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 320 ~             None => Command::Move(Direction::Still), 
[INFO] [stdout] 321 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:351:5
[INFO] [stdout]     |
[INFO] [stdout] 351 |     return Ok(window);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 351 -     return Ok(window);
[INFO] [stdout] 351 +     Ok(window)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/main.rs:373:17
[INFO] [stdout]     |
[INFO] [stdout] 373 | /                 match hit_brick {
[INFO] [stdout] 374 | |                     Some(brick_idx) => game.rm_brick(brick_idx),
[INFO] [stdout] 375 | |                     None => (),
[INFO] [stdout] 376 | |                 }
[INFO] [stdout]     | |_________________^ help: try: `if let Some(brick_idx) = hit_brick { game.rm_brick(brick_idx) }`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/main.rs:383:12
[INFO] [stdout]     |
[INFO] [stdout] 383 |         if game.bricks.len() == 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `game.bricks.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.16s
[INFO] running `Command { std: "docker" "inspect" "0082528c2a0393532812ac0c9f8a94596681959b0050dd8b51f56f3236665657", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "0082528c2a0393532812ac0c9f8a94596681959b0050dd8b51f56f3236665657", kill_on_drop: false }`
[INFO] [stdout] 0082528c2a0393532812ac0c9f8a94596681959b0050dd8b51f56f3236665657