[INFO] cloning repository https://github.com/pktucherche/file-integrity-monitoring [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pktucherche/file-integrity-monitoring" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpktucherche%2Ffile-integrity-monitoring", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpktucherche%2Ffile-integrity-monitoring'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8eb48a941728be83ea21f707a4e5a7539ee0163e [INFO] linting pktucherche/file-integrity-monitoring against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpktucherche%2Ffile-integrity-monitoring" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/pktucherche/file-integrity-monitoring [INFO] finished tweaking git repo https://github.com/pktucherche/file-integrity-monitoring [INFO] tweaked toml for git repo https://github.com/pktucherche/file-integrity-monitoring written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/pktucherche/file-integrity-monitoring on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/pktucherche/file-integrity-monitoring already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded diffy v0.3.0 [INFO] [stderr] Downloaded cc v1.0.96 [INFO] [stderr] Downloaded nix v0.23.2 [INFO] [stderr] Downloaded rusqlite v0.28.0 [INFO] [stderr] Downloaded libsqlite3-sys v0.25.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6c9e48c8734a6dd5c2a87e48e75c762ac8b32453d3e8023b711f6d88d7707242 [INFO] running `Command { std: "docker" "start" "-a" "6c9e48c8734a6dd5c2a87e48e75c762ac8b32453d3e8023b711f6d88d7707242", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c9e48c8734a6dd5c2a87e48e75c762ac8b32453d3e8023b711f6d88d7707242", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c9e48c8734a6dd5c2a87e48e75c762ac8b32453d3e8023b711f6d88d7707242", kill_on_drop: false }` [INFO] [stdout] 6c9e48c8734a6dd5c2a87e48e75c762ac8b32453d3e8023b711f6d88d7707242 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0392971a6cc6e024da04f42ce064275268057ec662ec07fc3cd3c126c917059d [INFO] running `Command { std: "docker" "start" "-a" "0392971a6cc6e024da04f42ce064275268057ec662ec07fc3cd3c126c917059d", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling serde v1.0.200 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Compiling bytes v1.6.0 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Compiling cc v1.0.96 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling zstd-safe v7.1.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling tracing-core v0.1.32 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling pin-project-lite v0.2.14 [INFO] [stderr] Compiling libsqlite3-sys v0.25.2 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Checking brotli-decompressor v2.5.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling http v0.2.12 [INFO] [stderr] Compiling bytestring v1.3.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking brotli v3.5.0 [INFO] [stderr] Checking nix v0.23.2 [INFO] [stderr] Compiling zstd-sys v2.0.10+zstd.1.5.6 [INFO] [stderr] Checking diffy v0.3.0 [INFO] [stderr] Checking rusqlite v0.28.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking actix-router v0.5.2 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking actix-rt v2.9.0 [INFO] [stderr] Checking inotify v0.10.2 [INFO] [stderr] Checking actix-server v2.3.0 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Compiling actix-web-codegen v4.2.2 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Checking zstd v0.13.1 [INFO] [stderr] Checking actix-http v3.6.0 [INFO] [stderr] Checking actix-web v4.5.1 [INFO] [stderr] Checking fileintegritymonitoring v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/web.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | fn fetch_events() -> Result), Error>>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/web.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | fn fetch_events() -> Result), Error>>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/web.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | let file_state; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `file_state` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 59 ~ [INFO] [stdout] 60 | [INFO] [stdout] 61 ~ let file_state = if app_fim.state == false { [INFO] [stdout] 62 ~ String::from("offline") [INFO] [stdout] 63 | } else { [INFO] [stdout] 64 ~ String::from("online") [INFO] [stdout] 65 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/web.rs:61:8 [INFO] [stdout] | [INFO] [stdout] 61 | if app_fim.state == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!app_fim.state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/web.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | if app_fim.state == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!app_fim.state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/web.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | / match fetch_events() { [INFO] [stdout] 95 | | Ok(events) => { [INFO] [stdout] 96 | | for event in events { [INFO] [stdout] 97 | | match event { [INFO] [stdout] ... | [INFO] [stdout] 140 | | _ => () [INFO] [stdout] 141 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 ~ if let Ok(events) = fetch_events() { [INFO] [stdout] 95 + for event in events { [INFO] [stdout] 96 + match event { [INFO] [stdout] 97 + Ok((id, file_path, type_event, date_event, diff)) => { [INFO] [stdout] 98 + html_with_css = html_with_css.replace("", " [INFO] [stdout] 99 +
[INFO] [stdout] 100 +
[INFO] [stdout] 101 +
[INFO] [stdout] 102 +
{2}
[INFO] [stdout] 103 +
[INFO] [stdout] 104 +
{3}
[INFO] [stdout] 105 +
{4}
[INFO] [stdout] 106 + {5} [INFO] [stdout] 107 +
[INFO] [stdout] 108 + [INFO] [stdout] 109 + "); [INFO] [stdout] 110 + [INFO] [stdout] 111 + html_with_css = match type_event.as_str() { [INFO] [stdout] 112 + "CREATE" => html_with_css.replace("{1}", "create"), [INFO] [stdout] 113 + "DELETE" => html_with_css.replace("{1}", "delete"), [INFO] [stdout] 114 + "MODIFY" => html_with_css.replace("{1}", "modify"), [INFO] [stdout] 115 + "MOVED_FROM" => html_with_css.replace("{1}", "moved_from"), [INFO] [stdout] 116 + "MOVED_TO" => html_with_css.replace("{1}", "moved_to"), [INFO] [stdout] 117 + _ => { [INFO] [stdout] 118 + continue; [INFO] [stdout] 119 + } [INFO] [stdout] 120 + }; [INFO] [stdout] 121 + [INFO] [stdout] 122 + html_with_css = html_with_css.replace("{2}", type_event.as_str()); [INFO] [stdout] 123 + html_with_css = html_with_css.replace("{3}", file_path.as_str()); [INFO] [stdout] 124 + html_with_css = html_with_css.replace("{4}", date_event.as_str()); [INFO] [stdout] 125 + [INFO] [stdout] 126 + if diff.is_empty() { [INFO] [stdout] 127 + html_with_css = html_with_css.replace("{5}", ""); [INFO] [stdout] 128 + } else { [INFO] [stdout] 129 + let tmp_link = "See more"; [INFO] [stdout] 130 + let tmp_id = format!("http://127.0.0.1:6077/diffweb?id={}", id); [INFO] [stdout] 131 + let tmp = tmp_link.replace("{6}", tmp_id.as_str()); [INFO] [stdout] 132 + html_with_css = html_with_css.replace("{5}", tmp.as_str()); [INFO] [stdout] 133 + } [INFO] [stdout] 134 + }, [INFO] [stdout] 135 + _ => continue [INFO] [stdout] 136 + } [INFO] [stdout] 137 + } [INFO] [stdout] 138 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/web.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | let file_state; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `file_state` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 59 ~ [INFO] [stdout] 60 | [INFO] [stdout] 61 ~ let file_state = if app_fim.state == false { [INFO] [stdout] 62 ~ String::from("offline") [INFO] [stdout] 63 | } else { [INFO] [stdout] 64 ~ String::from("online") [INFO] [stdout] 65 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/web.rs:61:8 [INFO] [stdout] | [INFO] [stdout] 61 | if app_fim.state == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!app_fim.state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/web.rs:152:8 [INFO] [stdout] | [INFO] [stdout] 152 | if app_fim.state == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!app_fim.state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/web.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | if app_fim.state == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!app_fim.state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/web.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | / match fetch_events() { [INFO] [stdout] 95 | | Ok(events) => { [INFO] [stdout] 96 | | for event in events { [INFO] [stdout] 97 | | match event { [INFO] [stdout] ... | [INFO] [stdout] 140 | | _ => () [INFO] [stdout] 141 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 ~ if let Ok(events) = fetch_events() { [INFO] [stdout] 95 + for event in events { [INFO] [stdout] 96 + match event { [INFO] [stdout] 97 + Ok((id, file_path, type_event, date_event, diff)) => { [INFO] [stdout] 98 + html_with_css = html_with_css.replace("", " [INFO] [stdout] 99 +
[INFO] [stdout] 100 +
[INFO] [stdout] 101 +
[INFO] [stdout] 102 +
{2}
[INFO] [stdout] 103 +
[INFO] [stdout] 104 +
{3}
[INFO] [stdout] 105 +
{4}
[INFO] [stdout] 106 + {5} [INFO] [stdout] 107 +
[INFO] [stdout] 108 + [INFO] [stdout] 109 + "); [INFO] [stdout] 110 + [INFO] [stdout] 111 + html_with_css = match type_event.as_str() { [INFO] [stdout] 112 + "CREATE" => html_with_css.replace("{1}", "create"), [INFO] [stdout] 113 + "DELETE" => html_with_css.replace("{1}", "delete"), [INFO] [stdout] 114 + "MODIFY" => html_with_css.replace("{1}", "modify"), [INFO] [stdout] 115 + "MOVED_FROM" => html_with_css.replace("{1}", "moved_from"), [INFO] [stdout] 116 + "MOVED_TO" => html_with_css.replace("{1}", "moved_to"), [INFO] [stdout] 117 + _ => { [INFO] [stdout] 118 + continue; [INFO] [stdout] 119 + } [INFO] [stdout] 120 + }; [INFO] [stdout] 121 + [INFO] [stdout] 122 + html_with_css = html_with_css.replace("{2}", type_event.as_str()); [INFO] [stdout] 123 + html_with_css = html_with_css.replace("{3}", file_path.as_str()); [INFO] [stdout] 124 + html_with_css = html_with_css.replace("{4}", date_event.as_str()); [INFO] [stdout] 125 + [INFO] [stdout] 126 + if diff.is_empty() { [INFO] [stdout] 127 + html_with_css = html_with_css.replace("{5}", ""); [INFO] [stdout] 128 + } else { [INFO] [stdout] 129 + let tmp_link = "See more"; [INFO] [stdout] 130 + let tmp_id = format!("http://127.0.0.1:6077/diffweb?id={}", id); [INFO] [stdout] 131 + let tmp = tmp_link.replace("{6}", tmp_id.as_str()); [INFO] [stdout] 132 + html_with_css = html_with_css.replace("{5}", tmp.as_str()); [INFO] [stdout] 133 + } [INFO] [stdout] 134 + }, [INFO] [stdout] 135 + _ => continue [INFO] [stdout] 136 + } [INFO] [stdout] 137 + } [INFO] [stdout] 138 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/web.rs:182:36 [INFO] [stdout] | [INFO] [stdout] 182 | let app_fim_clone = Arc::clone(&app_fim_mutex); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `app_fim_mutex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/web.rs:207:8 [INFO] [stdout] | [INFO] [stdout] 207 | if app_fim.state == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `app_fim.state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/web.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 216 | / match check_path(&path) { [INFO] [stdout] 217 | | Err(_) => return HttpResponse::Found().append_header(("Location", "/")).finish(), [INFO] [stdout] 218 | | _ => (), [INFO] [stdout] 219 | | } [INFO] [stdout] | |_____^ help: try: `if let Err(_) = check_path(&path) { return HttpResponse::Found().append_header(("Location", "/")).finish() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/web.rs:152:8 [INFO] [stdout] | [INFO] [stdout] 152 | if app_fim.state == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!app_fim.state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/web.rs:216:22 [INFO] [stdout] | [INFO] [stdout] 216 | match check_path(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/web.rs:230:41 [INFO] [stdout] | [INFO] [stdout] 230 | if desired_path.starts_with(&item) { [INFO] [stdout] | ^^^^^ help: change this to: `item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/web.rs:182:36 [INFO] [stdout] | [INFO] [stdout] 182 | let app_fim_clone = Arc::clone(&app_fim_mutex); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `app_fim_mutex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/web.rs:239:46 [INFO] [stdout] | [INFO] [stdout] 239 | app_fim.path_from_web.retain(|x| *x != PathBuf::from(item)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/web.rs:253:8 [INFO] [stdout] | [INFO] [stdout] 253 | if app_fim.state == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `app_fim.state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/web.rs:207:8 [INFO] [stdout] | [INFO] [stdout] 207 | if app_fim.state == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `app_fim.state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/web.rs:262:38 [INFO] [stdout] | [INFO] [stdout] 262 | app_fim.path_from_web.retain(|x| *x != PathBuf::from(path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/web.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 216 | / match check_path(&path) { [INFO] [stdout] 217 | | Err(_) => return HttpResponse::Found().append_header(("Location", "/")).finish(), [INFO] [stdout] 218 | | _ => (), [INFO] [stdout] 219 | | } [INFO] [stdout] | |_____^ help: try: `if let Err(_) = check_path(&path) { return HttpResponse::Found().append_header(("Location", "/")).finish() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/web.rs:216:22 [INFO] [stdout] | [INFO] [stdout] 216 | match check_path(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/web.rs:230:41 [INFO] [stdout] | [INFO] [stdout] 230 | if desired_path.starts_with(&item) { [INFO] [stdout] | ^^^^^ help: change this to: `item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/web.rs:239:46 [INFO] [stdout] | [INFO] [stdout] 239 | app_fim.path_from_web.retain(|x| *x != PathBuf::from(item)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/web.rs:253:8 [INFO] [stdout] | [INFO] [stdout] 253 | if app_fim.state == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `app_fim.state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/web.rs:262:38 [INFO] [stdout] | [INFO] [stdout] 262 | app_fim.path_from_web.retain(|x| *x != PathBuf::from(path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | if !fs::metadata("database.db").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("database.db").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> src/app.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | / match watch_directory_recursive(&inotify, path, &mut watched_dirs) { [INFO] [stdout] 73 | | _ => () [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 72 ~ watch_directory_recursive(&inotify, path, &mut watched_dirs); [INFO] [stdout] 73 + (); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> src/app.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | / match check_rec(&conn, path) { [INFO] [stdout] 77 | | _ => () [INFO] [stdout] 78 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 76 ~ check_rec(&conn, path); [INFO] [stdout] 77 + () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/app.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | if !fs::metadata("database.db").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("database.db").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> src/app.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | / match watch_directory_recursive(&inotify, path, &mut watched_dirs) { [INFO] [stdout] 73 | | _ => () [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 72 ~ watch_directory_recursive(&inotify, path, &mut watched_dirs); [INFO] [stdout] 73 + (); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> src/app.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | / match check_rec(&conn, path) { [INFO] [stdout] 77 | | _ => () [INFO] [stdout] 78 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 76 ~ check_rec(&conn, path); [INFO] [stdout] 77 + () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/app.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/app.rs:157:24 [INFO] [stdout] | [INFO] [stdout] 157 | if app_fim.state == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!app_fim.state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/app.rs:159:25 [INFO] [stdout] | [INFO] [stdout] 159 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_dir.rs:38:31 [INFO] [stdout] | [INFO] [stdout] 38 | watch_directory_recursive(&inotify, &complete_path, watched_dirs)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `inotify` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_dir.rs:38:41 [INFO] [stdout] | [INFO] [stdout] 38 | watch_directory_recursive(&inotify, &complete_path, watched_dirs)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `complete_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/event_dir.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 44 | complete_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 44 ~ complete_path: &Path, [INFO] [stdout] 45 | watched_dirs: &mut HashMap, [INFO] [stdout] ... [INFO] [stdout] 50 | for (key, value) in watched_dirs.iter() { [INFO] [stdout] 51 ~ if value.to_path_buf() == complete_path.to_path_buf() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/event_dir.rs:63:20 [INFO] [stdout] | [INFO] [stdout] 63 | complete_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - complete_path: &PathBuf, [INFO] [stdout] 63 + complete_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/app.rs:157:24 [INFO] [stdout] | [INFO] [stdout] 157 | if app_fim.state == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!app_fim.state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/app.rs:159:25 [INFO] [stdout] | [INFO] [stdout] 159 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/event_file.rs:28:39 [INFO] [stdout] | [INFO] [stdout] 28 | let buffer_new = match File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/event_file.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | if let Err(_) = file.read_to_end(&mut buffer) { [INFO] [stdout] | -------^^^^^^-------------------------------- help: try: `if file.read_to_end(&mut buffer).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/event_file.rs:53:11 [INFO] [stdout] | [INFO] [stdout] 53 | path: &PathBuf [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 53 - path: &PathBuf [INFO] [stdout] 53 + path: &Path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_dir.rs:38:31 [INFO] [stdout] | [INFO] [stdout] 38 | watch_directory_recursive(&inotify, &complete_path, watched_dirs)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `inotify` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/event_file.rs:65:33 [INFO] [stdout] | [INFO] [stdout] 65 | let copy = match File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_dir.rs:38:41 [INFO] [stdout] | [INFO] [stdout] 38 | watch_directory_recursive(&inotify, &complete_path, watched_dirs)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `complete_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/event_file.rs:68:20 [INFO] [stdout] | [INFO] [stdout] 68 | if let Err(_) = file.read_to_end(&mut buffer) { [INFO] [stdout] | -------^^^^^^-------------------------------- help: try: `if file.read_to_end(&mut buffer).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/event_dir.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 44 | complete_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 44 ~ complete_path: &Path, [INFO] [stdout] 45 | watched_dirs: &mut HashMap, [INFO] [stdout] ... [INFO] [stdout] 50 | for (key, value) in watched_dirs.iter() { [INFO] [stdout] 51 ~ if value.to_path_buf() == complete_path.to_path_buf() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/event_file.rs:92:47 [INFO] [stdout] | [INFO] [stdout] 92 | let buffer_file_create = match File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/event_file.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 95 | if let Err(_) = file.read_to_end(&mut buffer) { [INFO] [stdout] | -------^^^^^^-------------------------------- help: try: `if file.read_to_end(&mut buffer).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/event_dir.rs:63:20 [INFO] [stdout] | [INFO] [stdout] 63 | complete_path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - complete_path: &PathBuf, [INFO] [stdout] 63 + complete_path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/event_file.rs:116:11 [INFO] [stdout] | [INFO] [stdout] 116 | path: &PathBuf [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 116 - path: &PathBuf [INFO] [stdout] 116 + path: &Path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/event_file.rs:129:11 [INFO] [stdout] | [INFO] [stdout] 129 | path: &PathBuf [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 129 - path: &PathBuf [INFO] [stdout] 129 + path: &Path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/event_file.rs:28:39 [INFO] [stdout] | [INFO] [stdout] 28 | let buffer_new = match File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/event_file.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | if let Err(_) = file.read_to_end(&mut buffer) { [INFO] [stdout] | -------^^^^^^-------------------------------- help: try: `if file.read_to_end(&mut buffer).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:147:25 [INFO] [stdout] | [INFO] [stdout] 147 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:147:32 [INFO] [stdout] | [INFO] [stdout] 147 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/event_file.rs:53:11 [INFO] [stdout] | [INFO] [stdout] 53 | path: &PathBuf [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 53 - path: &PathBuf [INFO] [stdout] 53 + path: &Path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/event_file.rs:65:33 [INFO] [stdout] | [INFO] [stdout] 65 | let copy = match File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/event_file.rs:68:20 [INFO] [stdout] | [INFO] [stdout] 68 | if let Err(_) = file.read_to_end(&mut buffer) { [INFO] [stdout] | -------^^^^^^-------------------------------- help: try: `if file.read_to_end(&mut buffer).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/event_file.rs:92:47 [INFO] [stdout] | [INFO] [stdout] 92 | let buffer_file_create = match File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/event_file.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 95 | if let Err(_) = file.read_to_end(&mut buffer) { [INFO] [stdout] | -------^^^^^^-------------------------------- help: try: `if file.read_to_end(&mut buffer).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:157:17 [INFO] [stdout] | [INFO] [stdout] 157 | update_copy(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:157:24 [INFO] [stdout] | [INFO] [stdout] 157 | update_copy(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:167:25 [INFO] [stdout] | [INFO] [stdout] 167 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:167:32 [INFO] [stdout] | [INFO] [stdout] 167 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:177:17 [INFO] [stdout] | [INFO] [stdout] 177 | update_copy(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:177:24 [INFO] [stdout] | [INFO] [stdout] 177 | update_copy(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/event_file.rs:116:11 [INFO] [stdout] | [INFO] [stdout] 116 | path: &PathBuf [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 116 - path: &PathBuf [INFO] [stdout] 116 + path: &Path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/event_file.rs:129:11 [INFO] [stdout] | [INFO] [stdout] 129 | path: &PathBuf [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 129 - path: &PathBuf [INFO] [stdout] 129 + path: &Path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:187:25 [INFO] [stdout] | [INFO] [stdout] 187 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:187:32 [INFO] [stdout] | [INFO] [stdout] 187 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:190:21 [INFO] [stdout] | [INFO] [stdout] 190 | modify_file(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:190:28 [INFO] [stdout] | [INFO] [stdout] 190 | modify_file(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:201:25 [INFO] [stdout] | [INFO] [stdout] 201 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:201:32 [INFO] [stdout] | [INFO] [stdout] 201 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:147:25 [INFO] [stdout] | [INFO] [stdout] 147 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:147:32 [INFO] [stdout] | [INFO] [stdout] 147 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:211:17 [INFO] [stdout] | [INFO] [stdout] 211 | update_copy(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:211:24 [INFO] [stdout] | [INFO] [stdout] 211 | update_copy(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:157:17 [INFO] [stdout] | [INFO] [stdout] 157 | update_copy(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:222:25 [INFO] [stdout] | [INFO] [stdout] 222 | if !is_path_present(&conn, &path)? { [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:222:32 [INFO] [stdout] | [INFO] [stdout] 222 | if !is_path_present(&conn, &path)? { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:157:24 [INFO] [stdout] | [INFO] [stdout] 157 | update_copy(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:223:24 [INFO] [stdout] | [INFO] [stdout] 223 | create_file_db(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:223:31 [INFO] [stdout] | [INFO] [stdout] 223 | create_file_db(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:167:25 [INFO] [stdout] | [INFO] [stdout] 167 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:167:32 [INFO] [stdout] | [INFO] [stdout] 167 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:227:33 [INFO] [stdout] | [INFO] [stdout] 227 | "DELETE" => delete_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:227:40 [INFO] [stdout] | [INFO] [stdout] 227 | "DELETE" => delete_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:228:41 [INFO] [stdout] | [INFO] [stdout] 228 | "MOVED_FROM" => moved_from_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:228:48 [INFO] [stdout] | [INFO] [stdout] 228 | "MOVED_FROM" => moved_from_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:229:37 [INFO] [stdout] | [INFO] [stdout] 229 | "MOVED_TO" => moved_to_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:229:44 [INFO] [stdout] | [INFO] [stdout] 229 | "MOVED_TO" => moved_to_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:230:45 [INFO] [stdout] | [INFO] [stdout] 230 | "MAYBE_MODIFY" => maybe_modify_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:230:52 [INFO] [stdout] | [INFO] [stdout] 230 | "MAYBE_MODIFY" => maybe_modify_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:231:33 [INFO] [stdout] | [INFO] [stdout] 231 | "MODIFY" => modify_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:231:40 [INFO] [stdout] | [INFO] [stdout] 231 | "MODIFY" => modify_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:232:33 [INFO] [stdout] | [INFO] [stdout] 232 | "CREATE" => create_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:232:40 [INFO] [stdout] | [INFO] [stdout] 232 | "CREATE" => create_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:177:17 [INFO] [stdout] | [INFO] [stdout] 177 | update_copy(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:177:24 [INFO] [stdout] | [INFO] [stdout] 177 | update_copy(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:187:25 [INFO] [stdout] | [INFO] [stdout] 187 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:187:32 [INFO] [stdout] | [INFO] [stdout] 187 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:190:21 [INFO] [stdout] | [INFO] [stdout] 190 | modify_file(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:190:28 [INFO] [stdout] | [INFO] [stdout] 190 | modify_file(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:201:25 [INFO] [stdout] | [INFO] [stdout] 201 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:201:32 [INFO] [stdout] | [INFO] [stdout] 201 | let diff = get_diff(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:250:28 [INFO] [stdout] | [INFO] [stdout] 250 | check_file(&conn, &path, "MAYBE_MODIFY")?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:211:17 [INFO] [stdout] | [INFO] [stdout] 211 | update_copy(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:211:24 [INFO] [stdout] | [INFO] [stdout] 211 | update_copy(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:252:27 [INFO] [stdout] | [INFO] [stdout] 252 | check_rec(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:222:25 [INFO] [stdout] | [INFO] [stdout] 222 | if !is_path_present(&conn, &path)? { [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:222:32 [INFO] [stdout] | [INFO] [stdout] 222 | if !is_path_present(&conn, &path)? { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:223:24 [INFO] [stdout] | [INFO] [stdout] 223 | create_file_db(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:223:31 [INFO] [stdout] | [INFO] [stdout] 223 | create_file_db(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:227:33 [INFO] [stdout] | [INFO] [stdout] 227 | "DELETE" => delete_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:227:40 [INFO] [stdout] | [INFO] [stdout] 227 | "DELETE" => delete_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:228:41 [INFO] [stdout] | [INFO] [stdout] 228 | "MOVED_FROM" => moved_from_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:228:48 [INFO] [stdout] | [INFO] [stdout] 228 | "MOVED_FROM" => moved_from_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:229:37 [INFO] [stdout] | [INFO] [stdout] 229 | "MOVED_TO" => moved_to_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:229:44 [INFO] [stdout] | [INFO] [stdout] 229 | "MOVED_TO" => moved_to_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:230:45 [INFO] [stdout] | [INFO] [stdout] 230 | "MAYBE_MODIFY" => maybe_modify_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/watcher.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | / for entry in dir_entries { [INFO] [stdout] 50 | | if let Ok(entry) = entry { [INFO] [stdout] 51 | | watch_directory_recursive(inotify, &entry.path(), watched_dirs)?; [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/watcher.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | / if let Ok(entry) = entry { [INFO] [stdout] 51 | | watch_directory_recursive(inotify, &entry.path(), watched_dirs)?; [INFO] [stdout] 52 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 49 ~ for entry in dir_entries.flatten() { [INFO] [stdout] 50 + watch_directory_recursive(inotify, &entry.path(), watched_dirs)?; [INFO] [stdout] 51 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:230:52 [INFO] [stdout] | [INFO] [stdout] 230 | "MAYBE_MODIFY" => maybe_modify_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:231:33 [INFO] [stdout] | [INFO] [stdout] 231 | "MODIFY" => modify_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:231:40 [INFO] [stdout] | [INFO] [stdout] 231 | "MODIFY" => modify_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return Ok(()); [INFO] [stdout] 19 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:232:33 [INFO] [stdout] | [INFO] [stdout] 232 | "CREATE" => create_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:232:40 [INFO] [stdout] | [INFO] [stdout] 232 | "CREATE" => create_file(&conn, &path)?, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:250:28 [INFO] [stdout] | [INFO] [stdout] 250 | check_file(&conn, &path, "MAYBE_MODIFY")?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/event_file.rs:252:27 [INFO] [stdout] | [INFO] [stdout] 252 | check_rec(&conn, &path)?; [INFO] [stdout] | ^^^^^ help: change this to: `conn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/watcher.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | / for entry in dir_entries { [INFO] [stdout] 50 | | if let Ok(entry) = entry { [INFO] [stdout] 51 | | watch_directory_recursive(inotify, &entry.path(), watched_dirs)?; [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/watcher.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | / if let Ok(entry) = entry { [INFO] [stdout] 51 | | watch_directory_recursive(inotify, &entry.path(), watched_dirs)?; [INFO] [stdout] 52 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 49 ~ for entry in dir_entries.flatten() { [INFO] [stdout] 50 + watch_directory_recursive(inotify, &entry.path(), watched_dirs)?; [INFO] [stdout] 51 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return Ok(()); [INFO] [stdout] 19 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 34.71s [INFO] running `Command { std: "docker" "inspect" "0392971a6cc6e024da04f42ce064275268057ec662ec07fc3cd3c126c917059d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0392971a6cc6e024da04f42ce064275268057ec662ec07fc3cd3c126c917059d", kill_on_drop: false }` [INFO] [stdout] 0392971a6cc6e024da04f42ce064275268057ec662ec07fc3cd3c126c917059d