[INFO] cloning repository https://github.com/pjsph/advent_of_code_2024 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pjsph/advent_of_code_2024" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpjsph%2Fadvent_of_code_2024", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpjsph%2Fadvent_of_code_2024'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d9d6f2d42412c0c3b5ffc3281ad94ee80075b3ba [INFO] linting pjsph/advent_of_code_2024 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpjsph%2Fadvent_of_code_2024" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/pjsph/advent_of_code_2024 [INFO] finished tweaking git repo https://github.com/pjsph/advent_of_code_2024 [INFO] tweaked toml for git repo https://github.com/pjsph/advent_of_code_2024 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/pjsph/advent_of_code_2024 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/pjsph/advent_of_code_2024 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e8158e66225ad6f109f14f13df0926eff2b83cd329e19b871021798f53b15821 [INFO] running `Command { std: "docker" "start" "-a" "e8158e66225ad6f109f14f13df0926eff2b83cd329e19b871021798f53b15821", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e8158e66225ad6f109f14f13df0926eff2b83cd329e19b871021798f53b15821", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e8158e66225ad6f109f14f13df0926eff2b83cd329e19b871021798f53b15821", kill_on_drop: false }` [INFO] [stdout] e8158e66225ad6f109f14f13df0926eff2b83cd329e19b871021798f53b15821 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c76a5575e5a9d96ff3f926e4c213fcec16644f17f9d1d186b7abdc9352be732 [INFO] running `Command { std: "docker" "start" "-a" "4c76a5575e5a9d96ff3f926e4c213fcec16644f17f9d1d186b7abdc9352be732", kill_on_drop: false }` [INFO] [stderr] Checking advent_of_code_2024 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/day02/main.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | 'outer: for line_res in reader.lines() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_labels)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/day02/main.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | 'outer: for line_res in reader.lines() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/day02/main.rs:62:49 [INFO] [stdout] | [INFO] [stdout] 62 | fn check_line(numbers: &Vec) -> Result<(), (usize)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 62 - fn check_line(numbers: &Vec) -> Result<(), (usize)> { [INFO] [stdout] 62 + fn check_line(numbers: &Vec) -> Result<(), usize > { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HORIZONTAL_RIGHT` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 190 | HORIZONTAL_RIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HorizontalRight` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HORIZONTAL_LEFT` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:191:5 [INFO] [stdout] | [INFO] [stdout] 191 | HORIZONTAL_LEFT, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HorizontalLeft` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `VERTICAL_UP` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 192 | VERTICAL_UP, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `VerticalUp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `VERTICAL_DOWN` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 193 | VERTICAL_DOWN, [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `VerticalDown` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DIAGONAL_UPRIGHT` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:194:5 [INFO] [stdout] | [INFO] [stdout] 194 | DIAGONAL_UPRIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `DiagonalUpright` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DIAGONAL_UPLEFT` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 195 | DIAGONAL_UPLEFT, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `DiagonalUpleft` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DIAGONAL_DOWNRIGHT` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:196:5 [INFO] [stdout] | [INFO] [stdout] 196 | DIAGONAL_DOWNRIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `DiagonalDownright` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DIAGONAL_DOWNLEFT` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 197 | DIAGONAL_DOWNLEFT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `DiagonalDownleft` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/day05/main.rs:3:35 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{BufRead, BufReader, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/day02/main.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | 'outer: for line_res in reader.lines() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_labels)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/day02/main.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | 'outer: for line_res in reader.lines() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/day02/main.rs:62:49 [INFO] [stdout] | [INFO] [stdout] 62 | fn check_line(numbers: &Vec) -> Result<(), (usize)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 62 - fn check_line(numbers: &Vec) -> Result<(), (usize)> { [INFO] [stdout] 62 + fn check_line(numbers: &Vec) -> Result<(), usize > { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HORIZONTAL_RIGHT` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 190 | HORIZONTAL_RIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HorizontalRight` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HORIZONTAL_LEFT` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:191:5 [INFO] [stdout] | [INFO] [stdout] 191 | HORIZONTAL_LEFT, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HorizontalLeft` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `VERTICAL_UP` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 192 | VERTICAL_UP, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `VerticalUp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `VERTICAL_DOWN` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 193 | VERTICAL_DOWN, [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `VerticalDown` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DIAGONAL_UPRIGHT` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:194:5 [INFO] [stdout] | [INFO] [stdout] 194 | DIAGONAL_UPRIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `DiagonalUpright` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DIAGONAL_UPLEFT` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 195 | DIAGONAL_UPLEFT, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `DiagonalUpleft` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DIAGONAL_DOWNRIGHT` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:196:5 [INFO] [stdout] | [INFO] [stdout] 196 | DIAGONAL_DOWNRIGHT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `DiagonalDownright` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `DIAGONAL_DOWNLEFT` should have an upper camel case name [INFO] [stdout] --> src/day04/main.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 197 | DIAGONAL_DOWNLEFT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `DiagonalDownleft` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/day05/main.rs:3:35 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{BufRead, BufReader, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FACING_NORTH` should have an upper camel case name [INFO] [stdout] --> src/day06/main.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 242 | FACING_NORTH, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `FacingNorth` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FACING_EAST` should have an upper camel case name [INFO] [stdout] --> src/day06/main.rs:243:5 [INFO] [stdout] | [INFO] [stdout] 243 | FACING_EAST, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `FacingEast` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FACING_SOUTH` should have an upper camel case name [INFO] [stdout] --> src/day06/main.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 244 | FACING_SOUTH, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `FacingSouth` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FACING_WEST` should have an upper camel case name [INFO] [stdout] --> src/day06/main.rs:245:5 [INFO] [stdout] | [INFO] [stdout] 245 | FACING_WEST, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `FacingWest` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `OUT_OF_BOUND` should have an upper camel case name [INFO] [stdout] --> src/day06/main.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 255 | OUT_OF_BOUND, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `OutOfBound` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FACING_NORTH` should have an upper camel case name [INFO] [stdout] --> src/day06/main.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 242 | FACING_NORTH, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `FacingNorth` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FACING_EAST` should have an upper camel case name [INFO] [stdout] --> src/day06/main.rs:243:5 [INFO] [stdout] | [INFO] [stdout] 243 | FACING_EAST, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `FacingEast` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FACING_SOUTH` should have an upper camel case name [INFO] [stdout] --> src/day06/main.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 244 | FACING_SOUTH, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `FacingSouth` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FACING_WEST` should have an upper camel case name [INFO] [stdout] --> src/day06/main.rs:245:5 [INFO] [stdout] | [INFO] [stdout] 245 | FACING_WEST, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `FacingWest` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `OUT_OF_BOUND` should have an upper camel case name [INFO] [stdout] --> src/day06/main.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 255 | OUT_OF_BOUND, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `OutOfBound` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/day03/main.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | let mut start_index = curr_index; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `next_index` is never read [INFO] [stdout] --> src/day06/main.rs:201:33 [INFO] [stdout] | [INFO] [stdout] 201 | let mut next_index: usize = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/day01/main.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day01/main.rs:10:4 [INFO] [stdout] | [INFO] [stdout] 10 | fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day01/main.rs:35:4 [INFO] [stdout] | [INFO] [stdout] 35 | fn part2() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/day02/main.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day02/main.rs:9:4 [INFO] [stdout] | [INFO] [stdout] 9 | fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day02/main.rs:27:4 [INFO] [stdout] | [INFO] [stdout] 27 | fn part2() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check_line` is never used [INFO] [stdout] --> src/day02/main.rs:62:4 [INFO] [stdout] | [INFO] [stdout] 62 | fn check_line(numbers: &Vec) -> Result<(), (usize)> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/day03/main.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day03/main.rs:9:4 [INFO] [stdout] | [INFO] [stdout] 9 | fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day03/main.rs:41:4 [INFO] [stdout] | [INFO] [stdout] 41 | fn part2() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `try_consume_str` is never used [INFO] [stdout] --> src/day03/main.rs:87:4 [INFO] [stdout] | [INFO] [stdout] 87 | fn try_consume_str(input: &Vec, curr_index: &mut usize, token: &str) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `try_consume_alpha` is never used [INFO] [stdout] --> src/day03/main.rs:100:4 [INFO] [stdout] | [INFO] [stdout] 100 | fn try_consume_alpha(input: &Vec, curr_index: &mut usize) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `advance` is never used [INFO] [stdout] --> src/day03/main.rs:121:4 [INFO] [stdout] | [INFO] [stdout] 121 | fn advance(input: &Vec, curr_index: &mut usize) -> char { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `peek` is never used [INFO] [stdout] --> src/day03/main.rs:127:4 [INFO] [stdout] | [INFO] [stdout] 127 | fn peek(input: &Vec, curr_index: usize) -> char { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/day04/main.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day04/main.rs:9:4 [INFO] [stdout] | [INFO] [stdout] 9 | fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day04/main.rs:39:4 [INFO] [stdout] | [INFO] [stdout] 39 | fn part2() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check_validity` is never used [INFO] [stdout] --> src/day04/main.rs:74:4 [INFO] [stdout] | [INFO] [stdout] 74 | fn check_validity(len: usize, line_width: usize, center: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check_word` is never used [INFO] [stdout] --> src/day04/main.rs:91:4 [INFO] [stdout] | [INFO] [stdout] 91 | fn check_word(word_list: &Vec, word: &str, line_width: usize, index: usize, direction: CheckDirection) -> Result<(), ()> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `CheckDirection` is never used [INFO] [stdout] --> src/day04/main.rs:189:6 [INFO] [stdout] | [INFO] [stdout] 189 | enum CheckDirection { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `values` is never used [INFO] [stdout] --> src/day04/main.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 200 | impl CheckDirection { [INFO] [stdout] | ------------------- associated function in this implementation [INFO] [stdout] 201 | pub fn values() -> Vec { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day05/main.rs:10:4 [INFO] [stdout] | [INFO] [stdout] 10 | fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/day06/main.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day06/main.rs:9:4 [INFO] [stdout] | [INFO] [stdout] 9 | fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day06/main.rs:54:4 [INFO] [stdout] | [INFO] [stdout] 54 | fn part2() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `compute_path` is never used [INFO] [stdout] --> src/day06/main.rs:114:4 [INFO] [stdout] | [INFO] [stdout] 114 | fn compute_path( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `step` is never used [INFO] [stdout] --> src/day06/main.rs:165:4 [INFO] [stdout] | [INFO] [stdout] 165 | fn step( [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `turn_right` is never used [INFO] [stdout] --> src/day06/main.rs:186:4 [INFO] [stdout] | [INFO] [stdout] 186 | fn turn_right(direction: Direction) -> Direction { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `move_forward` is never used [INFO] [stdout] --> src/day06/main.rs:195:4 [INFO] [stdout] | [INFO] [stdout] 195 | fn move_forward( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Direction` is never used [INFO] [stdout] --> src/day06/main.rs:241:6 [INFO] [stdout] | [INFO] [stdout] 241 | enum Direction { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Action` is never used [INFO] [stdout] --> src/day06/main.rs:249:6 [INFO] [stdout] | [INFO] [stdout] 249 | enum Action { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `MoveError` is never used [INFO] [stdout] --> src/day06/main.rs:254:6 [INFO] [stdout] | [INFO] [stdout] 254 | enum MoveError { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `numbers1` [INFO] [stdout] --> src/day01/main.rs:57:14 [INFO] [stdout] | [INFO] [stdout] 57 | for i in 0..numbers1.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 57 - for i in 0..numbers1.len() { [INFO] [stdout] 57 + for in &numbers1 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/day02/main.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 46 | / match check_line(&corrected_numbers) { [INFO] [stdout] 47 | | Ok(()) => { [INFO] [stdout] 48 | | sum += 1; [INFO] [stdout] 49 | | break; [INFO] [stdout] 50 | | }, [INFO] [stdout] 51 | | Err(_) => {} [INFO] [stdout] 52 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 ~ if let Ok(()) = check_line(&corrected_numbers) { [INFO] [stdout] 47 + sum += 1; [INFO] [stdout] 48 + break; [INFO] [stdout] 49 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day02/main.rs:62:24 [INFO] [stdout] | [INFO] [stdout] 62 | fn check_line(numbers: &Vec) -> Result<(), (usize)> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 62 - fn check_line(numbers: &Vec) -> Result<(), (usize)> { [INFO] [stdout] 62 + fn check_line(numbers: &[i32]) -> Result<(), (usize)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/day03/main.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 74 | / if try_consume_str(&input, &mut curr_index, ")") { [INFO] [stdout] 75 | | if enabled { [INFO] [stdout] 76 | | count += a*b; [INFO] [stdout] 77 | | } [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if try_consume_str(&input, &mut curr_index, ")") [INFO] [stdout] 75 ~ && enabled { [INFO] [stdout] 76 | count += a*b; [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/day03/main.rs:103:11 [INFO] [stdout] | [INFO] [stdout] 103 | while peek(input, *curr_index).is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `peek(input, *curr_index).is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/day03/main.rs:112:50 [INFO] [stdout] | [INFO] [stdout] 112 | let parse = &input[start_index..*curr_index].into_iter().map(|c| c.to_digit(10)).try_fold(0, |ans, i| i.map(|i| ans * 10 + i)); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day03/main.rs:121:19 [INFO] [stdout] | [INFO] [stdout] 121 | fn advance(input: &Vec, curr_index: &mut usize) -> char { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 121 - fn advance(input: &Vec, curr_index: &mut usize) -> char { [INFO] [stdout] 121 + fn advance(input: &[char], curr_index: &mut usize) -> char { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day03/main.rs:127:16 [INFO] [stdout] | [INFO] [stdout] 127 | fn peek(input: &Vec, curr_index: usize) -> char { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 127 - fn peek(input: &Vec, curr_index: usize) -> char { [INFO] [stdout] 127 + fn peek(input: &[char], curr_index: usize) -> char { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day04/main.rs:91:26 [INFO] [stdout] | [INFO] [stdout] 91 | fn check_word(word_list: &Vec, word: &str, line_width: usize, index: usize, direction: CheckDirection) -> Result<(), ()> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 91 - fn check_word(word_list: &Vec, word: &str, line_width: usize, index: usize, direction: CheckDirection) -> Result<(), ()> { [INFO] [stdout] 91 + fn check_word(word_list: &[char], word: &str, line_width: usize, index: usize, direction: CheckDirection) -> Result<(), ()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/day05/main.rs:22:50 [INFO] [stdout] | [INFO] [stdout] 22 | let split_index = lines.iter().position(|el| el == "").unwrap(); [INFO] [stdout] | ^^^^^^^^ help: using `is_empty` is clearer and more explicit: `el.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/day05/main.rs:72:50 [INFO] [stdout] | [INFO] [stdout] 72 | let split_index = lines.iter().position(|el| el == "").unwrap(); [INFO] [stdout] | ^^^^^^^^ help: using `is_empty` is clearer and more explicit: `el.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `bad_updates` [INFO] [stdout] --> src/day05/main.rs:102:14 [INFO] [stdout] | [INFO] [stdout] 102 | for i in 0..bad_updates.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 102 - for i in 0..bad_updates.len() { [INFO] [stdout] 102 + for in &mut bad_updates { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `update` manually [INFO] [stdout] --> src/day05/main.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 119 | / let tmp = update[i]; [INFO] [stdout] 120 | | update[i] = update[j]; [INFO] [stdout] 121 | | update[j] = tmp; [INFO] [stdout] | |____________________________________^ help: try: `update.swap(i, j);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day05/main.rs:128:27 [INFO] [stdout] | [INFO] [stdout] 128 | fn is_update_good(update: &Vec, rules: &HashMap>) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 128 - fn is_update_good(update: &Vec, rules: &HashMap>) -> bool { [INFO] [stdout] 128 + fn is_update_good(update: &[u32], rules: &HashMap>) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `chars` [INFO] [stdout] --> src/day06/main.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | for i in 0..chars.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 29 - for i in 0..chars.len() { [INFO] [stdout] 29 + for (i, ) in chars.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day06/main.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 103 | if !compute_path(&new_chars, line_width, start_index, start_direction).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `compute_path(&new_chars, line_width, start_index, start_direction).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `chars` [INFO] [stdout] --> src/day06/main.rs:74:14 [INFO] [stdout] | [INFO] [stdout] 74 | for i in 0..chars.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 74 - for i in 0..chars.len() { [INFO] [stdout] 74 + for (i, ) in chars.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/day06/main.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/day06/main.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | / loop { [INFO] [stdout] 124 | | if let Ok(action) = step(chars, line_width, &mut curr_index, &mut curr_direction) { [INFO] [stdout] 125 | | match action { [INFO] [stdout] 126 | | Action::MOVE => { [INFO] [stdout] ... | [INFO] [stdout] 160 | | } [INFO] [stdout] | |_____^ help: try: `while let Ok(action) = step(chars, line_width, &mut curr_index, &mut curr_direction) { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day06/main.rs:196:12 [INFO] [stdout] | [INFO] [stdout] 196 | chars: &Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 196 - chars: &Vec, [INFO] [stdout] 196 + chars: &[char], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MOVE` contains a capitalized acronym [INFO] [stdout] --> src/day06/main.rs:250:5 [INFO] [stdout] | [INFO] [stdout] 250 | MOVE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Move` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TURN` contains a capitalized acronym [INFO] [stdout] --> src/day06/main.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 251 | TURN, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Turn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OBSTACLE` contains a capitalized acronym [INFO] [stdout] --> src/day06/main.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | OBSTACLE, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Obstacle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/day06/main.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | std::io::stdout().flush(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 100 | let _ = std::io::stdout().flush(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/day03/main.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | let mut start_index = curr_index; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `next_index` is never read [INFO] [stdout] --> src/day06/main.rs:201:33 [INFO] [stdout] | [INFO] [stdout] 201 | let mut next_index: usize = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/day01/main.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day01/main.rs:10:4 [INFO] [stdout] | [INFO] [stdout] 10 | fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day01/main.rs:35:4 [INFO] [stdout] | [INFO] [stdout] 35 | fn part2() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/day02/main.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day02/main.rs:9:4 [INFO] [stdout] | [INFO] [stdout] 9 | fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day02/main.rs:27:4 [INFO] [stdout] | [INFO] [stdout] 27 | fn part2() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check_line` is never used [INFO] [stdout] --> src/day02/main.rs:62:4 [INFO] [stdout] | [INFO] [stdout] 62 | fn check_line(numbers: &Vec) -> Result<(), (usize)> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/day03/main.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day03/main.rs:9:4 [INFO] [stdout] | [INFO] [stdout] 9 | fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day03/main.rs:41:4 [INFO] [stdout] | [INFO] [stdout] 41 | fn part2() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `try_consume_str` is never used [INFO] [stdout] --> src/day03/main.rs:87:4 [INFO] [stdout] | [INFO] [stdout] 87 | fn try_consume_str(input: &Vec, curr_index: &mut usize, token: &str) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `try_consume_alpha` is never used [INFO] [stdout] --> src/day03/main.rs:100:4 [INFO] [stdout] | [INFO] [stdout] 100 | fn try_consume_alpha(input: &Vec, curr_index: &mut usize) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `advance` is never used [INFO] [stdout] --> src/day03/main.rs:121:4 [INFO] [stdout] | [INFO] [stdout] 121 | fn advance(input: &Vec, curr_index: &mut usize) -> char { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `peek` is never used [INFO] [stdout] --> src/day03/main.rs:127:4 [INFO] [stdout] | [INFO] [stdout] 127 | fn peek(input: &Vec, curr_index: usize) -> char { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/day04/main.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day04/main.rs:9:4 [INFO] [stdout] | [INFO] [stdout] 9 | fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day04/main.rs:39:4 [INFO] [stdout] | [INFO] [stdout] 39 | fn part2() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check_validity` is never used [INFO] [stdout] --> src/day04/main.rs:74:4 [INFO] [stdout] | [INFO] [stdout] 74 | fn check_validity(len: usize, line_width: usize, center: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check_word` is never used [INFO] [stdout] --> src/day04/main.rs:91:4 [INFO] [stdout] | [INFO] [stdout] 91 | fn check_word(word_list: &Vec, word: &str, line_width: usize, index: usize, direction: CheckDirection) -> Result<(), ()> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `CheckDirection` is never used [INFO] [stdout] --> src/day04/main.rs:189:6 [INFO] [stdout] | [INFO] [stdout] 189 | enum CheckDirection { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `values` is never used [INFO] [stdout] --> src/day04/main.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 200 | impl CheckDirection { [INFO] [stdout] | ------------------- associated function in this implementation [INFO] [stdout] 201 | pub fn values() -> Vec { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day05/main.rs:10:4 [INFO] [stdout] | [INFO] [stdout] 10 | fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/day06/main.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day06/main.rs:9:4 [INFO] [stdout] | [INFO] [stdout] 9 | fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day06/main.rs:54:4 [INFO] [stdout] | [INFO] [stdout] 54 | fn part2() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `compute_path` is never used [INFO] [stdout] --> src/day06/main.rs:114:4 [INFO] [stdout] | [INFO] [stdout] 114 | fn compute_path( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `step` is never used [INFO] [stdout] --> src/day06/main.rs:165:4 [INFO] [stdout] | [INFO] [stdout] 165 | fn step( [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `turn_right` is never used [INFO] [stdout] --> src/day06/main.rs:186:4 [INFO] [stdout] | [INFO] [stdout] 186 | fn turn_right(direction: Direction) -> Direction { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `move_forward` is never used [INFO] [stdout] --> src/day06/main.rs:195:4 [INFO] [stdout] | [INFO] [stdout] 195 | fn move_forward( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Direction` is never used [INFO] [stdout] --> src/day06/main.rs:241:6 [INFO] [stdout] | [INFO] [stdout] 241 | enum Direction { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Action` is never used [INFO] [stdout] --> src/day06/main.rs:249:6 [INFO] [stdout] | [INFO] [stdout] 249 | enum Action { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `MoveError` is never used [INFO] [stdout] --> src/day06/main.rs:254:6 [INFO] [stdout] | [INFO] [stdout] 254 | enum MoveError { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `numbers1` [INFO] [stdout] --> src/day01/main.rs:57:14 [INFO] [stdout] | [INFO] [stdout] 57 | for i in 0..numbers1.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 57 - for i in 0..numbers1.len() { [INFO] [stdout] 57 + for in &numbers1 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/day02/main.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 46 | / match check_line(&corrected_numbers) { [INFO] [stdout] 47 | | Ok(()) => { [INFO] [stdout] 48 | | sum += 1; [INFO] [stdout] 49 | | break; [INFO] [stdout] 50 | | }, [INFO] [stdout] 51 | | Err(_) => {} [INFO] [stdout] 52 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 ~ if let Ok(()) = check_line(&corrected_numbers) { [INFO] [stdout] 47 + sum += 1; [INFO] [stdout] 48 + break; [INFO] [stdout] 49 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day02/main.rs:62:24 [INFO] [stdout] | [INFO] [stdout] 62 | fn check_line(numbers: &Vec) -> Result<(), (usize)> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 62 - fn check_line(numbers: &Vec) -> Result<(), (usize)> { [INFO] [stdout] 62 + fn check_line(numbers: &[i32]) -> Result<(), (usize)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/day03/main.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 74 | / if try_consume_str(&input, &mut curr_index, ")") { [INFO] [stdout] 75 | | if enabled { [INFO] [stdout] 76 | | count += a*b; [INFO] [stdout] 77 | | } [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if try_consume_str(&input, &mut curr_index, ")") [INFO] [stdout] 75 ~ && enabled { [INFO] [stdout] 76 | count += a*b; [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/day03/main.rs:103:11 [INFO] [stdout] | [INFO] [stdout] 103 | while peek(input, *curr_index).is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `peek(input, *curr_index).is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/day03/main.rs:112:50 [INFO] [stdout] | [INFO] [stdout] 112 | let parse = &input[start_index..*curr_index].into_iter().map(|c| c.to_digit(10)).try_fold(0, |ans, i| i.map(|i| ans * 10 + i)); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day03/main.rs:121:19 [INFO] [stdout] | [INFO] [stdout] 121 | fn advance(input: &Vec, curr_index: &mut usize) -> char { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 121 - fn advance(input: &Vec, curr_index: &mut usize) -> char { [INFO] [stdout] 121 + fn advance(input: &[char], curr_index: &mut usize) -> char { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day03/main.rs:127:16 [INFO] [stdout] | [INFO] [stdout] 127 | fn peek(input: &Vec, curr_index: usize) -> char { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 127 - fn peek(input: &Vec, curr_index: usize) -> char { [INFO] [stdout] 127 + fn peek(input: &[char], curr_index: usize) -> char { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day04/main.rs:91:26 [INFO] [stdout] | [INFO] [stdout] 91 | fn check_word(word_list: &Vec, word: &str, line_width: usize, index: usize, direction: CheckDirection) -> Result<(), ()> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 91 - fn check_word(word_list: &Vec, word: &str, line_width: usize, index: usize, direction: CheckDirection) -> Result<(), ()> { [INFO] [stdout] 91 + fn check_word(word_list: &[char], word: &str, line_width: usize, index: usize, direction: CheckDirection) -> Result<(), ()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/day05/main.rs:22:50 [INFO] [stdout] | [INFO] [stdout] 22 | let split_index = lines.iter().position(|el| el == "").unwrap(); [INFO] [stdout] | ^^^^^^^^ help: using `is_empty` is clearer and more explicit: `el.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/day05/main.rs:72:50 [INFO] [stdout] | [INFO] [stdout] 72 | let split_index = lines.iter().position(|el| el == "").unwrap(); [INFO] [stdout] | ^^^^^^^^ help: using `is_empty` is clearer and more explicit: `el.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `bad_updates` [INFO] [stdout] --> src/day05/main.rs:102:14 [INFO] [stdout] | [INFO] [stdout] 102 | for i in 0..bad_updates.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 102 - for i in 0..bad_updates.len() { [INFO] [stdout] 102 + for in &mut bad_updates { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `update` manually [INFO] [stdout] --> src/day05/main.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 119 | / let tmp = update[i]; [INFO] [stdout] 120 | | update[i] = update[j]; [INFO] [stdout] 121 | | update[j] = tmp; [INFO] [stdout] | |____________________________________^ help: try: `update.swap(i, j);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day05/main.rs:128:27 [INFO] [stdout] | [INFO] [stdout] 128 | fn is_update_good(update: &Vec, rules: &HashMap>) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 128 - fn is_update_good(update: &Vec, rules: &HashMap>) -> bool { [INFO] [stdout] 128 + fn is_update_good(update: &[u32], rules: &HashMap>) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `chars` [INFO] [stdout] --> src/day06/main.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | for i in 0..chars.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 29 - for i in 0..chars.len() { [INFO] [stdout] 29 + for (i, ) in chars.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day06/main.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 103 | if !compute_path(&new_chars, line_width, start_index, start_direction).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `compute_path(&new_chars, line_width, start_index, start_direction).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `chars` [INFO] [stdout] --> src/day06/main.rs:74:14 [INFO] [stdout] | [INFO] [stdout] 74 | for i in 0..chars.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 74 - for i in 0..chars.len() { [INFO] [stdout] 74 + for (i, ) in chars.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/day06/main.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/day06/main.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | / loop { [INFO] [stdout] 124 | | if let Ok(action) = step(chars, line_width, &mut curr_index, &mut curr_direction) { [INFO] [stdout] 125 | | match action { [INFO] [stdout] 126 | | Action::MOVE => { [INFO] [stdout] ... | [INFO] [stdout] 160 | | } [INFO] [stdout] | |_____^ help: try: `while let Ok(action) = step(chars, line_width, &mut curr_index, &mut curr_direction) { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day06/main.rs:196:12 [INFO] [stdout] | [INFO] [stdout] 196 | chars: &Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 196 - chars: &Vec, [INFO] [stdout] 196 + chars: &[char], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MOVE` contains a capitalized acronym [INFO] [stdout] --> src/day06/main.rs:250:5 [INFO] [stdout] | [INFO] [stdout] 250 | MOVE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Move` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TURN` contains a capitalized acronym [INFO] [stdout] --> src/day06/main.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 251 | TURN, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Turn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OBSTACLE` contains a capitalized acronym [INFO] [stdout] --> src/day06/main.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | OBSTACLE, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Obstacle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/day06/main.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | std::io::stdout().flush(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 100 | let _ = std::io::stdout().flush(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.45s [INFO] running `Command { std: "docker" "inspect" "4c76a5575e5a9d96ff3f926e4c213fcec16644f17f9d1d186b7abdc9352be732", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c76a5575e5a9d96ff3f926e4c213fcec16644f17f9d1d186b7abdc9352be732", kill_on_drop: false }` [INFO] [stdout] 4c76a5575e5a9d96ff3f926e4c213fcec16644f17f9d1d186b7abdc9352be732