[INFO] cloning repository https://github.com/pirr/kalah [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pirr/kalah" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpirr%2Fkalah", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpirr%2Fkalah'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ca104960b081349ccf973520938eb4e181a92552 [INFO] linting pirr/kalah against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpirr%2Fkalah" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/pirr/kalah [INFO] finished tweaking git repo https://github.com/pirr/kalah [INFO] tweaked toml for git repo https://github.com/pirr/kalah written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/pirr/kalah on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/pirr/kalah already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded instability v0.3.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f79c5793cd8a82dbfb7df280bea200ec89442fce1f414fbd42bd98af375b8e87 [INFO] running `Command { std: "docker" "start" "-a" "f79c5793cd8a82dbfb7df280bea200ec89442fce1f414fbd42bd98af375b8e87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f79c5793cd8a82dbfb7df280bea200ec89442fce1f414fbd42bd98af375b8e87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f79c5793cd8a82dbfb7df280bea200ec89442fce1f414fbd42bd98af375b8e87", kill_on_drop: false }` [INFO] [stdout] f79c5793cd8a82dbfb7df280bea200ec89442fce1f414fbd42bd98af375b8e87 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fcc22f75409894099902cf76499ee15f6c1fadf23660e412b22c0ba6fc72b93d [INFO] running `Command { std: "docker" "start" "-a" "fcc22f75409894099902cf76499ee15f6c1fadf23660e412b22c0ba6fc72b93d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking strum v0.27.1 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking rand v0.9.1 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling strum_macros v0.27.1 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling instability v0.3.7 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking kalah v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/game/game_process.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | game_field: game_field, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/game/game_process.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | game_config: game_config, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game/game_field.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / return GameField { [INFO] [stdout] 62 | | side_one, [INFO] [stdout] 63 | | side_two, [INFO] [stdout] 64 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ GameField { [INFO] [stdout] 62 + side_one, [INFO] [stdout] 63 + side_two, [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/game/game_process.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::usize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/game/game_process.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 34 | / let game_process = GameProcess { [INFO] [stdout] 35 | | player_one: Player { [INFO] [stdout] 36 | | name: player_one_name, [INFO] [stdout] 37 | | score: 0 [INFO] [stdout] ... | [INFO] [stdout] 52 | | game_finished: false, [INFO] [stdout] 53 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 54 | [INFO] [stdout] 55 | game_process [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 34 ~ [INFO] [stdout] 35 | [INFO] [stdout] 36 ~ GameProcess { [INFO] [stdout] 37 + player_one: Player { [INFO] [stdout] 38 + name: player_one_name, [INFO] [stdout] 39 + score: 0 [INFO] [stdout] 40 + }, [INFO] [stdout] 41 + player_two: Player { [INFO] [stdout] 42 + name: player_two_name, [INFO] [stdout] 43 + score: 0 [INFO] [stdout] 44 + }, [INFO] [stdout] 45 + game_field: game_field, [INFO] [stdout] 46 + game_config: game_config, [INFO] [stdout] 47 + is_player_one_turn: true, [INFO] [stdout] 48 + total_turns: 0, [INFO] [stdout] 49 + #[cfg(feature = "test_hooks")] [INFO] [stdout] 50 + swap_side_called: false, [INFO] [stdout] 51 + #[cfg(feature = "test_hooks")] [INFO] [stdout] 52 + swap_players_called: false, [INFO] [stdout] 53 + #[cfg(feature = "test_hooks")] [INFO] [stdout] 54 + game_finished: false, [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop [INFO] [stdout] --> src/game/game_process.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | let stone = stones.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some [INFO] [stdout] = note: `#[warn(clippy::manual_while_let_some)]` on by default [INFO] [stdout] help: consider using a `while..let` loop [INFO] [stdout] | [INFO] [stdout] 91 ~ while let Some(stone) = stones.pop() { [INFO] [stdout] 92 | [INFO] [stdout] 93 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game/game_process.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return is_empty_side; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return is_empty_side; [INFO] [stdout] 185 + is_empty_side [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).any(identity)` [INFO] [stdout] --> src/game/game_process.rs:175:14 [INFO] [stdout] | [INFO] [stdout] 175 | .map(|holes| { [INFO] [stdout] | ______________^ [INFO] [stdout] 176 | | holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] 177 | | }) [INFO] [stdout] 178 | | .any(|is_empty| is_empty); [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] = note: `#[warn(clippy::map_all_any_identity)]` on by default [INFO] [stdout] help: use `.any(...)` instead [INFO] [stdout] | [INFO] [stdout] 175 ~ .any(|holes| { [INFO] [stdout] 176 + holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] 177 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/game/game_process.rs:176:17 [INFO] [stdout] | [INFO] [stdout] 176 | holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `holes.iter().find(|hole| hole.stones.len() > 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/game/game_process.rs:176:44 [INFO] [stdout] | [INFO] [stdout] 176 | holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!hole.stones.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/game_process.rs:218:17 [INFO] [stdout] | [INFO] [stdout] 218 | else if !(self.is_player_one_turn && active_side == 2) && !(!self.is_player_one_turn && active_side == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(self.is_player_one_turn && active_side == 2 || !self.is_player_one_turn && active_side == 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/game_process.rs:218:67 [INFO] [stdout] | [INFO] [stdout] 218 | else if !(self.is_player_one_turn && active_side == 2) && !(!self.is_player_one_turn && active_side == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.is_player_one_turn || active_side != 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game/game_process.rs:214:28 [INFO] [stdout] | [INFO] [stdout] 214 | if hole_index != 0 { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 215 | | self.is_player_one_turn = !self.is_player_one_turn; [INFO] [stdout] 216 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game/game_process.rs:218:115 [INFO] [stdout] | [INFO] [stdout] 218 | else if !(self.is_player_one_turn && active_side == 2) && !(!self.is_player_one_turn && active_side == 1) { [INFO] [stdout] | ___________________________________________________________________________________________________________________^ [INFO] [stdout] 219 | | self.is_player_one_turn = !self.is_player_one_turn; [INFO] [stdout] 220 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/game/game_process.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | game_field: game_field, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/game/game_process.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | game_config: game_config, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/game/game_process.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | game_field: game_field, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/game/game_process.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | game_config: game_config, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/game/game_process.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | game_field: game_field, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/game/game_process.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | game_config: game_config, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game/game_field.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / return GameField { [INFO] [stdout] 62 | | side_one, [INFO] [stdout] 63 | | side_two, [INFO] [stdout] 64 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ GameField { [INFO] [stdout] 62 + side_one, [INFO] [stdout] 63 + side_two, [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/game/game_process.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::usize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/main.rs:134:33 [INFO] [stdout] | [INFO] [stdout] 134 | ... Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/game/game_process.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 34 | / let game_process = GameProcess { [INFO] [stdout] 35 | | player_one: Player { [INFO] [stdout] 36 | | name: player_one_name, [INFO] [stdout] 37 | | score: 0 [INFO] [stdout] ... | [INFO] [stdout] 52 | | game_finished: false, [INFO] [stdout] 53 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 54 | [INFO] [stdout] 55 | game_process [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 34 ~ [INFO] [stdout] 35 | [INFO] [stdout] 36 ~ GameProcess { [INFO] [stdout] 37 + player_one: Player { [INFO] [stdout] 38 + name: player_one_name, [INFO] [stdout] 39 + score: 0 [INFO] [stdout] 40 + }, [INFO] [stdout] 41 + player_two: Player { [INFO] [stdout] 42 + name: player_two_name, [INFO] [stdout] 43 + score: 0 [INFO] [stdout] 44 + }, [INFO] [stdout] 45 + game_field: game_field, [INFO] [stdout] 46 + game_config: game_config, [INFO] [stdout] 47 + is_player_one_turn: true, [INFO] [stdout] 48 + total_turns: 0, [INFO] [stdout] 49 + #[cfg(feature = "test_hooks")] [INFO] [stdout] 50 + swap_side_called: false, [INFO] [stdout] 51 + #[cfg(feature = "test_hooks")] [INFO] [stdout] 52 + swap_players_called: false, [INFO] [stdout] 53 + #[cfg(feature = "test_hooks")] [INFO] [stdout] 54 + game_finished: false, [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop [INFO] [stdout] --> src/game/game_process.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | let stone = stones.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some [INFO] [stdout] = note: `#[warn(clippy::manual_while_let_some)]` on by default [INFO] [stdout] help: consider using a `while..let` loop [INFO] [stdout] | [INFO] [stdout] 91 ~ while let Some(stone) = stones.pop() { [INFO] [stdout] 92 | [INFO] [stdout] 93 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game/game_field.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / return GameField { [INFO] [stdout] 62 | | side_one, [INFO] [stdout] 63 | | side_two, [INFO] [stdout] 64 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ GameField { [INFO] [stdout] 62 + side_one, [INFO] [stdout] 63 + side_two, [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/game/game_process.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::usize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/game/game_process.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 34 | / let game_process = GameProcess { [INFO] [stdout] 35 | | player_one: Player { [INFO] [stdout] 36 | | name: player_one_name, [INFO] [stdout] 37 | | score: 0 [INFO] [stdout] ... | [INFO] [stdout] 52 | | game_finished: false, [INFO] [stdout] 53 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 54 | [INFO] [stdout] 55 | game_process [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 34 ~ [INFO] [stdout] 35 | [INFO] [stdout] 36 ~ GameProcess { [INFO] [stdout] 37 + player_one: Player { [INFO] [stdout] 38 + name: player_one_name, [INFO] [stdout] 39 + score: 0 [INFO] [stdout] 40 + }, [INFO] [stdout] 41 + player_two: Player { [INFO] [stdout] 42 + name: player_two_name, [INFO] [stdout] 43 + score: 0 [INFO] [stdout] 44 + }, [INFO] [stdout] 45 + game_field: game_field, [INFO] [stdout] 46 + game_config: game_config, [INFO] [stdout] 47 + is_player_one_turn: true, [INFO] [stdout] 48 + total_turns: 0, [INFO] [stdout] 49 + #[cfg(feature = "test_hooks")] [INFO] [stdout] 50 + swap_side_called: false, [INFO] [stdout] 51 + #[cfg(feature = "test_hooks")] [INFO] [stdout] 52 + swap_players_called: false, [INFO] [stdout] 53 + #[cfg(feature = "test_hooks")] [INFO] [stdout] 54 + game_finished: false, [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game/game_process.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return is_empty_side; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return is_empty_side; [INFO] [stdout] 185 + is_empty_side [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).any(identity)` [INFO] [stdout] --> src/game/game_process.rs:175:14 [INFO] [stdout] | [INFO] [stdout] 175 | .map(|holes| { [INFO] [stdout] | ______________^ [INFO] [stdout] 176 | | holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] 177 | | }) [INFO] [stdout] 178 | | .any(|is_empty| is_empty); [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] = note: `#[warn(clippy::map_all_any_identity)]` on by default [INFO] [stdout] help: use `.any(...)` instead [INFO] [stdout] | [INFO] [stdout] 175 ~ .any(|holes| { [INFO] [stdout] 176 + holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] 177 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/game/game_process.rs:176:17 [INFO] [stdout] | [INFO] [stdout] 176 | holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `holes.iter().find(|hole| hole.stones.len() > 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/game/game_process.rs:176:44 [INFO] [stdout] | [INFO] [stdout] 176 | holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!hole.stones.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop [INFO] [stdout] --> src/game/game_process.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | let stone = stones.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some [INFO] [stdout] = note: `#[warn(clippy::manual_while_let_some)]` on by default [INFO] [stdout] help: consider using a `while..let` loop [INFO] [stdout] | [INFO] [stdout] 91 ~ while let Some(stone) = stones.pop() { [INFO] [stdout] 92 | [INFO] [stdout] 93 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/game_process.rs:218:17 [INFO] [stdout] | [INFO] [stdout] 218 | else if !(self.is_player_one_turn && active_side == 2) && !(!self.is_player_one_turn && active_side == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(self.is_player_one_turn && active_side == 2 || !self.is_player_one_turn && active_side == 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/game_process.rs:218:67 [INFO] [stdout] | [INFO] [stdout] 218 | else if !(self.is_player_one_turn && active_side == 2) && !(!self.is_player_one_turn && active_side == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.is_player_one_turn || active_side != 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game/game_process.rs:214:28 [INFO] [stdout] | [INFO] [stdout] 214 | if hole_index != 0 { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 215 | | self.is_player_one_turn = !self.is_player_one_turn; [INFO] [stdout] 216 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game/game_process.rs:218:115 [INFO] [stdout] | [INFO] [stdout] 218 | else if !(self.is_player_one_turn && active_side == 2) && !(!self.is_player_one_turn && active_side == 1) { [INFO] [stdout] | ___________________________________________________________________________________________________________________^ [INFO] [stdout] 219 | | self.is_player_one_turn = !self.is_player_one_turn; [INFO] [stdout] 220 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game/game_process.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return is_empty_side; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return is_empty_side; [INFO] [stdout] 185 + is_empty_side [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).any(identity)` [INFO] [stdout] --> src/game/game_process.rs:175:14 [INFO] [stdout] | [INFO] [stdout] 175 | .map(|holes| { [INFO] [stdout] | ______________^ [INFO] [stdout] 176 | | holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] 177 | | }) [INFO] [stdout] 178 | | .any(|is_empty| is_empty); [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] = note: `#[warn(clippy::map_all_any_identity)]` on by default [INFO] [stdout] help: use `.any(...)` instead [INFO] [stdout] | [INFO] [stdout] 175 ~ .any(|holes| { [INFO] [stdout] 176 + holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] 177 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/game/game_process.rs:176:17 [INFO] [stdout] | [INFO] [stdout] 176 | holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `holes.iter().find(|hole| hole.stones.len() > 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/game/game_process.rs:176:44 [INFO] [stdout] | [INFO] [stdout] 176 | holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!hole.stones.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/game_process.rs:218:17 [INFO] [stdout] | [INFO] [stdout] 218 | else if !(self.is_player_one_turn && active_side == 2) && !(!self.is_player_one_turn && active_side == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(self.is_player_one_turn && active_side == 2 || !self.is_player_one_turn && active_side == 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/game_process.rs:218:67 [INFO] [stdout] | [INFO] [stdout] 218 | else if !(self.is_player_one_turn && active_side == 2) && !(!self.is_player_one_turn && active_side == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.is_player_one_turn || active_side != 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game/game_process.rs:214:28 [INFO] [stdout] | [INFO] [stdout] 214 | if hole_index != 0 { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 215 | | self.is_player_one_turn = !self.is_player_one_turn; [INFO] [stdout] 216 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game/game_process.rs:218:115 [INFO] [stdout] | [INFO] [stdout] 218 | else if !(self.is_player_one_turn && active_side == 2) && !(!self.is_player_one_turn && active_side == 1) { [INFO] [stdout] | ___________________________________________________________________________________________________________________^ [INFO] [stdout] 219 | | self.is_player_one_turn = !self.is_player_one_turn; [INFO] [stdout] 220 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/main.rs:79:64 [INFO] [stdout] | [INFO] [stdout] 79 | let top_row = Paragraph::new(format!("{}: {}", "P2".to_string(), side_strs_str[1])); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/main.rs:80:102 [INFO] [stdout] | [INFO] [stdout] 80 | let bottom_row = Paragraph::new(format!("{}{}: {}", " ".repeat(4), side_strs_str[0], "P1".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | / if event::poll(std::time::Duration::from_millis(200))? { [INFO] [stdout] 98 | | if let Event::Key(key) = event::read()? { [INFO] [stdout] 99 | | match key.code { [INFO] [stdout] ... | [INFO] [stdout] 147 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 97 ~ if event::poll(std::time::Duration::from_millis(200))? [INFO] [stdout] 98 ~ && let Event::Key(key) = event::read()? { [INFO] [stdout] 99 | match key.code { [INFO] [stdout] ... [INFO] [stdout] 145 | } [INFO] [stdout] 146 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/main.rs:134:33 [INFO] [stdout] | [INFO] [stdout] 134 | ... Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game/game_field.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / return GameField { [INFO] [stdout] 62 | | side_one, [INFO] [stdout] 63 | | side_two, [INFO] [stdout] 64 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ GameField { [INFO] [stdout] 62 + side_one, [INFO] [stdout] 63 + side_two, [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/game/game_process.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::usize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/game/game_process.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 34 | / let game_process = GameProcess { [INFO] [stdout] 35 | | player_one: Player { [INFO] [stdout] 36 | | name: player_one_name, [INFO] [stdout] 37 | | score: 0 [INFO] [stdout] ... | [INFO] [stdout] 52 | | game_finished: false, [INFO] [stdout] 53 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 54 | [INFO] [stdout] 55 | game_process [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 34 ~ [INFO] [stdout] 35 | [INFO] [stdout] 36 ~ GameProcess { [INFO] [stdout] 37 + player_one: Player { [INFO] [stdout] 38 + name: player_one_name, [INFO] [stdout] 39 + score: 0 [INFO] [stdout] 40 + }, [INFO] [stdout] 41 + player_two: Player { [INFO] [stdout] 42 + name: player_two_name, [INFO] [stdout] 43 + score: 0 [INFO] [stdout] 44 + }, [INFO] [stdout] 45 + game_field: game_field, [INFO] [stdout] 46 + game_config: game_config, [INFO] [stdout] 47 + is_player_one_turn: true, [INFO] [stdout] 48 + total_turns: 0, [INFO] [stdout] 49 + #[cfg(feature = "test_hooks")] [INFO] [stdout] 50 + swap_side_called: false, [INFO] [stdout] 51 + #[cfg(feature = "test_hooks")] [INFO] [stdout] 52 + swap_players_called: false, [INFO] [stdout] 53 + #[cfg(feature = "test_hooks")] [INFO] [stdout] 54 + game_finished: false, [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop [INFO] [stdout] --> src/game/game_process.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | let stone = stones.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some [INFO] [stdout] = note: `#[warn(clippy::manual_while_let_some)]` on by default [INFO] [stdout] help: consider using a `while..let` loop [INFO] [stdout] | [INFO] [stdout] 91 ~ while let Some(stone) = stones.pop() { [INFO] [stdout] 92 | [INFO] [stdout] 93 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game/game_process.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return is_empty_side; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return is_empty_side; [INFO] [stdout] 185 + is_empty_side [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `.map(...).any(identity)` [INFO] [stdout] --> src/game/game_process.rs:175:14 [INFO] [stdout] | [INFO] [stdout] 175 | .map(|holes| { [INFO] [stdout] | ______________^ [INFO] [stdout] 176 | | holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] 177 | | }) [INFO] [stdout] 178 | | .any(|is_empty| is_empty); [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_all_any_identity [INFO] [stdout] = note: `#[warn(clippy::map_all_any_identity)]` on by default [INFO] [stdout] help: use `.any(...)` instead [INFO] [stdout] | [INFO] [stdout] 175 ~ .any(|holes| { [INFO] [stdout] 176 + holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] 177 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/game/game_process.rs:176:17 [INFO] [stdout] | [INFO] [stdout] 176 | holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `holes.iter().find(|hole| hole.stones.len() > 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/game/game_process.rs:176:44 [INFO] [stdout] | [INFO] [stdout] 176 | holes.iter().filter(|hole| hole.stones.len() > 0).next().is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!hole.stones.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/game_process.rs:218:17 [INFO] [stdout] | [INFO] [stdout] 218 | else if !(self.is_player_one_turn && active_side == 2) && !(!self.is_player_one_turn && active_side == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(self.is_player_one_turn && active_side == 2 || !self.is_player_one_turn && active_side == 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/game_process.rs:218:67 [INFO] [stdout] | [INFO] [stdout] 218 | else if !(self.is_player_one_turn && active_side == 2) && !(!self.is_player_one_turn && active_side == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.is_player_one_turn || active_side != 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game/game_process.rs:214:28 [INFO] [stdout] | [INFO] [stdout] 214 | if hole_index != 0 { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 215 | | self.is_player_one_turn = !self.is_player_one_turn; [INFO] [stdout] 216 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game/game_process.rs:218:115 [INFO] [stdout] | [INFO] [stdout] 218 | else if !(self.is_player_one_turn && active_side == 2) && !(!self.is_player_one_turn && active_side == 1) { [INFO] [stdout] | ___________________________________________________________________________________________________________________^ [INFO] [stdout] 219 | | self.is_player_one_turn = !self.is_player_one_turn; [INFO] [stdout] 220 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/main.rs:79:64 [INFO] [stdout] | [INFO] [stdout] 79 | let top_row = Paragraph::new(format!("{}: {}", "P2".to_string(), side_strs_str[1])); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/main.rs:80:102 [INFO] [stdout] | [INFO] [stdout] 80 | let bottom_row = Paragraph::new(format!("{}{}: {}", " ".repeat(4), side_strs_str[0], "P1".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | / if event::poll(std::time::Duration::from_millis(200))? { [INFO] [stdout] 98 | | if let Event::Key(key) = event::read()? { [INFO] [stdout] 99 | | match key.code { [INFO] [stdout] ... | [INFO] [stdout] 147 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 97 ~ if event::poll(std::time::Duration::from_millis(200))? [INFO] [stdout] 98 ~ && let Event::Key(key) = event::read()? { [INFO] [stdout] 99 | match key.code { [INFO] [stdout] ... [INFO] [stdout] 145 | } [INFO] [stdout] 146 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.41s [INFO] running `Command { std: "docker" "inspect" "fcc22f75409894099902cf76499ee15f6c1fadf23660e412b22c0ba6fc72b93d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcc22f75409894099902cf76499ee15f6c1fadf23660e412b22c0ba6fc72b93d", kill_on_drop: false }` [INFO] [stdout] fcc22f75409894099902cf76499ee15f6c1fadf23660e412b22c0ba6fc72b93d