[INFO] cloning repository https://github.com/pimpale/rust-chunks
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pimpale/rust-chunks" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpimpale%2Frust-chunks", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpimpale%2Frust-chunks'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 1407191aba754e26cffe4667744aa50daf166ac7
[INFO] linting pimpale/rust-chunks against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpimpale%2Frust-chunks" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/pimpale/rust-chunks
[INFO] finished tweaking git repo https://github.com/pimpale/rust-chunks
[INFO] tweaked toml for git repo https://github.com/pimpale/rust-chunks written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/pimpale/rust-chunks on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]      Locking 1 package to latest compatible version
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 0bb816b57065acc232e65b2fa7fbb6db2db061029f0f607c0cc7836cea37fd70
[INFO] running `Command { std: "docker" "start" "-a" "0bb816b57065acc232e65b2fa7fbb6db2db061029f0f607c0cc7836cea37fd70", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "0bb816b57065acc232e65b2fa7fbb6db2db061029f0f607c0cc7836cea37fd70", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "0bb816b57065acc232e65b2fa7fbb6db2db061029f0f607c0cc7836cea37fd70", kill_on_drop: false }`
[INFO] [stdout] 0bb816b57065acc232e65b2fa7fbb6db2db061029f0f607c0cc7836cea37fd70
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 666b4ab666356f75e34581d430a5b1c725e2246bdc633dd8d722988bd28a15e7
[INFO] running `Command { std: "docker" "start" "-a" "666b4ab666356f75e34581d430a5b1c725e2246bdc633dd8d722988bd28a15e7", kill_on_drop: false }`
[INFO] [stderr]     Checking rust-chunks v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/lib.rs:80:19
[INFO] [stdout]    |
[INFO] [stdout] 80 |         Point3D { x: x, y: y, z: z }
[INFO] [stdout]    |                   ^^^^ help: replace it with: `x`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/lib.rs:80:25
[INFO] [stdout]    |
[INFO] [stdout] 80 |         Point3D { x: x, y: y, z: z }
[INFO] [stdout]    |                         ^^^^ help: replace it with: `y`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/lib.rs:80:31
[INFO] [stdout]    |
[INFO] [stdout] 80 |         Point3D { x: x, y: y, z: z }
[INFO] [stdout]    |                               ^^^^ help: replace it with: `z`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]    --> src/lib.rs:109:1
[INFO] [stdout]     |
[INFO] [stdout] 109 | / /// portion of the world that is backed up by chunks, kinda like a world
[INFO] [stdout] 110 | |
[INFO] [stdout]     | |_^
[INFO] [stdout] 111 |   impl DataSegment {
[INFO] [stdout]     |   - the comment documents this implementation
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]     = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]     = help: if the empty line is unintentional, remove it
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:141:13
[INFO] [stdout]     |
[INFO] [stdout] 141 |             extra_data: extra_data,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extra_data`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:264:13
[INFO] [stdout]     |
[INFO] [stdout] 264 |             x_size: x_size,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^ help: replace it with: `x_size`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:265:13
[INFO] [stdout]     |
[INFO] [stdout] 265 |             y_size: y_size,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^ help: replace it with: `y_size`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:266:13
[INFO] [stdout]     |
[INFO] [stdout] 266 |             z_size: z_size,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^ help: replace it with: `z_size`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:267:13
[INFO] [stdout]     |
[INFO] [stdout] 267 |             start_location: start_location,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_location`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:268:13
[INFO] [stdout]     |
[INFO] [stdout] 268 |             end_location: end_location,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_location`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around block return value
[INFO] [stdout]    --> src/lib.rs:382:5
[INFO] [stdout]     |
[INFO] [stdout] 382 |     (map.within_bounds(location) && map.within_bounds(location_underneath)
[INFO] [stdout]     |     ^
[INFO] [stdout] ...
[INFO] [stdout] 386 |      && (map.get(location_underneath).get_type().solid))
[INFO] [stdout]     |                                                        ^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 382 ~     map.within_bounds(location) && map.within_bounds(location_underneath)
[INFO] [stdout] 383 |      //check that current location is not solid
[INFO] [stdout] 384 |      && (!map.get(location).get_type().solid)
[INFO] [stdout] 385 |      //check that location down one must be solid
[INFO] [stdout] 386 ~      && (map.get(location_underneath).get_type().solid)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/lib.rs:80:19
[INFO] [stdout]    |
[INFO] [stdout] 80 |         Point3D { x: x, y: y, z: z }
[INFO] [stdout]    |                   ^^^^ help: replace it with: `x`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/lib.rs:80:25
[INFO] [stdout]    |
[INFO] [stdout] 80 |         Point3D { x: x, y: y, z: z }
[INFO] [stdout]    |                         ^^^^ help: replace it with: `y`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/lib.rs:80:31
[INFO] [stdout]    |
[INFO] [stdout] 80 |         Point3D { x: x, y: y, z: z }
[INFO] [stdout]    |                               ^^^^ help: replace it with: `z`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]    --> src/lib.rs:109:1
[INFO] [stdout]     |
[INFO] [stdout] 109 | / /// portion of the world that is backed up by chunks, kinda like a world
[INFO] [stdout] 110 | |
[INFO] [stdout]     | |_^
[INFO] [stdout] 111 |   impl DataSegment {
[INFO] [stdout]     |   - the comment documents this implementation
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]     = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]     = help: if the empty line is unintentional, remove it
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:141:13
[INFO] [stdout]     |
[INFO] [stdout] 141 |             extra_data: extra_data,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extra_data`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:264:13
[INFO] [stdout]     |
[INFO] [stdout] 264 |             x_size: x_size,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^ help: replace it with: `x_size`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:265:13
[INFO] [stdout]     |
[INFO] [stdout] 265 |             y_size: y_size,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^ help: replace it with: `y_size`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:266:13
[INFO] [stdout]     |
[INFO] [stdout] 266 |             z_size: z_size,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^ help: replace it with: `z_size`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:267:13
[INFO] [stdout]     |
[INFO] [stdout] 267 |             start_location: start_location,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_location`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/lib.rs:268:13
[INFO] [stdout]     |
[INFO] [stdout] 268 |             end_location: end_location,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_location`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around block return value
[INFO] [stdout]    --> src/lib.rs:382:5
[INFO] [stdout]     |
[INFO] [stdout] 382 |     (map.within_bounds(location) && map.within_bounds(location_underneath)
[INFO] [stdout]     |     ^
[INFO] [stdout] ...
[INFO] [stdout] 386 |      && (map.get(location_underneath).get_type().solid))
[INFO] [stdout]     |                                                        ^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 382 ~     map.within_bounds(location) && map.within_bounds(location_underneath)
[INFO] [stdout] 383 |      //check that current location is not solid
[INFO] [stdout] 384 |      && (!map.get(location).get_type().solid)
[INFO] [stdout] 385 |      //check that location down one must be solid
[INFO] [stdout] 386 ~      && (map.get(location_underneath).get_type().solid)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:161:57
[INFO] [stdout]     |
[INFO] [stdout] 161 |     fn set(&mut self, location: VoxelLocation, value: T) -> () {
[INFO] [stdout]     |                                                         ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]     = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:166:53
[INFO] [stdout]     |
[INFO] [stdout] 166 |     fn read(&mut self, stream: &mut BufReader<File>) -> () {
[INFO] [stdout]     |                                                     ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:171:60
[INFO] [stdout]     |
[INFO] [stdout] 171 |     fn write(stream: &mut BufWriter<File>, chunk: Chunk<T>) -> () {
[INFO] [stdout]     |                                                            ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:186:79
[INFO] [stdout]     |
[INFO] [stdout] 186 |     fn add_chunk_in_place(&mut self, location: ChunkLocation, chunk: Chunk<T>) -> () {
[INFO] [stdout]     |                                                                               ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:192:65
[INFO] [stdout]     |
[INFO] [stdout] 192 |     fn remove_chunk_in_place(&mut self, location: ChunkLocation) -> () {
[INFO] [stdout]     |                                                                 ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:218:54
[INFO] [stdout]     |
[INFO] [stdout] 218 |     fn load_chunk(&mut self, location: ChunkLocation) -> () {
[INFO] [stdout]     |                                                      ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:223:54
[INFO] [stdout]     |
[INFO] [stdout] 223 |     fn sync_chunk(&mut self, location: ChunkLocation) -> () {
[INFO] [stdout]     |                                                      ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:228:24
[INFO] [stdout]     |
[INFO] [stdout] 228 |     fn flush(&mut self) -> () {
[INFO] [stdout]     |                        ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:293:58
[INFO] [stdout]     |
[INFO] [stdout] 293 |     fn set(&mut self, location: GlobalLocation, value: T) -> () {
[INFO] [stdout]     |                                                          ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:420:24
[INFO] [stdout]     |
[INFO] [stdout] 420 |                     && !visited.iter().find(|x| &x.location == location).is_some()
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `visited.iter().find(|x| &x.location == location).is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:161:57
[INFO] [stdout]     |
[INFO] [stdout] 161 |     fn set(&mut self, location: VoxelLocation, value: T) -> () {
[INFO] [stdout]     |                                                         ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]     = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:166:53
[INFO] [stdout]     |
[INFO] [stdout] 166 |     fn read(&mut self, stream: &mut BufReader<File>) -> () {
[INFO] [stdout]     |                                                     ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:171:60
[INFO] [stdout]     |
[INFO] [stdout] 171 |     fn write(stream: &mut BufWriter<File>, chunk: Chunk<T>) -> () {
[INFO] [stdout]     |                                                            ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:186:79
[INFO] [stdout]     |
[INFO] [stdout] 186 |     fn add_chunk_in_place(&mut self, location: ChunkLocation, chunk: Chunk<T>) -> () {
[INFO] [stdout]     |                                                                               ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:192:65
[INFO] [stdout]     |
[INFO] [stdout] 192 |     fn remove_chunk_in_place(&mut self, location: ChunkLocation) -> () {
[INFO] [stdout]     |                                                                 ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:218:54
[INFO] [stdout]     |
[INFO] [stdout] 218 |     fn load_chunk(&mut self, location: ChunkLocation) -> () {
[INFO] [stdout]     |                                                      ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:223:54
[INFO] [stdout]     |
[INFO] [stdout] 223 |     fn sync_chunk(&mut self, location: ChunkLocation) -> () {
[INFO] [stdout]     |                                                      ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:228:24
[INFO] [stdout]     |
[INFO] [stdout] 228 |     fn flush(&mut self) -> () {
[INFO] [stdout]     |                        ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Point3D` which implements the `Copy` trait
[INFO] [stdout]    --> src/lib.rs:398:23
[INFO] [stdout]     |
[INFO] [stdout] 398 |             location: location.clone(),
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*location`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait
[INFO] [stdout]    --> src/lib.rs:399:19
[INFO] [stdout]     |
[INFO] [stdout] 399 |             cost: weight.clone(),
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^ help: try dereferencing it: `*weight`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:404:11
[INFO] [stdout]     |
[INFO] [stdout] 404 |     while frontier.len() > 0 {
[INFO] [stdout]     |           ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!frontier.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/lib.rs:293:58
[INFO] [stdout]     |
[INFO] [stdout] 293 |     fn set(&mut self, location: GlobalLocation, value: T) -> () {
[INFO] [stdout]     |                                                          ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Point3D` which implements the `Copy` trait
[INFO] [stdout]    --> src/lib.rs:418:36
[INFO] [stdout]     |
[INFO] [stdout] 418 |             if is_traversable(map, location.clone())
[INFO] [stdout]     |                                    ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*location`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Point3D` which implements the `Copy` trait
[INFO] [stdout]    --> src/lib.rs:424:31
[INFO] [stdout]     |
[INFO] [stdout] 424 |                     location: location.clone(),
[INFO] [stdout]     |                               ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*location`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of a legacy numeric method
[INFO] [stdout]    --> src/lib.rs:433:59
[INFO] [stdout]     |
[INFO] [stdout] 433 |         Volume::new(map.start_location, map.end_location, u32::max_value());
[INFO] [stdout]     |                                                           ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]     = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] help: use the associated constant instead
[INFO] [stdout]     |
[INFO] [stdout] 433 -         Volume::new(map.start_location, map.end_location, u32::max_value());
[INFO] [stdout] 433 +         Volume::new(map.start_location, map.end_location, u32::MAX);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:420:24
[INFO] [stdout]     |
[INFO] [stdout] 420 |                     && !visited.iter().find(|x| &x.location == location).is_some()
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `visited.iter().find(|x| &x.location == location).is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Point3D` which implements the `Copy` trait
[INFO] [stdout]    --> src/lib.rs:398:23
[INFO] [stdout]     |
[INFO] [stdout] 398 |             location: location.clone(),
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*location`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait
[INFO] [stdout]    --> src/lib.rs:399:19
[INFO] [stdout]     |
[INFO] [stdout] 399 |             cost: weight.clone(),
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^ help: try dereferencing it: `*weight`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:404:11
[INFO] [stdout]     |
[INFO] [stdout] 404 |     while frontier.len() > 0 {
[INFO] [stdout]     |           ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!frontier.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Point3D` which implements the `Copy` trait
[INFO] [stdout]    --> src/lib.rs:418:36
[INFO] [stdout]     |
[INFO] [stdout] 418 |             if is_traversable(map, location.clone())
[INFO] [stdout]     |                                    ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*location`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Point3D` which implements the `Copy` trait
[INFO] [stdout]    --> src/lib.rs:424:31
[INFO] [stdout]     |
[INFO] [stdout] 424 |                     location: location.clone(),
[INFO] [stdout]     |                               ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*location`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of a legacy numeric method
[INFO] [stdout]    --> src/lib.rs:433:59
[INFO] [stdout]     |
[INFO] [stdout] 433 |         Volume::new(map.start_location, map.end_location, u32::max_value());
[INFO] [stdout]     |                                                           ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]     = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] help: use the associated constant instead
[INFO] [stdout]     |
[INFO] [stdout] 433 -         Volume::new(map.start_location, map.end_location, u32::max_value());
[INFO] [stdout] 433 +         Volume::new(map.start_location, map.end_location, u32::MAX);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.23s
[INFO] running `Command { std: "docker" "inspect" "666b4ab666356f75e34581d430a5b1c725e2246bdc633dd8d722988bd28a15e7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "666b4ab666356f75e34581d430a5b1c725e2246bdc633dd8d722988bd28a15e7", kill_on_drop: false }`
[INFO] [stdout] 666b4ab666356f75e34581d430a5b1c725e2246bdc633dd8d722988bd28a15e7