[INFO] cloning repository https://github.com/phnixir/trackerconqueror [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/phnixir/trackerconqueror" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fphnixir%2Ftrackerconqueror", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fphnixir%2Ftrackerconqueror'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e339dbf693e2332ae3883dac90e3906a30e3bb7c [INFO] linting phnixir/trackerconqueror against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fphnixir%2Ftrackerconqueror" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/phnixir/trackerconqueror [INFO] finished tweaking git repo https://github.com/phnixir/trackerconqueror [INFO] tweaked toml for git repo https://github.com/phnixir/trackerconqueror written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/phnixir/trackerconqueror on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/phnixir/trackerconqueror already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded chunked_transfer v1.4.0 [INFO] [stderr] Downloaded cpufeatures v0.1.3 [INFO] [stderr] Downloaded integer-encoding v3.0.2 [INFO] [stderr] Downloaded vcpkg v0.2.12 [INFO] [stderr] Downloaded ureq v2.1.1 [INFO] [stderr] Downloaded trackermeta v0.2.0 [INFO] [stderr] Downloaded escaper v0.1.1 [INFO] [stderr] Downloaded message-io v0.14.1 [INFO] [stderr] Downloaded bstr v0.2.16 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3caf341a914eedcbd1aea50029c568498f422072ac92e1b6d2a19d5fe23d7336 [INFO] running `Command { std: "docker" "start" "-a" "3caf341a914eedcbd1aea50029c568498f422072ac92e1b6d2a19d5fe23d7336", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3caf341a914eedcbd1aea50029c568498f422072ac92e1b6d2a19d5fe23d7336", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3caf341a914eedcbd1aea50029c568498f422072ac92e1b6d2a19d5fe23d7336", kill_on_drop: false }` [INFO] [stdout] 3caf341a914eedcbd1aea50029c568498f422072ac92e1b6d2a19d5fe23d7336 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5122c4184fc46d74f71aef88e1a930141ddd19cdc9c310346f1d76e0bfdd7a61 [INFO] running `Command { std: "docker" "start" "-a" "5122c4184fc46d74f71aef88e1a930141ddd19cdc9c310346f1d76e0bfdd7a61", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling cc v1.0.67 [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Checking tinyvec v1.2.0 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Checking unicode-bidi v0.3.5 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling openssl v0.10.34 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.4 [INFO] [stderr] Compiling httparse v1.4.1 [INFO] [stderr] Compiling native-tls v0.2.7 [INFO] [stderr] Checking openssl-probe v0.1.4 [INFO] [stderr] Checking cpufeatures v0.1.3 [INFO] [stderr] Checking http v0.2.4 [INFO] [stderr] Checking input_buffer v0.4.0 [INFO] [stderr] Checking chunked_transfer v1.4.0 [INFO] [stderr] Checking entities v1.0.1 [INFO] [stderr] Checking integer-encoding v3.0.2 [INFO] [stderr] Checking unicode-normalization v0.1.17 [INFO] [stderr] Checking escaper v0.1.1 [INFO] [stderr] Compiling openssl-src v111.15.0+1.1.1k [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling openssl-sys v0.9.63 [INFO] [stderr] Checking getrandom v0.2.2 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking mio v0.7.11 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking dirs-next v1.0.2 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking platform-dirs v0.3.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking sha-1 v0.9.6 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking webpki-roots v0.21.1 [INFO] [stderr] Checking rustls v0.19.1 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Compiling strum_macros v0.20.1 [INFO] [stderr] Checking ureq v2.1.1 [INFO] [stderr] Checking trackermeta v0.2.0 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking strum v0.20.0 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking tungstenite v0.13.0 [INFO] [stderr] Checking message-io v0.14.1 [INFO] [stderr] Checking trackerconqueror v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/client.rs:49:67 [INFO] [stdout] | [INFO] [stdout] 49 | let message: ServerMessage = bincode::deserialize(&input_data).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `input_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/client.rs:49:67 [INFO] [stdout] | [INFO] [stdout] 49 | let message: ServerMessage = bincode::deserialize(&input_data).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `input_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server.rs:98:69 [INFO] [stdout] | [INFO] [stdout] 98 | let message: ClientMessage = match bincode::deserialize(&input_data) { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `input_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server.rs:98:69 [INFO] [stdout] | [INFO] [stdout] 98 | let message: ClientMessage = match bincode::deserialize(&input_data) { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `input_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/miner.rs:34:25 [INFO] [stdout] | [INFO] [stdout] 34 | ser.request = match string.split(',').nth(0).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `string.split(',').next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/miner.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | std::str::from_utf8(&stdout).unwrap().split('\n').last().unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 52 - std::str::from_utf8(&stdout).unwrap().split('\n').last().unwrap().to_string() [INFO] [stdout] 52 + std::str::from_utf8(&stdout).unwrap().split('\n').next_back().unwrap().to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/miner.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 62 | let ser = string_to_ser(ser); [INFO] [stdout] | ----------------------------- unnecessary `let` binding [INFO] [stdout] 63 | [INFO] [stdout] 64 | ser [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 62 ~ [INFO] [stdout] 63 | [INFO] [stdout] 64 ~ string_to_ser(ser) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/miner.rs:57:15 [INFO] [stdout] | [INFO] [stdout] 57 | .args(&["client", &worker_name, &remote_addr, "getunit"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["client", &worker_name, &remote_addr, "getunit"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/miner.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 74 | let ser = string_to_ser(ser); [INFO] [stdout] | ----------------------------- unnecessary `let` binding [INFO] [stdout] 75 | [INFO] [stdout] 76 | ser [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 74 ~ [INFO] [stdout] 75 | [INFO] [stdout] 76 ~ string_to_ser(ser) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/miner.rs:69:15 [INFO] [stdout] | [INFO] [stdout] 69 | .args(&["client", &worker_name, &remote_addr, "complete", &format!("{}", unit_id)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["client", &worker_name, &remote_addr, "complete", &format!("{}", unit_id)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/miner.rs:100:44 [INFO] [stdout] | [INFO] [stdout] 100 | while (mod_counter >= unit_min) && !(mod_counter == unit_max) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(mod_counter != unit_max)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/miner.rs:138:44 [INFO] [stdout] | [INFO] [stdout] 138 | while (mod_counter >= unit_min) && !(mod_counter == unit_max) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(mod_counter != unit_max)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/miner.rs:83:16 [INFO] [stdout] | [INFO] [stdout] 83 | let arg0 = args.get(0).unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/miner.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/miner.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:40:26 [INFO] [stdout] | [INFO] [stdout] 40 | _ => return println!("{}", HELP_MSG), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - _ => return println!("{}", HELP_MSG), [INFO] [stdout] 40 + _ => println!("{}", HELP_MSG), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 43 | None => return println!("{}", HELP_MSG), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - None => return println!("{}", HELP_MSG), [INFO] [stdout] 43 + None => println!("{}", HELP_MSG), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/miner.rs:34:25 [INFO] [stdout] | [INFO] [stdout] 34 | ser.request = match string.split(',').nth(0).unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `string.split(',').next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/miner.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | std::str::from_utf8(&stdout).unwrap().split('\n').last().unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 52 - std::str::from_utf8(&stdout).unwrap().split('\n').last().unwrap().to_string() [INFO] [stdout] 52 + std::str::from_utf8(&stdout).unwrap().split('\n').next_back().unwrap().to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/miner.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 62 | let ser = string_to_ser(ser); [INFO] [stdout] | ----------------------------- unnecessary `let` binding [INFO] [stdout] 63 | [INFO] [stdout] 64 | ser [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 62 ~ [INFO] [stdout] 63 | [INFO] [stdout] 64 ~ string_to_ser(ser) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 58 | None => return println!("{}", HELP_MSG), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - None => return println!("{}", HELP_MSG), [INFO] [stdout] 58 + None => println!("{}", HELP_MSG), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/miner.rs:57:15 [INFO] [stdout] | [INFO] [stdout] 57 | .args(&["client", &worker_name, &remote_addr, "getunit"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["client", &worker_name, &remote_addr, "getunit"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 66 | Err(_) => return println!("{}", HELP_MSG), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 ~ Err(_) => println!("{}", HELP_MSG), [INFO] [stdout] 67 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:69:14 [INFO] [stdout] | [INFO] [stdout] 69 | _ => return println!("{}", HELP_MSG), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - _ => return println!("{}", HELP_MSG), [INFO] [stdout] 69 + _ => println!("{}", HELP_MSG), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/miner.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 74 | let ser = string_to_ser(ser); [INFO] [stdout] | ----------------------------- unnecessary `let` binding [INFO] [stdout] 75 | [INFO] [stdout] 76 | ser [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 74 ~ [INFO] [stdout] 75 | [INFO] [stdout] 76 ~ string_to_ser(ser) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/miner.rs:69:15 [INFO] [stdout] | [INFO] [stdout] 69 | .args(&["client", &worker_name, &remote_addr, "complete", &format!("{}", unit_id)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["client", &worker_name, &remote_addr, "complete", &format!("{}", unit_id)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/miner.rs:100:44 [INFO] [stdout] | [INFO] [stdout] 100 | while (mod_counter >= unit_min) && !(mod_counter == unit_max) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(mod_counter != unit_max)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/miner.rs:138:44 [INFO] [stdout] | [INFO] [stdout] 138 | while (mod_counter >= unit_min) && !(mod_counter == unit_max) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(mod_counter != unit_max)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/miner.rs:83:16 [INFO] [stdout] | [INFO] [stdout] 83 | let arg0 = args.get(0).unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/miner.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/miner.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:40:26 [INFO] [stdout] | [INFO] [stdout] 40 | _ => return println!("{}", HELP_MSG), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - _ => return println!("{}", HELP_MSG), [INFO] [stdout] 40 + _ => println!("{}", HELP_MSG), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 43 | None => return println!("{}", HELP_MSG), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - None => return println!("{}", HELP_MSG), [INFO] [stdout] 43 + None => println!("{}", HELP_MSG), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 58 | None => return println!("{}", HELP_MSG), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - None => return println!("{}", HELP_MSG), [INFO] [stdout] 58 + None => println!("{}", HELP_MSG), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:66:27 [INFO] [stdout] | [INFO] [stdout] 66 | Err(_) => return println!("{}", HELP_MSG), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 ~ Err(_) => println!("{}", HELP_MSG), [INFO] [stdout] 67 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:69:14 [INFO] [stdout] | [INFO] [stdout] 69 | _ => return println!("{}", HELP_MSG), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - _ => return println!("{}", HELP_MSG), [INFO] [stdout] 69 + _ => println!("{}", HELP_MSG), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 14s [INFO] running `Command { std: "docker" "inspect" "5122c4184fc46d74f71aef88e1a930141ddd19cdc9c310346f1d76e0bfdd7a61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5122c4184fc46d74f71aef88e1a930141ddd19cdc9c310346f1d76e0bfdd7a61", kill_on_drop: false }` [INFO] [stdout] 5122c4184fc46d74f71aef88e1a930141ddd19cdc9c310346f1d76e0bfdd7a61