[INFO] cloning repository https://github.com/pexip/os-rust-sequoia-sqv [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pexip/os-rust-sequoia-sqv" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpexip%2Fos-rust-sequoia-sqv", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpexip%2Fos-rust-sequoia-sqv'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2025ab055403713995c4a14370926f7b9aafb6b8 [INFO] linting pexip/os-rust-sequoia-sqv/2025ab055403713995c4a14370926f7b9aafb6b8 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpexip%2Fos-rust-sequoia-sqv" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/pexip/os-rust-sequoia-sqv [INFO] removed 0 missing tests [INFO] finished tweaking git repo https://github.com/pexip/os-rust-sequoia-sqv [INFO] tweaked toml for git repo https://github.com/pexip/os-rust-sequoia-sqv written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/pexip/os-rust-sequoia-sqv on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/pexip/os-rust-sequoia-sqv already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ocb3 v0.1.0 [INFO] [stderr] Downloaded semver v1.0.25 [INFO] [stderr] Downloaded tempfile v3.17.1 [INFO] [stderr] Downloaded terminal_size v0.4.1 [INFO] [stderr] Downloaded botan-sys v0.11.0 [INFO] [stderr] Downloaded ecb v0.1.2 [INFO] [stderr] Downloaded assert_cmd v2.0.16 [INFO] [stderr] Downloaded clap_derive v4.5.28 [INFO] [stderr] Downloaded clap_complete v4.5.46 [INFO] [stderr] Downloaded anyhow v1.0.96 [INFO] [stderr] Downloaded camellia v0.1.0 [INFO] [stderr] Downloaded sequoia-man v0.3.2 [INFO] [stderr] Downloaded buffered-reader v1.4.0 [INFO] [stderr] Downloaded nettle-sys v2.3.1 [INFO] [stderr] Downloaded p521 v0.13.3 [INFO] [stderr] Downloaded clap_builder v4.5.31 [INFO] [stderr] Downloaded sequoia-policy-config v0.8.0 [INFO] [stderr] Downloaded clap v4.5.31 [INFO] [stderr] Downloaded botan v0.11.0 [INFO] [stderr] Downloaded lalrpop v0.20.2 [INFO] [stderr] Downloaded cast5 v0.11.1 [INFO] [stderr] Downloaded cmac v0.7.2 [INFO] [stderr] Downloaded blowfish v0.9.1 [INFO] [stderr] Downloaded idea v0.5.1 [INFO] [stderr] Downloaded redox_syscall v0.5.9 [INFO] [stderr] Downloaded string_cache v0.8.8 [INFO] [stderr] Downloaded either v1.14.0 [INFO] [stderr] Downloaded cfb-mode v0.8.2 [INFO] [stderr] Downloaded dsa v0.6.3 [INFO] [stderr] Downloaded eax v0.5.0 [INFO] [stderr] Downloaded memsec v0.7.0 [INFO] [stderr] Downloaded dyn-clone v1.0.18 [INFO] [stderr] Downloaded ascii-canvas v3.0.0 [INFO] [stderr] Downloaded lalrpop-util v0.20.2 [INFO] [stderr] Downloaded win-crypto-ng v0.5.1 [INFO] [stderr] Downloaded roff v0.2.2 [INFO] [stderr] Downloaded dbl v0.3.2 [INFO] [stderr] Downloaded nettle v7.4.0 [INFO] [stderr] Downloaded twofish v0.7.1 [INFO] [stderr] Downloaded sha1collisiondetection v0.3.4 [INFO] [stderr] Downloaded sequoia-openpgp v2.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b23a8bdca5bbef77106ec60acb52c9a3bf8c00e76545a513f264744f0b644a9a [INFO] running `Command { std: "docker" "start" "-a" "b23a8bdca5bbef77106ec60acb52c9a3bf8c00e76545a513f264744f0b644a9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b23a8bdca5bbef77106ec60acb52c9a3bf8c00e76545a513f264744f0b644a9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b23a8bdca5bbef77106ec60acb52c9a3bf8c00e76545a513f264744f0b644a9a", kill_on_drop: false }` [INFO] [stdout] b23a8bdca5bbef77106ec60acb52c9a3bf8c00e76545a513f264744f0b644a9a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 49c21674fee49e67b512c2ddc96a15631295bbb96a69fff35f973dd640da7f46 [INFO] running `Command { std: "docker" "start" "-a" "49c21674fee49e67b512c2ddc96a15631295bbb96a69fff35f973dd640da7f46", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling unicode-ident v1.0.17 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling bitflags v2.8.0 [INFO] [stderr] Compiling linux-raw-sys v0.4.15 [INFO] [stderr] Compiling either v1.14.0 [INFO] [stderr] Compiling regex-syntax v0.8.5 [INFO] [stderr] Compiling glob v0.3.2 [INFO] [stderr] Compiling getrandom v0.3.1 [INFO] [stderr] Compiling stable_deref_trait v1.2.0 [INFO] [stderr] Compiling smallvec v1.14.0 [INFO] [stderr] Compiling libc v0.2.170 [INFO] [stderr] Compiling libloading v0.8.6 [INFO] [stderr] Compiling bindgen v0.70.1 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling once_cell v1.20.3 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling cc v1.2.15 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crunchy v0.2.3 [INFO] [stderr] Compiling siphasher v1.0.1 [INFO] [stderr] Compiling writeable v0.5.5 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling hashbrown v0.15.2 [INFO] [stderr] Compiling litemap v0.7.4 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling anyhow v1.0.96 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling log v0.4.26 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling indexmap v2.7.1 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling ena v0.14.3 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Compiling string_cache v0.8.8 [INFO] [stderr] Compiling sha1collisiondetection v0.3.4 [INFO] [stderr] Compiling icu_locid_transform_data v1.5.0 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling lalrpop-util v0.20.2 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Compiling utf8parse v0.2.2 [INFO] [stderr] Compiling icu_properties_data v1.5.0 [INFO] [stderr] Compiling anstyle-parse v0.2.6 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling colorchoice v1.0.3 [INFO] [stderr] Compiling utf16_iter v1.0.5 [INFO] [stderr] Compiling anstyle v1.0.10 [INFO] [stderr] Compiling write16 v1.0.0 [INFO] [stderr] Compiling anstyle-query v1.1.2 [INFO] [stderr] Compiling icu_normalizer_data v1.5.0 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling anstream v0.6.18 [INFO] [stderr] Compiling clap_lex v0.7.4 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling blake2 v0.10.6 [INFO] [stderr] Compiling password-hash v0.5.0 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling regex-automata v0.4.9 [INFO] [stderr] Compiling sequoia-policy-config v0.8.0 [INFO] [stderr] Compiling argon2 v0.5.3 [INFO] [stderr] Compiling serde v1.0.218 [INFO] [stderr] Compiling buffered-reader v1.4.0 [INFO] [stderr] Compiling xxhash-rust v0.8.15 [INFO] [stderr] Compiling iana-time-zone v0.1.61 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling memsec v0.7.0 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Compiling dyn-clone v1.0.18 [INFO] [stderr] Compiling roff v0.2.2 [INFO] [stderr] Compiling tempfile v3.17.1 [INFO] [stderr] Compiling terminal_size v0.4.1 [INFO] [stderr] Compiling clap_builder v4.5.31 [INFO] [stderr] Checking predicates-core v1.0.9 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking float-cmp v0.10.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking termtree v0.5.1 [INFO] [stderr] Compiling assert_cmd v2.0.16 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking predicates-tree v1.0.12 [INFO] [stderr] Compiling regex v1.11.1 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling lalrpop v0.20.2 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling clap_derive v4.5.28 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Checking bstr v1.11.3 [INFO] [stderr] Compiling zerofrom v0.1.5 [INFO] [stderr] Compiling yoke v0.7.5 [INFO] [stderr] Compiling clap v4.5.31 [INFO] [stderr] Compiling sequoia-man v0.3.2 [INFO] [stderr] Compiling clap_complete v4.5.46 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Compiling zerovec v0.10.4 [INFO] [stderr] Compiling tinystr v0.7.6 [INFO] [stderr] Compiling icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Compiling icu_provider v1.5.0 [INFO] [stderr] Compiling icu_locid_transform v1.5.0 [INFO] [stderr] Compiling icu_properties v1.5.1 [INFO] [stderr] Compiling nettle-sys v2.3.1 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Compiling sequoia-openpgp v2.0.0 [INFO] [stderr] Checking nettle v7.4.0 [INFO] [stderr] Compiling sequoia-sqv v1.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/cli/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// Command-line parser for sqv. [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | use std::path::PathBuf; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// Command-line parser for sqv. [INFO] [stdout] 1 + //! Command-line parser for sqv. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/cli/time.rs:73:24 [INFO] [stdout] | [INFO] [stdout] 73 | Self::try_from(SystemTime::try_from(time)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `DateTime` to `SystemTime` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 73 - Self::try_from(SystemTime::try_from(time)?) [INFO] [stdout] 73 + Self::try_from(From::from(time)?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/cli/time.rs:115:60 [INFO] [stdout] | [INFO] [stdout] 115 | if let Ok(d) = DateTime::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/cli/time.rs:118:76 [INFO] [stdout] | [INFO] [stdout] 118 | } else if let Ok(d) = chrono::NaiveDateTime::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/cli/time.rs:124:65 [INFO] [stdout] | [INFO] [stdout] 124 | if let Ok(d) = chrono::NaiveDate::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i64::abs()` to u64 [INFO] [stdout] --> src/cli/time.rs:158:37 [INFO] [stdout] | [INFO] [stdout] 158 | ... (false, count.abs() as u64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `count.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/cli/time.rs:215:50 [INFO] [stdout] | [INFO] [stdout] 215 | Time::Timestamp(ts) => Ok(ts.clone().try_into()?), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `Timestamp` to `SystemTime` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 215 - Time::Timestamp(ts) => Ok(ts.clone().try_into()?), [INFO] [stdout] 215 + Time::Timestamp(ts) => Ok(ts.clone().into()?), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Timestamp` which implements the `Copy` trait [INFO] [stdout] --> src/cli/time.rs:215:39 [INFO] [stdout] | [INFO] [stdout] 215 | Time::Timestamp(ts) => Ok(ts.clone().try_into()?), [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `(*ts)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: sequoia-sqv@1.3.0: shell completions written to /opt/rustwide/target/debug/build/sequoia-sqv-fae495ca6d16275f/out/shell-completions [INFO] [stderr] warning: sequoia-sqv@1.3.0: man pages written to /opt/rustwide/target/debug/build/sequoia-sqv-fae495ca6d16275f/out/man-pages [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/bad-subkey.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 12 | .args(&["--keyring", "bad-subkey-keyring.pgp", [INFO] [stdout] | ___________________^ [INFO] [stdout] 13 | | "bad-subkey.txt.sig", "bad-subkey.txt"]) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 ~ .args(["--keyring", "bad-subkey-keyring.pgp", [INFO] [stdout] 13 ~ "bad-subkey.txt.sig", "bad-subkey.txt"]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/wrong-key-flags.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | / &["--keyring", [INFO] [stdout] 12 | | &"no-signing-caps.key", [INFO] [stdout] 13 | | &"no-signing-caps.sig", [INFO] [stdout] 14 | | &"msg.txt"]) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 ~ ["--keyring", [INFO] [stdout] 12 + &"no-signing-caps.key", [INFO] [stdout] 13 + &"no-signing-caps.sig", [INFO] [stdout] 14 ~ &"msg.txt"]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/wrong-key-flags.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 12 | &"no-signing-caps.key", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"no-signing-caps.key"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/wrong-key-flags.rs:13:19 [INFO] [stdout] | [INFO] [stdout] 13 | &"no-signing-caps.sig", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"no-signing-caps.sig"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/wrong-key-flags.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 14 | &"msg.txt"]) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `"msg.txt"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/policy-as-of.rs:19:15 [INFO] [stdout] | [INFO] [stdout] 19 | .args(&["--keyring", [INFO] [stdout] | _______________^ [INFO] [stdout] 20 | | "mrpast.key", [INFO] [stdout] 21 | | "a-cypherpunks-manifesto.txt.sha1.sig", [INFO] [stdout] 22 | | "a-cypherpunks-manifesto.txt"]) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 ~ .args(["--keyring", [INFO] [stdout] 20 + "mrpast.key", [INFO] [stdout] 21 + "a-cypherpunks-manifesto.txt.sha1.sig", [INFO] [stdout] 22 ~ "a-cypherpunks-manifesto.txt"]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/policy-as-of.rs:29:15 [INFO] [stdout] | [INFO] [stdout] 29 | .args(&["--keyring", [INFO] [stdout] | _______________^ [INFO] [stdout] 30 | | "mrpast.key", [INFO] [stdout] 31 | | "--policy-as-of", "2008-08-03", [INFO] [stdout] 32 | | "a-cypherpunks-manifesto.txt.sha1.sig", [INFO] [stdout] 33 | | "a-cypherpunks-manifesto.txt"]) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 ~ .args(["--keyring", [INFO] [stdout] 30 + "mrpast.key", [INFO] [stdout] 31 + "--policy-as-of", "2008-08-03", [INFO] [stdout] 32 + "a-cypherpunks-manifesto.txt.sha1.sig", [INFO] [stdout] 33 ~ "a-cypherpunks-manifesto.txt"]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> tests/revoked-key.rs:42:1 [INFO] [stdout] | [INFO] [stdout] 42 | mod integration { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 251 | fn create_key() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = note: `#[warn(clippy::items_after_test_module)]` on by default [INFO] [stdout] = help: move the items to before the test module was defined [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/revoked-key.rs:51:17 [INFO] [stdout] | [INFO] [stdout] 51 | / &["--keyring", [INFO] [stdout] 52 | | &format!("revoked-key-cert-{}.pgp", keyring), [INFO] [stdout] 53 | | &format!("revoked-key-sig-{}.pgp", sig), [INFO] [stdout] 54 | | "msg.txt"]); [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 51 ~ ["--keyring", [INFO] [stdout] 52 + &format!("revoked-key-cert-{}.pgp", keyring), [INFO] [stdout] 53 + &format!("revoked-key-sig-{}.pgp", sig), [INFO] [stdout] 54 ~ "msg.txt"]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/multiple-signatures.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | / &["--keyring", [INFO] [stdout] 17 | | &p("keys/emmelie-dorothea-dina-samantha-awina-ed25519.pgp"), [INFO] [stdout] 18 | | "--signatures=2", [INFO] [stdout] 19 | | &p("messages/a-cypherpunks-manifesto.txt.ed25519.sig.duplicated"), [INFO] [stdout] 20 | | &p("messages/a-cypherpunks-manifesto.txt")]) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 ~ ["--keyring", [INFO] [stdout] 17 + &p("keys/emmelie-dorothea-dina-samantha-awina-ed25519.pgp"), [INFO] [stdout] 18 + "--signatures=2", [INFO] [stdout] 19 + &p("messages/a-cypherpunks-manifesto.txt.ed25519.sig.duplicated"), [INFO] [stdout] 20 ~ &p("messages/a-cypherpunks-manifesto.txt")]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/basics.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 10 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 11 | | "--keyring", [INFO] [stdout] 12 | | "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 13 | | "--signature-file=a-cypherpunks-manifesto.txt.ed25519.sig", [INFO] [stdout] 14 | | "a-cypherpunks-manifesto.txt", [INFO] [stdout] 15 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 10 ~ .args([ [INFO] [stdout] 11 + "--keyring", [INFO] [stdout] 12 + "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 13 + "--signature-file=a-cypherpunks-manifesto.txt.ed25519.sig", [INFO] [stdout] 14 + "a-cypherpunks-manifesto.txt", [INFO] [stdout] 15 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/basics.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 24 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 25 | | "--keyring", [INFO] [stdout] 26 | | "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 27 | | "--output=authenticated.txt", [INFO] [stdout] 28 | | "--signature-file=a-cypherpunks-manifesto.txt.ed25519.sig", [INFO] [stdout] 29 | | "a-cypherpunks-manifesto.txt", [INFO] [stdout] 30 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 24 ~ .args([ [INFO] [stdout] 25 + "--keyring", [INFO] [stdout] 26 + "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 27 + "--output=authenticated.txt", [INFO] [stdout] 28 + "--signature-file=a-cypherpunks-manifesto.txt.ed25519.sig", [INFO] [stdout] 29 + "a-cypherpunks-manifesto.txt", [INFO] [stdout] 30 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/basics.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 40 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 41 | | "--keyring", [INFO] [stdout] 42 | | "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 43 | | "a-cypherpunks-manifesto.txt.ed25519.sig", [INFO] [stdout] 44 | | "a-cypherpunks-manifesto.txt", [INFO] [stdout] 45 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 40 ~ .args([ [INFO] [stdout] 41 + "--keyring", [INFO] [stdout] 42 + "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 43 + "a-cypherpunks-manifesto.txt.ed25519.sig", [INFO] [stdout] 44 + "a-cypherpunks-manifesto.txt", [INFO] [stdout] 45 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/basics.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 60 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 61 | | "--keyring", [INFO] [stdout] 62 | | "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 63 | | "--output", &auth, [INFO] [stdout] 64 | | "--message", [INFO] [stdout] 65 | | "a-cypherpunks-manifesto.pgp", [INFO] [stdout] 66 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 60 ~ .args([ [INFO] [stdout] 61 + "--keyring", [INFO] [stdout] 62 + "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 63 + "--output", &auth, [INFO] [stdout] 64 + "--message", [INFO] [stdout] 65 + "a-cypherpunks-manifesto.pgp", [INFO] [stdout] 66 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/basics.rs:80:15 [INFO] [stdout] | [INFO] [stdout] 80 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 81 | | "--keyring", [INFO] [stdout] 82 | | "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 83 | | "--message", [INFO] [stdout] 84 | | "a-cypherpunks-manifesto.pgp", [INFO] [stdout] 85 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 ~ .args([ [INFO] [stdout] 81 + "--keyring", [INFO] [stdout] 82 + "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 83 + "--message", [INFO] [stdout] 84 + "a-cypherpunks-manifesto.pgp", [INFO] [stdout] 85 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/sqv.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / /// the motivation. [INFO] [stdout] 5 | | [INFO] [stdout] | |_^ [INFO] [stdout] 6 | use std::io; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! A simple signature verification program. [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872271 for [INFO] [stdout] 4 ~ //! the motivation. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/cli/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// Command-line parser for sqv. [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | use std::path::PathBuf; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// Command-line parser for sqv. [INFO] [stdout] 1 + //! Command-line parser for sqv. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/basics.rs:98:15 [INFO] [stdout] | [INFO] [stdout] 98 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 99 | | "--keyring", [INFO] [stdout] 100 | | "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 101 | | "--output", &auth, [INFO] [stdout] 102 | | "--cleartext", [INFO] [stdout] 103 | | "a-cypherpunks-manifesto.csf", [INFO] [stdout] 104 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 98 ~ .args([ [INFO] [stdout] 99 + "--keyring", [INFO] [stdout] 100 + "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 101 + "--output", &auth, [INFO] [stdout] 102 + "--cleartext", [INFO] [stdout] 103 + "a-cypherpunks-manifesto.csf", [INFO] [stdout] 104 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/basics.rs:121:15 [INFO] [stdout] | [INFO] [stdout] 121 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 122 | | "--keyring", [INFO] [stdout] 123 | | "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 124 | | "--cleartext", [INFO] [stdout] 125 | | "a-cypherpunks-manifesto.csf", [INFO] [stdout] 126 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 121 ~ .args([ [INFO] [stdout] 122 + "--keyring", [INFO] [stdout] 123 + "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 124 + "--cleartext", [INFO] [stdout] 125 + "a-cypherpunks-manifesto.csf", [INFO] [stdout] 126 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/not-before-after.rs:11:19 [INFO] [stdout] | [INFO] [stdout] 11 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 12 | | "--keyring", [INFO] [stdout] 13 | | "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 14 | | "a-cypherpunks-manifesto.txt.ed25519.sig", [INFO] [stdout] 15 | | "a-cypherpunks-manifesto.txt", [INFO] [stdout] 16 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 ~ .args([ [INFO] [stdout] 12 + "--keyring", [INFO] [stdout] 13 + "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 14 + "a-cypherpunks-manifesto.txt.ed25519.sig", [INFO] [stdout] 15 + "a-cypherpunks-manifesto.txt", [INFO] [stdout] 16 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/not-before-after.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 27 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 28 | | "--keyring", [INFO] [stdout] 29 | | "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 30 | | "--not-before", [INFO] [stdout] ... | [INFO] [stdout] 35 | | "a-cypherpunks-manifesto.txt", [INFO] [stdout] 36 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 27 ~ .args([ [INFO] [stdout] 28 + "--keyring", [INFO] [stdout] 29 + "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 30 + "--not-before", [INFO] [stdout] 31 + "2018-08-14", [INFO] [stdout] 32 + "--not-after", [INFO] [stdout] 33 + "2018-08-15", [INFO] [stdout] 34 + "a-cypherpunks-manifesto.txt.ed25519.sig", [INFO] [stdout] 35 + "a-cypherpunks-manifesto.txt", [INFO] [stdout] 36 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/not-before-after.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 47 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 48 | | "--keyring", [INFO] [stdout] 49 | | "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 50 | | "--not-before", [INFO] [stdout] ... | [INFO] [stdout] 53 | | "a-cypherpunks-manifesto.txt", [INFO] [stdout] 54 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 47 ~ .args([ [INFO] [stdout] 48 + "--keyring", [INFO] [stdout] 49 + "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 50 + "--not-before", [INFO] [stdout] 51 + "2018-08-15", [INFO] [stdout] 52 + "a-cypherpunks-manifesto.txt.ed25519.sig", [INFO] [stdout] 53 + "a-cypherpunks-manifesto.txt", [INFO] [stdout] 54 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/not-before-after.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 63 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 64 | | "--keyring", [INFO] [stdout] 65 | | "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 66 | | "--not-after", [INFO] [stdout] ... | [INFO] [stdout] 69 | | "a-cypherpunks-manifesto.txt", [INFO] [stdout] 70 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 ~ .args([ [INFO] [stdout] 64 + "--keyring", [INFO] [stdout] 65 + "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 66 + "--not-after", [INFO] [stdout] 67 + "2018-08-13", [INFO] [stdout] 68 + "a-cypherpunks-manifesto.txt.ed25519.sig", [INFO] [stdout] 69 + "a-cypherpunks-manifesto.txt", [INFO] [stdout] 70 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/sqv.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / /// the motivation. [INFO] [stdout] 5 | | [INFO] [stdout] | |_^ [INFO] [stdout] 6 | use std::io; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! A simple signature verification program. [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872271 for [INFO] [stdout] 4 ~ //! the motivation. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/cli/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// Command-line parser for sqv. [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | use std::path::PathBuf; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// Command-line parser for sqv. [INFO] [stdout] 1 + //! Command-line parser for sqv. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sqv.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | not_before: not_before, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `not_before` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sqv.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | not_after: not_after, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `not_after` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sqv.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | threshold: threshold, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sqv.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | keyrings: keyrings, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `keyrings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sqv.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | not_before: not_before, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `not_before` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sqv.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | not_after: not_after, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `not_after` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sqv.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | threshold: threshold, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sqv.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | keyrings: keyrings, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `keyrings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/duplicate-signatures.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 10 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 11 | | "--keyring", [INFO] [stdout] 12 | | "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 13 | | "a-cypherpunks-manifesto.txt.ed25519.sig.duplicated", [INFO] [stdout] 14 | | "a-cypherpunks-manifesto.txt", [INFO] [stdout] 15 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 10 ~ .args([ [INFO] [stdout] 11 + "--keyring", [INFO] [stdout] 12 + "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 13 + "a-cypherpunks-manifesto.txt.ed25519.sig.duplicated", [INFO] [stdout] 14 + "a-cypherpunks-manifesto.txt", [INFO] [stdout] 15 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/duplicate-signatures.rs:21:15 [INFO] [stdout] | [INFO] [stdout] 21 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 22 | | "--keyring", [INFO] [stdout] 23 | | "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 24 | | "--signatures=2", [INFO] [stdout] 25 | | "a-cypherpunks-manifesto.txt.ed25519.sig.duplicated", [INFO] [stdout] 26 | | "a-cypherpunks-manifesto.txt", [INFO] [stdout] 27 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 ~ .args([ [INFO] [stdout] 22 + "--keyring", [INFO] [stdout] 23 + "emmelie-dorothea-dina-samantha-awina-ed25519.pgp", [INFO] [stdout] 24 + "--signatures=2", [INFO] [stdout] 25 + "a-cypherpunks-manifesto.txt.ed25519.sig.duplicated", [INFO] [stdout] 26 + "a-cypherpunks-manifesto.txt", [INFO] [stdout] 27 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/sqv.rs:364:37 [INFO] [stdout] | [INFO] [stdout] 364 | return Ok(DateTime::from_utc(d, Utc)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/sqv.rs:378:33 [INFO] [stdout] | [INFO] [stdout] 378 | return Ok(DateTime::from_utc(d.and_time(pad_date_with), Utc)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/sqv.rs:364:37 [INFO] [stdout] | [INFO] [stdout] 364 | return Ok(DateTime::from_utc(d, Utc)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/sqv.rs:378:33 [INFO] [stdout] | [INFO] [stdout] 378 | return Ok(DateTime::from_utc(d.and_time(pad_date_with), Utc)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/cli/time.rs:73:24 [INFO] [stdout] | [INFO] [stdout] 73 | Self::try_from(SystemTime::try_from(time)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `DateTime` to `SystemTime` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 73 - Self::try_from(SystemTime::try_from(time)?) [INFO] [stdout] 73 + Self::try_from(From::from(time)?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/cli/time.rs:115:60 [INFO] [stdout] | [INFO] [stdout] 115 | if let Ok(d) = DateTime::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/cli/time.rs:118:76 [INFO] [stdout] | [INFO] [stdout] 118 | } else if let Ok(d) = chrono::NaiveDateTime::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/cli/time.rs:124:65 [INFO] [stdout] | [INFO] [stdout] 124 | if let Ok(d) = chrono::NaiveDate::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i64::abs()` to u64 [INFO] [stdout] --> src/cli/time.rs:158:37 [INFO] [stdout] | [INFO] [stdout] 158 | ... (false, count.abs() as u64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `count.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/cli/time.rs:215:50 [INFO] [stdout] | [INFO] [stdout] 215 | Time::Timestamp(ts) => Ok(ts.clone().try_into()?), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `Timestamp` to `SystemTime` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 215 - Time::Timestamp(ts) => Ok(ts.clone().try_into()?), [INFO] [stdout] 215 + Time::Timestamp(ts) => Ok(ts.clone().into()?), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Timestamp` which implements the `Copy` trait [INFO] [stdout] --> src/cli/time.rs:215:39 [INFO] [stdout] | [INFO] [stdout] 215 | Time::Timestamp(ts) => Ok(ts.clone().try_into()?), [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `(*ts)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/cli/time.rs:73:24 [INFO] [stdout] | [INFO] [stdout] 73 | Self::try_from(SystemTime::try_from(time)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `DateTime` to `SystemTime` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 73 - Self::try_from(SystemTime::try_from(time)?) [INFO] [stdout] 73 + Self::try_from(From::from(time)?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/cli/time.rs:115:60 [INFO] [stdout] | [INFO] [stdout] 115 | if let Ok(d) = DateTime::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/cli/time.rs:118:76 [INFO] [stdout] | [INFO] [stdout] 118 | } else if let Ok(d) = chrono::NaiveDateTime::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/cli/time.rs:124:65 [INFO] [stdout] | [INFO] [stdout] 124 | if let Ok(d) = chrono::NaiveDate::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i64::abs()` to u64 [INFO] [stdout] --> src/cli/time.rs:158:37 [INFO] [stdout] | [INFO] [stdout] 158 | ... (false, count.abs() as u64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `count.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/cli/time.rs:215:50 [INFO] [stdout] | [INFO] [stdout] 215 | Time::Timestamp(ts) => Ok(ts.clone().try_into()?), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `Timestamp` to `SystemTime` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 215 - Time::Timestamp(ts) => Ok(ts.clone().try_into()?), [INFO] [stdout] 215 + Time::Timestamp(ts) => Ok(ts.clone().into()?), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Timestamp` which implements the `Copy` trait [INFO] [stdout] --> src/cli/time.rs:215:39 [INFO] [stdout] | [INFO] [stdout] 215 | Time::Timestamp(ts) => Ok(ts.clone().try_into()?), [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `(*ts)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/sqv.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | certs.sort_by(|a, b| a.fingerprint().cmp(&b.fingerprint())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 99 - certs.sort_by(|a, b| a.fingerprint().cmp(&b.fingerprint())); [INFO] [stdout] 99 + certs.sort_by_key(|a| a.fingerprint()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/sqv.rs:359:56 [INFO] [stdout] | [INFO] [stdout] 359 | if let Ok(d) = DateTime::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/sqv.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | certs.sort_by(|a, b| a.fingerprint().cmp(&b.fingerprint())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 99 - certs.sort_by(|a, b| a.fingerprint().cmp(&b.fingerprint())); [INFO] [stdout] 99 + certs.sort_by_key(|a| a.fingerprint()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/sqv.rs:363:69 [INFO] [stdout] | [INFO] [stdout] 363 | if let Ok(d) = chrono::NaiveDateTime::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/sqv.rs:377:61 [INFO] [stdout] | [INFO] [stdout] 377 | if let Ok(d) = chrono::NaiveDate::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/sqv.rs:359:56 [INFO] [stdout] | [INFO] [stdout] 359 | if let Ok(d) = DateTime::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/sqv.rs:363:69 [INFO] [stdout] | [INFO] [stdout] 363 | if let Ok(d) = chrono::NaiveDateTime::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/sqv.rs:377:61 [INFO] [stdout] | [INFO] [stdout] 377 | if let Ok(d) = chrono::NaiveDate::parse_from_str(s, *f) { [INFO] [stdout] | ^^ help: try: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 21s [INFO] running `Command { std: "docker" "inspect" "49c21674fee49e67b512c2ddc96a15631295bbb96a69fff35f973dd640da7f46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49c21674fee49e67b512c2ddc96a15631295bbb96a69fff35f973dd640da7f46", kill_on_drop: false }` [INFO] [stdout] 49c21674fee49e67b512c2ddc96a15631295bbb96a69fff35f973dd640da7f46