[INFO] cloning repository https://github.com/peternguyen93/rustSerialKDPProxy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/peternguyen93/rustSerialKDPProxy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpeternguyen93%2FrustSerialKDPProxy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpeternguyen93%2FrustSerialKDPProxy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 659b31f87bd7250ea2a9e33a7c81f7619394b217 [INFO] linting peternguyen93/rustSerialKDPProxy against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpeternguyen93%2FrustSerialKDPProxy" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/peternguyen93/rustSerialKDPProxy [INFO] finished tweaking git repo https://github.com/peternguyen93/rustSerialKDPProxy [INFO] tweaked toml for git repo https://github.com/peternguyen93/rustSerialKDPProxy written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/peternguyen93/rustSerialKDPProxy on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/peternguyen93/rustSerialKDPProxy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded virt v0.2.11 [INFO] [stderr] Downloaded aho-corasick v0.7.19 [INFO] [stderr] Downloaded heck v0.4.0 [INFO] [stderr] Downloaded quote v1.0.15 [INFO] [stderr] Downloaded os_str_bytes v6.0.0 [INFO] [stderr] Downloaded jobserver v0.1.24 [INFO] [stderr] Downloaded clap_derive v3.1.0 [INFO] [stderr] Downloaded textwrap v0.14.2 [INFO] [stderr] Downloaded indexmap v1.8.0 [INFO] [stderr] Downloaded clap v3.1.1 [INFO] [stderr] Downloaded regex v1.6.0 [INFO] [stderr] Downloaded syn v1.0.86 [INFO] [stderr] Downloaded regex-syntax v0.6.27 [INFO] [stderr] Downloaded libc v0.2.119 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 143ea40510cc3799c5ebfcf4cffe50fc575a4c992480b3e077c54a2fa5565f40 [INFO] running `Command { std: "docker" "start" "-a" "143ea40510cc3799c5ebfcf4cffe50fc575a4c992480b3e077c54a2fa5565f40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "143ea40510cc3799c5ebfcf4cffe50fc575a4c992480b3e077c54a2fa5565f40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "143ea40510cc3799c5ebfcf4cffe50fc575a4c992480b3e077c54a2fa5565f40", kill_on_drop: false }` [INFO] [stdout] 143ea40510cc3799c5ebfcf4cffe50fc575a4c992480b3e077c54a2fa5565f40 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ddd39c87bb4b8509498b38ce418764f13f80f318bfcc6b5b12eb1e1474134212 [INFO] running `Command { std: "docker" "start" "-a" "ddd39c87bb4b8509498b38ce418764f13f80f318bfcc6b5b12eb1e1474134212", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking virt v0.2.11 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling rustSerialKDPProxy v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/build.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use cc; [INFO] [stdout] | ^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Compiling clap_derive v3.1.0 [INFO] [stderr] Checking clap v3.1.1 [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/kdp_export.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 95 | let num = (sin_addr.s_addr >> 8 * i) & 0xFF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `sin_addr.s_addr >> (8 * i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/kdp_export.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 95 | let num = (sin_addr.s_addr >> 8 * i) & 0xFF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `sin_addr.s_addr >> (8 * i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_ip_v` is never used [INFO] [stdout] --> src/kdp_export.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 38 | impl ip { [INFO] [stdout] | ------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 44 | pub fn get_ip_v(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_ip_v` is never used [INFO] [stdout] --> src/kdp_export.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 38 | impl ip { [INFO] [stdout] | ------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 44 | pub fn get_ip_v(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/kdp_export.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return self.ip_vhl & 0xF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return self.ip_vhl & 0xF; [INFO] [stdout] 45 + self.ip_vhl & 0xF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/kdp_export.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return (self.ip_vhl >> 4) & 0xF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return (self.ip_vhl >> 4) & 0xF; [INFO] [stdout] 53 + (self.ip_vhl >> 4) & 0xF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SERIALIZE` contains a capitalized acronym [INFO] [stdout] --> src/kdp_export.rs:73:10 [INFO] [stdout] | [INFO] [stdout] 73 | pub enum SERIALIZE { [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Serialize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/kdp_export.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return self.ip_vhl & 0xF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return self.ip_vhl & 0xF; [INFO] [stdout] 45 + self.ip_vhl & 0xF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/kdp_export.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | return u_value.to_be(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return u_value.to_be(); [INFO] [stdout] 87 + u_value.to_be() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/kdp_export.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | return ip_addr; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return ip_addr; [INFO] [stdout] 101 + ip_addr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/kdp_export.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return (self.ip_vhl >> 4) & 0xF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return (self.ip_vhl >> 4) & 0xF; [INFO] [stdout] 53 + (self.ip_vhl >> 4) & 0xF [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SERIALIZE` contains a capitalized acronym [INFO] [stdout] --> src/kdp_export.rs:73:10 [INFO] [stdout] | [INFO] [stdout] 73 | pub enum SERIALIZE { [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Serialize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/kdp_export.rs:126:2 [INFO] [stdout] | [INFO] [stdout] 126 | return sum as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return sum as u16; [INFO] [stdout] 126 + sum as u16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/kdp_export.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | return u_value.to_be(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return u_value.to_be(); [INFO] [stdout] 87 + u_value.to_be() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/kdp_export.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | return ip_addr; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return ip_addr; [INFO] [stdout] 101 + ip_addr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/kdp_export.rs:126:2 [INFO] [stdout] | [INFO] [stdout] 126 | return sum as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return sum as u16; [INFO] [stdout] 126 + sum as u16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/virt_connect.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return pty_device.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return pty_device.to_string(); [INFO] [stdout] 30 + pty_device.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/virt_connect.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return pty_device.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return pty_device.to_string(); [INFO] [stdout] 30 + pty_device.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:39:25 [INFO] [stdout] | [INFO] [stdout] 39 | if g_linecount != 0 && (g_linecount % 16) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `g_linecount.is_multiple_of(16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:46:4 [INFO] [stdout] | [INFO] [stdout] 46 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 46 - print!("\n"); [INFO] [stdout] 46 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:39:25 [INFO] [stdout] | [INFO] [stdout] 39 | if g_linecount != 0 && (g_linecount % 16) == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `g_linecount.is_multiple_of(16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:46:4 [INFO] [stdout] | [INFO] [stdout] 46 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 46 - print!("\n"); [INFO] [stdout] 46 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `client_macaddr` [INFO] [stdout] --> src/main.rs:98:18 [INFO] [stdout] | [INFO] [stdout] 98 | for i in 0..client_macaddr.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 98 - for i in 0..client_macaddr.len() { [INFO] [stdout] 98 + for (i, ) in client_macaddr.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `our_macaddr` [INFO] [stdout] --> src/main.rs:102:18 [INFO] [stdout] | [INFO] [stdout] 102 | for i in 0..our_macaddr.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 102 - for i in 0..our_macaddr.len() { [INFO] [stdout] 102 + for (i, ) in our_macaddr.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `client_macaddr` [INFO] [stdout] --> src/main.rs:98:18 [INFO] [stdout] | [INFO] [stdout] 98 | for i in 0..client_macaddr.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 98 - for i in 0..client_macaddr.len() { [INFO] [stdout] 98 + for (i, ) in client_macaddr.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `our_macaddr` [INFO] [stdout] --> src/main.rs:102:18 [INFO] [stdout] | [INFO] [stdout] 102 | for i in 0..our_macaddr.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 102 - for i in 0..our_macaddr.len() { [INFO] [stdout] 102 + for (i, ) in our_macaddr.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/main.rs:115:35 [INFO] [stdout] | [INFO] [stdout] 115 | pframe.h.ih.ip_id = htons(out_ip_id as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `out_ip_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/main.rs:115:35 [INFO] [stdout] | [INFO] [stdout] 115 | pframe.h.ih.ip_id = htons(out_ip_id as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `out_ip_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:230:5 [INFO] [stdout] | [INFO] [stdout] 230 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 230 - return ret; [INFO] [stdout] 230 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:230:5 [INFO] [stdout] | [INFO] [stdout] 230 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 230 - return ret; [INFO] [stdout] 230 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*mut libc::timeval` -> `*mut libc::timeval`) [INFO] [stdout] --> src/main.rs:184:18 [INFO] [stdout] | [INFO] [stdout] 184 | tv_ptr = null_mut() as *mut timeval; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `null_mut()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `fds` [INFO] [stdout] --> src/main.rs:187:14 [INFO] [stdout] | [INFO] [stdout] 187 | for i in 0..fds.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 187 - for i in 0..fds.len() { [INFO] [stdout] 187 + for in &fds { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*mut libc::timeval` -> `*mut libc::timeval`) [INFO] [stdout] --> src/main.rs:184:18 [INFO] [stdout] | [INFO] [stdout] 184 | tv_ptr = null_mut() as *mut timeval; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `null_mut()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `fds` [INFO] [stdout] --> src/main.rs:187:14 [INFO] [stdout] | [INFO] [stdout] 187 | for i in 0..fds.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 187 - for i in 0..fds.len() { [INFO] [stdout] 187 + for in &fds { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `fds` [INFO] [stdout] --> src/main.rs:210:14 [INFO] [stdout] | [INFO] [stdout] 210 | for i in 0..fds.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 210 - for i in 0..fds.len() { [INFO] [stdout] 210 + for in &mut fds { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `fds` [INFO] [stdout] --> src/main.rs:210:14 [INFO] [stdout] | [INFO] [stdout] 210 | for i in 0..fds.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 210 - for i in 0..fds.len() { [INFO] [stdout] 210 + for in &mut fds { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stdout] --> src/main.rs:272:11 [INFO] [stdout] | [INFO] [stdout] 272 | ... frame.buf.as_ptr().offset(size_of::() as isize) as *mut c_void, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stdout] = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default [INFO] [stdout] help: use `add` instead [INFO] [stdout] | [INFO] [stdout] 272 - frame.buf.as_ptr().offset(size_of::() as isize) as *mut c_void, [INFO] [stdout] 272 + frame.buf.as_ptr().add(size_of::()) as *mut c_void, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stdout] --> src/main.rs:272:11 [INFO] [stdout] | [INFO] [stdout] 272 | ... frame.buf.as_ptr().offset(size_of::() as isize) as *mut c_void, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stdout] = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default [INFO] [stdout] help: use `add` instead [INFO] [stdout] | [INFO] [stdout] 272 - frame.buf.as_ptr().offset(size_of::() as isize) as *mut c_void, [INFO] [stdout] 272 + frame.buf.as_ptr().add(size_of::()) as *mut c_void, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stdout] --> src/main.rs:312:10 [INFO] [stdout] | [INFO] [stdout] 312 | ... p_kdp_package.buf.as_ptr().offset(size_of::() as isize) as *const c_void, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stdout] help: use `add` instead [INFO] [stdout] | [INFO] [stdout] 312 - p_kdp_package.buf.as_ptr().offset(size_of::() as isize) as *const c_void, [INFO] [stdout] 312 + p_kdp_package.buf.as_ptr().add(size_of::()) as *const c_void, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stdout] --> src/main.rs:312:10 [INFO] [stdout] | [INFO] [stdout] 312 | ... p_kdp_package.buf.as_ptr().offset(size_of::() as isize) as *const c_void, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stdout] help: use `add` instead [INFO] [stdout] | [INFO] [stdout] 312 - p_kdp_package.buf.as_ptr().offset(size_of::() as isize) as *const c_void, [INFO] [stdout] 312 + p_kdp_package.buf.as_ptr().add(size_of::()) as *const c_void, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/main.rs:329:47 [INFO] [stdout] | [INFO] [stdout] 329 | ... print!("{}^{}{}", REVERSE_VIDEO, (b + '@' as u8) as char, NORMAL_VIDEO); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'@'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/main.rs:329:47 [INFO] [stdout] | [INFO] [stdout] 329 | ... print!("{}^{}{}", REVERSE_VIDEO, (b + '@' as u8) as char, NORMAL_VIDEO); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'@'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:370:8 [INFO] [stdout] | [INFO] [stdout] 370 | if !args.serial_path.is_none(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.serial_path.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:374:13 [INFO] [stdout] | [INFO] [stdout] 374 | else if !args.kvm_name.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.kvm_name.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:370:8 [INFO] [stdout] | [INFO] [stdout] 370 | if !args.serial_path.is_none(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.serial_path.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:374:13 [INFO] [stdout] | [INFO] [stdout] 374 | else if !args.kvm_name.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.kvm_name.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.serial_path` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:371:26 [INFO] [stdout] | [INFO] [stdout] 370 | if !args.serial_path.is_none(){ [INFO] [stdout] | -------------------------- the check is happening here [INFO] [stdout] 371 | serial_path.push(args.serial_path.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.serial_path` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:371:26 [INFO] [stdout] | [INFO] [stdout] 370 | if !args.serial_path.is_none(){ [INFO] [stdout] | -------------------------- the check is happening here [INFO] [stdout] 371 | serial_path.push(args.serial_path.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:366:2 [INFO] [stdout] | [INFO] [stdout] 366 | let listen_ip: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 382 | listen_ip = args.listen.unwrap_or(DEFAULT_LISTEN_IP.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `listen_ip` here [INFO] [stdout] | [INFO] [stdout] 366 ~ [INFO] [stdout] 367 | let port: u32; [INFO] [stdout] ... [INFO] [stdout] 381 | [INFO] [stdout] 382 ~ let listen_ip: String = args.listen.unwrap_or(DEFAULT_LISTEN_IP.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:367:2 [INFO] [stdout] | [INFO] [stdout] 367 | let port: u32; [INFO] [stdout] | ^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 383 | port = args.port; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `port` here [INFO] [stdout] | [INFO] [stdout] 367 ~ [INFO] [stdout] 368 | let args = SerialKDPArg::parse(); [INFO] [stdout] ... [INFO] [stdout] 382 | listen_ip = args.listen.unwrap_or(DEFAULT_LISTEN_IP.to_string()); [INFO] [stdout] 383 ~ let port: u32 = args.port; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:366:2 [INFO] [stdout] | [INFO] [stdout] 366 | let listen_ip: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 382 | listen_ip = args.listen.unwrap_or(DEFAULT_LISTEN_IP.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `listen_ip` here [INFO] [stdout] | [INFO] [stdout] 366 ~ [INFO] [stdout] 367 | let port: u32; [INFO] [stdout] ... [INFO] [stdout] 381 | [INFO] [stdout] 382 ~ let listen_ip: String = args.listen.unwrap_or(DEFAULT_LISTEN_IP.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:376:42 [INFO] [stdout] | [INFO] [stdout] 376 | let pty_device = kvm_extract_pty(&kvm_name.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `kvm_name.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:402:59 [INFO] [stdout] | [INFO] [stdout] 402 | let unix_stream = UnixStream::connect(raw_serial_path).expect( [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 403 | | &format!("Unable to open device {} as unix socket", raw_serial_path)); [INFO] [stdout] | |_________________________________________________________________________________________________________^ help: try: `unwrap_or_else(|_| panic!("Unable to open device {} as unix socket", raw_serial_path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:367:2 [INFO] [stdout] | [INFO] [stdout] 367 | let port: u32; [INFO] [stdout] | ^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 383 | port = args.port; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `port` here [INFO] [stdout] | [INFO] [stdout] 367 ~ [INFO] [stdout] 368 | let args = SerialKDPArg::parse(); [INFO] [stdout] ... [INFO] [stdout] 382 | listen_ip = args.listen.unwrap_or(DEFAULT_LISTEN_IP.to_string()); [INFO] [stdout] 383 ~ let port: u32 = args.port; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:376:42 [INFO] [stdout] | [INFO] [stdout] 376 | let pty_device = kvm_extract_pty(&kvm_name.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `kvm_name.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:402:59 [INFO] [stdout] | [INFO] [stdout] 402 | let unix_stream = UnixStream::connect(raw_serial_path).expect( [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 403 | | &format!("Unable to open device {} as unix socket", raw_serial_path)); [INFO] [stdout] | |_________________________________________________________________________________________________________^ help: try: `unwrap_or_else(|_| panic!("Unable to open device {} as unix socket", raw_serial_path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.99s [INFO] running `Command { std: "docker" "inspect" "ddd39c87bb4b8509498b38ce418764f13f80f318bfcc6b5b12eb1e1474134212", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ddd39c87bb4b8509498b38ce418764f13f80f318bfcc6b5b12eb1e1474134212", kill_on_drop: false }` [INFO] [stdout] ddd39c87bb4b8509498b38ce418764f13f80f318bfcc6b5b12eb1e1474134212