[INFO] cloning repository https://github.com/peter-kehl/tokio_logdna-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/peter-kehl/tokio_logdna-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpeter-kehl%2Ftokio_logdna-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpeter-kehl%2Ftokio_logdna-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9cabd2addf74a716ecff700494dce9318df0ad6c [INFO] linting peter-kehl/tokio_logdna-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpeter-kehl%2Ftokio_logdna-rust" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/peter-kehl/tokio_logdna-rust [INFO] finished tweaking git repo https://github.com/peter-kehl/tokio_logdna-rust [INFO] tweaked toml for git repo https://github.com/peter-kehl/tokio_logdna-rust written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/peter-kehl/tokio_logdna-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/peter-kehl/tokio_logdna-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/logdna/logdna-rust` [INFO] [stderr] Updating git repository `https://github.com/logdna/async-buf-pool-rs.git` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rustls-pemfile v1.0.0 [INFO] [stderr] Downloaded sync_wrapper v0.1.1 [INFO] [stderr] Downloaded axum-core v0.2.4 [INFO] [stderr] Downloaded matchit v0.5.0 [INFO] [stderr] Downloaded flate2 v1.0.23 [INFO] [stderr] Downloaded miniz_oxide v0.5.1 [INFO] [stderr] Downloaded async-compression v0.3.14 [INFO] [stderr] Downloaded tower-http v0.3.3 [INFO] [stderr] Downloaded tower v0.4.12 [INFO] [stderr] Downloaded axum v0.5.6 [INFO] [stderr] Downloaded http v0.2.7 [INFO] [stderr] Downloaded tokio-util v0.7.2 [INFO] [stderr] Downloaded rustls v0.20.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] affb05ab710cfea55e57f1291098e933bfb85fab8525f0f38dab181a9cfda7d8 [INFO] running `Command { std: "docker" "start" "-a" "affb05ab710cfea55e57f1291098e933bfb85fab8525f0f38dab181a9cfda7d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "affb05ab710cfea55e57f1291098e933bfb85fab8525f0f38dab181a9cfda7d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "affb05ab710cfea55e57f1291098e933bfb85fab8525f0f38dab181a9cfda7d8", kill_on_drop: false }` [INFO] [stdout] affb05ab710cfea55e57f1291098e933bfb85fab8525f0f38dab181a9cfda7d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d518c4dd27f2a86749703e612820fe73ae32f237bf1eca0d30069eb063f1ad3e [INFO] running `Command { std: "docker" "start" "-a" "d518c4dd27f2a86749703e612820fe73ae32f237bf1eca0d30069eb063f1ad3e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking tracing-core v0.1.26 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Checking http v0.2.7 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Compiling httparse v1.7.1 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling rustls v0.20.6 [INFO] [stderr] Compiling async-trait v0.1.53 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking mio v0.8.3 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking cache-padded v1.2.0 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking miniz_oxide v0.5.1 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking concurrent-queue v1.2.2 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking tower-layer v0.3.1 [INFO] [stderr] Checking event-listener v2.5.2 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Checking rustls-pemfile v1.0.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking http-range-header v0.3.0 [INFO] [stderr] Checking time v0.3.9 [INFO] [stderr] Checking rustls-native-certs v0.6.2 [INFO] [stderr] Checking async-channel v1.6.1 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking matchit v0.5.0 [INFO] [stderr] Checking flate2 v1.0.23 [INFO] [stderr] Checking countme v2.0.4 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking sync_wrapper v0.1.1 [INFO] [stderr] Checking async-compression v0.3.14 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling tracing-attributes v0.1.21 [INFO] [stderr] Compiling pin-project-internal v1.0.10 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Checking tokio v1.18.2 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking async-buf-pool v0.3.0 (https://github.com/logdna/async-buf-pool-rs.git?branch=0.3.x#667927ba) [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking pin-project v1.0.10 [INFO] [stderr] Checking tracing v0.1.34 [INFO] [stderr] Checking tokio-util v0.7.2 [INFO] [stderr] Checking tokio-rustls v0.23.4 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking axum-core v0.2.4 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking tower v0.4.12 [INFO] [stderr] Checking tower-http v0.3.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking hyper v0.14.18 [INFO] [stderr] Checking hyper-rustls v0.23.0 [INFO] [stderr] Checking axum v0.5.6 [INFO] [stderr] Checking logdna-client v0.7.0 (https://github.com/logdna/logdna-rust#569c5248) [INFO] [stderr] Checking tokio_logdna-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `axum::response::Response` [INFO] [stdout] --> src/lib.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use axum::response::Response; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `axum::Json` [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use axum::Json; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::json` [INFO] [stdout] --> src/lib.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use serde_json::json; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `axum::response::Response` [INFO] [stdout] --> src/lib.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use axum::response::Response; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `axum::Json` [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use axum::Json; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::json` [INFO] [stdout] --> src/lib.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use serde_json::json; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Logger` [INFO] [stdout] --> src/logger/mod.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> Self { [INFO] [stdout] 17 | | //env_logger::init(); [INFO] [stdout] 18 | | let params = Params::builder() [INFO] [stdout] 19 | | .hostname("rust-client-test") [INFO] [stdout] ... | [INFO] [stdout] 46 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 15 + impl Default for Logger { [INFO] [stdout] 16 + fn default() -> Self { [INFO] [stdout] 17 + Self::new() [INFO] [stdout] 18 + } [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/logger/mod.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 63 | Ok(handed_over) => match handed_over { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 64 | | Response::Sent => Ok(()), [INFO] [stdout] 65 | | _ => Err(()), [INFO] [stdout] 66 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/logger/mod.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 63 | Ok(handed_over) => match handed_over { [INFO] [stdout] | ^^^^^^^^^^^ replace this binding [INFO] [stdout] 64 | Response::Sent => Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/lib.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | / impl ToString for AddressType { [INFO] [stdout] 26 | | fn to_string(&self) -> String { [INFO] [stdout] 27 | | // @TODO discuss [INFO] [stdout] 28 | | match self { [INFO] [stdout] ... | [INFO] [stdout] 34 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Logger` [INFO] [stdout] --> src/logger/mod.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> Self { [INFO] [stdout] 17 | | //env_logger::init(); [INFO] [stdout] 18 | | let params = Params::builder() [INFO] [stdout] 19 | | .hostname("rust-client-test") [INFO] [stdout] ... | [INFO] [stdout] 46 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 15 + impl Default for Logger { [INFO] [stdout] 16 + fn default() -> Self { [INFO] [stdout] 17 + Self::new() [INFO] [stdout] 18 + } [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/logger/mod.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 63 | Ok(handed_over) => match handed_over { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 64 | | Response::Sent => Ok(()), [INFO] [stdout] 65 | | _ => Err(()), [INFO] [stdout] 66 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/logger/mod.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 63 | Ok(handed_over) => match handed_over { [INFO] [stdout] | ^^^^^^^^^^^ replace this binding [INFO] [stdout] 64 | Response::Sent => Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/lib.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | / impl ToString for AddressType { [INFO] [stdout] 26 | | fn to_string(&self) -> String { [INFO] [stdout] 27 | | // @TODO discuss [INFO] [stdout] 28 | | match self { [INFO] [stdout] ... | [INFO] [stdout] 34 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `header` after checking its variant with `is_err` [INFO] [stdout] --> src/lib.rs:70:26 [INFO] [stdout] | [INFO] [stdout] 66 | if header.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Ok() = header` [INFO] [stdout] ... [INFO] [stdout] 70 | let header = header.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/lib.rs:105:24 [INFO] [stdout] | [INFO] [stdout] 105 | .keys() [INFO] [stdout] | ________________________^ [INFO] [stdout] 106 | | .map(|field_name| field_name) [INFO] [stdout] | |_____________________________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `csv_record_result` after checking its variant with `is_err` [INFO] [stdout] --> src/lib.rs:149:30 [INFO] [stdout] | [INFO] [stdout] 146 | if csv_record_result.is_err() { [INFO] [stdout] | ----------------------------- help: try: `if let Ok() = csv_record_result` [INFO] [stdout] ... [INFO] [stdout] 149 | let record = csv_record_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:141:30 [INFO] [stdout] | [INFO] [stdout] 141 | let idx_option = field_to_column_idx.get(col_name).map(|&idx| idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `field_to_column_idx.get(col_name).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lib.rs:156:34 [INFO] [stdout] | [INFO] [stdout] 156 | ... .map(|value| Ok(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Ok` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:201:37 [INFO] [stdout] | [INFO] [stdout] 201 | pub fn addresses_to_json(addresses: &Vec
) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 201 - pub fn addresses_to_json(addresses: &Vec
) -> String { [INFO] [stdout] 201 + pub fn addresses_to_json(addresses: &[Address]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:240:8 [INFO] [stdout] | [INFO] [stdout] 240 | if !header.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `header.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:264:29 [INFO] [stdout] | [INFO] [stdout] 264 | let mut actual_fields = field_to_column_idx [INFO] [stdout] | _____________________________^ [INFO] [stdout] 265 | | .keys() [INFO] [stdout] 266 | | .map(|&field_name| field_name) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 264 ~ let mut actual_fields = field_to_column_idx [INFO] [stdout] 265 + .keys().copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `header` after checking its variant with `is_err` [INFO] [stdout] --> src/lib.rs:70:26 [INFO] [stdout] | [INFO] [stdout] 66 | if header.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Ok() = header` [INFO] [stdout] ... [INFO] [stdout] 70 | let header = header.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/lib.rs:105:24 [INFO] [stdout] | [INFO] [stdout] 105 | .keys() [INFO] [stdout] | ________________________^ [INFO] [stdout] 106 | | .map(|field_name| field_name) [INFO] [stdout] | |_____________________________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `csv_record_result` after checking its variant with `is_err` [INFO] [stdout] --> src/lib.rs:149:30 [INFO] [stdout] | [INFO] [stdout] 146 | if csv_record_result.is_err() { [INFO] [stdout] | ----------------------------- help: try: `if let Ok() = csv_record_result` [INFO] [stdout] ... [INFO] [stdout] 149 | let record = csv_record_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:141:30 [INFO] [stdout] | [INFO] [stdout] 141 | let idx_option = field_to_column_idx.get(col_name).map(|&idx| idx); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `field_to_column_idx.get(col_name).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lib.rs:156:34 [INFO] [stdout] | [INFO] [stdout] 156 | ... .map(|value| Ok(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Ok` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:201:37 [INFO] [stdout] | [INFO] [stdout] 201 | pub fn addresses_to_json(addresses: &Vec
) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 201 - pub fn addresses_to_json(addresses: &Vec
) -> String { [INFO] [stdout] 201 + pub fn addresses_to_json(addresses: &[Address]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:240:8 [INFO] [stdout] | [INFO] [stdout] 240 | if !header.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `header.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:264:29 [INFO] [stdout] | [INFO] [stdout] 264 | let mut actual_fields = field_to_column_idx [INFO] [stdout] | _____________________________^ [INFO] [stdout] 265 | | .keys() [INFO] [stdout] 266 | | .map(|&field_name| field_name) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 264 ~ let mut actual_fields = field_to_column_idx [INFO] [stdout] 265 + .keys().copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use tokio; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use tokio; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 55.18s [INFO] running `Command { std: "docker" "inspect" "d518c4dd27f2a86749703e612820fe73ae32f237bf1eca0d30069eb063f1ad3e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d518c4dd27f2a86749703e612820fe73ae32f237bf1eca0d30069eb063f1ad3e", kill_on_drop: false }` [INFO] [stdout] d518c4dd27f2a86749703e612820fe73ae32f237bf1eca0d30069eb063f1ad3e