[INFO] cloning repository https://github.com/pdoms/six502 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pdoms/six502" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpdoms%2Fsix502", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpdoms%2Fsix502'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9587a9a62474713f46fbf9f97094ce361d57961c [INFO] linting pdoms/six502 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpdoms%2Fsix502" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/pdoms/six502 [INFO] finished tweaking git repo https://github.com/pdoms/six502 [INFO] tweaked toml for git repo https://github.com/pdoms/six502 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/pdoms/six502 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/pdoms/six502 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d9a3af9f6711ee5262746a49a402e8193b2c31a7742d14b24464fd46dfb0475c [INFO] running `Command { std: "docker" "start" "-a" "d9a3af9f6711ee5262746a49a402e8193b2c31a7742d14b24464fd46dfb0475c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d9a3af9f6711ee5262746a49a402e8193b2c31a7742d14b24464fd46dfb0475c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9a3af9f6711ee5262746a49a402e8193b2c31a7742d14b24464fd46dfb0475c", kill_on_drop: false }` [INFO] [stdout] d9a3af9f6711ee5262746a49a402e8193b2c31a7742d14b24464fd46dfb0475c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5badd968a1a5c97529100964089f1f74e12159a092a11669cecd56cd63bf94a0 [INFO] running `Command { std: "docker" "start" "-a" "5badd968a1a5c97529100964089f1f74e12159a092a11669cecd56cd63bf94a0", kill_on_drop: false }` [INFO] [stderr] Checking six502 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Cell` [INFO] [stdout] --> src/cpu.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{cell::{Cell, RefCell}, mem::MaybeUninit, rc::Rc}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cell` [INFO] [stdout] --> src/data.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{cell::{Cell, RefCell}, rc::Rc}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/internal/ops/common.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | / /// out as well. [INFO] [stdout] 16 | | [INFO] [stdout] | |_^ [INFO] [stdout] 17 | pub fn nop(_cpu: &mut Six502) -> bool { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::instr` [INFO] [stdout] --> src/internal/initializer.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::instr; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cell` [INFO] [stdout] --> src/cpu.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{cell::{Cell, RefCell}, mem::MaybeUninit, rc::Rc}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cell` [INFO] [stdout] --> src/data.rs:1:18 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{cell::{Cell, RefCell}, rc::Rc}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/internal/ops/common.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | / /// out as well. [INFO] [stdout] 16 | | [INFO] [stdout] | |_^ [INFO] [stdout] 17 | pub fn nop(_cpu: &mut Six502) -> bool { [INFO] [stdout] | ---------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::instr` [INFO] [stdout] --> src/internal/initializer.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::instr; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Six502` [INFO] [stdout] --> src/internal/test/adc.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | Six502, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Six502` [INFO] [stdout] --> src/internal/test/brk.rs:1:19 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{cpu::{Six502, SP_INIT}, flags::DEFAULT_STATUS, internal::{modes::AddressingMode, opcodes::OpCode, Instructions}, mem::Mem}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Six502` [INFO] [stdout] --> src/internal/test/and.rs:2:21 [INFO] [stdout] | [INFO] [stdout] 2 | cpu::{Register, Six502, Word, SP_INIT}, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Six502` [INFO] [stdout] --> src/internal/test/asl.rs:1:29 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{cpu::{Register, Six502, Word, SP_INIT}, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Six502` [INFO] [stdout] --> src/internal/test/bit.rs:1:19 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{cpu::{Six502, Word, SP_INIT}, flags::{set_flag, Flag::{N, V, Z}, DEFAULT_STATUS}, internal::{modes::AddressingMode, opcod... [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Six502` [INFO] [stdout] --> src/internal/test/branch.rs:1:19 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{cpu::{Six502, Word, SP_INIT}, flags::{set_flag, Flag, DEFAULT_STATUS}, internal::{modes::AddressingMode, opcodes::OpCode,... [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `cycles`, `fetch_signed_byte`, and `pop_stack` are never used [INFO] [stdout] --> src/cpu.rs:83:19 [INFO] [stdout] | [INFO] [stdout] 38 | impl Six502 { [INFO] [stdout] | -------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 83 | pub(crate) fn cycles(&self) -> i64 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 206 | pub(crate) fn fetch_signed_byte(&mut self) -> SByte { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 271 | pub(crate) fn pop_stack(&mut self) -> Byte { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `CPU_RAM_MIN` is never used [INFO] [stdout] --> src/data.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const CPU_RAM_MIN: u16 = 0x0000; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `CPU_RAM_MAX` is never used [INFO] [stdout] --> src/data.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | const CPU_RAM_MAX: u16 = 0x1FFF; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bus` is never read [INFO] [stdout] --> src/data.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct System { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 19 | bus: Rc>, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `mnemonic`, `opcode`, and `mode` are never read [INFO] [stdout] --> src/internal/instruction.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct InstrCode { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 6 | pub mnemonic: &'static str, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | pub opcode: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 8 | pub mode: AddressingMode, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `LdaAbx` is never constructed [INFO] [stdout] --> src/internal/opcodes.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub enum OpCode { [INFO] [stdout] | ------ variant in this enum [INFO] [stdout] ... [INFO] [stdout] 46 | LdaAbx = 0xBD, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Mem` is never constructed [INFO] [stdout] --> src/mem.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Mem { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `init` is never used [INFO] [stdout] --> src/mem.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 39 | impl Mem { [INFO] [stdout] | -------- associated function in this implementation [INFO] [stdout] 40 | pub fn init() -> Self { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Error` is never constructed [INFO] [stdout] --> src/log.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | enum LogLevel { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] 12 | Error, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `mode` is never read [INFO] [stdout] --> src/log.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct Log { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 17 | mode: LogMode [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `error` is never used [INFO] [stdout] --> src/log.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 20 | impl Log { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn error(&self, data: &str) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Six502` [INFO] [stdout] --> src/cpu.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | / pub fn new() -> Self { [INFO] [stdout] 40 | | Self { [INFO] [stdout] 41 | | pc: 0xFFFC, [INFO] [stdout] 42 | | sp: SP_INIT, [INFO] [stdout] ... | [INFO] [stdout] 50 | | bus: Rc::new(RefCell::new(unsafe { MaybeUninit::zeroed().assume_init()}))} [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 38 + impl Default for Six502 { [INFO] [stdout] 39 + fn default() -> Self { [INFO] [stdout] 40 + Self::new() [INFO] [stdout] 41 + } [INFO] [stdout] 42 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cpu.rs:58:23 [INFO] [stdout] | [INFO] [stdout] 58 | self.log.info(format!("Running Reset Sequence").as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Running Reset Sequence".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | if (self.status & flag as u8) > 0 {1} else {0} [INFO] [stdout] | ^^^^^^^^^^ help: try: `flag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 168 | return (instr.exec_fn)(self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return (instr.exec_fn)(self) [INFO] [stdout] 168 + (instr.exec_fn)(self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | return b; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - return b; [INFO] [stdout] 177 + b [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return b; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return b; [INFO] [stdout] 185 + b [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | return lo | (hi << 8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return lo | (hi << 8); [INFO] [stdout] 202 + lo | (hi << 8) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | return b as i8; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return b as i8; [INFO] [stdout] 211 + b as i8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/common.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | return !((i ^ j) & N > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `((i ^ j) & N <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | return !((i ^ j) & N > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return !((i ^ j) & N > 0) [INFO] [stdout] 4 + !((i ^ j) & N > 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/internal/ops/common.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | cpu.set_a(sum as u8 & 0xFF); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider reducing it to: `(sum as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return true; [INFO] [stdout] 14 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return true; [INFO] [stdout] 22 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return true; [INFO] [stdout] 31 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return true; [INFO] [stdout] 39 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return true; [INFO] [stdout] 54 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return true; [INFO] [stdout] 70 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return true; [INFO] [stdout] 78 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return true; [INFO] [stdout] 95 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return true; [INFO] [stdout] 14 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return true; [INFO] [stdout] 21 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return true; [INFO] [stdout] 29 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return true; [INFO] [stdout] 36 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return true; [INFO] [stdout] 50 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return true; [INFO] [stdout] 65 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return true; [INFO] [stdout] 72 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return true; [INFO] [stdout] 87 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/asl.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return true; [INFO] [stdout] 15 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/asl.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return true; [INFO] [stdout] 24 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/asl.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return true; [INFO] [stdout] 34 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/asl.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return true; [INFO] [stdout] 43 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/asl.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return true; [INFO] [stdout] 52 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/bcc.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return false; [INFO] [stdout] 10 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/bcs.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return false; [INFO] [stdout] 9 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/bit.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return true; [INFO] [stdout] 11 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/internal/ops/bit.rs:7:27 [INFO] [stdout] | [INFO] [stdout] 7 | cpu.set_flag(Flag::Z, tmp & 0x00FF); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider reducing it to: `tmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/bit.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return true; [INFO] [stdout] 22 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/internal/ops/bit.rs:18:27 [INFO] [stdout] | [INFO] [stdout] 18 | cpu.set_flag(Flag::Z, tmp & 0x00FF); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider reducing it to: `tmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/brk.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return true; [INFO] [stdout] 23 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return true; [INFO] [stdout] 16 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return true; [INFO] [stdout] 24 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return true; [INFO] [stdout] 32 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return true; [INFO] [stdout] 40 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return true; [INFO] [stdout] 56 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return true; [INFO] [stdout] 72 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return true; [INFO] [stdout] 80 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return true; [INFO] [stdout] 96 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IMP` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | IMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Imp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IMM` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | IMM, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Imm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ZPX` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | ZPX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Zpx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ZPY` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | ZPY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Zpy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `REL` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | REL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ABS` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | ABS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Abs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ABX` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | ABX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Abx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ABY` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | ABY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Aby` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IND` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | IND, // Indirect [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ind` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IZX` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | IZX, // aka Indexed Indirect [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Izx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IZY` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | IZY, // aka Indirect Indexed [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Izy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ACC` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | ACC, // accumulator direct [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Acc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/internal/opcodes.rs:149:1 [INFO] [stdout] | [INFO] [stdout] 149 | impl Into for OpCode { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 149 ~ impl From for u8 { [INFO] [stdout] 150 ~ fn from(val: OpCode) -> Self { [INFO] [stdout] 151 ~ match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/log.rs:28:27 [INFO] [stdout] | [INFO] [stdout] 28 | let mode = if let Ok(_) = std::env::var("RUST_LOG") { [INFO] [stdout] | -------^^^^^---------------------------- help: try: `if std::env::var("RUST_LOG").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Flag` should have a snake case name [INFO] [stdout] --> src/flags.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub mod Flag { [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `flag` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mem` [INFO] [stdout] --> src/cpu.rs:373:13 [INFO] [stdout] | [INFO] [stdout] 373 | let mem = Mem::init(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mem` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/internal/test/branch.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | let a = 0; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mem2` [INFO] [stdout] --> src/internal/test/lda.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | let mem2 = &[OpCode::LdaZpx as u8, 0x80, OpCode::Nop as u8]; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_mem2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `cycles` and `fetch_signed_byte` are never used [INFO] [stdout] --> src/cpu.rs:83:19 [INFO] [stdout] | [INFO] [stdout] 38 | impl Six502 { [INFO] [stdout] | -------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 83 | pub(crate) fn cycles(&self) -> i64 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 206 | pub(crate) fn fetch_signed_byte(&mut self) -> SByte { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `CPU_RAM_MIN` is never used [INFO] [stdout] --> src/data.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const CPU_RAM_MIN: u16 = 0x0000; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `CPU_RAM_MAX` is never used [INFO] [stdout] --> src/data.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | const CPU_RAM_MAX: u16 = 0x1FFF; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bus` is never read [INFO] [stdout] --> src/data.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct System { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 19 | bus: Rc>, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opcode` is never read [INFO] [stdout] --> src/internal/instruction.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct InstrCode { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 6 | pub mnemonic: &'static str, [INFO] [stdout] 7 | pub opcode: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_mem_section` is never used [INFO] [stdout] --> src/mem.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 39 | impl Mem { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn get_mem_section(&self, start: usize, buf: &mut [Byte]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Silent` is never constructed [INFO] [stdout] --> src/log.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum LogMode { [INFO] [stdout] | ------- variant in this enum [INFO] [stdout] 7 | Verbose, [INFO] [stdout] 8 | Silent, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Error` is never constructed [INFO] [stdout] --> src/log.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | enum LogLevel { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] 12 | Error, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `mode` is never read [INFO] [stdout] --> src/log.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct Log { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 17 | mode: LogMode [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `error` is never used [INFO] [stdout] --> src/log.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 20 | impl Log { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn error(&self, data: &str) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Six502` [INFO] [stdout] --> src/cpu.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | / pub fn new() -> Self { [INFO] [stdout] 40 | | Self { [INFO] [stdout] 41 | | pc: 0xFFFC, [INFO] [stdout] 42 | | sp: SP_INIT, [INFO] [stdout] ... | [INFO] [stdout] 50 | | bus: Rc::new(RefCell::new(unsafe { MaybeUninit::zeroed().assume_init()}))} [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 38 + impl Default for Six502 { [INFO] [stdout] 39 + fn default() -> Self { [INFO] [stdout] 40 + Self::new() [INFO] [stdout] 41 + } [INFO] [stdout] 42 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cpu.rs:58:23 [INFO] [stdout] | [INFO] [stdout] 58 | self.log.info(format!("Running Reset Sequence").as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Running Reset Sequence".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | if (self.status & flag as u8) > 0 {1} else {0} [INFO] [stdout] | ^^^^^^^^^^ help: try: `flag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 168 | return (instr.exec_fn)(self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return (instr.exec_fn)(self) [INFO] [stdout] 168 + (instr.exec_fn)(self) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | return b; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - return b; [INFO] [stdout] 177 + b [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return b; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return b; [INFO] [stdout] 185 + b [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | return lo | (hi << 8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return lo | (hi << 8); [INFO] [stdout] 202 + lo | (hi << 8) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | return b as i8; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return b as i8; [INFO] [stdout] 211 + b as i8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/cpu.rs:313:5 [INFO] [stdout] | [INFO] [stdout] 313 | / pub(crate) fn assert_state(&self, [INFO] [stdout] 314 | | pc: Word, [INFO] [stdout] 315 | | sp: Byte, [INFO] [stdout] 316 | | a: Byte, [INFO] [stdout] ... | [INFO] [stdout] 319 | | cycles: i64, [INFO] [stdout] 320 | | status: Byte) { [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/common.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | return !((i ^ j) & N > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `((i ^ j) & N <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/common.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | return !((i ^ j) & N > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return !((i ^ j) & N > 0) [INFO] [stdout] 4 + !((i ^ j) & N > 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/internal/ops/common.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | cpu.set_a(sum as u8 & 0xFF); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider reducing it to: `(sum as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return true; [INFO] [stdout] 14 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return true; [INFO] [stdout] 22 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return true; [INFO] [stdout] 31 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return true; [INFO] [stdout] 39 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return true; [INFO] [stdout] 54 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return true; [INFO] [stdout] 70 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return true; [INFO] [stdout] 78 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/adc.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return true; [INFO] [stdout] 95 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return true; [INFO] [stdout] 14 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return true; [INFO] [stdout] 21 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return true; [INFO] [stdout] 29 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return true; [INFO] [stdout] 36 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return true; [INFO] [stdout] 50 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return true; [INFO] [stdout] 65 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return true; [INFO] [stdout] 72 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/and.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return true; [INFO] [stdout] 87 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/asl.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return true; [INFO] [stdout] 15 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/asl.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return true; [INFO] [stdout] 24 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/asl.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return true; [INFO] [stdout] 34 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/asl.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return true; [INFO] [stdout] 43 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/asl.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return true; [INFO] [stdout] 52 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/bcc.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return false; [INFO] [stdout] 10 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/bcs.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return false; [INFO] [stdout] 9 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/bit.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return true; [INFO] [stdout] 11 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/internal/ops/bit.rs:7:27 [INFO] [stdout] | [INFO] [stdout] 7 | cpu.set_flag(Flag::Z, tmp & 0x00FF); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider reducing it to: `tmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/bit.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return true; [INFO] [stdout] 22 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/internal/ops/bit.rs:18:27 [INFO] [stdout] | [INFO] [stdout] 18 | cpu.set_flag(Flag::Z, tmp & 0x00FF); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider reducing it to: `tmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/brk.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return true; [INFO] [stdout] 23 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return true; [INFO] [stdout] 16 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return true; [INFO] [stdout] 24 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return true; [INFO] [stdout] 32 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return true; [INFO] [stdout] 40 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return true; [INFO] [stdout] 56 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return true; [INFO] [stdout] 72 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return true; [INFO] [stdout] 80 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/internal/ops/lda.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return true; [INFO] [stdout] 96 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IMP` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | IMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Imp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IMM` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | IMM, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Imm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ZPX` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | ZPX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Zpx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ZPY` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | ZPY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Zpy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `REL` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | REL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ABS` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | ABS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Abs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ABX` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | ABX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Abx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ABY` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | ABY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Aby` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IND` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | IND, // Indirect [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ind` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IZX` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | IZX, // aka Indexed Indirect [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Izx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IZY` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | IZY, // aka Indirect Indexed [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Izy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ACC` contains a capitalized acronym [INFO] [stdout] --> src/internal/modes.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | ACC, // accumulator direct [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Acc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/internal/opcodes.rs:149:1 [INFO] [stdout] | [INFO] [stdout] 149 | impl Into for OpCode { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 149 ~ impl From for u8 { [INFO] [stdout] 150 ~ fn from(val: OpCode) -> Self { [INFO] [stdout] 151 ~ match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Flag` should have a snake case name [INFO] [stdout] --> src/flags.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub mod Flag { [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `flag` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `Command { std: "docker" "inspect" "5badd968a1a5c97529100964089f1f74e12159a092a11669cecd56cd63bf94a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5badd968a1a5c97529100964089f1f74e12159a092a11669cecd56cd63bf94a0", kill_on_drop: false }` [INFO] [stdout] 5badd968a1a5c97529100964089f1f74e12159a092a11669cecd56cd63bf94a0