[INFO] cloning repository https://github.com/passcod/catflap [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/passcod/catflap" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpasscod%2Fcatflap", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpasscod%2Fcatflap'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 44415ed0fea43ce9358f6dcd2f64e2b8d857c4ce [INFO] linting passcod/catflap against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpasscod%2Fcatflap" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/passcod/catflap [INFO] finished tweaking git repo https://github.com/passcod/catflap [INFO] tweaked toml for git repo https://github.com/passcod/catflap written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/passcod/catflap on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/passcod/catflap already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hermit-abi v0.1.13 [INFO] [stderr] Downloaded cc v1.0.54 [INFO] [stderr] Downloaded libc v0.2.71 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e5e183891ea7d8b2dde147fb6814058909971c27f55c2e31d824344f7b46eab [INFO] running `Command { std: "docker" "start" "-a" "3e5e183891ea7d8b2dde147fb6814058909971c27f55c2e31d824344f7b46eab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e5e183891ea7d8b2dde147fb6814058909971c27f55c2e31d824344f7b46eab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e5e183891ea7d8b2dde147fb6814058909971c27f55c2e31d824344f7b46eab", kill_on_drop: false }` [INFO] [stdout] 3e5e183891ea7d8b2dde147fb6814058909971c27f55c2e31d824344f7b46eab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 23a0fecbad2d104f1851052de8a0040e046e39cc595099b534e55748d47b894a [INFO] running `Command { std: "docker" "start" "-a" "23a0fecbad2d104f1851052de8a0040e046e39cc595099b534e55748d47b894a", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling nix v0.17.0 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking catflap v1.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sock.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | if !result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/sock.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | let result = Ok(()) [INFO] [stdout] | __________________^ [INFO] [stdout] 30 | | .and_then(|_| setsockopt(sock, sockopt::ReuseAddr, &true)) [INFO] [stdout] 31 | | .and_then(|_| bind(sock, &SockAddr::new_inet( [INFO] [stdout] 32 | | InetAddr::from_std(&addr)) [INFO] [stdout] 33 | | )) [INFO] [stdout] 34 | | .and_then(|_| listen(sock, 1)) [INFO] [stdout] 35 | | .and_then(|_| Ok(sock)); [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ let result = Ok(()) [INFO] [stdout] 30 ~ .and_then(|_| setsockopt(sock, sockopt::ReuseAddr, &true)) [INFO] [stdout] 31 ~ .and_then(|_| bind(sock, &SockAddr::new_inet( [INFO] [stdout] 32 ~ InetAddr::from_std(&addr)) [INFO] [stdout] 33 ~ )) [INFO] [stdout] 34 ~ .and_then(|_| listen(sock, 1)).map(|_| sock); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sock.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | if !result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/sock.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | let result = Ok(()) [INFO] [stdout] | __________________^ [INFO] [stdout] 30 | | .and_then(|_| setsockopt(sock, sockopt::ReuseAddr, &true)) [INFO] [stdout] 31 | | .and_then(|_| bind(sock, &SockAddr::new_inet( [INFO] [stdout] 32 | | InetAddr::from_std(&addr)) [INFO] [stdout] 33 | | )) [INFO] [stdout] 34 | | .and_then(|_| listen(sock, 1)) [INFO] [stdout] 35 | | .and_then(|_| Ok(sock)); [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ let result = Ok(()) [INFO] [stdout] 30 ~ .and_then(|_| setsockopt(sock, sockopt::ReuseAddr, &true)) [INFO] [stdout] 31 ~ .and_then(|_| bind(sock, &SockAddr::new_inet( [INFO] [stdout] 32 ~ InetAddr::from_std(&addr)) [INFO] [stdout] 33 ~ )) [INFO] [stdout] 34 ~ .and_then(|_| listen(sock, 1)).map(|_| sock); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.13s [INFO] running `Command { std: "docker" "inspect" "23a0fecbad2d104f1851052de8a0040e046e39cc595099b534e55748d47b894a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23a0fecbad2d104f1851052de8a0040e046e39cc595099b534e55748d47b894a", kill_on_drop: false }` [INFO] [stdout] 23a0fecbad2d104f1851052de8a0040e046e39cc595099b534e55748d47b894a