[INFO] cloning repository https://github.com/paprykdev/projector_cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/paprykdev/projector_cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpaprykdev%2Fprojector_cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpaprykdev%2Fprojector_cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3cb54335eca4d89ad18c54ca350e349d4203e2a7 [INFO] linting paprykdev/projector_cli against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpaprykdev%2Fprojector_cli" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/paprykdev/projector_cli [INFO] finished tweaking git repo https://github.com/paprykdev/projector_cli [INFO] tweaked toml for git repo https://github.com/paprykdev/projector_cli written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/paprykdev/projector_cli on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/paprykdev/projector_cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.23 [INFO] [stderr] Downloaded anstyle-wincon v3.0.6 [INFO] [stderr] Downloaded collection_macros v0.2.0 [INFO] [stderr] Downloaded clap_derive v4.5.18 [INFO] [stderr] Downloaded anyhow v1.0.95 [INFO] [stderr] Downloaded proc-macro2 v1.0.92 [INFO] [stderr] Downloaded unicode-ident v1.0.14 [INFO] [stderr] Downloaded serde v1.0.217 [INFO] [stderr] Downloaded serde_derive v1.0.217 [INFO] [stderr] Downloaded clap_builder v4.5.23 [INFO] [stderr] Downloaded serde_json v1.0.134 [INFO] [stderr] Downloaded syn v2.0.93 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc54e2b89b6f34f812be922610853a6eb416ba0b55a5a3572e4dec3f2211b048 [INFO] running `Command { std: "docker" "start" "-a" "dc54e2b89b6f34f812be922610853a6eb416ba0b55a5a3572e4dec3f2211b048", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc54e2b89b6f34f812be922610853a6eb416ba0b55a5a3572e4dec3f2211b048", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc54e2b89b6f34f812be922610853a6eb416ba0b55a5a3572e4dec3f2211b048", kill_on_drop: false }` [INFO] [stdout] dc54e2b89b6f34f812be922610853a6eb416ba0b55a5a3572e4dec3f2211b048 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a5cf2ba533597d2d4dedb24e25275415d03bb455a69fc27c01c737f7daac9e62 [INFO] running `Command { std: "docker" "start" "-a" "a5cf2ba533597d2d4dedb24e25275415d03bb455a69fc27c01c737f7daac9e62", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling unicode-ident v1.0.14 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Compiling serde_json v1.0.134 [INFO] [stderr] Compiling anyhow v1.0.95 [INFO] [stderr] Checking clap_builder v4.5.23 [INFO] [stderr] Checking itoa v1.0.14 [INFO] [stderr] Checking collection_macros v0.2.0 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling syn v2.0.93 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Checking clap v4.5.23 [INFO] [stderr] Checking rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | / return Ok(Config { [INFO] [stdout] 23 | | operation, [INFO] [stdout] 24 | | config, [INFO] [stdout] 25 | | pwd, [INFO] [stdout] 26 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 ~ Ok(Config { [INFO] [stdout] 23 + operation, [INFO] [stdout] 24 + config, [INFO] [stdout] 25 + pwd, [INFO] [stdout] 26 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return Ok(Self::Print(Some(arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return Ok(Self::Print(Some(arg))); [INFO] [stdout] 81 + Ok(Self::Print(Some(arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/config.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if value.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `value.get(0)` [INFO] [stdout] --> src/config.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | let term = value.get(0).expect("expect to exist"); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return Ok(loc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return Ok(loc); [INFO] [stdout] 96 + Ok(loc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | return Ok(std::env::current_dir().context("error getting currrent_dir")?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return Ok(std::env::current_dir().context("error getting currrent_dir")?); [INFO] [stdout] 104 + Ok(std::env::current_dir().context("error getting currrent_dir")?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/config.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 104 | return Ok(std::env::current_dir().context("error getting currrent_dir")?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 104 - return Ok(std::env::current_dir().context("error getting currrent_dir")?); [INFO] [stdout] 104 + return std::env::current_dir().context("error getting currrent_dir"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/projector.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | / self.data.projector.get(path).map(|x| { [INFO] [stdout] 36 | | out.extend(x.iter()); [INFO] [stdout] 37 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 35 - self.data.projector.get(path).map(|x| { [INFO] [stdout] 36 - out.extend(x.iter()); [INFO] [stdout] 37 - }); [INFO] [stdout] 35 + if let Some(x) = self.data.projector.get(path) { out.extend(x.iter()); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/projector.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&p).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/projector.rs:58:35 [INFO] [stdout] | [INFO] [stdout] 58 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^ help: change this to: `p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/projector.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return Ok(()); [INFO] [stdout] 31 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bin/projector.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | proj.get_value(&k).map(|x| println!("{}", x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 19 - proj.get_value(&k).map(|x| println!("{}", x)); [INFO] [stdout] 19 + if let Some(x) = proj.get_value(&k) { println!("{}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/projector.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return Ok(()); [INFO] [stdout] 31 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bin/projector.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | proj.get_value(&k).map(|x| println!("{}", x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 19 - proj.get_value(&k).map(|x| println!("{}", x)); [INFO] [stdout] 19 + if let Some(x) = proj.get_value(&k) { println!("{}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | / return Ok(Config { [INFO] [stdout] 23 | | operation, [INFO] [stdout] 24 | | config, [INFO] [stdout] 25 | | pwd, [INFO] [stdout] 26 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 ~ Ok(Config { [INFO] [stdout] 23 + operation, [INFO] [stdout] 24 + config, [INFO] [stdout] 25 + pwd, [INFO] [stdout] 26 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return Ok(Self::Print(Some(arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return Ok(Self::Print(Some(arg))); [INFO] [stdout] 81 + Ok(Self::Print(Some(arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/config.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if value.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `value.get(0)` [INFO] [stdout] --> src/config.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | let term = value.get(0).expect("expect to exist"); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return Ok(loc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return Ok(loc); [INFO] [stdout] 96 + Ok(loc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | return Ok(std::env::current_dir().context("error getting currrent_dir")?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return Ok(std::env::current_dir().context("error getting currrent_dir")?); [INFO] [stdout] 104 + Ok(std::env::current_dir().context("error getting currrent_dir")?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/config.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 104 | return Ok(std::env::current_dir().context("error getting currrent_dir")?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 104 - return Ok(std::env::current_dir().context("error getting currrent_dir")?); [INFO] [stdout] 104 + return std::env::current_dir().context("error getting currrent_dir"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/projector.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | / self.data.projector.get(path).map(|x| { [INFO] [stdout] 36 | | out.extend(x.iter()); [INFO] [stdout] 37 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 35 - self.data.projector.get(path).map(|x| { [INFO] [stdout] 36 - out.extend(x.iter()); [INFO] [stdout] 37 - }); [INFO] [stdout] 35 + if let Some(x) = self.data.projector.get(path) { out.extend(x.iter()); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/projector.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&p).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/projector.rs:58:35 [INFO] [stdout] | [INFO] [stdout] 58 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^ help: change this to: `p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.87s [INFO] running `Command { std: "docker" "inspect" "a5cf2ba533597d2d4dedb24e25275415d03bb455a69fc27c01c737f7daac9e62", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5cf2ba533597d2d4dedb24e25275415d03bb455a69fc27c01c737f7daac9e62", kill_on_drop: false }` [INFO] [stdout] a5cf2ba533597d2d4dedb24e25275415d03bb455a69fc27c01c737f7daac9e62