[INFO] cloning repository https://github.com/otkruchennyy/ascii-art-generator-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/otkruchennyy/ascii-art-generator-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fotkruchennyy%2Fascii-art-generator-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fotkruchennyy%2Fascii-art-generator-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a6ac51bcffdd675ac6117c69c0faccff10c8b478 [INFO] linting otkruchennyy/ascii-art-generator-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fotkruchennyy%2Fascii-art-generator-rs" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/otkruchennyy/ascii-art-generator-rs [INFO] finished tweaking git repo https://github.com/otkruchennyy/ascii-art-generator-rs [INFO] tweaked toml for git repo https://github.com/otkruchennyy/ascii-art-generator-rs written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/otkruchennyy/ascii-art-generator-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 80 packages to latest Rust 1.96.0-nightly compatible versions [INFO] [stderr] Adding dirs v5.0.1 (available: v6.0.0) [INFO] [stderr] Adding image v0.24.9 (available: v0.25.10) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5ea65dbe18f9bda8925973529ea74ea1739acd3de932f07f4f87631e770b6576 [INFO] running `Command { std: "docker" "start" "-a" "5ea65dbe18f9bda8925973529ea74ea1739acd3de932f07f4f87631e770b6576", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5ea65dbe18f9bda8925973529ea74ea1739acd3de932f07f4f87631e770b6576", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ea65dbe18f9bda8925973529ea74ea1739acd3de932f07f4f87631e770b6576", kill_on_drop: false }` [INFO] [stdout] 5ea65dbe18f9bda8925973529ea74ea1739acd3de932f07f4f87631e770b6576 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c9144aae93ad06a63fbf938b0f360eebc4d1a98574dea2be66272e2742356e3 [INFO] running `Command { std: "docker" "start" "-a" "1c9144aae93ad06a63fbf938b0f360eebc4d1a98574dea2be66272e2742356e3", kill_on_drop: false }` [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Checking colorchoice v1.0.5 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Checking anstyle-parse v1.0.0 [INFO] [stderr] Checking anstyle v1.0.14 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking clap_lex v1.1.0 [INFO] [stderr] Checking anyhow v1.0.102 [INFO] [stderr] Checking jpeg-decoder v0.3.2 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking anstream v1.0.0 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Checking clap_builder v4.6.0 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Compiling zerocopy-derive v0.8.42 [INFO] [stderr] Compiling clap_derive v4.6.0 [INFO] [stderr] Checking clap v4.6.0 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking ASCII_generator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/cli/input.rs:25:20 [INFO] [stdout] | [INFO] [stdout] 25 | if num < 20 || num > 400 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `!(20..=400).contains(&num)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/cli/input.rs:165:16 [INFO] [stdout] | [INFO] [stdout] 165 | if utils::file_exists(&new_path) == false || utils::img_path_exists(&new_path) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!utils::file_exists(&new_path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/cli/input.rs:165:58 [INFO] [stdout] | [INFO] [stdout] 165 | if utils::file_exists(&new_path) == false || utils::img_path_exists(&new_path) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!utils::img_path_exists(&new_path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cli/input.rs:192:8 [INFO] [stdout] | [INFO] [stdout] 192 | if get_user_input_bool() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `get_user_input_bool()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helpers/utils.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / (len >= 4 && &path[len-4..] == ".png") || [INFO] [stdout] 7 | | (len >= 4 && &path[len-4..] == ".jpg") || [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 6 - (len >= 4 && &path[len-4..] == ".png") || [INFO] [stdout] 7 - (len >= 4 && &path[len-4..] == ".jpg") || [INFO] [stdout] 6 + !(len < 4 || &path[len-4..] != ".png" && &path[len-4..] != ".jpg") || [INFO] [stdout] | [INFO] [stdout] 6 - (len >= 4 && &path[len-4..] == ".png") || [INFO] [stdout] 7 - (len >= 4 && &path[len-4..] == ".jpg") || [INFO] [stdout] 6 + (&path[len-4..] == ".jpg" || &path[len-4..] == ".png") && len >= 4 || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 47 | if input::get_user_input_bool() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `input::get_user_input_bool()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/cli/input.rs:25:20 [INFO] [stdout] | [INFO] [stdout] 25 | if num < 20 || num > 400 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `!(20..=400).contains(&num)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/cli/input.rs:165:16 [INFO] [stdout] | [INFO] [stdout] 165 | if utils::file_exists(&new_path) == false || utils::img_path_exists(&new_path) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!utils::file_exists(&new_path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/cli/input.rs:165:58 [INFO] [stdout] | [INFO] [stdout] 165 | if utils::file_exists(&new_path) == false || utils::img_path_exists(&new_path) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!utils::img_path_exists(&new_path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cli/input.rs:192:8 [INFO] [stdout] | [INFO] [stdout] 192 | if get_user_input_bool() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `get_user_input_bool()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helpers/utils.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / (len >= 4 && &path[len-4..] == ".png") || [INFO] [stdout] 7 | | (len >= 4 && &path[len-4..] == ".jpg") || [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 6 - (len >= 4 && &path[len-4..] == ".png") || [INFO] [stdout] 7 - (len >= 4 && &path[len-4..] == ".jpg") || [INFO] [stdout] 6 + !(len < 4 || &path[len-4..] != ".png" && &path[len-4..] != ".jpg") || [INFO] [stdout] | [INFO] [stdout] 6 - (len >= 4 && &path[len-4..] == ".png") || [INFO] [stdout] 7 - (len >= 4 && &path[len-4..] == ".jpg") || [INFO] [stdout] 6 + (&path[len-4..] == ".jpg" || &path[len-4..] == ".png") && len >= 4 || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 47 | if input::get_user_input_bool() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `input::get_user_input_bool()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.53s [INFO] running `Command { std: "docker" "inspect" "1c9144aae93ad06a63fbf938b0f360eebc4d1a98574dea2be66272e2742356e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c9144aae93ad06a63fbf938b0f360eebc4d1a98574dea2be66272e2742356e3", kill_on_drop: false }` [INFO] [stdout] 1c9144aae93ad06a63fbf938b0f360eebc4d1a98574dea2be66272e2742356e3