[INFO] cloning repository https://github.com/other8026/create_md_pages [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/other8026/create_md_pages" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fother8026%2Fcreate_md_pages", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fother8026%2Fcreate_md_pages'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 97fea5951c9e47672fce030971d23727b0535e74 [INFO] linting other8026/create_md_pages against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fother8026%2Fcreate_md_pages" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/other8026/create_md_pages [INFO] finished tweaking git repo https://github.com/other8026/create_md_pages [INFO] tweaked toml for git repo https://github.com/other8026/create_md_pages written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/other8026/create_md_pages on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/other8026/create_md_pages already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_derive v1.0.190 [INFO] [stderr] Downloaded proc-macro2 v1.0.69 [INFO] [stderr] Downloaded serde_yaml v0.9.27 [INFO] [stderr] Downloaded unsafe-libyaml v0.2.9 [INFO] [stderr] Downloaded serde v1.0.190 [INFO] [stderr] Downloaded unicode-segmentation v1.10.1 [INFO] [stderr] Downloaded hashbrown v0.14.2 [INFO] [stderr] Downloaded syn v2.0.38 [INFO] [stderr] Downloaded libc v0.2.149 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8191181b227fe9c5fed2126fc5a3676de6dd57f5c6a428a1151eda0308189c0c [INFO] running `Command { std: "docker" "start" "-a" "8191181b227fe9c5fed2126fc5a3676de6dd57f5c6a428a1151eda0308189c0c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8191181b227fe9c5fed2126fc5a3676de6dd57f5c6a428a1151eda0308189c0c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8191181b227fe9c5fed2126fc5a3676de6dd57f5c6a428a1151eda0308189c0c", kill_on_drop: false }` [INFO] [stdout] 8191181b227fe9c5fed2126fc5a3676de6dd57f5c6a428a1151eda0308189c0c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a9ee7a9a6ce625c51bdabb44fa7957014942feeb7467215bc961ca9336fa1abc [INFO] running `Command { std: "docker" "start" "-a" "a9ee7a9a6ce625c51bdabb44fa7957014942feeb7467215bc961ca9336fa1abc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling unicode-segmentation v1.10.1 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking hashbrown v0.14.2 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking unsafe-libyaml v0.2.9 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking indexmap v2.0.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Compiling serde_derive v1.0.190 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking serde_yaml v0.9.27 [INFO] [stderr] Checking create_md_pages v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/structs/app_compat_list.rs:12:26 [INFO] [stdout] | [INFO] [stdout] 12 | const DIV_START_STRING: &'static str = [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/structs/app_compat_list.rs:14:24 [INFO] [stdout] | [INFO] [stdout] 14 | const DIV_END_STRING: &'static str = "{{ raw_html( html = \"\") }}"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/structs/app_compat_list.rs:16:19 [INFO] [stdout] | [INFO] [stdout] 16 | const TOC_CLASS: &'static str = "toc"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/stdin_functions/get_bool_from_user.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | Ok(r?) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 27 - Ok(r?) [INFO] [stdout] 27 + r [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/stdin_functions/get_bool_from_user.rs:16:80 [INFO] [stdout] | [INFO] [stdout] 16 | .map_err(|e| format!("an error occurred while reading input: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/stdin_functions/get_option_bool_from_user.rs:12:76 [INFO] [stdout] | [INFO] [stdout] 12 | .map_err(|e| format!("an error occurred while reading input: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/stdin_functions/get_option_string_from_user.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | if response.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `response.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/stdin_functions/get_string_from_user.rs:15:80 [INFO] [stdout] | [INFO] [stdout] 15 | .map_err(|e| format!("an error occurred while reading input: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/stdin_functions/get_string_from_user.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 18 | if !can_be_empty && r.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `r.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/stdin_functions/mod.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | if trimmed.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trimmed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/structs/app_compat_list.rs:12:26 [INFO] [stdout] | [INFO] [stdout] 12 | const DIV_START_STRING: &'static str = [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/structs/app_compat_list.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / self.apps [INFO] [stdout] 70 | | .sort_by(|a, b| a.app_name.to_lowercase().cmp(&b.app_name.to_lowercase())); [INFO] [stdout] | |______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 70 - .sort_by(|a, b| a.app_name.to_lowercase().cmp(&b.app_name.to_lowercase())); [INFO] [stdout] 70 + .sort_by_key(|a| a.app_name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/structs/app_compat_list.rs:14:24 [INFO] [stdout] | [INFO] [stdout] 14 | const DIV_END_STRING: &'static str = "{{ raw_html( html = \"\") }}"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/structs/app_compat_list.rs:16:19 [INFO] [stdout] | [INFO] [stdout] 16 | const TOC_CLASS: &'static str = "toc"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:32:16 [INFO] [stdout] | [INFO] [stdout] 32 | || !opt.clone().output_md_file.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `opt.clone().output_md_file.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:38:36 [INFO] [stdout] | [INFO] [stdout] 38 | let yaml_file = File::open(&opt.yaml_file.unwrap()).map_err(|e| e.to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `opt.yaml_file.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/stdin_functions/get_bool_from_user.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | Ok(r?) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 27 - Ok(r?) [INFO] [stdout] 27 + r [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/stdin_functions/get_bool_from_user.rs:16:80 [INFO] [stdout] | [INFO] [stdout] 16 | .map_err(|e| format!("an error occurred while reading input: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/stdin_functions/get_option_bool_from_user.rs:12:76 [INFO] [stdout] | [INFO] [stdout] 12 | .map_err(|e| format!("an error occurred while reading input: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/stdin_functions/get_option_string_from_user.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | if response.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `response.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/stdin_functions/get_string_from_user.rs:15:80 [INFO] [stdout] | [INFO] [stdout] 15 | .map_err(|e| format!("an error occurred while reading input: {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/stdin_functions/get_string_from_user.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 18 | if !can_be_empty && r.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `r.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/stdin_functions/mod.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | if trimmed.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trimmed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/structs/app_compat_list.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | / self.apps [INFO] [stdout] 70 | | .sort_by(|a, b| a.app_name.to_lowercase().cmp(&b.app_name.to_lowercase())); [INFO] [stdout] | |______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 70 - .sort_by(|a, b| a.app_name.to_lowercase().cmp(&b.app_name.to_lowercase())); [INFO] [stdout] 70 + .sort_by_key(|a| a.app_name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:32:16 [INFO] [stdout] | [INFO] [stdout] 32 | || !opt.clone().output_md_file.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `opt.clone().output_md_file.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:38:36 [INFO] [stdout] | [INFO] [stdout] 38 | let yaml_file = File::open(&opt.yaml_file.unwrap()).map_err(|e| e.to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `opt.yaml_file.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.81s [INFO] running `Command { std: "docker" "inspect" "a9ee7a9a6ce625c51bdabb44fa7957014942feeb7467215bc961ca9336fa1abc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9ee7a9a6ce625c51bdabb44fa7957014942feeb7467215bc961ca9336fa1abc", kill_on_drop: false }` [INFO] [stdout] a9ee7a9a6ce625c51bdabb44fa7957014942feeb7467215bc961ca9336fa1abc