[INFO] cloning repository https://github.com/origo-labs/aish [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/origo-labs/aish" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Forigo-labs%2Faish", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Forigo-labs%2Faish'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6d369b022a116bd9b0eb44dd2ee56176effecff8 [INFO] linting origo-labs/aish against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Forigo-labs%2Faish" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/origo-labs/aish [INFO] finished tweaking git repo https://github.com/origo-labs/aish [INFO] tweaked toml for git repo https://github.com/origo-labs/aish written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/origo-labs/aish on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/origo-labs/aish already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serial-windows v0.4.0 [INFO] [stderr] Downloaded ioctl-rs v0.1.6 [INFO] [stderr] Downloaded serial v0.4.0 [INFO] [stderr] Downloaded termios v0.2.2 [INFO] [stderr] Downloaded serial-unix v0.4.0 [INFO] [stderr] Downloaded serial-core v0.4.0 [INFO] [stderr] Downloaded portable-pty v0.8.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 091f4fc8ab3ecbf2c9f3af254944a339066c0a020eb66a986efc4aef851daf24 [INFO] running `Command { std: "docker" "start" "-a" "091f4fc8ab3ecbf2c9f3af254944a339066c0a020eb66a986efc4aef851daf24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "091f4fc8ab3ecbf2c9f3af254944a339066c0a020eb66a986efc4aef851daf24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "091f4fc8ab3ecbf2c9f3af254944a339066c0a020eb66a986efc4aef851daf24", kill_on_drop: false }` [INFO] [stdout] 091f4fc8ab3ecbf2c9f3af254944a339066c0a020eb66a986efc4aef851daf24 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 10659583034b58440ef820f5c619ee9ae1d6e99e00dce94ebab485ef5b44d3bf [INFO] running `Command { std: "docker" "start" "-a" "10659583034b58440ef820f5c619ee9ae1d6e99e00dce94ebab485ef5b44d3bf", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Compiling time-macros v0.2.27 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking filedescriptor v0.8.3 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking portable-pty v0.8.1 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking aish-run v0.2.1 (/opt/rustwide/workdir/crates/aish-run) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/aish-run/src/detectors.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 72 | if !detector_enabled(rule.id, enabled_detectors) && !(coverage_command && rule.id == "coverage") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(detector_enabled(rule.id, enabled_detectors) || coverage_command && rule.id == "coverage")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> crates/aish-run/src/detectors.rs:282:28 [INFO] [stdout] | [INFO] [stdout] 282 | commands.is_empty() || commands.iter().any(|name| *name == cmd_name) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `commands.contains(&cmd_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/aish-run/src/detectors.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 72 | if !detector_enabled(rule.id, enabled_detectors) && !(coverage_command && rule.id == "coverage") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(detector_enabled(rule.id, enabled_detectors) || coverage_command && rule.id == "coverage")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> crates/aish-run/src/detectors.rs:282:28 [INFO] [stdout] | [INFO] [stdout] 282 | commands.is_empty() || commands.iter().any(|name| *name == cmd_name) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `commands.contains(&cmd_name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.95s [INFO] running `Command { std: "docker" "inspect" "10659583034b58440ef820f5c619ee9ae1d6e99e00dce94ebab485ef5b44d3bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10659583034b58440ef820f5c619ee9ae1d6e99e00dce94ebab485ef5b44d3bf", kill_on_drop: false }` [INFO] [stdout] 10659583034b58440ef820f5c619ee9ae1d6e99e00dce94ebab485ef5b44d3bf