[INFO] cloning repository https://github.com/oriastanjung/learn-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/oriastanjung/learn-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Foriastanjung%2Flearn-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Foriastanjung%2Flearn-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6d877d86103c04e129bf97cefd4db80660df81ae [INFO] linting oriastanjung/learn-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Foriastanjung%2Flearn-rust" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/oriastanjung/learn-rust [INFO] finished tweaking git repo https://github.com/oriastanjung/learn-rust [INFO] tweaked toml for git repo https://github.com/oriastanjung/learn-rust written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/oriastanjung/learn-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/oriastanjung/learn-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 59ce30919d02efaa6f7e6c5d454aba90dbeaa6dd9e062c0c3dd6a6db0c0a356d [INFO] running `Command { std: "docker" "start" "-a" "59ce30919d02efaa6f7e6c5d454aba90dbeaa6dd9e062c0c3dd6a6db0c0a356d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "59ce30919d02efaa6f7e6c5d454aba90dbeaa6dd9e062c0c3dd6a6db0c0a356d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59ce30919d02efaa6f7e6c5d454aba90dbeaa6dd9e062c0c3dd6a6db0c0a356d", kill_on_drop: false }` [INFO] [stdout] 59ce30919d02efaa6f7e6c5d454aba90dbeaa6dd9e062c0c3dd6a6db0c0a356d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e245c09923bcbd7f92e528af231bbed42219adf12b2fcd5d37f79a2d60df9ad8 [INFO] running `Command { std: "docker" "start" "-a" "e245c09923bcbd7f92e528af231bbed42219adf12b2fcd5d37f79a2d60df9ad8", kill_on_drop: false }` [INFO] [stderr] Checking learn-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `core::num` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use core::num; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::iter::Enumerate` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::iter::Enumerate; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::num` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use core::num; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::iter::Enumerate` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::iter::Enumerate; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 126 | price : price [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `price` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:265:8 [INFO] [stdout] | [INFO] [stdout] 265 | if (val >= 8) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 265 - if (val >= 8) { [INFO] [stdout] 265 + if val >= 8 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:267:14 [INFO] [stdout] | [INFO] [stdout] 267 | }else if (val ==7) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 267 - }else if (val ==7) { [INFO] [stdout] 267 + }else if val ==7 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/utils/utils.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | let a = 10; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `function_a` is never used [INFO] [stdout] --> src/main.rs:165:4 [INFO] [stdout] | [INFO] [stdout] 165 | fn function_a(){ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `function_b` is never used [INFO] [stdout] --> src/main.rs:172:4 [INFO] [stdout] | [INFO] [stdout] 172 | fn function_b(){ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `say_hallow` is never used [INFO] [stdout] --> src/new_main.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn say_hallow(){ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `midware` is never used [INFO] [stdout] --> src/utils/utils.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn midware(){ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/main.rs:356:5 [INFO] [stdout] | [INFO] [stdout] 356 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/utils/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod utils; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `username` is never read [INFO] [stdout] --> src/main.rs:194:24 [INFO] [stdout] | [INFO] [stdout] 194 | let mut username = "orias"; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/utils/utils.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | let a = 10; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | c = !a == b; [INFO] [stdout] | ^^^^^^^ help: try: `a != b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/main.rs:283:14 [INFO] [stdout] | [INFO] [stdout] 283 | }else if value < 8 && value >= 6 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(6..8).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/main.rs:295:14 [INFO] [stdout] | [INFO] [stdout] 295 | }else if value < 8 && value >= 6 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(6..8).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `arr` [INFO] [stdout] --> src/main.rs:396:14 [INFO] [stdout] | [INFO] [stdout] 396 | for i in 0..5{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 396 - for i in 0..5{ [INFO] [stdout] 396 + for in &arr{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `arr` [INFO] [stdout] --> src/main.rs:410:14 [INFO] [stdout] | [INFO] [stdout] 410 | for i in 0..=4{ [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 410 - for i in 0..=4{ [INFO] [stdout] 410 + for in &arr{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 435 | return num1 + num2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 435 - return num1 + num2; [INFO] [stdout] 435 + num1 + num2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/utils/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod utils; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::str::::replace` that must be used [INFO] [stdout] --> src/main.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 205 | name1.replace("Orias", "Ate"); // ga akan berubah, karena dia replace harus ditampung ke var [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this returns the replaced string as a new allocation, without modifying the original [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 205 | let _ = name1.replace("Orias", "Ate"); // ga akan berubah, karena dia replace harus ditampung ke var [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `newName1` should have a snake case name [INFO] [stdout] --> src/main.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | let newName1 = name1.replace("Orias", "Ate"); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `new_name1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.21s [INFO] running `Command { std: "docker" "inspect" "e245c09923bcbd7f92e528af231bbed42219adf12b2fcd5d37f79a2d60df9ad8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e245c09923bcbd7f92e528af231bbed42219adf12b2fcd5d37f79a2d60df9ad8", kill_on_drop: false }` [INFO] [stdout] e245c09923bcbd7f92e528af231bbed42219adf12b2fcd5d37f79a2d60df9ad8