[INFO] cloning repository https://github.com/opendicom/sirius-hip [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/opendicom/sirius-hip" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fopendicom%2Fsirius-hip", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fopendicom%2Fsirius-hip'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5b346c2120929d8cd13e164e8ef167a490f90bc1 [INFO] linting opendicom/sirius-hip against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fopendicom%2Fsirius-hip" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/opendicom/sirius-hip [INFO] finished tweaking git repo https://github.com/opendicom/sirius-hip [INFO] tweaked toml for git repo https://github.com/opendicom/sirius-hip written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/opendicom/sirius-hip on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/opendicom/sirius-hip already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lexical-core v0.8.5 [INFO] [stderr] Downloaded lexical-util v0.8.5 [INFO] [stderr] Downloaded mongodb-internal-macros v3.5.0 [INFO] [stderr] Downloaded dicom-test-files v0.2.1 [INFO] [stderr] Downloaded doc-comment v0.3.4 [INFO] [stderr] Downloaded dicom-json v0.1.0 [INFO] [stderr] Downloaded dicom-transfer-syntax-registry v0.6.2 [INFO] [stderr] Downloaded actix-cors v0.6.5 [INFO] [stderr] Downloaded dicom-parser v0.6.0 [INFO] [stderr] Downloaded clap v4.5.55 [INFO] [stderr] Downloaded async_zip v0.0.18 [INFO] [stderr] Downloaded dicom-core v0.6.3 [INFO] [stderr] Downloaded bson v2.15.0 [INFO] [stderr] Downloaded lexical-write-float v0.8.5 [INFO] [stderr] Downloaded lexical-write-integer v0.8.5 [INFO] [stderr] Downloaded clap_builder v4.5.55 [INFO] [stderr] Downloaded quick-xml v0.28.2 [INFO] [stderr] Downloaded dicom-dictionary-std v0.6.1 [INFO] [stderr] Downloaded moka v0.12.13 [INFO] [stderr] Downloaded lexical-parse-float v0.8.5 [INFO] [stderr] Downloaded zerocopy-derive v0.8.35 [INFO] [stderr] Downloaded zerocopy v0.8.35 [INFO] [stderr] Downloaded dicom-object v0.6.1 [INFO] [stderr] Downloaded jpeg-encoder v0.6.1 [INFO] [stderr] Downloaded mongocrypt v0.3.2 [INFO] [stderr] Downloaded lexical-parse-integer v0.8.6 [INFO] [stderr] Downloaded byteordered v0.6.0 [INFO] [stderr] Downloaded mongodb v3.5.0 [INFO] [stderr] Downloaded dicom-encoding v0.6.1 [INFO] [stderr] Downloaded typed-builder-macro v0.22.0 [INFO] [stderr] Downloaded typed-builder v0.22.0 [INFO] [stderr] Downloaded serde-querystring v0.2.1 [INFO] [stderr] Downloaded mongocrypt-sys v0.1.5+1.15.1 [INFO] [stderr] Downloaded lexical v6.1.1 [INFO] [stderr] Downloaded serde-querystring-actix v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 56d52ba87d59f7bf285833580f20e99e70767a95fd3b228ed77579a0efc75d7a [INFO] running `Command { std: "docker" "start" "-a" "56d52ba87d59f7bf285833580f20e99e70767a95fd3b228ed77579a0efc75d7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "56d52ba87d59f7bf285833580f20e99e70767a95fd3b228ed77579a0efc75d7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56d52ba87d59f7bf285833580f20e99e70767a95fd3b228ed77579a0efc75d7a", kill_on_drop: false }` [INFO] [stdout] 56d52ba87d59f7bf285833580f20e99e70767a95fd3b228ed77579a0efc75d7a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9ff6f7678bf35762490f7ca20447530beb1dde825ba0ed6cebfe7ee5b922d107 [INFO] running `Command { std: "docker" "start" "-a" "9ff6f7678bf35762490f7ca20447530beb1dde825ba0ed6cebfe7ee5b922d107", kill_on_drop: false }` [INFO] [stderr] Compiling find-msvc-tools v0.1.8 [INFO] [stderr] Checking critical-section v1.2.0 [INFO] [stderr] Compiling zerocopy v0.8.35 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Compiling zmij v1.0.17 [INFO] [stderr] Compiling stable_deref_trait v1.2.1 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Compiling bytes v1.11.0 [INFO] [stderr] Compiling cc v1.2.54 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling libm v0.2.16 [INFO] [stderr] Compiling writeable v0.6.2 [INFO] [stderr] Compiling litemap v0.8.1 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling crunchy v0.2.4 [INFO] [stderr] Compiling time-macros v0.2.26 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling base64ct v1.8.3 [INFO] [stderr] Compiling futures-core v0.3.31 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling doc-comment v0.3.4 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Compiling zeroize v1.8.2 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Checking time-core v0.1.8 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Compiling pem-rfc7468 v0.7.0 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Compiling lock_api v0.4.14 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling der v0.7.10 [INFO] [stderr] Checking tinyvec v1.10.0 [INFO] [stderr] Compiling aws-lc-sys v0.37.1 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking flate2 v1.1.8 [INFO] [stderr] Checking time v0.3.46 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling futures-sink v0.3.31 [INFO] [stderr] Compiling utf8_iter v1.0.4 [INFO] [stderr] Compiling allocator-api2 v0.2.21 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Compiling tinyvec_macros v0.1.1 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling parking_lot v0.12.5 [INFO] [stderr] Compiling tokio v1.49.0 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling spki v0.7.3 [INFO] [stderr] Checking safe-transmute v0.11.3 [INFO] [stderr] Compiling slab v0.4.11 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Compiling iana-time-zone v0.1.65 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Compiling futures-task v0.3.31 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling futures-io v0.3.31 [INFO] [stderr] Compiling unicode_categories v0.1.1 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling chrono v0.4.43 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Compiling crc v3.4.0 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling pkcs8 v0.10.2 [INFO] [stderr] Compiling num-iter v0.1.45 [INFO] [stderr] Compiling const-random v0.1.18 [INFO] [stderr] Compiling unicode-normalization v0.1.25 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Compiling sqlformat v0.2.6 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling hashlink v0.8.4 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling unicode-properties v0.1.4 [INFO] [stderr] Compiling event-listener v2.5.3 [INFO] [stderr] Compiling unicode-bidi v0.3.18 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling num-bigint-dig v0.8.6 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling tokio-stream v0.1.18 [INFO] [stderr] Compiling macro_magic_core_macros v0.5.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Compiling derive-syn-parse v0.2.0 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Compiling macro_magic_core v0.5.1 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Compiling pkcs1 v0.7.5 [INFO] [stderr] Checking brotli-decompressor v5.0.0 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Compiling signature v2.2.0 [INFO] [stderr] Compiling bytestring v1.5.0 [INFO] [stderr] Checking byteordered v0.6.0 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking webpki-roots v1.0.5 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Compiling whoami v1.6.1 [INFO] [stderr] Compiling linux-raw-sys v0.11.0 [INFO] [stderr] Compiling base64 v0.21.7 [INFO] [stderr] Compiling semver v1.0.27 [INFO] [stderr] Compiling regex-lite v0.1.8 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling rsa v0.9.10 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking brotli v8.0.2 [INFO] [stderr] Compiling macro_magic_macros v0.5.1 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking ryu v1.0.22 [INFO] [stderr] Compiling home v0.5.12 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling fastrand v2.3.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling enum-as-inner v0.6.1 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking actix-rt v2.11.0 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Checking actix-server v2.6.0 [INFO] [stderr] Compiling rustc_version_runtime v0.3.0 [INFO] [stderr] Checking cookie v0.16.2 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Compiling sqlx-core v0.7.4 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Compiling tempfile v3.24.0 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Checking dicom-core v0.6.3 [INFO] [stderr] Checking tagptr v0.2.0 [INFO] [stderr] Checking data-encoding v2.10.0 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking moka v0.12.13 [INFO] [stderr] Checking hickory-proto v0.25.2 [INFO] [stderr] Checking lexical v6.1.1 [INFO] [stderr] Compiling serde_with_macros v3.16.1 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking dicom-dictionary-std v0.6.1 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Compiling macro_magic v0.5.1 [INFO] [stderr] Compiling typed-builder-macro v0.22.0 [INFO] [stderr] Compiling pin-project-internal v1.1.11 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking serde_bytes v0.11.19 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Compiling sqlx-postgres v0.7.4 [INFO] [stderr] Compiling sqlx-mysql v0.7.4 [INFO] [stderr] Checking resolv-conf v0.7.6 [INFO] [stderr] Checking bson v2.15.0 [INFO] [stderr] Checking dicom-encoding v0.6.1 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking typed-builder v0.22.0 [INFO] [stderr] Checking simple_asn1 v0.6.3 [INFO] [stderr] Checking pin-project v1.1.11 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking clap_builder v4.5.55 [INFO] [stderr] Checking dicom-transfer-syntax-registry v0.6.2 [INFO] [stderr] Checking dicom-parser v0.6.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling mongodb-internal-macros v3.5.0 [INFO] [stderr] Checking serde_with v3.16.1 [INFO] [stderr] Checking hickory-resolver v0.25.2 [INFO] [stderr] Checking serde-querystring v0.2.1 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Compiling derive-where v1.6.0 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking dicom-object v0.6.1 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking humantime v2.3.0 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking jsonwebtoken v8.3.0 [INFO] [stderr] Checking async_zip v0.0.18 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking quick-xml v0.28.2 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking clap v4.5.55 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Compiling sqlx-macros-core v0.7.4 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Checking actix-http v3.11.2 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Compiling sqlx-macros v0.7.4 [INFO] [stderr] Checking actix-web v4.12.1 [INFO] [stderr] Checking sqlx v0.7.4 [INFO] [stderr] Checking actix-cors v0.6.5 [INFO] [stderr] Checking serde-querystring-actix v0.2.0 [INFO] [stderr] Compiling aws-lc-rs v1.16.0 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking ureq v2.12.1 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking mongodb v3.5.0 [INFO] [stderr] Checking reqwest v0.13.2 [INFO] [stderr] Checking dicom-test-files v0.2.1 [INFO] [stderr] Checking dicom-json v0.1.0 [INFO] [stderr] Checking sirius-hip v1.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this is an `else if` but the formatting might hide it [INFO] [stdout] --> src/pacs/infrastructure/dcm4chee440/mysql/study_repository.rs:768:14 [INFO] [stdout] | [INFO] [stdout] 768 | } else [INFO] [stdout] | ______________^ [INFO] [stdout] 769 | | if let Some(col) = override_col(overrides, "PatientID") { [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stdout] = note: `#[warn(clippy::suspicious_else_formatting)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/api/utils/wado_proxy.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use reqwest; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/state2.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use reqwest; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/application/use_cases/study_token.rs:1296:13 [INFO] [stdout] | [INFO] [stdout] 1296 | session_id: session_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `session_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/application/use_cases/study_token.rs:1297:13 [INFO] [stdout] | [INFO] [stdout] 1297 | base_url: base_url, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `base_url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is an `else if` but the formatting might hide it [INFO] [stdout] --> src/pacs/infrastructure/dcm4chee440/mysql/study_repository.rs:768:14 [INFO] [stdout] | [INFO] [stdout] 768 | } else [INFO] [stdout] | ______________^ [INFO] [stdout] 769 | | if let Some(col) = override_col(overrides, "PatientID") { [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stdout] = note: `#[warn(clippy::suspicious_else_formatting)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/api/utils/wado_proxy.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use reqwest; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/state2.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use reqwest; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/application/use_cases/study_token.rs:1296:13 [INFO] [stdout] | [INFO] [stdout] 1296 | session_id: session_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `session_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/application/use_cases/study_token.rs:1297:13 [INFO] [stdout] | [INFO] [stdout] 1297 | base_url: base_url, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `base_url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_token` is never used [INFO] [stdout] --> src/api/utils/token.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 40 | pub(crate) fn extract_token(req: &HttpRequest, query_token: Option<&str>) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `fuzzymatching` is never read [INFO] [stdout] --> src/api/qido_handler.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct QidoStudiesParams{ [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 50 | pub fuzzymatching:Option, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `QidoStudiesParams` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FilesystemPath` is never constructed [INFO] [stdout] --> src/dicomzip/stream.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 174 | pub enum EntrySource { [INFO] [stdout] | ----------- variant in this enum [INFO] [stdout] 175 | /// Read bytes from a local filesystem path. [INFO] [stdout] 176 | FilesystemPath(PathBuf), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EntrySource` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from_url_string` is never used [INFO] [stdout] --> src/dicomzip/stream.rs:187:8 [INFO] [stdout] | [INFO] [stdout] 186 | impl EntrySource { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 187 | fn from_url_string(url: &str) -> anyhow::Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_entry` and `add_filesystem_entry` are never used [INFO] [stdout] --> src/dicomzip/stream.rs:237:12 [INFO] [stdout] | [INFO] [stdout] 213 | impl DicomStreamZip { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 237 | pub fn add_entry(&mut self, name: &str, url: &str) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 244 | pub fn add_filesystem_entry(&mut self, name: &str, path: impl Into) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/settings/mod.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | /// Used to control access to resources based on JWT tokens [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 76 | /// Used to control access to resources based on JWT tokens [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth.rs:24:31 [INFO] [stdout] | [INFO] [stdout] 24 | jwt::decode::(&token, &secret, &validation) [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/utils/patient.rs:11:57 [INFO] [stdout] | [INFO] [stdout] 11 | let birthdate:String = birthdate.chars().filter(|c| c.is_digit(10)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NaiveDateTime` which implements the `Copy` trait [INFO] [stdout] --> src/pacs/infrastructure/dcm4chee2183/mysql/study_repository.rs:301:32 [INFO] [stdout] | [INFO] [stdout] 301 | .push_bind(cutoff.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*cutoff` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/pacs/infrastructure/dcm4chee2183/mysql/study_repository.rs:532:42 [INFO] [stdout] | [INFO] [stdout] 532 | qb.push(" LIMIT ").push_bind(max as u64); [INFO] [stdout] | ^^^^^^^^^^ help: try: `max` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/pacs/infrastructure/dcm4chee440/mysql/study_repository.rs:176:13 [INFO] [stdout] | [INFO] [stdout] 176 | / match patient_id_override.as_deref() { [INFO] [stdout] 177 | | Some(c) [INFO] [stdout] 178 | | if c.starts_with("patient.") [INFO] [stdout] 179 | | || c.starts_with("person_name.") [INFO] [stdout] ... | [INFO] [stdout] 184 | | _ => false, [INFO] [stdout] 185 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 176 ~ matches!(patient_id_override.as_deref(), Some(c) if c.starts_with("patient.") [INFO] [stdout] 177 + || c.starts_with("person_name.") [INFO] [stdout] 178 + || c.starts_with("patient_id")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NaiveDateTime` which implements the `Copy` trait [INFO] [stdout] --> src/pacs/infrastructure/dcm4chee440/mysql/study_repository.rs:330:32 [INFO] [stdout] | [INFO] [stdout] 330 | .push_bind(cutoff.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*cutoff` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/pacs/infrastructure/dcm4chee440/mysql/study_repository.rs:593:42 [INFO] [stdout] | [INFO] [stdout] 593 | qb.push(" LIMIT ").push_bind(max as u64); [INFO] [stdout] | ^^^^^^^^^^ help: try: `max` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/api/utils/wado_proxy.rs:22:48 [INFO] [stdout] | [INFO] [stdout] 22 | .filter(|(h, _)| should_forward_header(*h)) [INFO] [stdout] | ^^ help: try: `h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/api/utils/wado_proxy.rs:34:23 [INFO] [stdout] | [INFO] [stdout] 34 | chunk.map_err(|e| actix_web::error::ErrorInternalServerError(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `actix_web::error::ErrorInternalServerError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `RefCell` reference is held across an await point [INFO] [stdout] --> src/api/study_token_handler.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | let conn = req.connection_info(); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: ensure the reference is dropped before calling `await` [INFO] [stdout] note: these are all the await points this reference is held through [INFO] [stdout] --> src/api/study_token_handler.rs:122:6 [INFO] [stdout] | [INFO] [stdout] 122 | .await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref [INFO] [stdout] = note: `#[warn(clippy::await_holding_refcell_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/api/files_handler.rs:90:39 [INFO] [stdout] | [INFO] [stdout] 90 | chunk.map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 90 - chunk.map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e)) [INFO] [stdout] 90 + chunk.map_err(|e| std::io::Error::other(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/api/wado_handler.rs:130:47 [INFO] [stdout] | [INFO] [stdout] 130 | ... chunk.map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 130 - chunk.map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e)) [INFO] [stdout] 130 + chunk.map_err(|e| std::io::Error::other(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/application/infrastructure/mysql/download_session_repository.rs:868:9 [INFO] [stdout] | [INFO] [stdout] 868 | / if now_ts > last_ts && (now_ts - last_ts) >= 10 * 60 { [INFO] [stdout] 869 | | if LAST_ONE_TIME_TOKEN_CLEANUP_TS [INFO] [stdout] 870 | | .compare_exchange(last_ts, now_ts, Ordering::Relaxed, Ordering::Relaxed) [INFO] [stdout] 871 | | .is_ok() [INFO] [stdout] ... | [INFO] [stdout] 883 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 868 ~ if now_ts > last_ts && (now_ts - last_ts) >= 10 * 60 [INFO] [stdout] 869 ~ && LAST_ONE_TIME_TOKEN_CLEANUP_TS [INFO] [stdout] 870 | .compare_exchange(last_ts, now_ts, Ordering::Relaxed, Ordering::Relaxed) [INFO] [stdout] ... [INFO] [stdout] 881 | .await; [INFO] [stdout] 882 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/application/infrastructure/mysql/download_session_repository.rs:922:29 [INFO] [stdout] | [INFO] [stdout] 922 | let session_batch = self.cleanup_cfg.session_batch.max(1).min(5000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `self.cleanup_cfg.session_batch.clamp(1, 5000)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/application/infrastructure/mysql/download_session_repository.rs:923:27 [INFO] [stdout] | [INFO] [stdout] 923 | let max_batches = self.cleanup_cfg.max_batches.max(1).min(500); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `self.cleanup_cfg.max_batches.clamp(1, 500)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/application/infrastructure/mysql/download_session_repository.rs:924:34 [INFO] [stdout] | [INFO] [stdout] 924 | let token_delete_limit = self.cleanup_cfg.token_delete_limit.max(1).min(200_000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `self.cleanup_cfg.token_delete_limit.clamp(1, 200_000)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/application/models/manifests/ohif.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | pub studies: Box> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] = note: `#[warn(clippy::box_collection)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/application/use_cases/study_token.rs:370:25 [INFO] [stdout] | [INFO] [stdout] 370 | / if out.photometric_interpretation.is_none() { [INFO] [stdout] 371 | | let s = trim_dicom_str(value); [INFO] [stdout] 372 | | if !s.is_empty() { [INFO] [stdout] 373 | | out.photometric_interpretation = Some(s); [INFO] [stdout] 374 | | } [INFO] [stdout] 375 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 368 ~ (0x0028, 0x0004) [INFO] [stdout] 369 | // PhotometricInterpretation [INFO] [stdout] 370 ~ if out.photometric_interpretation.is_none() => { [INFO] [stdout] 371 | let s = trim_dicom_str(value); [INFO] [stdout] ... [INFO] [stdout] 374 | } [INFO] [stdout] 375 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `anyhow::Error` [INFO] [stdout] --> src/application/use_cases/study_token.rs:445:53 [INFO] [stdout] | [INFO] [stdout] 445 | .map_err(|e| AppError::Internal(e.into()))? [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/application/use_cases/study_token.rs:460:37 [INFO] [stdout] | [INFO] [stdout] 460 | let bytes = row [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 461 | | .study_attrs [INFO] [stdout] 462 | | .as_deref() [INFO] [stdout] 463 | | .or_else(|| row.inst_attrs.as_deref())?; [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `or` instead [INFO] [stdout] | [INFO] [stdout] 463 - .or_else(|| row.inst_attrs.as_deref())?; [INFO] [stdout] 463 + .or(row.inst_attrs.as_deref())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `anyhow::Error` [INFO] [stdout] --> src/application/use_cases/study_token.rs:513:53 [INFO] [stdout] | [INFO] [stdout] 513 | .map_err(|e| AppError::Internal(e.into()))?; [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `anyhow::Error` [INFO] [stdout] --> src/application/use_cases/study_token.rs:562:49 [INFO] [stdout] | [INFO] [stdout] 562 | .map_err(|e| AppError::Internal(e.into()))?; [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_token` is never used [INFO] [stdout] --> src/api/utils/token.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 40 | pub(crate) fn extract_token(req: &HttpRequest, query_token: Option<&str>) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `fuzzymatching` is never read [INFO] [stdout] --> src/api/qido_handler.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct QidoStudiesParams{ [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 50 | pub fuzzymatching:Option, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `QidoStudiesParams` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from_url_string` is never used [INFO] [stdout] --> src/dicomzip/stream.rs:187:8 [INFO] [stdout] | [INFO] [stdout] 186 | impl EntrySource { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 187 | fn from_url_string(url: &str) -> anyhow::Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_entry` is never used [INFO] [stdout] --> src/dicomzip/stream.rs:237:12 [INFO] [stdout] | [INFO] [stdout] 213 | impl DicomStreamZip { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 237 | pub fn add_entry(&mut self, name: &str, url: &str) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:91:42 [INFO] [stdout] | [INFO] [stdout] 91 | let content = fs::read_to_string(&conf_file) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `conf_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:316:13 [INFO] [stdout] | [INFO] [stdout] 242 | / let app = App::new() [INFO] [stdout] 243 | | .wrap(cors) [INFO] [stdout] 244 | | .wrap(Logger::new( [INFO] [stdout] 245 | | "%a \"%r\" %s %b \"%{Referer}i\" \"%{User-Agent}i\" %T %{X-Error-Id}o", [INFO] [stdout] ... | [INFO] [stdout] 315 | | ); [INFO] [stdout] | |______________- unnecessary `let` binding [INFO] [stdout] 316 | app [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 242 ~ [INFO] [stdout] 243 ~ App::new() [INFO] [stdout] 244 + .wrap(cors) [INFO] [stdout] 245 + .wrap(Logger::new( [INFO] [stdout] 246 + "%a \"%r\" %s %b \"%{Referer}i\" \"%{User-Agent}i\" %T %{X-Error-Id}o", [INFO] [stdout] 247 + )) [INFO] [stdout] 248 + //.wrap(Logger::new("%a %{User-Agent}i")) [INFO] [stdout] 249 + .wrap(middleware::Compress::default()) [INFO] [stdout] 250 + .app_data(app_state.clone()) [INFO] [stdout] 251 + .route("/echo", web::get().to(api::echo_handler)) [INFO] [stdout] 252 + .route("/settings", web::get().to(api::settings_handler)) [INFO] [stdout] 253 + [INFO] [stdout] 254 + // Download endpoint. [INFO] [stdout] 255 + // - JwtAuthMethod::OneTime: denies re-downloads (bitset enforcement) [INFO] [stdout] 256 + // - JwtAuthMethod::{Standard,None}: streams/proxies without one-time enforcement [INFO] [stdout] 257 + .route( [INFO] [stdout] 258 + "/files/{session_id}/{file_index}", [INFO] [stdout] 259 + web::get().to(api::download_file_handler), [INFO] [stdout] 260 + ) [INFO] [stdout] 261 + [INFO] [stdout] 262 + .service(web::scope("/studyToken") [INFO] [stdout] 263 + .app_data(web::QueryConfig::default().error_handler(|err, _req| { [INFO] [stdout] 264 + // Keep client-facing errors sanitized and consistent. [INFO] [stdout] 265 + // AppError logs the detail (we only emit a generic 400). [INFO] [stdout] 266 + actix_web::error::InternalError::from_response( [INFO] [stdout] 267 + err, [INFO] [stdout] 268 + AppError::bad_request("invalid query parameters").error_response(), [INFO] [stdout] 269 + ) [INFO] [stdout] 270 + .into() [INFO] [stdout] 271 + })) [INFO] [stdout] 272 + .service(web::resource("") [INFO] [stdout] 273 + .route(actix_web::web::get().to(api::study_token_handler))) [INFO] [stdout] 274 + ) [INFO] [stdout] 275 + [INFO] [stdout] 276 + [INFO] [stdout] 277 + // -- WADO PROXY------------------------------------------------------------------------------------ // [INFO] [stdout] 278 + .route("/wado", web::get().to(api::wado_handler)) [INFO] [stdout] 279 + [INFO] [stdout] 280 + [INFO] [stdout] 281 + // -- QIDO ------------------------------------------------------------------------------------------ // [INFO] [stdout] 282 + // SearchForStudies [INFO] [stdout] 283 + .service(web::scope("/qido") [INFO] [stdout] 284 + .service( [INFO] [stdout] 285 + web::resource("/studies") [INFO] [stdout] 286 + .app_data(qido_qs.clone()) [INFO] [stdout] 287 + .route(web::get().to(api::qido_studies_handler)) [INFO] [stdout] 288 + ) [INFO] [stdout] 289 + // SearchForSeries [INFO] [stdout] 290 + .service( [INFO] [stdout] 291 + web::resource("/studies/{StudyInstanceUID}/series") [INFO] [stdout] 292 + .app_data(qido_qs.clone()) [INFO] [stdout] 293 + .route(web::get().to(|| async { HttpResponse::NotImplemented().finish() })) [INFO] [stdout] 294 + ) [INFO] [stdout] 295 + .service( [INFO] [stdout] 296 + web::resource("/series") [INFO] [stdout] 297 + .app_data(qido_qs.clone()) [INFO] [stdout] 298 + .route(web::get().to(|| async { HttpResponse::NotImplemented().finish() })) [INFO] [stdout] 299 + ) [INFO] [stdout] 300 + // SearchForInstances [INFO] [stdout] 301 + .service( [INFO] [stdout] 302 + web::resource("/studies/{StudyInstanceUID}/series/{SeriesInstanceUID}/instances") [INFO] [stdout] 303 + .app_data(qido_qs.clone()) [INFO] [stdout] 304 + .route(web::get().to(|| async { HttpResponse::NotImplemented().finish() })) [INFO] [stdout] 305 + ) [INFO] [stdout] 306 + .service( [INFO] [stdout] 307 + web::resource("/studies/{StudyInstanceUID}/instances") [INFO] [stdout] 308 + .app_data(qido_qs.clone()) [INFO] [stdout] 309 + .route(web::get().to(|| async { HttpResponse::NotImplemented().finish() })) [INFO] [stdout] 310 + ) [INFO] [stdout] 311 + .service( [INFO] [stdout] 312 + web::resource("/instances") [INFO] [stdout] 313 + .app_data(qido_qs.clone()) [INFO] [stdout] 314 + .route(web::get().to(|| async { HttpResponse::NotImplemented().finish() })) [INFO] [stdout] 315 + ) [INFO] [stdout] 316 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/settings/mod.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | /// Used to control access to resources based on JWT tokens [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 76 | /// Used to control access to resources based on JWT tokens [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth.rs:24:31 [INFO] [stdout] | [INFO] [stdout] 24 | jwt::decode::(&token, &secret, &validation) [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/utils/patient.rs:11:57 [INFO] [stdout] | [INFO] [stdout] 11 | let birthdate:String = birthdate.chars().filter(|c| c.is_digit(10)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NaiveDateTime` which implements the `Copy` trait [INFO] [stdout] --> src/pacs/infrastructure/dcm4chee2183/mysql/study_repository.rs:301:32 [INFO] [stdout] | [INFO] [stdout] 301 | .push_bind(cutoff.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*cutoff` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/pacs/infrastructure/dcm4chee2183/mysql/study_repository.rs:532:42 [INFO] [stdout] | [INFO] [stdout] 532 | qb.push(" LIMIT ").push_bind(max as u64); [INFO] [stdout] | ^^^^^^^^^^ help: try: `max` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/pacs/infrastructure/dcm4chee440/mysql/study_repository.rs:176:13 [INFO] [stdout] | [INFO] [stdout] 176 | / match patient_id_override.as_deref() { [INFO] [stdout] 177 | | Some(c) [INFO] [stdout] 178 | | if c.starts_with("patient.") [INFO] [stdout] 179 | | || c.starts_with("person_name.") [INFO] [stdout] ... | [INFO] [stdout] 184 | | _ => false, [INFO] [stdout] 185 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 176 ~ matches!(patient_id_override.as_deref(), Some(c) if c.starts_with("patient.") [INFO] [stdout] 177 + || c.starts_with("person_name.") [INFO] [stdout] 178 + || c.starts_with("patient_id")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `NaiveDateTime` which implements the `Copy` trait [INFO] [stdout] --> src/pacs/infrastructure/dcm4chee440/mysql/study_repository.rs:330:32 [INFO] [stdout] | [INFO] [stdout] 330 | .push_bind(cutoff.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*cutoff` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/pacs/infrastructure/dcm4chee440/mysql/study_repository.rs:593:42 [INFO] [stdout] | [INFO] [stdout] 593 | qb.push(" LIMIT ").push_bind(max as u64); [INFO] [stdout] | ^^^^^^^^^^ help: try: `max` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/api/utils/wado_proxy.rs:22:48 [INFO] [stdout] | [INFO] [stdout] 22 | .filter(|(h, _)| should_forward_header(*h)) [INFO] [stdout] | ^^ help: try: `h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/api/utils/wado_proxy.rs:34:23 [INFO] [stdout] | [INFO] [stdout] 34 | chunk.map_err(|e| actix_web::error::ErrorInternalServerError(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `actix_web::error::ErrorInternalServerError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `RefCell` reference is held across an await point [INFO] [stdout] --> src/api/study_token_handler.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | let conn = req.connection_info(); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: ensure the reference is dropped before calling `await` [INFO] [stdout] note: these are all the await points this reference is held through [INFO] [stdout] --> src/api/study_token_handler.rs:122:6 [INFO] [stdout] | [INFO] [stdout] 122 | .await?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref [INFO] [stdout] = note: `#[warn(clippy::await_holding_refcell_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/api/files_handler.rs:90:39 [INFO] [stdout] | [INFO] [stdout] 90 | chunk.map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 90 - chunk.map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e)) [INFO] [stdout] 90 + chunk.map_err(|e| std::io::Error::other(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/api/wado_handler.rs:130:47 [INFO] [stdout] | [INFO] [stdout] 130 | ... chunk.map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 130 - chunk.map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e)) [INFO] [stdout] 130 + chunk.map_err(|e| std::io::Error::other(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/application/infrastructure/mysql/download_session_repository.rs:868:9 [INFO] [stdout] | [INFO] [stdout] 868 | / if now_ts > last_ts && (now_ts - last_ts) >= 10 * 60 { [INFO] [stdout] 869 | | if LAST_ONE_TIME_TOKEN_CLEANUP_TS [INFO] [stdout] 870 | | .compare_exchange(last_ts, now_ts, Ordering::Relaxed, Ordering::Relaxed) [INFO] [stdout] 871 | | .is_ok() [INFO] [stdout] ... | [INFO] [stdout] 883 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 868 ~ if now_ts > last_ts && (now_ts - last_ts) >= 10 * 60 [INFO] [stdout] 869 ~ && LAST_ONE_TIME_TOKEN_CLEANUP_TS [INFO] [stdout] 870 | .compare_exchange(last_ts, now_ts, Ordering::Relaxed, Ordering::Relaxed) [INFO] [stdout] ... [INFO] [stdout] 881 | .await; [INFO] [stdout] 882 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/application/infrastructure/mysql/download_session_repository.rs:922:29 [INFO] [stdout] | [INFO] [stdout] 922 | let session_batch = self.cleanup_cfg.session_batch.max(1).min(5000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `self.cleanup_cfg.session_batch.clamp(1, 5000)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/application/infrastructure/mysql/download_session_repository.rs:923:27 [INFO] [stdout] | [INFO] [stdout] 923 | let max_batches = self.cleanup_cfg.max_batches.max(1).min(500); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `self.cleanup_cfg.max_batches.clamp(1, 500)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/application/infrastructure/mysql/download_session_repository.rs:924:34 [INFO] [stdout] | [INFO] [stdout] 924 | let token_delete_limit = self.cleanup_cfg.token_delete_limit.max(1).min(200_000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `self.cleanup_cfg.token_delete_limit.clamp(1, 200_000)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/application/models/manifests/ohif.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 9 | pub studies: Box> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] = note: `#[warn(clippy::box_collection)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/application/use_cases/study_token.rs:370:25 [INFO] [stdout] | [INFO] [stdout] 370 | / if out.photometric_interpretation.is_none() { [INFO] [stdout] 371 | | let s = trim_dicom_str(value); [INFO] [stdout] 372 | | if !s.is_empty() { [INFO] [stdout] 373 | | out.photometric_interpretation = Some(s); [INFO] [stdout] 374 | | } [INFO] [stdout] 375 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 368 ~ (0x0028, 0x0004) [INFO] [stdout] 369 | // PhotometricInterpretation [INFO] [stdout] 370 ~ if out.photometric_interpretation.is_none() => { [INFO] [stdout] 371 | let s = trim_dicom_str(value); [INFO] [stdout] ... [INFO] [stdout] 374 | } [INFO] [stdout] 375 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `anyhow::Error` [INFO] [stdout] --> src/application/use_cases/study_token.rs:445:53 [INFO] [stdout] | [INFO] [stdout] 445 | .map_err(|e| AppError::Internal(e.into()))? [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/application/use_cases/study_token.rs:460:37 [INFO] [stdout] | [INFO] [stdout] 460 | let bytes = row [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 461 | | .study_attrs [INFO] [stdout] 462 | | .as_deref() [INFO] [stdout] 463 | | .or_else(|| row.inst_attrs.as_deref())?; [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `or` instead [INFO] [stdout] | [INFO] [stdout] 463 - .or_else(|| row.inst_attrs.as_deref())?; [INFO] [stdout] 463 + .or(row.inst_attrs.as_deref())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `anyhow::Error` [INFO] [stdout] --> src/application/use_cases/study_token.rs:513:53 [INFO] [stdout] | [INFO] [stdout] 513 | .map_err(|e| AppError::Internal(e.into()))?; [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `anyhow::Error` [INFO] [stdout] --> src/application/use_cases/study_token.rs:562:49 [INFO] [stdout] | [INFO] [stdout] 562 | .map_err(|e| AppError::Internal(e.into()))?; [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:91:42 [INFO] [stdout] | [INFO] [stdout] 91 | let content = fs::read_to_string(&conf_file) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `conf_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:316:13 [INFO] [stdout] | [INFO] [stdout] 242 | / let app = App::new() [INFO] [stdout] 243 | | .wrap(cors) [INFO] [stdout] 244 | | .wrap(Logger::new( [INFO] [stdout] 245 | | "%a \"%r\" %s %b \"%{Referer}i\" \"%{User-Agent}i\" %T %{X-Error-Id}o", [INFO] [stdout] ... | [INFO] [stdout] 315 | | ); [INFO] [stdout] | |______________- unnecessary `let` binding [INFO] [stdout] 316 | app [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 242 ~ [INFO] [stdout] 243 ~ App::new() [INFO] [stdout] 244 + .wrap(cors) [INFO] [stdout] 245 + .wrap(Logger::new( [INFO] [stdout] 246 + "%a \"%r\" %s %b \"%{Referer}i\" \"%{User-Agent}i\" %T %{X-Error-Id}o", [INFO] [stdout] 247 + )) [INFO] [stdout] 248 + //.wrap(Logger::new("%a %{User-Agent}i")) [INFO] [stdout] 249 + .wrap(middleware::Compress::default()) [INFO] [stdout] 250 + .app_data(app_state.clone()) [INFO] [stdout] 251 + .route("/echo", web::get().to(api::echo_handler)) [INFO] [stdout] 252 + .route("/settings", web::get().to(api::settings_handler)) [INFO] [stdout] 253 + [INFO] [stdout] 254 + // Download endpoint. [INFO] [stdout] 255 + // - JwtAuthMethod::OneTime: denies re-downloads (bitset enforcement) [INFO] [stdout] 256 + // - JwtAuthMethod::{Standard,None}: streams/proxies without one-time enforcement [INFO] [stdout] 257 + .route( [INFO] [stdout] 258 + "/files/{session_id}/{file_index}", [INFO] [stdout] 259 + web::get().to(api::download_file_handler), [INFO] [stdout] 260 + ) [INFO] [stdout] 261 + [INFO] [stdout] 262 + .service(web::scope("/studyToken") [INFO] [stdout] 263 + .app_data(web::QueryConfig::default().error_handler(|err, _req| { [INFO] [stdout] 264 + // Keep client-facing errors sanitized and consistent. [INFO] [stdout] 265 + // AppError logs the detail (we only emit a generic 400). [INFO] [stdout] 266 + actix_web::error::InternalError::from_response( [INFO] [stdout] 267 + err, [INFO] [stdout] 268 + AppError::bad_request("invalid query parameters").error_response(), [INFO] [stdout] 269 + ) [INFO] [stdout] 270 + .into() [INFO] [stdout] 271 + })) [INFO] [stdout] 272 + .service(web::resource("") [INFO] [stdout] 273 + .route(actix_web::web::get().to(api::study_token_handler))) [INFO] [stdout] 274 + ) [INFO] [stdout] 275 + [INFO] [stdout] 276 + [INFO] [stdout] 277 + // -- WADO PROXY------------------------------------------------------------------------------------ // [INFO] [stdout] 278 + .route("/wado", web::get().to(api::wado_handler)) [INFO] [stdout] 279 + [INFO] [stdout] 280 + [INFO] [stdout] 281 + // -- QIDO ------------------------------------------------------------------------------------------ // [INFO] [stdout] 282 + // SearchForStudies [INFO] [stdout] 283 + .service(web::scope("/qido") [INFO] [stdout] 284 + .service( [INFO] [stdout] 285 + web::resource("/studies") [INFO] [stdout] 286 + .app_data(qido_qs.clone()) [INFO] [stdout] 287 + .route(web::get().to(api::qido_studies_handler)) [INFO] [stdout] 288 + ) [INFO] [stdout] 289 + // SearchForSeries [INFO] [stdout] 290 + .service( [INFO] [stdout] 291 + web::resource("/studies/{StudyInstanceUID}/series") [INFO] [stdout] 292 + .app_data(qido_qs.clone()) [INFO] [stdout] 293 + .route(web::get().to(|| async { HttpResponse::NotImplemented().finish() })) [INFO] [stdout] 294 + ) [INFO] [stdout] 295 + .service( [INFO] [stdout] 296 + web::resource("/series") [INFO] [stdout] 297 + .app_data(qido_qs.clone()) [INFO] [stdout] 298 + .route(web::get().to(|| async { HttpResponse::NotImplemented().finish() })) [INFO] [stdout] 299 + ) [INFO] [stdout] 300 + // SearchForInstances [INFO] [stdout] 301 + .service( [INFO] [stdout] 302 + web::resource("/studies/{StudyInstanceUID}/series/{SeriesInstanceUID}/instances") [INFO] [stdout] 303 + .app_data(qido_qs.clone()) [INFO] [stdout] 304 + .route(web::get().to(|| async { HttpResponse::NotImplemented().finish() })) [INFO] [stdout] 305 + ) [INFO] [stdout] 306 + .service( [INFO] [stdout] 307 + web::resource("/studies/{StudyInstanceUID}/instances") [INFO] [stdout] 308 + .app_data(qido_qs.clone()) [INFO] [stdout] 309 + .route(web::get().to(|| async { HttpResponse::NotImplemented().finish() })) [INFO] [stdout] 310 + ) [INFO] [stdout] 311 + .service( [INFO] [stdout] 312 + web::resource("/instances") [INFO] [stdout] 313 + .app_data(qido_qs.clone()) [INFO] [stdout] 314 + .route(web::get().to(|| async { HttpResponse::NotImplemented().finish() })) [INFO] [stdout] 315 + ) [INFO] [stdout] 316 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 08s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: sqlx-postgres v0.7.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 5` [INFO] running `Command { std: "docker" "inspect" "9ff6f7678bf35762490f7ca20447530beb1dde825ba0ed6cebfe7ee5b922d107", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ff6f7678bf35762490f7ca20447530beb1dde825ba0ed6cebfe7ee5b922d107", kill_on_drop: false }` [INFO] [stdout] 9ff6f7678bf35762490f7ca20447530beb1dde825ba0ed6cebfe7ee5b922d107