[INFO] cloning repository https://github.com/onelin789/AdventOfCode2020 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/onelin789/AdventOfCode2020" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fonelin789%2FAdventOfCode2020", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fonelin789%2FAdventOfCode2020'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 30ba12f7d343b75036c5ffd97abf0782cc48dc21 [INFO] linting onelin789/AdventOfCode2020 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fonelin789%2FAdventOfCode2020" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/onelin789/AdventOfCode2020 [INFO] finished tweaking git repo https://github.com/onelin789/AdventOfCode2020 [INFO] tweaked toml for git repo https://github.com/onelin789/AdventOfCode2020 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/onelin789/AdventOfCode2020 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/onelin789/AdventOfCode2020 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded exec_time v0.1.4 [INFO] [stderr] Downloaded darling_macro v0.9.0 [INFO] [stderr] Downloaded bit_reverse v0.1.8 [INFO] [stderr] Downloaded intbits v0.2.0 [INFO] [stderr] Downloaded darling_core v0.9.0 [INFO] [stderr] Downloaded darling v0.9.0 [INFO] [stderr] Downloaded bitvec v0.20.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a38616854fde075ad9419f5f6eaf930d4f440fd9adff83080ab1613428e94b11 [INFO] running `Command { std: "docker" "start" "-a" "a38616854fde075ad9419f5f6eaf930d4f440fd9adff83080ab1613428e94b11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a38616854fde075ad9419f5f6eaf930d4f440fd9adff83080ab1613428e94b11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a38616854fde075ad9419f5f6eaf930d4f440fd9adff83080ab1613428e94b11", kill_on_drop: false }` [INFO] [stdout] a38616854fde075ad9419f5f6eaf930d4f440fd9adff83080ab1613428e94b11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f3b053c874c7b71d7891faa1a094ec9ee71c9ba6dd6e3f656bfda3c3cb46d55 [INFO] running `Command { std: "docker" "start" "-a" "2f3b053c874c7b71d7891faa1a094ec9ee71c9ba6dd6e3f656bfda3c3cb46d55", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling strsim v0.7.0 [INFO] [stderr] Compiling radium v0.6.2 [INFO] [stderr] Checking tap v1.0.0 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Checking bit_reverse v0.1.8 [INFO] [stderr] Checking intbits v0.2.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking bit-set v0.5.2 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking bitvec v0.20.1 [INFO] [stderr] Compiling darling_core v0.9.0 [INFO] [stderr] Compiling darling_macro v0.9.0 [INFO] [stderr] Compiling darling v0.9.0 [INFO] [stderr] Compiling exec_time v0.1.4 [INFO] [stderr] Checking advent_of_code_2020 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: attempt to mutate range bound within loop [INFO] [stdout] --> src/lib.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | last_swapped_pos = i; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the range of the loop is unchanged [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stdout] = note: `#[warn(clippy::mut_range_bound)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if swapped == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `!swapped` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return gte_i; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return gte_i; [INFO] [stdout] 58 + gte_i [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: attempt to mutate range bound within loop [INFO] [stdout] --> src/lib.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | last_swapped_pos = i; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the range of the loop is unchanged [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stdout] = note: `#[warn(clippy::mut_range_bound)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if swapped == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `!swapped` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return gte_i; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return gte_i; [INFO] [stdout] 58 + gte_i [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day014.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return val; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return val; [INFO] [stdout] 21 + val [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day014.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | val = val & !(1 << index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val &= !(1 << index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day014.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | val = val | (1 << index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val |= (1 << index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day014.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return sum; [INFO] [stdout] 52 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/bin/day014.rs:32:37 [INFO] [stdout] | [INFO] [stdout] 32 | let (addr, remainder) = a.splitn(2, ']').next_tuple().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.split_once(']')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] = note: `#[warn(clippy::manual_split_once)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day014.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return result; [INFO] [stdout] 71 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day008.rs:12:22 [INFO] [stdout] | [INFO] [stdout] 12 | fn part_1(inst_list: &Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn part_1(inst_list: &Vec) -> i32 { [INFO] [stdout] 12 + fn part_1(inst_list: &[Kind]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day008.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return true; [INFO] [stdout] 53 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day008.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return true; [INFO] [stdout] 59 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day008.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return false; [INFO] [stdout] 65 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day008.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return false; [INFO] [stdout] 67 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day008.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return true; [INFO] [stdout] 77 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day008.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return false; [INFO] [stdout] 80 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/bin/day008.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | visited.contains(index) == true, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `visited.contains(index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/bin/day008.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | visited.contains(index) == true, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `visited.contains(index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day014.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return sum; [INFO] [stdout] 118 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/bin/day014.rs:97:37 [INFO] [stdout] | [INFO] [stdout] 97 | let (addr, remainder) = a.splitn(2, ']').next_tuple().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.split_once(']')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/bin/day008.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | let kind; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `kind` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 154 ~ [INFO] [stdout] 155 | let (k, v) = line.split_whitespace().next_tuple().unwrap(); [INFO] [stdout] 156 ~ let kind = match k { [INFO] [stdout] 157 ~ "nop" => Kind::Nop(v.parse::().unwrap()), [INFO] [stdout] 158 ~ "acc" => Kind::Acc(v.parse::().unwrap()), [INFO] [stdout] 159 ~ "jmp" => Kind::Jmp(v.parse::().unwrap()), [INFO] [stdout] 160 | _ => panic!("Unrecognized instruction kind."), [INFO] [stdout] 161 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day002.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return valid_cnt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return valid_cnt; [INFO] [stdout] 14 + valid_cnt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day002.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return valid_cnt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return valid_cnt; [INFO] [stdout] 29 + valid_cnt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day002.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return Ok(()); [INFO] [stdout] 52 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `cid` is never read [INFO] [stdout] --> src/bin/day004.rs:82:23 [INFO] [stdout] | [INFO] [stdout] 82 | let mut cid = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `cid` is never read [INFO] [stdout] --> src/bin/day004.rs:93:26 [INFO] [stdout] | [INFO] [stdout] 93 | "cid" => cid += 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return 1; [INFO] [stdout] 11 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return 0; [INFO] [stdout] 13 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return 1; [INFO] [stdout] 32 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return 0; [INFO] [stdout] 34 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return 0; [INFO] [stdout] 43 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return 1; [INFO] [stdout] 45 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day003.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | return num_tree; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return num_tree; [INFO] [stdout] 20 + num_tree [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day003.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | fn traverse(rows: &Vec<&str>, rsteps: usize, dsteps: usize) -> i32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - fn traverse(rows: &Vec<&str>, rsteps: usize, dsteps: usize) -> i32 { [INFO] [stdout] 4 + fn traverse(rows: &[&str], rsteps: usize, dsteps: usize) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day003.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | posx = posx % rows[posy].len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `posx %= rows[posy].len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day003.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return traverse(rows, 3, 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return traverse(rows, 3, 1); [INFO] [stdout] 24 + traverse(rows, 3, 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day003.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return total; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return total; [INFO] [stdout] 34 + total [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:51:18 [INFO] [stdout] | [INFO] [stdout] 51 | "amb" => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - "amb" => return 1, [INFO] [stdout] 51 + "amb" => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 52 | "blu" => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - "blu" => return 1, [INFO] [stdout] 52 + "blu" => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 53 | "brn" => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - "brn" => return 1, [INFO] [stdout] 53 + "brn" => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 54 | "gry" => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - "gry" => return 1, [INFO] [stdout] 54 + "gry" => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 55 | "grn" => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - "grn" => return 1, [INFO] [stdout] 55 + "grn" => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:56:18 [INFO] [stdout] | [INFO] [stdout] 56 | "hzl" => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - "hzl" => return 1, [INFO] [stdout] 56 + "hzl" => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:57:18 [INFO] [stdout] | [INFO] [stdout] 57 | "oth" => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - "oth" => return 1, [INFO] [stdout] 57 + "oth" => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:58:14 [INFO] [stdout] | [INFO] [stdout] 58 | _ => return 0, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - _ => return 0, [INFO] [stdout] 58 + _ => 0, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return 0; [INFO] [stdout] 64 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return 0; [INFO] [stdout] 66 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return 1; [INFO] [stdout] 68 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/bin/day004.rs:63:52 [INFO] [stdout] | [INFO] [stdout] 63 | if val.contains(|c: char| !c.is_ascii_digit()) { [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 64 | | return 0; [INFO] [stdout] 65 | | } else if val.len() != 9 { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/bin/day004.rs:65:30 [INFO] [stdout] | [INFO] [stdout] 65 | } else if val.len() != 9 { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 66 | | return 0; [INFO] [stdout] 67 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | return valid_cnt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return valid_cnt; [INFO] [stdout] 109 + valid_cnt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day019.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | return possible_remaining_msgs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return possible_remaining_msgs; [INFO] [stdout] 50 + possible_remaining_msgs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day019.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | return possible_remaining_msgs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return possible_remaining_msgs; [INFO] [stdout] 23 + possible_remaining_msgs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day019.rs:15:34 [INFO] [stdout] | [INFO] [stdout] 15 | fn matches_subrule<'a>(msgs: &Vec<&'a str>, subrule: &[usize], rules: &[Rule]) -> Vec<&'a str> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 ~ fn matches_subrule<'a>(msgs: &[&'a str], subrule: &[usize], rules: &[Rule]) -> Vec<&'a str> { [INFO] [stdout] 16 ~ let mut possible_remaining_msgs = msgs.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day019.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | / return messages [INFO] [stdout] 55 | | .iter() [INFO] [stdout] 56 | | .filter(|msg| { [INFO] [stdout] 57 | | let remaining_msgs = matches(&(vec![msg]), rules, 0); [INFO] [stdout] ... | [INFO] [stdout] 65 | | }) [INFO] [stdout] 66 | | .count(); [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 ~ messages [INFO] [stdout] 55 + .iter() [INFO] [stdout] 56 + .filter(|msg| { [INFO] [stdout] 57 + let remaining_msgs = matches(&(vec![msg]), rules, 0); [INFO] [stdout] 58 + let mut res = false; [INFO] [stdout] 59 + for msg in remaining_msgs { [INFO] [stdout] 60 + if msg.len() == 0 { [INFO] [stdout] 61 + res = true; [INFO] [stdout] 62 + } [INFO] [stdout] 63 + } [INFO] [stdout] 64 + return res; [INFO] [stdout] 65 + }) [INFO] [stdout] 66 ~ .count() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day019.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return res; [INFO] [stdout] 64 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bin/day019.rs:60:20 [INFO] [stdout] | [INFO] [stdout] 60 | if msg.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day019.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | / return messages [INFO] [stdout] 74 | | .iter() [INFO] [stdout] 75 | | .filter(|msg| { [INFO] [stdout] 76 | | let remaining_msgs = matches(&(vec![msg]), &rules, 0); [INFO] [stdout] ... | [INFO] [stdout] 85 | | }) [INFO] [stdout] 86 | | .count(); [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 ~ messages [INFO] [stdout] 74 + .iter() [INFO] [stdout] 75 + .filter(|msg| { [INFO] [stdout] 76 + let remaining_msgs = matches(&(vec![msg]), &rules, 0); [INFO] [stdout] 77 + let mut res = false; [INFO] [stdout] 78 + // For part 2, there will [INFO] [stdout] 79 + for msg in remaining_msgs { [INFO] [stdout] 80 + if msg.len() == 0 { [INFO] [stdout] 81 + res = true; [INFO] [stdout] 82 + } [INFO] [stdout] 83 + } [INFO] [stdout] 84 + return res; [INFO] [stdout] 85 + }) [INFO] [stdout] 86 ~ .count() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day019.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return res; [INFO] [stdout] 84 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bin/day019.rs:80:20 [INFO] [stdout] | [INFO] [stdout] 80 | if msg.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day024.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return (x, y); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return (x, y); [INFO] [stdout] 42 + (x, y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/day024.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 21 | if y % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^ help: replace with: `y.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/day024.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | if y % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^ help: replace with: `y.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day024.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | return hex_grid; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return hex_grid; [INFO] [stdout] 115 + hex_grid [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/day024.rs:74:32 [INFO] [stdout] | [INFO] [stdout] 74 | ... if y % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^ help: replace with: `y.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/day024.rs:92:32 [INFO] [stdout] | [INFO] [stdout] 92 | ... if y % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^ help: replace with: `y.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day024.rs:158:5 [INFO] [stdout] | [INFO] [stdout] 158 | return hex_grid.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return hex_grid.len(); [INFO] [stdout] 158 + hex_grid.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day021.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | return acc; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return acc; [INFO] [stdout] 67 + acc [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day021.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | if matched_ingredients [INFO] [stdout] | ________________^ [INFO] [stdout] 61 | | .iter() [INFO] [stdout] 62 | | .find(|(matched_ingredient, _)| matched_ingredient == ingredient) [INFO] [stdout] 63 | | == None [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] help: use `Option::is_none()` instead [INFO] [stdout] | [INFO] [stdout] 60 ~ if matched_ingredients [INFO] [stdout] 61 + .iter() [INFO] [stdout] 62 + .find(|(matched_ingredient, _)| matched_ingredient == ingredient).is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/bin/day021.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | matched_ingredients.sort_by(|(_, allergen_a), (_, allergen_b)| allergen_a.cmp(allergen_b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 73 - matched_ingredients.sort_by(|(_, allergen_a), (_, allergen_b)| allergen_a.cmp(allergen_b)); [INFO] [stdout] 73 + matched_ingredients.sort_by_key(|(_, allergen_a)| *allergen_a); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day009.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | fn part_1(nums: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - fn part_1(nums: &Vec) -> Result { [INFO] [stdout] 6 + fn part_1(nums: &[i64]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day009.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return -1; [INFO] [stdout] 44 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day009.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | fn part_2(nums: &Vec, invalid_num: i64) -> i64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 30 - fn part_2(nums: &Vec, invalid_num: i64) -> i64 { [INFO] [stdout] 30 + fn part_2(nums: &[i64], invalid_num: i64) -> i64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day017.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | return write!(f, "#"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return write!(f, "#"); [INFO] [stdout] 15 + write!(f, "#") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day017.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | return write!(f, "."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return write!(f, "."); [INFO] [stdout] 18 + write!(f, ".") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day017.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | return count; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - return count; [INFO] [stdout] 60 + count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day017.rs:37:11 [INFO] [stdout] | [INFO] [stdout] 37 | grid: &Vec>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - grid: &Vec>>>, [INFO] [stdout] 37 + grid: &[Vec>>], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `iw` is only used to index `grid` [INFO] [stdout] --> src/bin/day017.rs:48:15 [INFO] [stdout] | [INFO] [stdout] 48 | for iw in (w - 1)..(w + 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 48 - for iw in (w - 1)..(w + 2) { [INFO] [stdout] 48 + for in grid.iter().take((w + 2)).skip((w - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `iz` is only used to index `grid` [INFO] [stdout] --> src/bin/day017.rs:49:19 [INFO] [stdout] | [INFO] [stdout] 49 | for iz in (z - 1)..(z + 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 49 - for iz in (z - 1)..(z + 2) { [INFO] [stdout] 49 + for in grid.iter().take((z + 2)).skip((z - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `iy` is only used to index `grid` [INFO] [stdout] --> src/bin/day017.rs:50:23 [INFO] [stdout] | [INFO] [stdout] 50 | for iy in (y - 1)..(y + 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 50 - for iy in (y - 1)..(y + 2) { [INFO] [stdout] 50 + for in grid.iter().take((y + 2)).skip((y - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `ix` is only used to index `grid` [INFO] [stdout] --> src/bin/day017.rs:51:27 [INFO] [stdout] | [INFO] [stdout] 51 | for ix in (x - 1)..(x + 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 51 - for ix in (x - 1)..(x + 2) { [INFO] [stdout] 51 + for in grid.iter().take((x + 2)).skip((x - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day017.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return active_cnt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return active_cnt; [INFO] [stdout] 76 + active_cnt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day017.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | return count_active(grid_dest); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return count_active(grid_dest); [INFO] [stdout] 113 + count_active(grid_dest) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day017.rs:79:17 [INFO] [stdout] | [INFO] [stdout] 79 | fn part_1(grid: &Vec>>>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 ~ fn part_1(grid: &[Vec>>]) -> i32 { [INFO] [stdout] 80 ~ let mut grid0 = grid.to_owned(); [INFO] [stdout] 81 ~ let mut grid1 = grid.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day017.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | return count_active(grid_dest); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - return count_active(grid_dest); [INFO] [stdout] 150 + count_active(grid_dest) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day017.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 116 | fn part_2(grid: &Vec>>>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 116 ~ fn part_2(grid: &[Vec>>]) -> i32 { [INFO] [stdout] 117 ~ let mut grid0 = grid.to_owned(); [INFO] [stdout] 118 ~ let mut grid1 = grid.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day007.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return sum; [INFO] [stdout] 37 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day007.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ false [INFO] [stdout] 20 | } [INFO] [stdout] ... [INFO] [stdout] 23 | } [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day007.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 ~ false [INFO] [stdout] 23 | } [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day007.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | return total_bags("shiny gold", rule_map) - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return total_bags("shiny gold", rule_map) - 1; [INFO] [stdout] 56 + total_bags("shiny gold", rule_map) - 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day007.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return sum; [INFO] [stdout] 53 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bin/day007.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / match rule_map.get(id) { [INFO] [stdout] 45 | | Some(contents) => { [INFO] [stdout] 46 | | sum += contents.iter().fold(0, |acc, idn| { [INFO] [stdout] 47 | | return acc + (idn.1 as i32) * total_bags(idn.0, rule_map); [INFO] [stdout] ... | [INFO] [stdout] 50 | | None => {} [INFO] [stdout] 51 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 44 ~ if let Some(contents) = rule_map.get(id) { [INFO] [stdout] 45 + sum += contents.iter().fold(0, |acc, idn| { [INFO] [stdout] 46 + return acc + (idn.1 as i32) * total_bags(idn.0, rule_map); [INFO] [stdout] 47 + }); [INFO] [stdout] 48 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day007.rs:47:21 [INFO] [stdout] | [INFO] [stdout] 47 | return acc + (idn.1 as i32) * total_bags(idn.0, rule_map); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return acc + (idn.1 as i32) * total_bags(idn.0, rule_map); [INFO] [stdout] 47 + acc + (idn.1 as i32) * total_bags(idn.0, rule_map) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/bin/day007.rs:66:35 [INFO] [stdout] | [INFO] [stdout] 66 | let (id, mut remainder) = line.splitn(2, " bags contain ").next_tuple().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `line.split_once(" bags contain ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] = note: `#[warn(clippy::manual_split_once)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/bin/day007.rs:76:39 [INFO] [stdout] | [INFO] [stdout] 76 | let (id, sub_remainder) = remainder.splitn(2, "bag").next_tuple().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `remainder.split_once("bag")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day010.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return diff_one_s * diff_three_s; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return diff_one_s * diff_three_s; [INFO] [stdout] 28 + diff_one_s * diff_three_s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day010.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | fn part_1(adapters: &Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 ~ fn part_1(adapters: &[i32]) -> i32 { [INFO] [stdout] 6 | let mut chain = Vec::with_capacity(adapters.len() + 2); [INFO] [stdout] 7 | chain.push(0); // Add outlet jolt. [INFO] [stdout] 8 ~ chain.append(&mut adapters.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day010.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 24 | return (s1, s3); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return (s1, s3); [INFO] [stdout] 24 + (s1, s3) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day010.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | return (permu, sub_permu, subs_permu); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return (permu, sub_permu, subs_permu); [INFO] [stdout] 56 + (permu, sub_permu, subs_permu) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day010.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | return permu; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return permu; [INFO] [stdout] 67 + permu [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day010.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 59 | fn part_2(adapters: &Vec) -> i64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 59 ~ fn part_2(adapters: &[i32]) -> i64 { [INFO] [stdout] 60 | let mut chain = Vec::with_capacity(adapters.len() + 2); [INFO] [stdout] 61 | chain.push(0); // Add outlet jolt. [INFO] [stdout] 62 ~ chain.append(&mut adapters.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day020.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / return Self { [INFO] [stdout] 20 | | data, [INFO] [stdout] 21 | | width, [INFO] [stdout] 22 | | height, [INFO] [stdout] 23 | | neighbours: RefCell::new([None; 4]), [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ Self { [INFO] [stdout] 20 + data, [INFO] [stdout] 21 + width, [INFO] [stdout] 22 + height, [INFO] [stdout] 23 + neighbours: RefCell::new([None; 4]), [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: slow zero-filling initialization [INFO] [stdout] --> src/bin/day020.rs:17:24 [INFO] [stdout] | [INFO] [stdout] 17 | let mut data = Vec::new(); [INFO] [stdout] | ________________________^ [INFO] [stdout] 18 | | data.resize(width * height, 0); [INFO] [stdout] | |______________________________________^ help: consider replacing this with: `vec![0; width * height]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stdout] = note: `#[warn(clippy::slow_vector_initialization)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/bin/day020.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | / for i in 0..self.width { [INFO] [stdout] 31 | | self.data[start + i] = row[i]; [INFO] [stdout] 32 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `self.data[start..(self.width + start)].copy_from_slice(&row[..self.width]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day020.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return self.data[start..(start + self.width)].to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return self.data[start..(start + self.width)].to_vec(); [INFO] [stdout] 37 + self.data[start..(start + self.width)].to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day009.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | fn part_1(nums: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - fn part_1(nums: &Vec) -> Result { [INFO] [stdout] 6 + fn part_1(nums: &[i64]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day009.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return -1; [INFO] [stdout] 44 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day009.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | fn part_2(nums: &Vec, invalid_num: i64) -> i64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 30 - fn part_2(nums: &Vec, invalid_num: i64) -> i64 { [INFO] [stdout] 30 + fn part_2(nums: &[i64], invalid_num: i64) -> i64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day020.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return col; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return col; [INFO] [stdout] 47 + col [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: slow zero-filling initialization [INFO] [stdout] --> src/bin/day020.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 42 | let mut col = Vec::new(); [INFO] [stdout] | _______________________^ [INFO] [stdout] 43 | | col.resize(self.height, 0); [INFO] [stdout] | |__________________________________^ help: consider replacing this with: `vec![0; self.height]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `col` [INFO] [stdout] --> src/bin/day020.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 44 | for i in 0..self.height { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 44 - for i in 0..self.height { [INFO] [stdout] 44 + for (i, ) in col.iter_mut().enumerate().take(self.height) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day020.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return vec![n, w, s, e]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return vec![n, w, s, e]; [INFO] [stdout] 55 + vec![n, w, s, e] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day020.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return cnt; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return cnt; [INFO] [stdout] 73 + cnt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day020.rs:69:16 [INFO] [stdout] | [INFO] [stdout] 69 | if *neighbour != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `neighbour.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: slow zero-filling initialization [INFO] [stdout] --> src/bin/day020.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 90 | let mut rotated = Vec::new(); [INFO] [stdout] | ___________________________^ [INFO] [stdout] 91 | | rotated.resize(self.width * self.height, 0); [INFO] [stdout] | |___________________________________________________^ help: consider replacing this with: `vec![0; self.width * self.height]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day020.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | return matched; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return matched; [INFO] [stdout] 131 + matched [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/bin/day020.rs:127:16 [INFO] [stdout] | [INFO] [stdout] 127 | if matched == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `!matched` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day020.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | return monster_cnt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return monster_cnt; [INFO] [stdout] 157 + monster_cnt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day020.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 170 | if line == None { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `Option::is_none()` instead: `line.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day020.rs:181:20 [INFO] [stdout] | [INFO] [stdout] 181 | if line == None { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `Option::is_none()` instead: `line.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `borders` [INFO] [stdout] --> src/bin/day020.rs:206:22 [INFO] [stdout] | [INFO] [stdout] 206 | for i in 0..borders.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 206 - for i in 0..borders.len() { [INFO] [stdout] 206 + for (i, ) in borders.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day020.rs:255:20 [INFO] [stdout] | [INFO] [stdout] 255 | if neighbours[0] == None [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `neighbours[0].is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day020.rs:256:24 [INFO] [stdout] | [INFO] [stdout] 256 | && neighbours[1] == None [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `neighbours[1].is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day020.rs:257:24 [INFO] [stdout] | [INFO] [stdout] 257 | && neighbours[2] != None [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `neighbours[2].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day020.rs:258:24 [INFO] [stdout] | [INFO] [stdout] 258 | && neighbours[3] != None [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `neighbours[3].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/bin/day020.rs:266:12 [INFO] [stdout] | [INFO] [stdout] 266 | if fit == false { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `!fit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bin/day020.rs:270:5 [INFO] [stdout] | [INFO] [stdout] 270 | assert_eq!(fit, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 270 - assert_eq!(fit, true); [INFO] [stdout] 270 + assert!(fit); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day008.rs:12:22 [INFO] [stdout] | [INFO] [stdout] 12 | fn part_1(inst_list: &Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn part_1(inst_list: &Vec) -> i32 { [INFO] [stdout] 12 + fn part_1(inst_list: &[Kind]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day016.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / return Self { [INFO] [stdout] 16 | | name, [INFO] [stdout] 17 | | range0: (min0..max0 + 1), [INFO] [stdout] 18 | | range1: (min1..max1 + 1), [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 ~ Self { [INFO] [stdout] 16 + name, [INFO] [stdout] 17 + range0: (min0..max0 + 1), [INFO] [stdout] 18 + range1: (min1..max1 + 1), [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day016.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | return self.range0.contains(&v) || self.range1.contains(&v); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return self.range0.contains(&v) || self.range1.contains(&v); [INFO] [stdout] 23 + self.range0.contains(&v) || self.range1.contains(&v) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day008.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return true; [INFO] [stdout] 53 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/bin/day016.rs:29:32 [INFO] [stdout] | [INFO] [stdout] 29 | let (rules_str, tickets) = from_utf8(input) [INFO] [stdout] | ________________________________^ [INFO] [stdout] 30 | | .unwrap() [INFO] [stdout] 31 | | .splitn(2, "your ticket:") [INFO] [stdout] 32 | | .next_tuple() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] = note: `#[warn(clippy::manual_split_once)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ let (rules_str, tickets) = from_utf8(input) [INFO] [stdout] 30 + .unwrap().split_once("your ticket:") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/bin/day016.rs:34:39 [INFO] [stdout] | [INFO] [stdout] 34 | let (my_ticket, nearby_tickets) = tickets.splitn(2, "nearby tickets:").next_tuple().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tickets.split_once("nearby tickets:")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day008.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return true; [INFO] [stdout] 59 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day008.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return false; [INFO] [stdout] 65 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day008.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return false; [INFO] [stdout] 67 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day008.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return true; [INFO] [stdout] 77 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day008.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return false; [INFO] [stdout] 80 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/bin/day008.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | visited.contains(index) == true, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `visited.contains(index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/bin/day008.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | visited.contains(index) == true, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `visited.contains(index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/bin/day008.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | let kind; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `kind` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 154 ~ [INFO] [stdout] 155 | let (k, v) = line.split_whitespace().next_tuple().unwrap(); [INFO] [stdout] 156 ~ let kind = match k { [INFO] [stdout] 157 ~ "nop" => Kind::Nop(v.parse::().unwrap()), [INFO] [stdout] 158 ~ "acc" => Kind::Acc(v.parse::().unwrap()), [INFO] [stdout] 159 ~ "jmp" => Kind::Jmp(v.parse::().unwrap()), [INFO] [stdout] 160 | _ => panic!("Unrecognized instruction kind."), [INFO] [stdout] 161 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day015.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return last_num; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return last_num; [INFO] [stdout] 23 + last_num [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day022.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return sum; [INFO] [stdout] 44 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day022.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - return false; [INFO] [stdout] 60 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day022.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | return winner; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return winner; [INFO] [stdout] 105 + winner [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | val = val * subject_n; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val *= subject_n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | val = val % divider; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `val %= divider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | val = val * subject_n; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val *= subject_n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day022.rs:116:5 [INFO] [stdout] | [INFO] [stdout] 116 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return sum; [INFO] [stdout] 116 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | val = val % divider; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `val %= divider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | val = val * door_pub; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val *= door_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | val = val % divider; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `val %= divider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/bin/day015.rs:6:19 [INFO] [stdout] | [INFO] [stdout] 6 | for (i, n) in (&start_nums[..(start_nums.len() - 1)]).iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `start_nums[..(start_nums.len() - 1)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | val = val * card_pub; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val *= card_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day015.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | return part_1(start_nums, 30000000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return part_1(start_nums, 30000000); [INFO] [stdout] 27 + part_1(start_nums, 30000000) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | val = val % divider; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `val %= divider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day011.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return occupied_adj_num; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return occupied_adj_num; [INFO] [stdout] 19 + occupied_adj_num [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/bin/day011.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | / if (r >= 0 && r < rows.len() as i32) [INFO] [stdout] 10 | | && (c >= 0 && c < rows[r as usize].len() as i32) [INFO] [stdout] 11 | | && (r != seat_row || c != seat_col) [INFO] [stdout] ... | [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 11 ~ && (r != seat_row || c != seat_col) [INFO] [stdout] 12 ~ && rows[r as usize][c as usize] == b'#' { [INFO] [stdout] 13 | occupied_adj_num += 1; [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day011.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | return occupied_num; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return occupied_num; [INFO] [stdout] 62 + occupied_num [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day011.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | return n; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return n; [INFO] [stdout] 74 + n [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/bin/day011.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | / for c in 0..row_src.len() { [INFO] [stdout] 84 | | row_dest[c] = row_src[c]; [INFO] [stdout] 85 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `row_dest[..row_src.len()].copy_from_slice(&row_src[..]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day011.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return true; [INFO] [stdout] 105 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bin/day011.rs:123:25 [INFO] [stdout] | [INFO] [stdout] 123 | / if count_occupied_adj_seat_num(room_src, r as i32, c as i32) == 0 { [INFO] [stdout] 124 | | row_dest[c] = b'#'; [INFO] [stdout] 125 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 122 ~ b'L' [INFO] [stdout] 123 ~ if count_occupied_adj_seat_num(room_src, r as i32, c as i32) == 0 => { [INFO] [stdout] 124 | row_dest[c] = b'#'; [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bin/day011.rs:128:25 [INFO] [stdout] | [INFO] [stdout] 128 | / if count_occupied_adj_seat_num(room_src, r as i32, c as i32) >= 4 { [INFO] [stdout] 129 | | row_dest[c] = b'L'; [INFO] [stdout] 130 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 127 ~ b'#' [INFO] [stdout] 128 ~ if count_occupied_adj_seat_num(room_src, r as i32, c as i32) >= 4 => { [INFO] [stdout] 129 | row_dest[c] = b'L'; [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bin/day011.rs:165:25 [INFO] [stdout] | [INFO] [stdout] 165 | / if count_visible_occupied_seat_num(room_src, r as i32, c as i32) == 0 { [INFO] [stdout] 166 | | row_dest[c] = b'#'; [INFO] [stdout] 167 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 164 ~ b'L' [INFO] [stdout] 165 ~ if count_visible_occupied_seat_num(room_src, r as i32, c as i32) == 0 => { [INFO] [stdout] 166 | row_dest[c] = b'#'; [INFO] [stdout] 167 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bin/day011.rs:170:25 [INFO] [stdout] | [INFO] [stdout] 170 | / if count_visible_occupied_seat_num(room_src, r as i32, c as i32) >= 5 { [INFO] [stdout] 171 | | row_dest[c] = b'L'; [INFO] [stdout] 172 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 169 ~ b'#' [INFO] [stdout] 170 ~ if count_visible_occupied_seat_num(room_src, r as i32, c as i32) >= 5 => { [INFO] [stdout] 171 | row_dest[c] = b'L'; [INFO] [stdout] 172 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/bin/day023.rs:48:30 [INFO] [stdout] | [INFO] [stdout] 48 | play(&mut cups_moved, 7, 1000_000, 10_000_000); [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] = note: `#[warn(clippy::inconsistent_digit_grouping)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/bin/day023.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | cups.resize(1000_000 + 1, 0); [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/bin/day023.rs:78:19 [INFO] [stdout] | [INFO] [stdout] 78 | for i in 10..=1000_000 { [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day023.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return res; [INFO] [stdout] 43 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day023.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | return next1 * next2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return next1 * next2; [INFO] [stdout] 52 + next1 * next2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/bin/day023.rs:51:28 [INFO] [stdout] | [INFO] [stdout] 51 | let next2 = cups_moved[next1 as usize] as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `next1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: slow zero-filling initialization [INFO] [stdout] --> src/bin/day023.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 59 | let mut cups: Vec = Vec::new(); [INFO] [stdout] | ______________________________^ [INFO] [stdout] 60 | | cups.resize(input.len() + 1, 0); [INFO] [stdout] | |___________________________________^ help: consider replacing this with: `vec![0; input.len() + 1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stdout] = note: `#[warn(clippy::slow_vector_initialization)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/bin/day023.rs:68:14 [INFO] [stdout] | [INFO] [stdout] 68 | cups[last as usize] = next; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `last` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day013.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return (earliest_depart_time - timestamp) * bus_id; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return (earliest_depart_time - timestamp) * bus_id; [INFO] [stdout] 26 + (earliest_depart_time - timestamp) * bus_id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day013.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return timestamp; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return timestamp; [INFO] [stdout] 40 + timestamp [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day013.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return None; [INFO] [stdout] 63 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day013.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 65 | return Some((i as _, id.parse::().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return Some((i as _, id.parse::().unwrap())); [INFO] [stdout] 65 + Some((i as _, id.parse::().unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day011.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return occupied_adj_num; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return occupied_adj_num; [INFO] [stdout] 19 + occupied_adj_num [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/bin/day011.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | / if (r >= 0 && r < rows.len() as i32) [INFO] [stdout] 10 | | && (c >= 0 && c < rows[r as usize].len() as i32) [INFO] [stdout] 11 | | && (r != seat_row || c != seat_col) [INFO] [stdout] ... | [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 11 ~ && (r != seat_row || c != seat_col) [INFO] [stdout] 12 ~ && rows[r as usize][c as usize] == b'#' { [INFO] [stdout] 13 | occupied_adj_num += 1; [INFO] [stdout] 14 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day011.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | return occupied_num; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return occupied_num; [INFO] [stdout] 62 + occupied_num [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day011.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | return n; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return n; [INFO] [stdout] 74 + n [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/bin/day011.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | / for c in 0..row_src.len() { [INFO] [stdout] 84 | | row_dest[c] = row_src[c]; [INFO] [stdout] 85 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `row_dest[..row_src.len()].copy_from_slice(&row_src[..]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day011.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return true; [INFO] [stdout] 105 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bin/day011.rs:123:25 [INFO] [stdout] | [INFO] [stdout] 123 | / if count_occupied_adj_seat_num(room_src, r as i32, c as i32) == 0 { [INFO] [stdout] 124 | | row_dest[c] = b'#'; [INFO] [stdout] 125 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 122 ~ b'L' [INFO] [stdout] 123 ~ if count_occupied_adj_seat_num(room_src, r as i32, c as i32) == 0 => { [INFO] [stdout] 124 | row_dest[c] = b'#'; [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bin/day011.rs:128:25 [INFO] [stdout] | [INFO] [stdout] 128 | / if count_occupied_adj_seat_num(room_src, r as i32, c as i32) >= 4 { [INFO] [stdout] 129 | | row_dest[c] = b'L'; [INFO] [stdout] 130 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 127 ~ b'#' [INFO] [stdout] 128 ~ if count_occupied_adj_seat_num(room_src, r as i32, c as i32) >= 4 => { [INFO] [stdout] 129 | row_dest[c] = b'L'; [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bin/day011.rs:165:25 [INFO] [stdout] | [INFO] [stdout] 165 | / if count_visible_occupied_seat_num(room_src, r as i32, c as i32) == 0 { [INFO] [stdout] 166 | | row_dest[c] = b'#'; [INFO] [stdout] 167 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 164 ~ b'L' [INFO] [stdout] 165 ~ if count_visible_occupied_seat_num(room_src, r as i32, c as i32) == 0 => { [INFO] [stdout] 166 | row_dest[c] = b'#'; [INFO] [stdout] 167 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bin/day011.rs:170:25 [INFO] [stdout] | [INFO] [stdout] 170 | / if count_visible_occupied_seat_num(room_src, r as i32, c as i32) >= 5 { [INFO] [stdout] 171 | | row_dest[c] = b'L'; [INFO] [stdout] 172 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 169 ~ b'#' [INFO] [stdout] 170 ~ if count_visible_occupied_seat_num(room_src, r as i32, c as i32) >= 5 => { [INFO] [stdout] 171 | row_dest[c] = b'L'; [INFO] [stdout] 172 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day013.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return (earliest_depart_time - timestamp) * bus_id; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return (earliest_depart_time - timestamp) * bus_id; [INFO] [stdout] 26 + (earliest_depart_time - timestamp) * bus_id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day005.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return s; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return s; [INFO] [stdout] 17 + s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day013.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return timestamp; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return timestamp; [INFO] [stdout] 40 + timestamp [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day005.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return highest; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return highest; [INFO] [stdout] 30 + highest [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day013.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return None; [INFO] [stdout] 63 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day013.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 65 | return Some((i as _, id.parse::().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return Some((i as _, id.parse::().unwrap())); [INFO] [stdout] 65 + Some((i as _, id.parse::().unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day014.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return val; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return val; [INFO] [stdout] 21 + val [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day014.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | val = val & !(1 << index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val &= !(1 << index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day014.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | val = val | (1 << index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val |= (1 << index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day014.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return sum; [INFO] [stdout] 52 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/bin/day014.rs:32:37 [INFO] [stdout] | [INFO] [stdout] 32 | let (addr, remainder) = a.splitn(2, ']').next_tuple().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.split_once(']')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] = note: `#[warn(clippy::manual_split_once)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day014.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return result; [INFO] [stdout] 71 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day014.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return sum; [INFO] [stdout] 118 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/bin/day014.rs:97:37 [INFO] [stdout] | [INFO] [stdout] 97 | let (addr, remainder) = a.splitn(2, ']').next_tuple().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.split_once(']')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day012.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return x.abs() + y.abs(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return x.abs() + y.abs(); [INFO] [stdout] 53 + x.abs() + y.abs() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day012.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | return x.abs() + y.abs(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return x.abs() + y.abs(); [INFO] [stdout] 114 + x.abs() + y.abs() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day012.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | return (action, val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return (action, val); [INFO] [stdout] 125 + (action, val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day020.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / return Self { [INFO] [stdout] 20 | | data, [INFO] [stdout] 21 | | width, [INFO] [stdout] 22 | | height, [INFO] [stdout] 23 | | neighbours: RefCell::new([None; 4]), [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ Self { [INFO] [stdout] 20 + data, [INFO] [stdout] 21 + width, [INFO] [stdout] 22 + height, [INFO] [stdout] 23 + neighbours: RefCell::new([None; 4]), [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: slow zero-filling initialization [INFO] [stdout] --> src/bin/day020.rs:17:24 [INFO] [stdout] | [INFO] [stdout] 17 | let mut data = Vec::new(); [INFO] [stdout] | ________________________^ [INFO] [stdout] 18 | | data.resize(width * height, 0); [INFO] [stdout] | |______________________________________^ help: consider replacing this with: `vec![0; width * height]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stdout] = note: `#[warn(clippy::slow_vector_initialization)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/bin/day020.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | / for i in 0..self.width { [INFO] [stdout] 31 | | self.data[start + i] = row[i]; [INFO] [stdout] 32 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `self.data[start..(self.width + start)].copy_from_slice(&row[..self.width]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day020.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return self.data[start..(start + self.width)].to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return self.data[start..(start + self.width)].to_vec(); [INFO] [stdout] 37 + self.data[start..(start + self.width)].to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day020.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return col; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return col; [INFO] [stdout] 47 + col [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: slow zero-filling initialization [INFO] [stdout] --> src/bin/day020.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 42 | let mut col = Vec::new(); [INFO] [stdout] | _______________________^ [INFO] [stdout] 43 | | col.resize(self.height, 0); [INFO] [stdout] | |__________________________________^ help: consider replacing this with: `vec![0; self.height]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `col` [INFO] [stdout] --> src/bin/day020.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 44 | for i in 0..self.height { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 44 - for i in 0..self.height { [INFO] [stdout] 44 + for (i, ) in col.iter_mut().enumerate().take(self.height) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day020.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return vec![n, w, s, e]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return vec![n, w, s, e]; [INFO] [stdout] 55 + vec![n, w, s, e] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day002.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return valid_cnt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return valid_cnt; [INFO] [stdout] 14 + valid_cnt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day002.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return valid_cnt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return valid_cnt; [INFO] [stdout] 29 + valid_cnt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day002.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return Ok(()); [INFO] [stdout] 52 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day020.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return cnt; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return cnt; [INFO] [stdout] 73 + cnt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day020.rs:69:16 [INFO] [stdout] | [INFO] [stdout] 69 | if *neighbour != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `neighbour.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: slow zero-filling initialization [INFO] [stdout] --> src/bin/day020.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 90 | let mut rotated = Vec::new(); [INFO] [stdout] | ___________________________^ [INFO] [stdout] 91 | | rotated.resize(self.width * self.height, 0); [INFO] [stdout] | |___________________________________________________^ help: consider replacing this with: `vec![0; self.width * self.height]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day020.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | return matched; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return matched; [INFO] [stdout] 131 + matched [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/bin/day020.rs:127:16 [INFO] [stdout] | [INFO] [stdout] 127 | if matched == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `!matched` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day020.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | return monster_cnt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return monster_cnt; [INFO] [stdout] 157 + monster_cnt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day020.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 170 | if line == None { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `Option::is_none()` instead: `line.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day020.rs:181:20 [INFO] [stdout] | [INFO] [stdout] 181 | if line == None { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `Option::is_none()` instead: `line.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `borders` [INFO] [stdout] --> src/bin/day020.rs:206:22 [INFO] [stdout] | [INFO] [stdout] 206 | for i in 0..borders.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 206 - for i in 0..borders.len() { [INFO] [stdout] 206 + for (i, ) in borders.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day020.rs:255:20 [INFO] [stdout] | [INFO] [stdout] 255 | if neighbours[0] == None [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `neighbours[0].is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day020.rs:256:24 [INFO] [stdout] | [INFO] [stdout] 256 | && neighbours[1] == None [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `neighbours[1].is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day020.rs:257:24 [INFO] [stdout] | [INFO] [stdout] 257 | && neighbours[2] != None [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `neighbours[2].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day020.rs:258:24 [INFO] [stdout] | [INFO] [stdout] 258 | && neighbours[3] != None [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `neighbours[3].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/bin/day020.rs:266:12 [INFO] [stdout] | [INFO] [stdout] 266 | if fit == false { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `!fit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bin/day020.rs:270:5 [INFO] [stdout] | [INFO] [stdout] 270 | assert_eq!(fit, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 270 - assert_eq!(fit, true); [INFO] [stdout] 270 + assert!(fit); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day019.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | return possible_remaining_msgs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return possible_remaining_msgs; [INFO] [stdout] 50 + possible_remaining_msgs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day019.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | return possible_remaining_msgs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return possible_remaining_msgs; [INFO] [stdout] 23 + possible_remaining_msgs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day019.rs:15:34 [INFO] [stdout] | [INFO] [stdout] 15 | fn matches_subrule<'a>(msgs: &Vec<&'a str>, subrule: &[usize], rules: &[Rule]) -> Vec<&'a str> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 ~ fn matches_subrule<'a>(msgs: &[&'a str], subrule: &[usize], rules: &[Rule]) -> Vec<&'a str> { [INFO] [stdout] 16 ~ let mut possible_remaining_msgs = msgs.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day016.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / return Self { [INFO] [stdout] 16 | | name, [INFO] [stdout] 17 | | range0: (min0..max0 + 1), [INFO] [stdout] 18 | | range1: (min1..max1 + 1), [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 ~ Self { [INFO] [stdout] 16 + name, [INFO] [stdout] 17 + range0: (min0..max0 + 1), [INFO] [stdout] 18 + range1: (min1..max1 + 1), [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day019.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | / return messages [INFO] [stdout] 55 | | .iter() [INFO] [stdout] 56 | | .filter(|msg| { [INFO] [stdout] 57 | | let remaining_msgs = matches(&(vec![msg]), rules, 0); [INFO] [stdout] ... | [INFO] [stdout] 65 | | }) [INFO] [stdout] 66 | | .count(); [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 ~ messages [INFO] [stdout] 55 + .iter() [INFO] [stdout] 56 + .filter(|msg| { [INFO] [stdout] 57 + let remaining_msgs = matches(&(vec![msg]), rules, 0); [INFO] [stdout] 58 + let mut res = false; [INFO] [stdout] 59 + for msg in remaining_msgs { [INFO] [stdout] 60 + if msg.len() == 0 { [INFO] [stdout] 61 + res = true; [INFO] [stdout] 62 + } [INFO] [stdout] 63 + } [INFO] [stdout] 64 + return res; [INFO] [stdout] 65 + }) [INFO] [stdout] 66 ~ .count() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day019.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return res; [INFO] [stdout] 64 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bin/day019.rs:60:20 [INFO] [stdout] | [INFO] [stdout] 60 | if msg.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day019.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | / return messages [INFO] [stdout] 74 | | .iter() [INFO] [stdout] 75 | | .filter(|msg| { [INFO] [stdout] 76 | | let remaining_msgs = matches(&(vec![msg]), &rules, 0); [INFO] [stdout] ... | [INFO] [stdout] 85 | | }) [INFO] [stdout] 86 | | .count(); [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 ~ messages [INFO] [stdout] 74 + .iter() [INFO] [stdout] 75 + .filter(|msg| { [INFO] [stdout] 76 + let remaining_msgs = matches(&(vec![msg]), &rules, 0); [INFO] [stdout] 77 + let mut res = false; [INFO] [stdout] 78 + // For part 2, there will [INFO] [stdout] 79 + for msg in remaining_msgs { [INFO] [stdout] 80 + if msg.len() == 0 { [INFO] [stdout] 81 + res = true; [INFO] [stdout] 82 + } [INFO] [stdout] 83 + } [INFO] [stdout] 84 + return res; [INFO] [stdout] 85 + }) [INFO] [stdout] 86 ~ .count() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day016.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | return self.range0.contains(&v) || self.range1.contains(&v); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return self.range0.contains(&v) || self.range1.contains(&v); [INFO] [stdout] 23 + self.range0.contains(&v) || self.range1.contains(&v) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/bin/day016.rs:29:32 [INFO] [stdout] | [INFO] [stdout] 29 | let (rules_str, tickets) = from_utf8(input) [INFO] [stdout] | ________________________________^ [INFO] [stdout] 30 | | .unwrap() [INFO] [stdout] 31 | | .splitn(2, "your ticket:") [INFO] [stdout] 32 | | .next_tuple() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] = note: `#[warn(clippy::manual_split_once)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ let (rules_str, tickets) = from_utf8(input) [INFO] [stdout] 30 + .unwrap().split_once("your ticket:") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day019.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return res; [INFO] [stdout] 84 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/bin/day016.rs:34:39 [INFO] [stdout] | [INFO] [stdout] 34 | let (my_ticket, nearby_tickets) = tickets.splitn(2, "nearby tickets:").next_tuple().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tickets.split_once("nearby tickets:")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bin/day019.rs:80:20 [INFO] [stdout] | [INFO] [stdout] 80 | if msg.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day006.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return sum; [INFO] [stdout] 16 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day006.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return sum; [INFO] [stdout] 38 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day005.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return s; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return s; [INFO] [stdout] 17 + s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day005.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return highest; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return highest; [INFO] [stdout] 30 + highest [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day006.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return sum; [INFO] [stdout] 16 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day006.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return sum; [INFO] [stdout] 38 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day003.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | return num_tree; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return num_tree; [INFO] [stdout] 20 + num_tree [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day003.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | fn traverse(rows: &Vec<&str>, rsteps: usize, dsteps: usize) -> i32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - fn traverse(rows: &Vec<&str>, rsteps: usize, dsteps: usize) -> i32 { [INFO] [stdout] 4 + fn traverse(rows: &[&str], rsteps: usize, dsteps: usize) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day003.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | posx = posx % rows[posy].len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `posx %= rows[posy].len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day003.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return traverse(rows, 3, 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return traverse(rows, 3, 1); [INFO] [stdout] 24 + traverse(rows, 3, 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day003.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return total; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return total; [INFO] [stdout] 34 + total [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day015.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return last_num; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return last_num; [INFO] [stdout] 23 + last_num [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/bin/day015.rs:6:19 [INFO] [stdout] | [INFO] [stdout] 6 | for (i, n) in (&start_nums[..(start_nums.len() - 1)]).iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `start_nums[..(start_nums.len() - 1)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day015.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | return part_1(start_nums, 30000000); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return part_1(start_nums, 30000000); [INFO] [stdout] 27 + part_1(start_nums, 30000000) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/bin/day023.rs:48:30 [INFO] [stdout] | [INFO] [stdout] 48 | play(&mut cups_moved, 7, 1000_000, 10_000_000); [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] = note: `#[warn(clippy::inconsistent_digit_grouping)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/bin/day023.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | cups.resize(1000_000 + 1, 0); [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits grouped inconsistently by underscores [INFO] [stdout] --> src/bin/day023.rs:78:19 [INFO] [stdout] | [INFO] [stdout] 78 | for i in 10..=1000_000 { [INFO] [stdout] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day024.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return (x, y); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return (x, y); [INFO] [stdout] 42 + (x, y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/day024.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 21 | if y % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^ help: replace with: `y.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/day024.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | if y % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^ help: replace with: `y.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day001.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return Ok(()); [INFO] [stdout] 56 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day024.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | return hex_grid; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return hex_grid; [INFO] [stdout] 115 + hex_grid [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/day024.rs:74:32 [INFO] [stdout] | [INFO] [stdout] 74 | ... if y % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^ help: replace with: `y.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/day024.rs:92:32 [INFO] [stdout] | [INFO] [stdout] 92 | ... if y % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^ help: replace with: `y.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day024.rs:158:5 [INFO] [stdout] | [INFO] [stdout] 158 | return hex_grid.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return hex_grid.len(); [INFO] [stdout] 158 + hex_grid.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day001.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return Ok(()); [INFO] [stdout] 56 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day017.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | return write!(f, "#"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return write!(f, "#"); [INFO] [stdout] 15 + write!(f, "#") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day017.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | return write!(f, "."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return write!(f, "."); [INFO] [stdout] 18 + write!(f, ".") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day023.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return res; [INFO] [stdout] 43 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day023.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | return next1 * next2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return next1 * next2; [INFO] [stdout] 52 + next1 * next2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day017.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | return count; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - return count; [INFO] [stdout] 60 + count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day017.rs:37:11 [INFO] [stdout] | [INFO] [stdout] 37 | grid: &Vec>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - grid: &Vec>>>, [INFO] [stdout] 37 + grid: &[Vec>>], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `iw` is only used to index `grid` [INFO] [stdout] --> src/bin/day017.rs:48:15 [INFO] [stdout] | [INFO] [stdout] 48 | for iw in (w - 1)..(w + 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 48 - for iw in (w - 1)..(w + 2) { [INFO] [stdout] 48 + for in grid.iter().take((w + 2)).skip((w - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/bin/day023.rs:51:28 [INFO] [stdout] | [INFO] [stdout] 51 | let next2 = cups_moved[next1 as usize] as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `next1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: slow zero-filling initialization [INFO] [stdout] --> src/bin/day023.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 59 | let mut cups: Vec = Vec::new(); [INFO] [stdout] | ______________________________^ [INFO] [stdout] 60 | | cups.resize(input.len() + 1, 0); [INFO] [stdout] | |___________________________________^ help: consider replacing this with: `vec![0; input.len() + 1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stdout] = note: `#[warn(clippy::slow_vector_initialization)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/bin/day023.rs:68:14 [INFO] [stdout] | [INFO] [stdout] 68 | cups[last as usize] = next; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `last` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `iz` is only used to index `grid` [INFO] [stdout] --> src/bin/day017.rs:49:19 [INFO] [stdout] | [INFO] [stdout] 49 | for iz in (z - 1)..(z + 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 49 - for iz in (z - 1)..(z + 2) { [INFO] [stdout] 49 + for in grid.iter().take((z + 2)).skip((z - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `iy` is only used to index `grid` [INFO] [stdout] --> src/bin/day017.rs:50:23 [INFO] [stdout] | [INFO] [stdout] 50 | for iy in (y - 1)..(y + 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 50 - for iy in (y - 1)..(y + 2) { [INFO] [stdout] 50 + for in grid.iter().take((y + 2)).skip((y - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `ix` is only used to index `grid` [INFO] [stdout] --> src/bin/day017.rs:51:27 [INFO] [stdout] | [INFO] [stdout] 51 | for ix in (x - 1)..(x + 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 51 - for ix in (x - 1)..(x + 2) { [INFO] [stdout] 51 + for in grid.iter().take((x + 2)).skip((x - 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day017.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return active_cnt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return active_cnt; [INFO] [stdout] 76 + active_cnt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day017.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | return count_active(grid_dest); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return count_active(grid_dest); [INFO] [stdout] 113 + count_active(grid_dest) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day017.rs:79:17 [INFO] [stdout] | [INFO] [stdout] 79 | fn part_1(grid: &Vec>>>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 ~ fn part_1(grid: &[Vec>>]) -> i32 { [INFO] [stdout] 80 ~ let mut grid0 = grid.to_owned(); [INFO] [stdout] 81 ~ let mut grid1 = grid.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day017.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | return count_active(grid_dest); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - return count_active(grid_dest); [INFO] [stdout] 150 + count_active(grid_dest) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day017.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 116 | fn part_2(grid: &Vec>>>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 116 ~ fn part_2(grid: &[Vec>>]) -> i32 { [INFO] [stdout] 117 ~ let mut grid0 = grid.to_owned(); [INFO] [stdout] 118 ~ let mut grid1 = grid.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day021.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | return acc; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return acc; [INFO] [stdout] 67 + acc [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day021.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | if matched_ingredients [INFO] [stdout] | ________________^ [INFO] [stdout] 61 | | .iter() [INFO] [stdout] 62 | | .find(|(matched_ingredient, _)| matched_ingredient == ingredient) [INFO] [stdout] 63 | | == None [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] help: use `Option::is_none()` instead [INFO] [stdout] | [INFO] [stdout] 60 ~ if matched_ingredients [INFO] [stdout] 61 + .iter() [INFO] [stdout] 62 + .find(|(matched_ingredient, _)| matched_ingredient == ingredient).is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/bin/day021.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | matched_ingredients.sort_by(|(_, allergen_a), (_, allergen_b)| allergen_a.cmp(allergen_b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 73 - matched_ingredients.sort_by(|(_, allergen_a), (_, allergen_b)| allergen_a.cmp(allergen_b)); [INFO] [stdout] 73 + matched_ingredients.sort_by_key(|(_, allergen_a)| *allergen_a); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day022.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return sum; [INFO] [stdout] 44 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day022.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - return false; [INFO] [stdout] 60 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day022.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | return winner; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return winner; [INFO] [stdout] 105 + winner [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day012.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return x.abs() + y.abs(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return x.abs() + y.abs(); [INFO] [stdout] 53 + x.abs() + y.abs() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day022.rs:116:5 [INFO] [stdout] | [INFO] [stdout] 116 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 - return sum; [INFO] [stdout] 116 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day012.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | return x.abs() + y.abs(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return x.abs() + y.abs(); [INFO] [stdout] 114 + x.abs() + y.abs() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day007.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return sum; [INFO] [stdout] 37 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day007.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ false [INFO] [stdout] 20 | } [INFO] [stdout] ... [INFO] [stdout] 23 | } [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day007.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 ~ false [INFO] [stdout] 23 | } [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day012.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | return (action, val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return (action, val); [INFO] [stdout] 125 + (action, val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `cid` is never read [INFO] [stdout] --> src/bin/day004.rs:82:23 [INFO] [stdout] | [INFO] [stdout] 82 | let mut cid = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `cid` is never read [INFO] [stdout] --> src/bin/day004.rs:93:26 [INFO] [stdout] | [INFO] [stdout] 93 | "cid" => cid += 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return 1; [INFO] [stdout] 11 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return 0; [INFO] [stdout] 13 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day007.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | return total_bags("shiny gold", rule_map) - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return total_bags("shiny gold", rule_map) - 1; [INFO] [stdout] 56 + total_bags("shiny gold", rule_map) - 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return 1; [INFO] [stdout] 32 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return 0; [INFO] [stdout] 34 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day007.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return sum; [INFO] [stdout] 53 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return 0; [INFO] [stdout] 43 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return 1; [INFO] [stdout] 45 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:51:18 [INFO] [stdout] | [INFO] [stdout] 51 | "amb" => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - "amb" => return 1, [INFO] [stdout] 51 + "amb" => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 52 | "blu" => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - "blu" => return 1, [INFO] [stdout] 52 + "blu" => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 53 | "brn" => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - "brn" => return 1, [INFO] [stdout] 53 + "brn" => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 54 | "gry" => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - "gry" => return 1, [INFO] [stdout] 54 + "gry" => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 55 | "grn" => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - "grn" => return 1, [INFO] [stdout] 55 + "grn" => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:56:18 [INFO] [stdout] | [INFO] [stdout] 56 | "hzl" => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - "hzl" => return 1, [INFO] [stdout] 56 + "hzl" => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:57:18 [INFO] [stdout] | [INFO] [stdout] 57 | "oth" => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - "oth" => return 1, [INFO] [stdout] 57 + "oth" => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:58:14 [INFO] [stdout] | [INFO] [stdout] 58 | _ => return 0, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - _ => return 0, [INFO] [stdout] 58 + _ => 0, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return 0; [INFO] [stdout] 64 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return 0; [INFO] [stdout] 66 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return 1; [INFO] [stdout] 68 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/bin/day004.rs:63:52 [INFO] [stdout] | [INFO] [stdout] 63 | if val.contains(|c: char| !c.is_ascii_digit()) { [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 64 | | return 0; [INFO] [stdout] 65 | | } else if val.len() != 9 { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/bin/day004.rs:65:30 [INFO] [stdout] | [INFO] [stdout] 65 | } else if val.len() != 9 { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 66 | | return 0; [INFO] [stdout] 67 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bin/day007.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / match rule_map.get(id) { [INFO] [stdout] 45 | | Some(contents) => { [INFO] [stdout] 46 | | sum += contents.iter().fold(0, |acc, idn| { [INFO] [stdout] 47 | | return acc + (idn.1 as i32) * total_bags(idn.0, rule_map); [INFO] [stdout] ... | [INFO] [stdout] 50 | | None => {} [INFO] [stdout] 51 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 44 ~ if let Some(contents) = rule_map.get(id) { [INFO] [stdout] 45 + sum += contents.iter().fold(0, |acc, idn| { [INFO] [stdout] 46 + return acc + (idn.1 as i32) * total_bags(idn.0, rule_map); [INFO] [stdout] 47 + }); [INFO] [stdout] 48 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day004.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | return valid_cnt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return valid_cnt; [INFO] [stdout] 109 + valid_cnt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day007.rs:47:21 [INFO] [stdout] | [INFO] [stdout] 47 | return acc + (idn.1 as i32) * total_bags(idn.0, rule_map); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return acc + (idn.1 as i32) * total_bags(idn.0, rule_map); [INFO] [stdout] 47 + acc + (idn.1 as i32) * total_bags(idn.0, rule_map) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/bin/day007.rs:66:35 [INFO] [stdout] | [INFO] [stdout] 66 | let (id, mut remainder) = line.splitn(2, " bags contain ").next_tuple().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `line.split_once(" bags contain ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] = note: `#[warn(clippy::manual_split_once)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/bin/day007.rs:76:39 [INFO] [stdout] | [INFO] [stdout] 76 | let (id, sub_remainder) = remainder.splitn(2, "bag").next_tuple().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `remainder.split_once("bag")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | val = val * subject_n; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val *= subject_n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | val = val % divider; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `val %= divider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | val = val * subject_n; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val *= subject_n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | val = val % divider; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `val %= divider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | val = val * door_pub; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val *= door_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | val = val % divider; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `val %= divider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | val = val * card_pub; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val *= card_pub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/day025.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | val = val % divider; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `val %= divider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day018.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | / return Self { [INFO] [stdout] 49 | | stream: s, [INFO] [stdout] 50 | | char_iter: s.chars().enumerate().peekable(), [INFO] [stdout] 51 | | past_eol: false, [INFO] [stdout] 52 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 ~ Self { [INFO] [stdout] 49 + stream: s, [INFO] [stdout] 50 + char_iter: s.chars().enumerate().peekable(), [INFO] [stdout] 51 + past_eol: false, [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day018.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | if !c.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `c.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/bin/day018.rs:68:20 [INFO] [stdout] | [INFO] [stdout] 68 | if self.past_eol == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.past_eol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/bin/day018.rs:111:20 [INFO] [stdout] | [INFO] [stdout] 111 | if token_inprocessing == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!token_inprocessing` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day018.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 199 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 199 - return res; [INFO] [stdout] 199 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/bin/day018.rs:134:25 [INFO] [stdout] | [INFO] [stdout] 134 | / loop { [INFO] [stdout] ... | [INFO] [stdout] 178 | | } [INFO] [stdout] | |_________________________^ help: try: `while let Some(last_op) = operator_stack.last() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/bin/day018.rs:142:43 [INFO] [stdout] | [INFO] [stdout] 142 | ... } else if precedence(last_op, &tok) == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `precedence(last_op, &tok)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day018.rs:211:5 [INFO] [stdout] | [INFO] [stdout] 211 | return total; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return total; [INFO] [stdout] 211 + total [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day018.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | return a.precedence_part1() <= b.precedence_part1(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return a.precedence_part1() <= b.precedence_part1(); [INFO] [stdout] 204 + a.precedence_part1() <= b.precedence_part1() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day018.rs:223:5 [INFO] [stdout] | [INFO] [stdout] 223 | return total; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - return total; [INFO] [stdout] 223 + total [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day018.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | return a.precedence_part2() <= b.precedence_part2(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 216 - return a.precedence_part2() <= b.precedence_part2(); [INFO] [stdout] 216 + a.precedence_part2() <= b.precedence_part2() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day010.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return diff_one_s * diff_three_s; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return diff_one_s * diff_three_s; [INFO] [stdout] 28 + diff_one_s * diff_three_s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day010.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | fn part_1(adapters: &Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 5 ~ fn part_1(adapters: &[i32]) -> i32 { [INFO] [stdout] 6 | let mut chain = Vec::with_capacity(adapters.len() + 2); [INFO] [stdout] 7 | chain.push(0); // Add outlet jolt. [INFO] [stdout] 8 ~ chain.append(&mut adapters.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day010.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 24 | return (s1, s3); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return (s1, s3); [INFO] [stdout] 24 + (s1, s3) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day010.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | return (permu, sub_permu, subs_permu); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return (permu, sub_permu, subs_permu); [INFO] [stdout] 56 + (permu, sub_permu, subs_permu) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day010.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | return permu; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return permu; [INFO] [stdout] 67 + permu [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day010.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 59 | fn part_2(adapters: &Vec) -> i64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 59 ~ fn part_2(adapters: &[i32]) -> i64 { [INFO] [stdout] 60 | let mut chain = Vec::with_capacity(adapters.len() + 2); [INFO] [stdout] 61 | chain.push(0); // Add outlet jolt. [INFO] [stdout] 62 ~ chain.append(&mut adapters.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day018.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | / return Self { [INFO] [stdout] 49 | | stream: s, [INFO] [stdout] 50 | | char_iter: s.chars().enumerate().peekable(), [INFO] [stdout] 51 | | past_eol: false, [INFO] [stdout] 52 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 ~ Self { [INFO] [stdout] 49 + stream: s, [INFO] [stdout] 50 + char_iter: s.chars().enumerate().peekable(), [INFO] [stdout] 51 + past_eol: false, [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day018.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | if !c.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `c.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/bin/day018.rs:68:20 [INFO] [stdout] | [INFO] [stdout] 68 | if self.past_eol == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.past_eol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/bin/day018.rs:111:20 [INFO] [stdout] | [INFO] [stdout] 111 | if token_inprocessing == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!token_inprocessing` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day018.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 199 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 199 - return res; [INFO] [stdout] 199 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/bin/day018.rs:134:25 [INFO] [stdout] | [INFO] [stdout] 134 | / loop { [INFO] [stdout] ... | [INFO] [stdout] 178 | | } [INFO] [stdout] | |_________________________^ help: try: `while let Some(last_op) = operator_stack.last() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/bin/day018.rs:142:43 [INFO] [stdout] | [INFO] [stdout] 142 | ... } else if precedence(last_op, &tok) == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `precedence(last_op, &tok)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day018.rs:211:5 [INFO] [stdout] | [INFO] [stdout] 211 | return total; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return total; [INFO] [stdout] 211 + total [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day018.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | return a.precedence_part1() <= b.precedence_part1(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return a.precedence_part1() <= b.precedence_part1(); [INFO] [stdout] 204 + a.precedence_part1() <= b.precedence_part1() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day018.rs:223:5 [INFO] [stdout] | [INFO] [stdout] 223 | return total; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - return total; [INFO] [stdout] 223 + total [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day018.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | return a.precedence_part2() <= b.precedence_part2(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 216 - return a.precedence_part2() <= b.precedence_part2(); [INFO] [stdout] 216 + a.precedence_part2() <= b.precedence_part2() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.56s [INFO] running `Command { std: "docker" "inspect" "2f3b053c874c7b71d7891faa1a094ec9ee71c9ba6dd6e3f656bfda3c3cb46d55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f3b053c874c7b71d7891faa1a094ec9ee71c9ba6dd6e3f656bfda3c3cb46d55", kill_on_drop: false }` [INFO] [stdout] 2f3b053c874c7b71d7891faa1a094ec9ee71c9ba6dd6e3f656bfda3c3cb46d55