[INFO] cloning repository https://github.com/onContentStop/silver [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/onContentStop/silver" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FonContentStop%2Fsilver", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FonContentStop%2Fsilver'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e51c32189839b24c029eb52c87f9b4ed3b0c75a0 [INFO] linting onContentStop/silver against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FonContentStop%2Fsilver" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/onContentStop/silver [INFO] finished tweaking git repo https://github.com/onContentStop/silver [INFO] tweaked toml for git repo https://github.com/onContentStop/silver written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/onContentStop/silver on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/onContentStop/silver already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded derive_more v0.99.11 [INFO] [stderr] Downloaded smallvec v1.5.1 [INFO] [stderr] Downloaded credibility v0.1.3 [INFO] [stderr] Downloaded output_vt100 v0.1.2 [INFO] [stderr] Downloaded rand_xorshift v0.2.0 [INFO] [stderr] Downloaded parking_lot_core v0.8.1 [INFO] [stderr] Downloaded anyhow v1.0.35 [INFO] [stderr] Downloaded signal-hook v0.1.16 [INFO] [stderr] Downloaded pretty_assertions v0.6.1 [INFO] [stderr] Downloaded proptest v0.10.1 [INFO] [stderr] Downloaded crossterm v0.18.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1fb520885d15ca2ac45321743813eb26d8a9f5ddb8b4ec98b76f96c215780a4d [INFO] running `Command { std: "docker" "start" "-a" "1fb520885d15ca2ac45321743813eb26d8a9f5ddb8b4ec98b76f96c215780a4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1fb520885d15ca2ac45321743813eb26d8a9f5ddb8b4ec98b76f96c215780a4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1fb520885d15ca2ac45321743813eb26d8a9f5ddb8b4ec98b76f96c215780a4d", kill_on_drop: false }` [INFO] [stdout] 1fb520885d15ca2ac45321743813eb26d8a9f5ddb8b4ec98b76f96c215780a4d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 92a404f03a043f4886e9f0bc8ae33fc4c0f28a3d0dcc425c5319eba5cd3df487 [INFO] running `Command { std: "docker" "start" "-a" "92a404f03a043f4886e9f0bc8ae33fc4c0f28a3d0dcc425c5319eba5cd3df487", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.54 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking smallvec v1.5.1 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking gimli v0.23.0 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Compiling miniz_oxide v0.4.3 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking object v0.22.0 [INFO] [stderr] Checking rustc-demangle v0.1.18 [INFO] [stderr] Compiling anyhow v1.0.35 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking strum v0.20.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking bit-set v0.5.2 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Checking pretty_assertions v0.6.1 [INFO] [stderr] Checking signal-hook-registry v1.2.2 [INFO] [stderr] Checking parking_lot_core v0.8.1 [INFO] [stderr] Checking mio v0.7.6 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_xorshift v0.2.0 [INFO] [stderr] Checking signal-hook v0.1.16 [INFO] [stderr] Checking crossterm v0.18.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking addr2line v0.14.0 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking backtrace v0.3.55 [INFO] [stderr] Checking proptest v0.10.1 [INFO] [stderr] Compiling synstructure v0.12.4 [INFO] [stderr] Compiling strum_macros v0.20.1 [INFO] [stderr] Compiling derive_more v0.99.11 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking credibility v0.1.3 [INFO] [stderr] Checking silver-language v0.1.0 (/opt/rustwide/workdir/silver-language) [INFO] [stdout] warning: trait `BoundNode` is never used [INFO] [stdout] --> silver-language/src/analysis/binding/bound_node.rs:3:18 [INFO] [stdout] | [INFO] [stdout] 3 | pub(crate) trait BoundNode { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `BoundNodeKind` is never used [INFO] [stdout] --> silver-language/src/analysis/binding/bound_node_kind.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | pub(crate) enum BoundNodeKind { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `SyntaxKindWithText` is never used [INFO] [stdout] --> silver-language/src/analysis/syntax/syntax_facts.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) trait SyntaxKindWithText { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `text` and `span` are never used [INFO] [stdout] --> silver-language/src/analysis/syntax/syntax_node.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub trait SyntaxNodeExt { [INFO] [stdout] | ------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 15 | fn text(&self) -> Option<&str>; [INFO] [stdout] | ^^^^ [INFO] [stdout] 16 | fn span(&self) -> TextSpan; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> silver-language/src/analysis/errors/null_error_reporter.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / impl Default for NullErrorReporter { [INFO] [stdout] 14 | | fn default() -> Self { [INFO] [stdout] 15 | | Self { had_error: false } [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 3 + #[derive(Default)] [INFO] [stdout] 4 | pub struct NullErrorReporter { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> silver-language/src/analysis/errors/string_error_reporter.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / impl Default for StringErrorReporter { [INFO] [stdout] 15 | | fn default() -> Self { [INFO] [stdout] 16 | | Self { errors: vec![] } [INFO] [stdout] 17 | | } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 4 + #[derive(Default)] [INFO] [stdout] 5 | pub struct StringErrorReporter { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> silver-language/src/analysis/syntax/lexer.rs:10:6 [INFO] [stdout] | [INFO] [stdout] 10 | impl<'source> Lexer { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> silver-language/src/analysis/text/source_text.rs:103:1 [INFO] [stdout] | [INFO] [stdout] 103 | / impl ToString for SourceText { [INFO] [stdout] 104 | | fn to_string(&self) -> String { [INFO] [stdout] 105 | | self.text.clone() [INFO] [stdout] 106 | | } [INFO] [stdout] 107 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `BoundNode` is never used [INFO] [stdout] --> silver-language/src/analysis/binding/bound_node.rs:3:18 [INFO] [stdout] | [INFO] [stdout] 3 | pub(crate) trait BoundNode { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `BoundNodeKind` is never used [INFO] [stdout] --> silver-language/src/analysis/binding/bound_node_kind.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | pub(crate) enum BoundNodeKind { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `span` is never used [INFO] [stdout] --> silver-language/src/analysis/syntax/syntax_node.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub trait SyntaxNodeExt { [INFO] [stdout] | ------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 16 | fn span(&self) -> TextSpan; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking silver v0.1.0 (/opt/rustwide/workdir/silver) [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> silver-language/src/analysis/errors/null_error_reporter.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / impl Default for NullErrorReporter { [INFO] [stdout] 14 | | fn default() -> Self { [INFO] [stdout] 15 | | Self { had_error: false } [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 3 + #[derive(Default)] [INFO] [stdout] 4 | pub struct NullErrorReporter { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> silver-language/src/analysis/errors/string_error_reporter.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / impl Default for StringErrorReporter { [INFO] [stdout] 15 | | fn default() -> Self { [INFO] [stdout] 16 | | Self { errors: vec![] } [INFO] [stdout] 17 | | } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 4 + #[derive(Default)] [INFO] [stdout] 5 | pub struct StringErrorReporter { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> silver-language/src/analysis/syntax/lexer.rs:10:6 [INFO] [stdout] | [INFO] [stdout] 10 | impl<'source> Lexer { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> silver-language/src/analysis/syntax/lexer.rs:235:17 [INFO] [stdout] | [INFO] [stdout] 235 | / if let Some(t) = k.get_text() { [INFO] [stdout] 236 | | Some((t, k)) [INFO] [stdout] 237 | | } else { [INFO] [stdout] 238 | | None [INFO] [stdout] 239 | | } [INFO] [stdout] | |_________________^ help: try: `k.get_text().map(|t| (t, k))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> silver-language/src/analysis/syntax/lexer.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 286 | / t1_is_keyword && t2_is_keyword [INFO] [stdout] 287 | | || t1_is_keyword && t2kind == SyntaxKind::IdentifierToken [INFO] [stdout] 288 | | || t1kind == SyntaxKind::IdentifierToken && t2_is_keyword [INFO] [stdout] 289 | | || t1kind == SyntaxKind::IdentifierToken && t2kind == SyntaxKind::IdentifierToken [INFO] [stdout] | |_____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 286 - t1_is_keyword && t2_is_keyword [INFO] [stdout] 287 - || t1_is_keyword && t2kind == SyntaxKind::IdentifierToken [INFO] [stdout] 288 - || t1kind == SyntaxKind::IdentifierToken && t2_is_keyword [INFO] [stdout] 289 - || t1kind == SyntaxKind::IdentifierToken && t2kind == SyntaxKind::IdentifierToken [INFO] [stdout] 286 + !(!t2_is_keyword && t2kind != SyntaxKind::IdentifierToken || !t1_is_keyword && t1kind != SyntaxKind::IdentifierToken) [INFO] [stdout] | [INFO] [stdout] 286 - t1_is_keyword && t2_is_keyword [INFO] [stdout] 287 - || t1_is_keyword && t2kind == SyntaxKind::IdentifierToken [INFO] [stdout] 288 - || t1kind == SyntaxKind::IdentifierToken && t2_is_keyword [INFO] [stdout] 289 - || t1kind == SyntaxKind::IdentifierToken && t2kind == SyntaxKind::IdentifierToken [INFO] [stdout] 286 + (t1kind == SyntaxKind::IdentifierToken || t1_is_keyword) && (t2kind == SyntaxKind::IdentifierToken || t2_is_keyword) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> silver-language/src/analysis/syntax/lexer.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 286 | / t1_is_keyword && t2_is_keyword [INFO] [stdout] 287 | | || t1_is_keyword && t2kind == SyntaxKind::IdentifierToken [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 286 - t1_is_keyword && t2_is_keyword [INFO] [stdout] 287 - || t1_is_keyword && t2kind == SyntaxKind::IdentifierToken [INFO] [stdout] 286 + !(!t1_is_keyword || !t2_is_keyword && t2kind != SyntaxKind::IdentifierToken) [INFO] [stdout] | [INFO] [stdout] 286 - t1_is_keyword && t2_is_keyword [INFO] [stdout] 287 - || t1_is_keyword && t2kind == SyntaxKind::IdentifierToken [INFO] [stdout] 286 + (t2kind == SyntaxKind::IdentifierToken || t2_is_keyword) && t1_is_keyword [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> silver/src/view_options.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | / impl Default for ViewOptions { [INFO] [stdout] 6 | | fn default() -> Self { [INFO] [stdout] 7 | | Self { show_tree: false } [INFO] [stdout] 8 | | } [INFO] [stdout] 9 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 1 + #[derive(Default)] [INFO] [stdout] 2 | pub(crate) struct ViewOptions { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> silver/src/view_options.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | / impl Default for ViewOptions { [INFO] [stdout] 6 | | fn default() -> Self { [INFO] [stdout] 7 | | Self { show_tree: false } [INFO] [stdout] 8 | | } [INFO] [stdout] 9 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 1 + #[derive(Default)] [INFO] [stdout] 2 | pub(crate) struct ViewOptions { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> silver-language/src/analysis/text/source_text.rs:103:1 [INFO] [stdout] | [INFO] [stdout] 103 | / impl ToString for SourceText { [INFO] [stdout] 104 | | fn to_string(&self) -> String { [INFO] [stdout] 105 | | self.text.clone() [INFO] [stdout] 106 | | } [INFO] [stdout] 107 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> silver-language/src/analysis/syntax/lexer.rs:242:30 [INFO] [stdout] | [INFO] [stdout] 242 | let dynamic_tokens = vec![ [INFO] [stdout] | ______________________________^ [INFO] [stdout] 243 | | ("a", SyntaxKind::IdentifierToken), [INFO] [stdout] 244 | | ("abc", SyntaxKind::IdentifierToken), [INFO] [stdout] 245 | | ("abcABC", SyntaxKind::IdentifierToken), [INFO] [stdout] 246 | | ("1", SyntaxKind::NumberToken), [INFO] [stdout] 247 | | ("123", SyntaxKind::NumberToken), [INFO] [stdout] 248 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 242 ~ let dynamic_tokens = [("a", SyntaxKind::IdentifierToken), [INFO] [stdout] 243 + ("abc", SyntaxKind::IdentifierToken), [INFO] [stdout] 244 + ("abcABC", SyntaxKind::IdentifierToken), [INFO] [stdout] 245 + ("1", SyntaxKind::NumberToken), [INFO] [stdout] 246 ~ ("123", SyntaxKind::NumberToken)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.58s [INFO] running `Command { std: "docker" "inspect" "92a404f03a043f4886e9f0bc8ae33fc4c0f28a3d0dcc425c5319eba5cd3df487", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92a404f03a043f4886e9f0bc8ae33fc4c0f28a3d0dcc425c5319eba5cd3df487", kill_on_drop: false }` [INFO] [stdout] 92a404f03a043f4886e9f0bc8ae33fc4c0f28a3d0dcc425c5319eba5cd3df487