[INFO] cloning repository https://github.com/omkargwagholikar/Termion [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/omkargwagholikar/Termion" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fomkargwagholikar%2FTermion", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fomkargwagholikar%2FTermion'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e7a55e6ce277c2be918447e64b9161c7b6c4b8bd [INFO] linting omkargwagholikar/Termion against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fomkargwagholikar%2FTermion" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/omkargwagholikar/Termion [INFO] finished tweaking git repo https://github.com/omkargwagholikar/Termion [INFO] tweaked toml for git repo https://github.com/omkargwagholikar/Termion written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/omkargwagholikar/Termion on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/omkargwagholikar/Termion already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ecolor v0.30.0 [INFO] [stderr] Downloaded emath v0.30.0 [INFO] [stderr] Downloaded accesskit_unix v0.13.1 [INFO] [stderr] Downloaded egui_glow v0.30.0 [INFO] [stderr] Downloaded egui-wgpu v0.30.0 [INFO] [stderr] Downloaded async-trait v0.1.84 [INFO] [stderr] Downloaded webbrowser v1.0.3 [INFO] [stderr] Downloaded epaint v0.30.0 [INFO] [stderr] Downloaded eframe v0.30.0 [INFO] [stderr] Downloaded accesskit_atspi_common v0.10.1 [INFO] [stderr] Downloaded egui-winit v0.30.0 [INFO] [stderr] Downloaded winnow v0.6.21 [INFO] [stderr] Downloaded egui v0.30.0 [INFO] [stderr] Downloaded winit v0.30.7 [INFO] [stderr] Downloaded epaint_default_fonts v0.30.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 78e38f48cd23613df6d162283193cf0cc37e6bdcca11dc89cd572f44f0e69d7c [INFO] running `Command { std: "docker" "start" "-a" "78e38f48cd23613df6d162283193cf0cc37e6bdcca11dc89cd572f44f0e69d7c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "78e38f48cd23613df6d162283193cf0cc37e6bdcca11dc89cd572f44f0e69d7c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "78e38f48cd23613df6d162283193cf0cc37e6bdcca11dc89cd572f44f0e69d7c", kill_on_drop: false }` [INFO] [stdout] 78e38f48cd23613df6d162283193cf0cc37e6bdcca11dc89cd572f44f0e69d7c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1054cf3b20955f4a547c762a383f04578b9bdee797bacf07217d69c7f1f735ee [INFO] running `Command { std: "docker" "start" "-a" "1054cf3b20955f4a547c762a383f04578b9bdee797bacf07217d69c7f1f735ee", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.42 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Compiling winnow v0.6.21 [INFO] [stderr] Checking libloading v0.8.6 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling indexmap v2.7.0 [INFO] [stderr] Compiling wayland-sys v0.31.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling cc v1.2.7 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling quick-xml v0.36.2 [INFO] [stderr] Compiling wayland-client v0.31.7 [INFO] [stderr] Checking futures-lite v2.5.0 [INFO] [stderr] Compiling endi v1.1.0 [INFO] [stderr] Compiling syn v2.0.94 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking cpufeatures v0.2.16 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking event-listener-strategy v0.5.3 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking async-executor v1.13.1 [INFO] [stderr] Compiling wayland-scanner v0.31.5 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Compiling xml-rs v0.8.24 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking xcursor v0.3.8 [INFO] [stderr] Checking cursor-icon v1.1.0 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Checking accesskit v0.17.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking as-raw-xcb-connection v1.0.1 [INFO] [stderr] Checking x11rb-protocol v0.13.1 [INFO] [stderr] Checking foldhash v0.1.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking immutable-chunkmap v2.0.6 [INFO] [stderr] Compiling winit v0.30.7 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Compiling toml_edit v0.22.22 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking profiling v1.0.16 [INFO] [stderr] Checking dpi v0.1.1 [INFO] [stderr] Checking epaint_default_fonts v0.30.0 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking miniz_oxide v0.8.2 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling wayland-backend v0.3.7 [INFO] [stderr] Compiling glutin v0.32.1 [INFO] [stderr] Checking accesskit_consumer v0.26.0 [INFO] [stderr] Compiling glutin-winit v0.5.0 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking glow v0.16.0 [INFO] [stderr] Checking flate2 v1.0.35 [INFO] [stderr] Compiling glutin_egl_sys v0.7.0 [INFO] [stderr] Compiling glutin_glx_sys v0.6.0 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking owned_ttf_parser v0.25.0 [INFO] [stderr] Checking ab_glyph v0.2.29 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling enumflags2_derive v0.7.10 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling bytemuck_derive v1.8.1 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling async-trait v0.1.84 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking bytemuck v1.21.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking emath v0.30.0 [INFO] [stderr] Checking image v0.25.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking async-io v2.4.0 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking ecolor v0.30.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking epaint v0.30.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking egui v0.30.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking wayland-protocols v0.32.5 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking wayland-cursor v0.31.7 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Compiling enumflags2 v0.7.10 [INFO] [stderr] Compiling quick-xml v0.30.0 [INFO] [stderr] Compiling zvariant v4.2.0 [INFO] [stderr] Checking egui_glow v0.30.0 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.5 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.5 [INFO] [stderr] Checking webbrowser v1.0.3 [INFO] [stderr] Compiling zbus_names v3.0.0 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Compiling zbus_xml v4.0.0 [INFO] [stderr] Compiling zbus-lockstep v0.4.4 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Compiling zbus-lockstep-macros v0.4.4 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.2 [INFO] [stderr] Checking arboard v3.4.1 [INFO] [stderr] Checking atspi-common v0.6.0 [INFO] [stderr] Checking atspi-proxies v0.6.0 [INFO] [stderr] Checking accesskit_atspi_common v0.10.1 [INFO] [stderr] Checking atspi-connection v0.6.0 [INFO] [stderr] Checking atspi v0.22.0 [INFO] [stderr] Checking accesskit_unix v0.13.1 [INFO] [stderr] Checking accesskit_winit v0.23.1 [INFO] [stderr] Checking egui-winit v0.30.0 [INFO] [stderr] Checking eframe v0.30.0 [INFO] [stderr] Checking terminal_emulator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/main.rs:75:17 [INFO] [stdout] | [INFO] [stdout] 74 | nix::unistd::execvp(shell_name, &args).unwrap(); [INFO] [stdout] | ----------------------------------------------- any code following this expression is unreachable [INFO] [stdout] 75 | exit(1); // Only reached if execvp fails [INFO] [stdout] | ^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] note: this expression has type `std::convert::Infallible`, which is uninhabited [INFO] [stdout] --> src/main.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | nix::unistd::execvp(shell_name, &args).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 137 | return (width, height); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return (width, height); [INFO] [stdout] 137 + (width, height) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/main.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | / job.wrap = egui::text::TextWrapping { [INFO] [stdout] 148 | | max_width: f32::INFINITY, [INFO] [stdout] 149 | | ..Default::default() [INFO] [stdout] 150 | | }; [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `eframe::egui::text::LayoutJob { wrap: egui::text::TextWrapping { [INFO] [stdout] max_width: f32::INFINITY, [INFO] [stdout] ..Default::default() [INFO] [stdout] }, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/main.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | let mut job = LayoutJob::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:261:16 [INFO] [stdout] | [INFO] [stdout] 261 | if j > 0 && buf[j] == b'[' && j > 0 && buf[j - 1] == b'\x1b' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 261 - if j > 0 && buf[j] == b'[' && j > 0 && buf[j - 1] == b'\x1b' { [INFO] [stdout] 261 + if !(j <= 0 || buf[j] != b'[' || buf[j - 1] != b'\x1b') { [INFO] [stdout] | [INFO] [stdout] 261 - if j > 0 && buf[j] == b'[' && j > 0 && buf[j - 1] == b'\x1b' { [INFO] [stdout] 261 + if j > 0 && buf[j] == b'[' && buf[j - 1] == b'\x1b' { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:261:16 [INFO] [stdout] | [INFO] [stdout] 261 | if j > 0 && buf[j] == b'[' && j > 0 && buf[j - 1] == b'\x1b' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 261 - if j > 0 && buf[j] == b'[' && j > 0 && buf[j - 1] == b'\x1b' { [INFO] [stdout] 261 + if !(j <= 0 || buf[j] != b'[') && buf[j - 1] == b'\x1b' { [INFO] [stdout] | [INFO] [stdout] 261 - if j > 0 && buf[j] == b'[' && j > 0 && buf[j - 1] == b'\x1b' { [INFO] [stdout] 261 + if j > 0 && buf[j] == b'[' && buf[j - 1] == b'\x1b' { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/main.rs:75:17 [INFO] [stdout] | [INFO] [stdout] 74 | nix::unistd::execvp(shell_name, &args).unwrap(); [INFO] [stdout] | ----------------------------------------------- any code following this expression is unreachable [INFO] [stdout] 75 | exit(1); // Only reached if execvp fails [INFO] [stdout] | ^^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] note: this expression has type `std::convert::Infallible`, which is uninhabited [INFO] [stdout] --> src/main.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | nix::unistd::execvp(shell_name, &args).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:379:51 [INFO] [stdout] | [INFO] [stdout] 379 | let mut to_write: &[u8] = &bytes; [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:380:31 [INFO] [stdout] | [INFO] [stdout] 380 | while to_write.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!to_write.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:416:41 [INFO] [stdout] | [INFO] [stdout] 416 | / ... if *pressed { [INFO] [stdout] 417 | | ... if !self.current_command.trim().is_empty() { [INFO] [stdout] 418 | | ... self.command_history.push(self.current_command.clone()); [INFO] [stdout] ... | [INFO] [stdout] 423 | | ... "" [INFO] [stdout] 424 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 415 ~ egui::Key::Enter [INFO] [stdout] 416 ~ if *pressed => { [INFO] [stdout] 417 | if !self.current_command.trim().is_empty() { [INFO] [stdout] ... [INFO] [stdout] 421 | "\n" [INFO] [stdout] 422 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:442:55 [INFO] [stdout] | [INFO] [stdout] 442 | ... let mut to_write: &[u8] = &bytes; [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 137 | return (width, height); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return (width, height); [INFO] [stdout] 137 + (width, height) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/main.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | / job.wrap = egui::text::TextWrapping { [INFO] [stdout] 148 | | max_width: f32::INFINITY, [INFO] [stdout] 149 | | ..Default::default() [INFO] [stdout] 150 | | }; [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `eframe::egui::text::LayoutJob { wrap: egui::text::TextWrapping { [INFO] [stdout] max_width: f32::INFINITY, [INFO] [stdout] ..Default::default() [INFO] [stdout] }, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/main.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | let mut job = LayoutJob::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:261:16 [INFO] [stdout] | [INFO] [stdout] 261 | if j > 0 && buf[j] == b'[' && j > 0 && buf[j - 1] == b'\x1b' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 261 - if j > 0 && buf[j] == b'[' && j > 0 && buf[j - 1] == b'\x1b' { [INFO] [stdout] 261 + if !(j <= 0 || buf[j] != b'[' || buf[j - 1] != b'\x1b') { [INFO] [stdout] | [INFO] [stdout] 261 - if j > 0 && buf[j] == b'[' && j > 0 && buf[j - 1] == b'\x1b' { [INFO] [stdout] 261 + if j > 0 && buf[j] == b'[' && buf[j - 1] == b'\x1b' { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:261:16 [INFO] [stdout] | [INFO] [stdout] 261 | if j > 0 && buf[j] == b'[' && j > 0 && buf[j - 1] == b'\x1b' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 261 - if j > 0 && buf[j] == b'[' && j > 0 && buf[j - 1] == b'\x1b' { [INFO] [stdout] 261 + if !(j <= 0 || buf[j] != b'[') && buf[j - 1] == b'\x1b' { [INFO] [stdout] | [INFO] [stdout] 261 - if j > 0 && buf[j] == b'[' && j > 0 && buf[j - 1] == b'\x1b' { [INFO] [stdout] 261 + if j > 0 && buf[j] == b'[' && buf[j - 1] == b'\x1b' { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:379:51 [INFO] [stdout] | [INFO] [stdout] 379 | let mut to_write: &[u8] = &bytes; [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:380:31 [INFO] [stdout] | [INFO] [stdout] 380 | while to_write.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!to_write.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:416:41 [INFO] [stdout] | [INFO] [stdout] 416 | / ... if *pressed { [INFO] [stdout] 417 | | ... if !self.current_command.trim().is_empty() { [INFO] [stdout] 418 | | ... self.command_history.push(self.current_command.clone()); [INFO] [stdout] ... | [INFO] [stdout] 423 | | ... "" [INFO] [stdout] 424 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 415 ~ egui::Key::Enter [INFO] [stdout] 416 ~ if *pressed => { [INFO] [stdout] 417 | if !self.current_command.trim().is_empty() { [INFO] [stdout] ... [INFO] [stdout] 421 | "\n" [INFO] [stdout] 422 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:442:55 [INFO] [stdout] | [INFO] [stdout] 442 | ... let mut to_write: &[u8] = &bytes; [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 50.43s [INFO] running `Command { std: "docker" "inspect" "1054cf3b20955f4a547c762a383f04578b9bdee797bacf07217d69c7f1f735ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1054cf3b20955f4a547c762a383f04578b9bdee797bacf07217d69c7f1f735ee", kill_on_drop: false }` [INFO] [stdout] 1054cf3b20955f4a547c762a383f04578b9bdee797bacf07217d69c7f1f735ee