[INFO] cloning repository https://github.com/omersajid9/sudoku_api [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/omersajid9/sudoku_api" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fomersajid9%2Fsudoku_api", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fomersajid9%2Fsudoku_api'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 843f9c9b2d09d552cc796aadf1b3710201f84734 [INFO] linting omersajid9/sudoku_api against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fomersajid9%2Fsudoku_api" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/omersajid9/sudoku_api [INFO] finished tweaking git repo https://github.com/omersajid9/sudoku_api [INFO] tweaked toml for git repo https://github.com/omersajid9/sudoku_api written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/omersajid9/sudoku_api on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/omersajid9/sudoku_api already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f5764a9b45068f5bb2e32ad1a5253334bff88ba71748909d2aca10286d51200 [INFO] running `Command { std: "docker" "start" "-a" "5f5764a9b45068f5bb2e32ad1a5253334bff88ba71748909d2aca10286d51200", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f5764a9b45068f5bb2e32ad1a5253334bff88ba71748909d2aca10286d51200", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f5764a9b45068f5bb2e32ad1a5253334bff88ba71748909d2aca10286d51200", kill_on_drop: false }` [INFO] [stdout] 5f5764a9b45068f5bb2e32ad1a5253334bff88ba71748909d2aca10286d51200 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8b7bfbf8de0e438b2347d72399bc4ece6c51e2bddb75a3b589502e89161e1d84 [INFO] running `Command { std: "docker" "start" "-a" "8b7bfbf8de0e438b2347d72399bc4ece6c51e2bddb75a3b589502e89161e1d84", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.162 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tokio v1.41.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking api v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: type `sudoku::ModeType` is more private than the item `sudoku::Sudoku::mode` [INFO] [stdout] --> src/sudoku.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | pub mode: ModeType, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ field `sudoku::Sudoku::mode` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `sudoku::ModeType` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/sudoku.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | struct ModeType { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sudoku.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 118 | if !self.solve().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.solve().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/sudoku.rs:112:24 [INFO] [stdout] | [INFO] [stdout] 112 | if let Ok(_) = self.set(fill_x, fill_y, allowed_numbers[random_index]) { [INFO] [stdout] | -------^^^^^---------------------------------------------------------- help: try: `if self.set(fill_x, fill_y, allowed_numbers[random_index]).is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `sudoku::ModeType` is more private than the item `sudoku::Sudoku::mode` [INFO] [stdout] --> src/sudoku.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | pub mode: ModeType, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ field `sudoku::Sudoku::mode` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `sudoku::ModeType` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/sudoku.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | struct ModeType { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/sudoku.rs:270:24 [INFO] [stdout] | [INFO] [stdout] 270 | if let Ok(_) = self.set(x, y, value) { [INFO] [stdout] | -------^^^^^------------------------ help: try: `if self.set(x, y, value).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:103:30 [INFO] [stdout] | [INFO] [stdout] 103 | fn count_filled_cells(board: &Vec>) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 103 - fn count_filled_cells(board: &Vec>) -> usize { [INFO] [stdout] 103 + fn count_filled_cells(board: &[Vec]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:110:23 [INFO] [stdout] | [INFO] [stdout] 110 | fn print_board(board: &Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 110 - fn print_board(board: &Vec>) { [INFO] [stdout] 110 + fn print_board(board: &[Vec]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sudoku.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 118 | if !self.solve().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.solve().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/sudoku.rs:112:24 [INFO] [stdout] | [INFO] [stdout] 112 | if let Ok(_) = self.set(fill_x, fill_y, allowed_numbers[random_index]) { [INFO] [stdout] | -------^^^^^---------------------------------------------------------- help: try: `if self.set(fill_x, fill_y, allowed_numbers[random_index]).is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/sudoku.rs:270:24 [INFO] [stdout] | [INFO] [stdout] 270 | if let Ok(_) = self.set(x, y, value) { [INFO] [stdout] | -------^^^^^------------------------ help: try: `if self.set(x, y, value).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:103:30 [INFO] [stdout] | [INFO] [stdout] 103 | fn count_filled_cells(board: &Vec>) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 103 - fn count_filled_cells(board: &Vec>) -> usize { [INFO] [stdout] 103 + fn count_filled_cells(board: &[Vec]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:110:23 [INFO] [stdout] | [INFO] [stdout] 110 | fn print_board(board: &Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 110 - fn print_board(board: &Vec>) { [INFO] [stdout] 110 + fn print_board(board: &[Vec]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.91s [INFO] running `Command { std: "docker" "inspect" "8b7bfbf8de0e438b2347d72399bc4ece6c51e2bddb75a3b589502e89161e1d84", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b7bfbf8de0e438b2347d72399bc4ece6c51e2bddb75a3b589502e89161e1d84", kill_on_drop: false }` [INFO] [stdout] 8b7bfbf8de0e438b2347d72399bc4ece6c51e2bddb75a3b589502e89161e1d84