[INFO] cloning repository https://github.com/obwan02/xanal [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/obwan02/xanal" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fobwan02%2Fxanal", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fobwan02%2Fxanal'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b4222a819dc31d4b1bafad8c9e5c0c0a630e34b4 [INFO] linting obwan02/xanal against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fobwan02%2Fxanal" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/obwan02/xanal [INFO] finished tweaking git repo https://github.com/obwan02/xanal [INFO] tweaked toml for git repo https://github.com/obwan02/xanal written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/obwan02/xanal on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/obwan02/xanal already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ppv-lite86 v0.2.16 [INFO] [stderr] Downloaded unicode-width v0.1.9 [INFO] [stderr] Downloaded getrandom v0.2.7 [INFO] [stderr] Downloaded simple-error v0.2.3 [INFO] [stderr] Downloaded num_threads v0.1.6 [INFO] [stderr] Downloaded lipsum v0.8.2 [INFO] [stderr] Downloaded thiserror-impl v1.0.31 [INFO] [stderr] Downloaded clap_derive v3.2.7 [INFO] [stderr] Downloaded rustversion v1.0.7 [INFO] [stderr] Downloaded indexmap v1.9.1 [INFO] [stderr] Downloaded textwrap v0.15.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.40 [INFO] [stderr] Downloaded hashbrown v0.12.2 [INFO] [stderr] Downloaded time-macros v0.2.4 [INFO] [stderr] Downloaded time v0.3.11 [INFO] [stderr] Downloaded quote v1.0.20 [INFO] [stderr] Downloaded flexi_logger v0.22.5 [INFO] [stderr] Downloaded thiserror v1.0.31 [INFO] [stderr] Downloaded os_str_bytes v6.1.0 [INFO] [stderr] Downloaded clap v3.2.11 [INFO] [stderr] Downloaded regex-syntax v0.6.27 [INFO] [stderr] Downloaded libc v0.2.126 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29f9920a075743a79ed25201cf95f4ce3911989101aa9e92d12ca1d5b87f280b [INFO] running `Command { std: "docker" "start" "-a" "29f9920a075743a79ed25201cf95f4ce3911989101aa9e92d12ca1d5b87f280b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29f9920a075743a79ed25201cf95f4ce3911989101aa9e92d12ca1d5b87f280b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29f9920a075743a79ed25201cf95f4ce3911989101aa9e92d12ca1d5b87f280b", kill_on_drop: false }` [INFO] [stdout] 29f9920a075743a79ed25201cf95f4ce3911989101aa9e92d12ca1d5b87f280b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d7d744617d60c6b944b6e13b5e616c57d1b1211a26fac8f25ffd40d47fe7ce9b [INFO] running `Command { std: "docker" "start" "-a" "d7d744617d60c6b944b6e13b5e616c57d1b1211a26fac8f25ffd40d47fe7ce9b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling rustversion v1.0.7 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking hashbrown v0.12.2 [INFO] [stderr] Compiling time-macros v0.2.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking os_str_bytes v6.1.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking simple-error v0.2.3 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking time v0.3.11 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking lipsum v0.8.2 [INFO] [stderr] Checking console v0.15.0 [INFO] [stderr] Checking indicatif v0.16.2 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling clap_derive v3.2.7 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking flexi_logger v0.22.5 [INFO] [stderr] Checking clap v3.2.11 [INFO] [stderr] Checking xcrypt v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/key_guess.rs:19:6 [INFO] [stdout] | [INFO] [stdout] 19 | impl<'a> GuessMethod for MostCommonMethod { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/key_guess.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | / let mut keys = Vec::new(); [INFO] [stdout] 55 | | keys.push(key); [INFO] [stdout] | |_______________________^ help: consider using the `vec![]` macro: `let keys = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/key_guess.rs:19:6 [INFO] [stdout] | [INFO] [stdout] 19 | impl<'a> GuessMethod for MostCommonMethod { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/key_guess.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 94 | if &enc_diff[i..end_index] == &crib_diff { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 94 - if &enc_diff[i..end_index] == &crib_diff { [INFO] [stdout] 94 + if enc_diff[i..end_index] == crib_diff { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/kl_anal.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | let ic = ic as f32 / (length * (length - 1)) as f32; [INFO] [stdout] | ---------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 19 | ic [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 18 ~ [INFO] [stdout] 19 ~ ic as f32 / (length * (length - 1)) as f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/kl_anal.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | .fold(0, |accum, x| accum + x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/key_guess.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | / let mut keys = Vec::new(); [INFO] [stdout] 55 | | keys.push(key); [INFO] [stdout] | |_______________________^ help: consider using the `vec![]` macro: `let keys = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/kl_anal.rs:67:20 [INFO] [stdout] | [INFO] [stdout] 67 | if !((i + 1) % (best_guess_i + 1) == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((i + 1) % (best_guess_i + 1) != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/key_guess.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 94 | if &enc_diff[i..end_index] == &crib_diff { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 94 - if &enc_diff[i..end_index] == &crib_diff { [INFO] [stdout] 94 + if enc_diff[i..end_index] == crib_diff { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/kl_anal.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | let ic = ic as f32 / (length * (length - 1)) as f32; [INFO] [stdout] | ---------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 19 | ic [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 18 ~ [INFO] [stdout] 19 ~ ic as f32 / (length * (length - 1)) as f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/kl_anal.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | .fold(0, |accum, x| accum + x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/kl_anal.rs:67:20 [INFO] [stdout] | [INFO] [stdout] 67 | if !((i + 1) % (best_guess_i + 1) == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((i + 1) % (best_guess_i + 1) != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:197:31 [INFO] [stdout] | [INFO] [stdout] 197 | let mut file = File::open(&file)?; [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/lib.rs:211:57 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn run(config: Config, enable_verbose: impl FnOnce() -> ()) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:219:8 [INFO] [stdout] | [INFO] [stdout] 219 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:254:8 [INFO] [stdout] | [INFO] [stdout] 254 | if key_guesses.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `key_guesses.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:277:52 [INFO] [stdout] | [INFO] [stdout] 277 | let path = path.with_file_name(&format!( [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 278 | | "{}-{}{}{}", [INFO] [stdout] 279 | | path.file_stem() [INFO] [stdout] 280 | | .unwrap_or(OsStr::new("")) [INFO] [stdout] ... | [INFO] [stdout] 288 | | .unwrap_or(""), [INFO] [stdout] 289 | | )); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 277 ~ let path = path.with_file_name(format!( [INFO] [stdout] 278 + "{}-{}{}{}", [INFO] [stdout] 279 + path.file_stem() [INFO] [stdout] 280 + .unwrap_or(OsStr::new("")) [INFO] [stdout] 281 + .to_str() [INFO] [stdout] 282 + .unwrap_or(""), [INFO] [stdout] 283 + i, [INFO] [stdout] 284 + dot, [INFO] [stdout] 285 + path.extension() [INFO] [stdout] 286 + .unwrap_or(OsStr::new("")) [INFO] [stdout] 287 + .to_str() [INFO] [stdout] 288 + .unwrap_or(""), [INFO] [stdout] 289 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:197:31 [INFO] [stdout] | [INFO] [stdout] 197 | let mut file = File::open(&file)?; [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/lib.rs:211:57 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn run(config: Config, enable_verbose: impl FnOnce() -> ()) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:219:8 [INFO] [stdout] | [INFO] [stdout] 219 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:254:8 [INFO] [stdout] | [INFO] [stdout] 254 | if key_guesses.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `key_guesses.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:277:52 [INFO] [stdout] | [INFO] [stdout] 277 | let path = path.with_file_name(&format!( [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 278 | | "{}-{}{}{}", [INFO] [stdout] 279 | | path.file_stem() [INFO] [stdout] 280 | | .unwrap_or(OsStr::new("")) [INFO] [stdout] ... | [INFO] [stdout] 288 | | .unwrap_or(""), [INFO] [stdout] 289 | | )); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 277 ~ let path = path.with_file_name(format!( [INFO] [stdout] 278 + "{}-{}{}{}", [INFO] [stdout] 279 + path.file_stem() [INFO] [stdout] 280 + .unwrap_or(OsStr::new("")) [INFO] [stdout] 281 + .to_str() [INFO] [stdout] 282 + .unwrap_or(""), [INFO] [stdout] 283 + i, [INFO] [stdout] 284 + dot, [INFO] [stdout] 285 + path.extension() [INFO] [stdout] 286 + .unwrap_or(OsStr::new("")) [INFO] [stdout] 287 + .to_str() [INFO] [stdout] 288 + .unwrap_or(""), [INFO] [stdout] 289 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/main.rs:29:34 [INFO] [stdout] | [INFO] [stdout] 29 | write!(w, "{}", record.args().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/main.rs:29:34 [INFO] [stdout] | [INFO] [stdout] 29 | write!(w, "{}", record.args().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.59s [INFO] running `Command { std: "docker" "inspect" "d7d744617d60c6b944b6e13b5e616c57d1b1211a26fac8f25ffd40d47fe7ce9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7d744617d60c6b944b6e13b5e616c57d1b1211a26fac8f25ffd40d47fe7ce9b", kill_on_drop: false }` [INFO] [stdout] d7d744617d60c6b944b6e13b5e616c57d1b1211a26fac8f25ffd40d47fe7ce9b