[INFO] cloning repository https://github.com/oberien/iot2db [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/oberien/iot2db" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Foberien%2Fiot2db", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Foberien%2Fiot2db'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 17b4a920b454f5551562695ce483098ad095ce42 [INFO] linting oberien/iot2db against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Foberien%2Fiot2db" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-5-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/oberien/iot2db [INFO] finished tweaking git repo https://github.com/oberien/iot2db [INFO] tweaked toml for git repo https://github.com/oberien/iot2db written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/oberien/iot2db on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/oberien/iot2db already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/oberien/rebo` [INFO] [stderr] Updating git repository `https://github.com/oberien/diagnostic` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded utf8-cstr v0.1.6 [INFO] [stderr] Downloaded stringprep v0.1.3 [INFO] [stderr] Downloaded postgres-protocol v0.6.5 [INFO] [stderr] Downloaded systemd v0.10.0 [INFO] [stderr] Downloaded genawaiter-macro v0.99.1 [INFO] [stderr] Downloaded rt-format v0.3.1 [INFO] [stderr] Downloaded proc-macro-error v0.4.12 [INFO] [stderr] Downloaded genawaiter v0.99.1 [INFO] [stderr] Downloaded clap v4.5.31 [INFO] [stderr] Downloaded lexical-sort v0.3.1 [INFO] [stderr] Downloaded tokio-postgres v0.7.8 [INFO] [stderr] Downloaded lexical v5.2.2 [INFO] [stderr] Downloaded serde_with v3.1.0 [INFO] [stderr] Downloaded winnow v0.5.0 [INFO] [stderr] Downloaded serde_with_macros v3.1.0 [INFO] [stderr] Downloaded clap_builder v4.5.31 [INFO] [stderr] Downloaded libsystemd-sys v0.9.3 [INFO] [stderr] Downloaded any_ascii v0.1.7 [INFO] [stderr] Downloaded cstr-argument v0.1.2 [INFO] [stderr] Downloaded build-env v0.3.1 [INFO] [stderr] Downloaded postgres-types v0.2.5 [INFO] [stderr] Downloaded syn-mid v0.5.4 [INFO] [stderr] Downloaded proc-macro-error-attr v0.4.12 [INFO] [stderr] Downloaded genawaiter-proc-macro v0.99.1 [INFO] [stderr] Downloaded appendlist v1.4.0 [INFO] [stderr] Downloaded intervaltree v0.2.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff70212cdc010a8b248b43c5cdc45370c1f56d9388367d0d46a09c902f42accb [INFO] running `Command { std: "docker" "start" "-a" "ff70212cdc010a8b248b43c5cdc45370c1f56d9388367d0d46a09c902f42accb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff70212cdc010a8b248b43c5cdc45370c1f56d9388367d0d46a09c902f42accb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff70212cdc010a8b248b43c5cdc45370c1f56d9388367d0d46a09c902f42accb", kill_on_drop: false }` [INFO] [stdout] ff70212cdc010a8b248b43c5cdc45370c1f56d9388367d0d46a09c902f42accb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c57570ab36e3ea4899c2c1e895f25750c5a8afb23bfa0ae7f08868b1b552e25f [INFO] running `Command { std: "docker" "start" "-a" "c57570ab36e3ea4899c2c1e895f25750c5a8afb23bfa0ae7f08868b1b552e25f", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling cc v1.1.31 [INFO] [stderr] Compiling libc v0.2.161 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Checking siphasher v0.3.10 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking parking_lot_core v0.9.7 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking rustls-pki-types v1.10.0 [INFO] [stderr] Compiling openssl v0.10.55 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.12 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking regex-automata v0.3.3 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling proc-macro-error v0.4.12 [INFO] [stderr] Checking gimli v0.27.3 [INFO] [stderr] Compiling build-env v0.3.1 [INFO] [stderr] Checking phf_shared v0.10.0 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Compiling thiserror v1.0.65 [INFO] [stderr] Compiling getrandom v0.3.1 [INFO] [stderr] Compiling libsystemd-sys v0.9.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking stringprep v0.1.3 [INFO] [stderr] Checking md-5 v0.10.5 [INFO] [stderr] Compiling syn v2.0.85 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking object v0.31.1 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling unicode-segmentation v1.10.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling either v1.8.1 [INFO] [stderr] Checking clap_builder v4.5.31 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling openssl-sys v0.9.90 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling backtrace v0.3.68 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking postgres-protocol v0.6.5 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking regex v1.9.1 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking any_ascii v0.1.7 [INFO] [stderr] Checking winnow v0.5.0 [INFO] [stderr] Checking appendlist v1.4.0 [INFO] [stderr] Checking foreign-types-shared v0.3.1 [INFO] [stderr] Checking lexical-sort v0.3.1 [INFO] [stderr] Checking rt-format v0.3.1 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking rustls-native-certs v0.7.3 [INFO] [stderr] Checking addr2line v0.20.0 [INFO] [stderr] Checking uuid v1.15.1 [INFO] [stderr] Checking postgres-types v0.2.5 [INFO] [stderr] Checking flume v0.11.1 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking cstr-argument v0.1.2 [INFO] [stderr] Checking intervaltree v0.2.7 [INFO] [stderr] Checking genawaiter-macro v0.99.1 [INFO] [stderr] Checking strum v0.21.0 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Checking lexical v5.2.2 [INFO] [stderr] Checking utf8-cstr v0.1.6 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Compiling markup5ever v0.11.0 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking diagnostic v0.1.0 (https://github.com/oberien/diagnostic?rev=889fb5da592d746b47b0fafca6bc7e71c4e2a55e#889fb5da) [INFO] [stderr] Compiling darling_core v0.20.3 [INFO] [stderr] Compiling syn-mid v0.5.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Compiling serde_derive v1.0.218 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.65 [INFO] [stderr] Compiling clap_derive v4.5.28 [INFO] [stderr] Compiling foreign-types-macros v0.2.3 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling html5ever v0.26.0 [INFO] [stderr] Compiling strum_macros v0.21.1 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling rebo_derive v0.1.0 (https://github.com/oberien/rebo?rev=e098e2ab5e279783400a5e86b194934381e92c69#e098e2ab) [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tokio v1.41.0 [INFO] [stderr] Checking foreign-types v0.5.0 [INFO] [stderr] Checking systemd v0.10.0 [INFO] [stderr] Compiling genawaiter-proc-macro v0.99.1 [INFO] [stderr] Compiling darling_macro v0.20.3 [INFO] [stderr] Checking genawaiter v0.99.1 [INFO] [stderr] Compiling darling v0.20.3 [INFO] [stderr] Compiling serde_with_macros v3.1.0 [INFO] [stderr] Checking clap v4.5.31 [INFO] [stderr] Checking serde v1.0.218 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking indexmap v1.9.3 [INFO] [stderr] Checking string_cache v0.8.7 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_edit v0.19.14 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking petgraph v0.6.3 [INFO] [stderr] Checking serde_with v3.1.0 [INFO] [stderr] Checking rumqttc v0.24.0 [INFO] [stderr] Checking h2 v0.3.20 [INFO] [stderr] Checking tokio-postgres v0.7.8 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking xml5ever v0.17.0 [INFO] [stderr] Checking markup5ever_rcdom v0.2.0 [INFO] [stderr] Checking toml v0.7.6 [INFO] [stderr] Checking rebo v0.1.0 (https://github.com/oberien/rebo?rev=e098e2ab5e279783400a5e86b194934381e92c69#e098e2ab) [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.18 [INFO] [stderr] Checking iot2db v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `aggregate` is never read [INFO] [stdout] --> src/config.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 133 | pub struct Value { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 143 | pub aggregate: Aggregate, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Value` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:218:1 [INFO] [stdout] | [INFO] [stdout] 218 | / impl Default for Aggregate { [INFO] [stdout] 219 | | fn default() -> Self { [INFO] [stdout] 220 | | Aggregate::None [INFO] [stdout] 221 | | } [INFO] [stdout] 222 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 152 + #[derive(Default)] [INFO] [stdout] 153 | pub enum Aggregate { [INFO] [stdout] 154 ~ #[default] [INFO] [stdout] 155 ~ None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `Vec` [INFO] [stdout] --> src/frontend/homematic_ccu3.rs:86:84 [INFO] [stdout] | [INFO] [stdout] 86 | for (i, channel) in device["channels"].as_array_mut().unwrap().into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `aggregate` is never read [INFO] [stdout] --> src/config.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 133 | pub struct Value { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 143 | pub aggregate: Aggregate, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Value` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/frontend/mqtt.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | receivers: Arc)>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/frontend/mqtt.rs:25:24 [INFO] [stdout] | [INFO] [stdout] 25 | let receivers: Arc)>>> = Arc::new(StdMutex::new(Vec::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/frontend/mqtt.rs:73:63 [INFO] [stdout] | [INFO] [stdout] 73 | let receiver = receivers.iter().find(|(regex, _)| regex.as_str() == &pattern); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `pattern` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/mod.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | if !old.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `old.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/data.rs:27:51 [INFO] [stdout] | [INFO] [stdout] 27 | (None, Some(DirectValues::All(_))) if json_pointer == "" => return None, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `json_pointer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/data.rs:29:55 [INFO] [stdout] | [INFO] [stdout] 29 | ... (None, Some(DirectValues::Keys(keys))) if keys.iter().any(|k| *k == json_pointer) => (json_pointer_to_key(&json_pointer), None... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `keys.contains(&json_pointer)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/data.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 47 | / let val = match postprocess.clone() { [INFO] [stdout] 48 | | Some(postprocess) => run_rebo(postprocess, val), [INFO] [stdout] 49 | | None => val, [INFO] [stdout] 50 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 51 | val [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 47 ~ [INFO] [stdout] 48 ~ match postprocess.clone() { [INFO] [stdout] 49 + Some(postprocess) => run_rebo(postprocess, val), [INFO] [stdout] 50 + None => val, [INFO] [stdout] 51 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/data.rs:120:38 [INFO] [stdout] | [INFO] [stdout] 120 | fn json_pointer_to_key(json_pointer: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 120 - fn json_pointer_to_key(json_pointer: &String) -> String { [INFO] [stdout] 120 + fn json_pointer_to_key(json_pointer: &str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/backend/postgres.rs:80:43 [INFO] [stdout] | [INFO] [stdout] 80 | let escaped_table = escape_identifier(&table); [INFO] [stdout] | ^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/backend/postgres.rs:93:43 [INFO] [stdout] | [INFO] [stdout] 93 | let escaped_table = escape_identifier(&table); [INFO] [stdout] | ^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:218:1 [INFO] [stdout] | [INFO] [stdout] 218 | / impl Default for Aggregate { [INFO] [stdout] 219 | | fn default() -> Self { [INFO] [stdout] 220 | | Aggregate::None [INFO] [stdout] 221 | | } [INFO] [stdout] 222 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 152 + #[derive(Default)] [INFO] [stdout] 153 | pub enum Aggregate { [INFO] [stdout] 154 ~ #[default] [INFO] [stdout] 155 ~ None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `Vec` [INFO] [stdout] --> src/frontend/homematic_ccu3.rs:86:84 [INFO] [stdout] | [INFO] [stdout] 86 | for (i, channel) in device["channels"].as_array_mut().unwrap().into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/frontend/mqtt.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | receivers: Arc)>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/frontend/mqtt.rs:25:24 [INFO] [stdout] | [INFO] [stdout] 25 | let receivers: Arc)>>> = Arc::new(StdMutex::new(Vec::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/frontend/mqtt.rs:73:63 [INFO] [stdout] | [INFO] [stdout] 73 | let receiver = receivers.iter().find(|(regex, _)| regex.as_str() == &pattern); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `pattern` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/mod.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | if !old.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `old.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/data.rs:27:51 [INFO] [stdout] | [INFO] [stdout] 27 | (None, Some(DirectValues::All(_))) if json_pointer == "" => return None, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `json_pointer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/data.rs:29:55 [INFO] [stdout] | [INFO] [stdout] 29 | ... (None, Some(DirectValues::Keys(keys))) if keys.iter().any(|k| *k == json_pointer) => (json_pointer_to_key(&json_pointer), None... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `keys.contains(&json_pointer)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/data.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 47 | / let val = match postprocess.clone() { [INFO] [stdout] 48 | | Some(postprocess) => run_rebo(postprocess, val), [INFO] [stdout] 49 | | None => val, [INFO] [stdout] 50 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 51 | val [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 47 ~ [INFO] [stdout] 48 ~ match postprocess.clone() { [INFO] [stdout] 49 + Some(postprocess) => run_rebo(postprocess, val), [INFO] [stdout] 50 + None => val, [INFO] [stdout] 51 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/data.rs:120:38 [INFO] [stdout] | [INFO] [stdout] 120 | fn json_pointer_to_key(json_pointer: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 120 - fn json_pointer_to_key(json_pointer: &String) -> String { [INFO] [stdout] 120 + fn json_pointer_to_key(json_pointer: &str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/backend/postgres.rs:80:43 [INFO] [stdout] | [INFO] [stdout] 80 | let escaped_table = escape_identifier(&table); [INFO] [stdout] | ^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/backend/postgres.rs:93:43 [INFO] [stdout] | [INFO] [stdout] 93 | let escaped_table = escape_identifier(&table); [INFO] [stdout] | ^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 40.36s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: openssl v0.10.55 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "c57570ab36e3ea4899c2c1e895f25750c5a8afb23bfa0ae7f08868b1b552e25f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c57570ab36e3ea4899c2c1e895f25750c5a8afb23bfa0ae7f08868b1b552e25f", kill_on_drop: false }` [INFO] [stdout] c57570ab36e3ea4899c2c1e895f25750c5a8afb23bfa0ae7f08868b1b552e25f