[INFO] cloning repository https://github.com/nwilkens/triton-cn-agent [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nwilkens/triton-cn-agent" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnwilkens%2Ftriton-cn-agent", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnwilkens%2Ftriton-cn-agent'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ef6d4a7d73f6e036967deafc7c83c91ea249c0ee [INFO] linting nwilkens/triton-cn-agent against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnwilkens%2Ftriton-cn-agent" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-5-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/nwilkens/triton-cn-agent [INFO] finished tweaking git repo https://github.com/nwilkens/triton-cn-agent [INFO] tweaked toml for git repo https://github.com/nwilkens/triton-cn-agent written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/nwilkens/triton-cn-agent on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/nwilkens/triton-cn-agent already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae2a27743ab5657856d89c2900ac75b4bb6243eb220c590287a26de4109bea6b [INFO] running `Command { std: "docker" "start" "-a" "ae2a27743ab5657856d89c2900ac75b4bb6243eb220c590287a26de4109bea6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae2a27743ab5657856d89c2900ac75b4bb6243eb220c590287a26de4109bea6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae2a27743ab5657856d89c2900ac75b4bb6243eb220c590287a26de4109bea6b", kill_on_drop: false }` [INFO] [stdout] ae2a27743ab5657856d89c2900ac75b4bb6243eb220c590287a26de4109bea6b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e133478e0bcfd67eb4c6698803c289dd9986e11ce61b3fcc2cda56cf3be9f90a [INFO] running `Command { std: "docker" "start" "-a" "e133478e0bcfd67eb4c6698803c289dd9986e11ce61b3fcc2cda56cf3be9f90a", kill_on_drop: false }` [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling rustls v0.23.32 [INFO] [stderr] Checking webpki-roots v1.0.2 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Checking filetime v0.2.26 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking regex-automata v0.4.11 [INFO] [stderr] Checking rustls-webpki v0.103.7 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking regex v1.11.3 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling clap_derive v4.5.47 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking clap v4.5.48 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking cn-agent-core v2.0.0 (/opt/rustwide/workdir/cn-agent-core) [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stdout] warning: unused import: `AgentError` [INFO] [stdout] --> cn-agent-core/src/task.rs:7:20 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::error::{AgentError, Result}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AgentError` [INFO] [stdout] --> cn-agent-core/src/task.rs:7:20 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::error::{AgentError, Result}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking cn-agent-tasks v2.0.0 (/opt/rustwide/workdir/cn-agent-tasks) [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Checking reqwest v0.12.23 [INFO] [stderr] Checking cn-agent-backends v2.0.0 (/opt/rustwide/workdir/cn-agent-backends) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-backends/src/smartos/kstat.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 60 | .args(&["-p", kstat_key]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `["-p", kstat_key]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `path_to_check` [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_copy.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | let path_to_check = if params.destination.contains(':') { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_path_to_check` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-backends/src/smartos/vmadm.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 56 | .args(&["lookup", "-j"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `["lookup", "-j"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-backends/src/smartos/vmadm.rs:176:15 [INFO] [stdout] | [INFO] [stdout] 176 | .args(&["get", &uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-backends/src/smartos/kstat.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 60 | .args(&["-p", kstat_key]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `["-p", kstat_key]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-backends/src/smartos/zfs.rs:27:15 [INFO] [stdout] | [INFO] [stdout] 27 | .args(&["list", "-Hp"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `["list", "-Hp"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-backends/src/smartos/zfs.rs:114:15 [INFO] [stdout] | [INFO] [stdout] 114 | .args(&["-k"]) [INFO] [stdout] | ^^^^^^^ help: change this to: `["-k"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-backends/src/smartos/vmadm.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 56 | .args(&["lookup", "-j"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `["lookup", "-j"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-backends/src/smartos/vmadm.rs:176:15 [INFO] [stdout] | [INFO] [stdout] 176 | .args(&["get", &uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-backends/src/smartos/zfs.rs:27:15 [INFO] [stdout] | [INFO] [stdout] 27 | .args(&["list", "-Hp"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `["list", "-Hp"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-backends/src/smartos/zfs.rs:114:15 [INFO] [stdout] | [INFO] [stdout] 114 | .args(&["-k"]) [INFO] [stdout] | ^^^^^^^ help: change this to: `["-k"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `path_to_check` [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_copy.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | let path_to_check = if params.destination.contains(':') { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_path_to_check` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `uuid` is never read [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_create.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 99 | struct VmInfo { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 100 | uuid: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VmInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `uuid` is never read [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kill.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 80 | struct VmState { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 81 | uuid: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VmState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_boot.rs:145:19 [INFO] [stdout] | [INFO] [stdout] 145 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_boot.rs:183:19 [INFO] [stdout] | [INFO] [stdout] 183 | .args(&["start", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["start", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_reboot.rs:201:19 [INFO] [stdout] | [INFO] [stdout] 201 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_shutdown.rs:187:19 [INFO] [stdout] | [INFO] [stdout] 187 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_create.rs:168:17 [INFO] [stdout] | [INFO] [stdout] 168 | / if !obj.contains_key("disks") { [INFO] [stdout] 169 | | return Err(MachineCreateError::MissingParameter("disks".to_string())); [INFO] [stdout] 170 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 167 ~ "kvm" | "bhyve" [INFO] [stdout] 168 ~ if !obj.contains_key("disks") => { [INFO] [stdout] 169 | return Err(MachineCreateError::MissingParameter("disks".to_string())); [INFO] [stdout] 170 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_create.rs:174:17 [INFO] [stdout] | [INFO] [stdout] 174 | / if !obj.contains_key("quota") && !obj.contains_key("image_uuid") { [INFO] [stdout] 175 | | return Err(MachineCreateError::MissingParameter("quota or image_uuid".to_string())); [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ "joyent" | "joyent-minimal" | "lx" [INFO] [stdout] 173 | // Zones should have quota or image_uuid [INFO] [stdout] 174 ~ if !obj.contains_key("quota") && !obj.contains_key("image_uuid") => { [INFO] [stdout] 175 | return Err(MachineCreateError::MissingParameter("quota or image_uuid".to_string())); [INFO] [stdout] 176 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_create.rs:226:19 [INFO] [stdout] | [INFO] [stdout] 226 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_destroy.rs:130:19 [INFO] [stdout] | [INFO] [stdout] 130 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_destroy.rs:170:19 [INFO] [stdout] | [INFO] [stdout] 170 | .args(&["delete", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["delete", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_destroy.rs:188:19 [INFO] [stdout] | [INFO] [stdout] 188 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_reprovision.rs:161:19 [INFO] [stdout] | [INFO] [stdout] 161 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_reprovision.rs:210:19 [INFO] [stdout] | [INFO] [stdout] 210 | .args(&["reprovision", &vm_uuid.to_string(), &image_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["reprovision", &vm_uuid.to_string(), &image_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_update.rs:127:19 [INFO] [stdout] | [INFO] [stdout] 127 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_update.rs:172:19 [INFO] [stdout] | [INFO] [stdout] 172 | .args(&["update", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["update", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_update.rs:198:19 [INFO] [stdout] | [INFO] [stdout] 198 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kill.rs:116:19 [INFO] [stdout] | [INFO] [stdout] 116 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kill.rs:136:19 [INFO] [stdout] | [INFO] [stdout] 136 | .args(&["kill", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["kill", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kill.rs:153:19 [INFO] [stdout] | [INFO] [stdout] 153 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_snapshot.rs:92:19 [INFO] [stdout] | [INFO] [stdout] 92 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_snapshot.rs:112:19 [INFO] [stdout] | [INFO] [stdout] 112 | .args(&["create-snapshot", &vm_uuid.to_string(), snapshot_name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["create-snapshot", &vm_uuid.to_string(), snapshot_name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_rollback_snapshot.rs:72:19 [INFO] [stdout] | [INFO] [stdout] 72 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_rollback_snapshot.rs:92:19 [INFO] [stdout] | [INFO] [stdout] 92 | .args(&["rollback-snapshot", &vm_uuid.to_string(), snapshot_name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rollback-snapshot", &vm_uuid.to_string(), snapshot_name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_delete_snapshot.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 69 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_delete_snapshot.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | .args(&["delete-snapshot", &vm_uuid.to_string(), snapshot_name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["delete-snapshot", &vm_uuid.to_string(), snapshot_name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_add_nics.rs:73:19 [INFO] [stdout] | [INFO] [stdout] 73 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_add_nics.rs:113:19 [INFO] [stdout] | [INFO] [stdout] 113 | .args(&["update", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["update", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_update_nics.rs:73:19 [INFO] [stdout] | [INFO] [stdout] 73 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_update_nics.rs:100:16 [INFO] [stdout] | [INFO] [stdout] 100 | if !nic.get("mac").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `nic.get("mac").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_update_nics.rs:116:19 [INFO] [stdout] | [INFO] [stdout] 116 | .args(&["update", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["update", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_remove_nics.rs:73:19 [INFO] [stdout] | [INFO] [stdout] 73 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_remove_nics.rs:107:19 [INFO] [stdout] | [INFO] [stdout] 107 | .args(&["update", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["update", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_add_disk.rs:81:19 [INFO] [stdout] | [INFO] [stdout] 81 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_add_disk.rs:130:19 [INFO] [stdout] | [INFO] [stdout] 130 | .args(&["update", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["update", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_resize_disk.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 75 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_resize_disk.rs:112:19 [INFO] [stdout] | [INFO] [stdout] 112 | .args(&["update", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["update", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/server_ensure_image.rs:83:19 [INFO] [stdout] | [INFO] [stdout] 83 | .args(&["get", &image_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &image_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/server_ensure_image.rs:95:19 [INFO] [stdout] | [INFO] [stdout] 95 | .args(&["import", &image_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["import", &image_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/server_ensure_image.rs:112:19 [INFO] [stdout] | [INFO] [stdout] 112 | .args(&["get", &image_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &image_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> cn-agent-tasks/src/tasks/server_overprovision_ratio.rs:55:16 [INFO] [stdout] | [INFO] [stdout] 55 | if cpu_ratio < 1.0 || cpu_ratio > 10.0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1.0..=10.0).contains(&cpu_ratio)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> cn-agent-tasks/src/tasks/server_overprovision_ratio.rs:64:16 [INFO] [stdout] | [INFO] [stdout] 64 | if ram_ratio < 1.0 || ram_ratio > 10.0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1.0..=10.0).contains(&ram_ratio)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_build.rs:248:19 [INFO] [stdout] | [INFO] [stdout] 248 | .args(&["inspect", "--format", "{{.Size}}", image_id]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["inspect", "--format", "{{.Size}}", image_id]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_exec.rs:120:19 [INFO] [stdout] | [INFO] [stdout] 120 | .args(&["inspect", "--format", "{{.State.Running}}", container_id]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["inspect", "--format", "{{.State.Running}}", container_id]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_stats.rs:57:19 [INFO] [stdout] | [INFO] [stdout] 57 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 58 | | "stats", [INFO] [stdout] 59 | | "--no-stream", [INFO] [stdout] 60 | | "--format", [INFO] [stdout] 61 | | "{{json .}}", [INFO] [stdout] 62 | | ¶ms.container_id, [INFO] [stdout] 63 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 57 ~ .args([ [INFO] [stdout] 58 + "stats", [INFO] [stdout] 59 + "--no-stream", [INFO] [stdout] 60 + "--format", [INFO] [stdout] 61 + "{{json .}}", [INFO] [stdout] 62 + ¶ms.container_id, [INFO] [stdout] 63 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_copy.rs:74:19 [INFO] [stdout] | [INFO] [stdout] 74 | .args(&["cp", ¶ms.source, ¶ms.destination]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["cp", ¶ms.source, ¶ms.destination]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_copy.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | / let path_to_check = if params.destination.contains(':') { [INFO] [stdout] 95 | | // Container path - use docker exec [INFO] [stdout] 96 | | let parts: Vec<&str> = params.destination.split(':').collect(); [INFO] [stdout] 97 | | if parts.len() != 2 { [INFO] [stdout] ... | [INFO] [stdout] 132 | | return Ok(0); [INFO] [stdout] 133 | | }; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 94 - let path_to_check = if params.destination.contains(':') { [INFO] [stdout] 94 + if params.destination.contains(':') { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_copy.rs:102:23 [INFO] [stdout] | [INFO] [stdout] 102 | .args(&["exec", parts[0], "du", "-sb", parts[1]]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["exec", parts[0], "du", "-sb", parts[1]]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_copy.rs:119:23 [INFO] [stdout] | [INFO] [stdout] 119 | .args(&["-sb", ¶ms.destination]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-sb", ¶ms.destination]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/zfs_create.rs:103:19 [INFO] [stdout] | [INFO] [stdout] 103 | .args(&["get", "-H", "-o", "property,value", "all", dataset]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", "-H", "-o", "property,value", "all", dataset]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/zfs_get.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | .args(&["get", "-H", "-o", "property,value", &properties_arg, ¶ms.dataset]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", "-H", "-o", "property,value", &properties_arg, ¶ms.dataset]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/image_get.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 43 | .args(&["get", ¶ms.image_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", ¶ms.image_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/image_create.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 47 | .args(&["create", ¶ms.vm_uuid.to_string(), "-m", &manifest_json]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["create", ¶ms.vm_uuid.to_string(), "-m", &manifest_json]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/image_import.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 53 | cmd.arg(¶ms.image_uuid.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `params.image_uuid.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/agent_uninstall.rs:42:19 [INFO] [stdout] | [INFO] [stdout] 42 | .args(&["disable", "-s", &format!("svc:/smartdc/agent/{}", params.agent_name)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["disable", "-s", &format!("svc:/smartdc/agent/{}", params.agent_name)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/agent_uninstall.rs:55:19 [INFO] [stdout] | [INFO] [stdout] 55 | .args(&["uninstall", ¶ms.agent_name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["uninstall", ¶ms.agent_name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/agent_refresh.rs:44:19 [INFO] [stdout] | [INFO] [stdout] 44 | .args(&["refresh", &service_name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["refresh", &service_name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_screenshot.rs:50:19 [INFO] [stdout] | [INFO] [stdout] 50 | .args(&["screenshot", ¶ms.vm_uuid.to_string(), &screenshot_path]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["screenshot", ¶ms.vm_uuid.to_string(), &screenshot_path]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_screenshot.rs:76:19 [INFO] [stdout] | [INFO] [stdout] 76 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kvmdebug.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 63 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kvmdebug.rs:86:19 [INFO] [stdout] | [INFO] [stdout] 86 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kvmdebug.rs:105:19 [INFO] [stdout] | [INFO] [stdout] 105 | .args(&["-f", &format!("qemu.*{}", vm_uuid)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-f", &format!("qemu.*{}", vm_uuid)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kvmdebug.rs:123:19 [INFO] [stdout] | [INFO] [stdout] 123 | .args(&["-o", "pid,vsz,rss,time,args", "-p", &pid]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-o", "pid,vsz,rss,time,args", "-p", &pid]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_proc.rs:55:19 [INFO] [stdout] | [INFO] [stdout] 55 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_proc.rs:80:19 [INFO] [stdout] | [INFO] [stdout] 80 | .args(&["-Z", "-o", "zone,pid,user,comm,args"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-Z", "-o", "zone,pid,user,comm,args"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `uuid` is never read [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_create.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 99 | struct VmInfo { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 100 | uuid: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VmInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `uuid` is never read [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kill.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 80 | struct VmState { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 81 | uuid: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VmState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_migration_sync.rs:43:1 [INFO] [stdout] | [INFO] [stdout] 43 | / impl Default for MigrationAction { [INFO] [stdout] 44 | | fn default() -> Self { [INFO] [stdout] 45 | | MigrationAction::Sync [INFO] [stdout] 46 | | } [INFO] [stdout] 47 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 36 + #[derive(Default)] [INFO] [stdout] 37 | pub enum MigrationAction { [INFO] [stdout] 38 | Begin, [INFO] [stdout] 39 ~ #[default] [INFO] [stdout] 40 ~ Sync, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_migration_sync.rs:71:19 [INFO] [stdout] | [INFO] [stdout] 71 | .args(&["migrate", action_str, ¶ms.vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["migrate", action_str, ¶ms.vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_migration_sync.rs:99:19 [INFO] [stdout] | [INFO] [stdout] 99 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_boot.rs:145:19 [INFO] [stdout] | [INFO] [stdout] 145 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_boot.rs:183:19 [INFO] [stdout] | [INFO] [stdout] 183 | .args(&["start", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["start", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_reboot.rs:201:19 [INFO] [stdout] | [INFO] [stdout] 201 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_reboot.rs:343:9 [INFO] [stdout] | [INFO] [stdout] 343 | assert_eq!(parsed.force, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 343 - assert_eq!(parsed.force, false); [INFO] [stdout] 343 + assert!(!parsed.force); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_reboot.rs:351:9 [INFO] [stdout] | [INFO] [stdout] 351 | assert_eq!(params.force, false); // default force [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 351 - assert_eq!(params.force, false); // default force [INFO] [stdout] 351 + assert!(!params.force); // default force [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_shutdown.rs:187:19 [INFO] [stdout] | [INFO] [stdout] 187 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_shutdown.rs:317:9 [INFO] [stdout] | [INFO] [stdout] 317 | assert_eq!(parsed.force, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 317 - assert_eq!(parsed.force, false); [INFO] [stdout] 317 + assert!(!parsed.force); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_shutdown.rs:325:9 [INFO] [stdout] | [INFO] [stdout] 325 | assert_eq!(params.force, false); // default force [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 325 - assert_eq!(params.force, false); // default force [INFO] [stdout] 325 + assert!(!params.force); // default force [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_create.rs:168:17 [INFO] [stdout] | [INFO] [stdout] 168 | / if !obj.contains_key("disks") { [INFO] [stdout] 169 | | return Err(MachineCreateError::MissingParameter("disks".to_string())); [INFO] [stdout] 170 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 167 ~ "kvm" | "bhyve" [INFO] [stdout] 168 ~ if !obj.contains_key("disks") => { [INFO] [stdout] 169 | return Err(MachineCreateError::MissingParameter("disks".to_string())); [INFO] [stdout] 170 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_create.rs:174:17 [INFO] [stdout] | [INFO] [stdout] 174 | / if !obj.contains_key("quota") && !obj.contains_key("image_uuid") { [INFO] [stdout] 175 | | return Err(MachineCreateError::MissingParameter("quota or image_uuid".to_string())); [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ "joyent" | "joyent-minimal" | "lx" [INFO] [stdout] 173 | // Zones should have quota or image_uuid [INFO] [stdout] 174 ~ if !obj.contains_key("quota") && !obj.contains_key("image_uuid") => { [INFO] [stdout] 175 | return Err(MachineCreateError::MissingParameter("quota or image_uuid".to_string())); [INFO] [stdout] 176 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression can be written more simply using `.retain()` [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_list.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | / vms = vms [INFO] [stdout] 72 | | .into_iter() [INFO] [stdout] 73 | | .filter(|vm| Self::apply_filters(vm, ¶ms)) [INFO] [stdout] 74 | | .collect(); [INFO] [stdout] | |__________________________^ help: consider calling `.retain()` instead: `vms.retain(|vm| Self::apply_filters(vm, ¶ms))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain [INFO] [stdout] = note: `#[warn(clippy::manual_retain)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_create.rs:226:19 [INFO] [stdout] | [INFO] [stdout] 226 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_destroy.rs:130:19 [INFO] [stdout] | [INFO] [stdout] 130 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_destroy.rs:170:19 [INFO] [stdout] | [INFO] [stdout] 170 | .args(&["delete", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["delete", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_destroy.rs:188:19 [INFO] [stdout] | [INFO] [stdout] 188 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_reprovision.rs:161:19 [INFO] [stdout] | [INFO] [stdout] 161 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_reprovision.rs:210:19 [INFO] [stdout] | [INFO] [stdout] 210 | .args(&["reprovision", &vm_uuid.to_string(), &image_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["reprovision", &vm_uuid.to_string(), &image_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> cn-agent-tasks/src/tasks/cleanup_stale_locks.rs:79:36 [INFO] [stdout] | [INFO] [stdout] 79 | if !path.is_file() || !path.extension().map_or(false, |ext| ext == "lock") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 79 - if !path.is_file() || !path.extension().map_or(false, |ext| ext == "lock") { [INFO] [stdout] 79 + if !path.is_file() || !path.extension().is_some_and(|ext| ext == "lock") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_update.rs:127:19 [INFO] [stdout] | [INFO] [stdout] 127 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_update.rs:172:19 [INFO] [stdout] | [INFO] [stdout] 172 | .args(&["update", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["update", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_update.rs:198:19 [INFO] [stdout] | [INFO] [stdout] 198 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kill.rs:116:19 [INFO] [stdout] | [INFO] [stdout] 116 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kill.rs:136:19 [INFO] [stdout] | [INFO] [stdout] 136 | .args(&["kill", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["kill", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kill.rs:153:19 [INFO] [stdout] | [INFO] [stdout] 153 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_snapshot.rs:92:19 [INFO] [stdout] | [INFO] [stdout] 92 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_snapshot.rs:112:19 [INFO] [stdout] | [INFO] [stdout] 112 | .args(&["create-snapshot", &vm_uuid.to_string(), snapshot_name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["create-snapshot", &vm_uuid.to_string(), snapshot_name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_rollback_snapshot.rs:72:19 [INFO] [stdout] | [INFO] [stdout] 72 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_rollback_snapshot.rs:92:19 [INFO] [stdout] | [INFO] [stdout] 92 | .args(&["rollback-snapshot", &vm_uuid.to_string(), snapshot_name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["rollback-snapshot", &vm_uuid.to_string(), snapshot_name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_delete_snapshot.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 69 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_delete_snapshot.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | .args(&["delete-snapshot", &vm_uuid.to_string(), snapshot_name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["delete-snapshot", &vm_uuid.to_string(), snapshot_name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_add_nics.rs:73:19 [INFO] [stdout] | [INFO] [stdout] 73 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_add_nics.rs:113:19 [INFO] [stdout] | [INFO] [stdout] 113 | .args(&["update", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["update", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_update_nics.rs:73:19 [INFO] [stdout] | [INFO] [stdout] 73 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_update_nics.rs:100:16 [INFO] [stdout] | [INFO] [stdout] 100 | if !nic.get("mac").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `nic.get("mac").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_update_nics.rs:116:19 [INFO] [stdout] | [INFO] [stdout] 116 | .args(&["update", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["update", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_remove_nics.rs:73:19 [INFO] [stdout] | [INFO] [stdout] 73 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_remove_nics.rs:107:19 [INFO] [stdout] | [INFO] [stdout] 107 | .args(&["update", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["update", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_add_disk.rs:81:19 [INFO] [stdout] | [INFO] [stdout] 81 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_add_disk.rs:130:19 [INFO] [stdout] | [INFO] [stdout] 130 | .args(&["update", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["update", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_resize_disk.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 75 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_resize_disk.rs:112:19 [INFO] [stdout] | [INFO] [stdout] 112 | .args(&["update", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["update", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/server_ensure_image.rs:83:19 [INFO] [stdout] | [INFO] [stdout] 83 | .args(&["get", &image_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &image_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/server_ensure_image.rs:95:19 [INFO] [stdout] | [INFO] [stdout] 95 | .args(&["import", &image_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["import", &image_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/server_ensure_image.rs:112:19 [INFO] [stdout] | [INFO] [stdout] 112 | .args(&["get", &image_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &image_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> cn-agent-tasks/src/tasks/server_overprovision_ratio.rs:55:16 [INFO] [stdout] | [INFO] [stdout] 55 | if cpu_ratio < 1.0 || cpu_ratio > 10.0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1.0..=10.0).contains(&cpu_ratio)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> cn-agent-tasks/src/tasks/server_overprovision_ratio.rs:64:16 [INFO] [stdout] | [INFO] [stdout] 64 | if ram_ratio < 1.0 || ram_ratio > 10.0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1.0..=10.0).contains(&ram_ratio)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_build.rs:248:19 [INFO] [stdout] | [INFO] [stdout] 248 | .args(&["inspect", "--format", "{{.Size}}", image_id]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["inspect", "--format", "{{.Size}}", image_id]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_build.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 333 | assert_eq!(params.use_cache, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 333 - assert_eq!(params.use_cache, true); [INFO] [stdout] 333 + assert!(params.use_cache); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_build.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 334 | assert_eq!(params.rm, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 334 - assert_eq!(params.rm, true); [INFO] [stdout] 334 + assert!(params.rm); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_exec.rs:120:19 [INFO] [stdout] | [INFO] [stdout] 120 | .args(&["inspect", "--format", "{{.State.Running}}", container_id]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["inspect", "--format", "{{.State.Running}}", container_id]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_stats.rs:57:19 [INFO] [stdout] | [INFO] [stdout] 57 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 58 | | "stats", [INFO] [stdout] 59 | | "--no-stream", [INFO] [stdout] 60 | | "--format", [INFO] [stdout] 61 | | "{{json .}}", [INFO] [stdout] 62 | | ¶ms.container_id, [INFO] [stdout] 63 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 57 ~ .args([ [INFO] [stdout] 58 + "stats", [INFO] [stdout] 59 + "--no-stream", [INFO] [stdout] 60 + "--format", [INFO] [stdout] 61 + "{{json .}}", [INFO] [stdout] 62 + ¶ms.container_id, [INFO] [stdout] 63 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_copy.rs:74:19 [INFO] [stdout] | [INFO] [stdout] 74 | .args(&["cp", ¶ms.source, ¶ms.destination]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["cp", ¶ms.source, ¶ms.destination]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_copy.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | / let path_to_check = if params.destination.contains(':') { [INFO] [stdout] 95 | | // Container path - use docker exec [INFO] [stdout] 96 | | let parts: Vec<&str> = params.destination.split(':').collect(); [INFO] [stdout] 97 | | if parts.len() != 2 { [INFO] [stdout] ... | [INFO] [stdout] 132 | | return Ok(0); [INFO] [stdout] 133 | | }; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 94 - let path_to_check = if params.destination.contains(':') { [INFO] [stdout] 94 + if params.destination.contains(':') { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_copy.rs:102:23 [INFO] [stdout] | [INFO] [stdout] 102 | .args(&["exec", parts[0], "du", "-sb", parts[1]]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["exec", parts[0], "du", "-sb", parts[1]]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/docker_copy.rs:119:23 [INFO] [stdout] | [INFO] [stdout] 119 | .args(&["-sb", ¶ms.destination]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-sb", ¶ms.destination]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/zfs_create.rs:103:19 [INFO] [stdout] | [INFO] [stdout] 103 | .args(&["get", "-H", "-o", "property,value", "all", dataset]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", "-H", "-o", "property,value", "all", dataset]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> cn-agent-tasks/src/tasks/zfs_create.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | assert_eq!(parsed.create_parents, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 174 - assert_eq!(parsed.create_parents, true); [INFO] [stdout] 174 + assert!(parsed.create_parents); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/zfs_get.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | .args(&["get", "-H", "-o", "property,value", &properties_arg, ¶ms.dataset]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", "-H", "-o", "property,value", &properties_arg, ¶ms.dataset]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/image_get.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 43 | .args(&["get", ¶ms.image_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", ¶ms.image_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/image_create.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 47 | .args(&["create", ¶ms.vm_uuid.to_string(), "-m", &manifest_json]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["create", ¶ms.vm_uuid.to_string(), "-m", &manifest_json]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/image_import.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 53 | cmd.arg(¶ms.image_uuid.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `params.image_uuid.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/agent_uninstall.rs:42:19 [INFO] [stdout] | [INFO] [stdout] 42 | .args(&["disable", "-s", &format!("svc:/smartdc/agent/{}", params.agent_name)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["disable", "-s", &format!("svc:/smartdc/agent/{}", params.agent_name)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/agent_uninstall.rs:55:19 [INFO] [stdout] | [INFO] [stdout] 55 | .args(&["uninstall", ¶ms.agent_name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["uninstall", ¶ms.agent_name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/agent_refresh.rs:44:19 [INFO] [stdout] | [INFO] [stdout] 44 | .args(&["refresh", &service_name]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["refresh", &service_name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_screenshot.rs:50:19 [INFO] [stdout] | [INFO] [stdout] 50 | .args(&["screenshot", ¶ms.vm_uuid.to_string(), &screenshot_path]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["screenshot", ¶ms.vm_uuid.to_string(), &screenshot_path]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_screenshot.rs:76:19 [INFO] [stdout] | [INFO] [stdout] 76 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kvmdebug.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 63 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kvmdebug.rs:86:19 [INFO] [stdout] | [INFO] [stdout] 86 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kvmdebug.rs:105:19 [INFO] [stdout] | [INFO] [stdout] 105 | .args(&["-f", &format!("qemu.*{}", vm_uuid)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-f", &format!("qemu.*{}", vm_uuid)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_kvmdebug.rs:123:19 [INFO] [stdout] | [INFO] [stdout] 123 | .args(&["-o", "pid,vsz,rss,time,args", "-p", &pid]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-o", "pid,vsz,rss,time,args", "-p", &pid]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_proc.rs:55:19 [INFO] [stdout] | [INFO] [stdout] 55 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_proc.rs:80:19 [INFO] [stdout] | [INFO] [stdout] 80 | .args(&["-Z", "-o", "zone,pid,user,comm,args"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-Z", "-o", "zone,pid,user,comm,args"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_migration_sync.rs:43:1 [INFO] [stdout] | [INFO] [stdout] 43 | / impl Default for MigrationAction { [INFO] [stdout] 44 | | fn default() -> Self { [INFO] [stdout] 45 | | MigrationAction::Sync [INFO] [stdout] 46 | | } [INFO] [stdout] 47 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 36 + #[derive(Default)] [INFO] [stdout] 37 | pub enum MigrationAction { [INFO] [stdout] 38 | Begin, [INFO] [stdout] 39 ~ #[default] [INFO] [stdout] 40 ~ Sync, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_migration_sync.rs:71:19 [INFO] [stdout] | [INFO] [stdout] 71 | .args(&["migrate", action_str, ¶ms.vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["migrate", action_str, ¶ms.vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_migration_sync.rs:99:19 [INFO] [stdout] | [INFO] [stdout] 99 | .args(&["get", &vm_uuid.to_string()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["get", &vm_uuid.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression can be written more simply using `.retain()` [INFO] [stdout] --> cn-agent-tasks/src/tasks/machine_list.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | / vms = vms [INFO] [stdout] 72 | | .into_iter() [INFO] [stdout] 73 | | .filter(|vm| Self::apply_filters(vm, ¶ms)) [INFO] [stdout] 74 | | .collect(); [INFO] [stdout] | |__________________________^ help: consider calling `.retain()` instead: `vms.retain(|vm| Self::apply_filters(vm, ¶ms))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_retain [INFO] [stdout] = note: `#[warn(clippy::manual_retain)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> cn-agent-tasks/src/tasks/cleanup_stale_locks.rs:79:36 [INFO] [stdout] | [INFO] [stdout] 79 | if !path.is_file() || !path.extension().map_or(false, |ext| ext == "lock") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 79 - if !path.is_file() || !path.extension().map_or(false, |ext| ext == "lock") { [INFO] [stdout] 79 + if !path.is_file() || !path.extension().is_some_and(|ext| ext == "lock") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking cn-agent v2.0.0 (/opt/rustwide/workdir/cn-agent) [INFO] [stdout] warning: unused imports: `HeartbeatRequest`, `HeartbeatResponse`, and `RegistrationResponse` [INFO] [stdout] --> cn-agent/src/cnapi/client.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | HeartbeatRequest, HeartbeatResponse, RegistrationRequest, RegistrationResponse, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CnapiError` and `Result` [INFO] [stdout] --> cn-agent/src/cnapi/mod.rs:13:44 [INFO] [stdout] | [INFO] [stdout] 13 | pub use client::{CnapiClient, CnapiConfig, CnapiError, Result}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HeartbeatRequest`, `HeartbeatResponse`, `RegistrationRequest`, and `StatusUpdateRequest` [INFO] [stdout] --> cn-agent/src/cnapi/mod.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | pub use types::{HeartbeatRequest, HeartbeatResponse, RegistrationRequest, StatusUpdateRequest}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `QueueDefinition` and `TaskRunnerConfig` [INFO] [stdout] --> cn-agent/src/server.rs:10:25 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::task_agent::{QueueDefinition, TaskAgent, TaskRunnerConfig}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> cn-agent/src/server.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `worker::WorkerMessage` [INFO] [stdout] --> cn-agent/src/task_agent/mod.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub use worker::WorkerMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HeartbeatRequest`, `HeartbeatResponse`, and `RegistrationResponse` [INFO] [stdout] --> cn-agent/src/cnapi/client.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | HeartbeatRequest, HeartbeatResponse, RegistrationRequest, RegistrationResponse, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CnapiError` and `Result` [INFO] [stdout] --> cn-agent/src/cnapi/mod.rs:13:44 [INFO] [stdout] | [INFO] [stdout] 13 | pub use client::{CnapiClient, CnapiConfig, CnapiError, Result}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HeartbeatRequest`, `HeartbeatResponse`, `RegistrationRequest`, and `StatusUpdateRequest` [INFO] [stdout] --> cn-agent/src/cnapi/mod.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | pub use types::{HeartbeatRequest, HeartbeatResponse, RegistrationRequest, StatusUpdateRequest}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `QueueDefinition` and `TaskRunnerConfig` [INFO] [stdout] --> cn-agent/src/server.rs:10:25 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::task_agent::{QueueDefinition, TaskAgent, TaskRunnerConfig}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> cn-agent/src/server.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `worker::WorkerMessage` [INFO] [stdout] --> cn-agent/src/task_agent/mod.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub use worker::WorkerMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `update_sysinfo`, `post_with_retry`, `put_with_retry`, and `process_response` are never used [INFO] [stdout] --> cn-agent/src/cnapi/client.rs:198:18 [INFO] [stdout] | [INFO] [stdout] 134 | impl CnapiClient { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 198 | pub async fn update_sysinfo(&self, sysinfo: Sysinfo) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 273 | async fn post_with_retry(&self, url: &str, body: &T) -> Result [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 323 | async fn put_with_retry(&self, url: &str, body: &T) -> Result [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 373 | async fn process_response(&self, response: reqwest::Response, url: &str, attempt: u32) -> Result [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `cancel` is never used [INFO] [stdout] --> cn-agent/src/task_agent/agent.rs:170:18 [INFO] [stdout] | [INFO] [stdout] 60 | impl TaskAgent { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 170 | pub async fn cancel(&self, task_id: Uuid) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `task_id`, `task_name`, and `history` are never read [INFO] [stdout] --> cn-agent/src/task_agent/runner.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 59 | struct RunningTask { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 60 | /// Task ID. [INFO] [stdout] 61 | task_id: Uuid, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 62 | /// Task name. [INFO] [stdout] 63 | task_name: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 64 | /// Task history entry. [INFO] [stdout] 65 | history: TaskHistory, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `cancel` is never used [INFO] [stdout] --> cn-agent/src/task_agent/runner.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 78 | impl TaskRunner { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 225 | pub async fn cancel(&self, task_id: Uuid) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `send` is never used [INFO] [stdout] --> cn-agent/src/task_agent/worker.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 47 | impl WorkerMessage { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 76 | pub fn send(&self) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_shutting_down` is never used [INFO] [stdout] --> cn-agent/src/app.rs:415:18 [INFO] [stdout] | [INFO] [stdout] 66 | impl App { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 415 | pub async fn is_shutting_down(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `with_timeout`, `with_max_retries`, and `with_backoff` are never used [INFO] [stdout] --> cn-agent/src/cnapi/client.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 95 | impl CnapiConfig { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 105 | pub fn with_timeout(mut self, timeout_secs: u64) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 111 | pub fn with_max_retries(mut self, max_retries: u32) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 117 | pub fn with_backoff(mut self, initial_secs: u64, max_secs: u64) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `update_sysinfo`, `post_with_retry`, `put_with_retry`, and `process_response` are never used [INFO] [stdout] --> cn-agent/src/cnapi/client.rs:198:18 [INFO] [stdout] | [INFO] [stdout] 134 | impl CnapiClient { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 198 | pub async fn update_sysinfo(&self, sysinfo: Sysinfo) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 273 | async fn post_with_retry(&self, url: &str, body: &T) -> Result [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 323 | async fn put_with_retry(&self, url: &str, body: &T) -> Result [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 373 | async fn process_response(&self, response: reqwest::Response, url: &str, attempt: u32) -> Result [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RegistrationResponse` is never constructed [INFO] [stdout] --> cn-agent/src/cnapi/types.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct RegistrationResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `HeartbeatRequest` is never constructed [INFO] [stdout] --> cn-agent/src/cnapi/types.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | pub struct HeartbeatRequest { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `HeartbeatResponse` is never constructed [INFO] [stdout] --> cn-agent/src/cnapi/types.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 45 | pub struct HeartbeatResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `next_check_duration` is never used [INFO] [stdout] --> cn-agent/src/heartbeat.rs:228:18 [INFO] [stdout] | [INFO] [stdout] 45 | impl StatusReporter { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 228 | pub async fn next_check_duration(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `with_tasks` and `with_task` are never used [INFO] [stdout] --> cn-agent/src/task_agent/agent.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 27 | impl QueueDefinition { [INFO] [stdout] | -------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn with_tasks(mut self, task_names: Vec) -> Self { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 44 | pub fn with_task(mut self, task_name: impl Into) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_default_queue`, `cancel`, `queue_count`, and `get_queue_info` are never used [INFO] [stdout] --> cn-agent/src/task_agent/agent.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 60 | impl TaskAgent { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 103 | pub fn set_default_queue(&mut self, queue_name: impl Into) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 170 | pub async fn cancel(&self, task_id: Uuid) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 213 | pub async fn queue_count(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 218 | pub async fn get_queue_info(&self) -> HashMap { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `QueueInfo` is never constructed [INFO] [stdout] --> cn-agent/src/task_agent/agent.rs:243:12 [INFO] [stdout] | [INFO] [stdout] 243 | pub struct QueueInfo { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `task_id`, `task_name`, and `history` are never read [INFO] [stdout] --> cn-agent/src/task_agent/runner.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 59 | struct RunningTask { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 60 | /// Task ID. [INFO] [stdout] 61 | task_id: Uuid, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 62 | /// Task name. [INFO] [stdout] 63 | task_name: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 64 | /// Task history entry. [INFO] [stdout] 65 | history: TaskHistory, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `cancel` and `get_all_history` are never used [INFO] [stdout] --> cn-agent/src/task_agent/runner.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 78 | impl TaskRunner { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 225 | pub async fn cancel(&self, task_id: Uuid) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 284 | pub async fn get_all_history(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `WorkerMessage` is never used [INFO] [stdout] --> cn-agent/src/task_agent/worker.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | pub enum WorkerMessage { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `started`, `progress`, `completed`, `failed`, and `send` are never used [INFO] [stdout] --> cn-agent/src/task_agent/worker.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 47 | impl WorkerMessage { [INFO] [stdout] | ------------------ associated items in this implementation [INFO] [stdout] 48 | /// Create a new "started" message. [INFO] [stdout] 49 | pub fn started(task_id: Uuid) -> Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | pub fn progress(progress: u8, message: Option) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 62 | pub fn completed(result: Option) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn failed(error: impl Into) -> Self { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 76 | pub fn send(&self) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> cn-agent/src/heartbeat.rs:103:66 [INFO] [stdout] | [INFO] [stdout] 103 | DateTime::::from_timestamp(0, 0).unwrap_or_else(|| chrono::Utc::now()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `chrono::Utc::now` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> cn-agent/src/heartbeat.rs:103:66 [INFO] [stdout] | [INFO] [stdout] 103 | DateTime::::from_timestamp(0, 0).unwrap_or_else(|| chrono::Utc::now()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `chrono::Utc::now` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> cn-agent/src/task_agent/agent.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | all_history.sort_by(|a, b| b.created_at.cmp(&a.created_at)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 207 - all_history.sort_by(|a, b| b.created_at.cmp(&a.created_at)); [INFO] [stdout] 207 + all_history.sort_by_key(|b| std::cmp::Reverse(b.created_at)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> cn-agent/src/task_agent/agent.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | all_history.sort_by(|a, b| b.created_at.cmp(&a.created_at)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 207 - all_history.sort_by(|a, b| b.created_at.cmp(&a.created_at)); [INFO] [stdout] 207 + all_history.sort_by_key(|b| std::cmp::Reverse(b.created_at)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 14s [INFO] running `Command { std: "docker" "inspect" "e133478e0bcfd67eb4c6698803c289dd9986e11ce61b3fcc2cda56cf3be9f90a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e133478e0bcfd67eb4c6698803c289dd9986e11ce61b3fcc2cda56cf3be9f90a", kill_on_drop: false }` [INFO] [stdout] e133478e0bcfd67eb4c6698803c289dd9986e11ce61b3fcc2cda56cf3be9f90a