[INFO] cloning repository https://github.com/nuhtan/minecraft_monitor [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nuhtan/minecraft_monitor" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnuhtan%2Fminecraft_monitor", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnuhtan%2Fminecraft_monitor'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2a0a45d229ebc1180c104220953e4fdd559b84d2 [INFO] linting nuhtan/minecraft_monitor against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnuhtan%2Fminecraft_monitor" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/nuhtan/minecraft_monitor [INFO] finished tweaking git repo https://github.com/nuhtan/minecraft_monitor [INFO] tweaked toml for git repo https://github.com/nuhtan/minecraft_monitor written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/nuhtan/minecraft_monitor on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/nuhtan/minecraft_monitor already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8a82a10cf86cfb5514b3dca11ee63c1c4af21f021f54b64ccd1d79ef6d83cd00 [INFO] running `Command { std: "docker" "start" "-a" "8a82a10cf86cfb5514b3dca11ee63c1c4af21f021f54b64ccd1d79ef6d83cd00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8a82a10cf86cfb5514b3dca11ee63c1c4af21f021f54b64ccd1d79ef6d83cd00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a82a10cf86cfb5514b3dca11ee63c1c4af21f021f54b64ccd1d79ef6d83cd00", kill_on_drop: false }` [INFO] [stdout] 8a82a10cf86cfb5514b3dca11ee63c1c4af21f021f54b64ccd1d79ef6d83cd00 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c503f4e10d11e4f7b877ef8ccb89f90e07936a200a871e65c86cfa8864e26318 [INFO] running `Command { std: "docker" "start" "-a" "c503f4e10d11e4f7b877ef8ccb89f90e07936a200a871e65c86cfa8864e26318", kill_on_drop: false }` [INFO] [stderr] Checking minecraft_monitor v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/functions/configuration.rs:12:6 [INFO] [stdout] | [INFO] [stdout] 12 | ) -> Result< [INFO] [stdout] | ______^ [INFO] [stdout] 13 | | ( [INFO] [stdout] 14 | | Ipv4Addr, [INFO] [stdout] 15 | | u16, [INFO] [stdout] ... | [INFO] [stdout] 25 | | Error, [INFO] [stdout] 26 | | > { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/functions/configuration.rs:127:26 [INFO] [stdout] | [INFO] [stdout] 127 | if line != "" && !(&line[0..1] == "#") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(&line[0..1] != "#")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:101:8 [INFO] [stdout] | [INFO] [stdout] 101 | if download_config == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `download_config.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/functions/configuration.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 127 | if line != "" && !(&line[0..1] == "#") { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:136:24 [INFO] [stdout] | [INFO] [stdout] 136 | if root_location == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `root_location.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:142:24 [INFO] [stdout] | [INFO] [stdout] 142 | if address == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `address.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:147:24 [INFO] [stdout] | [INFO] [stdout] 147 | if port == None { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `Option::is_none()` instead: `port.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/functions/configuration.rs:12:6 [INFO] [stdout] | [INFO] [stdout] 12 | ) -> Result< [INFO] [stdout] | ______^ [INFO] [stdout] 13 | | ( [INFO] [stdout] 14 | | Ipv4Addr, [INFO] [stdout] 15 | | u16, [INFO] [stdout] ... | [INFO] [stdout] 25 | | Error, [INFO] [stdout] 26 | | > { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:152:24 [INFO] [stdout] | [INFO] [stdout] 152 | if web_index == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `web_index.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:157:24 [INFO] [stdout] | [INFO] [stdout] 157 | if gen_args == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `gen_args.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:164:24 [INFO] [stdout] | [INFO] [stdout] 164 | if jar_name == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `jar_name.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:169:24 [INFO] [stdout] | [INFO] [stdout] 169 | if min_ram == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `min_ram.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/functions/configuration.rs:127:26 [INFO] [stdout] | [INFO] [stdout] 127 | if line != "" && !(&line[0..1] == "#") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(&line[0..1] != "#")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:174:24 [INFO] [stdout] | [INFO] [stdout] 174 | if max_ram == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `max_ram.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:179:24 [INFO] [stdout] | [INFO] [stdout] 179 | if download_public == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `download_public.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:186:24 [INFO] [stdout] | [INFO] [stdout] 186 | if web_log == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `web_log.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:191:24 [INFO] [stdout] | [INFO] [stdout] 191 | if verbosity == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `verbosity.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:205:8 [INFO] [stdout] | [INFO] [stdout] 205 | if root_location == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `root_location.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:208:8 [INFO] [stdout] | [INFO] [stdout] 208 | if address == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `address.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:211:8 [INFO] [stdout] | [INFO] [stdout] 211 | if port == None { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `Option::is_none()` instead: `port.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:214:8 [INFO] [stdout] | [INFO] [stdout] 214 | if web_index == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `web_index.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:217:8 [INFO] [stdout] | [INFO] [stdout] 217 | if gen_args == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `gen_args.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:220:8 [INFO] [stdout] | [INFO] [stdout] 220 | if jar_name == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `jar_name.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:223:8 [INFO] [stdout] | [INFO] [stdout] 223 | if min_ram == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `min_ram.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:226:8 [INFO] [stdout] | [INFO] [stdout] 226 | if max_ram == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `max_ram.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:229:8 [INFO] [stdout] | [INFO] [stdout] 229 | if download_public == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `download_public.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:232:8 [INFO] [stdout] | [INFO] [stdout] 232 | if web_log == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `web_log.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:235:8 [INFO] [stdout] | [INFO] [stdout] 235 | if verbosity == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `verbosity.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:101:8 [INFO] [stdout] | [INFO] [stdout] 101 | if download_config == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `download_config.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/functions/configuration.rs:246:180 [INFO] [stdout] | [INFO] [stdout] 246 | ...("-o").arg(format!("public/manifest.json")).spawn().expect("Error?"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"public/manifest.json".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/functions/configuration.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 127 | if line != "" && !(&line[0..1] == "#") { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:136:24 [INFO] [stdout] | [INFO] [stdout] 136 | if root_location == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `root_location.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/functions/configuration.rs:257:27 [INFO] [stdout] | [INFO] [stdout] 257 | while files.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:142:24 [INFO] [stdout] | [INFO] [stdout] 142 | if address == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `address.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:147:24 [INFO] [stdout] | [INFO] [stdout] 147 | if port == None { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `Option::is_none()` instead: `port.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:152:24 [INFO] [stdout] | [INFO] [stdout] 152 | if web_index == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `web_index.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:157:24 [INFO] [stdout] | [INFO] [stdout] 157 | if gen_args == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `gen_args.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:164:24 [INFO] [stdout] | [INFO] [stdout] 164 | if jar_name == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `jar_name.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:169:24 [INFO] [stdout] | [INFO] [stdout] 169 | if min_ram == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `min_ram.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:174:24 [INFO] [stdout] | [INFO] [stdout] 174 | if max_ram == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `max_ram.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:179:24 [INFO] [stdout] | [INFO] [stdout] 179 | if download_public == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `download_public.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:186:24 [INFO] [stdout] | [INFO] [stdout] 186 | if web_log == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `web_log.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:191:24 [INFO] [stdout] | [INFO] [stdout] 191 | if verbosity == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `verbosity.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:205:8 [INFO] [stdout] | [INFO] [stdout] 205 | if root_location == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `root_location.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:208:8 [INFO] [stdout] | [INFO] [stdout] 208 | if address == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `address.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:211:8 [INFO] [stdout] | [INFO] [stdout] 211 | if port == None { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `Option::is_none()` instead: `port.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:214:8 [INFO] [stdout] | [INFO] [stdout] 214 | if web_index == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `web_index.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:217:8 [INFO] [stdout] | [INFO] [stdout] 217 | if gen_args == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `gen_args.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:220:8 [INFO] [stdout] | [INFO] [stdout] 220 | if jar_name == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `jar_name.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:223:8 [INFO] [stdout] | [INFO] [stdout] 223 | if min_ram == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `min_ram.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:226:8 [INFO] [stdout] | [INFO] [stdout] 226 | if max_ram == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `max_ram.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:229:8 [INFO] [stdout] | [INFO] [stdout] 229 | if download_public == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `download_public.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/functions/configuration.rs:274:39 [INFO] [stdout] | [INFO] [stdout] 274 | for (i, c) in file.chars().into_iter().rev().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `file.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:232:8 [INFO] [stdout] | [INFO] [stdout] 232 | if web_log == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `web_log.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/functions/configuration.rs:235:8 [INFO] [stdout] | [INFO] [stdout] 235 | if verbosity == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `verbosity.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/functions/configuration.rs:280:28 [INFO] [stdout] | [INFO] [stdout] 280 | if ext == "" { [INFO] [stdout] | ^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ext.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/functions/configuration.rs:246:180 [INFO] [stdout] | [INFO] [stdout] 246 | ...("-o").arg(format!("public/manifest.json")).spawn().expect("Error?"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"public/manifest.json".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/functions/configuration.rs:257:27 [INFO] [stdout] | [INFO] [stdout] 257 | while files.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:340:21 [INFO] [stdout] | [INFO] [stdout] 340 | Ok(addr) => return addr, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 340 ~ Ok(addr) => addr, [INFO] [stdout] 341 | Err(_) => panic!("Invalid ip address, found: {}", arg), [INFO] [stdout] 342 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:347:18 [INFO] [stdout] | [INFO] [stdout] 347 | Ok(p) => return p, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 347 ~ Ok(p) => p, [INFO] [stdout] 348 | Err(_) => panic!("Invalid port, found {}", arg), [INFO] [stdout] 349 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:355:9 [INFO] [stdout] | [INFO] [stdout] 355 | return arg [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 355 - return arg [INFO] [stdout] 355 + arg [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:362:9 [INFO] [stdout] | [INFO] [stdout] 362 | return arg [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 362 - return arg [INFO] [stdout] 362 + arg [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:371:21 [INFO] [stdout] | [INFO] [stdout] 371 | return arg; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 371 - return arg; [INFO] [stdout] 371 + arg [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/functions/configuration.rs:274:39 [INFO] [stdout] | [INFO] [stdout] 274 | for (i, c) in file.chars().into_iter().rev().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `file.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:381:5 [INFO] [stdout] | [INFO] [stdout] 381 | / return match arg.as_str() { [INFO] [stdout] 382 | | "off" => None, [INFO] [stdout] 383 | | _ => Some(arg), [INFO] [stdout] 384 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 381 ~ match arg.as_str() { [INFO] [stdout] 382 + "off" => None, [INFO] [stdout] 383 + _ => Some(arg), [INFO] [stdout] 384 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/functions/configuration.rs:280:28 [INFO] [stdout] | [INFO] [stdout] 280 | if ext == "" { [INFO] [stdout] | ^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ext.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:391:13 [INFO] [stdout] | [INFO] [stdout] 391 | / return match arg[0..arg.len() - 1].parse::() { [INFO] [stdout] 392 | | Ok(_) => arg, [INFO] [stdout] 393 | | Err(_) => panic!( [INFO] [stdout] 394 | | "Invalid number found for minimum allocated ram, found: {}", [INFO] [stdout] 395 | | &arg[0..arg.len() - 1] [INFO] [stdout] 396 | | ), [INFO] [stdout] 397 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 391 ~ match arg[0..arg.len() - 1].parse::() { [INFO] [stdout] 392 + Ok(_) => arg, [INFO] [stdout] 393 + Err(_) => panic!( [INFO] [stdout] 394 + "Invalid number found for minimum allocated ram, found: {}", [INFO] [stdout] 395 + &arg[0..arg.len() - 1] [INFO] [stdout] 396 + ), [INFO] [stdout] 397 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:410:13 [INFO] [stdout] | [INFO] [stdout] 410 | / return match arg[0..arg.len() - 1].parse::() { [INFO] [stdout] 411 | | Ok(_) => arg, [INFO] [stdout] 412 | | Err(_) => panic!( [INFO] [stdout] 413 | | "Invalid number found for maximum alloram, found: {}", [INFO] [stdout] 414 | | &arg[0..arg.len() - 1] [INFO] [stdout] 415 | | ), [INFO] [stdout] 416 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 410 ~ match arg[0..arg.len() - 1].parse::() { [INFO] [stdout] 411 + Ok(_) => arg, [INFO] [stdout] 412 + Err(_) => panic!( [INFO] [stdout] 413 + "Invalid number found for maximum alloram, found: {}", [INFO] [stdout] 414 + &arg[0..arg.len() - 1] [INFO] [stdout] 415 + ), [INFO] [stdout] 416 ~ } [INFO] [stdout] 417 | } [INFO] [stdout] ... [INFO] [stdout] 421 | ), [INFO] [stdout] 422 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:426:5 [INFO] [stdout] | [INFO] [stdout] 426 | / return match arg.as_str() { [INFO] [stdout] 427 | | "true" => true, [INFO] [stdout] 428 | | "false" => false, [INFO] [stdout] 429 | | _ => panic!("Boolean not found for web log, found: {}", arg), [INFO] [stdout] 430 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 426 ~ match arg.as_str() { [INFO] [stdout] 427 + "true" => true, [INFO] [stdout] 428 + "false" => false, [INFO] [stdout] 429 + _ => panic!("Boolean not found for web log, found: {}", arg), [INFO] [stdout] 430 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:434:5 [INFO] [stdout] | [INFO] [stdout] 434 | / return match arg.as_str() { [INFO] [stdout] 435 | | "none" => Verbosity::None, [INFO] [stdout] 436 | | "mine" => Verbosity::Mine, [INFO] [stdout] 437 | | "web" => Verbosity::Web, [INFO] [stdout] 438 | | "mineweb" => Verbosity::MineWeb, [INFO] [stdout] 439 | | _ => panic!("Invalid parameter for verbosity found, found: {}", arg), [INFO] [stdout] 440 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 434 ~ match arg.as_str() { [INFO] [stdout] 435 + "none" => Verbosity::None, [INFO] [stdout] 436 + "mine" => Verbosity::Mine, [INFO] [stdout] 437 + "web" => Verbosity::Web, [INFO] [stdout] 438 + "mineweb" => Verbosity::MineWeb, [INFO] [stdout] 439 + _ => panic!("Invalid parameter for verbosity found, found: {}", arg), [INFO] [stdout] 440 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:444:5 [INFO] [stdout] | [INFO] [stdout] 444 | / return match arg.as_str() { [INFO] [stdout] 445 | | "true" => true, [INFO] [stdout] 446 | | "false" => false, [INFO] [stdout] 447 | | _ => panic!( [INFO] [stdout] ... | [INFO] [stdout] 450 | | ), [INFO] [stdout] 451 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 444 ~ match arg.as_str() { [INFO] [stdout] 445 + "true" => true, [INFO] [stdout] 446 + "false" => false, [INFO] [stdout] 447 + _ => panic!( [INFO] [stdout] 448 + "Boolean not found for download web directory, found: {}", [INFO] [stdout] 449 + arg [INFO] [stdout] 450 + ), [INFO] [stdout] 451 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:340:21 [INFO] [stdout] | [INFO] [stdout] 340 | Ok(addr) => return addr, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 340 ~ Ok(addr) => addr, [INFO] [stdout] 341 | Err(_) => panic!("Invalid ip address, found: {}", arg), [INFO] [stdout] 342 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/minecraft_related.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return true; [INFO] [stdout] 13 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:347:18 [INFO] [stdout] | [INFO] [stdout] 347 | Ok(p) => return p, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 347 ~ Ok(p) => p, [INFO] [stdout] 348 | Err(_) => panic!("Invalid port, found {}", arg), [INFO] [stdout] 349 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:355:9 [INFO] [stdout] | [INFO] [stdout] 355 | return arg [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 355 - return arg [INFO] [stdout] 355 + arg [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:362:9 [INFO] [stdout] | [INFO] [stdout] 362 | return arg [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 362 - return arg [INFO] [stdout] 362 + arg [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:371:21 [INFO] [stdout] | [INFO] [stdout] 371 | return arg; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 371 - return arg; [INFO] [stdout] 371 + arg [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:381:5 [INFO] [stdout] | [INFO] [stdout] 381 | / return match arg.as_str() { [INFO] [stdout] 382 | | "off" => None, [INFO] [stdout] 383 | | _ => Some(arg), [INFO] [stdout] 384 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 381 ~ match arg.as_str() { [INFO] [stdout] 382 + "off" => None, [INFO] [stdout] 383 + _ => Some(arg), [INFO] [stdout] 384 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/functions/minecraft_related.rs:40:19 [INFO] [stdout] | [INFO] [stdout] 40 | } else if &line_content[..] == "Closing Server\n" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use the original value instead: `line_content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:391:13 [INFO] [stdout] | [INFO] [stdout] 391 | / return match arg[0..arg.len() - 1].parse::() { [INFO] [stdout] 392 | | Ok(_) => arg, [INFO] [stdout] 393 | | Err(_) => panic!( [INFO] [stdout] 394 | | "Invalid number found for minimum allocated ram, found: {}", [INFO] [stdout] 395 | | &arg[0..arg.len() - 1] [INFO] [stdout] 396 | | ), [INFO] [stdout] 397 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 391 ~ match arg[0..arg.len() - 1].parse::() { [INFO] [stdout] 392 + Ok(_) => arg, [INFO] [stdout] 393 + Err(_) => panic!( [INFO] [stdout] 394 + "Invalid number found for minimum allocated ram, found: {}", [INFO] [stdout] 395 + &arg[0..arg.len() - 1] [INFO] [stdout] 396 + ), [INFO] [stdout] 397 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:410:13 [INFO] [stdout] | [INFO] [stdout] 410 | / return match arg[0..arg.len() - 1].parse::() { [INFO] [stdout] 411 | | Ok(_) => arg, [INFO] [stdout] 412 | | Err(_) => panic!( [INFO] [stdout] 413 | | "Invalid number found for maximum alloram, found: {}", [INFO] [stdout] 414 | | &arg[0..arg.len() - 1] [INFO] [stdout] 415 | | ), [INFO] [stdout] 416 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 410 ~ match arg[0..arg.len() - 1].parse::() { [INFO] [stdout] 411 + Ok(_) => arg, [INFO] [stdout] 412 + Err(_) => panic!( [INFO] [stdout] 413 + "Invalid number found for maximum alloram, found: {}", [INFO] [stdout] 414 + &arg[0..arg.len() - 1] [INFO] [stdout] 415 + ), [INFO] [stdout] 416 ~ } [INFO] [stdout] 417 | } [INFO] [stdout] ... [INFO] [stdout] 421 | ), [INFO] [stdout] 422 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/functions/minecraft_related.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 43 | } else if &line_content[..] == "You need to agree to the EULA in order to run the server. Go to eula.txt for more info.\n" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use the original value instead: `line_content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:426:5 [INFO] [stdout] | [INFO] [stdout] 426 | / return match arg.as_str() { [INFO] [stdout] 427 | | "true" => true, [INFO] [stdout] 428 | | "false" => false, [INFO] [stdout] 429 | | _ => panic!("Boolean not found for web log, found: {}", arg), [INFO] [stdout] 430 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 426 ~ match arg.as_str() { [INFO] [stdout] 427 + "true" => true, [INFO] [stdout] 428 + "false" => false, [INFO] [stdout] 429 + _ => panic!("Boolean not found for web log, found: {}", arg), [INFO] [stdout] 430 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:434:5 [INFO] [stdout] | [INFO] [stdout] 434 | / return match arg.as_str() { [INFO] [stdout] 435 | | "none" => Verbosity::None, [INFO] [stdout] 436 | | "mine" => Verbosity::Mine, [INFO] [stdout] 437 | | "web" => Verbosity::Web, [INFO] [stdout] 438 | | "mineweb" => Verbosity::MineWeb, [INFO] [stdout] 439 | | _ => panic!("Invalid parameter for verbosity found, found: {}", arg), [INFO] [stdout] 440 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 434 ~ match arg.as_str() { [INFO] [stdout] 435 + "none" => Verbosity::None, [INFO] [stdout] 436 + "mine" => Verbosity::Mine, [INFO] [stdout] 437 + "web" => Verbosity::Web, [INFO] [stdout] 438 + "mineweb" => Verbosity::MineWeb, [INFO] [stdout] 439 + _ => panic!("Invalid parameter for verbosity found, found: {}", arg), [INFO] [stdout] 440 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/configuration.rs:444:5 [INFO] [stdout] | [INFO] [stdout] 444 | / return match arg.as_str() { [INFO] [stdout] 445 | | "true" => true, [INFO] [stdout] 446 | | "false" => false, [INFO] [stdout] 447 | | _ => panic!( [INFO] [stdout] ... | [INFO] [stdout] 450 | | ), [INFO] [stdout] 451 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 444 ~ match arg.as_str() { [INFO] [stdout] 445 + "true" => true, [INFO] [stdout] 446 + "false" => false, [INFO] [stdout] 447 + _ => panic!( [INFO] [stdout] 448 + "Boolean not found for download web directory, found: {}", [INFO] [stdout] 449 + arg [INFO] [stdout] 450 + ), [INFO] [stdout] 451 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/minecraft_related.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return true; [INFO] [stdout] 13 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/functions/server_interactions.rs:50:19 [INFO] [stdout] | [INFO] [stdout] 50 | let mut log = format!("{{\"chat\": {{\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"{\"chat\": {\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/functions/minecraft_related.rs:40:19 [INFO] [stdout] | [INFO] [stdout] 40 | } else if &line_content[..] == "Closing Server\n" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use the original value instead: `line_content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/functions/minecraft_related.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 43 | } else if &line_content[..] == "You need to agree to the EULA in order to run the server. Go to eula.txt for more info.\n" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use the original value instead: `line_content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/server_interactions.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); [INFO] [stdout] 109 + "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `MinecraftServerState` which implements the `Copy` trait [INFO] [stdout] --> src/functions/server_interactions.rs:91:30 [INFO] [stdout] | [INFO] [stdout] 91 | let reference_mc_state = mc_state.lock().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mc_state.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/server_interactions.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 135 | return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); [INFO] [stdout] 135 + "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `MinecraftServerState` which implements the `Copy` trait [INFO] [stdout] --> src/functions/server_interactions.rs:118:30 [INFO] [stdout] | [INFO] [stdout] 118 | let reference_mc_state = mc_state.lock().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mc_state.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/functions/server_interactions.rs:50:19 [INFO] [stdout] | [INFO] [stdout] 50 | let mut log = format!("{{\"chat\": {{\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"{\"chat\": {\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/server_interactions.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); [INFO] [stdout] 150 + "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/server_interactions.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); // Change to return an error thing [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); // Change to return an error thing [INFO] [stdout] 152 + "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string()// Change to return an error thing [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/server_interactions.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); [INFO] [stdout] 109 + "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `MinecraftServerState` which implements the `Copy` trait [INFO] [stdout] --> src/functions/server_interactions.rs:91:30 [INFO] [stdout] | [INFO] [stdout] 91 | let reference_mc_state = mc_state.lock().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mc_state.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ServerSharedData` [INFO] [stdout] --> src/functions/shared_data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub fn new() -> ServerSharedData { [INFO] [stdout] 19 | | ServerSharedData { [INFO] [stdout] 20 | | server_output: Arc::new(Mutex::new(VecDeque::<(u32, String)>::new())), [INFO] [stdout] 21 | | current_player_count: Arc::new(Mutex::new(0)), [INFO] [stdout] ... | [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 17 + impl Default for ServerSharedData { [INFO] [stdout] 18 + fn default() -> Self { [INFO] [stdout] 19 + Self::new() [INFO] [stdout] 20 + } [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/server_interactions.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 135 | return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); [INFO] [stdout] 135 + "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `MinecraftServerState` which implements the `Copy` trait [INFO] [stdout] --> src/functions/server_interactions.rs:118:30 [INFO] [stdout] | [INFO] [stdout] 118 | let reference_mc_state = mc_state.lock().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mc_state.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/server_interactions.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); [INFO] [stdout] 150 + "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/functions/server_interactions.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); // Change to return an error thing [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string(); // Change to return an error thing [INFO] [stdout] 152 + "HTTP/1.1 201 Created\r\nContent-Type: text/plain\r\nConnection: Close".to_string()// Change to return an error thing [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ServerSharedData` [INFO] [stdout] --> src/functions/shared_data.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub fn new() -> ServerSharedData { [INFO] [stdout] 19 | | ServerSharedData { [INFO] [stdout] 20 | | server_output: Arc::new(Mutex::new(VecDeque::<(u32, String)>::new())), [INFO] [stdout] 21 | | current_player_count: Arc::new(Mutex::new(0)), [INFO] [stdout] ... | [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 17 + impl Default for ServerSharedData { [INFO] [stdout] 18 + fn default() -> Self { [INFO] [stdout] 19 + Self::new() [INFO] [stdout] 20 + } [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/functions/web_server.rs:72:78 [INFO] [stdout] | [INFO] [stdout] 72 | println!("\x1b[0;33m[\x1b[32m{}\x1b[0;33m]:\x1b[0m {}", peer_address.to_string(), request); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `MinecraftServerState` which implements the `Copy` trait [INFO] [stdout] --> src/functions/web_server.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | ref_state = start_state.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*start_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/functions/web_server.rs:114:32 [INFO] [stdout] | [INFO] [stdout] 114 | if request.len() > 10 as usize && &request[0..10] == "/api/send?" { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `10_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/functions/web_server.rs:72:78 [INFO] [stdout] | [INFO] [stdout] 72 | println!("\x1b[0;33m[\x1b[32m{}\x1b[0;33m]:\x1b[0m {}", peer_address.to_string(), request); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `MinecraftServerState` which implements the `Copy` trait [INFO] [stdout] --> src/functions/web_server.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | ref_state = start_state.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*start_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/functions/web_server.rs:166:6 [INFO] [stdout] | [INFO] [stdout] 166 | .expect(format!("Failed to read file: {}", path).as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to read file: {}", path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/functions/web_server.rs:114:32 [INFO] [stdout] | [INFO] [stdout] 114 | if request.len() > 10 as usize && &request[0..10] == "/api/send?" { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `10_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/functions/web_server.rs:166:6 [INFO] [stdout] | [INFO] [stdout] 166 | .expect(format!("Failed to read file: {}", path).as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to read file: {}", path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `web_log` [INFO] [stdout] --> src/bin/launch.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | web_log: bool, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_web_log` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv4Addr` which implements the `Copy` trait [INFO] [stdout] --> src/bin/launch.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | address.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `address` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u16` which implements the `Copy` trait [INFO] [stdout] --> src/bin/launch.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | port.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/bin/launch.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | web_log.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `web_log` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Verbosity` which implements the `Copy` trait [INFO] [stdout] --> src/bin/launch.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | verbosity.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `verbosity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/bin/launch.rs:61:1 [INFO] [stdout] | [INFO] [stdout] 61 | / fn launch( [INFO] [stdout] 62 | | shared_data: ServerSharedData, [INFO] [stdout] 63 | | address: Ipv4Addr, [INFO] [stdout] 64 | | port: u16, [INFO] [stdout] ... | [INFO] [stdout] 71 | | verbosity: Verbosity, [INFO] [stdout] 72 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/launch.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 89 | if gen_args == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `gen_args.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bin/launch.rs:91:19 [INFO] [stdout] | [INFO] [stdout] 91 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 92 | | format!("-Xms{}", min_ram).as_str(), [INFO] [stdout] 93 | | format!("-Xmx{}", max_ram).as_str(), [INFO] [stdout] 94 | | "-XX:+UseG1GC", [INFO] [stdout] ... | [INFO] [stdout] 97 | | "nogui", [INFO] [stdout] 98 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 91 ~ .args([ [INFO] [stdout] 92 + format!("-Xms{}", min_ram).as_str(), [INFO] [stdout] 93 + format!("-Xmx{}", max_ram).as_str(), [INFO] [stdout] 94 + "-XX:+UseG1GC", [INFO] [stdout] 95 + "-jar", [INFO] [stdout] 96 + format!("{}", jar_name).as_str(), [INFO] [stdout] 97 + "nogui", [INFO] [stdout] 98 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/bin/launch.rs:96:17 [INFO] [stdout] | [INFO] [stdout] 96 | format!("{}", jar_name).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `jar_name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Verbosity` which implements the `Copy` trait [INFO] [stdout] --> src/bin/launch.rs:125:28 [INFO] [stdout] | [INFO] [stdout] 125 | let output_verbosity = verbosity.clone(); // This might not be needed because COPY has been derived now [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `verbosity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/bin/launch.rs:154:24 [INFO] [stdout] | [INFO] [stdout] 154 | if line != "".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/bin/launch.rs:156:20 [INFO] [stdout] | [INFO] [stdout] 156 | if line != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Verbosity` which implements the `Copy` trait [INFO] [stdout] --> src/bin/launch.rs:175:27 [INFO] [stdout] | [INFO] [stdout] 175 | let input_verbosity = verbosity.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `verbosity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/launch.rs:200:21 [INFO] [stdout] | [INFO] [stdout] 200 | cmd = cmd + "\n"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `cmd += "\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `web_log` [INFO] [stdout] --> src/bin/launch.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | web_log: bool, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_web_log` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Ipv4Addr` which implements the `Copy` trait [INFO] [stdout] --> src/bin/launch.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | address.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `address` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u16` which implements the `Copy` trait [INFO] [stdout] --> src/bin/launch.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | port.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/bin/launch.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | web_log.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `web_log` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Verbosity` which implements the `Copy` trait [INFO] [stdout] --> src/bin/launch.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | verbosity.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `verbosity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/bin/launch.rs:61:1 [INFO] [stdout] | [INFO] [stdout] 61 | / fn launch( [INFO] [stdout] 62 | | shared_data: ServerSharedData, [INFO] [stdout] 63 | | address: Ipv4Addr, [INFO] [stdout] 64 | | port: u16, [INFO] [stdout] ... | [INFO] [stdout] 71 | | verbosity: Verbosity, [INFO] [stdout] 72 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/launch.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 89 | if gen_args == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `gen_args.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bin/launch.rs:91:19 [INFO] [stdout] | [INFO] [stdout] 91 | .args(&[ [INFO] [stdout] | ___________________^ [INFO] [stdout] 92 | | format!("-Xms{}", min_ram).as_str(), [INFO] [stdout] 93 | | format!("-Xmx{}", max_ram).as_str(), [INFO] [stdout] 94 | | "-XX:+UseG1GC", [INFO] [stdout] ... | [INFO] [stdout] 97 | | "nogui", [INFO] [stdout] 98 | | ]) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 91 ~ .args([ [INFO] [stdout] 92 + format!("-Xms{}", min_ram).as_str(), [INFO] [stdout] 93 + format!("-Xmx{}", max_ram).as_str(), [INFO] [stdout] 94 + "-XX:+UseG1GC", [INFO] [stdout] 95 + "-jar", [INFO] [stdout] 96 + format!("{}", jar_name).as_str(), [INFO] [stdout] 97 + "nogui", [INFO] [stdout] 98 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/bin/launch.rs:96:17 [INFO] [stdout] | [INFO] [stdout] 96 | format!("{}", jar_name).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `jar_name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Verbosity` which implements the `Copy` trait [INFO] [stdout] --> src/bin/launch.rs:125:28 [INFO] [stdout] | [INFO] [stdout] 125 | let output_verbosity = verbosity.clone(); // This might not be needed because COPY has been derived now [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `verbosity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/bin/launch.rs:154:24 [INFO] [stdout] | [INFO] [stdout] 154 | if line != "".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/bin/launch.rs:156:20 [INFO] [stdout] | [INFO] [stdout] 156 | if line != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Verbosity` which implements the `Copy` trait [INFO] [stdout] --> src/bin/launch.rs:175:27 [INFO] [stdout] | [INFO] [stdout] 175 | let input_verbosity = verbosity.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `verbosity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/launch.rs:200:21 [INFO] [stdout] | [INFO] [stdout] 200 | cmd = cmd + "\n"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `cmd += "\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.46s [INFO] running `Command { std: "docker" "inspect" "c503f4e10d11e4f7b877ef8ccb89f90e07936a200a871e65c86cfa8864e26318", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c503f4e10d11e4f7b877ef8ccb89f90e07936a200a871e65c86cfa8864e26318", kill_on_drop: false }` [INFO] [stdout] c503f4e10d11e4f7b877ef8ccb89f90e07936a200a871e65c86cfa8864e26318