[INFO] cloning repository https://github.com/nuggetInc/advent_of_code [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nuggetInc/advent_of_code" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FnuggetInc%2Fadvent_of_code", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FnuggetInc%2Fadvent_of_code'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 203b5acc58136a532c3c3a0ebeda53c2df5925e9 [INFO] linting nuggetInc/advent_of_code against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FnuggetInc%2Fadvent_of_code" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/nuggetInc/advent_of_code [INFO] finished tweaking git repo https://github.com/nuggetInc/advent_of_code [INFO] tweaked toml for git repo https://github.com/nuggetInc/advent_of_code written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/nuggetInc/advent_of_code on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/nuggetInc/advent_of_code already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded schannel v0.1.24 [INFO] [stderr] Downloaded ipnet v2.10.0 [INFO] [stderr] Downloaded redox_syscall v0.5.6 [INFO] [stderr] Downloaded cc v1.1.22 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2cb99297e4616921a21b030ccc203b525111942d8c12c70c9eea07051467bbc0 [INFO] running `Command { std: "docker" "start" "-a" "2cb99297e4616921a21b030ccc203b525111942d8c12c70c9eea07051467bbc0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2cb99297e4616921a21b030ccc203b525111942d8c12c70c9eea07051467bbc0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cb99297e4616921a21b030ccc203b525111942d8c12c70c9eea07051467bbc0", kill_on_drop: false }` [INFO] [stdout] 2cb99297e4616921a21b030ccc203b525111942d8c12c70c9eea07051467bbc0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bfd8367174682d77fe756092e76ae407fe40aacf8149275a6f39b3f6bb5d0a6d [INFO] running `Command { std: "docker" "start" "-a" "bfd8367174682d77fe756092e76ae407fe40aacf8149275a6f39b3f6bb5d0a6d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling cc v1.1.22 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking dtoa v1.0.9 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking dtoa-short v0.3.5 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking servo_arc v0.3.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking string_cache v0.8.7 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking ipnet v2.10.0 [INFO] [stderr] Checking ego-tree v0.6.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Compiling html5ever v0.27.0 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking regex v1.11.0 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling selectors v0.25.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Compiling markup5ever v0.12.1 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking cssparser v0.31.2 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking scraper v0.20.0 [INFO] [stderr] Checking aoc_core v0.1.0 (/opt/rustwide/workdir/aoc_core) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Day` [INFO] [stdout] --> aoc_core/src/execute/day.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self { [INFO] [stdout] 21 | | parts: BTreeMap::new(), [INFO] [stdout] 22 | | files: Vec::new(), [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for Day { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> aoc_core/src/execute/day.rs:43:56 [INFO] [stdout] | [INFO] [stdout] 43 | fs::read_to_string(input_file).map_err(|err| DayError::InputFileError(err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `DayError::InputFileError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> aoc_core/src/execute/day.rs:49:57 [INFO] [stdout] | [INFO] [stdout] 49 | fs::read_to_string(output_file).map_err(|err| DayError::OutputFileError(err))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `DayError::OutputFileError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> aoc_core/src/execute/part.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | solver: Box AocResult + RefUnwindSafe + 'static>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> aoc_core/src/execute/result/day.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | file_parts: Vec<(PathBuf, BTreeMap, Result>)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> aoc_core/src/execute/result/day.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 22 | file_parts: Vec<(PathBuf, BTreeMap, Result>)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Day` [INFO] [stdout] --> aoc_core/src/execute/day.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self { [INFO] [stdout] 21 | | parts: BTreeMap::new(), [INFO] [stdout] 22 | | files: Vec::new(), [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for Day { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> aoc_core/src/execute/day.rs:43:56 [INFO] [stdout] | [INFO] [stdout] 43 | fs::read_to_string(input_file).map_err(|err| DayError::InputFileError(err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `DayError::InputFileError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> aoc_core/src/execute/day.rs:49:57 [INFO] [stdout] | [INFO] [stdout] 49 | fs::read_to_string(output_file).map_err(|err| DayError::OutputFileError(err))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `DayError::OutputFileError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> aoc_core/src/execute/part.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | solver: Box AocResult + RefUnwindSafe + 'static>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> aoc_core/src/execute/result/day.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | file_parts: Vec<(PathBuf, BTreeMap, Result>)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> aoc_core/src/execute/result/day.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 22 | file_parts: Vec<(PathBuf, BTreeMap, Result>)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Year` [INFO] [stdout] --> aoc_core/src/execute/year.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Self { [INFO] [stdout] 12 | | Self { [INFO] [stdout] 13 | | days: BTreeMap::new(), [INFO] [stdout] 14 | | } [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for Year { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> aoc_core/src/id.rs:25:29 [INFO] [stdout] | [INFO] [stdout] 25 | fn clone(&self) -> Self { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 26 | | Self(self.0.clone(), PhantomData) [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> aoc_core/src/id.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | Self(self.0.clone(), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> aoc_core/src/id.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | / impl PartialOrd for Id { [INFO] [stdout] 61 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 62 | | self.0.partial_cmp(&other.0) [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 61 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 62 - self.0.partial_cmp(&other.0) [INFO] [stdout] 63 - } [INFO] [stdout] 61 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Year` [INFO] [stdout] --> aoc_core/src/execute/year.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Self { [INFO] [stdout] 12 | | Self { [INFO] [stdout] 13 | | days: BTreeMap::new(), [INFO] [stdout] 14 | | } [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for Year { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> aoc_core/src/id.rs:25:29 [INFO] [stdout] | [INFO] [stdout] 25 | fn clone(&self) -> Self { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 26 | | Self(self.0.clone(), PhantomData) [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> aoc_core/src/id.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | Self(self.0.clone(), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> aoc_core/src/id.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | / impl PartialOrd for Id { [INFO] [stdout] 61 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 62 | | self.0.partial_cmp(&other.0) [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 61 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 62 - self.0.partial_cmp(&other.0) [INFO] [stdout] 63 - } [INFO] [stdout] 61 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking year2022 v0.1.0 (/opt/rustwide/workdir/year2022) [INFO] [stderr] Checking year2023 v0.1.0 (/opt/rustwide/workdir/year2023) [INFO] [stderr] Checking year2024 v0.1.0 (/opt/rustwide/workdir/year2024) [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day01/mod.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 11 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 11 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day01/mod.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 27 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 27 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 27 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day02/mod.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 11 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 11 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day02/mod.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 32 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 32 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day03/mod.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 13 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day03/mod.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 32 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 32 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day04/mod.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 11 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 11 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day04/mod.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 37 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day05/mod.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 12 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day05/mod.rs:61:20 [INFO] [stdout] | [INFO] [stdout] 61 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 61 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 61 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day06/mod.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | fn find_marker(input: &String, size: usize) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 - fn find_marker(input: &String, size: usize) -> usize { [INFO] [stdout] 21 + fn find_marker(input: &str, size: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> year2022/src/day07/mod.rs:22:28 [INFO] [stdout] | [INFO] [stdout] 22 | directories.extend(directory.items.iter().filter_map(|(_, item)| match item { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 23 | | Item::Directory(directory) => Some(directory), [INFO] [stdout] 24 | | Item::File(_) => None, [INFO] [stdout] 25 | | })); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 22 ~ directories.extend(directory.items.values().filter_map(|item| match item { [INFO] [stdout] 23 + Item::Directory(directory) => Some(directory), [INFO] [stdout] 24 + Item::File(_) => None, [INFO] [stdout] 25 ~ })); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> year2022/src/day07/mod.rs:46:28 [INFO] [stdout] | [INFO] [stdout] 46 | directories.extend(directory.items.iter().filter_map(|(_, item)| match item { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 47 | | Item::Directory(directory) => Some(directory), [INFO] [stdout] 48 | | Item::File(_) => None, [INFO] [stdout] 49 | | })); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 ~ directories.extend(directory.items.values().filter_map(|item| match item { [INFO] [stdout] 47 + Item::Directory(directory) => Some(directory), [INFO] [stdout] 48 + Item::File(_) => None, [INFO] [stdout] 49 ~ })); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day07/mod.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | fn parse(input: &String) -> Directory { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 67 - fn parse(input: &String) -> Directory { [INFO] [stdout] 67 + fn parse(input: &str) -> Directory { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day08/mod.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | fn parse(input: &String) -> Grid { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - fn parse(input: &String) -> Grid { [INFO] [stdout] 11 + fn parse(input: &str) -> Grid { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day09/mod.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 13 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day01/mod.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 11 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 11 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day09/mod.rs:66:20 [INFO] [stdout] | [INFO] [stdout] 66 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 66 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day01/mod.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 27 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 27 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 27 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day02/mod.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 11 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 11 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day02/mod.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 32 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 32 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day03/mod.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 13 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day03/mod.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 32 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 32 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day04/mod.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 11 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 11 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day04/mod.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 37 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day05/mod.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 12 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day05/mod.rs:61:20 [INFO] [stdout] | [INFO] [stdout] 61 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 61 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 61 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day10/mod.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 11 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 11 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day10/mod.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 42 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 42 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 42 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day06/mod.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | fn find_marker(input: &String, size: usize) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 - fn find_marker(input: &String, size: usize) -> usize { [INFO] [stdout] 21 + fn find_marker(input: &str, size: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> year2022/src/day07/mod.rs:22:28 [INFO] [stdout] | [INFO] [stdout] 22 | directories.extend(directory.items.iter().filter_map(|(_, item)| match item { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 23 | | Item::Directory(directory) => Some(directory), [INFO] [stdout] 24 | | Item::File(_) => None, [INFO] [stdout] 25 | | })); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 22 ~ directories.extend(directory.items.values().filter_map(|item| match item { [INFO] [stdout] 23 + Item::Directory(directory) => Some(directory), [INFO] [stdout] 24 + Item::File(_) => None, [INFO] [stdout] 25 ~ })); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> year2022/src/day07/mod.rs:46:28 [INFO] [stdout] | [INFO] [stdout] 46 | directories.extend(directory.items.iter().filter_map(|(_, item)| match item { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 47 | | Item::Directory(directory) => Some(directory), [INFO] [stdout] 48 | | Item::File(_) => None, [INFO] [stdout] 49 | | })); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 ~ directories.extend(directory.items.values().filter_map(|item| match item { [INFO] [stdout] 47 + Item::Directory(directory) => Some(directory), [INFO] [stdout] 48 + Item::File(_) => None, [INFO] [stdout] 49 ~ })); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day07/mod.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | fn parse(input: &String) -> Directory { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 67 - fn parse(input: &String) -> Directory { [INFO] [stdout] 67 + fn parse(input: &str) -> Directory { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day11/mod.rs:88:17 [INFO] [stdout] | [INFO] [stdout] 88 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 88 - fn parse(input: &String) -> Vec { [INFO] [stdout] 88 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day12/mod.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | fn parse(input: &String) -> Map { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 25 - fn parse(input: &String) -> Map { [INFO] [stdout] 25 + fn parse(input: &str) -> Map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day08/mod.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | fn parse(input: &String) -> Grid { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - fn parse(input: &String) -> Grid { [INFO] [stdout] 11 + fn parse(input: &str) -> Grid { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> year2022/src/day12/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if position % self.width > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!position.is_multiple_of(self.width)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day13/mod.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 59 | fn parse_one(input: &String) -> Vec<(Value, Value)> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 59 - fn parse_one(input: &String) -> Vec<(Value, Value)> { [INFO] [stdout] 59 + fn parse_one(input: &str) -> Vec<(Value, Value)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day13/mod.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 77 | fn parse_two(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 77 - fn parse_two(input: &String) -> Vec { [INFO] [stdout] 77 + fn parse_two(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day14/mod.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | fn parse(input: &String) -> Vec> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 133 - fn parse(input: &String) -> Vec> { [INFO] [stdout] 133 + fn parse(input: &str) -> Vec> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day09/mod.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 13 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day15/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 74 - fn parse(input: &String) -> Vec { [INFO] [stdout] 74 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day09/mod.rs:66:20 [INFO] [stdout] | [INFO] [stdout] 66 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 66 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day16/mod.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | fn parse(input: &String) -> HashMap { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 54 - fn parse(input: &String) -> HashMap { [INFO] [stdout] 54 + fn parse(input: &str) -> HashMap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day10/mod.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 11 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 11 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day10/mod.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 42 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 42 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 42 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day11/mod.rs:88:17 [INFO] [stdout] | [INFO] [stdout] 88 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 88 - fn parse(input: &String) -> Vec { [INFO] [stdout] 88 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day12/mod.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | fn parse(input: &String) -> Map { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 25 - fn parse(input: &String) -> Map { [INFO] [stdout] 25 + fn parse(input: &str) -> Map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> year2022/src/day12/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if position % self.width > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!position.is_multiple_of(self.width)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day13/mod.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 59 | fn parse_one(input: &String) -> Vec<(Value, Value)> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 59 - fn parse_one(input: &String) -> Vec<(Value, Value)> { [INFO] [stdout] 59 + fn parse_one(input: &str) -> Vec<(Value, Value)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day13/mod.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 77 | fn parse_two(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 77 - fn parse_two(input: &String) -> Vec { [INFO] [stdout] 77 + fn parse_two(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day14/mod.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | fn parse(input: &String) -> Vec> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 133 - fn parse(input: &String) -> Vec> { [INFO] [stdout] 133 + fn parse(input: &str) -> Vec> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day15/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 74 - fn parse(input: &String) -> Vec { [INFO] [stdout] 74 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2022/src/day16/mod.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | fn parse(input: &String) -> HashMap { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 54 - fn parse(input: &String) -> HashMap { [INFO] [stdout] 54 + fn parse(input: &str) -> HashMap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day1/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | fn parse(input: &String) -> (Vec, Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn parse(input: &String) -> (Vec, Vec) { [INFO] [stdout] 12 + fn parse(input: &str) -> (Vec, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day10/mod.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | fn parse(input: &String) -> Grid { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 17 - fn parse(input: &String) -> Grid { [INFO] [stdout] 17 + fn parse(input: &str) -> Grid { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day1/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | fn parse(input: &String) -> (Vec, Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn parse(input: &String) -> (Vec, Vec) { [INFO] [stdout] 12 + fn parse(input: &str) -> (Vec, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day10/mod.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | fn parse(input: &String) -> Grid { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 17 - fn parse(input: &String) -> Grid { [INFO] [stdout] 17 + fn parse(input: &str) -> Grid { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> year2024/src/day10/mod.rs:226:9 [INFO] [stdout] | [INFO] [stdout] 226 | / return position.x >= 0 [INFO] [stdout] 227 | | && position.y >= 0 [INFO] [stdout] 228 | | && position.x < self.width [INFO] [stdout] 229 | | && position.y < self.height; [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 226 ~ position.x >= 0 [INFO] [stdout] 227 + && position.y >= 0 [INFO] [stdout] 228 + && position.x < self.width [INFO] [stdout] 229 ~ && position.y < self.height [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day11/mod.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | fn parse(input: &String) -> FxHashMap { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn parse(input: &String) -> FxHashMap { [INFO] [stdout] 13 + fn parse(input: &str) -> FxHashMap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> year2024/src/day11/mod.rs:31:40 [INFO] [stdout] | [INFO] [stdout] 31 | let power = 10_u64.pow((stone.ilog10() + 1) / 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `stone.ilog10().div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day12/mod.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | fn parse(input: &String) -> Grid { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 20 - fn parse(input: &String) -> Grid { [INFO] [stdout] 20 + fn parse(input: &str) -> Grid { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> year2024/src/day12/mod.rs:124:28 [INFO] [stdout] | [INFO] [stdout] 124 | if !grid [INFO] [stdout] | ____________________________^ [INFO] [stdout] 125 | | .get(position + direction) [INFO] [stdout] 126 | | .is_some_and(|tile| tile.0 == plant) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 124 ~ if grid [INFO] [stdout] 125 + .get(position + direction).is_none_or(|tile| tile.0 != plant) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> year2024/src/day12/mod.rs:127:32 [INFO] [stdout] | [INFO] [stdout] 127 | ... && !grid [INFO] [stdout] | __________________________^ [INFO] [stdout] 128 | | ... .get(position + direction.rotated_cw()) [INFO] [stdout] 129 | | ... .is_some_and(|tile| tile.0 == plant) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 127 ~ && grid [INFO] [stdout] 128 + .get(position + direction.rotated_cw()).is_none_or(|tile| tile.0 != plant) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> year2024/src/day12/mod.rs:138:32 [INFO] [stdout] | [INFO] [stdout] 138 | ... && !grid [INFO] [stdout] | __________________________^ [INFO] [stdout] 139 | | ... .get(position + direction + direction.rotated_cw()) [INFO] [stdout] 140 | | ... .is_some_and(|tile| tile.0 == plant) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 138 ~ && grid [INFO] [stdout] 139 + .get(position + direction + direction.rotated_cw()).is_none_or(|tile| tile.0 != plant) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> year2024/src/day12/mod.rs:130:25 [INFO] [stdout] | [INFO] [stdout] 130 | / { [INFO] [stdout] 131 | | sides += 1; [INFO] [stdout] 132 | | } else if grid [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> year2024/src/day12/mod.rs:141:25 [INFO] [stdout] | [INFO] [stdout] 141 | / { [INFO] [stdout] 142 | | sides += 1; [INFO] [stdout] 143 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> year2024/src/day12/mod.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | / return position.x >= 0 [INFO] [stdout] 284 | | && position.y >= 0 [INFO] [stdout] 285 | | && position.x < self.width [INFO] [stdout] 286 | | && position.y < self.height; [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 283 ~ position.x >= 0 [INFO] [stdout] 284 + && position.y >= 0 [INFO] [stdout] 285 + && position.x < self.width [INFO] [stdout] 286 ~ && position.y < self.height [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day13/mod.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | fn parse(input: &String) -> Vec<(Position, Position, Position)> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - fn parse(input: &String) -> Vec<(Position, Position, Position)> { [INFO] [stdout] 16 + fn parse(input: &str) -> Vec<(Position, Position, Position)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day14/mod.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | fn parse(input: &String) -> Vec<(Position, Position)> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - fn parse(input: &String) -> Vec<(Position, Position)> { [INFO] [stdout] 16 + fn parse(input: &str) -> Vec<(Position, Position)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day15/mod.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | fn parse_one(input: &String) -> (Position, Grid, Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - fn parse_one(input: &String) -> (Position, Grid, Vec) { [INFO] [stdout] 16 + fn parse_one(input: &str) -> (Position, Grid, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day15/mod.rs:45:21 [INFO] [stdout] | [INFO] [stdout] 45 | fn parse_two(input: &String) -> (Position, Grid, Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 45 - fn parse_two(input: &String) -> (Position, Grid, Vec) { [INFO] [stdout] 45 + fn parse_two(input: &str) -> (Position, Grid, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> year2024/src/day10/mod.rs:226:9 [INFO] [stdout] | [INFO] [stdout] 226 | / return position.x >= 0 [INFO] [stdout] 227 | | && position.y >= 0 [INFO] [stdout] 228 | | && position.x < self.width [INFO] [stdout] 229 | | && position.y < self.height; [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 226 ~ position.x >= 0 [INFO] [stdout] 227 + && position.y >= 0 [INFO] [stdout] 228 + && position.x < self.width [INFO] [stdout] 229 ~ && position.y < self.height [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day11/mod.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | fn parse(input: &String) -> FxHashMap { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn parse(input: &String) -> FxHashMap { [INFO] [stdout] 13 + fn parse(input: &str) -> FxHashMap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> year2024/src/day11/mod.rs:31:40 [INFO] [stdout] | [INFO] [stdout] 31 | let power = 10_u64.pow((stone.ilog10() + 1) / 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `stone.ilog10().div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> year2024/src/day15/mod.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | / if try_move_one(grid, new_position, direction) { [INFO] [stdout] 124 | | let c = *grid.get(position).unwrap(); [INFO] [stdout] 125 | | *grid.get_mut(new_position).unwrap() = c; [INFO] [stdout] 126 | | *grid.get_mut(position).unwrap() = '.'; [INFO] [stdout] ... | [INFO] [stdout] 130 | | false [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 122 ~ Some('O' | '@') [INFO] [stdout] 123 ~ if try_move_one(grid, new_position, direction) => { [INFO] [stdout] 124 | let c = *grid.get(position).unwrap(); [INFO] [stdout] ... [INFO] [stdout] 128 | true [INFO] [stdout] 129 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day12/mod.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | fn parse(input: &String) -> Grid { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 20 - fn parse(input: &String) -> Grid { [INFO] [stdout] 20 + fn parse(input: &str) -> Grid { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> year2024/src/day12/mod.rs:124:28 [INFO] [stdout] | [INFO] [stdout] 124 | if !grid [INFO] [stdout] | ____________________________^ [INFO] [stdout] 125 | | .get(position + direction) [INFO] [stdout] 126 | | .is_some_and(|tile| tile.0 == plant) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 124 ~ if grid [INFO] [stdout] 125 + .get(position + direction).is_none_or(|tile| tile.0 != plant) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> year2024/src/day12/mod.rs:127:32 [INFO] [stdout] | [INFO] [stdout] 127 | ... && !grid [INFO] [stdout] | __________________________^ [INFO] [stdout] 128 | | ... .get(position + direction.rotated_cw()) [INFO] [stdout] 129 | | ... .is_some_and(|tile| tile.0 == plant) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 127 ~ && grid [INFO] [stdout] 128 + .get(position + direction.rotated_cw()).is_none_or(|tile| tile.0 != plant) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> year2024/src/day12/mod.rs:138:32 [INFO] [stdout] | [INFO] [stdout] 138 | ... && !grid [INFO] [stdout] | __________________________^ [INFO] [stdout] 139 | | ... .get(position + direction + direction.rotated_cw()) [INFO] [stdout] 140 | | ... .is_some_and(|tile| tile.0 == plant) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 138 ~ && grid [INFO] [stdout] 139 + .get(position + direction + direction.rotated_cw()).is_none_or(|tile| tile.0 != plant) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> year2024/src/day12/mod.rs:130:25 [INFO] [stdout] | [INFO] [stdout] 130 | / { [INFO] [stdout] 131 | | sides += 1; [INFO] [stdout] 132 | | } else if grid [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> year2024/src/day12/mod.rs:141:25 [INFO] [stdout] | [INFO] [stdout] 141 | / { [INFO] [stdout] 142 | | sides += 1; [INFO] [stdout] 143 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> year2024/src/day15/mod.rs:358:9 [INFO] [stdout] | [INFO] [stdout] 358 | / return position.x >= 0 [INFO] [stdout] 359 | | && position.y >= 0 [INFO] [stdout] 360 | | && position.x < self.width [INFO] [stdout] 361 | | && position.y < self.height; [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 358 ~ position.x >= 0 [INFO] [stdout] 359 + && position.y >= 0 [INFO] [stdout] 360 + && position.x < self.width [INFO] [stdout] 361 ~ && position.y < self.height [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> year2024/src/day12/mod.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | / return position.x >= 0 [INFO] [stdout] 284 | | && position.y >= 0 [INFO] [stdout] 285 | | && position.x < self.width [INFO] [stdout] 286 | | && position.y < self.height; [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 283 ~ position.x >= 0 [INFO] [stdout] 284 + && position.y >= 0 [INFO] [stdout] 285 + && position.x < self.width [INFO] [stdout] 286 ~ && position.y < self.height [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day16/mod.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | fn parse(input: &String) -> (Vec, usize, usize) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 20 - fn parse(input: &String) -> (Vec, usize, usize) { [INFO] [stdout] 20 + fn parse(input: &str) -> (Vec, usize, usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day13/mod.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | fn parse(input: &String) -> Vec<(Position, Position, Position)> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - fn parse(input: &String) -> Vec<(Position, Position, Position)> { [INFO] [stdout] 16 + fn parse(input: &str) -> Vec<(Position, Position, Position)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day14/mod.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | fn parse(input: &String) -> Vec<(Position, Position)> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - fn parse(input: &String) -> Vec<(Position, Position)> { [INFO] [stdout] 16 + fn parse(input: &str) -> Vec<(Position, Position)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day01/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn parse(input: &String) -> Vec { [INFO] [stdout] 12 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day15/mod.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 16 | fn parse_one(input: &String) -> (Position, Grid, Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - fn parse_one(input: &String) -> (Position, Grid, Vec) { [INFO] [stdout] 16 + fn parse_one(input: &str) -> (Position, Grid, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> year2024/src/day16/mod.rs:388:9 [INFO] [stdout] | [INFO] [stdout] 388 | / return position.x >= 0 [INFO] [stdout] 389 | | && position.y >= 0 [INFO] [stdout] 390 | | && position.x < self.width [INFO] [stdout] 391 | | && position.y < self.height; [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 388 ~ position.x >= 0 [INFO] [stdout] 389 + && position.y >= 0 [INFO] [stdout] 390 + && position.x < self.width [INFO] [stdout] 391 ~ && position.y < self.height [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day15/mod.rs:45:21 [INFO] [stdout] | [INFO] [stdout] 45 | fn parse_two(input: &String) -> (Position, Grid, Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 45 - fn parse_two(input: &String) -> (Position, Grid, Vec) { [INFO] [stdout] 45 + fn parse_two(input: &str) -> (Position, Grid, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day2/mod.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | fn parse(input: &String) -> Vec> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn parse(input: &String) -> Vec> { [INFO] [stdout] 13 + fn parse(input: &str) -> Vec> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> year2024/src/day15/mod.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | / if try_move_one(grid, new_position, direction) { [INFO] [stdout] 124 | | let c = *grid.get(position).unwrap(); [INFO] [stdout] 125 | | *grid.get_mut(new_position).unwrap() = c; [INFO] [stdout] 126 | | *grid.get_mut(position).unwrap() = '.'; [INFO] [stdout] ... | [INFO] [stdout] 130 | | false [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 122 ~ Some('O' | '@') [INFO] [stdout] 123 ~ if try_move_one(grid, new_position, direction) => { [INFO] [stdout] 124 | let c = *grid.get(position).unwrap(); [INFO] [stdout] ... [INFO] [stdout] 128 | true [INFO] [stdout] 129 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day3/mod.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 13 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day3/mod.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 28 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 28 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day4/mod.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 15 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 15 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day4/mod.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 48 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 48 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day5/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> (BTreeMap>, Vec>) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> (BTreeMap>, Vec>) { [INFO] [stdout] 15 + fn parse(input: &str) -> (BTreeMap>, Vec>) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> year2024/src/day5/mod.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 29 | } else if line != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day02/mod.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - fn parse(input: &String) -> Vec { [INFO] [stdout] 14 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> year2024/src/day15/mod.rs:358:9 [INFO] [stdout] | [INFO] [stdout] 358 | / return position.x >= 0 [INFO] [stdout] 359 | | && position.y >= 0 [INFO] [stdout] 360 | | && position.x < self.width [INFO] [stdout] 361 | | && position.y < self.height; [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 358 ~ position.x >= 0 [INFO] [stdout] 359 + && position.y >= 0 [INFO] [stdout] 360 + && position.x < self.width [INFO] [stdout] 361 ~ && position.y < self.height [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day16/mod.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | fn parse(input: &String) -> (Vec, usize, usize) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 20 - fn parse(input: &String) -> (Vec, usize, usize) { [INFO] [stdout] 20 + fn parse(input: &str) -> (Vec, usize, usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day6/mod.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | fn parse(input: &String) -> (Grid, Position, Position) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 17 - fn parse(input: &String) -> (Grid, Position, Position) { [INFO] [stdout] 17 + fn parse(input: &str) -> (Grid, Position, Position) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> year2024/src/day6/mod.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | / return position.x >= 0 [INFO] [stdout] 215 | | && position.y >= 0 [INFO] [stdout] 216 | | && position.x < self.width [INFO] [stdout] 217 | | && position.y < self.height; [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 214 ~ position.x >= 0 [INFO] [stdout] 215 + && position.y >= 0 [INFO] [stdout] 216 + && position.x < self.width [INFO] [stdout] 217 ~ && position.y < self.height [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day7/mod.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | fn parse(input: &String) -> Vec<(u64, Vec)> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn parse(input: &String) -> Vec<(u64, Vec)> { [INFO] [stdout] 13 + fn parse(input: &str) -> Vec<(u64, Vec)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day8/mod.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | fn parse(input: &String) -> (Vec<(Position, char)>, Bounds) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 18 - fn parse(input: &String) -> (Vec<(Position, char)>, Bounds) { [INFO] [stdout] 18 + fn parse(input: &str) -> (Vec<(Position, char)>, Bounds) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> year2024/src/day8/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | antinode = antinode + diff [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `antinode += diff` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> year2024/src/day16/mod.rs:388:9 [INFO] [stdout] | [INFO] [stdout] 388 | / return position.x >= 0 [INFO] [stdout] 389 | | && position.y >= 0 [INFO] [stdout] 390 | | && position.x < self.width [INFO] [stdout] 391 | | && position.y < self.height; [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 388 ~ position.x >= 0 [INFO] [stdout] 389 + && position.y >= 0 [INFO] [stdout] 390 + && position.x < self.width [INFO] [stdout] 391 ~ && position.y < self.height [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day2/mod.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | fn parse(input: &String) -> Vec> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn parse(input: &String) -> Vec> { [INFO] [stdout] 13 + fn parse(input: &str) -> Vec> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> year2024/src/day8/mod.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | / return position.x >= 0 [INFO] [stdout] 146 | | && position.y >= 0 [INFO] [stdout] 147 | | && position.x < self.width [INFO] [stdout] 148 | | && position.y < self.height; [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 ~ position.x >= 0 [INFO] [stdout] 146 + && position.y >= 0 [INFO] [stdout] 147 + && position.x < self.width [INFO] [stdout] 148 ~ && position.y < self.height [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day9/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn parse(input: &String) -> Vec { [INFO] [stdout] 12 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day3/mod.rs:13:20 [INFO] [stdout] | [INFO] [stdout] 13 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 13 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day03/mod.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | fn parse(input: &String) -> (Vec, Vec>) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - fn parse(input: &String) -> (Vec, Vec>) { [INFO] [stdout] 14 + fn parse(input: &str) -> (Vec, Vec>) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day3/mod.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 28 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 28 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day4/mod.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 15 | fn part_one(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn part_one(input: &String) -> AocResult { [INFO] [stdout] 15 + fn part_one(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day4/mod.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 48 | fn part_two(input: &String) -> AocResult { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 - fn part_two(input: &String) -> AocResult { [INFO] [stdout] 48 + fn part_two(input: &str) -> AocResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day5/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> (BTreeMap>, Vec>) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> (BTreeMap>, Vec>) { [INFO] [stdout] 15 + fn parse(input: &str) -> (BTreeMap>, Vec>) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> year2024/src/day5/mod.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 29 | } else if line != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day04/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn parse(input: &String) -> Vec { [INFO] [stdout] 12 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day05/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> Almanac { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> Almanac { [INFO] [stdout] 15 + fn parse(input: &str) -> Almanac { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day06/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | fn parse(input: &String) -> Vec<(u64, u64)> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn parse(input: &String) -> Vec<(u64, u64)> { [INFO] [stdout] 12 + fn parse(input: &str) -> Vec<(u64, u64)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day07/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> Vec { [INFO] [stdout] 15 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day6/mod.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | fn parse(input: &String) -> (Grid, Position, Position) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 17 - fn parse(input: &String) -> (Grid, Position, Position) { [INFO] [stdout] 17 + fn parse(input: &str) -> (Grid, Position, Position) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day08/mod.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | fn parse(input: &String) -> (Vec, Vec<(usize, usize)>) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn parse(input: &String) -> (Vec, Vec<(usize, usize)>) { [INFO] [stdout] 13 + fn parse(input: &str) -> (Vec, Vec<(usize, usize)>) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day09/mod.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn parse(input: &String) -> Vec { [INFO] [stdout] 13 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day10/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> Map { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> Map { [INFO] [stdout] 15 + fn parse(input: &str) -> Map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day11/mod.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | fn parse(input: &String) -> (Vec, Vec, Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn parse(input: &String) -> (Vec, Vec, Vec) { [INFO] [stdout] 13 + fn parse(input: &str) -> (Vec, Vec, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day12/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn parse(input: &String) -> Vec { [INFO] [stdout] 12 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> year2024/src/day6/mod.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | / return position.x >= 0 [INFO] [stdout] 215 | | && position.y >= 0 [INFO] [stdout] 216 | | && position.x < self.width [INFO] [stdout] 217 | | && position.y < self.height; [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 214 ~ position.x >= 0 [INFO] [stdout] 215 + && position.y >= 0 [INFO] [stdout] 216 + && position.x < self.width [INFO] [stdout] 217 ~ && position.y < self.height [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day7/mod.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | fn parse(input: &String) -> Vec<(u64, Vec)> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn parse(input: &String) -> Vec<(u64, Vec)> { [INFO] [stdout] 13 + fn parse(input: &str) -> Vec<(u64, Vec)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day13/mod.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn parse(input: &String) -> Vec { [INFO] [stdout] 13 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day14/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> Map { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> Map { [INFO] [stdout] 15 + fn parse(input: &str) -> Map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day8/mod.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | fn parse(input: &String) -> (Vec<(Position, char)>, Bounds) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 18 - fn parse(input: &String) -> (Vec<(Position, char)>, Bounds) { [INFO] [stdout] 18 + fn parse(input: &str) -> (Vec<(Position, char)>, Bounds) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day15/mod.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | fn parse_one(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn parse_one(input: &String) -> Vec { [INFO] [stdout] 12 + fn parse_one(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day15/mod.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | fn parse_two(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 27 - fn parse_two(input: &String) -> Vec { [INFO] [stdout] 27 + fn parse_two(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day15/mod.rs:80:16 [INFO] [stdout] | [INFO] [stdout] 80 | fn hash(value: &String) -> u32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 - fn hash(value: &String) -> u32 { [INFO] [stdout] 80 + fn hash(value: &str) -> u32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day16/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> Map { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> Map { [INFO] [stdout] 15 + fn parse(input: &str) -> Map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> year2023/src/day16/mod.rs:22:30 [INFO] [stdout] | [INFO] [stdout] 22 | line.chars().map(|char| Tile::from(char)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Tile::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> year2023/src/day16/mod.rs:109:32 [INFO] [stdout] | [INFO] [stdout] 109 | Direction::Left if pos.index % self.width > 0 => Some(Position { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!pos.index.is_multiple_of(self.width)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> year2024/src/day8/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | antinode = antinode + diff [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `antinode += diff` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> year2024/src/day8/mod.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | / return position.x >= 0 [INFO] [stdout] 146 | | && position.y >= 0 [INFO] [stdout] 147 | | && position.x < self.width [INFO] [stdout] 148 | | && position.y < self.height; [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 ~ position.x >= 0 [INFO] [stdout] 146 + && position.y >= 0 [INFO] [stdout] 147 + && position.x < self.width [INFO] [stdout] 148 ~ && position.y < self.height [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day17/mod.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | fn parse(input: &String) -> Map { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 18 - fn parse(input: &String) -> Map { [INFO] [stdout] 18 + fn parse(input: &str) -> Map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2024/src/day9/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn parse(input: &String) -> Vec { [INFO] [stdout] 12 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day18/mod.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | fn parse(input: &String) -> Vec<(Direction, i32, Direction, i32)> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - fn parse(input: &String) -> Vec<(Direction, i32, Direction, i32)> { [INFO] [stdout] 14 + fn parse(input: &str) -> Vec<(Direction, i32, Direction, i32)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day19/mod.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | fn parse(input: &String) -> (BTreeMap, Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - fn parse(input: &String) -> (BTreeMap, Vec) { [INFO] [stdout] 14 + fn parse(input: &str) -> (BTreeMap, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day20/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> (BTreeMap, Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> (BTreeMap, Vec) { [INFO] [stdout] 15 + fn parse(input: &str) -> (BTreeMap, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day21/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> (Map, usize, usize) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> (Map, usize, usize) { [INFO] [stdout] 15 + fn parse(input: &str) -> (Map, usize, usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day01/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn parse(input: &String) -> Vec { [INFO] [stdout] 12 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day02/mod.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - fn parse(input: &String) -> Vec { [INFO] [stdout] 14 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking aoc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day03/mod.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | fn parse(input: &String) -> (Vec, Vec>) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - fn parse(input: &String) -> (Vec, Vec>) { [INFO] [stdout] 14 + fn parse(input: &str) -> (Vec, Vec>) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day04/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn parse(input: &String) -> Vec { [INFO] [stdout] 12 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day05/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> Almanac { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> Almanac { [INFO] [stdout] 15 + fn parse(input: &str) -> Almanac { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day06/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | fn parse(input: &String) -> Vec<(u64, u64)> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn parse(input: &String) -> Vec<(u64, u64)> { [INFO] [stdout] 12 + fn parse(input: &str) -> Vec<(u64, u64)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day07/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> Vec { [INFO] [stdout] 15 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day08/mod.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | fn parse(input: &String) -> (Vec, Vec<(usize, usize)>) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn parse(input: &String) -> (Vec, Vec<(usize, usize)>) { [INFO] [stdout] 13 + fn parse(input: &str) -> (Vec, Vec<(usize, usize)>) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day09/mod.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn parse(input: &String) -> Vec { [INFO] [stdout] 13 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day10/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> Map { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> Map { [INFO] [stdout] 15 + fn parse(input: &str) -> Map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day11/mod.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | fn parse(input: &String) -> (Vec, Vec, Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn parse(input: &String) -> (Vec, Vec, Vec) { [INFO] [stdout] 13 + fn parse(input: &str) -> (Vec, Vec, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day12/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn parse(input: &String) -> Vec { [INFO] [stdout] 12 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day13/mod.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | fn parse(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 - fn parse(input: &String) -> Vec { [INFO] [stdout] 13 + fn parse(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day14/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> Map { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> Map { [INFO] [stdout] 15 + fn parse(input: &str) -> Map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day15/mod.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | fn parse_one(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - fn parse_one(input: &String) -> Vec { [INFO] [stdout] 12 + fn parse_one(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day15/mod.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | fn parse_two(input: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 27 - fn parse_two(input: &String) -> Vec { [INFO] [stdout] 27 + fn parse_two(input: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day15/mod.rs:80:16 [INFO] [stdout] | [INFO] [stdout] 80 | fn hash(value: &String) -> u32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 - fn hash(value: &String) -> u32 { [INFO] [stdout] 80 + fn hash(value: &str) -> u32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day16/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> Map { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> Map { [INFO] [stdout] 15 + fn parse(input: &str) -> Map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> year2023/src/day16/mod.rs:22:30 [INFO] [stdout] | [INFO] [stdout] 22 | line.chars().map(|char| Tile::from(char)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Tile::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> year2023/src/day16/mod.rs:109:32 [INFO] [stdout] | [INFO] [stdout] 109 | Direction::Left if pos.index % self.width > 0 => Some(Position { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!pos.index.is_multiple_of(self.width)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day17/mod.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | fn parse(input: &String) -> Map { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 18 - fn parse(input: &String) -> Map { [INFO] [stdout] 18 + fn parse(input: &str) -> Map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day18/mod.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | fn parse(input: &String) -> Vec<(Direction, i32, Direction, i32)> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - fn parse(input: &String) -> Vec<(Direction, i32, Direction, i32)> { [INFO] [stdout] 14 + fn parse(input: &str) -> Vec<(Direction, i32, Direction, i32)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day19/mod.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | fn parse(input: &String) -> (BTreeMap, Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - fn parse(input: &String) -> (BTreeMap, Vec) { [INFO] [stdout] 14 + fn parse(input: &str) -> (BTreeMap, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day20/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> (BTreeMap, Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> (BTreeMap, Vec) { [INFO] [stdout] 15 + fn parse(input: &str) -> (BTreeMap, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> year2023/src/day21/mod.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(input: &String) -> (Map, usize, usize) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn parse(input: &String) -> (Map, usize, usize) { [INFO] [stdout] 15 + fn parse(input: &str) -> (Map, usize, usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 59.29s [INFO] running `Command { std: "docker" "inspect" "bfd8367174682d77fe756092e76ae407fe40aacf8149275a6f39b3f6bb5d0a6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bfd8367174682d77fe756092e76ae407fe40aacf8149275a6f39b3f6bb5d0a6d", kill_on_drop: false }` [INFO] [stdout] bfd8367174682d77fe756092e76ae407fe40aacf8149275a6f39b3f6bb5d0a6d