[INFO] cloning repository https://github.com/nsalguero/yabinero [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nsalguero/yabinero" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnsalguero%2Fyabinero", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnsalguero%2Fyabinero'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 34171b47086af773a84d227490081d187de018e1 [INFO] linting nsalguero/yabinero against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnsalguero%2Fyabinero" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/nsalguero/yabinero [INFO] finished tweaking git repo https://github.com/nsalguero/yabinero [INFO] tweaked toml for git repo https://github.com/nsalguero/yabinero written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/nsalguero/yabinero on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/nsalguero/yabinero already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded symphonia v0.5.4 [INFO] [stderr] Downloaded symphonia-bundle-mp3 v0.5.4 [INFO] [stderr] Downloaded xdg v2.5.2 [INFO] [stderr] Downloaded enum-iterator v2.1.0 [INFO] [stderr] Downloaded enum-iterator-derive v1.4.0 [INFO] [stderr] Downloaded preferences v2.0.0 [INFO] [stderr] Downloaded cmk v0.1.2 [INFO] [stderr] Downloaded gettext v0.4.0 [INFO] [stderr] Downloaded cmake v0.1.54 [INFO] [stderr] Downloaded hound v3.5.1 [INFO] [stderr] Downloaded claxon v0.4.3 [INFO] [stderr] Downloaded symphonia-core v0.5.4 [INFO] [stderr] Downloaded tr v0.1.11 [INFO] [stderr] Downloaded locale_config v0.3.0 [INFO] [stderr] Downloaded app_dirs2 v2.5.5 [INFO] [stderr] Downloaded symphonia-metadata v0.5.4 [INFO] [stderr] Downloaded fltk v1.5.9 [INFO] [stderr] Downloaded fltk-sys v1.5.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8fe65e2f0fbb2c533f3de4cf52fbe19d2979c385bc8e4d05eae297564d108e65 [INFO] running `Command { std: "docker" "start" "-a" "8fe65e2f0fbb2c533f3de4cf52fbe19d2979c385bc8e4d05eae297564d108e65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8fe65e2f0fbb2c533f3de4cf52fbe19d2979c385bc8e4d05eae297564d108e65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8fe65e2f0fbb2c533f3de4cf52fbe19d2979c385bc8e4d05eae297564d108e65", kill_on_drop: false }` [INFO] [stdout] 8fe65e2f0fbb2c533f3de4cf52fbe19d2979c385bc8e4d05eae297564d108e65 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 50c30af85abeff537cb49c83666df19d8100e0ac5c6b8dde982bc218b62c2d6a [INFO] running `Command { std: "docker" "start" "-a" "50c30af85abeff537cb49c83666df19d8100e0ac5c6b8dde982bc218b62c2d6a", kill_on_drop: false }` [INFO] [stderr] Checking cfg-if v1.0.1 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling cc v1.2.27 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking bytemuck v1.23.1 [INFO] [stderr] Compiling zerocopy v0.8.26 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking symphonia-core v0.5.4 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling cpal v0.15.3 [INFO] [stderr] Checking tinyvec v1.9.0 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking symphonia-metadata v0.5.4 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Compiling fltk-sys v1.5.9 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.4 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking gettext v0.4.0 [INFO] [stderr] Checking app_dirs2 v2.5.5 [INFO] [stderr] Checking symphonia v0.5.4 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking rand v0.9.1 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking tr v0.1.11 [INFO] [stderr] Checking rodio v0.20.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling enum-iterator-derive v1.4.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking locale_config v0.3.0 [INFO] [stderr] Checking enum-iterator v2.1.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking preferences v2.0.0 [INFO] [stderr] Checking fltk v1.5.9 [INFO] [stderr] Checking yabinero v1.69.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/gui/menu.rs:475:17 [INFO] [stdout] | [INFO] [stdout] 475 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/gui/menu.rs:476:18 [INFO] [stdout] | [INFO] [stdout] 476 | const HOMEPAGE: &'static str = env!("CARGO_PKG_HOMEPAGE"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/gui/menu.rs:475:17 [INFO] [stdout] | [INFO] [stdout] 475 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/gui/menu.rs:477:17 [INFO] [stdout] | [INFO] [stdout] 477 | const LICENSE: &'static str = env!("CARGO_PKG_LICENSE"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/gui/menu.rs:476:18 [INFO] [stdout] | [INFO] [stdout] 476 | const HOMEPAGE: &'static str = env!("CARGO_PKG_HOMEPAGE"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/gui/menu.rs:477:17 [INFO] [stdout] | [INFO] [stdout] 477 | const LICENSE: &'static str = env!("CARGO_PKG_LICENSE"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/engine/grid.rs:199:13 [INFO] [stdout] | [INFO] [stdout] 199 | result.push_str("-"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/engine/grid.rs:206:17 [INFO] [stdout] | [INFO] [stdout] 206 | result.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/engine/grid.rs:209:29 [INFO] [stdout] | [INFO] [stdout] 209 | None => result.push_str(" "), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/engine/grid.rs:199:13 [INFO] [stdout] | [INFO] [stdout] 199 | result.push_str("-"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/engine/grid.rs:206:17 [INFO] [stdout] | [INFO] [stdout] 206 | result.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/engine/grid.rs:209:29 [INFO] [stdout] | [INFO] [stdout] 209 | None => result.push_str(" "), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/engine/history.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | / if let Some(current) = self.current_item { [INFO] [stdout] 132 | | if current == i { [INFO] [stdout] 133 | | history.push_str(" <-"); [INFO] [stdout] 134 | | } [INFO] [stdout] 135 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 131 ~ if let Some(current) = self.current_item [INFO] [stdout] 132 ~ && current == i { [INFO] [stdout] 133 | history.push_str(" <-"); [INFO] [stdout] 134 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/engine/history.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | history.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `history.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/engine/history.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | / if let Some(current) = self.current_item { [INFO] [stdout] 132 | | if current == i { [INFO] [stdout] 133 | | history.push_str(" <-"); [INFO] [stdout] 134 | | } [INFO] [stdout] 135 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 131 ~ if let Some(current) = self.current_item [INFO] [stdout] 132 ~ && current == i { [INFO] [stdout] 133 | history.push_str(" <-"); [INFO] [stdout] 134 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/engine/history.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | history.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `history.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/engine/mod.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / if !self.grid.is_full() { [INFO] [stdout] 56 | | if !self.try_a_choice() { [INFO] [stdout] 57 | | grid_can_be_solved = self.backtrack_to_latest_choice(); [INFO] [stdout] 58 | | if !grid_can_be_solved { [INFO] [stdout] ... | [INFO] [stdout] 62 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 55 ~ if !self.grid.is_full() [INFO] [stdout] 56 ~ && !self.try_a_choice() { [INFO] [stdout] 57 | grid_can_be_solved = self.backtrack_to_latest_choice(); [INFO] [stdout] ... [INFO] [stdout] 60 | } [INFO] [stdout] 61 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/engine/mod.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / if !self.grid.is_full() { [INFO] [stdout] 56 | | if !self.try_a_choice() { [INFO] [stdout] 57 | | grid_can_be_solved = self.backtrack_to_latest_choice(); [INFO] [stdout] 58 | | if !grid_can_be_solved { [INFO] [stdout] ... | [INFO] [stdout] 62 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 55 ~ if !self.grid.is_full() [INFO] [stdout] 56 ~ && !self.try_a_choice() { [INFO] [stdout] 57 | grid_can_be_solved = self.backtrack_to_latest_choice(); [INFO] [stdout] ... [INFO] [stdout] 60 | } [INFO] [stdout] 61 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/engine/mod.rs:191:17 [INFO] [stdout] | [INFO] [stdout] 191 | / if self.grid.get(i, j).is_none() { [INFO] [stdout] 192 | | if let Some(value) = self.mandatory_value(i, j) { [INFO] [stdout] 193 | | if self.grid.can_put(i, j, value) { [INFO] [stdout] 194 | | self.put_a_mandatory_value(i, j, value); [INFO] [stdout] ... | [INFO] [stdout] 201 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 191 ~ if self.grid.get(i, j).is_none() [INFO] [stdout] 192 ~ && let Some(value) = self.mandatory_value(i, j) { [INFO] [stdout] 193 | if self.grid.can_put(i, j, value) { [INFO] [stdout] ... [INFO] [stdout] 199 | some_value_put = true; [INFO] [stdout] 200 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/engine/mod.rs:191:17 [INFO] [stdout] | [INFO] [stdout] 191 | / if self.grid.get(i, j).is_none() { [INFO] [stdout] 192 | | if let Some(value) = self.mandatory_value(i, j) { [INFO] [stdout] 193 | | if self.grid.can_put(i, j, value) { [INFO] [stdout] 194 | | self.put_a_mandatory_value(i, j, value); [INFO] [stdout] ... | [INFO] [stdout] 201 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 191 ~ if self.grid.get(i, j).is_none() [INFO] [stdout] 192 ~ && let Some(value) = self.mandatory_value(i, j) { [INFO] [stdout] 193 | if self.grid.can_put(i, j, value) { [INFO] [stdout] ... [INFO] [stdout] 199 | some_value_put = true; [INFO] [stdout] 200 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/engine/mod.rs:232:21 [INFO] [stdout] | [INFO] [stdout] 232 | / if i == current { [INFO] [stdout] 233 | | if let Some(bad_value) = item.new_value() { [INFO] [stdout] 234 | | let (x_axis, y_axis) = (item.x_axis(), item.y_axis()); [INFO] [stdout] 235 | | let other_value = bad_value.the_other(); [INFO] [stdout] ... | [INFO] [stdout] 242 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 232 ~ if i == current [INFO] [stdout] 233 ~ && let Some(bad_value) = item.new_value() { [INFO] [stdout] 234 | let (x_axis, y_axis) = (item.x_axis(), item.y_axis()); [INFO] [stdout] ... [INFO] [stdout] 240 | } [INFO] [stdout] 241 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/engine/mod.rs:232:21 [INFO] [stdout] | [INFO] [stdout] 232 | / if i == current { [INFO] [stdout] 233 | | if let Some(bad_value) = item.new_value() { [INFO] [stdout] 234 | | let (x_axis, y_axis) = (item.x_axis(), item.y_axis()); [INFO] [stdout] 235 | | let other_value = bad_value.the_other(); [INFO] [stdout] ... | [INFO] [stdout] 242 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 232 ~ if i == current [INFO] [stdout] 233 ~ && let Some(bad_value) = item.new_value() { [INFO] [stdout] 234 | let (x_axis, y_axis) = (item.x_axis(), item.y_axis()); [INFO] [stdout] ... [INFO] [stdout] 240 | } [INFO] [stdout] 241 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/gui/changing.rs:102:27 [INFO] [stdout] | [INFO] [stdout] 102 | for (_, boxes) in &changing.borrow().grids { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 102 - for (_, boxes) in &changing.borrow().grids { [INFO] [stdout] 102 + for boxes in changing.borrow().grids.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/changing.rs:103:46 [INFO] [stdout] | [INFO] [stdout] 103 | ChangingPart::hide_selected_grid(&boxes); [INFO] [stdout] | ^^^^^^ help: change this to: `boxes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/changing.rs:117:41 [INFO] [stdout] | [INFO] [stdout] 117 | ChangingPart::set_value(&changing, size, item, true); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `changing` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/gui/changing.rs:102:27 [INFO] [stdout] | [INFO] [stdout] 102 | for (_, boxes) in &changing.borrow().grids { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 102 - for (_, boxes) in &changing.borrow().grids { [INFO] [stdout] 102 + for boxes in changing.borrow().grids.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/changing.rs:103:46 [INFO] [stdout] | [INFO] [stdout] 103 | ChangingPart::hide_selected_grid(&boxes); [INFO] [stdout] | ^^^^^^ help: change this to: `boxes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/changing.rs:117:41 [INFO] [stdout] | [INFO] [stdout] 117 | ChangingPart::set_value(&changing, size, item, true); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `changing` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/changing.rs:132:41 [INFO] [stdout] | [INFO] [stdout] 132 | ChangingPart::set_value(&changing, size, item, false); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `changing` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/changing.rs:151:50 [INFO] [stdout] | [INFO] [stdout] 151 | ChangingPart::fill_selected_grid(&boxes, user_prefs, tx, difficulty, timer, changing); [INFO] [stdout] | ^^^^^^ help: change this to: `boxes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/changing.rs:153:50 [INFO] [stdout] | [INFO] [stdout] 153 | ChangingPart::hide_selected_grid(&boxes); [INFO] [stdout] | ^^^^^^ help: change this to: `boxes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/changing.rs:132:41 [INFO] [stdout] | [INFO] [stdout] 132 | ChangingPart::set_value(&changing, size, item, false); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `changing` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/gui/changing.rs:189:45 [INFO] [stdout] | [INFO] [stdout] 189 | if let Ok(mut img) = SvgImage::load(&Path::new("icons").join("pause.svg")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("icons").join("pause.svg")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/changing.rs:151:50 [INFO] [stdout] | [INFO] [stdout] 151 | ChangingPart::fill_selected_grid(&boxes, user_prefs, tx, difficulty, timer, changing); [INFO] [stdout] | ^^^^^^ help: change this to: `boxes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/changing.rs:153:50 [INFO] [stdout] | [INFO] [stdout] 153 | ChangingPart::hide_selected_grid(&boxes); [INFO] [stdout] | ^^^^^^ help: change this to: `boxes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/gui/changing.rs:189:45 [INFO] [stdout] | [INFO] [stdout] 189 | if let Ok(mut img) = SvgImage::load(&Path::new("icons").join("pause.svg")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("icons").join("pause.svg")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/gui/changing.rs:318:5 [INFO] [stdout] | [INFO] [stdout] 318 | fn add_event_handler(boxes: &Rc>>>, input: &mut Input, x_axis: u8, y_axis: u8, user_prefs: &Rc>, tx: &Sender, difficulty: Difficulty, timer: &Rc>, changing: &Rc>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/gui/changing.rs:318:5 [INFO] [stdout] | [INFO] [stdout] 318 | fn add_event_handler(boxes: &Rc>>>, input: &mut Input, x_axis: u8, y_axis: u8, user_prefs: &Rc>, tx: &Sender, difficulty: Difficulty, timer: &Rc>, changing: &Rc>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/gui/changing.rs:346:31 [INFO] [stdout] | [INFO] [stdout] 346 | } else if val == "" { [INFO] [stdout] | ^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `val.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/gui/changing.rs:346:31 [INFO] [stdout] | [INFO] [stdout] 346 | } else if val == "" { [INFO] [stdout] | ^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `val.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/changing.rs:414:54 [INFO] [stdout] | [INFO] [stdout] 414 | ChangingPart::hide_selected_grid(&boxes); [INFO] [stdout] | ^^^^^^ help: change this to: `boxes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/changing.rs:437:50 [INFO] [stdout] | [INFO] [stdout] 437 | ChangingPart::show_selected_grid(&boxes); [INFO] [stdout] | ^^^^^^ help: change this to: `boxes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/changing.rs:414:54 [INFO] [stdout] | [INFO] [stdout] 414 | ChangingPart::hide_selected_grid(&boxes); [INFO] [stdout] | ^^^^^^ help: change this to: `boxes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/changing.rs:437:50 [INFO] [stdout] | [INFO] [stdout] 437 | ChangingPart::show_selected_grid(&boxes); [INFO] [stdout] | ^^^^^^ help: change this to: `boxes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui/menu.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | / if user_prefs.borrow().sounds() { [INFO] [stdout] 57 | | if let Some(mut menu_item) = menu.find_item(&entry_label(&TopLevelMenu::Options, &Submenu::Sounds, None)) { [INFO] [stdout] 58 | | menu_item.set(); [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 56 ~ if user_prefs.borrow().sounds() [INFO] [stdout] 57 ~ && let Some(mut menu_item) = menu.find_item(&entry_label(&TopLevelMenu::Options, &Submenu::Sounds, None)) { [INFO] [stdout] 58 | menu_item.set(); [INFO] [stdout] 59 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui/menu.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | / if user_prefs.borrow().sounds() { [INFO] [stdout] 57 | | if let Some(mut menu_item) = menu.find_item(&entry_label(&TopLevelMenu::Options, &Submenu::Sounds, None)) { [INFO] [stdout] 58 | | menu_item.set(); [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 56 ~ if user_prefs.borrow().sounds() [INFO] [stdout] 57 ~ && let Some(mut menu_item) = menu.find_item(&entry_label(&TopLevelMenu::Options, &Submenu::Sounds, None)) { [INFO] [stdout] 58 | menu_item.set(); [INFO] [stdout] 59 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/gui/menu.rs:334:5 [INFO] [stdout] | [INFO] [stdout] 334 | result.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/gui/menu.rs:334:5 [INFO] [stdout] | [INFO] [stdout] 334 | result.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `load_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/gui/user_data.rs:25:24 [INFO] [stdout] | [INFO] [stdout] 23 | if load_result.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = load_result` [INFO] [stdout] 24 | UserPrefs { [INFO] [stdout] 25 | faves: load_result.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `load_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/gui/user_data.rs:25:24 [INFO] [stdout] | [INFO] [stdout] 23 | if load_result.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = load_result` [INFO] [stdout] 24 | UserPrefs { [INFO] [stdout] 25 | faves: load_result.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gui/user_data.rs:212:12 [INFO] [stdout] | [INFO] [stdout] 212 | if !save_result.is_ok() && show_error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `save_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui/user_data.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | / if color.len() == 3 { [INFO] [stdout] 223 | | if let Ok(red) = color[0].replace("(", "").trim().parse() { [INFO] [stdout] 224 | | if let Ok(green) = color[1].trim().parse() { [INFO] [stdout] 225 | | if let Ok(blue) = color[2].replace(")", "").trim().parse() { [INFO] [stdout] ... | [INFO] [stdout] 230 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 222 ~ if color.len() == 3 [INFO] [stdout] 223 ~ && let Ok(red) = color[0].replace("(", "").trim().parse() { [INFO] [stdout] 224 | if let Ok(green) = color[1].trim().parse() { [INFO] [stdout] ... [INFO] [stdout] 228 | } [INFO] [stdout] 229 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gui/user_data.rs:212:12 [INFO] [stdout] | [INFO] [stdout] 212 | if !save_result.is_ok() && show_error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `save_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui/user_data.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | / if let Ok(red) = color[0].replace("(", "").trim().parse() { [INFO] [stdout] 224 | | if let Ok(green) = color[1].trim().parse() { [INFO] [stdout] 225 | | if let Ok(blue) = color[2].replace(")", "").trim().parse() { [INFO] [stdout] 226 | | return Some(Color::from_rgb(red, green, blue)); [INFO] [stdout] ... | [INFO] [stdout] 229 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 223 ~ if let Ok(red) = color[0].replace("(", "").trim().parse() [INFO] [stdout] 224 ~ && let Ok(green) = color[1].trim().parse() { [INFO] [stdout] 225 | if let Ok(blue) = color[2].replace(")", "").trim().parse() { [INFO] [stdout] 226 | return Some(Color::from_rgb(red, green, blue)); [INFO] [stdout] 227 | } [INFO] [stdout] 228 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui/user_data.rs:224:17 [INFO] [stdout] | [INFO] [stdout] 224 | / if let Ok(green) = color[1].trim().parse() { [INFO] [stdout] 225 | | if let Ok(blue) = color[2].replace(")", "").trim().parse() { [INFO] [stdout] 226 | | return Some(Color::from_rgb(red, green, blue)); [INFO] [stdout] 227 | | } [INFO] [stdout] 228 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 224 ~ if let Ok(green) = color[1].trim().parse() [INFO] [stdout] 225 ~ && let Ok(blue) = color[2].replace(")", "").trim().parse() { [INFO] [stdout] 226 | return Some(Color::from_rgb(red, green, blue)); [INFO] [stdout] 227 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `load_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/gui/user_data.rs:275:21 [INFO] [stdout] | [INFO] [stdout] 274 | let score = if load_result.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = load_result` [INFO] [stdout] 275 | load_result.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui/user_data.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | / if color.len() == 3 { [INFO] [stdout] 223 | | if let Ok(red) = color[0].replace("(", "").trim().parse() { [INFO] [stdout] 224 | | if let Ok(green) = color[1].trim().parse() { [INFO] [stdout] 225 | | if let Ok(blue) = color[2].replace(")", "").trim().parse() { [INFO] [stdout] ... | [INFO] [stdout] 230 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 222 ~ if color.len() == 3 [INFO] [stdout] 223 ~ && let Ok(red) = color[0].replace("(", "").trim().parse() { [INFO] [stdout] 224 | if let Ok(green) = color[1].trim().parse() { [INFO] [stdout] ... [INFO] [stdout] 228 | } [INFO] [stdout] 229 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui/user_data.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | / if let Ok(red) = color[0].replace("(", "").trim().parse() { [INFO] [stdout] 224 | | if let Ok(green) = color[1].trim().parse() { [INFO] [stdout] 225 | | if let Ok(blue) = color[2].replace(")", "").trim().parse() { [INFO] [stdout] 226 | | return Some(Color::from_rgb(red, green, blue)); [INFO] [stdout] ... | [INFO] [stdout] 229 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 223 ~ if let Ok(red) = color[0].replace("(", "").trim().parse() [INFO] [stdout] 224 ~ && let Ok(green) = color[1].trim().parse() { [INFO] [stdout] 225 | if let Ok(blue) = color[2].replace(")", "").trim().parse() { [INFO] [stdout] 226 | return Some(Color::from_rgb(red, green, blue)); [INFO] [stdout] 227 | } [INFO] [stdout] 228 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui/user_data.rs:224:17 [INFO] [stdout] | [INFO] [stdout] 224 | / if let Ok(green) = color[1].trim().parse() { [INFO] [stdout] 225 | | if let Ok(blue) = color[2].replace(")", "").trim().parse() { [INFO] [stdout] 226 | | return Some(Color::from_rgb(red, green, blue)); [INFO] [stdout] 227 | | } [INFO] [stdout] 228 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 224 ~ if let Ok(green) = color[1].trim().parse() [INFO] [stdout] 225 ~ && let Ok(blue) = color[2].replace(")", "").trim().parse() { [INFO] [stdout] 226 | return Some(Color::from_rgb(red, green, blue)); [INFO] [stdout] 227 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `load_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/gui/user_data.rs:275:21 [INFO] [stdout] | [INFO] [stdout] 274 | let score = if load_result.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = load_result` [INFO] [stdout] 275 | load_result.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/gui/user_data.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 303 | result.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/gui/user_data.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 303 | result.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/user_data.rs:326:48 [INFO] [stdout] | [INFO] [stdout] 326 | let dur = BestScores::duration(&score); [INFO] [stdout] | ^^^^^^ help: change this to: `score` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gui/user_data.rs:376:12 [INFO] [stdout] | [INFO] [stdout] 376 | if !save_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `save_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/gui/user_data.rs:326:48 [INFO] [stdout] | [INFO] [stdout] 326 | let dur = BestScores::duration(&score); [INFO] [stdout] | ^^^^^^ help: change this to: `score` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gui/user_data.rs:376:12 [INFO] [stdout] | [INFO] [stdout] 376 | if !save_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `save_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/gui/mod.rs:70:42 [INFO] [stdout] | [INFO] [stdout] 70 | if let Ok(icon) = PngImage::load(&Path::new("icons").join("icon.png")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("icons").join("icon.png")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/gui/mod.rs:70:42 [INFO] [stdout] | [INFO] [stdout] 70 | if let Ok(icon) = PngImage::load(&Path::new("icons").join("icon.png")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("icons").join("icon.png")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/gui/mod.rs:123:41 [INFO] [stdout] | [INFO] [stdout] 123 | if let Ok(mut img) = SvgImage::load(&Path::new("icons").join(icon)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("icons").join(icon)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/gui/mod.rs:123:41 [INFO] [stdout] | [INFO] [stdout] 123 | if let Ok(mut img) = SvgImage::load(&Path::new("icons").join(icon)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("icons").join(icon)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 46 | loc_path.push(&format!("{}{}", env!("CARGO_PKG_NAME"), ".mo")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}{}", env!("CARGO_PKG_NAME"), ".mo")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 46 | loc_path.push(&format!("{}{}", env!("CARGO_PKG_NAME"), ".mo")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}{}", env!("CARGO_PKG_NAME"), ".mo")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 47s [INFO] running `Command { std: "docker" "inspect" "50c30af85abeff537cb49c83666df19d8100e0ac5c6b8dde982bc218b62c2d6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50c30af85abeff537cb49c83666df19d8100e0ac5c6b8dde982bc218b62c2d6a", kill_on_drop: false }` [INFO] [stdout] 50c30af85abeff537cb49c83666df19d8100e0ac5c6b8dde982bc218b62c2d6a