[INFO] cloning repository https://github.com/notmyst33d/schedapi [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/notmyst33d/schedapi" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnotmyst33d%2Fschedapi", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnotmyst33d%2Fschedapi'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ebe76320e541b032c78d76984505150909919237 [INFO] linting notmyst33d/schedapi against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnotmyst33d%2Fschedapi" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/notmyst33d/schedapi [INFO] finished tweaking git repo https://github.com/notmyst33d/schedapi [INFO] tweaked toml for git repo https://github.com/notmyst33d/schedapi written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/notmyst33d/schedapi on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/notmyst33d/schedapi already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rust-embed-utils v8.2.0 [INFO] [stderr] Downloaded walkdir v2.4.0 [INFO] [stderr] Downloaded http-body-util v0.1.0 [INFO] [stderr] Downloaded rust-embed-impl v8.2.0 [INFO] [stderr] Downloaded csv-core v0.1.11 [INFO] [stderr] Downloaded serde v1.0.195 [INFO] [stderr] Downloaded axum-core v0.4.2 [INFO] [stderr] Downloaded serde_derive v1.0.195 [INFO] [stderr] Downloaded serde_path_to_error v0.1.15 [INFO] [stderr] Downloaded toml v0.8.8 [INFO] [stderr] Downloaded hyper-util v0.1.2 [INFO] [stderr] Downloaded toml_edit v0.21.0 [INFO] [stderr] Downloaded tower-http v0.5.1 [INFO] [stderr] Downloaded winnow v0.5.34 [INFO] [stderr] Downloaded hyper v1.1.0 [INFO] [stderr] Downloaded h2 v0.4.1 [INFO] [stderr] Downloaded axum v0.7.3 [INFO] [stderr] Downloaded serde_json v1.0.111 [INFO] [stderr] Downloaded http v1.0.0 [INFO] [stderr] Downloaded utoipa-gen v4.2.0 [INFO] [stderr] Downloaded utoipa v4.2.0 [INFO] [stderr] Downloaded regex v1.10.2 [INFO] [stderr] Downloaded regex-automata v0.4.3 [INFO] [stderr] Downloaded libc v0.2.152 [INFO] [stderr] Downloaded csv v1.3.0 [INFO] [stderr] Downloaded rust-embed v8.2.0 [INFO] [stderr] Downloaded utoipa-swagger-ui v6.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] db15e39e9a91a65d9e98be04c2e9f06834c87fbc86a4999613c296812740c0f1 [INFO] running `Command { std: "docker" "start" "-a" "db15e39e9a91a65d9e98be04c2e9f06834c87fbc86a4999613c296812740c0f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "db15e39e9a91a65d9e98be04c2e9f06834c87fbc86a4999613c296812740c0f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db15e39e9a91a65d9e98be04c2e9f06834c87fbc86a4999613c296812740c0f1", kill_on_drop: false }` [INFO] [stdout] db15e39e9a91a65d9e98be04c2e9f06834c87fbc86a4999613c296812740c0f1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1bf97e02331454dce689b4ff9102bc2e27819cc8d0785cb05ce29f9308d47f14 [INFO] running `Command { std: "docker" "start" "-a" "1bf97e02331454dce689b4ff9102bc2e27819cc8d0785cb05ce29f9308d47f14", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking http v1.0.0 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling adler v1.0.2 [INFO] [stderr] Compiling miniz_oxide v0.7.1 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling cpufeatures v0.2.12 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling walkdir v2.4.0 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling aho-corasick v1.1.2 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Compiling flate2 v1.0.28 [INFO] [stderr] Checking http-body-util v0.1.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling axum-core v0.4.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Compiling zip v0.6.6 [INFO] [stderr] Compiling rust-embed-utils v8.2.0 [INFO] [stderr] Compiling axum v0.7.3 [INFO] [stderr] Checking winnow v0.5.34 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking tower-http v0.5.1 [INFO] [stderr] Compiling regex-automata v0.4.3 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling utoipa-gen v4.2.0 [INFO] [stderr] Compiling rust-embed-impl v8.2.0 [INFO] [stderr] Checking rust-embed v8.2.0 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Compiling regex v1.10.2 [INFO] [stderr] Compiling utoipa-swagger-ui v6.0.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.15 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking h2 v0.4.1 [INFO] [stderr] Checking toml_edit v0.21.0 [INFO] [stderr] Checking utoipa v4.2.0 [INFO] [stderr] Checking toml v0.8.8 [INFO] [stderr] Checking hyper v1.1.0 [INFO] [stderr] Checking hyper-util v0.1.2 [INFO] [stderr] Checking schedapi v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `empty` is never read [INFO] [stdout] --> src/models/portable_schedule_entry.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct PortableScheduleEntry { [INFO] [stdout] | --------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | pub empty: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PortableScheduleEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/api/schedule.rs:37:43 [INFO] [stdout] | [INFO] [stdout] 37 | even_odd_check = (even && request.week % 2 == 0) || (odd && request.week % 2 != 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `request.week.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/api/schedule.rs:37:77 [INFO] [stdout] | [INFO] [stdout] 37 | even_odd_check = (even && request.week % 2 == 0) || (odd && request.week % 2 != 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!request.week.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/models/portable_schedule_entry.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 42 | if !split.get(1).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `split.get(1).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `split.get(0)` [INFO] [stdout] --> src/models/portable_schedule_entry.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 35 | let start: u8 = split [INFO] [stdout] | _____________________^ [INFO] [stdout] 36 | | .get(0) [INFO] [stdout] | |_______________^ help: try: `split.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `empty` is never read [INFO] [stdout] --> src/models/portable_schedule_entry.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct PortableScheduleEntry { [INFO] [stdout] | --------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | pub empty: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PortableScheduleEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/api/schedule.rs:37:43 [INFO] [stdout] | [INFO] [stdout] 37 | even_odd_check = (even && request.week % 2 == 0) || (odd && request.week % 2 != 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `request.week.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/api/schedule.rs:37:77 [INFO] [stdout] | [INFO] [stdout] 37 | even_odd_check = (even && request.week % 2 == 0) || (odd && request.week % 2 != 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!request.week.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/models/portable_schedule_entry.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 42 | if !split.get(1).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `split.get(1).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `split.get(0)` [INFO] [stdout] --> src/models/portable_schedule_entry.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 35 | let start: u8 = split [INFO] [stdout] | _____________________^ [INFO] [stdout] 36 | | .get(0) [INFO] [stdout] | |_______________^ help: try: `split.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 06s [INFO] running `Command { std: "docker" "inspect" "1bf97e02331454dce689b4ff9102bc2e27819cc8d0785cb05ce29f9308d47f14", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1bf97e02331454dce689b4ff9102bc2e27819cc8d0785cb05ce29f9308d47f14", kill_on_drop: false }` [INFO] [stdout] 1bf97e02331454dce689b4ff9102bc2e27819cc8d0785cb05ce29f9308d47f14